From nobody Thu Dec 18 19:07:19 2025 Received: from laurent.telenet-ops.be (laurent.telenet-ops.be [195.130.137.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42809135A63 for ; Mon, 29 Jul 2024 09:26:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.130.137.89 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722245212; cv=none; b=fbErgIRRJQvMpY6xTxYAcNKjz7G5d+TDLOTzzNGMMgAb3b5rtDdoPRSm27oFCK2H9riRTKSTcHEyS0lsbHUWwa8cE1/t9KNyY9iarx74kgy/+XZl06UF1MncpSR2wkZCJqr20nkWtz2Ql3CWvg+wbgbjX82zIUlrEti8ipzGRBU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722245212; c=relaxed/simple; bh=WiVYHby0gDFIsydXvgNrz6vK7ZT0j27BIyNpOfhYHi0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=bnzdIsL+FEUUAiUhmTSWlsVgB0qzdY0GIB2w2YiTnI99FK0mG+ELdYUrW0TfUvfe4Aba3smYxYYRcdtxgkCU+ZXm5t7LrrqA2AQbHPG2gF8gvcV6SAIfdRjFg1YSNxqB3h6lpNI/RRa0EIISG0RaOtIT0CxUrndJTUAT6ddOM6w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=glider.be; spf=none smtp.mailfrom=linux-m68k.org; arc=none smtp.client-ip=195.130.137.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=glider.be Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux-m68k.org Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed80:4441:3808:f850:4280]) by laurent.telenet-ops.be with bizsmtp id tMSc2C0030ZURL201MScHA; Mon, 29 Jul 2024 11:26:42 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1sYMdw-003sUd-Sq; Mon, 29 Jul 2024 11:26:36 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1sYMeJ-009LXV-Uh; Mon, 29 Jul 2024 11:26:35 +0200 From: Geert Uytterhoeven To: Lucas De Marchi , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Ashutosh Dixit , Umesh Nerlige Ramappa , =?UTF-8?q?Jos=C3=A9=20Roberto=20de=20Souza?= Cc: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] drm/xe/oa/uapi: Make bit masks unsigned Date: Mon, 29 Jul 2024 11:26:34 +0200 Message-Id: <20240729092634.2227611-1-geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable When building with gcc-5: In function =E2=80=98decode_oa_format.isra.26=E2=80=99, inlined from =E2=80=98xe_oa_set_prop_oa_format=E2=80=99 at drivers/gpu/drm= /xe/xe_oa.c:1664:6: ././include/linux/compiler_types.h:510:38: error: call to =E2=80=98__co= mpiletime_assert_1336=E2=80=99 declared with attribute error: FIELD_GET: ma= sk is not constant [...] ./include/linux/bitfield.h:155:3: note: in expansion of macro =E2=80=98= __BF_FIELD_CHECK=E2=80=99 __BF_FIELD_CHECK(_mask, _reg, 0U, "FIELD_GET: "); \ ^ drivers/gpu/drm/xe/xe_oa.c:1573:18: note: in expansion of macro =E2=80= =98FIELD_GET=E2=80=99 u32 bc_report =3D FIELD_GET(DRM_XE_OA_FORMAT_MASK_BC_REPORT, fmt); ^ Fixes: b6fd51c6211910b1 ("drm/xe/oa/uapi: Define and parse OA stream proper= ties") Signed-off-by: Geert Uytterhoeven Reviewed-by: Lucas De Marchi --- Compile-tested only. --- include/uapi/drm/xe_drm.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h index 19619d4952a863f7..db232a25189eba9f 100644 --- a/include/uapi/drm/xe_drm.h +++ b/include/uapi/drm/xe_drm.h @@ -1590,10 +1590,10 @@ enum drm_xe_oa_property_id { * b. Counter select c. Counter size and d. BC report. Also refer to the * oa_formats array in drivers/gpu/drm/xe/xe_oa.c. */ -#define DRM_XE_OA_FORMAT_MASK_FMT_TYPE (0xff << 0) -#define DRM_XE_OA_FORMAT_MASK_COUNTER_SEL (0xff << 8) -#define DRM_XE_OA_FORMAT_MASK_COUNTER_SIZE (0xff << 16) -#define DRM_XE_OA_FORMAT_MASK_BC_REPORT (0xff << 24) +#define DRM_XE_OA_FORMAT_MASK_FMT_TYPE (0xffu << 0) +#define DRM_XE_OA_FORMAT_MASK_COUNTER_SEL (0xffu << 8) +#define DRM_XE_OA_FORMAT_MASK_COUNTER_SIZE (0xffu << 16) +#define DRM_XE_OA_FORMAT_MASK_BC_REPORT (0xffu << 24) =20 /** * @DRM_XE_OA_PROPERTY_OA_PERIOD_EXPONENT: Requests periodic OA unit --=20 2.34.1