From nobody Tue Feb 10 19:14:29 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C70798002A for ; Mon, 29 Jul 2024 05:22:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722230532; cv=none; b=uHCBdgrAXuMFnhp1cHm4lzhBS3eYbJe38ghzis5GvT2aO44wOC0dRl93c0LkaG/RgWzU2vA2PekBmPSsX6vYzg/N8aWsawrU0u/yDGGky4aio2eIkLIeROix40sMtb74ycloarGgIhG8wZDnDjd0GB3J8gR1szj/c6WXoIW7co0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722230532; c=relaxed/simple; bh=FqGoL1gIrG+6pQBWKG7TqPWVrmXfXg8wT0MmB/exNU0=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rRJBco46gwutDqgh8Hw0Gcz7bgSiw7gohNZVTk3HWy+PYrCtdd9eflM4J/rYon4LK/Mb7t3oSJZT8afF7rblXgjIamdYmjfxLTYHo+axP9qkYS0DRmMg/ZFvleMUhaWR01Y+8CQsJMIO0X7YMVELjV/bSKbtadjJtjZFE3ooQws= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=A1tUmCuk; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="A1tUmCuk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722230529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KaDV7paMve8+TDjLvnzLCW3finEF8AmwpTegyY1jZGA=; b=A1tUmCuk8jpGDOKluxWd/CZm/8TSuVvfPujj62BL6/Lp1xTRHRyrF7BOZAZzG9ui7OEBpZ p8I7BJ4RRibovhDjEZPoDJZpVAocfpPuYCxAkjlrhRpB10MWDB20b8/v9XFHPfpHw7JLKC Hh+S/U7c3i7/Lf0heHaKoDp84C0slj4= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-46-4q3-DfTlNDiLk3Kg7TdA7g-1; Mon, 29 Jul 2024 01:22:04 -0400 X-MC-Unique: 4q3-DfTlNDiLk3Kg7TdA7g-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8DA2E1944B32; Mon, 29 Jul 2024 05:22:03 +0000 (UTC) Received: from server.redhat.com (unknown [10.72.112.168]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9231A195605F; Mon, 29 Jul 2024 05:21:58 +0000 (UTC) From: Cindy Lu To: lulu@redhat.com, dtatulea@nvidia.com, mst@redhat.com, jasowang@redhat.com, parav@nvidia.com, sgarzare@redhat.com, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 1/3] vdpa: support set mac address from vdpa tool Date: Mon, 29 Jul 2024 13:20:45 +0800 Message-ID: <20240729052146.621924-2-lulu@redhat.com> In-Reply-To: <20240729052146.621924-1-lulu@redhat.com> References: <20240729052146.621924-1-lulu@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Content-Type: text/plain; charset="utf-8" Add new UAPI to support the mac address from vdpa tool Function vdpa_nl_cmd_dev_attr_set_doit() will get the new MAC address from the vdpa tool and then set it to the device. The usage is: vdpa dev set name vdpa_name mac **:**:**:**:**:** Here is example: root@L1# vdpa -jp dev config show vdpa0 { "config": { "vdpa0": { "mac": "82:4d:e9:5d:d7:e6", "link ": "up", "link_announce ": false, "mtu": 1500 } } } root@L1# vdpa dev set name vdpa0 mac 00:11:22:33:44:55 root@L1# vdpa -jp dev config show vdpa0 { "config": { "vdpa0": { "mac": "00:11:22:33:44:55", "link ": "up", "link_announce ": false, "mtu": 1500 } } } Signed-off-by: Cindy Lu --- drivers/vdpa/vdpa.c | 80 +++++++++++++++++++++++++++++++++++++++ include/linux/vdpa.h | 9 +++++ include/uapi/linux/vdpa.h | 1 + 3 files changed, 90 insertions(+) diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c index 8d391947eb8d..7d16f62540ed 100644 --- a/drivers/vdpa/vdpa.c +++ b/drivers/vdpa/vdpa.c @@ -1361,6 +1361,81 @@ static int vdpa_nl_cmd_dev_config_get_doit(struct sk= _buff *skb, struct genl_info return err; } =20 +static int vdpa_dev_net_device_attr_set(struct vdpa_device *vdev, + struct genl_info *info) +{ + struct vdpa_dev_set_config set_config =3D {}; + struct vdpa_mgmt_dev *mdev =3D vdev->mdev; + struct nlattr **nl_attrs =3D info->attrs; + const u8 *macaddr; + int err =3D -EINVAL; + + down_write(&vdev->cf_lock); + if (nl_attrs[VDPA_ATTR_DEV_NET_CFG_MACADDR]) { + set_config.mask |=3D BIT_ULL(VDPA_ATTR_DEV_NET_CFG_MACADDR); + macaddr =3D nla_data(nl_attrs[VDPA_ATTR_DEV_NET_CFG_MACADDR]); + + if (is_valid_ether_addr(macaddr)) { + ether_addr_copy(set_config.net.mac, macaddr); + memcpy(set_config.net.mac, macaddr, ETH_ALEN); + if (mdev->ops->dev_set_attr) { + err =3D mdev->ops->dev_set_attr(mdev, vdev, + &set_config); + } else { + NL_SET_ERR_MSG_FMT_MOD(info->extack, + "device does not support changing the MAC address"); + } + } else { + NL_SET_ERR_MSG_FMT_MOD(info->extack, + "Invalid MAC address"); + } + } + up_write(&vdev->cf_lock); + return err; +} + +static int vdpa_nl_cmd_dev_attr_set_doit(struct sk_buff *skb, + struct genl_info *info) +{ + struct vdpa_device *vdev; + struct device *dev; + const char *name; + u64 classes; + int err =3D 0; + + if (!info->attrs[VDPA_ATTR_DEV_NAME]) + return -EINVAL; + + name =3D nla_data(info->attrs[VDPA_ATTR_DEV_NAME]); + + down_write(&vdpa_dev_lock); + dev =3D bus_find_device(&vdpa_bus, NULL, name, vdpa_name_match); + if (!dev) { + NL_SET_ERR_MSG_MOD(info->extack, "device not found"); + err =3D -ENODEV; + goto dev_err; + } + vdev =3D container_of(dev, struct vdpa_device, dev); + if (!vdev->mdev) { + NL_SET_ERR_MSG_MOD(info->extack, "unmanaged vdpa device"); + err =3D -EINVAL; + goto mdev_err; + } + classes =3D vdpa_mgmtdev_get_classes(vdev->mdev, NULL); + if (classes & BIT_ULL(VIRTIO_ID_NET)) { + err =3D vdpa_dev_net_device_attr_set(vdev, info); + } else { + NL_SET_ERR_MSG_FMT_MOD(info->extack, "%s device not supported", + name); + } + +mdev_err: + put_device(dev); +dev_err: + up_write(&vdpa_dev_lock); + return err; +} + static int vdpa_dev_config_dump(struct device *dev, void *data) { struct vdpa_device *vdev =3D container_of(dev, struct vdpa_device, dev); @@ -1497,6 +1572,11 @@ static const struct genl_ops vdpa_nl_ops[] =3D { .doit =3D vdpa_nl_cmd_dev_stats_get_doit, .flags =3D GENL_ADMIN_PERM, }, + { + .cmd =3D VDPA_CMD_DEV_ATTR_SET, + .doit =3D vdpa_nl_cmd_dev_attr_set_doit, + .flags =3D GENL_ADMIN_PERM, + }, }; =20 static struct genl_family vdpa_nl_family __ro_after_init =3D { diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h index 7977ca03ac7a..2e7a30fe6b92 100644 --- a/include/linux/vdpa.h +++ b/include/linux/vdpa.h @@ -582,11 +582,20 @@ void vdpa_set_status(struct vdpa_device *vdev, u8 sta= tus); * @dev: vdpa device to remove * Driver need to remove the specified device by calling * _vdpa_unregister_device(). + * @dev_set_attr: change a vdpa device's attr after it was create + * @mdev: parent device to use for device + * @dev: vdpa device structure + * @config:Attributes to be set for the device. + * The driver needs to check the mask of the structure and then set + * the related information to the vdpa device. The driver must return= 0 + * if set successfully. */ struct vdpa_mgmtdev_ops { int (*dev_add)(struct vdpa_mgmt_dev *mdev, const char *name, const struct vdpa_dev_set_config *config); void (*dev_del)(struct vdpa_mgmt_dev *mdev, struct vdpa_device *dev); + int (*dev_set_attr)(struct vdpa_mgmt_dev *mdev, struct vdpa_device *dev, + const struct vdpa_dev_set_config *config); }; =20 /** diff --git a/include/uapi/linux/vdpa.h b/include/uapi/linux/vdpa.h index 842bf1201ac4..71edf2c70cc3 100644 --- a/include/uapi/linux/vdpa.h +++ b/include/uapi/linux/vdpa.h @@ -19,6 +19,7 @@ enum vdpa_command { VDPA_CMD_DEV_GET, /* can dump */ VDPA_CMD_DEV_CONFIG_GET, /* can dump */ VDPA_CMD_DEV_VSTATS_GET, + VDPA_CMD_DEV_ATTR_SET, }; =20 enum vdpa_attr { --=20 2.45.0 From nobody Tue Feb 10 19:14:29 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6812E163 for ; Mon, 29 Jul 2024 05:22:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722230542; cv=none; b=kMh/03Zcb7jn4Dga6pXi3y5Kpb0SEm24D8daDYVfFVAhgfhO0GuK4V0scdqOsrBA+K2doADLotydefo+O/MOXeR/+E7GvC7FaOuQjkFPlnjyDare3BBds/MkhDrMqVxkitMFWvbRQRHYgXYegydsDlJvkSDNPHHaAePyT9yyEEg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722230542; c=relaxed/simple; bh=3F4r8zbWDAULZmDTjyIijQog+qcyeV2Q81fOtJnZ2mk=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a5F15SeshAamAM7v0Y4RqYekAfuYRcOqIgz0ihcjHPvqI4gz9Hf9VeEF3pit7qGF/6BCwDe2nKcc2kX73z8IQqHK+Ui+AHqlaRwIk335E5jseh5EbRke/QaY87YA5rEgwkGa6/sJ3SKW82K6AFtbLOBump+mzLFu4MgHmCtCYew= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OLlQ84rs; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OLlQ84rs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722230539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/yAuVHIcu+Q+kzwM0Mf0bzl0dl3j4qxMTUhJ7TQ3QIg=; b=OLlQ84rsv0q2HHAGYT/eG05koVK7pSb/FKPyhdZY5MYPNl2O60JENeFEiZYUei1zEXxQ3n 0ywLIF6o/sIk+ljqKC/6o57AIOhIBa/r3C/nBVWLXhODlkTrqCyA+rkQLnkQjUslt/GTun X831/yQO2HJiVdw+t9gtNmqmx18EDbQ= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-61-ngwIEaHFN4Scz8rXEIyHWQ-1; Mon, 29 Jul 2024 01:22:14 -0400 X-MC-Unique: ngwIEaHFN4Scz8rXEIyHWQ-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AA99B19560B1; Mon, 29 Jul 2024 05:22:12 +0000 (UTC) Received: from server.redhat.com (unknown [10.72.112.168]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0DB08195605F; Mon, 29 Jul 2024 05:22:03 +0000 (UTC) From: Cindy Lu To: lulu@redhat.com, dtatulea@nvidia.com, mst@redhat.com, jasowang@redhat.com, parav@nvidia.com, sgarzare@redhat.com, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 2/3] vdpa_sim_net: Add the support of set mac address Date: Mon, 29 Jul 2024 13:20:46 +0800 Message-ID: <20240729052146.621924-3-lulu@redhat.com> In-Reply-To: <20240729052146.621924-1-lulu@redhat.com> References: <20240729052146.621924-1-lulu@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Content-Type: text/plain; charset="utf-8" Add the function to support setting the MAC address. For vdpa_sim_net, the driver will write the MAC address to the config space, and other devices can implement their own functions to support this. Signed-off-by: Cindy Lu --- drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/v= dpa_sim_net.c index cfe962911804..5baf934e685b 100644 --- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c @@ -414,6 +414,24 @@ static void vdpasim_net_get_config(struct vdpasim *vdp= asim, void *config) net_config->status =3D cpu_to_vdpasim16(vdpasim, VIRTIO_NET_S_LINK_UP); } =20 +static int vdpasim_net_set_attr(struct vdpa_mgmt_dev *mdev, struct vdpa_de= vice *dev, + const struct vdpa_dev_set_config *config) +{ + struct vdpasim *vdpasim =3D container_of(dev, struct vdpasim, vdpa); + struct virtio_net_config *vio_config =3D vdpasim->config; + + mutex_lock(&vdpasim->mutex); + + if (config->mask & (1 << VDPA_ATTR_DEV_NET_CFG_MACADDR)) { + ether_addr_copy(vio_config->mac, config->net.mac); + mutex_unlock(&vdpasim->mutex); + return 0; + } + + mutex_unlock(&vdpasim->mutex); + return -EINVAL; +} + static void vdpasim_net_setup_config(struct vdpasim *vdpasim, const struct vdpa_dev_set_config *config) { @@ -510,7 +528,8 @@ static void vdpasim_net_dev_del(struct vdpa_mgmt_dev *m= dev, =20 static const struct vdpa_mgmtdev_ops vdpasim_net_mgmtdev_ops =3D { .dev_add =3D vdpasim_net_dev_add, - .dev_del =3D vdpasim_net_dev_del + .dev_del =3D vdpasim_net_dev_del, + .dev_set_attr =3D vdpasim_net_set_attr }; =20 static struct virtio_device_id id_table[] =3D { --=20 2.45.0 From nobody Tue Feb 10 19:14:29 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB11884FA0 for ; Mon, 29 Jul 2024 05:22:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722230546; cv=none; b=urBAT5Ipq/nlkevOZWfsJAiBLLiNVKary4ID7VvUL/7ViLBYW/WuGb0m7Oss0OHaeEn0360CH0WOtQ0KgWopsKjV5ihWKiHLyjpE4ctKQN8kOuzCPtr0v6Sv/JxOEi1DXTkGBmUx3dhSsF2rqVoB5+SO2DQEzvNVBCTtcfzQvfA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722230546; c=relaxed/simple; bh=gtbtsPPrhBlsHf9S+0HR57Br4O4cC9TR/0wWshqIE2E=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VT3qXCzl9MbLjBzsUIBz/w14md4WLUcBIUVdDbZgCFossEDL6zQs9UUg5H3H58ho+9sEWi+d++pCZG0g7QaE8ap6zxbuRAmnCZGl+EqXjrJBw/jsrL0cVsPH8/97KA8nTBPx4l7orCmH/NEcAcvlLf9VNH0KNhaT3djMN3a7O9w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NG+QCVKm; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NG+QCVKm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722230544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PxloFJjHKztR9LybQruoy6tmYRAm4Ks4H6Vbpd2cuSQ=; b=NG+QCVKmPkEzrRku6iW4TlkYufiz0jU3tP5t4mhMNRnOL5tu30/hNWNjAuI0SCdHgn1Y+m mUHdDHIyVaqnJW9l+IqQBU75qdk3xaYXcKSmMylPz7cd3SAw4GtWZ9pRkUgxUqmtFH1BFI P3CofwXu9ddwMZE2HcueA4lGq4B9EBg= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-s22FMNWmM3uPmfWY7IR2DQ-1; Mon, 29 Jul 2024 01:22:19 -0400 X-MC-Unique: s22FMNWmM3uPmfWY7IR2DQ-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 28D7C1955D45; Mon, 29 Jul 2024 05:22:18 +0000 (UTC) Received: from server.redhat.com (unknown [10.72.112.168]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 227DB1955D42; Mon, 29 Jul 2024 05:22:12 +0000 (UTC) From: Cindy Lu To: lulu@redhat.com, dtatulea@nvidia.com, mst@redhat.com, jasowang@redhat.com, parav@nvidia.com, sgarzare@redhat.com, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 3/3] vdpa/mlx5: Add the support of set mac address Date: Mon, 29 Jul 2024 13:20:47 +0800 Message-ID: <20240729052146.621924-4-lulu@redhat.com> In-Reply-To: <20240729052146.621924-1-lulu@redhat.com> References: <20240729052146.621924-1-lulu@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Content-Type: text/plain; charset="utf-8" Add the function to support setting the MAC address. For vdpa/mlx5, the function will use mlx5_mpfs_add_mac to set the mac address Tested in ConnectX-6 Dx device Signed-off-by: Cindy Lu --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5= _vnet.c index ecfc16151d61..dd19eec40297 100644 --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c @@ -3786,9 +3786,37 @@ static void mlx5_vdpa_dev_del(struct vdpa_mgmt_dev *= v_mdev, struct vdpa_device * mgtdev->ndev =3D NULL; } =20 +static int mlx5_vdpa_set_attr(struct vdpa_mgmt_dev *v_mdev, struct vdpa_de= vice *dev, + const struct vdpa_dev_set_config *add_config) +{ + struct virtio_net_config *config; + struct mlx5_core_dev *pfmdev; + struct mlx5_vdpa_dev *mvdev; + struct mlx5_vdpa_net *ndev; + struct mlx5_core_dev *mdev; + int err =3D -EINVAL; + + mvdev =3D to_mvdev(dev); + ndev =3D to_mlx5_vdpa_ndev(mvdev); + mdev =3D mvdev->mdev; + config =3D &ndev->config; + + down_write(&ndev->reslock); + if (add_config->mask & (1 << VDPA_ATTR_DEV_NET_CFG_MACADDR)) { + pfmdev =3D pci_get_drvdata(pci_physfn(mdev->pdev)); + err =3D mlx5_mpfs_add_mac(pfmdev, config->mac); + if (!err) + ether_addr_copy(config->mac, add_config->net.mac); + } + + up_write(&ndev->reslock); + return err; +} + static const struct vdpa_mgmtdev_ops mdev_ops =3D { .dev_add =3D mlx5_vdpa_dev_add, .dev_del =3D mlx5_vdpa_dev_del, + .dev_set_attr =3D mlx5_vdpa_set_attr, }; =20 static struct virtio_device_id id_table[] =3D { --=20 2.45.0