From nobody Thu Sep 19 00:16:47 2024 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A34E714F9E6 for ; Fri, 26 Jul 2024 20:00:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722024010; cv=none; b=XC1TprlLuTr7Ctbt8WKP4FdqQnOwHR7+TQgCXkYxnga6UwyyHaI4OjPCk580iXLxLCyJMDtUA7bZdmlib1VEF7NC/kZnd+wGHq48AakpWH+H+UjnAowFQ25YY69I0ByJUlwtavjDRkHWPw6VxTmNyLXPlj7tl3nubMXTVO9SQaI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722024010; c=relaxed/simple; bh=t6EwZ6i4na0n8NMTSrZB1GIshA5X1Zsp8851eUofPjM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lQq/FbBlWu5VQGOFLxlUjMXSMd32Mfi7DKJk2YGMYKbRY52FfyrqKu3sQ9VlsAfFdUT5/oVqr3M9V0Qzg8KBAxckY79S93TRUhNcVaa25Me//FFji84dvO6j5NZhASy23zIoBJkKjZVu4U6Yu/rdrTKyUGDDjz6LYWvittsbozU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=EDh3v0EF; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="EDh3v0EF" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5a156557029so3454749a12.2 for ; Fri, 26 Jul 2024 13:00:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1722024007; x=1722628807; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n6vACS09qfMp/6TXOWUchSNtennyGoJCWfR5pa4HeUA=; b=EDh3v0EFWYqQmztkws5YnVxrv1SuxKZ8kmQRNhuc5bTBh/bYHU37tPzY8fKgRtfVyN 2xIylUEHb2cLXibbi1af4e9HjV+A8jnEhnwBXncpSIdYUxnJl5R6d0R/RDpPnKTJoeEX Rd223ZHVWOSba2uKp2XM1rpY4/Ghxp6E/P7t2uQFjwHX/X7JeAznwy4wXkvm7ORml0p9 pCSmBNAx1QoywM+k3EhxU2QAFLVHiU8zkkvcBKkrKZCL4zZQ/crpYlM4RVj/0t8SDADP RXhh2gl+8gpoVAD6qfu2aiGdZ/2DLMRLrWJe6EQKC7otVZ/jWcBcFR10yCCt+SeLp8OP I8IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722024007; x=1722628807; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n6vACS09qfMp/6TXOWUchSNtennyGoJCWfR5pa4HeUA=; b=Vn2513SxK6EkehaJgK9UOuGWtWDPx5pY+Jix9Pc9g24mVFnLbj19LFO5ywX/IaO602 lu7MHBLW0kGhFg2GmPGIBvp63PtjYbL8UUeZy4IojSHU0ftmFpkSZJfPJ5iP/klWoyDU f3ltsY1lALKqH+UP8xosaooYtXbZ/7hFxGciJu1/ElocXzEKb58IZ0MY/yaReq277ick 7yLHuUz/wvSb2LTOFsmWLLAffKjEzPpxKMOugLbh3S6j8i7C6D7y8ZPme6SavNOQJTh5 IpXibViX9i3PxRutlBMGjxZSlr8vd0GO6HCWXRXWE28ztLgkglOYjei+4RwiXEvKYPBd fnQw== X-Forwarded-Encrypted: i=1; AJvYcCUf1FDs8M/C+cLXdRz3SOXAY2yLdnQmRM2jLFM4cGpMI99YOFUI2KDG2Yczzxq8JEi5X5NgXY24yhMOfALarPQnVQcL7s0KewFfvkeQ X-Gm-Message-State: AOJu0YylpxvmJpKbtUBRKRt89IYs6VY3bKkCdmyKX4iNpxnbHQQs8XyZ LyU2cMYs1is0J9Y72t97/ODX3FDdYBiOsUeNYFzqjqUrpjuaDePoZqBlBGMIRPI= X-Google-Smtp-Source: AGHT+IEvy1txv1WUQfzxlMFCu8wRQC6RbvPsAnRENjxXb+mowGIzRFW6VNoCJbR9EDAeoYQ9pEjbew== X-Received: by 2002:a17:907:7e92:b0:a7d:33f0:4d58 with SMTP id a640c23a62f3a-a7d40128730mr45428566b.48.1722024007043; Fri, 26 Jul 2024 13:00:07 -0700 (PDT) Received: from blmsp.fritz.box ([2001:4091:a245:8609:c1c4:a4f8:94c8:31f2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acad90e1esm209999166b.151.2024.07.26.13.00.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jul 2024 13:00:06 -0700 (PDT) From: Markus Schneider-Pargmann To: Chandrasekar Ramakrishnan , Marc Kleine-Budde , Vincent Mailhol , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Markus Schneider-Pargmann , =?UTF-8?q?Martin=20Hundeb=C3=B8ll?= , Michal Kubiak , Simon Horman , Tony Lindgren , Judith Mendez Cc: Matthias Schiffer , Linux regression tracking , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/7] can: m_can: disable_all_interrupts, not clear active_interrupts Date: Fri, 26 Jul 2024 21:59:42 +0200 Message-ID: <20240726195944.2414812-6-msp@baylibre.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240726195944.2414812-1-msp@baylibre.com> References: <20240726195944.2414812-1-msp@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" active_interrupts is a cache for the enabled interrupts and not the global masking of interrupts. Do not clear this variable otherwise we may loose the state of the interrupts. Fixes: 07f25091ca02 ("can: m_can: Implement receive coalescing") Signed-off-by: Markus Schneider-Pargmann --- drivers/net/can/m_can/m_can.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index e70c7100a3c9..bf4a9ae76db9 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -483,7 +483,6 @@ static inline void m_can_disable_all_interrupts(struct = m_can_classdev *cdev) { m_can_coalescing_disable(cdev); m_can_write(cdev, M_CAN_ILE, 0x0); - cdev->active_interrupts =3D 0x0; =20 if (!cdev->net->irq) { dev_dbg(cdev->dev, "Stop hrtimer\n"); --=20 2.45.2