From nobody Mon Feb 9 16:35:05 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB3D018A94A for ; Mon, 29 Jul 2024 16:46:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722271583; cv=none; b=KhGzeWspwdqW3coLoB2QnsXLXrewJ18PAdvqNBN4cF71JAPva19mMb9bZiWV/xUPeH2TYogot6di8fNGYd8Vg6/7H1C9bYZI/XFeVLhtZfjruf8Dfo8Mkqmb8ys3yEEYXV3u64SpGEBHurThG87qpLcC7daTqm2pkNmhwDyTCCU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722271583; c=relaxed/simple; bh=vcEzXouSW5qhs+WKWJ6j7BThr5Umszy0VJSt4R3KWXE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pNzG/7TxYJ53cm/Ms9+JVvVmHMhPOTvuDOdGWsV8roJL0ZK5UypFs9KatcvP8WE30ykREaAiMEoBJ2k/NZyH/Vy/HfQZDbA11VPiBLvYFchKy//Df4dQed8IVy5ZxTkBwpL3bMj8/3Z15JisQ38u8NjaYdJMvSk1fg36QjSyTrU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=P6zz1nS1; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="P6zz1nS1" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1fbc3a9d23bso19317745ad.1 for ; Mon, 29 Jul 2024 09:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1722271580; x=1722876380; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BW7CGRA85beDZYynJOG3K+o2YMpxrF+HMxsvS/Z8BLI=; b=P6zz1nS1Qk6Oh+bA2gtESUKV0MFqo0sGW6ESrThezO3r8j2MjGd+lofOCCGbUF/dwa ETo0w5q6T8iRFn1kZjwph9A9dd4ODJ377xXiXrNxF6j5A1Y0xhUMbmtk+SQpHIqRxy/0 CUQPgYPdFIV4biOdmMyPOHS9GkVyWCH6C7nF52tuLAr/PmD05i8MCg1HBxXb0+67xmBL HcGtAMzRYcDVmPkJ76hwO+EEWH4vSJrr1fcvQOZ6PXkzBu0v10ZEtNikGmpks0h9b49H HfQjfDzuBOZlXUaPkR716dz/Y/KrQeVj0M+052DE/a3E9YWmxoaSpGBUbSghCmnYXVsY U9cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722271580; x=1722876380; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BW7CGRA85beDZYynJOG3K+o2YMpxrF+HMxsvS/Z8BLI=; b=Mf2GAZQn3fJnVOcVXcBzpdnQ+qCQkgWGtuPD7WtRmK7/U85MwkXxQUCX0H2UIzG4m+ 00/81/pLdSGhfPJEZnEYGel9CC5neEB8XoENOuWq+etCQYQajCd0DdhqltuVQe/Va71Y vz9yLGEn/gtM6yDoNEB8ErcjY+X2K7sBM1vrX56rFLfJg9aF2Ax5IGNv0gzN21Kr0RMG CJOQnioM1K1BKNMhk925FeY21JDXyC1Fd10UrK/3OJEausL4NAlKe2WWDo6JVMb6ZxpH nd5X8X+gSPJbrMVgnEfII934Etcvo+9jKe21bi2HP7AZPdnQY61+5FYOS46w4dXa5Ztp LGvA== X-Forwarded-Encrypted: i=1; AJvYcCW2a6QGZO+KroHZiGiKqNI10ETDg3sd0T07eLE1UYgCC/mNlKro7u667k4O6cHyuLMBP9EqJ7vVsL767fQUHiJBzMHMBaLLsiBfZkV+ X-Gm-Message-State: AOJu0YyDCLD3kG6BxD39x+ZMjcnGJ76NLLPJmjyhvgKPeGuaAptteW2m 4J+JYD+A1l7cdvwTW8HjR76i7swUmjT/ECCYC247rMg0hlu9fLONX4Bb6hqDKUE= X-Google-Smtp-Source: AGHT+IGT68p/2k5fQAsQJYVblnXyBTkymlHklXNAKKlhKSCjLI+wrBNoURLMQpu2s75WaRqmrTJs/A== X-Received: by 2002:a17:903:4298:b0:1fd:3cf9:c7d1 with SMTP id d9443c01a7336-1ff0482be69mr57426615ad.19.1722271579966; Mon, 29 Jul 2024 09:46:19 -0700 (PDT) Received: from charlie.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fed7d401c6sm85480545ad.117.2024.07.29.09.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jul 2024 09:46:19 -0700 (PDT) From: Charlie Jenkins Date: Fri, 26 Jul 2024 22:29:38 -0700 Subject: [PATCH v2 8/8] libperf test: Add test_stat_overflow_event() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240726-overflow_check_libperf-v2-8-7d154dcf6bea@rivosinc.com> References: <20240726-overflow_check_libperf-v2-0-7d154dcf6bea@rivosinc.com> In-Reply-To: <20240726-overflow_check_libperf-v2-0-7d154dcf6bea@rivosinc.com> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Andrii Nakryiko , Eduard Zingerman , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Charlie Jenkins , Shunsuke Nakamura X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1722271564; l=7556; i=charlie@rivosinc.com; s=20231120; h=from:subject:message-id; bh=NX8BD2CX09iOEogiAZJc+2h9Y+GaCDx2QBL9DE7jL6c=; b=vj4XrZPx2rKNLrg7qQ9zQkLdR+6nTeAcc3FVWqgcDvl00wCiU8f0eW84vn9pbovF0dF0LBn7o BXCM/LpaJu1DMdDywG4WOfEvQVKgPjHU1FyIEX12mh4eKyAnU8EZExi X-Developer-Key: i=charlie@rivosinc.com; a=ed25519; pk=t4RSWpMV1q5lf/NWIeR9z58bcje60/dbtxxmoSfBEcs= From: Shunsuke Nakamura Add a test to check overflowed events. Committer testing: $ sudo make tests -C ./tools/lib/perf V=3D1 make: Entering directory '/home/nakamura/build_work/build_kernel/linux-ke= rnel/linux/tools/lib/perf' make -f /home/nakamura/build_work/build_kernel/linux-kernel/linux/tools/b= uild/Makefile.build dir=3D. obj=3Dlibperf make -C /home/nakamura/build_work/build_kernel/linux-kernel/linux/tools/l= ib/api/ O=3D libapi.a make -f /home/nakamura/build_work/build_kernel/linux-kernel/linux/tools/b= uild/Makefile.build dir=3D./fd obj=3Dlibapi make -f /home/nakamura/build_work/build_kernel/linux-kernel/linux/tools/b= uild/Makefile.build dir=3D./fs obj=3Dlibapi make -f /home/nakamura/build_work/build_kernel/linux-kernel/linux/tools/b= uild/Makefile.build dir=3D. obj=3Dtests make -f /home/nakamura/build_work/build_kernel/linux-kernel/linux/tools/b= uild/Makefile.build dir=3D./tests obj=3Dtests running static: - running tests/test-cpumap.c...OK - running tests/test-threadmap.c...OK - running tests/test-evlist.c... Event 0 -- overflow flag =3D 0x1, POLL_HUP =3D 1, other signal event =3D= 0 Event 1 -- overflow flag =3D 0x2, POLL_HUP =3D 1, other signal event =3D= 0 Event 2 -- overflow flag =3D 0x4, POLL_HUP =3D 1, other signal event =3D= 0 Event 3 -- overflow flag =3D 0x8, POLL_HUP =3D 1, other signal event =3D= 0 OK - running tests/test-evsel.c... OK running dynamic: - running tests/test-cpumap.c...OK - running tests/test-threadmap.c...OK - running tests/test-evlist.c... Event 0 -- overflow flag =3D 0x1, POLL_HUP =3D 1, other signal event =3D= 0 Event 1 -- overflow flag =3D 0x2, POLL_HUP =3D 1, other signal event =3D= 0 Event 2 -- overflow flag =3D 0x4, POLL_HUP =3D 1, other signal event =3D= 0 Event 3 -- overflow flag =3D 0x8, POLL_HUP =3D 1, other signal event =3D= 0 OK - running tests/test-evsel.c... OK make: Leaving directory '/home/nakamura/build_work/build_kernel/linux-ker= nel/linux/tools/lib/perf' Signed-off-by: Shunsuke Nakamura Signed-off-by: Charlie Jenkins --- tools/lib/perf/tests/test-evlist.c | 111 +++++++++++++++++++++++++++++++++= ++++ tools/lib/perf/tests/test-evsel.c | 20 +++---- 2 files changed, 121 insertions(+), 10 deletions(-) diff --git a/tools/lib/perf/tests/test-evlist.c b/tools/lib/perf/tests/test= -evlist.c index 3a833f0349d3..7bfceb8e0c66 100644 --- a/tools/lib/perf/tests/test-evlist.c +++ b/tools/lib/perf/tests/test-evlist.c @@ -5,6 +5,8 @@ #include #include #include +#include +#include #include #include #include @@ -24,6 +26,13 @@ #define EVENT_NUM 15 #define WAIT_COUNT 100000000UL =20 +static unsigned int overflow_flag; +static struct signal_counts { + int hup; + int others; +} sig_count; +static struct perf_evlist *s_evlist; + static int libperf_print(enum libperf_print_level level, const char *fmt, va_list ap) { @@ -570,6 +579,107 @@ static int test_stat_multiplexing(void) return 0; } =20 +static void sig_handler(int signo, siginfo_t *info, void *uc) +{ + struct perf_evsel *evsel; + int i =3D 0; + + perf_evlist__for_each_evsel(s_evlist, evsel) { + if (perf_evsel__has_fd(evsel, info->si_fd)) { + if (info->si_code =3D=3D POLL_HUP) + sig_count.hup++; + else + sig_count.others++; + + overflow_flag =3D (1U << i); + return; + } + i++; + } + + __T_VERBOSE("Failed to get fd of overflowed event"); +} + +static int test_stat_overflow_event(void) +{ + static struct sigaction sigact; + + struct perf_thread_map *threads; + struct perf_evsel *evsel; + struct perf_event_attr attr =3D { + .type =3D PERF_TYPE_SOFTWARE, + .config =3D PERF_COUNT_SW_CPU_CLOCK, + .sample_type =3D PERF_SAMPLE_PERIOD, + .sample_period =3D 100000, + .disabled =3D 1, + }; + int err, i, event_num =3D 4; + + LIBPERF_OPTS(perf_evsel_open_opts, opts, + .open_flags =3D PERF_FLAG_FD_CLOEXEC, + .fcntl_flags =3D (O_RDWR | O_NONBLOCK | O_ASYNC), + .signal =3D SIGRTMIN + 1, + .owner_type =3D F_OWNER_PID, + .sigact =3D &sigact); + + /* setup signal handler */ + memset(&sigact, 0, sizeof(struct sigaction)); + sigact.sa_sigaction =3D (void *)sig_handler; + sigact.sa_flags =3D SA_SIGINFO; + + threads =3D perf_thread_map__new_dummy(); + __T("failed to create threads", threads); + + perf_thread_map__set_pid(threads, 0, 0); + + s_evlist =3D perf_evlist__new(); + __T("failed to create evlist", s_evlist); + + for (i =3D 0; i < event_num; i++) { + evsel =3D perf_evsel__new(&attr); + __T("failed to create evsel", evsel); + + perf_evlist__add(s_evlist, evsel); + } + + perf_evlist__set_maps(s_evlist, NULL, threads); + + err =3D perf_evlist__open_opts(s_evlist, &opts); + __T("failed to open evlist", err =3D=3D 0); + + i =3D 0; + perf_evlist__for_each_evsel(s_evlist, evsel) { + volatile unsigned int wait_count =3D WAIT_COUNT; + + overflow_flag =3D 0; + sig_count.hup =3D 0; + sig_count.others =3D 0; + + err =3D perf_evsel__refresh(evsel, 1); + __T("failed to refresh evsel", err =3D=3D 0); + + while (wait_count--) + ; + + __T_VERBOSE("Event %2d -- overflow flag =3D %#x, ", + i, overflow_flag); + __T_VERBOSE("POLL_HUP =3D %d, other signal event =3D %d\n", + sig_count.hup, sig_count.others); + + __T("unexpected event overflow detected", overflow_flag && (1U << i)); + __T("unexpected signal event detected", + sig_count.hup =3D=3D 1 && sig_count.others =3D=3D 0); + + i++; + } + + perf_evlist__close(s_evlist); + perf_evlist__delete(s_evlist); + perf_thread_map__put(threads); + + return 0; +} + int test_evlist(int argc, char **argv) { __T_START; @@ -582,6 +692,7 @@ int test_evlist(int argc, char **argv) test_mmap_thread(); test_mmap_cpus(); test_stat_multiplexing(); + test_stat_overflow_event(); =20 __T_END; return tests_failed =3D=3D 0 ? 0 : -1; diff --git a/tools/lib/perf/tests/test-evsel.c b/tools/lib/perf/tests/test-= evsel.c index b27dd65f2ec9..56f4ae20e922 100644 --- a/tools/lib/perf/tests/test-evsel.c +++ b/tools/lib/perf/tests/test-evsel.c @@ -15,7 +15,7 @@ #include #include "tests.h" =20 -#define WAIT_COUNT 10000000UL +#define WAIT_COUNT 100000000UL static struct signal_counts { int in; int hup; @@ -380,7 +380,7 @@ static void sig_handler(int signo, siginfo_t *info, voi= d *uc) =20 static int test_stat_overflow(int owner) { - static struct sigaction sig; + static struct sigaction sigact; u64 period =3D 1000000; int overflow_limit =3D 3; =20 @@ -396,16 +396,16 @@ static int test_stat_overflow(int owner) int err =3D 0, i; =20 LIBPERF_OPTS(perf_evsel_open_opts, opts, - .open_flags =3D PERF_FLAG_FD_CLOEXEC, - .flags =3D (O_RDWR | O_NONBLOCK | O_ASYNC), - .signal =3D SIGRTMIN + 1, - .owner_type =3D owner, - .sig =3D &sig); + .open_flags =3D PERF_FLAG_FD_CLOEXEC, + .fcntl_flags =3D (O_RDWR | O_NONBLOCK | O_ASYNC), + .signal =3D SIGRTMIN + 1, + .owner_type =3D owner, + .sigact =3D &sigact); =20 /* setup signal handler */ - memset(&sig, 0, sizeof(struct sigaction)); - sig.sa_sigaction =3D (void *)sig_handler; - sig.sa_flags =3D SA_SIGINFO; + memset(&sigact, 0, sizeof(struct sigaction)); + sigact.sa_sigaction =3D (void *)sig_handler; + sigact.sa_flags =3D SA_SIGINFO; =20 threads =3D perf_thread_map__new_dummy(); __T("failed to create threads", threads); --=20 2.44.0