From nobody Mon Sep 16 19:47:51 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F00F519AD91; Thu, 25 Jul 2024 16:46:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721925999; cv=none; b=A3A/8XVNI4lwcbwXXQrVyKkYKkvL+k0uEOwZRPFom/hVLrDgh7gGkWfidUsnghpT3aO3CvLsCAkdgIhh42CLf0ioetxuYakYCgVTagFi1TmYl6vW7sYpYInZkhsNDJymU5n9jvDJi7RIaWsijiJhAhnC+O4gWJw516ZdRbplOnM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721925999; c=relaxed/simple; bh=SSWd5Cnq+ZrCshF93rK3w3XNcMN4l49cB+5OMG1g2/I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j8h4z0S+XXwliGVXwHrIcp0Hg87/AVXRk0CNcgCtD3C0bF+vnq5fkBpn1cxFgLQgfnsDy4R1PaYRBmD18qh2XNAf/Iegjfd0/XEAX2ary0C7jXbMTfIeof9OuFXooMuJpfToXJcjPnA9NozONurmI1tPUXPXM7yMYRL1zGlGCx4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jTG8Lmd9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jTG8Lmd9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 389D0C4AF07; Thu, 25 Jul 2024 16:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721925998; bh=SSWd5Cnq+ZrCshF93rK3w3XNcMN4l49cB+5OMG1g2/I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jTG8Lmd9g7jMyyYZIVEFgD8oNX95GGLhdAiZC3eO1TrIki9UxSp1K7J9p9reii4FA 072BcifkbzYfeoNdMe/rkoVRT9Gb81EB2e38ZOMDOuIXIbH7rI3KifZq+emNFrkRZC lYANVl4ZYm+kucbd6Gt6Inwo1V6un/6JuNJtRQ4L9NcQEmDt5d/ZYF+b3Dy8ErCljU LyiFwRTgYTbI7lR6NczmFu7HT0P9YPfGHqO3PmhJf7nrRBn+nROGnOgLppQ5iZf1ar +dcjz68D/NOf+coXHvAcYYr1QoZFuDaHic8wDdCkIwnFEK8ze4zraIrumATWg1RDEd ZX3ilsM5w1hbw== From: Stephen Boyd To: Greg Kroah-Hartman Cc: Jeff Johnson , linux-kernel@vger.kernel.org, patches@lists.linux.dev Subject: [PATCH 1/3] spmi: add missing MODULE_DESCRIPTION() macros Date: Thu, 25 Jul 2024 09:46:31 -0700 Message-ID: <20240725164636.3362690-2-sboyd@kernel.org> X-Mailer: git-send-email 2.46.0.rc1.232.g9752f9e123-goog In-Reply-To: <20240725164636.3362690-1-sboyd@kernel.org> References: <20240725164636.3362690-1-sboyd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jeff Johnson make allmodconfig && make W=3D1 C=3D1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/spmi/hisi-spmi-co= ntroller.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/spmi/spmi-pmic-ar= b.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson Link: https://lore.kernel.org/r/20240609-md-drivers-spmi-v1-1-f1d5b24e7a66@= quicinc.com Signed-off-by: Stephen Boyd --- drivers/spmi/hisi-spmi-controller.c | 1 + drivers/spmi/spmi-pmic-arb.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-c= ontroller.c index fa068b34b040..3cafdf22c909 100644 --- a/drivers/spmi/hisi-spmi-controller.c +++ b/drivers/spmi/hisi-spmi-controller.c @@ -344,6 +344,7 @@ static void __exit spmi_controller_exit(void) } module_exit(spmi_controller_exit); =20 +MODULE_DESCRIPTION("Hisilicon 3670 SPMI Controller driver"); MODULE_LICENSE("GPL v2"); MODULE_VERSION("1.0"); MODULE_ALIAS("platform:spmi_controller"); diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 791cdc160c51..f240fcc5a4e1 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -1891,5 +1891,6 @@ static struct platform_driver spmi_pmic_arb_driver = =3D { }; module_platform_driver(spmi_pmic_arb_driver); =20 +MODULE_DESCRIPTION("Qualcomm MSM SPMI Controller (PMIC Arbiter) driver"); MODULE_LICENSE("GPL v2"); MODULE_ALIAS("platform:spmi_pmic_arb"); --=20 https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/ https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git From nobody Mon Sep 16 19:47:51 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6438319D89E; Thu, 25 Jul 2024 16:46:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721925999; cv=none; b=TV4OcwQi5NQKIJXYeEIU0zCurs7VWEdLeXU7ZsMzXTrBt8fMkrPtB63ux+x2gCG5hAN5/DYn0Of0E0aB3v6xgg/EKCKYblFK3AI3Rcev3uZfLmcnnsCA95gIDo8wBE6kBxoAd5oHji2yKtd2YPJ8FMD6dtyNls3Y1kpby2jWORA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721925999; c=relaxed/simple; bh=Qq3CcW40qWfdw5BFZRNSV2DrrWbD7dh0AWeFfVliKVs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=p1qmEI2Y4GOzc/ML0lMB+3dijMny3nDQX7sOMJeds+MbvEIMV4QJZmoKKdPJ5NEZ0kbQhcHIEAi0HDWCJgC3Wz55dRPiQp0JgYrt1W222mCsT2p9Ecbj+QA5HuzCwilQ+Cj7h4G+qlVlvhqWc440W3UqRCGaIgO+PV9jZGDWciA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XLtbxnCV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XLtbxnCV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A2E9C32782; Thu, 25 Jul 2024 16:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721925999; bh=Qq3CcW40qWfdw5BFZRNSV2DrrWbD7dh0AWeFfVliKVs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XLtbxnCVsM3H88hxCT4whwdZObEvgfX0FGOw6VDK3bTQ7fqdxxyj/UJb8E+p2SnC3 chyIiKVV4cXmLRbif4eKgr4Xf97QJpf8mbJRU2C3Mxqe4teXXiZd0gy288ib9MUjUw twvBSmq1JTuIHyjyYWuWi0lwJUhFqxPGUe/yELQIcb28JPWTsPM3a1yMFdcQSVHe2i EzzpgxcCgq2X2qoLNlw+esFvejW6Awz1x330vAbu429VaPNw5ZsDhlRj6sAlp5VUlt ZOuUgOeFx4ypAnfpg1vb7O1i63mqP2ECLUHoM3gs/J90o2wZxFkfOYcRlrAkDtyY0d S0SfxslSoqqMQ== From: Stephen Boyd To: Greg Kroah-Hartman Cc: Konrad Dybcio , linux-kernel@vger.kernel.org, patches@lists.linux.dev, Abel Vesa , Dmitry Baryshkov , stable@vger.kernel.org Subject: [PATCH 2/3] spmi: pmic-arb: Pass the correct of_node to irq_domain_add_tree Date: Thu, 25 Jul 2024 09:46:32 -0700 Message-ID: <20240725164636.3362690-3-sboyd@kernel.org> X-Mailer: git-send-email 2.46.0.rc1.232.g9752f9e123-goog In-Reply-To: <20240725164636.3362690-1-sboyd@kernel.org> References: <20240725164636.3362690-1-sboyd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Konrad Dybcio Currently, irqchips for all of the subnodes (which represent a given bus master) point to the parent wrapper node. This is no bueno, as no interrupts arrive, ever (because nothing references that node). Fix that by passing a reference to the respective master's of_node. Worth noting, this is a NOP for devices with only a single master described. Signed-off-by: Konrad Dybcio Link: https://lore.kernel.org/r/20240522-topic-spmi_multi_master_irqfix-v2-= 1-7ec92a862b9f@linaro.org Reviewed-by: Abel Vesa Tested-by: Dmitry Baryshkov Reviewed-by: Dmitry Baryshkov Fixes: 02922ccbb330 ("spmi: pmic-arb: Register controller for bus instead o= f arbiter") Cc: stable@vger.kernel.org Signed-off-by: Stephen Boyd --- drivers/spmi/spmi-pmic-arb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index f240fcc5a4e1..b6880c13163c 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -1737,8 +1737,7 @@ static int spmi_pmic_arb_bus_init(struct platform_dev= ice *pdev, =20 dev_dbg(&pdev->dev, "adding irq domain for bus %d\n", bus_index); =20 - bus->domain =3D irq_domain_add_tree(dev->of_node, - &pmic_arb_irq_domain_ops, bus); + bus->domain =3D irq_domain_add_tree(node, &pmic_arb_irq_domain_ops, bus); if (!bus->domain) { dev_err(&pdev->dev, "unable to create irq_domain\n"); return -ENOMEM; --=20 https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/ https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git From nobody Mon Sep 16 19:47:51 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9321919DF64; Thu, 25 Jul 2024 16:46:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721925999; cv=none; b=q4hTJxJ/cutpLD+aZggZ7t40TZ52+2g53h+tVc25thVBOwEG8UnX8K1SoBL6FT7h/yfc+93POuVX9ikXcsRYkhi/USJfbIVCUhZsSPgOfzw4JIrrYHBm/5Ec0Pqh8tEm+MSlM21oV+bgy9zdXz1CLgGR2Ws+bW3C0vPePNtAruw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721925999; c=relaxed/simple; bh=BB6mD9MVfalBY2Sh8QiPsmLsNCeDOP5OqjX1/QypdnE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eulFsQjd73yvAGDSt3xdRURiUfU1ApXiEJ0W/wtQyMhk4IWakdBWDPfiaFguFPRSbZAQVlW1j3Al6Tx3o2RicKiG51VF6njjSJivILixYCrNrPzNGM3/ToyaU6uPn9L02Siubci/roGPqwzEFOjGKZzifHMWo0UnsmSdv4/L4+Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L+d91RQ2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L+d91RQ2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28D1DC4AF0E; Thu, 25 Jul 2024 16:46:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721925999; bh=BB6mD9MVfalBY2Sh8QiPsmLsNCeDOP5OqjX1/QypdnE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L+d91RQ2OsaoskFRNBR8TuJagp//xrXXJwHZpmg9ujOutiIBRvbkg1dT/Hr0FLDS6 JR91ucZ15amlWT4aHeLYvZlPG4cSxFWmwtvsJDqv2BoS2whS5qLtYNwcuLS1LfCEWV cpVbLqoVHAE2hyxF7JT3f7BmEaETBx9KUQ9AyeFoHx2K2EH5ECb4w6GE7ZrsFEeo62 tDaqn6XJ7CujZ1E/Pv01m+7iuMn+Lfb+AQQfuvxQRVa/SozCfK0+Tg7QqMBI65i/U8 cWa5cLA/wS7AXNlfPB0puTwyxr66I2hFp2h3w5YoeudvputdLsy0wqxuSpbFH2/cq5 F0JU21qp5LrCg== From: Stephen Boyd To: Greg Kroah-Hartman Cc: David Collins , linux-kernel@vger.kernel.org, patches@lists.linux.dev, Bjorn Andersson Subject: [PATCH 3/3] spmi: pmic-arb: add missing newline in dev_err format strings Date: Thu, 25 Jul 2024 09:46:33 -0700 Message-ID: <20240725164636.3362690-4-sboyd@kernel.org> X-Mailer: git-send-email 2.46.0.rc1.232.g9752f9e123-goog In-Reply-To: <20240725164636.3362690-1-sboyd@kernel.org> References: <20240725164636.3362690-1-sboyd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: David Collins dev_err() format strings should end with '\n'. Several such format strings in the spmi-pmic-arb driver are missing it. Add newlines where needed. Fixes: 02922ccbb330 ("spmi: pmic-arb: Register controller for bus instead o= f arbiter") Signed-off-by: David Collins Link: https://lore.kernel.org/r/20240703221248.3640490-1-quic_collinsd@quic= inc.com Reviewed-by: Bjorn Andersson Signed-off-by: Stephen Boyd --- drivers/spmi/spmi-pmic-arb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index b6880c13163c..9ba9495fcc4b 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -398,7 +398,7 @@ static int pmic_arb_fmt_read_cmd(struct spmi_pmic_arb_b= us *bus, u8 opc, u8 sid, =20 *offset =3D rc; if (bc >=3D PMIC_ARB_MAX_TRANS_BYTES) { - dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:= %zu requested", + dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:= %zu requested\n", PMIC_ARB_MAX_TRANS_BYTES, len); return -EINVAL; } @@ -477,7 +477,7 @@ static int pmic_arb_fmt_write_cmd(struct spmi_pmic_arb_= bus *bus, u8 opc, =20 *offset =3D rc; if (bc >=3D PMIC_ARB_MAX_TRANS_BYTES) { - dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:= %zu requested", + dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:= %zu requested\n", PMIC_ARB_MAX_TRANS_BYTES, len); return -EINVAL; } @@ -1702,7 +1702,7 @@ static int spmi_pmic_arb_bus_init(struct platform_dev= ice *pdev, =20 index =3D of_property_match_string(node, "reg-names", "cnfg"); if (index < 0) { - dev_err(dev, "cnfg reg region missing"); + dev_err(dev, "cnfg reg region missing\n"); return -EINVAL; } =20 @@ -1712,7 +1712,7 @@ static int spmi_pmic_arb_bus_init(struct platform_dev= ice *pdev, =20 index =3D of_property_match_string(node, "reg-names", "intr"); if (index < 0) { - dev_err(dev, "intr reg region missing"); + dev_err(dev, "intr reg region missing\n"); return -EINVAL; } =20 --=20 https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/ https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git