From nobody Thu Dec 18 08:26:37 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3E407482 for ; Thu, 25 Jul 2024 15:11:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721920280; cv=none; b=PXZVIpI95ZXNjCKP4dLSoClbTkCGr9UhawzxBUZtB89DmoeTovexfaSGTdFB5HIMrrIMLjyK22RvUn+JXiQtqor0x5duOVwbQnMi9lU3mT5ndyzicOoMR77CEhCjVcEjUVVJ7zrhLh5YXp74hv4EL84w2SmtIA/432ZVqyt0d7c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721920280; c=relaxed/simple; bh=RDA2VrRAE/IIlxWaSQLIDHC8rCsMYDyViCallkFB8d8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=HgW2EnO09eSExT0LDY+dAklxv01QzfnQ3qTEwYPZ6KyaHk3fusTtwIi1kXmdHYVOrKhh27VdSHQAmNTNkneb4DzjdDuCsxSrlDngq5olMYlj9hbuBIAO4/HO3q6zfrwyCF6myjD0msbSYfacXlk+LoZ/nOE34JL7TwACIKnNoSE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=M8HLzu7a; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="M8HLzu7a" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721920279; x=1753456279; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=RDA2VrRAE/IIlxWaSQLIDHC8rCsMYDyViCallkFB8d8=; b=M8HLzu7ai6xYx2W4K5GUDGLd9Hh+XJIQNUUh7c0QaP73X3aEh7FOLGVO vaPrB0E3Zn0MK6Sdglghozjw7Yl91KP9UN4mipVCjYjfsf0FxgeFEdjpF SfE59zZ2C5kD5sX49o/YvwMA3vUELK2lDXHgwnz9BYlvN1aK6cvnEWQEX HAG1xGQXLZzQq7gJl5wsi7ZfaUAHMdP1+l7WfEp3iDYipqvitmsM2JVEv AltKvHLd/5AUOzp+GJ0hEZE5zZ+eVKKrth5ucevTkma5+2omDyCNB6zs/ g0HsSZDqkDq4V0Vpaze6w02+yNUaIHN82AXhWlULvTQeCSwuFxYTVWpbV g==; X-CSE-ConnectionGUID: LOCZz/kaTO2jc0/nDAo+Ww== X-CSE-MsgGUID: A3WRBAu0SYOdvRDs6Sst4Q== X-IronPort-AV: E=McAfee;i="6700,10204,11144"; a="42195238" X-IronPort-AV: E=Sophos;i="6.09,236,1716274800"; d="scan'208";a="42195238" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2024 08:11:15 -0700 X-CSE-ConnectionGUID: UvIC7JJHTd6Llyt2P9lW5A== X-CSE-MsgGUID: eiUJ9P8aQl6sO+m3BeFfzQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,236,1716274800"; d="scan'208";a="52645293" Received: from chenyu-dev.sh.intel.com ([10.239.62.164]) by fmviesa006.fm.intel.com with ESMTP; 25 Jul 2024 08:11:12 -0700 From: Chen Yu To: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Juri Lelli Cc: Hongyan Xia , Qais Yousef , Lukasz Luba , linux-kernel@vger.kernel.org, Chen Yu Subject: [PATCH v2] sched/pelt: Use rq_clock_task() for hw_pressure Date: Thu, 25 Jul 2024 23:08:20 +0800 Message-Id: <20240725150820.376623-1-yu.c.chen@intel.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" commit 97450eb90965 ("sched/pelt: Remove shift of thermal clock") removed the decay_shift for hw_pressure. This commit uses the sched_clock_task() in sched_tick() while it replaces the sched_clock_task() with rq_clock_pelt() in __update_blocked_others(). This could bring inconsistence. One possible scenario I can think of is in ___update_load_sum(): u64 delta =3D now - sa->last_update_time 'now' could be calculated by rq_clock_pelt() from __update_blocked_others(), and last_update_time was calculated by rq_clock_task() previously from sched_tick(). Usually the former chases after the latter, it cause a very large 'delta' and brings unexpected behavior. Fixes: 97450eb90965 ("sched/pelt: Remove shift of thermal clock") Reviewed-by: Hongyan Xia Signed-off-by: Chen Yu --- v1->v2: Added Hongyan's Reviewed-by tag. Removed the Reported-by/Closes tags because they are not related to this fix.(Hongyan Xia) --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 9057584ec06d..cfd4755954fd 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9362,7 +9362,7 @@ static bool __update_blocked_others(struct rq *rq, bo= ol *done) =20 decayed =3D update_rt_rq_load_avg(now, rq, curr_class =3D=3D &rt_sched_cl= ass) | update_dl_rq_load_avg(now, rq, curr_class =3D=3D &dl_sched_class) | - update_hw_load_avg(now, rq, hw_pressure) | + update_hw_load_avg(rq_clock_task(rq), rq, hw_pressure) | update_irq_load_avg(rq, 0); =20 if (others_have_blocked(rq)) --=20 2.25.1