From nobody Wed Dec 17 10:52:29 2025 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5F7916CD3A; Thu, 25 Jul 2024 07:15:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.154.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721891722; cv=none; b=hAKJe2rs2Uoe/pDY2Hm0m7XHIRJWZrwJ6tepA1NqhbphNgqQ+ZP6ztUF0u7jWSV4w2w6faA72DhKnx6dZszrHzL593J9N4NPdpF9dF/8K4xN1IwvXrGB1q/joqxc1IhjaErIOSE76txq6qp3yJ5sGgz1xs3sxurg/Co/8t4RMJA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721891722; c=relaxed/simple; bh=C6WRwDUONbCwjMOYbPgm8PvoHT72vL1m8MFet/DFhv4=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Ew8lDchEjkFkiocmpR/uHRTpe9rg14z4wKB0yaBpLP2IyTLDBgoHTKUu21M8Ah6KbCpeRvEkv9R2CC2FkH9czE24c96KXf3AqALJ3YM7A5pKQ5InDj7lSG+UyFpDpaTTyxS/NPcyT8qZbspgKzQck0q8qwpFnNN17WkclhYJmqw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=EoTZd8wG; arc=none smtp.client-ip=68.232.154.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="EoTZd8wG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1721891721; x=1753427721; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=C6WRwDUONbCwjMOYbPgm8PvoHT72vL1m8MFet/DFhv4=; b=EoTZd8wGWKdqN54orOLP7N6V8ATfFpM0SyHC6M1p/k2/T6YiBeyj+gKO 0CRW59pMPLjt+rR/Kgk4WMg1h+7cs7Mgjvn7WmqH6BKHgHQInVCD/dOWU ESv8+PPCSgleXua2yDjlFVG98TmWr8cnwcONa4/CVxt/NMINauZp+UrsC dkSUUffM45tNvDFk+GtEJl1zy9P1pBAPnvTRpeOMngUIs/iNwtTpGJ/gd j7TvWqjgPjKYAeoNtgEI+ZU/y/+0/fTDVlGLvdE4MbG0pVLDroFv6Py2t uItUDMb6FuEKurusTioEppOSMEU7Mme8OQ5TU7UfkLZsDC03TNKt0nS8w w==; X-CSE-ConnectionGUID: 6oFYj1z4SPSlQiymYK1oBA== X-CSE-MsgGUID: R3+59Xb1TRe+XjSfi5TUmw== X-IronPort-AV: E=Sophos;i="6.09,235,1716274800"; d="scan'208";a="30323881" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 Jul 2024 00:15:19 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Jul 2024 00:14:57 -0700 Received: from HYD-DK-UNGSW21.microchip.com (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Thu, 25 Jul 2024 00:14:53 -0700 From: Raju Lakkaraju To: CC: , , , , , , , , , , Subject: [PATCH net V1] net: phy: micrel: Fix the KSZ9131 MDI-X status issue Date: Thu, 25 Jul 2024 12:41:25 +0530 Message-ID: <20240725071125.13960-1-Raju.Lakkaraju@microchip.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The MDIX status is not accurately reflecting the current state after the li= nk partner has manually altered its MDIX configuration while operating in forc= ed mode. Access information about Auto mdix completion and pair selection from the KSZ9131's Auto/MDI/MDI-X status register Fixes: b64e6a8794d9 ("net: phy: micrel: Add PHY Auto/MDI/MDI-X set driver f= or KSZ9131") Signed-off-by: Raju Lakkaraju Reviewed-by: Andrew Lunn --- drivers/net/phy/micrel.c | 34 +++++++++++++++++++--------------- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index dd519805deee..65b0a3115e14 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -1389,6 +1389,8 @@ static int ksz9131_config_init(struct phy_device *phy= dev) const struct device *dev_walker; int ret; =20 + phydev->mdix_ctrl =3D ETH_TP_MDI_AUTO; + dev_walker =3D &phydev->mdio.dev; do { of_node =3D dev_walker->of_node; @@ -1438,28 +1440,30 @@ static int ksz9131_config_init(struct phy_device *p= hydev) #define MII_KSZ9131_AUTO_MDIX 0x1C #define MII_KSZ9131_AUTO_MDI_SET BIT(7) #define MII_KSZ9131_AUTO_MDIX_SWAP_OFF BIT(6) +#define MII_KSZ9131_DIG_AXAN_STS 0x14 +#define MII_KSZ9131_DIG_AXAN_STS_LINK_DET BIT(14) +#define MII_KSZ9131_DIG_AXAN_STS_A_SELECT BIT(12) =20 static int ksz9131_mdix_update(struct phy_device *phydev) { int ret; =20 - ret =3D phy_read(phydev, MII_KSZ9131_AUTO_MDIX); - if (ret < 0) - return ret; - - if (ret & MII_KSZ9131_AUTO_MDIX_SWAP_OFF) { - if (ret & MII_KSZ9131_AUTO_MDI_SET) - phydev->mdix_ctrl =3D ETH_TP_MDI; - else - phydev->mdix_ctrl =3D ETH_TP_MDI_X; + if (phydev->mdix_ctrl !=3D ETH_TP_MDI_AUTO) { + phydev->mdix =3D phydev->mdix_ctrl; } else { - phydev->mdix_ctrl =3D ETH_TP_MDI_AUTO; - } + ret =3D phy_read(phydev, MII_KSZ9131_DIG_AXAN_STS); + if (ret < 0) + return ret; =20 - if (ret & MII_KSZ9131_AUTO_MDI_SET) - phydev->mdix =3D ETH_TP_MDI; - else - phydev->mdix =3D ETH_TP_MDI_X; + if (ret & MII_KSZ9131_DIG_AXAN_STS_LINK_DET) { + if (ret & MII_KSZ9131_DIG_AXAN_STS_A_SELECT) + phydev->mdix =3D ETH_TP_MDI; + else + phydev->mdix =3D ETH_TP_MDI_X; + } else { + phydev->mdix =3D ETH_TP_MDI_INVALID; + } + } =20 return 0; } --=20 2.34.1