From nobody Mon Sep 16 19:34:58 2024 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CADAFD2FA for ; Thu, 25 Jul 2024 01:32:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721871157; cv=none; b=E/qKIBDjoH00JZrll9HP9DJLl1iebeXMzSCE6QJyrcmm14QlkKuYz50R5EqXtN+6crprNyoQmLzPkFoJItP//PHU+Ee7bEi2owMFvFcG1FOmGxi9GOhffMG1WSBfBipQeYCBcMFP1EtBpEyfpPRjp5JyvrLlBaSJQHoOPHkVm68= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721871157; c=relaxed/simple; bh=80as5wGw/4bdUFUAe3kNOZtWGAiuWTJGuy6fX/wSteQ=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J9Imfqq8KNiRX1AkE48nS1ykT9YIhDhSx8X6iC9x67dLo6dnezioss81rYxxHp4F+WFcIvZHsDKDR4D3O/xAS8KiC+d8VzpDVpJEjqRfyuYSJe1dTx8MEAZKEEGu1MyRKjLT1YU3WAuhMLtFR5bMOmGVBKvhwWd5/Ix/dBPvgX4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=g2KCD8i5; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g2KCD8i5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721871154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c54iM9kz0Lz3lDmdY2pXRISqXriV8mZr57Nulga5voY=; b=g2KCD8i5Hb+9q0dwHL/BHxg5WlsF++GE625jpfgF8X19uShD5IJdtcjoh7zYS2DL9cOuF0 EFyMHRObJn4LAB6hVTbPTi5s4OrJXrtatzx+16lgZKibKIBbuPRkpIS1HnKpRzeXz1rPKm 1331dRFLfO6hwr59k3pzlSDrp4Ej/PY= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-3BoLhMbXPUyWwPbXb5-YcA-1; Wed, 24 Jul 2024 21:32:33 -0400 X-MC-Unique: 3BoLhMbXPUyWwPbXb5-YcA-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E74E419560BF; Thu, 25 Jul 2024 01:32:31 +0000 (UTC) Received: from server.redhat.com (unknown [10.72.112.141]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AD1C81955D42; Thu, 25 Jul 2024 01:32:26 +0000 (UTC) From: Cindy Lu To: lulu@redhat.com, dtatulea@nvidia.com, mst@redhat.com, jasowang@redhat.com, parav@nvidia.com, sgarzare@redhat.com, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATH v6 1/3] vdpa: support set mac address from vdpa tool Date: Thu, 25 Jul 2024 09:31:02 +0800 Message-ID: <20240725013217.1124704-2-lulu@redhat.com> In-Reply-To: <20240725013217.1124704-1-lulu@redhat.com> References: <20240725013217.1124704-1-lulu@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Content-Type: text/plain; charset="utf-8" Add new UAPI to support the mac address from vdpa tool Function vdpa_nl_cmd_dev_attr_set_doit() will get the new MAC address from the vdpa tool and then set it to the device. The usage is: vdpa dev set name vdpa_name mac **:**:**:**:**:** Here is example: root@L1# vdpa -jp dev config show vdpa0 { "config": { "vdpa0": { "mac": "82:4d:e9:5d:d7:e6", "link ": "up", "link_announce ": false, "mtu": 1500 } } } root@L1# vdpa dev set name vdpa0 mac 00:11:22:33:44:55 root@L1# vdpa -jp dev config show vdpa0 { "config": { "vdpa0": { "mac": "00:11:22:33:44:55", "link ": "up", "link_announce ": false, "mtu": 1500 } } } Signed-off-by: Cindy Lu --- drivers/vdpa/vdpa.c | 80 +++++++++++++++++++++++++++++++++++++++ include/linux/vdpa.h | 9 +++++ include/uapi/linux/vdpa.h | 1 + 3 files changed, 90 insertions(+) diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c index 8d391947eb8d..532cf3b52b26 100644 --- a/drivers/vdpa/vdpa.c +++ b/drivers/vdpa/vdpa.c @@ -1361,6 +1361,81 @@ static int vdpa_nl_cmd_dev_config_get_doit(struct sk= _buff *skb, struct genl_info return err; } =20 +static int vdpa_dev_net_device_attr_set(struct vdpa_device *vdev, + struct genl_info *info) +{ + struct vdpa_dev_set_config set_config =3D {}; + const u8 *macaddr; + struct vdpa_mgmt_dev *mdev =3D vdev->mdev; + struct nlattr **nl_attrs =3D info->attrs; + int err =3D -EINVAL; + + down_write(&vdev->cf_lock); + if (nl_attrs[VDPA_ATTR_DEV_NET_CFG_MACADDR]) { + set_config.mask |=3D BIT_ULL(VDPA_ATTR_DEV_NET_CFG_MACADDR); + macaddr =3D nla_data(nl_attrs[VDPA_ATTR_DEV_NET_CFG_MACADDR]); + + if (is_valid_ether_addr(macaddr)) { + ether_addr_copy(set_config.net.mac, macaddr); + memcpy(set_config.net.mac, macaddr, ETH_ALEN); + if (mdev->ops->dev_set_attr) { + err =3D mdev->ops->dev_set_attr(mdev, vdev, + &set_config); + } else { + NL_SET_ERR_MSG_FMT_MOD( + info->extack, + "device does not support changing the MAC address"); + } + } else { + NL_SET_ERR_MSG_FMT_MOD(info->extack, + "Invalid MAC address"); + } + } + up_write(&vdev->cf_lock); + return err; +} +static int vdpa_nl_cmd_dev_attr_set_doit(struct sk_buff *skb, + struct genl_info *info) +{ + const char *name; + int err =3D 0; + struct device *dev; + struct vdpa_device *vdev; + u64 classes; + + if (!info->attrs[VDPA_ATTR_DEV_NAME]) + return -EINVAL; + + name =3D nla_data(info->attrs[VDPA_ATTR_DEV_NAME]); + + down_write(&vdpa_dev_lock); + dev =3D bus_find_device(&vdpa_bus, NULL, name, vdpa_name_match); + if (!dev) { + NL_SET_ERR_MSG_MOD(info->extack, "device not found"); + err =3D -ENODEV; + goto dev_err; + } + vdev =3D container_of(dev, struct vdpa_device, dev); + if (!vdev->mdev) { + NL_SET_ERR_MSG_MOD(info->extack, "unmanaged vdpa device"); + err =3D -EINVAL; + goto mdev_err; + } + classes =3D vdpa_mgmtdev_get_classes(vdev->mdev, NULL); + if (classes & BIT_ULL(VIRTIO_ID_NET)) { + err =3D vdpa_dev_net_device_attr_set(vdev, info); + } else { + NL_SET_ERR_MSG_FMT_MOD(info->extack, "%s device not supported", + name); + } + +mdev_err: + put_device(dev); +dev_err: + up_write(&vdpa_dev_lock); + return err; +} + static int vdpa_dev_config_dump(struct device *dev, void *data) { struct vdpa_device *vdev =3D container_of(dev, struct vdpa_device, dev); @@ -1497,6 +1572,11 @@ static const struct genl_ops vdpa_nl_ops[] =3D { .doit =3D vdpa_nl_cmd_dev_stats_get_doit, .flags =3D GENL_ADMIN_PERM, }, + { + .cmd =3D VDPA_CMD_DEV_ATTR_SET, + .doit =3D vdpa_nl_cmd_dev_attr_set_doit, + .flags =3D GENL_ADMIN_PERM, + }, }; =20 static struct genl_family vdpa_nl_family __ro_after_init =3D { diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h index 7977ca03ac7a..2e7a30fe6b92 100644 --- a/include/linux/vdpa.h +++ b/include/linux/vdpa.h @@ -582,11 +582,20 @@ void vdpa_set_status(struct vdpa_device *vdev, u8 sta= tus); * @dev: vdpa device to remove * Driver need to remove the specified device by calling * _vdpa_unregister_device(). + * @dev_set_attr: change a vdpa device's attr after it was create + * @mdev: parent device to use for device + * @dev: vdpa device structure + * @config:Attributes to be set for the device. + * The driver needs to check the mask of the structure and then set + * the related information to the vdpa device. The driver must return= 0 + * if set successfully. */ struct vdpa_mgmtdev_ops { int (*dev_add)(struct vdpa_mgmt_dev *mdev, const char *name, const struct vdpa_dev_set_config *config); void (*dev_del)(struct vdpa_mgmt_dev *mdev, struct vdpa_device *dev); + int (*dev_set_attr)(struct vdpa_mgmt_dev *mdev, struct vdpa_device *dev, + const struct vdpa_dev_set_config *config); }; =20 /** diff --git a/include/uapi/linux/vdpa.h b/include/uapi/linux/vdpa.h index 842bf1201ac4..71edf2c70cc3 100644 --- a/include/uapi/linux/vdpa.h +++ b/include/uapi/linux/vdpa.h @@ -19,6 +19,7 @@ enum vdpa_command { VDPA_CMD_DEV_GET, /* can dump */ VDPA_CMD_DEV_CONFIG_GET, /* can dump */ VDPA_CMD_DEV_VSTATS_GET, + VDPA_CMD_DEV_ATTR_SET, }; =20 enum vdpa_attr { --=20 2.45.0 From nobody Mon Sep 16 19:34:58 2024 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41D036FB8 for ; Thu, 25 Jul 2024 01:32:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721871168; cv=none; b=tUbHar+ruVkx/hlb6lgimRCov0hn92dXFsYBLqv32isFe+hn9OjbsYW+DVflOUtqdhLIVpR/boRQmMvZAs8nKOsqzKvFbCxwUvdzQfbYxLa/0iY0fNcEQqkAlaS8oR2ii6GF7NinFDbDPWQF7vORDOeKcoPIk7hYSlFxC10CktE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721871168; c=relaxed/simple; bh=B6kntrV50yntikWKwzd0CtyYI/Y0SyA0TsudD3v/2IE=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GO2R2ub/PAYBR46JSZNLB4fQIdKcOfpnQmL+cc1YkIovd45YwKDTuHFkE8sBHlzoLADOWUU45X6SjTuqH8cpDxBEAOtcGzP01i60XBVTSwHWVhIr4o0pZPRYbfB/vnX9U+j0f2QM0w89BsW5Ytz2DKADvo3KoDpH6ZCbq6Yf7CA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fxuGFz12; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fxuGFz12" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721871164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+201+GOsBBZJHHPN4LmlnkaPcB8che0dgv5rCxUZjcs=; b=fxuGFz12nFrqwDxMnZg4XkmHhoHLrI0jyQLzR5idNHE2BZJ1tsACD7JRS0Nj2wrYy4fU4g n8ptEGVBF1bVhO3aOZ4Et0oDmfAtJDdk9FyGQSf+4MqSCIDPG/agNE015U1OcJTuow/dcp 7EvRideXZxiMHEVofLwgZg9mYZgsciA= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-144-zUwEXeGhM52c7UO-bFujcA-1; Wed, 24 Jul 2024 21:32:39 -0400 X-MC-Unique: zUwEXeGhM52c7UO-bFujcA-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0DEE01955D45; Thu, 25 Jul 2024 01:32:38 +0000 (UTC) Received: from server.redhat.com (unknown [10.72.112.141]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EDAA01955D42; Thu, 25 Jul 2024 01:32:31 +0000 (UTC) From: Cindy Lu To: lulu@redhat.com, dtatulea@nvidia.com, mst@redhat.com, jasowang@redhat.com, parav@nvidia.com, sgarzare@redhat.com, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATH v6 2/3] vdpa_sim_net: Add the support of set mac address Date: Thu, 25 Jul 2024 09:31:03 +0800 Message-ID: <20240725013217.1124704-3-lulu@redhat.com> In-Reply-To: <20240725013217.1124704-1-lulu@redhat.com> References: <20240725013217.1124704-1-lulu@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Content-Type: text/plain; charset="utf-8" Add the function to support setting the MAC address. For vdpa_sim_net, the driver will write the MAC address to the config space, and other devices can implement their own functions to support this. Signed-off-by: Cindy Lu --- drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/v= dpa_sim_net.c index cfe962911804..cd404a896414 100644 --- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c @@ -414,6 +414,25 @@ static void vdpasim_net_get_config(struct vdpasim *vdp= asim, void *config) net_config->status =3D cpu_to_vdpasim16(vdpasim, VIRTIO_NET_S_LINK_UP); } =20 +static int vdpasim_net_set_attr(struct vdpa_mgmt_dev *mdev, + struct vdpa_device *dev, + const struct vdpa_dev_set_config *config) +{ + struct vdpasim *vdpasim =3D container_of(dev, struct vdpasim, vdpa); + struct virtio_net_config *vio_config =3D vdpasim->config; + + mutex_lock(&vdpasim->mutex); + + if (config->mask & (1 << VDPA_ATTR_DEV_NET_CFG_MACADDR)) { + ether_addr_copy(vio_config->mac, config->net.mac); + mutex_unlock(&vdpasim->mutex); + return 0; + } + + mutex_unlock(&vdpasim->mutex); + return -EINVAL; +} + static void vdpasim_net_setup_config(struct vdpasim *vdpasim, const struct vdpa_dev_set_config *config) { @@ -510,7 +529,8 @@ static void vdpasim_net_dev_del(struct vdpa_mgmt_dev *m= dev, =20 static const struct vdpa_mgmtdev_ops vdpasim_net_mgmtdev_ops =3D { .dev_add =3D vdpasim_net_dev_add, - .dev_del =3D vdpasim_net_dev_del + .dev_del =3D vdpasim_net_dev_del, + .dev_set_attr =3D vdpasim_net_set_attr }; =20 static struct virtio_device_id id_table[] =3D { --=20 2.45.0 From nobody Mon Sep 16 19:34:58 2024 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A90ED299 for ; Thu, 25 Jul 2024 01:32:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721871170; cv=none; b=O4zdRnGbdf+q8ySsDwwR4Yj1uKT848PUnVamXa6lX98bMQEWFKKO+9ksjrzc4ocT6g67uFshCerOJqL5RRrd+BSu1CZzC0o+HTjMPl0cwvXeHqm7atUXFUrT6O2KrKh2qa7hMfmhCH3W/y3EO3ojQ+R1ZWqzeml55sARSCXKQBg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721871170; c=relaxed/simple; bh=aQT2ZjdHncAQA3F9k5tupIS/QkiNkv6HyFsjQ5yQFgg=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EJ/t7v2bM/l/nKtkQw2r+SvRD2fXhZpXvMacVKocHq7gZvzWfnr05oj37Ehu6X+JuN2emSF0ivLHJuY4pB0qBQix2/uYI6z5mFqMk318jrL1rqTeaB8WCYoUIkOVcr5Je+A/w6xhis9kSylrL2HTJmHZVqxVr3XjDdZSqSLU0JM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ts0UWYFh; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ts0UWYFh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721871168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LyzxTagTU4yj7oHgWRzHQbbpQVmDDWL4VI+84EdA2Xw=; b=Ts0UWYFhjntKkzPMpY9onba8lwbSVpobr2VG+6ihYwo4etJwNbTqTC9V8dIN5S3/J+zD5L 3kWPImLeoRa7lUxNPfyMwmeav7Nh8AKi1sz7eK7KMoMmTpL0fBRbD/VuVZ6zOKmXX5h05z ee4OOm36d3ZrRhLqrIpDWGI3tiNezlc= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-390-_ayhg8jcOCazEdAX-TLUFQ-1; Wed, 24 Jul 2024 21:32:45 -0400 X-MC-Unique: _ayhg8jcOCazEdAX-TLUFQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E7D191955F3D; Thu, 25 Jul 2024 01:32:43 +0000 (UTC) Received: from server.redhat.com (unknown [10.72.112.141]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AD4021955D45; Thu, 25 Jul 2024 01:32:38 +0000 (UTC) From: Cindy Lu To: lulu@redhat.com, dtatulea@nvidia.com, mst@redhat.com, jasowang@redhat.com, parav@nvidia.com, sgarzare@redhat.com, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATH v6 3/3] vdpa/mlx5: Add the support of set mac address Date: Thu, 25 Jul 2024 09:31:04 +0800 Message-ID: <20240725013217.1124704-4-lulu@redhat.com> In-Reply-To: <20240725013217.1124704-1-lulu@redhat.com> References: <20240725013217.1124704-1-lulu@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Content-Type: text/plain; charset="utf-8" Add the function to support setting the MAC address. For vdpa/mlx5, the function will use mlx5_mpfs_add_mac to set the mac address Tested in ConnectX-6 Dx device Signed-off-by: Cindy Lu --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5= _vnet.c index ecfc16151d61..d7e5e30e9ef4 100644 --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c @@ -3785,10 +3785,38 @@ static void mlx5_vdpa_dev_del(struct vdpa_mgmt_dev = *v_mdev, struct vdpa_device * destroy_workqueue(wq); mgtdev->ndev =3D NULL; } +static int mlx5_vdpa_set_attr(struct vdpa_mgmt_dev *v_mdev, + struct vdpa_device *dev, + const struct vdpa_dev_set_config *add_config) +{ + struct virtio_net_config *config; + struct mlx5_core_dev *pfmdev; + struct mlx5_vdpa_dev *mvdev; + struct mlx5_vdpa_net *ndev; + struct mlx5_core_dev *mdev; + int err =3D -EINVAL; + + mvdev =3D to_mvdev(dev); + ndev =3D to_mlx5_vdpa_ndev(mvdev); + mdev =3D mvdev->mdev; + config =3D &ndev->config; + + down_write(&ndev->reslock); + if (add_config->mask & (1 << VDPA_ATTR_DEV_NET_CFG_MACADDR)) { + pfmdev =3D pci_get_drvdata(pci_physfn(mdev->pdev)); + err =3D mlx5_mpfs_add_mac(pfmdev, config->mac); + if (!err) + ether_addr_copy(config->mac, add_config->net.mac); + } + + up_write(&ndev->reslock); + return err; +} =20 static const struct vdpa_mgmtdev_ops mdev_ops =3D { .dev_add =3D mlx5_vdpa_dev_add, .dev_del =3D mlx5_vdpa_dev_del, + .dev_set_attr =3D mlx5_vdpa_set_attr, }; =20 static struct virtio_device_id id_table[] =3D { --=20 2.45.0