From nobody Wed Dec 17 02:56:49 2025 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4B5313D610 for ; Wed, 24 Jul 2024 22:54:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721861674; cv=none; b=cV/A5voR1UxlXD8VGXpoMcAv+RlD6Sf/t2Z5hc4f+4lbr8h1y1rkdt1kemM3o+Mn5ZJJr/DqMBV0G5n/qTUCxzZ9RStkef0xLDk48Xy+KeUAevWjLLDWQYxIf3VmeoSawR0g+QhoeC5S8upvJNiNh7hNQqkHa/mBOvpnLQQryIo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721861674; c=relaxed/simple; bh=OP0JdHoSd9gMBU62TPqG4ciM1LELFK61GDnQjRxEkpI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XoF0DuQii04zilflDnkmegfShIzxCew/kYikjTsaslRTOHbD2K5NE79g/z1bcI/jlZzapapVFRm4zHh7GgjKKQwGsXwYuRjW67eXjRG5GoMSIDQ08tih450JCO74zSffYwIgTwspkDAForqYCqKKaRjTvDhEfIqaVMseUb5G8hI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=njLUo5js; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="njLUo5js" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-70d199fb3dfso268737b3a.3 for ; Wed, 24 Jul 2024 15:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1721861670; x=1722466470; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tDb9UcxpPJ+x+vOamEQvSw2xOsae11rJfZQoPCR9PSA=; b=njLUo5jssxii1UDYO2QPlpaRMuAZh7EtVBA+fZ6RcVf/jI9pwAHgXxW9V+ZA7Urops ET1+KkVPg1lNYEc7VoydSqPwQGNpj1zsRECAolNN+rsHuYoY8KjC74HATC0IRgdflGC7 NKEBubk7/va4Jd+oKxCN5r4ce+V8zMyK5XksmXHRrEIDKdvOSQkhv1Asy75/mpX7j3uA F8ZlpfwnPc/JyhhPczv1GCKhBvPLDs2XNWbu4fYi3e9jaDzIFPKDndLdg60jxWJcJ17U aU3ErwM0fMwRjvMeQivxjiGto4LEN5wRm6cWhiQum9qDe4wgL+R2Qi+QGetwIQUNGQho qqZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721861670; x=1722466470; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tDb9UcxpPJ+x+vOamEQvSw2xOsae11rJfZQoPCR9PSA=; b=m3mWxstwaWmpBhx1GOiS3pNvkzf2LjDbqttrLRUTUHikaUDSwslLVbSSQH5dQPpqpV OUNklZyqFS2bIbkeifekRrcMbEwIuwL/u6VNchDPc3jROjlB8yJSkPuHbk6KwRMDO2bZ eaUbz4nbYTw5HguuYd88KH31t2bUH4zYyvBsKv1CeQjp0kh22hZlBD4LoX8TcFX21OvB 8qADa+BspK8qOqmhvNDQeMswcoW1LlL2ogHJA/ix2gwqyUBaRhPRHEdf4pe0VODgIUiI FPQP3J5jKpc4Mv1E8H5lVf+k/hUORonuX+FQtsLcRQbsOt7gppHuihlNbloobfF5xGtn Bn9A== X-Forwarded-Encrypted: i=1; AJvYcCV3mA7gWoBCIGBaJ2XrQ0dQdY/iDhVG16LpkAZ7TpTZXZFDWcj8fNf+B5T6YW5uc4q4OshTae6XmJPB1vodAQSo4avmpKVHnVz3sYsb X-Gm-Message-State: AOJu0YyqhlX0MdvUo1FNLcrQHEJ7Rq0X9b7u/l5bzFYuyikNxyBLy287 +zGjgtdsUVIxBsyJ6wfFe2W0zC85rOV/pDsjV98aUyic5VkJxF3bBr9N41KiuaM= X-Google-Smtp-Source: AGHT+IF9fif1HCfBJ4YhIrH1wtC24GQEnJ5adEf6WQQm+HSY06XkFnQlsT0TMF+ih4DDmrs90zkr0g== X-Received: by 2002:a05:6a20:12d3:b0:1bd:18ee:f145 with SMTP id adf61e73a8af0-1c472803abdmr1849216637.1.1721861669976; Wed, 24 Jul 2024 15:54:29 -0700 (PDT) Received: from charlie.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead874c6fsm74992b3a.165.2024.07.24.15.54.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 15:54:29 -0700 (PDT) From: Charlie Jenkins Date: Wed, 24 Jul 2024 15:54:11 -0700 Subject: [PATCH 1/2] perf: Add PERF_EVENT_IOC_INC_EVENT_LIMIT Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240724-perf_set_event_limit-v1-1-e680c93eca55@rivosinc.com> References: <20240724-perf_set_event_limit-v1-0-e680c93eca55@rivosinc.com> In-Reply-To: <20240724-perf_set_event_limit-v1-0-e680c93eca55@rivosinc.com> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Atish Patra Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Charlie Jenkins X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1721861667; l=5119; i=charlie@rivosinc.com; s=20231120; h=from:subject:message-id; bh=OP0JdHoSd9gMBU62TPqG4ciM1LELFK61GDnQjRxEkpI=; b=xk6OYmV6UNcRRVlbkOqATweVf+A0I3+Nel2KBoFXVaG9WmkaZy235qX37LIex6eODtMs9Fc3j pUEQnO+Sm0jDfN85eaQNcOKBI42GGWw2z8bn/NzLqq8cH5v4Fiife7E X-Developer-Key: i=charlie@rivosinc.com; a=ed25519; pk=t4RSWpMV1q5lf/NWIeR9z58bcje60/dbtxxmoSfBEcs= PERF_EVENT_IOC_REFRESH immediately enables after incrementing event_limit. Provide a new ioctl flag that allows programs to increment event_limit without enabling the event. A usecase for this is to set an event_limit in combination with enable_on_exec. Signed-off-by: Charlie Jenkins --- include/linux/perf_event.h | 4 ++-- include/uapi/linux/perf_event.h | 1 + kernel/events/core.c | 17 +++++++++++------ tools/include/uapi/linux/perf_event.h | 1 + 4 files changed, 15 insertions(+), 8 deletions(-) diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index a5304ae8c654..40025a5eb98a 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -1103,7 +1103,7 @@ extern int perf_event_task_enable(void); =20 extern void perf_pmu_resched(struct pmu *pmu); =20 -extern int perf_event_refresh(struct perf_event *event, int refresh); +extern int perf_event_refresh(struct perf_event *event, int refresh, bool = enable); extern void perf_event_update_userpage(struct perf_event *event); extern int perf_event_release_kernel(struct perf_event *event); extern struct perf_event * @@ -1770,7 +1770,7 @@ static inline int perf_event_read_local(struct perf_e= vent *event, u64 *value, static inline void perf_event_print_debug(void) { } static inline int perf_event_task_disable(void) { return -EINVAL; } static inline int perf_event_task_enable(void) { return -EINVAL; } -static inline int perf_event_refresh(struct perf_event *event, int refresh) +static inline int perf_event_refresh(struct perf_event *event, int refresh= , bool enable) { return -EINVAL; } diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_even= t.h index 3a64499b0f5d..992f51effb27 100644 --- a/include/uapi/linux/perf_event.h +++ b/include/uapi/linux/perf_event.h @@ -560,6 +560,7 @@ struct perf_event_query_bpf { #define PERF_EVENT_IOC_PAUSE_OUTPUT _IOW('$', 9, __u32) #define PERF_EVENT_IOC_QUERY_BPF _IOWR('$', 10, struct perf_event_query_b= pf *) #define PERF_EVENT_IOC_MODIFY_ATTRIBUTES _IOW('$', 11, struct perf_event_a= ttr *) +#define PERF_EVENT_IOC_INC_EVENT_LIMIT _IO ('$', 12) =20 enum perf_event_ioc_flags { PERF_IOC_FLAG_GROUP =3D 1U << 0, diff --git a/kernel/events/core.c b/kernel/events/core.c index 8f908f077935..b9d009733ace 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -3142,7 +3142,7 @@ void perf_event_addr_filters_sync(struct perf_event *= event) } EXPORT_SYMBOL_GPL(perf_event_addr_filters_sync); =20 -static int _perf_event_refresh(struct perf_event *event, int refresh) +static int _perf_event_refresh(struct perf_event *event, int refresh, bool= enable) { /* * not supported on inherited events @@ -3151,7 +3151,8 @@ static int _perf_event_refresh(struct perf_event *eve= nt, int refresh) return -EINVAL; =20 atomic_add(refresh, &event->event_limit); - _perf_event_enable(event); + if (enable) + _perf_event_enable(event); =20 return 0; } @@ -3159,13 +3160,13 @@ static int _perf_event_refresh(struct perf_event *e= vent, int refresh) /* * See perf_event_disable() */ -int perf_event_refresh(struct perf_event *event, int refresh) +int perf_event_refresh(struct perf_event *event, int refresh, bool enable) { struct perf_event_context *ctx; int ret; =20 ctx =3D perf_event_ctx_lock(event); - ret =3D _perf_event_refresh(event, refresh); + ret =3D _perf_event_refresh(event, refresh, enable); perf_event_ctx_unlock(event, ctx); =20 return ret; @@ -5920,7 +5921,7 @@ static long _perf_ioctl(struct perf_event *event, uns= igned int cmd, unsigned lon break; =20 case PERF_EVENT_IOC_REFRESH: - return _perf_event_refresh(event, arg); + return _perf_event_refresh(event, arg, true); =20 case PERF_EVENT_IOC_PERIOD: { @@ -6006,6 +6007,10 @@ static long _perf_ioctl(struct perf_event *event, un= signed int cmd, unsigned lon =20 return perf_event_modify_attr(event, &new_attr); } + + case PERF_EVENT_IOC_INC_EVENT_LIMIT: + return _perf_event_refresh(event, arg, false); + default: return -ENOTTY; } @@ -6721,7 +6726,7 @@ void perf_event_wakeup(struct perf_event *event) ring_buffer_wakeup(event); =20 if (event->pending_kill) { - kill_fasync(perf_event_fasync(event), SIGIO, event->pending_kill); + kill_fasync(perf_event_fasync(event), SIGTRAP, event->pending_kill); event->pending_kill =3D 0; } } diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/lin= ux/perf_event.h index 3a64499b0f5d..992f51effb27 100644 --- a/tools/include/uapi/linux/perf_event.h +++ b/tools/include/uapi/linux/perf_event.h @@ -560,6 +560,7 @@ struct perf_event_query_bpf { #define PERF_EVENT_IOC_PAUSE_OUTPUT _IOW('$', 9, __u32) #define PERF_EVENT_IOC_QUERY_BPF _IOWR('$', 10, struct perf_event_query_b= pf *) #define PERF_EVENT_IOC_MODIFY_ATTRIBUTES _IOW('$', 11, struct perf_event_a= ttr *) +#define PERF_EVENT_IOC_INC_EVENT_LIMIT _IO ('$', 12) =20 enum perf_event_ioc_flags { PERF_IOC_FLAG_GROUP =3D 1U << 0, --=20 2.44.0 From nobody Wed Dec 17 02:56:49 2025 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6660013C918 for ; Wed, 24 Jul 2024 22:54:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721861674; cv=none; b=frmwgJgwpRv6jYZ5X/nNmESBydlkzj6Uib6G3U1A3S5Lce1Kwbd2/z9Sx3o8frs14NzwI8KW5fetyYgVMGe0IQJfEXG37VlhaLT2h4fFLRgEO1EP/riRReJD3g5vMee+ZcCL9Ul1NGDZ2hPCL+Lkz8ra1hC6ZWY02cniM8d0ZGU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721861674; c=relaxed/simple; bh=4M35RJ0MrhFzvtO/gpzcZAZGyvkPqgVAOXcftDMuvps=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BjDuAbkIAxec235eI7+eD4qTHxb9UDGoukHjI55joqVBpyFnPJkugcWKbQD4A/T7Wg4GGgZ4JBPrQaoDvNMxa2SJu1gEfWNDh2alEihx5PDpSD4rUwpwVynL5Kg/LtKNhMuOnV+y9vBpPDhl78z28CXW0SIOSeHEN82WGUDFENw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=oI/1eCgE; arc=none smtp.client-ip=209.85.160.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="oI/1eCgE" Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-260e5b2dfb5so145500fac.3 for ; Wed, 24 Jul 2024 15:54:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1721861671; x=1722466471; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BSkmGq7ZrZbXdHouXcfFGOgcX1f8uJ3n8uj4r7vA1PE=; b=oI/1eCgECsTYCFEA0gQCJhXJ82oFmmIiP04yF7Fe5eVU2zyiHJ+yyX/uEMtzPNwSIz +UjB75/bMxLwy3ShA+p9pgkbwyuY1Ythp6O5wKE6Zzg4+fJiV5u1RQ4WoDfqlX3GSD2J YBzY4pV6zLXcyqBuFxie0xqnzP8UTDQdkgckkqXmqh/E2/NbM8VZLtMrWp8IBQaRFHpa RZec0u1CZSr16Lkf+jMGPxPWCuLzaH6Q4i5elCeR6pUfe64lsZJbggOvZkBVZ3ytBmTR huEirdnB1u7dIOslpeSer/oKuVkk/7uMQHeg2nF88sP1HG7kV1rNjGAiwEgRk2f10RBj 2Iig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721861671; x=1722466471; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BSkmGq7ZrZbXdHouXcfFGOgcX1f8uJ3n8uj4r7vA1PE=; b=iNavehxR7EjS6VGSe63GwKN4Mna6Glc7Kz+kEwTp2Ou8NinN+P9co85xKGA5BjdcIW 7JKoiWAEcldYL4XvRvEyjwgjsNEAdkkaKOJk1QoNNKOWfoRbYDnW4ryAVz9hCgs1Frug Mm6Ae0/jL/f8FJlHcLt7PItBfmgr1BfbXoAXw7FYXoFDG986qXZp8FSZ3tzg4H2emyBQ C0CPVmPO4XABuy0eZ64VftpE41h7wTckzbtxojtjWPbIxtS1lTcxjmPi7wj6yrP+MYUP UtIr2M2IZVDc1vgrNq6R1Fyf8AspLoiQhUSYJEbjuPnw45aFn4ZALrtOlbIFUh8iAqlu mUDw== X-Forwarded-Encrypted: i=1; AJvYcCVp5NVsagHEtUXX/0OCMB4LUIwgd/ZOxnRwLZzLHEiz5DzQVs2ISLH65o+NvfydXuWmtD0Py3F5bgbSM4G3+rsOe8lKtKo6SRh176Gu X-Gm-Message-State: AOJu0YwB1PU47hCpdmmsERRBbSzpITrNii+eaGWm1LGVkJzl36CGLpdX paRX2mNelCBJHNyuLb73RMn7R1x7bAShGfLOK8bUACR4RkkwuzfxnV6hmKT4KzTxeNt/CUBxUHq V X-Google-Smtp-Source: AGHT+IEkOVbZUMgs8KjJIn54klAlrolAUh6zjRu2D3dQNCcUv5496n2AzBl9GvX9rDRx8tTdsQtvTw== X-Received: by 2002:a05:6871:6001:b0:260:fc8c:2d28 with SMTP id 586e51a60fabf-264a0e0b39cmr1137866fac.22.1721861671250; Wed, 24 Jul 2024 15:54:31 -0700 (PDT) Received: from charlie.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead874c6fsm74992b3a.165.2024.07.24.15.54.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 15:54:30 -0700 (PDT) From: Charlie Jenkins Date: Wed, 24 Jul 2024 15:54:12 -0700 Subject: [PATCH 2/2] perf: Document PERF_EVENT_IOC_SET_EVENT_LIMIT Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240724-perf_set_event_limit-v1-2-e680c93eca55@rivosinc.com> References: <20240724-perf_set_event_limit-v1-0-e680c93eca55@rivosinc.com> In-Reply-To: <20240724-perf_set_event_limit-v1-0-e680c93eca55@rivosinc.com> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Atish Patra Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Charlie Jenkins X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1721861667; l=886; i=charlie@rivosinc.com; s=20231120; h=from:subject:message-id; bh=4M35RJ0MrhFzvtO/gpzcZAZGyvkPqgVAOXcftDMuvps=; b=Ft1lYHdZdmWJU19FBYN1LMTLSqpqK9Wblkotv6+rB4MEMMnCzwlA1VGTJPEZ6Ma4ZEXBf2s4b gWs9Eg58Rr4AyJkOjYV2FmoT85V2BsuXM+5lI0uCnMS6HfFmTK5vsvq X-Developer-Key: i=charlie@rivosinc.com; a=ed25519; pk=t4RSWpMV1q5lf/NWIeR9z58bcje60/dbtxxmoSfBEcs= Introduce PERF_EVENT_IOC_SET_EVENT_LIMIT and explain the differences between it and PERF_EVENT_IOC_REFRESH. Signed-off-by: Charlie Jenkins --- tools/perf/design.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/perf/design.txt b/tools/perf/design.txt index aa8cfeabb743..1626ae83785a 100644 --- a/tools/perf/design.txt +++ b/tools/perf/design.txt @@ -439,6 +439,11 @@ Additionally, non-inherited overflow counters can use =20 to enable a counter for 'nr' events, after which it gets disabled again. =20 +PERF_EVENT_IOC_REFRESH will increment the event limit by 'nr' and enable t= he +event. To increment the event limit without enabling it, use the following: + + ioctl(fd, PERF_EVENT_IOC_INC_EVENT_LIMIT, nr); + A process can enable or disable all the counter groups that are attached to it, using prctl: =20 --=20 2.44.0