From nobody Thu Dec 18 11:55:57 2025 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2082.outbound.protection.outlook.com [40.107.22.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E591D157E84 for ; Wed, 24 Jul 2024 15:46:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721835976; cv=fail; b=I7TerChUM3HX5XAgiL4nXpjgHLZazzSGamKDrhzP7KM06ZRIOceWkpI86l8lqLKzTjazdXwqARjbBf5sqJqAnRyDCwgqbImnR8fnAb7GqiCEshgexIIgizkSUwvGQgEIAGtnTfHf31S+tSBhoShAH8Er2Yu0QA0VB3LMzLn5U9A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721835976; c=relaxed/simple; bh=/JI8s94ok2z+hT6L0BfTNT5ICOc99IOP4jbZmyhmqiE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Hs8uOKkg6cxsE6NwranSX+yy/uI7n+SzL6dxuHxtDBI6X/N5RgpmrH6WPEDe9MMDdrQMrsRRFbxl0rn2i5moJhQhoNmmswLcAoi5FxmYmAN3uHC1y6zlB8+5/nyq9Mt3DxhSPgYphrF/b9ah902tBwy6IuWw3nUGMRgPjFlk0LE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=a4QDHlwo; arc=fail smtp.client-ip=40.107.22.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="a4QDHlwo" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UL/Q7HnL5kAoc3JStDozAoCPI170iu81xwYIytYfspGKQpcFzdCZ3nx/51c6k5cn2wg80oR36UZasNVOv4jHaAoyKRXUpIaDnk3mL6ZV9G8OcvkggCbmdtoP0CxGbS7XerPiAsDtObEEcwcOb974f9+VExL312XGv2UOuDVmsOr8AgiK8OvuDl7nLzxDVCiXUnDrLHl3wK7Zwh4LsCaolZo4Xkba6IyWjQ28tIRgxd9rNDzGXf0ti97wjSbbRaGonod4fJkE8eCVuvjXbcvffqTkYji+LLmMF+paes/pYc+xuORx75jGPv+N47VqZChgdOhozAvaDrTdplk/ZiCXlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iEH3AqOKfHzxwLjQgVs3Ok5rqhSw+ALKLhi5IuDAIjI=; b=msO/EdVkx2mV9sT0i1lpSL3vgzOXI3/slTEqwN0P8jFNSGsZW2aJDS9Zk/hoe3IVQtIukF3HqtB9kPRg3OKtguZEP6Qi9AEUdJvUbuM0pFRygUl0aBZPifBRhn9JT+uDGNu+ogwrxaFQWEYWOJaAFaKf6FSbnbn4SwPoMyeIf6eK6PpMKAAYLJsdYxOkhM/Z1podt3nmDFJOArRpUwdleVKWY9Nt5AV0Gewxaf6sOr4nYIGuwJWzp0dGzeDmRQ9Lig7WyTB5s0oEyveJw6XmjGoJNgrT4Ls2B9G6zNulGyw1CrilRMr4n/aOoXmYNEQifDKl9vhmrYMyuttHXkaM1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iEH3AqOKfHzxwLjQgVs3Ok5rqhSw+ALKLhi5IuDAIjI=; b=a4QDHlwocieW2UypgvFfBg0npeEBrCOCLsMZcVjMN7MMiVDNX4LogWPJdInIuWkw3OFLUYPtEa351AYAf6Bm15dR0G4yYpTwVqhe1A4dZwERb7WGH+AwcZ7LSXg8Y5eV1wWjnDpGJE8J8slVJt0uP89u45xzhmSh9G3/+fxkotTbsc94IxKCqwero4Oibfrp3bIsMzojfUasvAcBuj826Eudwu7Kh7O4YhgpCUUCepMdE7TDyvq5N/BshEu5jzxfPLwvE3Hp/ZaBSdEztIfoQDkd9buyhsxGPEsW5oxazosjXzy877p09ySGaU2gRs8hAMovTh8hY1QgJ/9e55d04w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by DU2PR04MB8599.eurprd04.prod.outlook.com (2603:10a6:10:2da::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.16; Wed, 24 Jul 2024 15:46:08 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%5]) with mapi id 15.20.7784.017; Wed, 24 Jul 2024 15:46:08 +0000 From: Frank Li Date: Wed, 24 Jul 2024 11:45:46 -0400 Subject: [PATCH 1/7] i3c: master: Remove i3c_dev_disable_ibi_locked(olddev) on device hotjoin Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240724-i3c_fix-v1-1-bfa500b023d6@nxp.com> References: <20240724-i3c_fix-v1-0-bfa500b023d6@nxp.com> In-Reply-To: <20240724-i3c_fix-v1-0-bfa500b023d6@nxp.com> To: Alexandre Belloni , Boris Brezillon , Parshuram Thombare , Greg Kroah-Hartman , Boris Brezillon , Arnd Bergmann , Miquel Raynal , Conor Culhane Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1721835962; l=1374; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=/JI8s94ok2z+hT6L0BfTNT5ICOc99IOP4jbZmyhmqiE=; b=vyxohMNLsA1z6uxTUSTcPrthrJborPex1MOrjSPVRNKz/05KfcjgbQG571ILWthcw3HcfFCHg jrp+UIZPzKTDZNIjlTe3JN0zpCKFlavy19fbLG+9BOEF7RteESp2hXZ X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR17CA0008.namprd17.prod.outlook.com (2603:10b6:a03:1b8::21) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|DU2PR04MB8599:EE_ X-MS-Office365-Filtering-Correlation-Id: fea120cf-7f9f-48f7-9e90-08dcabf7bc59 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?KzN5NGlLT29SOWNSVVRsdVpFNzE3T0lZNVNWSExGYnRlbytlSXpBSXhHS0Fw?= =?utf-8?B?Skl2QmhYUmJOanFvWDVZR1F2djJrRzZ0ODdIbjRIRmZqOTRDNWtucUNMakN4?= =?utf-8?B?MXJtaVlSZEQ5QXNJbTJYbTFHcTdTV1p4YWRySW9zL0Mwa0h3amRVNXI2eXV1?= =?utf-8?B?alpYdGRrV1VwTmtqTDl1cjlsdHRXVUg0OWdlc0Rqak9FOVcrMUhjNGFBSE1j?= =?utf-8?B?NHlmZVVySHBDcWdyRkhjWTlydmp5NDhqWEJhb0dxRWFKU2xCK1Nka1dTU2FN?= =?utf-8?B?OW5iT0t6Sm53UVJGSVI1Z05RdGt6czRCS01OeFB6VVFmTFBVNGVBbEtnakFw?= =?utf-8?B?akZoL2U5eUN4aTRQWHFGSHBrRnhpVG81Uk84QjdsZDNQRmpXS1dIZGl2RE5U?= =?utf-8?B?YVRIaiszbTcyYVY4bmlVVnNBaDVERGtsMERFSVdxT2wrSlI0ODN4UWlvaUk5?= =?utf-8?B?MXQwZng5aU9WSzM2dnl5U0VKOVVxdEttSEMzbWZBbVg1YjU5N081bW5ZaGcy?= =?utf-8?B?RTgwemtrUUZLellSWVpjV096N29jRlA2V0lYS2ZUZ1VtOGlreTZrbVVrUitt?= =?utf-8?B?L0dKQ0phVzN1YUlqRk0wc005ZFpWYm1QaTM0NFNTVWRzeXV3Y0pOeDhkcyt5?= =?utf-8?B?WmYra3kvSVpsWkU1S28xVGdKbTRsNjJDYlBrRFlZYWJyamdhQVBlZjg0akVr?= =?utf-8?B?K0dabVlBM2FNZEJUOXNacEkxMnhEYlUrWUdCeUJkcllQQnJ4ZWZEUzgvbkg4?= =?utf-8?B?SlpJemhRRnozSGNtejBnK0RjeXFsU2x0Q1Eza3VUcXpkQ1hNNnRjQzdqT0Fk?= =?utf-8?B?bWxDbXpVUW1DUXFQa0FSUlRoQjFqQlJJTUhxaVVveGltVnA5UngrcEdkTjk4?= =?utf-8?B?ZmVzSzViK21jZXZnMEhnRktMTXM3QnhVOUpuTzhIQlRoSUZhSlMvbXNnakV1?= =?utf-8?B?Q2ZoWnN2OE5Ec2lxMGFPNGxYRmsvVHdYOXhFaEUwc1hUV0w2WlZ4YmVMS0t2?= =?utf-8?B?NkZKV3ZPbUNtck5yejRjdnlMWkJaKzJMb0oveVVQc1BWeG94Mkk4eEdtTDBk?= =?utf-8?B?V0NTaE1kWUZuWjgwVXFab0wrb1ZudElaWE4rQkh1elowckU4eG1UL2lsaWFE?= =?utf-8?B?c3FxNkhiTTY0MTN4THI3cm9NQktpQXdIckRJQVAwKytGOEpkb2haY294K201?= =?utf-8?B?UExzUGliTmJXVkxyS3JxUDVJUlVlcSt1cUVzS20zajRoS2NmUkpBditIcFVq?= =?utf-8?B?Q2dkOGlxcWFzRDVIQmVheXVtMjhQZW0vYzBQU2JsYVVMRnQ5Nm1pV245L1JR?= =?utf-8?B?YmZpUkJKYUJ4THhyNFVIZEMzYVJXdzBVa0tGTStPak1LWG5rcW1sUEVtbnpT?= =?utf-8?B?ZkZYWGFwZElHcXN4YmVuS3RzbG0rK2cvVXRwWUg3WW5wbTlZRnl6eVRlZTRI?= =?utf-8?B?MkxHaHN4RFJWZTUyc1VyTHhpWHJ1TU82N2owNlhyTzZEMlNrSzJQVktnaTZJ?= =?utf-8?B?MW9jSFd5NnZUbmNCOW9VVEdYY3lIK2xsVGJDWEJOTEhlbWRpL3BYeG42eU5v?= =?utf-8?B?bnFWdTlRNjZYOGgydVpQNWRtYkV4UG1xdWtxVFRjakFiVEhpYnJCS0d2ZWJX?= =?utf-8?B?Z3g0YlNPa0hBQWd0ZGZZekV4MVJ0Q2UwS0E2MnFjSy9QNzNoLzQ2eVJlQWxQ?= =?utf-8?B?WXVucWVwYm1zQm9GMUduVEVnWHVGaFJkL3ZxNDM2cVhveE0vcmhVbUFiS3di?= =?utf-8?B?a3V2bXM1UVdBVHRGS1hacXdBaHpTblBMbUpaSzBzSDA1Skd2dTBObVZPSXAy?= =?utf-8?B?aktiaXEvV1ZrVFNrWGxLSEhTaWdWSThJaGtJV1ErcjEwSllaenBtUGVOZjFM?= =?utf-8?B?c0tLYW1MM21VMG9NdzJxZWc5TklYbWJKYWVaczRDQ2NPekE9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWd5Q3poMGlPdlJkbldhdkhRMEpWc0JhYU1zVkJDWDdsd3BXajZ2ZCtZeVJu?= =?utf-8?B?UDlZRTdYclpJdTFZKy8yS2xiNmg5SDUxU0wyaHNzWHBUdVFPK3N2V0UzdkRI?= =?utf-8?B?ejNMMCtSZnhGckJZOFBlamx6bmRYT1JBdnhxMGZjSnlyVHE3aUhHVWM4Qkp0?= =?utf-8?B?SFFFd3ZYTndxV21rRkJVWVlVTS9FTU01R0IrVm4vMnhCL1laQkpxR0ppaFIw?= =?utf-8?B?SGZtdmhLOXJ1cFc2dk85T3ZaWWF1T1hJbE1XMmd5RGpad0FsQVRjK1dYc0Ny?= =?utf-8?B?UlBPUy9tUTExRXNtZk1icW80dkkvOVFGd3BJRmhYeUo2QXh3WnFwYm8yTkNw?= =?utf-8?B?akhET2xjOWNnVzR4aHMwcEFWck1IelViNWJlQ2J1dzg0SWlXdStCWkkwa2V3?= =?utf-8?B?UnpGZUQ4SUlXbElvRzNFVTN1eGFLYmE4azhESHBWZ3lFTEZMWmFxb2dwK1Zr?= =?utf-8?B?S2RhR0NUTFZEcXZqVHR1N2M3SmI3U1VUVHNKNnlpVlBqd1ZIT0lKc2wwb09x?= =?utf-8?B?V1NXVDVTRm5rWi9ld0E0YUtaZm4yK1VlTzNLc3Y3TnV2d1RDQWorMVJMUEQ4?= =?utf-8?B?M0xKU0QxUTY1YU93R1dwczVSVFNpRHlRSFdQS25KL2xucExaL3FVT1o3MVNz?= =?utf-8?B?Z29kSUUzVVlWbFl0TnJmQ200TjFRMy9KdU4xdHkrQ2F5NFZLNmFkK3NSSy9T?= =?utf-8?B?U2pNTkE1Z2E4Wk82UkEvK1NKSDFnREJCbUtybU9vNU44REp4Qkh3ZGlSOXZO?= =?utf-8?B?SWc5ZEFvUUxxQlZCWVFsRFZ0d1lmL1BzZmI1cjhkMUJ1Ui93dUhmbWdiQm1r?= =?utf-8?B?S2ZkMU5UYjBGVkU2Q0VnUHFGMXl1azlaYUgySkZ2ZW1rUTh2K1VHWWk5OE95?= =?utf-8?B?VnVoRldodG9tZ1pIalVEYk1UcVJ1UndNUHh1bWppQ243YW5Ybm9GTm5wY2NO?= =?utf-8?B?ekFXaTVvb3lJMGxENkVUUjhjbWxEWHJ3bTE4VTlBNGxLSk4xZDJDLzVoTWpz?= =?utf-8?B?MG84dzFOMnVyRWZVRmI3K243THFtL3hQUnpWeldBb3diK3ZYaGhFUEUxUDM1?= =?utf-8?B?OWRQVktVa0EwbVNrQjJibitlS2Rvay90NjRVYklQOXp0SjVHd0lVR3l1UGlr?= =?utf-8?B?RWZwcm04OVRPSFdZZmFsZkFGa0hzWkQ4WGx1bDJSUi9PR0ZTalhiaU5RMVY0?= =?utf-8?B?SzVXUm9kdVlhV2JVa252ZTd6ZDB6SU9BdlU4STUvQ05Ed3hMUVB2N3JTVk9B?= =?utf-8?B?Zk1MUjhmb2o5M2J3TzQ2dVdUeWV0QTdmZHdqazUxVmpqbTQ1OWxQd2thSGEx?= =?utf-8?B?TUdOS3U4bHo4dzllajdrVERmSjFiNmgzaXdnQUxialNnMXJMVGltNlhSZkkw?= =?utf-8?B?VDRKQXhjbUhKSVRnV2duWVk1L1BSbmNJYXhvUGJLeXNiTEwybzJQY3BPSE9H?= =?utf-8?B?U1NvOHQ3WTdoZFVTVHJkb0RJT1ovclpuS04ydFdLM1k0RmhKWlFiVGVJME5p?= =?utf-8?B?bHpLUVdBdFdwRlRoTUFBV1owS1lrRFRPN09jK2NjUUN2SzRyTkU5dThVZU5i?= =?utf-8?B?eXNGRHlOdWlOb2V5QlJMaGdYbEQyUXFqRFZabjZ6bEdiTGY2N0hOclJocG53?= =?utf-8?B?TFdjR3dSYnY2L0JDL1J6QlBsVmhJRlVGZFZSbXNxY0RNcmZJWW5ERkJIbUtL?= =?utf-8?B?Z0gvMVVpWnltZUVMYUNmYjVUSzU1N25qZ0dNT3o0b3lyZG9VLzJhZ2ttY2Nl?= =?utf-8?B?WkJJWnNrcFlpYnVRY0NYNkRzK3ZUS1JMMTUrc2NWQlVLcSt6eHdPUXI5aXRj?= =?utf-8?B?eDJQYUoraTM5dzQ0TTlMVkozdkZhQ05JckNVVkhTUDgwcnN5YVB3ZDVSZER0?= =?utf-8?B?VFdJVXJzWTRjNzZxOFV2SkgwWFdYMkhpdTFaeXRHVHUvK2hsc2R4NFJ2aVB1?= =?utf-8?B?ME9vd0hrbGNXV1ByL1pPem96NWdyNWZQbitsazdSUTB2dTBTdVJuZFpsRnE5?= =?utf-8?B?djdXcG9QRHlLOTl6NC9CU1NJTVR1WG1vY2dNaXpIT2tUa08xTml4aDQ3NzAy?= =?utf-8?B?WXNxK3kxTGdOSXBTWkRmZGpQWmV3WC82TS8xTU5FZk1MVklrSjN3Umw0cHpW?= =?utf-8?Q?Xf3mCt5PBsq7HyWExX0CNvgWf?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fea120cf-7f9f-48f7-9e90-08dcabf7bc59 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2024 15:46:08.5959 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cMwWSxVc2t1XzCseARubJn3D5Kezsb6Im7O6B/4HdMS3HfsjcI0FE+IyM17MRACICJL+GR+8MBvijj9+POBOfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8599 When a new device hotjoins, a new dynamic address is assigned. i3c_master_add_i3c_dev_locked() identifies that the device was previously attached to the bus and locates the olddev. i3c_master_add_i3c_dev_locked() { ... olddev =3D i3c_master_search_i3c_dev_duplicate(newdev); ... if (olddev) { ... i3c_dev_disable_ibi_locked(olddev); ^^^^^^ The olddev should not receive any commands on the i3c bus as it does not exist and has been assigned a new address. This will result in NACK or timeout. So remove it. } } Fixes: 317bacf960a4 ("i3c: master: add enable(disable) hot join in sys entr= y") Signed-off-by: Frank Li --- drivers/i3c/master.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 7028f03c2c42e..852b32178b722 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -2039,10 +2039,8 @@ int i3c_master_add_i3c_dev_locked(struct i3c_master_= controller *master, ibireq.max_payload_len =3D olddev->ibi->max_payload_len; ibireq.num_slots =3D olddev->ibi->num_slots; =20 - if (olddev->ibi->enabled) { + if (olddev->ibi->enabled) enable_ibi =3D true; - i3c_dev_disable_ibi_locked(olddev); - } =20 i3c_dev_free_ibi_locked(olddev); } --=20 2.34.1 From nobody Thu Dec 18 11:55:57 2025 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2082.outbound.protection.outlook.com [40.107.22.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54EDB15B963 for ; Wed, 24 Jul 2024 15:46:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721835978; cv=fail; b=TGomCqYjnx5Q/JrvmZq/bCZvzxPjr3IP8NO7rTNnFNvw1RZaKvWwgUVtMPKe43ilaGQ4/NCOjHec+seGKEHxtIl0HjWTVFZgjddwwakoj1MkHxjJ7MFXAjR/rWeZaDKQbV8qRNN8+mjPEO+JU5E6AZuq/qXrE9eJhICEU+04W1o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721835978; c=relaxed/simple; bh=/8gjfrLEbeqdvh2UWIsUOXSQLlEPInExNiw2wP5o2A0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=dvt4BcyMK22zAH9OzDHjBHiMTYkyRtcLO9vSbWyRzGmmjXLN6XhiIuhOfMef6obDsxYP5Ke0qmD+oiBPa27P+bKmMEFPqgqfeObSgmr31S71WuubMvoikSpJNCK1s999ujFVc+SGqinLc+B80KZmxaaO2TwOejk3ZUlBZ1Ltsac= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=WXS+PVjc; arc=fail smtp.client-ip=40.107.22.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="WXS+PVjc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=A0hKXhIP09WxodGn6dj/F/2R7F/tPyOq+aFChGYKTdnmgQAD/z9+K/bt7W7fliVSEBekpKnsLX8dlSfet/MGHj5CGGvbuvx7R1Rc8zS1cEcHtmCGPGba2+LmmMX8qu5YqMiUuzI5mQ7PdQCi3qwCYoQxj57nNZKyYfjdMDqbCpaZiENY872WayDD2vTUsDPduLQdtNNBKPvauEqK9ME0TzMLNToOtoMjo1+Hve2N924cUPNgL068ZWu+ZIOMFh9gg+PXuqHStsFGCAzCVZ8SsHLfJBA8yALxUMihVonKI5OReEMlhj2dpJ5nHRjwyBVVrObQTvnYDN7hlkMgu0EI4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/H5YFp3nwDhvmKVPeBWxGQWI1IbbbTbtrRrxup0oAxQ=; b=qewuBOKZP4RwYXwcnEPATi8Fd20Hl0DoONQDXPQwHSJAQv2FOpBiIvL5H64RKRX7Dm+3yeRiPynKcaGS4OZj2i0GETyspxkNURVnU3ZfsErHQYOXVTTmzVOvv/i8AlD3m+Kw+5WW30XZPGOKbuUh3opcZdO6UCdT8L6wmxC6qKGnTFGGPjnHDBv5AWC4DB8+iehXbLzvJgMaXiA7DpxWhTcMmNeMXuf/LxrbPBwrW6OikhhVVq7Vs1yFlhHtR1O7ljd4ZDtR8ee6qxLQ9E4dAONslMmB/Jugbv0RDDnBEDuVZBo2xWe0R1SUbEPyrg8gAIc5Hq/PJj4l/sNhra02XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/H5YFp3nwDhvmKVPeBWxGQWI1IbbbTbtrRrxup0oAxQ=; b=WXS+PVjcKeqRF4jjgO7iLt8go+BMayzwf66w2IzcZOH/ExyldavC95D+dYBbybfiNtEBFDDIXOowTLOF4lv/awJtouyi/+5CjLzvLQkXgypCk3j35jyA4x0tLlat7nZ1ajz70gHu3zcAQ64iudMH4JJThDzm785h7z8Lcd+N93JCgexehoqDziPn9Es5wwpnBoKt/ug+klbb2F4zl7RdKP+POdset6eF2OaTh2oh0Yybugkq4QhPqZUQId53pAAgsL9X4/zL1GMFf1BBMWZ8PBHn43osGn0YcCSC3KNaHrcqxLdUkZvTQrE/THkTgqxXIgwYvZ3TshzBACEUi9tYLA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by DU2PR04MB8599.eurprd04.prod.outlook.com (2603:10a6:10:2da::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.16; Wed, 24 Jul 2024 15:46:11 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%5]) with mapi id 15.20.7784.017; Wed, 24 Jul 2024 15:46:11 +0000 From: Frank Li Date: Wed, 24 Jul 2024 11:45:47 -0400 Subject: [PATCH 2/7] i3c: master: Replace hard code 2 with macro I3C_ADDR_SLOT_BITS Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240724-i3c_fix-v1-2-bfa500b023d6@nxp.com> References: <20240724-i3c_fix-v1-0-bfa500b023d6@nxp.com> In-Reply-To: <20240724-i3c_fix-v1-0-bfa500b023d6@nxp.com> To: Alexandre Belloni , Boris Brezillon , Parshuram Thombare , Greg Kroah-Hartman , Boris Brezillon , Arnd Bergmann , Miquel Raynal , Conor Culhane Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1721835962; l=1901; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=/8gjfrLEbeqdvh2UWIsUOXSQLlEPInExNiw2wP5o2A0=; b=o3K+zGhp85Eo5QVg5L9biEGZcoVSDJXgyOoSG1pJZaeva+eIH2wEx1039sM8ZAULgIcYz9q/n zWlMN0WXdfhBxRe9XBnrX4yMFMzy578s75fzlZ2Vo22QPmPZngeO1Qn X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR17CA0008.namprd17.prod.outlook.com (2603:10b6:a03:1b8::21) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|DU2PR04MB8599:EE_ X-MS-Office365-Filtering-Correlation-Id: 5af0900b-d7da-4119-c89e-08dcabf7be49 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Yk9kRU9NYzFyLzRVd3BWZnJxdnNkRnRUQS9KVERIa0k2NVNrU0svd0FiMWs5?= =?utf-8?B?R200eituRHJ3Ym4zMkdKL0Z6OXcwV0h5Z1dNa09TYUkrcHo1eE41bmY5TW5P?= =?utf-8?B?aEdoRjJ3bWNFK0lXYkVVVnIrN1U0TU5HRkEwZ1VLaEVGWXhKQlpXUk0zM2dB?= =?utf-8?B?WkVKcmxvNi9PV1ltaWd6V2psbWVWeE1OK2cxWS9EdHRLRkZTVlVrLzBXYm05?= =?utf-8?B?N2xuOFdsK0phNm94MVNUaHlLVGJiNkFncXhVQ0RYTm1iRy9iMFNQK0N3UGp1?= =?utf-8?B?VGttU0J5b0xiMzZqNGdXOTE2OUpsdUdpQUQyYk1wNG92cG5DM2RLaWsxUnAy?= =?utf-8?B?b2NJNG9ranRvc1UxNWJxcTJRa2RSNXZTLzFTWGNsNXI3dEV3eTFMTzhlR2Uv?= =?utf-8?B?TGVwVHBnRS9DM0dra2svOHdYMS9YMnZZV3BBd0RFQzh6dGpoK0s5Y2l6ZHpO?= =?utf-8?B?bTBLdWIyWDRicFBqOGhlSndSK2ZhNHJBQnI2anBzUG5TWnFWOEdlSDFVTFJ6?= =?utf-8?B?NDdxN0o4UVc1VGJUT2xialFnQnQxZnZMSC9NbGEyKzF1SDZOQVh3aEQvMzh1?= =?utf-8?B?NFI4TEpGTE5LNE8zZ2VXR3lQSnQ4cWJ3c0xCQjBiTlFvVTZLVlR1cmlYQmVD?= =?utf-8?B?a2dWL1hWSVFmbmFFa29RSjlJVlZ1TVpOcUZ4UzRHcEhzZjUxTHNLM1BQSVJN?= =?utf-8?B?aHdzUC9VOGFKd0pveGI0WFFNQjY2YVh4RWQ1aFR4MlVjQk5uaDJTeUVFRHZh?= =?utf-8?B?T2QwT1FlaCszZHVqRGNycTVLQ3BtK29sZEo5SmkwdTN4cjRwTzFpZFA2aUh4?= =?utf-8?B?VjUrUEdVbXRkZzViNEFtK1I5MmlxMThVTEZCMGtkMW5qR2x6UUZlS0djQnVl?= =?utf-8?B?b1hRTWhPbG9GdVV6dWYydTd3WTJCK2haNHJ3ZWltMEVKQnB3cHdMeXFpOVhP?= =?utf-8?B?eldHQWg1Y1BvNnpFVlBueHVkdGN4TlpLMGxmZ2tJZnVBM3VtdVVGdkVIbVFh?= =?utf-8?B?bHU4bEdBTjNmdkVSRzdKNFAyaFgxS3ZzWXNsTDBnTHJQK0dYN0tBNDA5N0hW?= =?utf-8?B?Z3NCT25SU2JlcTZQL2EzdENaOTlvL25WRWx3OGtmSEo0bEVuSkVnVFBqVkxG?= =?utf-8?B?d0NoYzBSMFBWOTNwNmVyNTlYWmtMVnczRTRDNWI2QWFZQ2VNanVHcCtzczNQ?= =?utf-8?B?NEwxaC9RMmVvN1plVi85cVUwVG10YWsraGxZbS8vbU9nNUZodGN4KzBlaFFq?= =?utf-8?B?Qjc2U3BBY2Z1d3g1Tk80ckYzUW9qYXpaTlIyeis3bkRUeGRKbnA5djhiTWta?= =?utf-8?B?OGVRQjdVbDZLTGl2eGZaS0VScHhtTyt2UUNTcUVtRFJLWmsxL1l5VFFobGJR?= =?utf-8?B?cHQyWmJaNG1Pd1dac1c2YmVqVjhTZy9HYlBPbFFWYUtUdFF0cWpRL3hqSEVI?= =?utf-8?B?QkJ2THJ4aGRidnovVS9XRXJEeFpJdC9MM2RsQzZlalFmVHlreHpKQ253SnFD?= =?utf-8?B?bWxWN2tzU0JWSGdFRmJtbE5wYmZRZ1NqeGlMYTdEOGNzQjZWeGx3VDRXV09w?= =?utf-8?B?Z3VoRzBWMnVtajg0QXBvbHRCNk1uRG1xbHBQc1ZPVFRjZ0JVa1lKVkorVU5o?= =?utf-8?B?Z0htQ052bXN1NXF0RVdrMk1ZQXFabWx2SGNKaEFZTEZlZzRnME4xcHZidDdK?= =?utf-8?B?bmlKY0pKN1BJTjJJblZYZTkrVzhaMkh5SzJqaU1QVmYySm5TN2F3N2pJMDRi?= =?utf-8?B?M3BkRHpUa2FIU1kxRlFTdG1HSDAxR2U2NlAxVG5vbmVhNWJmenFOT1IwVDAw?= =?utf-8?B?Q3hPSTlUWmZzNjV3OGpMTFNQOTlNTDRYbnNJbUxDdm1Ra1oxSFppaVBQdHFT?= =?utf-8?B?YTZXMkNIWmhZNEE3bUNPd0FmaS9hQmQ2aW9icEJSRXBNWWc9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHp4L21oUkVvN2EyM2FOVHdDQkNLSTM3M3ltZFN2RmVoTE1obHZEMHRPNlRl?= =?utf-8?B?Y20zZm5LNk0wck00a2ZBQkppZVlrRHNHSGxpTDViekIvRjJOS2NIcU9qWGY4?= =?utf-8?B?TW5NMHBkYVZsb2pIMUFBSU5NMkZVdnpsQklpNGMxeDJzMjFwRHRob0hrL0tm?= =?utf-8?B?MHU5cHBKTktkdWxTTXdjaTVRQ21zU2tNU2FUbllTOWRTRmJWRkw5eUJvVTFa?= =?utf-8?B?Q0xlOXROd3ZCMXQwNFVkRnBJdnZEanBVTFVOOVhQTm5ZZkthUFZXRjV5SURK?= =?utf-8?B?bE4rcGo3bkM0YkhEdTNvNWI3Vll4OVRKeHEwVm9VbWRmTG53YjJZQVBVNXRM?= =?utf-8?B?NFcybWViVjdTUkhQY0Q1b1lJY0hDUlNPTmZPSk9mNlRkR1hQYkhQUmRmQi92?= =?utf-8?B?dkZlTlpDVnpOT25OcGU1OXhpQk8zZjVHVzR1SmFUWjcxRlN1NE5ZZE0zSDE1?= =?utf-8?B?NFJJb3VDRlNOMHU1Nnk4Mzk4bkFRaVJhTFJQTVliUEJvYm9IRlhVY1dQZ1JB?= =?utf-8?B?cUJBeGlHaG5nSjRrNFc5Y1k4SnBaVHczakZHM0lORXpha0NybTYwazA1Smh2?= =?utf-8?B?eUpEMk52WWVZNnlwSVluR2pXNzdkdHFubUVpTlFOakQ2QXNHTGRrdkhISG91?= =?utf-8?B?U3FWQ2FzanF1dmZlc3NSdTFqZWpoeUlRaFlSL1IyWXhjV3RuRWE4Zk5qSWMr?= =?utf-8?B?bitHTGkwakFiVXJOdk1KT3R0L2tNL0NGNXBuTXlneGZIMkNHMzIraDdLc3da?= =?utf-8?B?by91YkUwYzJkVnRRNDZRaUc2OWV2b2xvNThtK0RoQzZod2ZSOGpnTEcza21Z?= =?utf-8?B?Vm4wdnRFbVBBd2F6cWh4Q2I0bGNvUFY3NUFkQnBNV3FPNFNHUWJwNmpDSXkr?= =?utf-8?B?UktQQ285WThYbU94S1JRdDVyZHI0NHQ4Mm04bEtEeHpuTVFPekUyb01KYmVu?= =?utf-8?B?QjN0L0VEM2dYemtWNTVzVGNHTWVKTURGZExtNFlURzdBa0h3V2xhNDVkNnNZ?= =?utf-8?B?aUMwZ09KeGF5VHA2SUU4aTlzR29LZG1DTXhjdHNsUWhKc3NhWG9aU2pPYWds?= =?utf-8?B?N28wMmhZNzdMTDl2OU4xK21qTXU3WFVKR0JVNlZROVJmV2J1MUhEQkR5TEpF?= =?utf-8?B?RmtncXJTb2x5Z3RtMmhaQVdIampSR1hKTk1DRHdMSGY1TFJQcVNySmhWZUdQ?= =?utf-8?B?QU43bitHbENRay9sejlQVkV5STBEUFVBUTg1L0Y4Q0d4TGdnSmExaUhlUzJU?= =?utf-8?B?RW02ckR2emQvd2NFK2hxZVdhUmx5V3laOGpEbmdOOWs0VW1pSzlhaEJpaGNn?= =?utf-8?B?dzFiS24xL3EyUWJxclJiQXFnMWVoc3pYS3gxQzFSUm40T1NKVHNnUVhjNU1I?= =?utf-8?B?Wnl4ZzllYVhRV1g5SnNHSE5Yd2ZsUFhScXZ2VldXelZHQ2ZMdldBUit1eGlT?= =?utf-8?B?L041YUhqSmZzL0dlWVZ3enV3RW5NZ1VFUS9PUFBhWnExZTNJV3dJYzJjREU2?= =?utf-8?B?c29RSmszZlhhckxaUGFJRVNYeldpbytpblhrRStnMVY2bjRyRW1HY0xUa1dx?= =?utf-8?B?cU9nbG4xWnkxT0FYZnRFY1lwWlpUT0JkTzcxQzk4dDY4c1JmVnV2WTJrNTFB?= =?utf-8?B?QjhTUUZGNmtSNjVldlQ5dGp0MkhVK2huY2hGZjdvUDJIZmpscWw0bkYyT3Ra?= =?utf-8?B?Y3VQQnFGdENOMURscndkUEo1Nmx5UnlISENhTnVJSmpMVkpDTlpzVmg1cGVi?= =?utf-8?B?WEwwZ2dhUTdLTGYyQ3dzald1MHlJRTNNN2VXWXlzZUV0a3RVQUZFVkdpa0NJ?= =?utf-8?B?MlVVS0l5bDBwblNYS2FJbVdKanJucXZHTEJ5bXRXaCtTNWJXbDFhbHpsbDZB?= =?utf-8?B?OTdaSXVzUUFIU2MrK3FOWWRLM2NJN2VlMWlXbE1TU2lwdzN3K0tLUDNQVmM3?= =?utf-8?B?U0Z6MlFJd2JVcU5rZ3FPckcxMStPaWhxekxkcmtaT2VoQU84dUpFS0xueVRa?= =?utf-8?B?MDNmWVR5SExZOTgrSzN5Z3BVR0s1Y25wTEhoRm80ZTNnZmdRK1c4Z29DL0Uw?= =?utf-8?B?RFZWZU45QXY2NTQyVnkzRGIrMFJacW8vR09PS1Z4YnN5ZDRVVk41eWw5Z0Yv?= =?utf-8?Q?xIHRAVgs7h03EzxXHG4ean3/L?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5af0900b-d7da-4119-c89e-08dcabf7be49 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2024 15:46:11.8621 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Qt1hYMUyq/SuY+qoVFOVUPtmeSrXen+RLaOTzmEoXxLE0T6ONukBxNMLMb0/jWcB4DggwNwUPjr5pnikcaTZEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8599 Replace the hardcoded value 2, which indicates 2 bits for I3C address status, with the predefined macro I3C_ADDR_SLOT_BITS. Improve maintainability and extensibility of the code. Signed-off-by: Frank Li --- drivers/i3c/master.c | 4 ++-- include/linux/i3c/master.h | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 852b32178b722..85c737554c940 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -348,7 +348,7 @@ static enum i3c_addr_slot_status i3c_bus_get_addr_slot_status(struct i3c_bus *bus, u16 addr) { unsigned long status; - int bitpos =3D addr * 2; + int bitpos =3D addr * I3C_ADDR_SLOT_BITS; =20 if (addr > I2C_MAX_ADDR) return I3C_ADDR_SLOT_RSVD; @@ -362,7 +362,7 @@ i3c_bus_get_addr_slot_status(struct i3c_bus *bus, u16 a= ddr) static void i3c_bus_set_addr_slot_status(struct i3c_bus *bus, u16 addr, enum i3c_addr_slot_status status) { - int bitpos =3D addr * 2; + int bitpos =3D addr * I3C_ADDR_SLOT_BITS; unsigned long *ptr; =20 if (addr > I2C_MAX_ADDR) diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h index 074f632868d98..4601b6957f799 100644 --- a/include/linux/i3c/master.h +++ b/include/linux/i3c/master.h @@ -299,6 +299,8 @@ enum i3c_addr_slot_status { I3C_ADDR_SLOT_STATUS_MASK =3D 3, }; =20 +#define I3C_ADDR_SLOT_BITS 2 + /** * struct i3c_bus - I3C bus object * @cur_master: I3C master currently driving the bus. Since I3C is multi-m= aster @@ -340,7 +342,7 @@ enum i3c_addr_slot_status { struct i3c_bus { struct i3c_dev_desc *cur_master; int id; - unsigned long addrslots[((I2C_MAX_ADDR + 1) * 2) / BITS_PER_LONG]; + unsigned long addrslots[((I2C_MAX_ADDR + 1) * I3C_ADDR_SLOT_BITS) / BITS_= PER_LONG]; enum i3c_bus_mode mode; struct { unsigned long i3c; --=20 2.34.1 From nobody Thu Dec 18 11:55:57 2025 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2082.outbound.protection.outlook.com [40.107.22.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBF8615D5D9 for ; Wed, 24 Jul 2024 15:46:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721835980; cv=fail; b=peyq5pp+5zXTqbS5sKkv8WT41ZW/SKd0FiXqUVn7o/6lS31srhyVXkF58sOyu52in/4XqezBtqi+4q+txYMoHuJHGFmH6J19XwEyGB2ULVF0Um+lc3gCKJJEFFDFzcx/ILiMWYT9sEPnPeb4ou5tkcx6D4jW4QGM6YuoqIbDFqs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721835980; c=relaxed/simple; bh=nvcmTWDJj+SrtpBzaB8l8keUZ2F8Z2oCpFCzJlzH9us=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ARObhNXnzUxPCEL2xzu96rx6X01RuVwMebtx8HunaypriDOLH37AkWxeacD17UshAWQF7u6B+pxYqYy+GTe+hGEiFgUlUURUNHCpxHeoDCW0vcIcaRZRrKWhvWABYcqBwgza5IWcVpiN0OtMQLFY9Jg7Cdtv0cUCw4tImMA1s9c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=c3O3efil; arc=fail smtp.client-ip=40.107.22.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="c3O3efil" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=n8FVY26yIGeFF2nyBwg7kQTqWqUXzmWy9s+68F/SxFvHaD/z9kxKGPiuwS7tLPJadTy0+Hq5rQ+bJl75bFGxvT/SjSBccYkwll+krvhyy0NVDDuTL44kHaDNfvURgsOjTlcwdTyh6j1SJr5QscLqPPoMBkjIPf1CwXWBcCCLwo2OeWbCGdCkV/mHxCwu8pqmOfpyKbCwffMPGma6jK/zOLR69ilN4jNisGq7BuhjHbthYwZS0ZWEM5X8YmIC3IR/6nt1r+4F6zM5hcltTmn6HgAWVtDoWoGz3lJl6bqFED5ovpG1ItRuAJF17KYWnU8FVtEyojQOkTFGSzII5rxWFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jk3Sg8K892J5LLK9qnygB0m2WRCfBM/GY0tQ0z2NeDw=; b=PWB7KsGIPUzmMPdiTS31D0C9IvGSjU59b650GBEYYzS88CG3vyGUgcokL3yCQJRUFYAmz3gMhkeZHxu8YSXFJTf1dkCuN4+llqt2ushIi7ywAoZuk+y9h2B8fsizazF3cenDOn++p1Ed+M8K7TZS9XfA0l8oMo4FzNKLc0YBa4j7w8uTmqwUWsBwfo1XJDG1IyZfkDnUH//5J1j5sIiulc31IZWZwkmmQK/yBVSc4d7e5i++QyKKiTqnwZUjNtoLJQBtJA5afEH10iIXh+0CEepioXghd6TS+P6xu6gX7rnjdf6AN/GAbI8zG5v87vVQ9zjrJfKnOYLI08cdP2WvrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jk3Sg8K892J5LLK9qnygB0m2WRCfBM/GY0tQ0z2NeDw=; b=c3O3efiloGTsEHe02FROPDYyjYgp0L+gn2NjzjPnYNNnVKw6C0wRtsqx7coSmIYQL2Jj7Fkq3Efriq/4jVFR7vTFMZ2hXSe5ylLQu4Q22XuweQWEgOH9acyXehmuC8asxhRIIsRG9r49zGt0RMz9xRA5jHeIU76tb9K9ULAkzr64/+7IIEuxFwcyv9FOoS4SBQQpxzDuhZwmVfBSMiLK9TSM19hRvU3I5k7yCqfcHCmoYHSNEk9rG0Y15UYkOmMJ2RJFv7zP8vLeycmdwvPJa4dxmL/SVfQU2AjkZVQfYHPrsk+WucBHMYDgrWjmfnx8b4WZBGZZ4yBMd1AdPaIhig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by DU2PR04MB8599.eurprd04.prod.outlook.com (2603:10a6:10:2da::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.16; Wed, 24 Jul 2024 15:46:14 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%5]) with mapi id 15.20.7784.017; Wed, 24 Jul 2024 15:46:14 +0000 From: Frank Li Date: Wed, 24 Jul 2024 11:45:48 -0400 Subject: [PATCH 3/7] i3c: master: Extend address status bit to 4 and add I3C_ADDR_SLOT_EXT_INIT Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240724-i3c_fix-v1-3-bfa500b023d6@nxp.com> References: <20240724-i3c_fix-v1-0-bfa500b023d6@nxp.com> In-Reply-To: <20240724-i3c_fix-v1-0-bfa500b023d6@nxp.com> To: Alexandre Belloni , Boris Brezillon , Parshuram Thombare , Greg Kroah-Hartman , Boris Brezillon , Arnd Bergmann , Miquel Raynal , Conor Culhane Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1721835962; l=5289; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=nvcmTWDJj+SrtpBzaB8l8keUZ2F8Z2oCpFCzJlzH9us=; b=sjKVN7n3qDvzp/ZKjRO7ubR1ZFpEBwXfqUL6koCoxCnfbSExSMcJzGPnIGBceG5/8TQp8kc0y kNJs07FZpdGCA/k+oQpurU9BSuemRwfNxhtrqKD3F92NDBA1KHkN5m2 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR17CA0008.namprd17.prod.outlook.com (2603:10b6:a03:1b8::21) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|DU2PR04MB8599:EE_ X-MS-Office365-Filtering-Correlation-Id: 51b3c391-a828-4821-5ee0-08dcabf7c013 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?V2JPazBvWVBBYVl0TjBGK0txQ3VEL1pnVW1LZDlyOGU5YXUzRUJxaTNXL09K?= =?utf-8?B?VnNuR1lBU0o2ZjJNTVhqajdpMTF0WjRyN1ZvUzhEOEF0Y2p4SjducTRiU2k0?= =?utf-8?B?NTYzSVBPcmI0MVc4Z1V3dHY5Rkp4YVJrWCs0MnZYZU81anFoTlZvczY2YXNY?= =?utf-8?B?TFd0WnVPUEZnazNVaGdMaUhZSFoyVGx4YytEZ2wrcnEyMk1kSnVFWGo0aG1W?= =?utf-8?B?cEdHZzk3V3pldTY3ZnFxYzdHajJ4dmVTdlFvSm0wbEMvUFlCd0REK2FmQmtD?= =?utf-8?B?QWhkZjZZaTM4SjIzeW9ZUks0Q0IwN2dTUVlUNDhCeWFCWHN4aFRidjdHZ3BF?= =?utf-8?B?QUFsYWhVelhrNmZWWWt0VGhKWk5pVkRKVzQ3dm1QR28xWkNSeWFvb3J0TFRt?= =?utf-8?B?VDhtbHZYU3M2bGoyOSthREY1THFXcWZmN25LWXI1Snd6WCtIWXY0MDJlN2dp?= =?utf-8?B?YmhDWTArWXVSNG10UHczOWlTYmMyak1Pck9wY29vNno5cFErRnkzQXBTVHpz?= =?utf-8?B?OFNjNTRzcXJtczR2L3lvNzcxRmZrSFZOdlNzMmFJSXdEOEVNbnRWWnA4a1N0?= =?utf-8?B?Wm0rU3dwMHRmUmhNQTVIMUNpSndTWFZjelM5cmZRakFmblpENnFyYVlRRXJF?= =?utf-8?B?L2gzeVUrREltOWdQZWxSV0tvSHpqak8ycTltczRvRjBTQUdJSlJ1N2pteW9l?= =?utf-8?B?c1YzYzAvTnZ1MDhXTzJqTjBWcTlWQXhkWEhMeXJnem5Yd3JmeXYvYmxGcEJI?= =?utf-8?B?cVVwanRVZ043M0JKU0hSak5jUDhNM0UvVVBrVnlIYUI2c2hBV0NNdzlvUldz?= =?utf-8?B?Tk1rVE8rbjA2blcxL3BBWmkvVkR6S1h2dDB2MG1kSzZMOTVMWWEyWks5NTRa?= =?utf-8?B?d3VlblA1RFU5S0xoQXhKaEhid0s4M2ZKRGRaQTRYMFozTERRZGprWURzZVRW?= =?utf-8?B?Yk1Kczg2MVhWRUhBUVJVcWh1Z2RVaHR5bmh4cGgwcUwwU0ttZ01QVGphbFls?= =?utf-8?B?dXhyZWgrOTg0TUhHWnZoS28wL3BPYjBOZ0g0aEdUc1RjZ013NldRYnFVY2Jk?= =?utf-8?B?Qi9Wb29mRDdvaWpsY0JQZ2ZZSTRYS1lSY1VSWXdUVlhFd0d5L3dmdkh0Nks3?= =?utf-8?B?NTBKZkxKekJjNER1NTRGWTJNVUgzMlp0TGFTSkdpVzQ2dlliZVp2YnM2MnVx?= =?utf-8?B?cFBYUllVRmtmUHNwL2hXL1F0d3hjMENJSkd4ZnJ6Ukg1QTFzWDVzYjZYQkR2?= =?utf-8?B?VWtnQ01Ta0RmN0E5SUVFdXVHQ1dmWXlTN2t6aGNRZmxDK3Fqa01tYVlpNW53?= =?utf-8?B?eGxueGVQck9wZVRWV1BRMVJqcFkrcElUdDhENk12eTNoYk9lWUxTN3pudWtS?= =?utf-8?B?K3luaVZXd0VKMG5OSXdMS3V0QmMxVXBzdWU3cXE5Z2dFcEFqckpyY0lqMnlx?= =?utf-8?B?Z2xQc1VSbGl0ZndlYkQ0SFk5ZEI0bkxzemc2V0JSajYrWW5JMnJWWWl2QVEr?= =?utf-8?B?YXp5R3BDc3JUSndrRmg4SXlvODBpeEc0UWNFT001d3BKTFpOTFZpdURISlVN?= =?utf-8?B?MEc4dytib2N3bCtzaEs4MUE1eTVQV2J0eDVCUWpmUXEraUdMenllQWJUUngv?= =?utf-8?B?OUNRMkdGbzdpcTVGeUZ0TUUrcmxqeVZlMFJxZG5hREVnU1dWRTkwR3RvWk5S?= =?utf-8?B?aUdoSE9zclZTUm9VRTJQR240ZnFzYlUyUUppTmZGeDVlNUZNcXJFVngwajJY?= =?utf-8?B?Ry8wN0dPa2s1SnZ4SEtKMWdDeEpOcmdXWC80MSt3Qzd0VkFNb3dxMDJsNFox?= =?utf-8?B?WjcxN1pUcTQ1VDZmZkJjUmY2YUhrL3Q4SjdoYVE4TFdGZGVIR0Z5VzVoSzB0?= =?utf-8?B?NVQ4eXdHT3J3SmcwNHRPVG5JbkZ2OVBLb0lWTk1KSVRaWEE9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2dKc1lOdnFLTE1qUUxzQThoVkVmZmttT2FndWsvVmRiYzB5N05IbU5BYkxC?= =?utf-8?B?T1c2dDdXSWpRQ0JmS0V3eXFEaWxWdWh0V3Z6RmlEalpYN0hoSnZLSFUwcksv?= =?utf-8?B?M251V0I2Q2FKVjhsemswemxWRWJTSXg0ZHZmTmRpdXRzanNDWWd5ZnN5Rk84?= =?utf-8?B?dHVmM3Z4OUtPRFY1TktEVHVDY1BlTkVEbmREZm5aOVZGWU83aWZRYXphbGIy?= =?utf-8?B?MnFrWDIvbTc3VGhHaUpxWVNrQTJncHJ5VXpTa2R3dWV3SlJQanZVNXZVVWFW?= =?utf-8?B?WGRpeFdYSlpwdGJDWVlsdkRkajBwQmVJNEZmckNRSEVUeGVjQVpGbWhPbkFL?= =?utf-8?B?cEp1eUZldjc4UXN0RGpDNlhrTG5ucG5MK2ZLQndrMnNFSU1NY2xndnY1ekZr?= =?utf-8?B?N25zRmlhNTEyRHl1SDduRHg1TFZIZkFuc05NTGRQSi9KMHM3STJLYWVtM3pm?= =?utf-8?B?QWc0Rm1vOEVzWldzVmNNR3VvNTB2MmJibHJOWWpGNkpkSWhsZDZ2UkEvYzJx?= =?utf-8?B?U0lEUjduZjlWSVNpdElkYkU0QjRSMk90T09kVVJhNk81Vit2TWt2RCtGQnJ6?= =?utf-8?B?K1ZHU0RESEJ5S1U0TzQ0QkE0Z0RkRTc2a2U4bkhYb0cvMnFMM21jZmhaUlJM?= =?utf-8?B?b3JVTURVeTNvWXBzanNJOGZ1ekJGakpOemNzeDllS3lzeEFheExKaWxlRy8w?= =?utf-8?B?djVLLzhJTlpDMWdmMlZMSVcrU2NoUVhPMWU2WUQ5dGE5eVJ4UFBTaHRPS1B3?= =?utf-8?B?OWh0TE8wM3hWaTVGdXFMWWRnM0lxS3QzRVNCNG1RVnlmL2R1TWo2bjVWWDc2?= =?utf-8?B?ZXNFY1NyMVNQZmtaTm9RUWpTN282QnpPL0VrTkVzTlBuWloxbHdkcW1VNlMz?= =?utf-8?B?Y0p2QjBSa2pUaUx4WHJtb0NMclhwNU5PVXpkaGk2MmhycExDYXJZY2JxbStN?= =?utf-8?B?K3lIMWUxQ29BcWp4WkhaOHZpcXJycmVya0JzUUlldGtqQWJkRDd5Ly9BRUJK?= =?utf-8?B?Zjl3VGsreXNzcHVvZmJvZlFqczdwMkNZT3NVY25BRkE3ajhGeTlyTU5HcXJT?= =?utf-8?B?cEEwMEZmQVIvNmgvSzEyOXpML21OVTFtRzlHektUZkxRK0IvK2JFTUlCdWh6?= =?utf-8?B?R3FDRmc3MGZiMXZMaFBvVExjYm95RXdVYWJjSXdNS2dzNFlEcS9mK1FrVXhE?= =?utf-8?B?aEp6ZjJqcjZrVU9kTWlIeXJRYTZ1ZnE0WXBhOStncGV2RllKUzh3bklpWnRa?= =?utf-8?B?MnZxYXJLalduRDZtVHhCOFRtRVpYNzYwVEIvSWNEcXh2VkxWOUh5aTk5TS9h?= =?utf-8?B?Yk4vd0VVeWVyaXhLTUMxbzlic1FCZEdlWFR4V2k5bWVpblZkTGVxZEdRWk42?= =?utf-8?B?QlJKVEpFYzVsSDlrOHlId0huZmZKellnRk45QWJDa1F2bVpuVGlMV2pYeVRG?= =?utf-8?B?dCs5d2RkZm1US0RiQUJJVlRHYUxwaTM0ZThRcFlFVzgrd0duZURuQmdkY0RX?= =?utf-8?B?ZUFZK0JpekE4RytkVjV6NGo3TWRJbDBSbFBLTktpTDlsbThZNCt1RUhUbnRr?= =?utf-8?B?V2xHRjZMSmVQVnJIcVUzWlNDNDRZZWNVbU1rQnA5Wno0cHphQXJnMFZWZjJ6?= =?utf-8?B?bks3YUdwdG1BUGhOVU1za0VobHFZaDNLSDdFSm9YVTJndjNCSXY4VC9vSTUw?= =?utf-8?B?QUVHU1ZDR1hxRW9WeXFzYmEybVNxSDdHREVCN1VXODRWcDB6WElPVVFzaklo?= =?utf-8?B?SjhmSzAxR1RNZCtERTlHckliZFFXWnNoVWlodUpISktYSXFXMExoanJXRitL?= =?utf-8?B?ZHRQU0tOMG83U3JxODNnajJzdjJ0TW01aGwyMlg5NGRpcHk0Rm1wUmc5QnIr?= =?utf-8?B?YUNoei9nZGF3dTd6YkY4QnpmNnk0UW93YmZ4SGdLUVh3OFcwQ05Dd2g1STRL?= =?utf-8?B?UnhRaUMrejFEMy9RV2NiSDloT1BCT1hrZXJIcEVUMHJrKzdrZVp1OW1IeHF5?= =?utf-8?B?YVp0MStxclFuN1ZVa1k0N2lNM2tiK3ZCT1laTWRJSUtqdjRCQnVxSjUwYkIw?= =?utf-8?B?M1VJREJWSC84SFJueGJkNmNRYk5DcEl3djdlY3BJMTRWbW9OS2xwOFQ1Zk05?= =?utf-8?Q?Fi6QP/GvLtgPSl/un6YlD8c4p?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51b3c391-a828-4821-5ee0-08dcabf7c013 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2024 15:46:14.8636 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Bnee3CB35MGR7ulv/boQFU2Fg8GQeJjN5uD6XW0O/Udi43VoQ1aE3/FdVYWY7qx7WizSEHXgoKvExDre1Ls/qA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8599 Extend the address status bit to 4 and introduce the I3C_ADDR_SLOT_EXT_INIT macro to indicate that a device prefers a specific address. This is generally set by the 'assigned-address' in the device tree source (dts) file. When an i3c device is removed from the bus, the old address status is set to FREE, allowing other devices to use the address during hotjoin. The I3C_ADDR_SLOT_EXT_INIT status indicates that an address is preferred by some devices. The function i3c_bus_get_free_addr() will first attempt to use unassigned addresses before searching for assigned addresses of devices that have been removed from the bus, trying to best match the 'assigned-address'. Signed-off-by: Frank Li --- drivers/i3c/master.c | 43 ++++++++++++++++++++++++++++++++++--------- include/linux/i3c/master.h | 6 +++++- 2 files changed, 39 insertions(+), 10 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 85c737554c940..4281f673e08d8 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -345,7 +345,7 @@ const struct bus_type i3c_bus_type =3D { EXPORT_SYMBOL_GPL(i3c_bus_type); =20 static enum i3c_addr_slot_status -i3c_bus_get_addr_slot_status(struct i3c_bus *bus, u16 addr) +i3c_bus_get_addr_slot_status_ext(struct i3c_bus *bus, u16 addr) { unsigned long status; int bitpos =3D addr * I3C_ADDR_SLOT_BITS; @@ -356,11 +356,17 @@ i3c_bus_get_addr_slot_status(struct i3c_bus *bus, u16= addr) status =3D bus->addrslots[bitpos / BITS_PER_LONG]; status >>=3D bitpos % BITS_PER_LONG; =20 - return status & I3C_ADDR_SLOT_STATUS_MASK; + return status & I3C_ADDR_SLOT_EXT_STATUS_MASK; } =20 -static void i3c_bus_set_addr_slot_status(struct i3c_bus *bus, u16 addr, - enum i3c_addr_slot_status status) +static enum i3c_addr_slot_status +i3c_bus_get_addr_slot_status(struct i3c_bus *bus, u16 addr) +{ + return i3c_bus_get_addr_slot_status_ext(bus, addr) & I3C_ADDR_SLOT_STATUS= _MASK; +} + +static void i3c_bus_set_addr_slot_status_mask(struct i3c_bus *bus, u16 add= r, + enum i3c_addr_slot_status status, int mask) { int bitpos =3D addr * I3C_ADDR_SLOT_BITS; unsigned long *ptr; @@ -369,11 +375,22 @@ static void i3c_bus_set_addr_slot_status(struct i3c_b= us *bus, u16 addr, return; =20 ptr =3D bus->addrslots + (bitpos / BITS_PER_LONG); - *ptr &=3D ~((unsigned long)I3C_ADDR_SLOT_STATUS_MASK << - (bitpos % BITS_PER_LONG)); + *ptr &=3D ~((unsigned long)mask << (bitpos % BITS_PER_LONG)); *ptr |=3D (unsigned long)status << (bitpos % BITS_PER_LONG); } =20 +static void i3c_bus_set_addr_slot_status(struct i3c_bus *bus, u16 addr, + enum i3c_addr_slot_status status) +{ + i3c_bus_set_addr_slot_status_mask(bus, addr, status, I3C_ADDR_SLOT_STATUS= _MASK); +} + +static void i3c_bus_set_addr_slot_status_ext(struct i3c_bus *bus, u16 addr, + enum i3c_addr_slot_status status) +{ + i3c_bus_set_addr_slot_status_mask(bus, addr, status, I3C_ADDR_SLOT_EXT_ST= ATUS_MASK); +} + static bool i3c_bus_dev_addr_is_avail(struct i3c_bus *bus, u8 addr) { enum i3c_addr_slot_status status; @@ -388,6 +405,14 @@ static int i3c_bus_get_free_addr(struct i3c_bus *bus, = u8 start_addr) enum i3c_addr_slot_status status; u8 addr; =20 + /* try find an address, which have not pre-allocated by assigned-address = */ + for (addr =3D start_addr; addr < I3C_MAX_ADDR; addr++) { + status =3D i3c_bus_get_addr_slot_status_ext(bus, addr); + if (status =3D=3D I3C_ADDR_SLOT_FREE) + return addr; + } + + /* use pre-allocoated by assigned-address because such device was removed= at bus*/ for (addr =3D start_addr; addr < I3C_MAX_ADDR; addr++) { status =3D i3c_bus_get_addr_slot_status(bus, addr); if (status =3D=3D I3C_ADDR_SLOT_FREE) @@ -1906,9 +1931,9 @@ static int i3c_master_bus_init(struct i3c_master_cont= roller *master) goto err_rstdaa; } =20 - i3c_bus_set_addr_slot_status(&master->bus, - i3cboardinfo->init_dyn_addr, - I3C_ADDR_SLOT_I3C_DEV); + i3c_bus_set_addr_slot_status_ext(&master->bus, + i3cboardinfo->init_dyn_addr, + I3C_ADDR_SLOT_I3C_DEV | I3C_ADDR_SLOT_EXT_INIT); =20 /* * Only try to create/attach devices that have a static diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h index 4601b6957f799..c923b76bbc321 100644 --- a/include/linux/i3c/master.h +++ b/include/linux/i3c/master.h @@ -284,6 +284,8 @@ enum i3c_bus_mode { * @I3C_ADDR_SLOT_I2C_DEV: address is assigned to an I2C device * @I3C_ADDR_SLOT_I3C_DEV: address is assigned to an I3C device * @I3C_ADDR_SLOT_STATUS_MASK: address slot mask + * @I3C_ADDR_SLOT_EXT_INIT: the bit mask display of addresses is preferred= by some devices, + * such as the "assigned-address" in device tree source (dts). * * On an I3C bus, addresses are assigned dynamically, and we need to know = which * addresses are free to use and which ones are already assigned. @@ -297,9 +299,11 @@ enum i3c_addr_slot_status { I3C_ADDR_SLOT_I2C_DEV, I3C_ADDR_SLOT_I3C_DEV, I3C_ADDR_SLOT_STATUS_MASK =3D 3, + I3C_ADDR_SLOT_EXT_STATUS_MASK =3D 7, + I3C_ADDR_SLOT_EXT_INIT =3D BIT(2), }; =20 -#define I3C_ADDR_SLOT_BITS 2 +#define I3C_ADDR_SLOT_BITS 4 =20 /** * struct i3c_bus - I3C bus object --=20 2.34.1 From nobody Thu Dec 18 11:55:57 2025 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2082.outbound.protection.outlook.com [40.107.22.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F311015E5CC for ; Wed, 24 Jul 2024 15:46:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.82 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721835982; cv=fail; b=jJm/w7YxF+xyy1XZc0cYIJBfA/I1h9e9DVap13P01S0D6+8YaRvZ6yJxP62jKtCLTKg/VhnjSiuIT9M9ZOnoo52gJUzw4DjtYJhLzbG32rtJhWBRbfaB+DtC2wufSQeqe752H6L1Gbr19yqEaI+s/pFbME2lD+JsJhYtJUcVnBg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721835982; c=relaxed/simple; bh=phlwJ/9jw9NpeTB7NJPyHYpdTuYWHApnsz953oBcxmA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=D9iGTNigg7Gzxsr5J1I8x0b7LKyqcU6xveg8NfDxN1rYqFqUSe0vJVzJR9WlSfa1dxN9FVXpxcJsy7kccf3lFz2zJW1kuziJ3gl2N0WJPgJtMFaC5+RHYKwk0eItNkQ2bjbzDQjYiLGlbrk3NYXWomdowdgxiK3vH28t1rVK8ro= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=CxXCMnv0; arc=fail smtp.client-ip=40.107.22.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="CxXCMnv0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QuS6vfRobAMe7ErioX4SAqCZG4KGuoRDl4R1hj5/BjaO6qCBXDhFRgJSqH6xLuY7m2mfX280EqHDhB9Vx8Yp6blxevTypxPD+ETrzuxdV5jdl7UB3+Ttu5reKOJbbrd671jF7C0gPoT0K7naZThJ2Uu+5oMgawg2nKMLHCtQGYvrdLgcAaeF6ysUyjn2jEYRstmtJvKSXhYE6ORNtoAAgf3ENzeSe7Fj4vTyM8F2eXT9y35WpskVRVlO6ldDJgGGTf+NbJKaBEmg17AA44xsRTvAbVoLDLQ/OF9PdqryGhREjPhpj3JE55Y82X2zDkedxyHkGsFK2RIJvSkyli4L5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=khB9K849nl/MU67dxO7G2LRxt5J+Bs0EnkTKFa+J0gI=; b=GguIrD33wfZVOlWx0Wf6FlX4el4py3JlynM2di3srKwKfhhGRd81u5DG3/DdmWvPe6lWU9kgpd0dnKnNHX9CCAuh/AymJE5JBgef/bDtKVZebTRHM5C6rzSYR+vnH/n4mnCOdpK/ZdgubulUSF5XQ9yVVGyh8DdJiK1PVkLoJosgf4iUITOT26iHVwtoaRxKrUPOucRE0CzdKQIeZ5VSM43zsZYiuWFfq7WWOjM0sBQ/OHOMyQFEJSLpR3dHYL5eA7coxSvaHymkKXnfHQCh7+YvuoKr/+n83Va/2fhGGNWhm4LmZaUqZmOmVjvhRrlzrSUqduxP3uXOKS+hA/AO8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=khB9K849nl/MU67dxO7G2LRxt5J+Bs0EnkTKFa+J0gI=; b=CxXCMnv03TqgWktSBg1A+7x3Wf8DNLctSeAjyfiLm3O1R2YBwysXjXw9Jyf3D3CY5Mci6AigIqvvg8qQonyfM9P8FkRN9hIrLD09a3wvtXiHu31NjBNY56kKIf4IAPgtmIG1GCEaje93rAfTaSUPO8q4/isxGca55ndfTQforAunaY0yDgZg48R2xEiqgaH1wP0iSG5HTA1e8hb3a7fXdSRNq5o+k/5wACrTjF45qxKd5jQa6jyI/4AdS6xQ/V8rjcbWFatX94OqK45Qa5p/+Oq52RbqDVXg3CPvAu06+8NRLSvNj0FawlqQ4JoRWk8SBw/5QTsXN+4z3ZPR7QqSMw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by DU2PR04MB8599.eurprd04.prod.outlook.com (2603:10a6:10:2da::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.16; Wed, 24 Jul 2024 15:46:18 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%5]) with mapi id 15.20.7784.017; Wed, 24 Jul 2024 15:46:18 +0000 From: Frank Li Date: Wed, 24 Jul 2024 11:45:49 -0400 Subject: [PATCH 4/7] i3c: master: Fix dynamic address leak when 'assigned-address' is present Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240724-i3c_fix-v1-4-bfa500b023d6@nxp.com> References: <20240724-i3c_fix-v1-0-bfa500b023d6@nxp.com> In-Reply-To: <20240724-i3c_fix-v1-0-bfa500b023d6@nxp.com> To: Alexandre Belloni , Boris Brezillon , Parshuram Thombare , Greg Kroah-Hartman , Boris Brezillon , Arnd Bergmann , Miquel Raynal , Conor Culhane Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1721835962; l=3637; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=phlwJ/9jw9NpeTB7NJPyHYpdTuYWHApnsz953oBcxmA=; b=bFam1yY7BeGLoVc3lylUfnBvI0dojbpBk9GROZZaVWtnPAY0urR9VS5sJ0CzXLcUYp/FN6Z6r AqzW7pFiOXCApRF9lwBMPP7wBPBbgsfPv6QoV3bH0gT1OdPR21aEPW5 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR17CA0008.namprd17.prod.outlook.com (2603:10b6:a03:1b8::21) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|DU2PR04MB8599:EE_ X-MS-Office365-Filtering-Correlation-Id: 245238aa-7814-4c7f-1404-08dcabf7c1fe X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?d0FuVkgzNE5lUlNsOGxNRFBWMU5sMm5lQ1dra2RrM1d3dnlUVkxTM2VBRVAy?= =?utf-8?B?UnMyL0dabHlvTHhPakJVVVZBcG4ya1NDd2ViSTFkeElTT1R4UDZwUE9NelBv?= =?utf-8?B?SDZSVWVhU1d1cmwwL1N3d0xJMVhYWElOVUxKeVlHcEdyNnNVSEJsVmpsVWU2?= =?utf-8?B?T0VGc01sdHJGTVlBZ2VvZ2ZrUTYrNW9mb1dIZ1BWWSt1ZU1peTJSKzBkOVJt?= =?utf-8?B?VmpIMnFyZDhSVmFwNzNYTC9CQ1R1eEd6NmU2Z2FaWUNSUko5NEdJbU5hVVlV?= =?utf-8?B?Z09qSlpvZjVuQWN4STYwdFlPcklUM0NLN2lUbUdMSkxORzR0a3NNeCs2dExl?= =?utf-8?B?QjN2VWVFT1U5amVZeEg4Qk5jWTZnTG1BZ25POXB6U2JuQ3BIdVAxWlJzR0VO?= =?utf-8?B?S3BjVVJvY2hKdXZEVWFVa1VEK3FpeUtLVXVGRyt4LzFwSkFadFJSalJZNThS?= =?utf-8?B?NG0weDBkT1ZzQUdHRXRyUmJ1SG9rNExIQWhYejZOMzIvdXVkVmlwUlc4L1Fv?= =?utf-8?B?WmVaWHhuNk8vSGNxenBzRnA0NjlpR2NaTTFwUSttaGJTUkZPeGJoTE5JZ0pa?= =?utf-8?B?NGY5Q1NlRm5uVWNpd3RTM3I1QnlMWDVFa3d6MnpjT3ZyalJhZ0l5NHZCT0Fk?= =?utf-8?B?NFRrMXRjT2VVZUpkYWlIVjJ6RURONXhrbHhIdjJ6R3Z3VkVXNFluN21naU1H?= =?utf-8?B?ejA3eXNkdWlvMmJnV2ZTdFdvMzhNYnF6d0cvbGhQTEFPNXdLN1J2UUFyMXNC?= =?utf-8?B?R1lrT1NpV2hYdU51U015K0REL2w1K2pWVUZPbHZJV1RVdGRGQ3dncWxCZFF4?= =?utf-8?B?L3pIZC9HMnhjWm5OV3EzY0x1TU01U1Nzc3MxYXRJOFZ0MUVnSWRHUkZkMExT?= =?utf-8?B?NC8vKzdKVHRXZ2kwMVlya2hpd0wvV3BFdXQyNDZOWjN3ZkRGbkdLSkZDNnBQ?= =?utf-8?B?Mnp3elljQVBiVE1EcnJUWVZERW5jb0FuYU9wemNNSTBQODl4NE5zN1lobkFz?= =?utf-8?B?U0NZNVlUY1pYanJyOU52YktYbDVRalNjMEpBK3RMVnVnbGhDRTVYY0FpdlI1?= =?utf-8?B?Q1pQcEs4aWNNRTF5UmJJdjFDcnBuUUNFNWphR2tSUU1tWnRhelNZK01Za0R2?= =?utf-8?B?eDRDUEdMQytFdzhjRWpJK0RkakM4anJ5NmNpcmhBcHZ2em5Wd0tZNTl3OWdj?= =?utf-8?B?MWsyZWhCNExaR29rWnhQZjJYSHg5c0RUbCthMDJYMWdBK1dwaEJyN1lWSVhw?= =?utf-8?B?blhnbHQwRURDd3p5WVZ0dDNhbFAwQmVMY1N2aGhOODZIeUd1TWNvY1J1eWda?= =?utf-8?B?eTdiVXMvQ3llMjZNcXVIZHNtY085aDd0c1g0SGIxM1g3c2tKdUU1NjBsQjFC?= =?utf-8?B?eGFBWXNESWgyd0hOeEt0VVdRTWFtQkdPSlJLdWNuZDhhRE5COXBEb2xXZUR5?= =?utf-8?B?MmNhYVl0eWp3VGF3WjduUjN6eUJTUnlVRXk4YXNhc1FLeDRsNHl4UUFvWFB4?= =?utf-8?B?THhMdStCTE1wcmQ3UzNMWDUxZmRQNzM1NlYyOGJPK1ZVQ2FNZm1uWXdGblRT?= =?utf-8?B?dFJVNDErYm53UTVRV1lncUpJRnFhNFduU0N3aER4Q2ZYcEJEWXhDd0NvTXRs?= =?utf-8?B?aEF0bTM4bHRzMmVSNnFhMUd6S1RBRlkzR1NnRi9iZHRKWnpJa3hDNkJOcjBO?= =?utf-8?B?ejRXMXdpUTVtUEF2ZVRRVzZvZ1pVWExnSjA3amNCT3FDVlVYSzhPcU5MaVhE?= =?utf-8?B?ZmQwU09CM2VvWUpXdWZoVkR5MnZoQy9VWnd5VjRwMHZLN2tXbkxOdEtHbFYr?= =?utf-8?B?aFdMazk0bTNOeHZVZytJZzg3SUJZbnBKVXA5a2lTbEczYVVYWURtM1RYYlZM?= =?utf-8?B?ZzE3MnV2RC82UHdsdTFrVXlEbU1DSnN0bXp1YkI2YlVETXc9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWlQc1VjK1dLVE1EZ3YrWFJSUUh2YWtUM1hZTjVSYk1GdVI2bStuWjRBZm5E?= =?utf-8?B?NEEyNXlPRDB5MUJ2dFlCNTVuMXJBR1MrU2o5Y0EvS01LcklUNHIxcjlvcGpB?= =?utf-8?B?NWxUdkYyWVNxY1QwTmJxMTNqTEVhQUI0bGo0QW14VmlYUVUvMDF4cGRrK29I?= =?utf-8?B?MC8zSXlRL0JLSjBqTnVRN0d6VjZmOGlrSFA3SHF5cHkybjJYR0hscUhrZGx0?= =?utf-8?B?NEs4a1p1RVAxekNtelVLOXJPaGU1RDE3RHhlait4RnA4TzhqWmNtd1NsVXZB?= =?utf-8?B?U2hWTlBWb29MMDk3Smw5YlM0ZDI3QndncDV3SGxDRXNOdk5La2JEQnR1ZzZH?= =?utf-8?B?VENtZi9XN2Q1WHRud0JDS0JUckRCZllHSUlqU0xHN29ROUF0dE40OGN0QlJX?= =?utf-8?B?c280bnhkRVY4RFNRRnl3U3ZDbmx6Wm4zZ0tUd2VXSFR5WWEwd1JzV0c0NG9p?= =?utf-8?B?ZnRLWjA5MVgrOHV5WVdwekZVcE1oREFLYVFrZXFxL1UzZThmVE1rRUFTL2V2?= =?utf-8?B?ZzJacEVhTFpJdFZZblRJSEF2M2wrQlp0VUUraWMwbHNiUHFZV09uV01GdVBz?= =?utf-8?B?M1J0Mk1pS1cyQ1BCNU1ZQ1M4eFlETDdqUXBqWHEyeXJjM2U3ZEpGcUcrdEQ1?= =?utf-8?B?V0piZlFnWjdlK2RPQ2M4ejd1d2JtODRjeXF0Q1J5N0NwYk41UkFMSUhvY2tV?= =?utf-8?B?MktjU2t0bE82bWlPK1hOT3ZkbnhVczhYWDdhaXZRTUZwMnFBVGxORGNkQjM1?= =?utf-8?B?ZXFMZUp6VVFHOEdFQnNTYmlsZFZSSVpocXZ0eklNeGd1Z0hqNUNBQWFQU0x1?= =?utf-8?B?UmFFeVhlc0l3eW9xN1JTV056KzMvSU1sbkQyMlp0Z0J5ditFcVNrOXFOc2pC?= =?utf-8?B?bmJBU051a3JRRHNRMGxyclhBaEVUYTB0RmVlUFlJZ20yWFNkQ1pwMldKdUs3?= =?utf-8?B?aDVpeTF2YW1OR0poaUxPMVloREtvVkdWd1RpeWE3aEFSeHpBVEEycVdWSllJ?= =?utf-8?B?QUxYc05pVktlR3FiaExDR0pSM1JGWnp1NUtjbjRHaHp4dC9ZdVk4Y0V4ekcy?= =?utf-8?B?UCtIUm5tSGU1NHByTUdGTjdHUmZPMjFmRWFpbkpKL0NoeFkzVk5tUDJOV09I?= =?utf-8?B?N0g5ZGI0cU52cm8rZlBIaVNjNUdjem1NZ2laazloLzRwRjFOczBNR0hLaklV?= =?utf-8?B?TDRBbGl1M3hoVUZGTEptMDczZlJiNWw2SXRQaENpT01nWmVQQkQrYXpLZTh1?= =?utf-8?B?SzFQbVNERkU5ODJBdlArNmNxS2lZd0V1d3BWc2Y2V1gzWHRLUWNCRXFVc2d6?= =?utf-8?B?cGh3aXFzdWRSNXRRalREQXdxcVRwMEhnT1JFbFRZT3BvVDRxN2NaK2Qrd3dp?= =?utf-8?B?SGZyVU5vUG5WWlQ5Vm9ENGlyWldtb1lSUFhRZXRLN3VXaktSRmdKUCswRlVv?= =?utf-8?B?RUxxWDR4RG44NkdBb1QybDEwNnlsM0ZQcDNZNFNqUGZ6dkJjdHo0V2poaEt5?= =?utf-8?B?M29mTUZsM2hSUnJpWXczajVnNVZkcXNTNCtmb0RyYWQzdVgrYy9DQmlaSFRE?= =?utf-8?B?OVFhMldFNUtMZkI0akc1NU1QY2tpMDFEZmZMeFAvVlZFSEtjNktTZDIyY1A0?= =?utf-8?B?OUN2RDhycUhtSkRNSGVuZ1pwU1duT2F5WDNpT2NFUjB1Mk9vV0JyZ2RIdk9T?= =?utf-8?B?SmpHQWNEMUw1N3BEbTRxV0d6Y3QwQVg4WmtLcmFuU0dFSnF3bmV3eWtxTzd3?= =?utf-8?B?elRxZVRsOCtUSkduOURHQjRkdTFQdThTSlFLcm1PdDZmNENpaU40NXF6SzhC?= =?utf-8?B?cW11MFhKK2IxV1dkOUdXTFNSM2dQTGdmRWt3ak9nNklLK0JFSlczRnBVcnBW?= =?utf-8?B?dUFxazI1SXoxRWpHcUdoaDUvdkNZUjRMSUR5Rm5WQWVoeDNFNU1tWlgxNnhw?= =?utf-8?B?bnFwaEFGNVJmejJzSWtJczFNdm96cUZRV3VqamVabDg0Qk5abEx5WDArZ3lO?= =?utf-8?B?alNpd3NSUzM5bG1paUNoVGNvY3ovTDhybDcxd2Z5OEZoNVlvb2xxOWd3Y3Ix?= =?utf-8?B?bGI4VW5kVU04TGNrVFhMalJNVlIwZ1ErdExQV05aZkJ6NW5XL1U1RVpiK2pE?= =?utf-8?Q?n3eHau2X76pdmy6KG1SvaGj0O?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 245238aa-7814-4c7f-1404-08dcabf7c1fe X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2024 15:46:18.0751 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dZ8Dms9LO55cyO0YVZc/zaLhzO8f71rYPTmRbm2bnPIRWOjEFB03YV/gPYqjyWkz7McShbdfTM4x/Fy5VLk7WA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8599 If the DTS contains 'assigned-address', a dynamic address leak occurs during hotjoin events. Assume a device have assigned-address 0xb. - Device issue Hotjoin - Call i3c_master_do_daa() - Call driver xxx_do_daa() - Call i3c_master_get_free_addr() to get dynamic address 0x9 - i3c_master_add_i3c_dev_locked(0x9) - expected_dyn_addr =3D newdev->boardinfo->init_dyn_addr (0xb); - i3c_master_reattach_i3c_dev(newdev(0xb), old_dyn_addr(0x9)); - if (dev->info.dyn_addr !=3D old_dyn_addr && ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 0xb !=3D 0x9 -> TRUE (!dev->boardinfo || ^^^^^^^^^^^^^^^ -> FALSE dev->info.dyn_addr !=3D dev->boardinfo->init_dyn_addr)) { ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 0xb !=3D 0xb -> FALSE ... i3c_bus_set_addr_slot_status(&master->bus, old_dyn_addr, I3C_ADDR_SLOT_FREE); ^^^ This will be skipped. So old_dyn_addr never free } - i3c_master_get_free_addr() will return increased sequence number. Remove dev->info.dyn_addr !=3D dev->boardinfo->init_dyn_addr condition chec= k. dev->info.dyn_addr should be checked before calling this function because i3c_master_setnewda_locked() has already been called and the target device has already accepted dyn_addr. It is too late to check if dyn_addr is free in i3c_master_reattach_i3c_dev(). Add check to ensure expected_dyn_addr is free before i3c_master_setnewda_locked(). Fixes: cc3a392d69b6 ("i3c: master: fix for SETDASA and DAA process") Cc: stable@kernel.org Signed-off-by: Frank Li --- drivers/i3c/master.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 4281f673e08d8..c8eaeada54781 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -1531,16 +1531,9 @@ static int i3c_master_reattach_i3c_dev(struct i3c_de= v_desc *dev, u8 old_dyn_addr) { struct i3c_master_controller *master =3D i3c_dev_get_master(dev); - enum i3c_addr_slot_status status; int ret; =20 - if (dev->info.dyn_addr !=3D old_dyn_addr && - (!dev->boardinfo || - dev->info.dyn_addr !=3D dev->boardinfo->init_dyn_addr)) { - status =3D i3c_bus_get_addr_slot_status(&master->bus, - dev->info.dyn_addr); - if (status !=3D I3C_ADDR_SLOT_FREE) - return -EBUSY; + if (dev->info.dyn_addr !=3D old_dyn_addr) { i3c_bus_set_addr_slot_status(&master->bus, dev->info.dyn_addr, I3C_ADDR_SLOT_I3C_DEV); @@ -1931,9 +1924,10 @@ static int i3c_master_bus_init(struct i3c_master_con= troller *master) goto err_rstdaa; } =20 + /* Not mark as occupied until real device exist in bus */ i3c_bus_set_addr_slot_status_ext(&master->bus, i3cboardinfo->init_dyn_addr, - I3C_ADDR_SLOT_I3C_DEV | I3C_ADDR_SLOT_EXT_INIT); + I3C_ADDR_SLOT_EXT_INIT); =20 /* * Only try to create/attach devices that have a static @@ -2094,7 +2088,8 @@ int i3c_master_add_i3c_dev_locked(struct i3c_master_c= ontroller *master, else expected_dyn_addr =3D newdev->info.dyn_addr; =20 - if (newdev->info.dyn_addr !=3D expected_dyn_addr) { + if (newdev->info.dyn_addr !=3D expected_dyn_addr && + i3c_bus_get_addr_slot_status(&master->bus, expected_dyn_addr) =3D=3D = I3C_ADDR_SLOT_FREE) { /* * Try to apply the expected dynamic address. If it fails, keep * the address assigned by the master. --=20 2.34.1 From nobody Thu Dec 18 11:55:57 2025 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2042.outbound.protection.outlook.com [40.107.104.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4F9615ECDF for ; Wed, 24 Jul 2024 15:46:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.104.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721835986; cv=fail; b=Vo1gj72Yc/q6Sa/qCL+uY6SxL5y6iN1qjmL0KEKFoAimcj4bogExlFiQtE5YhEXHx6LwCbxHYkChDDfOENzB26smoBVS9Msn/WmGTOk+ldZFZWNAMjaV1lTgz+0OBlzf+Q0CK+TpOEPDwUyqg9fqMZXXXkyJ05QLHPAQ803vLOc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721835986; c=relaxed/simple; bh=EgTA/bzPVGwsyEemXX3hWkQUEBTDZOU6gFrO4erNl9A=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=k/uoXbkcy/fkmVl8CGBVzEJThwW3yFqD+QMvQ4n9+89ZyVGMcHSTjVSTVZj43jn3ttWorlGGb0nMR7nt910RJI5E56Ue3FSv5JYmG9KoPJmMdrTtSb0CV+aSjQLmT7bbLQxxXCbFOXLIMa5aufk1uD5mHpimfdc/NVvNaUCUav0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=nP0cI2Dg; arc=fail smtp.client-ip=40.107.104.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="nP0cI2Dg" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BE3/41bCQMojSs2o5XfAeVyC3ky0SQbfnvgkVSsZWfFhHJmj9qZLb55Sv3STgHHKERVLafAzhmt82q6AIW8euhFGRokN45VQR7KqE0zxdlXwU2WLbOMV5yxigzkQnUtfVwwLu1W0vPPiL/gu9wO9nK+aXACwV+3Y6PtZqU5kD2GHYmKASps/mb18NsK327YTVsIMJpxu5YUEQWc9ucq0LJCu1yXS0KJknGpz3xwGVtNuw/G2ipBEN2jD06newICeqMNf7vYtdaqByNbdTkQDJAudhyY0xkLPk8H4e87lpwxaCIj5BjIekb08WZMgTER2xX8GM7W+8Hqf4jZRc5cftg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PZHzogEyoKA0FrCgQ8jcF7EjjYfhLpLTAtbn8jWUYd0=; b=OlyQ/+7T93lo0ecrPGaYKB/IdR5kO7VG1S30vy8g9mOjjX24jZAP5N1/3nJTRi400xWJRGu+XlyXQ0QDtkqiob52z4Rj4kvwyRYM9Jt2j9sUCDu4AWSKm8Ftv0vxG0vkQOEsqFUD2eKP24iAC2hlUaXh2DWHWuUiG2LqCLKak3oVQaODvMZdZGkujrNW9mtEksCzmmRlA59YgS6wb/lup/2yiijE2f6eo9zlZmNnj1fgpf5Hor7FgM65AnUL95mfGkVVsdsxUCjuRSMekXaDHhYUc7THglAtuFZpLzWwk19FQSal+qkeCcglp9mOhD3esKEHc3DwuoNxOdsue8jgcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PZHzogEyoKA0FrCgQ8jcF7EjjYfhLpLTAtbn8jWUYd0=; b=nP0cI2DglCsZMvDyldJ+TfBzlVyfz2Y+XpiORwfQrzy7pPgeBXDKhFJ7GR5t+0LMe1dHASWEjyrxcpuBtw655OlR9Oz514WGj7hTmTYiy8Yab49WKQVS/kRRlqggOZ4Oz0LkQDbd/+4mWesfnOra1hFuKc65hoV/kNwen18T+aaGEzal2q2F9VrDZy0XkXYeiGnJN2F9AFdB+Tr6U2asurwAPOA+hvvKoiqUqCnhopzWlYS6NZbDcayq5NbSSP3N0vvSO8A7EmHD77PBOZKVi0V6fqsoTAPKD1Jy7DH3m4W+xqHfKqkD/oFFvSS+vut6/6yDCzcusobtAWqobSPqJg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AS8PR04MB8963.eurprd04.prod.outlook.com (2603:10a6:20b:42e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.20; Wed, 24 Jul 2024 15:46:21 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%5]) with mapi id 15.20.7784.017; Wed, 24 Jul 2024 15:46:21 +0000 From: Frank Li Date: Wed, 24 Jul 2024 11:45:50 -0400 Subject: [PATCH 5/7] i3c: master: Fix miss free init_dyn_addr at i3c_master_put_i3c_addrs() Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240724-i3c_fix-v1-5-bfa500b023d6@nxp.com> References: <20240724-i3c_fix-v1-0-bfa500b023d6@nxp.com> In-Reply-To: <20240724-i3c_fix-v1-0-bfa500b023d6@nxp.com> To: Alexandre Belloni , Boris Brezillon , Parshuram Thombare , Greg Kroah-Hartman , Boris Brezillon , Arnd Bergmann , Miquel Raynal , Conor Culhane Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1721835962; l=1049; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=EgTA/bzPVGwsyEemXX3hWkQUEBTDZOU6gFrO4erNl9A=; b=0UuauI2+/BTetwObzpVZ+YmX7TCq/xYlCGHfHnPIu8OVeBh3FhdtPHT242b84hOpHYMFpmh+i vLeIEA3LZIlB+2HaUC9OWqBX7RUYV7fAywjzPdEUccBjPD9eqJIG6oW X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR17CA0008.namprd17.prod.outlook.com (2603:10b6:a03:1b8::21) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AS8PR04MB8963:EE_ X-MS-Office365-Filtering-Correlation-Id: cb70048c-8e9e-49ec-dd28-08dcabf7c3e7 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SlVSVldoUlVacXdTa0xHSEg1aFNTcURackowSnFnb3FIUitxVG44eEMrNWhV?= =?utf-8?B?K00weEQ4dXNwTUE0ODl0VFhKRWFoWjUvbVRuemtTMkErd1c0OGFHSzQ4Rjg5?= =?utf-8?B?UG9OMGRvOVZteWNoOEJ3Q2JnZ2ZGenF1SzIzaEh5RTgrNjk1NGs3RUN6Uktx?= =?utf-8?B?Ukw3RFErbFlNeXYvR0E5N2FUVHdTaG9kT2ZINkZ4TGYxMVowSGFnc0ZYRGU2?= =?utf-8?B?UmswcGtlLzNZc2d2ekpDRm9MdGFVUit1dnhKaDNCMldPc2pQMkFJZXFYdUU5?= =?utf-8?B?U2xBTFpuMFFUQmFiMnR5YkxXeXdVeTNNUWpuSThtd08yRGZRbksrWXBZbXpT?= =?utf-8?B?K053WEQvQVBvaWJCQmJVN0xSeTQ0SXpsbyt3b2hOU2o3cW5pcHhqNmVBUlkr?= =?utf-8?B?N3FUc0h4REhlWUFzRXBBOFF0dkpFUGhaMERIME9zdFcwdkpmL1d0MlN2K01V?= =?utf-8?B?UHdRaHhuZk5sbnRoclA2aG5lOWhScC9xQ0RqTHRaQ0ZYRG9adDVLdnFkd2h4?= =?utf-8?B?N0VYeitjQ2lQNk1LSEdtUXoxaTNyZFlMT2NPT3hiVDJyRnU4Qjg4WjJIUDJz?= =?utf-8?B?TDhTdXpJUVdUL0s0d3FmTUdXc3VFZE5ESElLNjJ6UTQwdWlVZEFEOWRrakpy?= =?utf-8?B?WDhFbGJBbzB5aTVSS0dSU3RpQjljdmlWTG42YlZXZlpKaHZnQUxvOHNtNjBP?= =?utf-8?B?UjJMNjFKMUhBV25aeGRiR3FNSGFoT2ZHTVE2QmUwdjNPYlZEdnZrT0dvTlRC?= =?utf-8?B?S1lnaldCUmxIeDFFUVB6MHRZSDlSZXVHZEphL0F1RG1udUJvekJTMVJ4T3JM?= =?utf-8?B?L0luVkczUkV4M1M5ODhScng2Mm8yL2FwMmtlM2xLMHNNNFFNbVNBM05tM2ZK?= =?utf-8?B?VDZVUFRCTnVHelptVGtUSGlMK1dhR3FibVZlWnpQMHJPeFFLUUVnQVN3ZlRn?= =?utf-8?B?c2JObzUxbjhncklqc3RRbHlvYUszQ0NmdXlIOWt0aDQ2SnBmcTB0VlJxQzVk?= =?utf-8?B?YjJMY2FJN0l6V21zdXRZWEFBa2lQUzRkakg2N0c1TnQ1SG1FS1kyb1lQZUxr?= =?utf-8?B?NEJyL2UwcysrN2VmWGpMTVJWRE12a1RmZExJRS9tSmRISUxJTitGNVYwZ05B?= =?utf-8?B?ZEEwdDJ4VHBNaXB6OUJrZ1RoS2RjWFZiUzQwMTZadmxMbFlTVkx6d2crZWYw?= =?utf-8?B?ZmN6OFhzOXk1ZHZwQ3EvTFd5VjVqeGYydzh3S3gxaWFLRFp6RTQ0QUxhdWpK?= =?utf-8?B?WUtERndBMWhzYVNUVUZBS3NXcUl5UlFudUxqbzM3NHZpck1UL20wc1dBY2Fw?= =?utf-8?B?YmVuV1lpTm5KUzFoMXhCSHhGSjlwYUw5a3FtbENPSHpBTmlDek4wYlhTNzhE?= =?utf-8?B?QlRhNzlGMDlDb3NyelloYmphcXNoaGx0b3A2RjBOa3N6WG12ZFR1b252R3VY?= =?utf-8?B?UE9VNE5Ja0dXNkMyRTVRUlZDV010cUdCVTFpQ2tjYVRJaXNhQkMrM21Ic1Mv?= =?utf-8?B?NHVxYTdKUlhVQWxKd21lMndicm5MOWk3UHZtcktxMG1XUEZ2dGdERCt1Z25a?= =?utf-8?B?VS9SSVdNOEpnZElwSG5PL25iWEdaQm1GakpoTzIrM05TbTBKbDlGZkgySXI1?= =?utf-8?B?dkdZaThsYWJBT0E5ZExna1hNTUhXTjVkOUVoRnROOS9zZWxsQ1BQSlJjOTVU?= =?utf-8?B?bWpjVHZFNG11ejlYY1BVSkdLUVFRbUFWSVF6MG1MMVFaU0Y4dDE4VnorVCt0?= =?utf-8?B?YTAwUmdjVzB0eTBBeFNTdDBnSDdSNi8xSThHVHJGOUlWMEQ5V1pKOEFpamxa?= =?utf-8?B?dXg2STIxcy9mS00wMXJxQzYvVXhxTkNpUDdQazRmdHRCNldFVVFEd3BUd005?= =?utf-8?B?WCsrRmxRamt5aVlCNTlxQXd1VmxBT1dWS2hURTVPYnB2WXc9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TldjbVFDb3QvQlA0Tlp6THlnSHZnT29LUjYrdStJZXhhUC8vVm5Cci96Y28x?= =?utf-8?B?SEZEZzE1cm93c3k4Mk1TM1E2QXRHSXU4dUF4THBhYkk1djRiR0RXZGZZRGhS?= =?utf-8?B?dVNDb1BYeFdiZnEvU3lCaE1NN3U3UUpGamFNN2F3b0oyYW9VMERBb0xQdGta?= =?utf-8?B?MHBDZjJrUDQyYndtOE1uZXMyM0JBMUFZcmczZW1JbEU5YzBoSzZES056WnlX?= =?utf-8?B?VWZLVm1NUWlrVjRza2hyczUzWnNUZWtKU1hjODY0b0ZyLzZyNExya0FuRUdY?= =?utf-8?B?aVJVdGNuK016WmM4UzJYQVdYM3AzWjZoczIwUlNnTzNUdWJ4MEJlZjZKd0hK?= =?utf-8?B?c1BhenNESG1YNEJlcUxnN3ZGNjhycGxIVTV4MWQzelpkcGhrd0k5bnNEa1Bt?= =?utf-8?B?MUtjWkZ1MXpKdlFWYUhEZnJETVJpRnppeENjODhDdURscDJEdzVLMEdKWjVV?= =?utf-8?B?aEowUDZ1WXVFVllzREdyY0JGWWVTUTBaY0w2QU5wMjUrNnN1ZUdRL0o3QSsw?= =?utf-8?B?b2FtdDJkWC81dTIrRVB5OExZb0diN0JseVI5VW8weHVkQWhvTmFrZS9kZHRu?= =?utf-8?B?Q1FaTWJaOFMrN1hiTDhQVjRScGEwNlJ3aysxV2cveEVpREJBMWNWUCs4djlE?= =?utf-8?B?ZytxUjI3UnlhNTRWT1N1VkZnZHJLL25LSHNFaVJFOGZVQ1BHOFovQkt5NFU1?= =?utf-8?B?WWFLSTYwWkV1YXhLazEwK0tHMnlBeHYydmF6M2E1U2pkZ2tPSE01VDdmdW9P?= =?utf-8?B?K0Z5dUQ3YThqaG42Q292Q3BYTTI4S3BZNEgwVTdiem45NjJVSysvdkdkZklI?= =?utf-8?B?Z2oxRmtQN3BLU0FJeTl0eVBkMktFVXN2cjdpNS9NdDM4S0dpbG9WNTNOaXlQ?= =?utf-8?B?K2VreUNjRml2dlZORDhzWHpRL25UZGkvakFZZWQ1eHAzbzN2V3liTEIvZXZG?= =?utf-8?B?enNFa1ZaN3J0cElIdTllaWpHbVNEMEpINmpRT1cyR0NROEYxS2VpcjNpWDhM?= =?utf-8?B?VVBTVVlSUDVwQ3NTb1VqOGFnRENKeVJTQTdBQ1hkbEhVSHo3cUI1cUtucWpX?= =?utf-8?B?aU16dEVId0UraEhUdlk0THpPYU42cVpESkY2cFFnMFR6Yi90SW5qZlFYTzZR?= =?utf-8?B?eE9sR0M5Yjc4ZmV4TEhVa2J1RTFNNmswVjBEaFVUOENHUE5sa0lsLzFaSkhz?= =?utf-8?B?c0VrREdGMUl4NGt6MVNzMmQ3ZTNoWURTV2lYcTVUOUR6VmxjRUlycDJlMHRR?= =?utf-8?B?T2VkNDc4TzNGVUc4SnhFSHQwZHBOZi9ZaGxEWjRoYTdEeDgyR3BpUHhVcGFU?= =?utf-8?B?bUxVR1JiM2oySGhpa1RRT09FRUhGNWZYZVNRZE5UeTRoVjc4Q3Q1aDFDQm9N?= =?utf-8?B?cHZQU3VDK3FSL01rV1E4QWQ2VFYrOCtqVTJGcXZySzhQZXVEZ3RkOGhjVkRx?= =?utf-8?B?amRNeGJoWktMRGdDeXJIME8rUkZjTnJLQUI1RU5SNEQ4WmIvM1dUUXlIejV6?= =?utf-8?B?aVZXdUpUVHc0V0lHcTg3YWVxeG9vWnFGeWVWVzMrZUNGZEJEcFl6T09RMkFT?= =?utf-8?B?ckxUb1RFTG02WnhuZDJCRjBEaGRGYXJFYjhKemVVYVJKUVdidDN2SlNZSlUx?= =?utf-8?B?OXRWd2NEbWYrNG5mRGFxMW5EektrVkE3d2dVbkhuMkZtKzBWQTVKTVJqWmNO?= =?utf-8?B?ZmZUZlZvRUJTZFNTcVorTS9Pa0JWVStFaEhESTIyaGY0cU10c296eTZWU1Z3?= =?utf-8?B?OHNPaUlxcXpZWmpCcXBwdWg5c3VlSmlGM0Z6NnpITHBtZUdPa094UUlIUlQ0?= =?utf-8?B?dk5pM1Jidld4TFdhN1BSbm83c2YzTUJlZG1CZERmVTM5cXNiZkM5VWNobEhZ?= =?utf-8?B?NlJwYXdxYWIrUVJIQklabklmQXVOcC9yQld5aHpWWUNnbTBHdlRwYnV4K2M3?= =?utf-8?B?YUc0S1R6OEttSjRsZkFRU0E1Q2ZnbTNyaVNaUDFWaWpQcWVIZWNKdTVkYmlE?= =?utf-8?B?NVAxNG1CTFErZStmZ1EyM0Mzb21zaVl6Q1hGdW1hZmdRQmM2b0ZlWUhBVkJp?= =?utf-8?B?RjB0V2N0UzhsNUV0Mklza0g4b3BCdEd4UllyRG5XQ1BScXRqYXUvOXpuc1dT?= =?utf-8?Q?q+OU5c6R56hho0JdNRnAqa7Yl?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb70048c-8e9e-49ec-dd28-08dcabf7c3e7 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2024 15:46:21.2572 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ufVv8VsajwIux79ul1PIpFHgNT70+KtFipUDY5L7KXp09hR4etcxqFI+OMBVGBu65+8ghUA1KDfhqTmOIDaCZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8963 if (dev->boardinfo && dev->boardinfo->init_dyn_addr) ^^^ here check "init_dyn_addr" i3c_bus_set_addr_slot_status(&master->bus, dev->info.dyn_addr, ...) ^^^^ free "dyn_addr" Fix typo "dyn_addr" by replacing it with "init_dyn_addr". Cc: stable@kernel.org Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure") Signed-off-by: Frank Li --- drivers/i3c/master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index c8eaeada54781..65642e5afdcfb 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -1442,7 +1442,7 @@ static void i3c_master_put_i3c_addrs(struct i3c_dev_d= esc *dev) I3C_ADDR_SLOT_FREE); =20 if (dev->boardinfo && dev->boardinfo->init_dyn_addr) - i3c_bus_set_addr_slot_status(&master->bus, dev->info.dyn_addr, + i3c_bus_set_addr_slot_status(&master->bus, dev->boardinfo->init_dyn_addr, I3C_ADDR_SLOT_FREE); } =20 --=20 2.34.1 From nobody Thu Dec 18 11:55:57 2025 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2042.outbound.protection.outlook.com [40.107.104.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC77815ECF2 for ; Wed, 24 Jul 2024 15:46:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.104.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721835988; cv=fail; b=HS8njK6Eh4LURRh6OJrQeUbdL/sUaZt0cK3U6EwvOOgkgMcNOJfG2nnyL89ht4CJZFSEH60AdtIGaD98HOE01C9lZe6CGdj2ZGtg2rNJ+siapu5OxFCXslbXGIM5++rHdbHcbdw6VAJAAA46JnpnemHp65gin5Ohcs90WtT6mg4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721835988; c=relaxed/simple; bh=An63rdNKf8siEFmhpUTOtrd2drbSwaCzp/D7qZONW80=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=TyxIg/cpr3SnEjm6zbID34KVO67OEth6kUhOP7IsIKigKRzPLBGHPmbxzcvBKzIZjZtbPKN+gpKhZxxIZ0TGHppXP+QG2/Jf7mfWUR8X4fxs7TO+C+sV6oD4pxqg12iCceRCdAFAMOx9eUq/j0Jf7FsIH3uIqkZ+ravOrIrYB1k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=BLTB+QqF; arc=fail smtp.client-ip=40.107.104.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="BLTB+QqF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aQm7r6eKPIpox7k2nk9B2vXKDz7HSXNGHcvBFZ32VNXgzZeD+lylIFqDwthvdG5uQAql65GRbHWQ/HYQt1HEWDXLMjgBRlZJCPxKoRYGVovJqEKB4eki4Ub5sjK+gDAcjhh6uHi44bnnEqNBKfa6OsT56HsDInJWEtLBPsx3B5tuvVjWgqUPE+FcfGXgXmldZ+uifafqBoxSuIeNWEPjEBEJjxgBjainBAdmD9gJox9r6gPpbleq1SkpogBNNEflg/dzO/eaIT5HR3nfgwyWtp4e4BWkK/xswFrlYXmFBLxcAbaafA63U/f8mvQk+Iow1kXQRaGoIY4jUXuk6hSKmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DDbmmbFgBxhKaOhHOUp/UpYi2/c+KPJaw5dvLjPdxrI=; b=CaPmVxcuYXaI0yv1EFbWMD2BvkLx075DQxb5diQ/AopRhexHWbTTs0lgPG/kThiDefCjtUXm6Oz7oJJHkk6TjDFuH4wUYgkbxB+EmaWub4QHoKMiC3RUOsrSKhx4xQAZnab3bmnTZ4qMOrww48YN86fefwMCAU3W1Sh5+4bxI9Ibt8vpC+aGWYf5lAt+7zs9Vt0WRVTSwa0y/P0Zs5WSW2pdJoE1LIhA1ABmiWvbjvYS7O0cTPO2OrgdCd95XcII1Ucj69gVvg7dyHUvkUmfZlF4Njc9IpApR/KZ7WSmV3QCWmk0oNpdO0gP5LhS1a5fzI/ZMhkS5VXEWN6gLHyEpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DDbmmbFgBxhKaOhHOUp/UpYi2/c+KPJaw5dvLjPdxrI=; b=BLTB+QqFIHV0LUuhH6wpcv7WXYqjiAohNhfnUBJO+ZKBTMmA/04/S2TMfR6gkYvg0tPWh+qN4stOcmHUYq1lSRUZqzbkiUrk9fTIIM3cdETwc1eKXb3jOcpc4JGx0eQG7xufI/Edq9KMG7q4k1R8Lbf/bhq7RjcRpiq2pwwXXT8IW72u6bDfYbtkjudymdxS+QWMajHCEOTEAFG7GYX8UgD46fxousDpWj+cZvG5ez/l0SLvCOz4wpA9l2cr7OJ5N8+RhWejKSteQepowrA59zZRjhlrf5ZyE/q84UYgY/XVidQuKAEoX85c3BMbqr8HqPOHPl/7qLvTpRGMPMB1fg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AS8PR04MB8963.eurprd04.prod.outlook.com (2603:10a6:20b:42e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.20; Wed, 24 Jul 2024 15:46:24 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%5]) with mapi id 15.20.7784.017; Wed, 24 Jul 2024 15:46:24 +0000 From: Frank Li Date: Wed, 24 Jul 2024 11:45:51 -0400 Subject: [PATCH 6/7] i3c: master: svc: use repeat start when IBI WIN happens Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240724-i3c_fix-v1-6-bfa500b023d6@nxp.com> References: <20240724-i3c_fix-v1-0-bfa500b023d6@nxp.com> In-Reply-To: <20240724-i3c_fix-v1-0-bfa500b023d6@nxp.com> To: Alexandre Belloni , Boris Brezillon , Parshuram Thombare , Greg Kroah-Hartman , Boris Brezillon , Arnd Bergmann , Miquel Raynal , Conor Culhane Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1721835962; l=3542; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=An63rdNKf8siEFmhpUTOtrd2drbSwaCzp/D7qZONW80=; b=2Ij2pePKr9oQIJVOK5bWSO3K/6+4NSzl+qUlw/3b+/5QPy6mx2HNAT9qefo7Huai9Z6dpS96z yXLEdc5qfmjAD9ku9AtHVx79TYOWb7bV+FPm6JHnWihNV4y/447WGzP X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR17CA0008.namprd17.prod.outlook.com (2603:10b6:a03:1b8::21) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AS8PR04MB8963:EE_ X-MS-Office365-Filtering-Correlation-Id: 37e7f5f4-906c-4875-9be9-08dcabf7c5af X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bnp3TWwxL0JkbnJWMElYZWp3VkpWKytReEgzSVp2ampGVlM3QURMM1lCWmNC?= =?utf-8?B?WmZnQU9QZWs1dmNkSDB2VDZPRm1oZEQvbllvWTZXSGJaaWxNUUl1ejczazl2?= =?utf-8?B?UXdOLzhWZ2FmZVptUCtleXpoMjhDV25GWXRuOHFJNlAxRVJJazhWcHJzamJ5?= =?utf-8?B?L0NvdlRSblp6OENFM2dMZlVmK1dMakk1aEQ4SzhvSXkyZ1VVUWI2L1B3TzJD?= =?utf-8?B?T0h6ZXc1eXhFYnduNU9kZldTWEhLTFFFRWFDSmlyNkloYlJYSU1vM1Q0Rmpa?= =?utf-8?B?blpwYmxuY0pDK0tLVE5EbmJMM1lSb1pVbThuY3dEY21uNS93NW5mdXM1Rmgz?= =?utf-8?B?ajNrNEVFYnRBNHZJbHF4QlNKVERtNHFqZ0ZOa2lDaVFmeFpzcU9YOHdLaDNk?= =?utf-8?B?b0FHZU9JREt5czMycXFvS0ZJZVdTVVB4V3pKL05iWWRncjJpWWJVQlFHcG9W?= =?utf-8?B?NFlDS3VGWlpxbmx5anhEL2k4WTFBbHBMcEViNEFyQTVsemNyWlIzeVdFQzNz?= =?utf-8?B?SUl6TU9SRTJKT1dTUTVTMjA5NS9FMDhocnRlQUJhdSs0T09HdlZqcm16MGN0?= =?utf-8?B?TEV1ZE1Ia1FqTEpPaHdsYTlyTHBUUjg4ZXYrTVJEU29BaGlta2F3dWRsa3FL?= =?utf-8?B?RzVDbEM0aVkwQnJaSUdWcURpUEpJNHRWYWhiUEFOdXpNdjBLd1h0QlhFcFZh?= =?utf-8?B?VjlHQWhhUjROZlR5c0ZXVXZpbEYxOEt5NzJNOEhNMTVxOE5FeGUvTnIyZUYr?= =?utf-8?B?UVBiQWNJTFJaRUJsbEQ4WW1nOXN2bWZ2aFNGTllxQmdJd1lqeXB6elMyNkhw?= =?utf-8?B?YU5vMnJYSnlqc29acVJlWk1iWW5sU2p1TkpoTnBPZkpxY3F3YmNEWXhjVm9i?= =?utf-8?B?NW1ldzBua0swUTBmMXBkQmU3dFpHVGpoeHpkQUhjb0VKa1phWGJ6WDE2UllF?= =?utf-8?B?WGJUM2k5U2hSdVJGaTFsaThWVkw0NVZRdzBFZHVlRkhYME1yYzduYzhaL0dP?= =?utf-8?B?TnJSZmJZWDM2cnZKRXVqa2Y3V21VcEpwSWhxeURLeE9RVERyaG1mTEQ0ZHQ4?= =?utf-8?B?dkI1bnpHcVhqV0VZWUVsSTlJUEg5bk1iRHdNenFSa3VyUjJOcVhtMms1V0dD?= =?utf-8?B?SStZbHRTN0loK3pGdU1LUXh1ZjdCUFV0Rlc3dTV1clAwRVZ5blVQdEs3M1dG?= =?utf-8?B?R0xTcjVCWGYvQzkraHM0SHYrZThwUkpIc3IyTU5xMnJNN0pFWDhocHpMRE5v?= =?utf-8?B?YWxRR0h3TlN0cjZ3dXFrMWtWRU9BUkNHRytVYTRGZ2lqZkZGQktvdXFRdjk1?= =?utf-8?B?Tm1LdEV5THJYdGNianEvZlpPdmFDNUxpQmlrT1hDNVpVWWlCNnNkMzZybmo2?= =?utf-8?B?NGJJK3ptR0xOZXFRMXlLdWF2S0VwcUFqdDhkWW1OenR3Nkx0WG54Nnd2NjdW?= =?utf-8?B?VDFmalU2THhaZU1TNGhoK2w1UGVoVWx5alRtdjJLMFpXd3dwUHRKRThpb2Fp?= =?utf-8?B?a2VoWFhrWERLVDFITy9ZRGoxOGFhTElkWEZ0VEh3a3NxelhXemVSQlJzTmF3?= =?utf-8?B?YXN6MHFJTnVxT0JUdVBDdnVTUmpCMDRkdVBINXpxRitER0JJZEZmRjAxTGV6?= =?utf-8?B?S1ZVSGs4QTZ2K1F0ZVpXN0QvaXpKaXVSb1h0QzZKWlh1VXVaYSsyV2JMU1N1?= =?utf-8?B?M0puYmZQbk9zZnpYeVY1VjA3MjhsZ2I3ZFZVdlhOUEFzWVRzNWozN3Z6RUp6?= =?utf-8?B?WFVISXcySm5PcVlaMlN1ZGlRNWx6T2MzSVZaOVVqNFJudnVWMW5zZlVGWHlr?= =?utf-8?B?Mld0UjVXNE1sblZZQlBodjZYQnVaUHZ2bVpKdWd0V0IyblhZOEJ3MzRicXpJ?= =?utf-8?B?QnNjNVhocGJMak1rdjNXcGZ0S0krUkI4OU81VWZLZWZ0bWc9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXRwbHhCWTl1ZDM1eDdFYklNbGNtdVdHK0lQQzlWY01pNUVZOEtWeXpCclYr?= =?utf-8?B?ZlhjTkxYY2RsMytqZkdoUVhYV2VVbmViOXJwVWtuV0I0cm01ZWozRVlxRTQy?= =?utf-8?B?b2RYTURSV1hiYUZPdkhkeDBrZWNSNGhSTmNFM0RUNm8xaFMyNVdjcFdMdEhx?= =?utf-8?B?YVJlSE52S2NIUEZLV0padmRDR0ZTeUlSSmR3M2NxZjVDamlVQndXd3BXMi9T?= =?utf-8?B?ejBQRHIwYU1taXhzcVFKTlVURFJSVXIwcHcrNy9UempjS0dDSGhNcnBQbkF4?= =?utf-8?B?NjVJYktjbGx3QXR6d2tSdXczYnFlc0g1VTZqVERZR0hJOWRLdHJoNXMvSlVi?= =?utf-8?B?MDlTU1lYZll4emtzSjZoSFFsUWYxVlNya2FSRDM1c2YvREFFMFFrWXdwenNl?= =?utf-8?B?SVJZdzduMkhXUi9Qd3o4Q1g4NjdnTm9JejhoZjdNaUp2R09weWtqenFVU3Qx?= =?utf-8?B?TFVOMU4wQjFCUFhxRkFsd3F4ZWlZOFFMWFlSNlNUSjNHaVdaSmNhQ3RXVFha?= =?utf-8?B?VVhCTGxTSlY1ZENKSTkrSjkwYlFzV1Q3d0V3UEo4MHVreFplL05uN1R3bmJ3?= =?utf-8?B?bkcwd25PczRTQU96SWxRRzI4SWlWSXBvQXlUNEhRek90bllLTXJuUDB5N0ha?= =?utf-8?B?S2VxM21XUjJuaWYwTGp5VEVKZHVEUHlxdVVab3RRcElNZXRBV1pESSs2V05M?= =?utf-8?B?aHUreE9lUy9BNnFzRnlaaDNSNHUvbVpRTFJUZkkxWHYwbFRyRFpIaUpRcUt5?= =?utf-8?B?LytQTmFYZHF6TUZreHVzM0RzYnRiQ1M0L1FNL0M2T0RRcjM4VHgyZHdFUkZC?= =?utf-8?B?NkVIMUVqZFJYSzBHcUtEbDBVa2M2STY2YjZueE9Eckc2MmVHTDU1YW55ZGRU?= =?utf-8?B?WDkvQ3hsUFcwTGZ1MFdlYmc0VWRzNmw0ZlpSQ1cxS3NGYnJmYWZEWHo0WSt0?= =?utf-8?B?SjRGWFZmaEtJYzA0QXE2NVVQNFlXV2FtajJxdU1UMTB0K3JuSUd5Q0VrTWFi?= =?utf-8?B?SThMeXJaaWtRc0NhQ05ObytmMEZzSG5oby93UDFaMUxwUUY3YTZiTHdhdHNM?= =?utf-8?B?T3FBN1FkZ0VYYzVha2xiajJ3NHB6cEliblhFT3JyNjNGZm9VNE9Uekp4QWdT?= =?utf-8?B?RnpUVHFtU3l3eHhuR1p6MnZ5TWVobUFHcWZRT0F2MzBKaDdhR3JRMFpSQm1a?= =?utf-8?B?MUJ0NWI3VkM1S1NEYmhETGFSNUZrbm5LNGVWNUppOC9NUlcybFpmRHNNUjds?= =?utf-8?B?QTJ4RG5sYzJBMEZ3UmxZYTlkQkhWQzdtZVJoRFMwSlRydXRBWmVqUy85TzhX?= =?utf-8?B?MmM0dVArbDk5NDJzMEFNVGNFRjNUOVNIVXZLS1Fqcjl6V1lLcmFmWWVPaU9W?= =?utf-8?B?c1hiYUpEOFdKTm9tL090eGNzekF5dER6cGlrK0dzT3RlT1hQOWpoak4yeUZq?= =?utf-8?B?ZkNTcktrYjNDK0NTZmpaVjlra0FMWjM2MERMOFdiZkorVjg1YkNiajhoS0Jv?= =?utf-8?B?Ukl6THNMaEF5UkVqaGJRbWppS21ETW1CT2ZHVDhTelNabWZHOGpHU3lBRS9s?= =?utf-8?B?N1VvVjRYRDNLQVRkT3J4ejFzaEx0R2J0eVVKQytDa0lkM2NvY1dPVEZ0Tm9Z?= =?utf-8?B?R1BUWTl0ZHlYTnd4SGpjYys1d2d3ZHduSW13akF2NXVKbm9jR2NNOGlURCth?= =?utf-8?B?dXNPakJlWWl1c3lVeTRaZDZhVk5kb0JLb0xxcllBS3grTVFmZm5YaGJjMmho?= =?utf-8?B?THQwN3l0QmZOQWdmYUhtNUpubHgwU3VMZFQvRFgrT1FtV1JjL0FPRnZIRzFV?= =?utf-8?B?T3pHM0I2QzNpWEpFeVpkaXVLeTlsbFRYRStOUTgvdzQ2MWxqNTk5Uk5oN3Y2?= =?utf-8?B?K2NIajdIM2ZDVElXUE5MTXZTU0F2dHB0eTNieUZTcFZOY0VnTWRxY2RKU3do?= =?utf-8?B?elY0aW5raFRSNXcvL3J5M2F1TEtyOUhRdW5rbGtTazE4RlozdGlkSzFkY1kw?= =?utf-8?B?aWYycEFJZEw3Zm5SdTloTGE0SWU4L2pBYW5zVkoxSERwV1BLUUdSclNmU0Jl?= =?utf-8?B?a2xETEorN3QrMzl5OSt4ek0zMld2L0RaQmJIaitzSEl6Zllxd0xjcm5jVUhw?= =?utf-8?Q?V9HrB6ZaZ7kjhWjgzuSCBO8Z8?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37e7f5f4-906c-4875-9be9-08dcabf7c5af X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2024 15:46:24.2434 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lY0tAXpsv75WymS0eLrDwuv4sUQHtTHvTGtmzO5idElAlJeh2Htli3fM+jSsMS4/ZDITZyqG9TP21kw7XAJpkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8963 There is a possibility of an IBI WIN occurring when addressing issues, even when sending CCC commands. Most of the time, returning -EAGAIN is acceptable, but the case below becomes highly complex. When a Hotjoin event occurs: - i3c_master_do_daa() - i3c_master_add_i3c_dev_locked() - A dynamic address (e.g., 0x9) is already set during DAA. - i3c_master_getpid_locked() - Another device issues HJ or IBI here. Returning -EAGAIN causes failure in adding the new device. However, the dynamic address(0x9) has already been assigned to this device. If another device issues HJ, it will get this address 0x9 again, causing two devices on the bus to use the same dynamic address 0x9. - Attempting to send RSTDAA when the first device fails at i3c_master_getpid_locked() could also fail when sending RSTDAA for the same reason. According to the I3C spec, address arbitration only happens at START, never at REPEAT start. Using repeat start when an IBI WIN occurs simplifies this case, as i3c_master_getpid_locked() will not return an error when another device tries to send HJ or IBI. Signed-off-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 36 ++++++++++++++++++---------------= --- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index e80c002991f75..5d19251238ff8 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -1099,6 +1099,24 @@ static int svc_i3c_master_xfer(struct svc_i3c_master= *master, if (ret) goto emit_stop; =20 + /* + * According to I3C spec ver 1.1.1, 5.1.2.2.3 Consequence of Controller = Starting a + * Frame with I3C Target Address. + * + * The I3C Controller normally should start a Frame, the Address may be = arbitrated, + * and so the Controller shall monitor to see whether an In-Band Interru= pt request, + * a Controller Role Request (i.e., Secondary Controller requests to bec= ome the + * Active Controller), or a Hot-Join Request has been made. + * + * If missed IBIWON check, the wrong data will be return. When IBIWON ha= ppen, issue + * repeat start. Address arbitrate only happen at START, never happen at= REPEAT + * start. + */ + if (SVC_I3C_MSTATUS_IBIWON(reg)) { + writel(SVC_I3C_MINT_IBIWON, master->regs + SVC_I3C_MSTATUS); + continue; + } + if (readl(master->regs + SVC_I3C_MERRWARN) & SVC_I3C_MERRWARN_NACK) { /* * According to I3C Spec 1.1.1, 11-Jun-2021, section: 5.1.2.2.3. @@ -1132,24 +1150,6 @@ static int svc_i3c_master_xfer(struct svc_i3c_master= *master, } } =20 - /* - * According to I3C spec ver 1.1.1, 5.1.2.2.3 Consequence of Controller S= tarting a Frame - * with I3C Target Address. - * - * The I3C Controller normally should start a Frame, the Address may be a= rbitrated, and so - * the Controller shall monitor to see whether an In-Band Interrupt reque= st, a Controller - * Role Request (i.e., Secondary Controller requests to become the Active= Controller), or - * a Hot-Join Request has been made. - * - * If missed IBIWON check, the wrong data will be return. When IBIWON hap= pen, return failure - * and yield the above events handler. - */ - if (SVC_I3C_MSTATUS_IBIWON(reg)) { - ret =3D -EAGAIN; - *actual_len =3D 0; - goto emit_stop; - } - if (rnw) ret =3D svc_i3c_master_read(master, in, xfer_len); else --=20 2.34.1 From nobody Thu Dec 18 11:55:57 2025 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2086.outbound.protection.outlook.com [40.107.103.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC47B15CD49 for ; Wed, 24 Jul 2024 15:46:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.103.86 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721835992; cv=fail; b=osHcigDAqd8df1QdDZmsNai83HXUwgKhFvQU5s2btUXhiYl7fnFZ0QSS4dvkXEULI60UjjRpCUk7WWzWchZhOXu7Kml3t1Vc2zk6tFa7zkCLRg+rUKH8+fqNfEb/wE5J03YGYEbovRkI2aSx2/VroNVp+mLUuw/S2jqOB5PNYlI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721835992; c=relaxed/simple; bh=8AD6/oyw5maO8G3UDbDr2ZOWPiM7trJt/A903JRssEo=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=oftzKPV3NFYh6/Haodc0XshDmIiQEwFDh0iDsqNz9XvpCYJ+msNNmSWWc+wmqTZyAdiiwEeeFEho91pvTJl8zI0Q7TnDFqc9c7pPby4lod9czP5dKkQH92IpZEvNoTqYJlky6omPPqD7U9zU6LMo+8Onb47DRZ/y9YUu79eyVZY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=kAxJ7STB; arc=fail smtp.client-ip=40.107.103.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="kAxJ7STB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=A5eKVmHUDVhl9/BUz0qqvhhXz6099jSlA00Y+qW/KrCfnA8GbdHKe8lRPkz4CVmSDbwC4I2exWKsmqoYhZ2IznHkJUcsD1wj9n+SFKPmc1eEExU60w0UToX1UYmaDufu5A8kqPaLQoFujsodcNIBY1YQ/3LH1XaQN9LombJQ4/ZMBfEJ5OoNkP9jJn8CCTCvB1i9hRJGoK254uCIr7zVCBh+81FVMDCS/IVBEbjTNgzTUJuA5Ek3PxO6+9AUXqVMH/aJZEybSrchT5hyybMsNxRRhaYzrChpfhUi4guM7dJcJibrj6DSIB2D/mHsGWLZERiTzkoQeRFWlaNAAXJukg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v4JXtZRVQMARG9qMgKwkntLShr3lq15YWhLhU+kDbuA=; b=q3fvJMfno1+ven8LgqtwIzTua7vjX1+93EjwHocXR4Mu8RsEwaXFjxUSlRwZ+cr+wFdI2MQHRMYYf1S1mm8iupFtLnwKV0FZ7rp7VdUupKwU0cUI+2ORM/QB8gMu9dR1TpASNlY1S2HlQOr6oTH/jTl3lY7EM1KGoFQUBvUgAGbIAErlg9yQVUp6tkQiNI+D+pZZKAJYHOOtPZBHLKcL+ZDeUMEavrqVxzOzCI/eo/aBhxa8fzuR67GLyf10flynBAQOXQemfTlNkXUT/mlY2rL3EB4mBPMOMpV8sV7xjUxMsJHaT6Hx5rpdp1KZhZ45X4mHLh6z1AA7BWIt0VDJ6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v4JXtZRVQMARG9qMgKwkntLShr3lq15YWhLhU+kDbuA=; b=kAxJ7STBo6rnxGtDfqQThzNbEBHICtfj7kNiq8N7mWaaDOL4ipEhajZrcfUYwNZu12WSrTELCytJdkSs2CG53ATWZLPFm7cF1r5f4hed+iOiroakSevWagcuQ2TpfwQLkewKvt25ApG2VWqZI+bGvGJOKZNzISuGEx3XNmRUUiTjwnlfYSetKcvVEa7efCp8N7li3T1eQbUR7pY1rdhJAK4LHN62OXNZ9dTfGu6FxX+f22dBzhdIfhs0L3fDyriM+X/OgvqXHsAnwkHaMbYlBLEkujXFOqwZVezxjATZUXvAHAn5/SJEG8E7e348YNx3oNb32g13ocb9AJ3rrquICw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AS8PR04MB8963.eurprd04.prod.outlook.com (2603:10a6:20b:42e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.20; Wed, 24 Jul 2024 15:46:27 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%5]) with mapi id 15.20.7784.017; Wed, 24 Jul 2024 15:46:27 +0000 From: Frank Li Date: Wed, 24 Jul 2024 11:45:52 -0400 Subject: [PATCH 7/7] i3c: master: svc: manually emit NACK/ACK for hotjoin Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240724-i3c_fix-v1-7-bfa500b023d6@nxp.com> References: <20240724-i3c_fix-v1-0-bfa500b023d6@nxp.com> In-Reply-To: <20240724-i3c_fix-v1-0-bfa500b023d6@nxp.com> To: Alexandre Belloni , Boris Brezillon , Parshuram Thombare , Greg Kroah-Hartman , Boris Brezillon , Arnd Bergmann , Miquel Raynal , Conor Culhane Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1721835962; l=1155; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=8AD6/oyw5maO8G3UDbDr2ZOWPiM7trJt/A903JRssEo=; b=NVQR/STY999tK82BWZmJWzz48Ldla2y+1bpy7jeCH5M3rNEXgYj2Hd3ufwIsSx2iMb2vJ3Eoo oEcZmcGFtm5CQfNO/tnsG6nnlQLD+owSo3uRPyE0hHniUOyiHRovvLi X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR17CA0008.namprd17.prod.outlook.com (2603:10b6:a03:1b8::21) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AS8PR04MB8963:EE_ X-MS-Office365-Filtering-Correlation-Id: d4e6e549-5d11-4031-ffa9-08dcabf7c77c X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Vy9RMEJOVFJrbTJKY2xFQVBCeTg2WkNUcFh6SktmNU1lbWg5ek90UTI2WVVz?= =?utf-8?B?U0pvQVhTNUkyZkpPUy9sQWQ0aWRaNGIxdkxhUUovRmVJWnFPaXBJZTI1Z1Rs?= =?utf-8?B?ZUkwQnpKZkQzdDVMeGxWa3UrUzJOSFk1bFJVbm9HU0QwM0kzcU9VeXdVbEto?= =?utf-8?B?WHlhTVpRRlUzb2NxQjJ6ajBla0ZtUmJVT2VtcUE1cjFjbzBUTnBMOE9MSXpj?= =?utf-8?B?SUJtVzZnMHY3dTFORnZiYUlwSHp0aDQ4RUdlTUlYM0xJU051WDZWTUNxY3J6?= =?utf-8?B?UnBNT2FEL0VWWjJ5MjBiTXdlTCt2alJ0ejZHV1pMcDUzM3c0Q2VJTzcwU0cy?= =?utf-8?B?Sk5ZcWVhc0RBTTZ6Ui93ajBHU0I3WFlaNUgvMDRLaGFBTHJncktveWszMHZp?= =?utf-8?B?TEJ0MFdPZnA3SmNwY3prNFMySEQwUlNqTnE1QVFrc01nVTdWZ24yODNDdys3?= =?utf-8?B?Qm5KanhWUDF2K1dGdDFJZXJ0TkFENWhyakRnQWdXNWdMOXp2Tno4ZVIwa3Va?= =?utf-8?B?bEVDck10STlvZ21FczlhcnJhZlVFamIzTTkxTG04RXpneGpNZGJCejI5NWJN?= =?utf-8?B?UERUeE53bHdyZ2VQVHB3Uit0SGlNdDEySDREMzJuMnhQZmx4UGJXK3VIVUFE?= =?utf-8?B?MjlZd3d2N25kZXNGZjJLcUdTOG5CMHQwT3FuNm9jY0xvTUc5a045SWVaVVRE?= =?utf-8?B?aTBhc0VMYUpxeitZV2dLZlVLUGZ4eFFOd3A3Z3B3RFUrTDVQT3dUMVhuTFI5?= =?utf-8?B?MjI1VkRJSXhTa09mUGVOd1BvTUV5YnY0RFduVmlTU1lJVCsxa2xUY0J5YUlL?= =?utf-8?B?N3FWME0wQzA4YmMvc2NNZ004aFI4UDY2T29neWRna3pGYmdBUUJURlpYWDRC?= =?utf-8?B?YmNZTmRHVzBWZU5sNjBGTE9hdUl0OG5OVGhubnVLZThGemFpN0hXVXZOZGV6?= =?utf-8?B?dFBKNTBmeXBYZWhLMXVYeUZFcmF0a2NyMDg3L1F6dXhhbkNQTGhpdmpGSERO?= =?utf-8?B?TnhUT29Oelh6TTVpbWFlWXc1eGY4SjI2cHlFbzJyVlFiRnI3MFFCKzl2ZEZ5?= =?utf-8?B?SmlWSE9FUjBWV3ZoTnNGTkE5aGxkVmJkNVM2RCtOTTB1UXp3OVRqekw0Z2VP?= =?utf-8?B?dmwyNlovMVZiZTN0a1Q1KysxeU02SG1IY1VKeERzRUpoVHpnV0ZoMXZibldH?= =?utf-8?B?d2xPbWo3S1BON0dZVFAwcVQrTGtkVUpJS0E3OWozaDZROXArNlg0OVRCY20y?= =?utf-8?B?VnhmV0hwVEVMQ0pMQXhyU2tzZ25kVEJuN0hlTWhpeVFQQ0VySlRGc29VNk15?= =?utf-8?B?YlRNRVdrc3ExWk5oeVVGaTdjU1RlYXkzeWRucXFCNWxMTUFndi83ejBuR0s0?= =?utf-8?B?aEdjeVZYWk1RdHErc1FEM3Z3aFBPalNJNnMySmE0NGhRKzBjTTFnaWd5UlZw?= =?utf-8?B?Nm9mMTkxSUpSbFRKNEZuWVk4eVk3Y3ZIT0d4V0VncktUQkpMR09JN0VSY2RT?= =?utf-8?B?cmVVNFJDSi9WNEJKNUtOdW9HZWFDQ1RXdzdZenBMWS85aUY4czZXVTh0aDFI?= =?utf-8?B?NGduYno4N1h2SjFMNm1XTlg2NVBRdmR4bmxYT3h1K2V3QVpoUkxFUnJqTm5a?= =?utf-8?B?Rk5wL08rY1JQYTdlUXBsRUQ0aVR6cVlZekljQ3hLbUtCcFpRY2swRForREVG?= =?utf-8?B?TnZNNXk1UmJYQytWNGJubjRFbnlBaGdVTUkzbTJSY0FrOUpnMlhndjR6amtM?= =?utf-8?B?d3FUNzRXa1JSamc1SUdBSHE5YTdGdXFIcU9NUlZOMlE4SUFVZWMyamhQMWxM?= =?utf-8?B?K3lBeDRkTnNmbzRsa0x6dml3NUpodnFSaEo2VTlwbkRxSnZ1TEdyY2dEYWVX?= =?utf-8?B?K1UwQXpTZkpubWsxNDhFS3pHNGNUNXI3NXlNY0hXVVlyU3c9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzIxWUUzMjJtVnlYbTdKbW1Cbi9FOWN1OFdseHJsZnVDM2dGcTU1QVJEQXUz?= =?utf-8?B?akwrV1YxR3F6d1VaeCtVUGU1djRzYmpXVDd6WkxqVU1iU01PR01EWUpySlNo?= =?utf-8?B?U1FibC9KRmVLQm9DcjVoYnlFdDVRUllRcWdWQTNvSFhVSXRmUmgzMWlMK3R1?= =?utf-8?B?VkZvUko2c2xmYXdUbFlzSnJJa0lMWkQzQjNNQlJhT1QrQ3h1OVhDemFhWHND?= =?utf-8?B?UG1TWkhBbjRCREZjUzJwZEVSM2xMSlo0LzhNT3UxL0RZV0I3dDlOdG12Snd1?= =?utf-8?B?SWNwaWJ2aSt4MkNNd2NLMlRGMnFLZ0VHRmN6N2NHUndwalpJMHh6dDhWZzdS?= =?utf-8?B?K0NhUnA4NWFpUjhPZkozQjgxNlA0a1dMZHhWbDEybTAvVTc2RHIrTzdldEhy?= =?utf-8?B?SE5xUzdHOU10OWZBdWxlaERTMjN0Vy9TdlJha0lQQnd4MGdsbHlNN2tQOFZO?= =?utf-8?B?SGVjZjhxN3k0SHEyZy9GNEhRWDFkdFI3VW5IWmZTUzU3WkN6QnRHNE5SYmln?= =?utf-8?B?L2VxYm00L1lzRzA5UHRWb21Xd2N4dXIyemIrWjhxK0Y1RjJybEt1dXZoVkNl?= =?utf-8?B?L0huSlloaUduK2hxSWVSRUZCcU1PTlpwN3lKWGJkUUhma0lZdktQcjhwQ0Zm?= =?utf-8?B?R3J3SVJJMHFubm1RelZwamxxelkwZVhnUFFHMWR3Sk9idXlIcG8vTGhRZUJ2?= =?utf-8?B?OEVRdmYwc1l4VW5rRGNrQW9YemFnNG5mYVJ2Sm1XSzcyK0RwVW40SzVrQ2U1?= =?utf-8?B?TFM0Z0lWMVRGSW5aSGtDTXRGRGMrbjZKRWdJK0FndEtXZXZ1VHBYbS95eGU1?= =?utf-8?B?ZGFuU1QvekI3azdFZ0pidTVoeTBGTCtmZ2pkQ2xIZUN0WnF1bnJTem8vQ2RL?= =?utf-8?B?Ty93d29wbHlBQ2NkNjlIQ1JzeTRhdTkzSStiQjU1VzhZaTgzcUhsdTRyTEMx?= =?utf-8?B?TlI3aXI3UlFESTNnazU0N0gwNUZCUHhDU1NmNUFDNFhLS0RGa2tQVUx5YUVs?= =?utf-8?B?WTlKdnVpZlZiZzE4K2R4Ly96emVJNlFSWlZlYm1MRU9UNlBrcDQvd0NmK0xH?= =?utf-8?B?R2xudFlsa3JoTkhrOTZwUlVDMU9BTEpHSjN2QTJyelJ4bVNKTWtRQmpPTFI1?= =?utf-8?B?d3Y3OERpc1orY213Um9TYlptTGVmZXAvbUZlRWhEczhVemwzWXpyQ3Z5M0ZH?= =?utf-8?B?YVBxNytWUUFrYURXT09Ic3Rra2F4bkw5QjNLaFBsenNtR05ERWVBTDVmaXl0?= =?utf-8?B?NVZiL3I2SmMyazJyUjFYQUhEU043RUpCdjNERGJVOHhkamxiR1lFUkhsL1ht?= =?utf-8?B?Zzl1Z1I4Z051c1djNzl1TTh0VElzc09WTVZHRmc0UGlFU25kM3JzamxkdHMz?= =?utf-8?B?Q3pzd3lLRXo0eWlBTkJrVEVOTmFJaTEyY2ROOXpSYnVqQ3dHV1Z0QjlxK3d2?= =?utf-8?B?ZFF1eHpDZkxrdUFHTkdFWlg3K2g0TTJjM3B6bFJpbUNTYkxCK3dqMEUrYjdI?= =?utf-8?B?ZFVqdm9IZVEzY3pKc3FrRE5zclBoZHl6cTVsTlZtcGZXSVJlcEFuejRCOWJt?= =?utf-8?B?UVE2V1N3YTdCTWNRanc2cm9GRUg0cnhacVdUZmlOSlhCbW5rVmVvaERXVmcy?= =?utf-8?B?RVZCM05jcjlMTEx1R215NU5GQ01NVGlvL2M1NlljTmR2SStTeUVCVVVBMnBa?= =?utf-8?B?TStEaHZ5VmxPRFpVK3NGTHYwTUl6WnhJVnEwc0NqeXUyWVNFU2h3VjlqMWNz?= =?utf-8?B?K3NwcXBad1F4UitMOVRPZkpTcmNZODJuTzJTb1BsRFRhOUFkRFFPbHdUVTAw?= =?utf-8?B?NXQxZkVJM0ZteVkxbDBORU9pak80UW9GVW5sNy9TVTBKMzZudys0NkpCVEZJ?= =?utf-8?B?RGtBSkFRUlk2TEI5R0JnajBScFVoVlhiNmZiVmJRODh0UUI4b0NYak4wd0ht?= =?utf-8?B?dTBiYmpCMmQ5NkNoMTgrUnNBSERqTkZ1QXhxdmZSUEhVUWtoUnFmbnRxVXFt?= =?utf-8?B?U25PR0F4THVVWFd6bU4xc2xrWnRUcEZLY0VkZ1U4SUp6QkNmZXJjQmIxTkxD?= =?utf-8?B?TVRtdlV4MDFYSVlVYVIzeTVjSERyM0RFZHNILzA0ZUtSbE9zaE1iNmR6OVFH?= =?utf-8?Q?lUPJ3ONH5Ac/7VarRx+Q5od5X?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4e6e549-5d11-4031-ffa9-08dcabf7c77c X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2024 15:46:27.2991 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4PlNxrwA3uqt9pkxnGLUkZQp7NmCZMLJIPQkV8RG3k+N+Be3hipRJOGuHnUhn65xzp0KGLEnSdWysdyiPHYIRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8963 When the address is arbitrated at send address, the hardware can auto-send NACK if it is an IBI. However, manual emission of NACK/ACK is needed for hot join or controller request events. Add an event type check to send out NACK if the event is not an IBI. Signed-off-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 5d19251238ff8..36e01d0430747 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -1113,7 +1113,15 @@ static int svc_i3c_master_xfer(struct svc_i3c_master= *master, * start. */ if (SVC_I3C_MSTATUS_IBIWON(reg)) { + int ibitype =3D SVC_I3C_MSTATUS_IBITYPE(reg); + writel(SVC_I3C_MINT_IBIWON, master->regs + SVC_I3C_MSTATUS); + + /* Hardware can't auto emit NACK for hot join and master request */ + if (ibitype =3D=3D SVC_I3C_MSTATUS_IBITYPE_HOT_JOIN || + ibitype =3D=3D SVC_I3C_MSTATUS_IBITYPE_MASTER_REQUEST) + svc_i3c_master_nack_ibi(master); + continue; } =20 --=20 2.34.1