From nobody Mon Sep 16 19:37:49 2024 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A48BC13D8A6 for ; Tue, 23 Jul 2024 06:26:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721715993; cv=none; b=McATKdf8b/KYkFj9Fj8eCuokmzHwhJPmP+hRty3CVQ73yLxQf0eAZeGblzVnxY/kwV1GIF217O437tL2LGdk5riAfs/drwh7spUL18Sm1tDFcRP1NCpCEQwvIkZvO1ZpavjII+VbsFL0zd6PSq9msaP1JuPyxnvS8xa1i6OBdDI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721715993; c=relaxed/simple; bh=sPvIUhcfxQrn/1WC2FAzQI+ObrcduHZ/wkF5+Fgq014=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=U/Kq6w2/gvEytz0ce36S1JjK+ZxN1VZTHYC1m6zQFdSuUkBzXWfDScb52951booRw6aSHws2R1oNCd7ZOp6QpfRSGWtkN2TSj6WeK++KAg6vB2ogKvMzmoDNopVA7K+IhdHcNwLt/R2wK0wSeyte/Y4vWqcnvc0BBuPYxWMl/cM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=huaqin.corp-partner.google.com; spf=pass smtp.mailfrom=huaqin.corp-partner.google.com; dkim=pass (2048-bit key) header.d=huaqin-corp-partner-google-com.20230601.gappssmtp.com header.i=@huaqin-corp-partner-google-com.20230601.gappssmtp.com header.b=rvrcS7Cp; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=huaqin.corp-partner.google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaqin.corp-partner.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=huaqin-corp-partner-google-com.20230601.gappssmtp.com header.i=@huaqin-corp-partner-google-com.20230601.gappssmtp.com header.b="rvrcS7Cp" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-70d1d6369acso1413785b3a.0 for ; Mon, 22 Jul 2024 23:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=huaqin-corp-partner-google-com.20230601.gappssmtp.com; s=20230601; t=1721715990; x=1722320790; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=Gkiwi2HblLWIRJEo+ICl77dLaAlbyjAEjVCFsYMguCg=; b=rvrcS7CpvC6SX661YwFE658PsgJB5sp10JvE4DwJCwY89k2I1Pj+gLdS7LgwrUNoFT vI+76ClIxm7T27BSrwdyRb+5gVqTPUZhlt+1p3ht0+DZCns/UOR9cfdctiYE+vU26IH/ fl2oojjsO0RIZOei29D+kxTIWiv6hcgZ70e1s4zdlGCInAt86qCWe8bofhxp4Gcav/HG +2hQnNe1QkUC4NCJJzada202A7a5zWGTcVQEm6FCtUU4e8A52XG6t8eLclyZSQ2d7Ww4 4xZQ1iI6e5g1qjc754DqEgISKHfGnj5s6xvJ6v6JTE3sVpp4i/eexvlcvyO+4FkwFQO2 lwhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721715990; x=1722320790; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Gkiwi2HblLWIRJEo+ICl77dLaAlbyjAEjVCFsYMguCg=; b=XjVZuNA9eHCFy/0Kt2W49GQvtKAVyVmqBYcApwq36aS3KXzCjIndydmlKDCdY8Wsxg j0tSKsco6azMKXsg64bmTbRrOjeDeLg9VYsNN1LYAxb2pKYN17f/BCjnkU80JOFghG4w TcQqwLZwgkatMDIDrnBzyXafdeqQPCEmvonJ2KvXiXOYcCl5m7yw+aZCgh8RStq4H8Jx Y5EFjJ2Jdgh4CdVIWwEQ5mtJpSYQ+FXs5+FH2eLp0w5iQuBkuRWSyJiHoaYG/8qY7MFW SVdw1Sma8XO6xMO86cLv9YIPqLOXZxhblk/4SyIsy6e37U0b87uVgoPvTSPBkTGbgcRN pSew== X-Forwarded-Encrypted: i=1; AJvYcCWpND5oJg2F8E1hsmlop0mmob16CYU5r2CLhRkhIznfawm87iAtEE9VMUvJf0L1cv9g8YLzFJiyElLrT09nGFpXojbDsHPP1OBYLYBV X-Gm-Message-State: AOJu0YwladB0y7IXutn2xW0xWX0XcgJOcZDF7+n2lY6fUTqOZaoqjQa8 nXvGoRj/+lHKHjGWBhSndLU7JqlydDnP5U8KM08lydYgVHMjojr/5TEp21ACdIDq3vlShkmE+Kj m6Kg= X-Google-Smtp-Source: AGHT+IEMEYV49A/7sN13fNs7QtDLUZ+KsEivgaXNWoeS2uNGXFKSc3HIPXHBpH2cEqizv54RUEDbdg== X-Received: by 2002:a17:902:d509:b0:1fc:4acb:3670 with SMTP id d9443c01a7336-1fdb95128e9mr16250375ad.12.1721715990126; Mon, 22 Jul 2024 23:26:30 -0700 (PDT) Received: from lvzhaoxiong-KLVC-WXX9.huaqin.com ([116.66.212.162]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fd6f25ab47sm66351465ad.45.2024.07.22.23.26.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jul 2024 23:26:29 -0700 (PDT) From: Zhaoxiong Lv To: neil.armstrong@linaro.org, quic_jesszhan@quicinc.com, sam@ravnborg.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, dianders@chromium.org, hsinyi@google.com, awarnecke002@hotmail.com, dmitry.baryshkov@linaro.org Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Zhaoxiong Lv Subject: [PATCH v4 1/2] drm/panel: boe-th101mb31ig002 : Fix the way to get porch parameters Date: Tue, 23 Jul 2024 14:26:14 +0800 Message-Id: <20240723062615.14796-2-lvzhaoxiong@huaqin.corp-partner.google.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240723062615.14796-1-lvzhaoxiong@huaqin.corp-partner.google.com> References: <20240723062615.14796-1-lvzhaoxiong@huaqin.corp-partner.google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The current driver can only obtain the porch parameters of boe-th101mb31ig002. Modify it to obtain the porch parameters of the panel currently being used. Reviewed-by: Douglas Anderson Signed-off-by: Zhaoxiong Lv --- Changes between V4 and V3: - 1. No changes. v3: https://lore.kernel.org/all/20240722092428.24499-2-lvzhaoxiong@huaqin.c= orp-partner.google.com/ Changes between V3 and V2: - 1. No changes. v2: https://lore.kernel.org/all/20240716121112.14435-2-lvzhaoxiong@huaqin.c= orp-partner.google.com/ Changes between V2 and V1: - 1. No changes, Modify the commit information format. v1: https://lore.kernel.org/all/20240715031845.6687-2-lvzhaoxiong@huaqin.co= rp-partner.google.com/ --- drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c b/drivers= /gpu/drm/panel/panel-boe-th101mb31ig002-28a.c index b55cf80c5522..d4e4abd103bb 100644 --- a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c +++ b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c @@ -312,15 +312,14 @@ static int boe_th101mb31ig002_get_modes(struct drm_pa= nel *panel, struct boe_th101mb31ig002 *ctx =3D container_of(panel, struct boe_th101mb31ig002, panel); + const struct drm_display_mode *desc_mode =3D ctx->desc->modes; struct drm_display_mode *mode; =20 - mode =3D drm_mode_duplicate(connector->dev, - &boe_th101mb31ig002_default_mode); + mode =3D drm_mode_duplicate(connector->dev, desc_mode); if (!mode) { dev_err(panel->dev, "Failed to add mode %ux%u@%u\n", - boe_th101mb31ig002_default_mode.hdisplay, - boe_th101mb31ig002_default_mode.vdisplay, - drm_mode_vrefresh(&boe_th101mb31ig002_default_mode)); + desc_mode->hdisplay, desc_mode->vdisplay, + drm_mode_vrefresh(desc_mode)); return -ENOMEM; } =20 --=20 2.17.1 From nobody Mon Sep 16 19:37:49 2024 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC37F14036E for ; Tue, 23 Jul 2024 06:26:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721715997; cv=none; b=k0Acp5VOZb5G5C9JYZ8C3GP2nKoO2342NmUE0Hl0+qzJDXpT6C2J8r17ixLBZoGjuj8uvAhzGp4UTuNSS5k3W0NkgQdOm7/WAoLgniHoIoGOzE3Y6gkXZ+ZG08AEBhh6i8gRzdOLBGXUQDLtY4QFHzjsAAyMJHbYF8l/n5WDK4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721715997; c=relaxed/simple; bh=IOlFdcG+Qc+uHnT45i1vLJl0/ZkiTyUuqIT6O9QcgxM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=mWnBNLPC1gDsYiOFIJ1ObFz7ND0T2umtAQCC2ztkFMj1ZtmVf1s4m2aC80XLrKUAVkh7ZvI3ZZiU6bqFH7EIP/SBvQky9iHeurlY1MnF8KN2Q2P/aGcY8C0VvbNH3r3yPOLZt7pAr3vqJ+amyKpnq5EhOkXfeGS/kGNRflfZv3I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=huaqin.corp-partner.google.com; spf=pass smtp.mailfrom=huaqin.corp-partner.google.com; dkim=pass (2048-bit key) header.d=huaqin-corp-partner-google-com.20230601.gappssmtp.com header.i=@huaqin-corp-partner-google-com.20230601.gappssmtp.com header.b=BS71e/hR; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=huaqin.corp-partner.google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaqin.corp-partner.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=huaqin-corp-partner-google-com.20230601.gappssmtp.com header.i=@huaqin-corp-partner-google-com.20230601.gappssmtp.com header.b="BS71e/hR" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1fd9e6189d5so12773515ad.3 for ; Mon, 22 Jul 2024 23:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=huaqin-corp-partner-google-com.20230601.gappssmtp.com; s=20230601; t=1721715995; x=1722320795; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=a4U/lX5wwRXFBYNa5qyfaellagLlJY0UfTFYRgdibjk=; b=BS71e/hRiXrVMwNqWpo/3z/NzDEWuPu202a+NbPrCqcZyNR6Edk9Mp+N9TvFFlAGeZ CkArcuvLQPhDQ6m1my2qX9HERfjqPYQ5kr7UWFPlZZ7BV0bYIzATCmkFCfAq7T+RT0xW bangmuH6pBJ9HsSs5BOYXXQ4SlPyPlqen6QRHIg/iZOi3xPSNz0ZMI1fn/fN/rhcyAe4 OHUimvMy3As5FBVg5+/eyqwHeDmoEjewTDQKAqdKBvk/ITnn82trPR4jUpQDAXjRHtAx T/UYp0kUJB05WxBduMWsv+7hSenrTOUaNhWqP8VJRmC0ecdqtPtjN+8COmXkJGy5PXpp 9fwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721715995; x=1722320795; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a4U/lX5wwRXFBYNa5qyfaellagLlJY0UfTFYRgdibjk=; b=GpczT+ZJs3YbJUGhv7HLe3sdSQxq7P4dCzpX0437mAG5m+guV/63VzqGH4yYaI2xtQ Hk5bq6NVidplUfpVC9w085impdtjo82u480ZX5nCeUoZIIYPI8kKkMO14i762HmaN8Yu Ovj3qWpeFVYLqXpmqnArvcrPC18DMmh5rxB/ZPvAdrcQXoBd5H5Qi/cjV0MYoF+qV55z 6imm7JEiJjQBJ6NPiX+TkQMGiR09kSzssSiW/q/6HXDCjN9t7sBAep55RiwcgX4VVLmP oqgeYP22KHTbnw/aZPw6omiq3wQhTS096OOv7Xtd9lAMX1ynOImoEAeMzrjWBaGw9tP7 5K6Q== X-Forwarded-Encrypted: i=1; AJvYcCXhmdcUUjMe04s3q0K1QVqxAF6MT97LzWIYS0RgEp/Sq6WLTi0wGC2bZL2L8J8KPRCN5PSecEOidXugR2ohQxv16+zosS6qBU3PhhE3 X-Gm-Message-State: AOJu0YwO1SoKujvthbryDCwbwvvfLwAiiQeymXrckYQlnlY1f4Zv8fEf zQeRueEg/93GOokJhnEvuFKHai5xt6U5XRNWM6Kv76/si8sE9PxgRUeeONet4cw= X-Google-Smtp-Source: AGHT+IHVekg2SGD27MeBu8a61N2QblO1dxpPiH7hnQpFqY1dwa+oz13T7HNCePcM1CZMQrcn7ELDFg== X-Received: by 2002:a17:903:2306:b0:1fd:69d6:856d with SMTP id d9443c01a7336-1fd74598718mr72102175ad.17.1721715995165; Mon, 22 Jul 2024 23:26:35 -0700 (PDT) Received: from lvzhaoxiong-KLVC-WXX9.huaqin.com ([116.66.212.162]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fd6f25ab47sm66351465ad.45.2024.07.22.23.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jul 2024 23:26:34 -0700 (PDT) From: Zhaoxiong Lv To: neil.armstrong@linaro.org, quic_jesszhan@quicinc.com, sam@ravnborg.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, dianders@chromium.org, hsinyi@google.com, awarnecke002@hotmail.com, dmitry.baryshkov@linaro.org Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Zhaoxiong Lv Subject: [PATCH v4 2/2] drm/panel: boe-th101mb31ig002 : using drm_connector_helper_get_modes_fixed() Date: Tue, 23 Jul 2024 14:26:15 +0800 Message-Id: <20240723062615.14796-3-lvzhaoxiong@huaqin.corp-partner.google.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240723062615.14796-1-lvzhaoxiong@huaqin.corp-partner.google.com> References: <20240723062615.14796-1-lvzhaoxiong@huaqin.corp-partner.google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Use public functions( drm_connector_helper_get_modes_fixed()) to get porch parameters. Signed-off-by: Zhaoxiong Lv Reviewed-by: Douglas Anderson --- Changes between V4 and V3: - 1.Modify the return value, return drm_connector_helper_get_modes_fixed(c= onnector, desc_mode). v3: https://lore.kernel.org/all/20240722092428.24499-3-lvzhaoxiong@huaqin.c= orp-partner.google.com/ Changes between V3 and V2: - 1. Keep bpc settings and drm_connector_set_panel_orientation() function.. v2: https://lore.kernel.org/all/20240716121112.14435-3-lvzhaoxiong@huaqin.c= orp-partner.google.com/ --- .../drm/panel/panel-boe-th101mb31ig002-28a.c | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c b/drivers= /gpu/drm/panel/panel-boe-th101mb31ig002-28a.c index d4e4abd103bb..0b87f1e6ecae 100644 --- a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c +++ b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c @@ -16,6 +16,7 @@ #include #include #include +#include =20 struct boe_th101mb31ig002; =20 @@ -313,31 +314,15 @@ static int boe_th101mb31ig002_get_modes(struct drm_pa= nel *panel, struct boe_th101mb31ig002, panel); const struct drm_display_mode *desc_mode =3D ctx->desc->modes; - struct drm_display_mode *mode; - - mode =3D drm_mode_duplicate(connector->dev, desc_mode); - if (!mode) { - dev_err(panel->dev, "Failed to add mode %ux%u@%u\n", - desc_mode->hdisplay, desc_mode->vdisplay, - drm_mode_vrefresh(desc_mode)); - return -ENOMEM; - } - - drm_mode_set_name(mode); =20 connector->display_info.bpc =3D 8; - connector->display_info.width_mm =3D mode->width_mm; - connector->display_info.height_mm =3D mode->height_mm; - /* * TODO: Remove once all drm drivers call * drm_connector_set_orientation_from_panel() */ drm_connector_set_panel_orientation(connector, ctx->orientation); =20 - drm_mode_probed_add(connector, mode); - - return 1; + return drm_connector_helper_get_modes_fixed(connector, desc_mode); } =20 static enum drm_panel_orientation --=20 2.17.1