From nobody Tue Dec 16 17:55:57 2025 Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8F4413F458 for ; Fri, 19 Jul 2024 13:42:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721396576; cv=none; b=iCebo7GEdbr/lQPbnmn9+vokFbYZW0OgWzBicBgRNMCwp/zPNJsssEiPH+kD2/VMLZyyNyfsZXh2oVi4BsnhWdGl44QkwjG0+3PcmjPJUnmr0HzBb7X2quX+vqZFRSiKC0bxWC000EGzTK01CVoRja9BLOFfjJ93BlCMmMONXoE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721396576; c=relaxed/simple; bh=OObjBT5+tmi8SJwD/vGEg0LnoSk/hpHy9nJZqdaQsvM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=nV5fwTgxd0BOy6mKHHCT+MkSi4XBshuJXxnHFDQi8ocEycDdI7opz5FCK16Y7rVUCb/n/QupTnSehdlCH1cpOMFiKXIW1D/pbj/wlXBX444UBhmmAbFnQl6/m0NwQO5O4KCMWNdVsbipmd4uY/Z4fSfTd4blaZ0PNEZDxo5p1Rc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=katqSECl; arc=none smtp.client-ip=209.85.160.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="katqSECl" Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-260e5b2dfb5so1075847fac.3 for ; Fri, 19 Jul 2024 06:42:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721396574; x=1722001374; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6zxRHXX1Q8OwMxEpYD1fuoDQoSBRUnmedwW5/qepIyg=; b=katqSEClNIYlnTIRHm7sdp859uGyzunL0Xk06UYblNyzq40EnSXhFkK2BQtziulcFQ GnksgOQZ1hzDEF5lSKdSe2Jm9WgyMNQKbk8+HwbLK9yIKUqdKytgHSbYFHQwX/JraxZJ 1dOWE/HQrGdlNjqa/z+aQAR11RA7ym4zMGgVBmVinbnb+ZtSZaoaZf1uin8XgpoAgjTu johMrUWct23ZKd67sYqdX5ssZTX5FSiZLNU2E56yamIzbeXS+/YL8mgholDLWt2DelGl Dc7RA0d73rSod873Lvtiorti+JuRkP+wroT6am0oow8jXa/sdSaRkF5Q1pdpMrZVsu1J 9CFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721396574; x=1722001374; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6zxRHXX1Q8OwMxEpYD1fuoDQoSBRUnmedwW5/qepIyg=; b=OFrtV79Qih0CrLEPxM/c8EGh04zziTd7vBYiaXTc7W4Y/Akr9NGlYKyxcmSSMjjp18 JHTxAxcQ3fRbG33MfPEarLN1sx7b1c+MB0XMjoNbd1QlpqcjvWWa+A5AXnjkafW1VF21 7b2E5x6i2LKia6yKoDdaLwm5hY5RCVSoFCID5OXeH6/Fu81tzCoVWpUNYjOS9UG84+2V KfZnHAIhb28sIcoebo7U945julmAWL2wajfT1os32O5lXFPAOyenYgzMALVmP+jwhEmP 33NW4g219uIXVQ9fF8mo4wfuhkk/n5pa4uEX7AygoapIOkprAJuAyGbxzBUH8nGeqxSE 0rLg== X-Forwarded-Encrypted: i=1; AJvYcCVGs4N9GS3Dn7fe1W/6cVs1Eh2eNJ38CFsdjlzCiLYmVii2HeFX6oCFsuIEpPB+SnHGGRNk4rGV/5A/muXE24Rtq52+veK5FvM3g+Qm X-Gm-Message-State: AOJu0YxAefDxS33qCC4g2uyYoglbV3gSubfwuRkPf6IIFMIZTzuYG4yl eY3/VzR43mOG2obxY6FiQnhRSrDq5gM8LZEV+p7iVGwDcmCPFtlxNxHPd4BAeg== X-Google-Smtp-Source: AGHT+IF797ziqOa4665rJuAHn4nLvwBl+NHT4V9kt7EP7l5a0fsyXgWUeyDot8Xa9UiXgvgE7Xem3w== X-Received: by 2002:a05:6870:8998:b0:261:164d:6854 with SMTP id 586e51a60fabf-261164dbbe6mr817994fac.54.1721396573901; Fri, 19 Jul 2024 06:42:53 -0700 (PDT) Received: from localhost.localdomain ([120.60.142.236]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70cff491088sm1190212b3a.41.2024.07.19.06.42.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jul 2024 06:42:53 -0700 (PDT) From: Manivannan Sadhasivam To: andersson@kernel.org, mturquette@baylibre.com, sboyd@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , stable@vger.kernel.org Subject: [PATCH] clk: qcom: gcc-sm8250: Do not turn off PCIe GDSCs during gdsc_disable() Date: Fri, 19 Jul 2024 19:12:38 +0530 Message-Id: <20240719134238.312191-1-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This can happen during scenarios such as system suspend and breaks the resume of PCIe controllers from suspend. So use PWRSTS_RET_ON to indicate the GDSC driver to not turn off the GDSCs during gdsc_disable() and allow the hardware to transition the GDSCs to retention when the parent domain enters low power state during system suspend. Cc: stable@vger.kernel.org # 5.7 Fixes: 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver fo= r SM8250") Signed-off-by: Manivannan Sadhasivam --- drivers/clk/qcom/gcc-sm8250.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8250.c b/drivers/clk/qcom/gcc-sm8250.c index 991cd8b8d597..1c59d70e0f96 100644 --- a/drivers/clk/qcom/gcc-sm8250.c +++ b/drivers/clk/qcom/gcc-sm8250.c @@ -3226,7 +3226,7 @@ static struct gdsc pcie_0_gdsc =3D { .pd =3D { .name =3D "pcie_0_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, }; =20 static struct gdsc pcie_1_gdsc =3D { @@ -3234,7 +3234,7 @@ static struct gdsc pcie_1_gdsc =3D { .pd =3D { .name =3D "pcie_1_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, }; =20 static struct gdsc pcie_2_gdsc =3D { @@ -3242,7 +3242,7 @@ static struct gdsc pcie_2_gdsc =3D { .pd =3D { .name =3D "pcie_2_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, }; =20 static struct gdsc ufs_card_gdsc =3D { --=20 2.25.1