From nobody Thu Sep 19 23:20:45 2024 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2B9617E902 for ; Wed, 17 Jul 2024 11:59:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721217567; cv=none; b=q4f7v/s82iaMZHHmlfUZ+07nybhwLuebk+pEVGkyUzz8H/KlMCkSkXe0Bji/kB0fcN1IeS7WDhgP/myOOVlJrz1KBqWJY+RiDEBYJqFv02/knR6capHoUz6ES6DA+LDvVLeJAG7S7WN/V8mIOHozKBrR3pa/wacHD63OVnqfcB0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721217567; c=relaxed/simple; bh=KH1+6eSbxrB1U64vYzIFihUaz/eu4frVte02WfURPuQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AEss3llm+ii33QATG+/UUtp6yNI4rw4O8Kk9iQ2vIkEiSOFQH0w5MNdciALZnl21NNgGCqkO5xlr9eeJ9bd3D/yPgmTG7+8TfJxO4PLGljfpptadzCdgEpreTKKWDzXB9XWuXiOiw/5qwNdLD2vsmwGxzWb2E2UUtVfC4fmhNgQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=JhLI8e9e; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="JhLI8e9e" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2c95ca60719so4455738a91.3 for ; Wed, 17 Jul 2024 04:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1721217565; x=1721822365; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kcTlzdSbCPYBa7vAri6YqB9ZoXDHn//E8DaLgVTWQzY=; b=JhLI8e9emxYmzJRT/L5LOOMg+NVG9WDV2UPKhn5eID0f0GCPilxt5awOgwG7xIYvD6 UbEONuCF4AEaI9yZfNs7A57eULJR5sLncCR2EDWlMLGtxFKzB5E762YPLFiY11e0DC0t 45rIGPA4rkcgDxA6LeR2SgPnPwYolJ9/t5yVQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721217565; x=1721822365; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kcTlzdSbCPYBa7vAri6YqB9ZoXDHn//E8DaLgVTWQzY=; b=EcEo8OseHH6bhk1L/G0YkUdipUt1dSo3UUvS5wZ5tobhe2SYILrk+ywTZ5qWVR27cl rnXuNWLDXqANpY4sWAzW6SlweMcDhJoTZYRU601jBgXywEWOR4gSMd0yz3l+51f8PMHB aVlNsdXnf8FDVgtxxqYjFMZYViEt69wZlx8jReqN2TX6q/4rZZ2gSJPIksn4+5XdaTLX kGNxG8FvrraRbhl6JHX64fdwFtUaqHYuNO4B0MCtoExNdbvEd2hM0IiwO1RC/MKp1CAC kkIOfqCNjvCkAZMFqJoeDGZ94we9wA8Gi3cN338lTzSh/uVL4S8LS72M6sbV2wfE7NPd h5GA== X-Forwarded-Encrypted: i=1; AJvYcCU6C0CPEbSU8ZybdSK2Yx4tEghF/rDlSM1J7t6pUIppi1q31hvopszbXTZ5PeF0Jdx7IajvGlLnAiTkn8lTr6c65FIimrM4yPlgSz4Q X-Gm-Message-State: AOJu0YxqKzfB6/vwyhaAlBZB/kfanSkSOpMDmLXisd1VcmQ3IG0aQnUu BVYjxqt2/m2CvWtWEYrfbFv5VIS9C3LbeaOtmLIaakzipa+i5D93AH24Qdgarw== X-Google-Smtp-Source: AGHT+IE8xpZ5IZDUMHdNrgUQW2/WR8g1HkPeRhtTiLALcp2Xt/UQv21YSG9GEN31UQfbsAOI8lOinw== X-Received: by 2002:a17:90a:c7d1:b0:2cb:5654:8367 with SMTP id 98e67ed59e1d1-2cb56548442mr722546a91.26.1721217565184; Wed, 17 Jul 2024 04:59:25 -0700 (PDT) Received: from fshao-p620.tpe.corp.google.com ([2401:fa00:1:10:97dd:ecf:8796:54cd]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cacd41a01asm10006858a91.32.2024.07.17.04.59.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jul 2024 04:59:24 -0700 (PDT) From: Fei Shao To: AngeloGioacchino Del Regno , Stephen Boyd Cc: Fei Shao , Matthias Brugger , Michael Turquette , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH] clk: mediatek: reset: Return regmap's error code Date: Wed, 17 Jul 2024 19:58:52 +0800 Message-ID: <20240717115919.975474-1-fshao@chromium.org> X-Mailer: git-send-email 2.45.2.993.g49e7a77208-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" device_node_to_regmap() can return different errors, and it's better practice to pass them to callers. Clean up the hardcoded -EINVAL and use PTR_ERR(regmap) instead. Signed-off-by: Fei Shao Reviewed-by: AngeloGioacchino Del Regno --- drivers/clk/mediatek/reset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/mediatek/reset.c b/drivers/clk/mediatek/reset.c index 290ceda84ce4..f8c0fd031512 100644 --- a/drivers/clk/mediatek/reset.c +++ b/drivers/clk/mediatek/reset.c @@ -138,7 +138,7 @@ int mtk_register_reset_controller(struct device_node *n= p, regmap =3D device_node_to_regmap(np); if (IS_ERR(regmap)) { pr_err("Cannot find regmap for %pOF: %pe\n", np, regmap); - return -EINVAL; + return PTR_ERR(regmap); } =20 data =3D kzalloc(sizeof(*data), GFP_KERNEL); @@ -198,7 +198,7 @@ int mtk_register_reset_controller_with_dev(struct devic= e *dev, regmap =3D device_node_to_regmap(np); if (IS_ERR(regmap)) { dev_err(dev, "Cannot find regmap %pe\n", regmap); - return -EINVAL; + return PTR_ERR(regmap); } =20 data =3D devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); --=20 2.45.2.993.g49e7a77208-goog