From nobody Thu Dec 18 08:32:39 2025 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.5]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6C03140BE3 for ; Wed, 17 Jul 2024 09:16:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721207788; cv=none; b=Gc+2wWqOcvsnFTArCTAqppqWCobhrvz+N/nnmTasQfFLLJybxoAvv60lJT3UMzW9RQIznKM/B3mhhN/j1RFv29C2kw4mXO/B1+7LJV2u4sopm7p0F1KYkRXL2TsRX0sP155AE/CvA5XmO3YrFetGJzTEbm+VLXxP4Vf++EhkWfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721207788; c=relaxed/simple; bh=QlYBRFMkqeKj1SrbXGYvXAXZvHVAXeV35XnaMgCh+30=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SJgbUxU5DGGbEjF+QntBRCv6/0NKfaoRzAA9FIAQNWPT87xRILLJP6cuqFrFZPWtJykE0oZLP5Ed0x7amG9O8eV725u31k5iNVUB6b4YNWRYFhRnjebmgmbyVJGEUoeyaaOrj6rQuYvswNzgM6tsOurnpIrvhiSa1TwdjLYpNnc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=jmk9kOWT; arc=none smtp.client-ip=220.197.31.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="jmk9kOWT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=iDA8D efekoXWbxjlJxep/Z5r+jMeXIenya8RpdthsfM=; b=jmk9kOWTKOK9LVWQ6WiXA j17WmzLmQMyw5ryF8r+tjkHLsiVid7GfLByd5uXIeTLRvfEs0e8jN4UoGfZhVNjs 2vISev/5RcYdrl1K0U5Y3yCczWu4p6azuroBBsahgmHl56za+8vc+82ZcUhQnlq7 wCRQk0xeQOgUKBECid9BME= Received: from localhost.localdomain (unknown [223.166.237.119]) by gzga-smtp-mta-g2-1 (Coremail) with SMTP id _____wD3Py3Ki5dmGNFmDQ--.41698S3; Wed, 17 Jul 2024 17:16:00 +0800 (CST) From: Ping Gan To: hare@suse.de, sagi@grimberg.me, hch@lst.de, kch@nvidia.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Cc: ping.gan@dell.com, Ping Gan Subject: [PATCH v2 1/2] nvmet-tcp: add unbound_wq support for nvmet-tcp Date: Wed, 17 Jul 2024 17:14:50 +0800 Message-Id: <20240717091451.111158-2-jacky_gam_2001@163.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20240717091451.111158-1-jacky_gam_2001@163.com> References: <20240717091451.111158-1-jacky_gam_2001@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wD3Py3Ki5dmGNFmDQ--.41698S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7Cry3uw15urW8Ar1UJw1fJFb_yoW8GFy8pa n3tF15Jr43J3yDKa1rCr4DXrWrCa17Cr9rua1xGw45Ar10qFZ5AFyqqF1Y9r47Cry8ZF12 kFyDZr1UWF1Yy37anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zinYFJUUUUU= X-CM-SenderInfo: 5mdfy55bjdzsisqqiqqrwthudrp/1tbiKBMfKWXAmTj9MQAAsF Content-Type: text/plain; charset="utf-8" To define a module parameter use_unbound_wq to enable unbound workqueue to handle TCP's IO. Signed-off-by: Ping Gan Reviewed-by: Hannes Reinecke Reviewed-by: Sagi Grimberg --- drivers/nvme/target/tcp.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c index 5bff0d5464d1..f71d56843e1a 100644 --- a/drivers/nvme/target/tcp.c +++ b/drivers/nvme/target/tcp.c @@ -73,6 +73,10 @@ device_param_cb(idle_poll_period_usecs, &set_param_ops, MODULE_PARM_DESC(idle_poll_period_usecs, "nvmet tcp io_work poll till idle time period in usecs: Default 0"); =20 +static bool use_unbound_wq; +module_param(use_unbound_wq, bool, 0444); +MODULE_PARM_DESC(use_unbound_wq, "use unbound workqueue to handle IO reque= st: Default false"); + #ifdef CONFIG_NVME_TARGET_TCP_TLS /* * TLS handshake timeout @@ -2196,9 +2200,13 @@ static const struct nvmet_fabrics_ops nvmet_tcp_ops = =3D { static int __init nvmet_tcp_init(void) { int ret; + unsigned int flags; + + flags =3D WQ_MEM_RECLAIM | WQ_HIGHPRI; + if (use_unbound_wq) + flags |=3D (WQ_UNBOUND | WQ_SYSFS); =20 - nvmet_tcp_wq =3D alloc_workqueue("nvmet_tcp_wq", - WQ_MEM_RECLAIM | WQ_HIGHPRI, 0); + nvmet_tcp_wq =3D alloc_workqueue("nvmet_tcp_wq", flags, 0); if (!nvmet_tcp_wq) return -ENOMEM; =20 --=20 2.26.2 From nobody Thu Dec 18 08:32:39 2025 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.5]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 59CC54437C for ; Wed, 17 Jul 2024 09:16:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721207791; cv=none; b=U1w5jtP9rp3NpFAHAklBmyCdM9jh6Gw1NJqnCCp7CZ0OMpRwNHDjF6DEllgmacqICQBJhQBjRc4ZV1M2nAGA7IcMYkNBpKTV35+Ff540IbBwGCv+FoUFvlXxuyCThanFdpjC0uYldaNu0Yfhhy9/WQWWK+6ARolLuWKiGvghdBI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721207791; c=relaxed/simple; bh=gyv+bR46tq6MKbMFNaXBytQqOl8y3S4hYh0EtUx32ZY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FbIffHbmzufj4PhZwsZr8pts81x4yf2rBWg6X6wh1ODgTYeJFpwGJpPydol9vwFSRfXS/0rV0TvpjgKfExuPFMYR8DGyF33t8rTXy1mYK2NckV+e78Tj+r3R+lPWApiGcdcJvNKEY1lYQyqNHgwzma/QHjpTGuz8paamOrAf1Zo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=dXPKbUMU; arc=none smtp.client-ip=117.135.210.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="dXPKbUMU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=e62nI TpAz+fELQO3Wpxu5xtovyKXRrI0UgadVew2J8g=; b=dXPKbUMUiCVOCRLDlbUhL JTkKGnwl6fN0EKLUKceZoZ3MaE6CYb4X3Kob0RczYUzD2Dg0HI06oE+DmBuwzf91 RPf5Ez0iaqoSIopLecFb09zJASaHzP7O02mtAPsb7vVCsAIuV8LoOlidyxEe40gq TuyMDX1n7uC+mGLNrSFgFA= Received: from localhost.localdomain (unknown [223.166.237.119]) by gzga-smtp-mta-g2-1 (Coremail) with SMTP id _____wD3Py3Ki5dmGNFmDQ--.41698S4; Wed, 17 Jul 2024 17:16:03 +0800 (CST) From: Ping Gan To: hare@suse.de, sagi@grimberg.me, hch@lst.de, kch@nvidia.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Cc: ping.gan@dell.com, Ping Gan Subject: [PATCH v2 2/2] nvmet-rdma: add unbound_wq support for nvmet-rdma Date: Wed, 17 Jul 2024 17:14:51 +0800 Message-Id: <20240717091451.111158-3-jacky_gam_2001@163.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20240717091451.111158-1-jacky_gam_2001@163.com> References: <20240717091451.111158-1-jacky_gam_2001@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wD3Py3Ki5dmGNFmDQ--.41698S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7CryfGFyUAr4UKFy8tF4Utwb_yoW8WrWDp3 93CF17Z397KrW2ya98KFsrXan3u3yfu3yUCas3t34jgFn5trZ3X3WDtry29rW8GF97Jr4x Ja1UXr4kZF4Y9wUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zirWrJUUUUU= X-CM-SenderInfo: 5mdfy55bjdzsisqqiqqrwthudrp/1tbiKBMfKWXAmTj9MwABsG Content-Type: text/plain; charset="utf-8" To define a module parameter use_unbound_wq to enable unbound workqueue to handle RDMA's IO of CQ. Signed-off-by: Ping Gan Reviewed-by: Hannes Reinecke Reviewed-by: Sagi Grimberg --- drivers/nvme/target/rdma.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c index 1eff8ca6a5f1..bfd7106316bc 100644 --- a/drivers/nvme/target/rdma.c +++ b/drivers/nvme/target/rdma.c @@ -155,6 +155,10 @@ static int nvmet_rdma_srq_size =3D 1024; module_param_cb(srq_size, &srq_size_ops, &nvmet_rdma_srq_size, 0644); MODULE_PARM_DESC(srq_size, "set Shared Receive Queue (SRQ) size, should >= =3D 256 (default: 1024)"); =20 +static bool use_unbound_wq; +module_param(use_unbound_wq, bool, 0444); +MODULE_PARM_DESC(use_unbound_wq, "use unbound workqueue to handle IO reque= st: Default false"); + static DEFINE_IDA(nvmet_rdma_queue_ida); static LIST_HEAD(nvmet_rdma_queue_list); static DEFINE_MUTEX(nvmet_rdma_queue_mutex); @@ -1259,7 +1263,11 @@ static int nvmet_rdma_create_queue_ib(struct nvmet_r= dma_queue *queue) */ nr_cqe =3D queue->recv_queue_size + 2 * queue->send_queue_size; =20 - queue->cq =3D ib_cq_pool_get(ndev->device, nr_cqe + 1, + if (use_unbound_wq) + queue->cq =3D ib_cq_pool_get(ndev->device, nr_cqe + 1, + queue->comp_vector, IB_POLL_UNBOUND_WORKQUEUE); + else + queue->cq =3D ib_cq_pool_get(ndev->device, nr_cqe + 1, queue->comp_vector, IB_POLL_WORKQUEUE); if (IS_ERR(queue->cq)) { ret =3D PTR_ERR(queue->cq); --=20 2.26.2