From nobody Thu Dec 18 08:32:10 2025 Received: from m15.mail.163.com (m15.mail.163.com [45.254.50.219]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B9B371CA80 for ; Wed, 17 Jul 2024 07:53:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.254.50.219 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721202817; cv=none; b=h7+kcAJj4RtcGSaS2o5eM5guEEAm3HvIneKfrNJzH3YjfEL9k1iBCMRiGVjCS29ScOmR10pCFYJOLeD4QAdITDAq2Tl0Edve+Uj+sjAgRNyavanBmk7QRyM2lL8Mw7My4WY2RjJHQKhtScer8LH2n972EgAdYe6UI/qGk0E7eyg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721202817; c=relaxed/simple; bh=8oyO9EzSTeS1mN1RBQpt2fmbrJfUKWkg3WXEAVWW8X8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cHhZHmuiD+t86jrCYmBfSZ5KuUdYTjwx7nIHtlyt0lh81/fz17uxujHvtpFfXIenEmJTHnXXy11L4L/fqcRut3xgE5UpkHvMbyiXgUx8JHlpGPokSpBXRGyC38bAPA6UQbkcHw+XZk1W/6LZHTBieKSKKwtb2jIpKIC1POH5Seo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=K25G2YbH; arc=none smtp.client-ip=45.254.50.219 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="K25G2YbH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=wQxVK OZRWZH4KWipiQnJFFf46L7FDmYSv688Dpn970w=; b=K25G2YbHuJS9M3WyLTE0V XJD8u0v6WMTYuT48wNm/EgbQqZMWYI2edYTZxtnbnEmC/M7asDbRhjjLciM4OGh9 AU6x81b1Eumfy+YWqn/aemAFebLikHU5SeRM8fmd6IFaHbg5Oh51/ollczPsqb4T 0Yxw2XAhJ8Hxi47UGZ+Kbw= Received: from localhost.localdomain (unknown [223.166.237.119]) by gzga-smtp-mta-g0-5 (Coremail) with SMTP id _____wD3f3ddeJdmTsbxAA--.36565S3; Wed, 17 Jul 2024 15:53:08 +0800 (CST) From: Ping Gan To: hare@suse.de, sagi@grimberg.me, hch@lst.de, kch@nvidia.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Cc: ping.gan@dell.com, Ping Gan Subject: [PATCH 1/2] nvmet-tcp: add unbound_wq support for nvmet-tcp Date: Wed, 17 Jul 2024 15:52:07 +0800 Message-Id: <20240717075208.87324-2-jacky_gam_2001@163.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20240717075208.87324-1-jacky_gam_2001@163.com> References: <20240717075208.87324-1-jacky_gam_2001@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wD3f3ddeJdmTsbxAA--.36565S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7Cry3uw15urW8Ar1UJw1fJFb_yoW8Gry3pa nxtF15Jr43J3yDKa1rCr4DXrWfCa17C3srua1xCw45Aw1FqFZ5AFyqqF1Y9r47ury8Zr12 kFyDZr1UWF1jy37anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zinYFJUUUUU= X-CM-SenderInfo: 5mdfy55bjdzsisqqiqqrwthudrp/1tbiSBgfKWXAmTHxfwADsm Content-Type: text/plain; charset="utf-8" To define a module parameter use_unbound_wq to enable unbound workqueue to handle TCP's IO. Signed-off-by: jackygam2001 Reviewed-by: Hannes Reinecke --- drivers/nvme/target/tcp.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c index 5bff0d5464d1..f71d56843e1a 100644 --- a/drivers/nvme/target/tcp.c +++ b/drivers/nvme/target/tcp.c @@ -73,6 +73,10 @@ device_param_cb(idle_poll_period_usecs, &set_param_ops, MODULE_PARM_DESC(idle_poll_period_usecs, "nvmet tcp io_work poll till idle time period in usecs: Default 0"); =20 +static bool use_unbound_wq; +module_param(use_unbound_wq, bool, 0444); +MODULE_PARM_DESC(use_unbound_wq, "use unbound workqueue to handle IO reque= st: Default false"); + #ifdef CONFIG_NVME_TARGET_TCP_TLS /* * TLS handshake timeout @@ -2196,9 +2200,13 @@ static const struct nvmet_fabrics_ops nvmet_tcp_ops = =3D { static int __init nvmet_tcp_init(void) { int ret; + unsigned int flags; + + flags =3D WQ_MEM_RECLAIM | WQ_HIGHPRI; + if (use_unbound_wq) + flags |=3D (WQ_UNBOUND | WQ_SYSFS); =20 - nvmet_tcp_wq =3D alloc_workqueue("nvmet_tcp_wq", - WQ_MEM_RECLAIM | WQ_HIGHPRI, 0); + nvmet_tcp_wq =3D alloc_workqueue("nvmet_tcp_wq", flags, 0); if (!nvmet_tcp_wq) return -ENOMEM; =20 --=20 2.26.2 From nobody Thu Dec 18 08:32:10 2025 Received: from m15.mail.163.com (m15.mail.163.com [45.254.50.219]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D693438389 for ; Wed, 17 Jul 2024 07:53:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.254.50.219 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721202825; cv=none; b=XIme7E1M8nnCbbTFiTEbHN76UoizbegtriyjFmbDBzQb2/ksXTLYwT3Jyz6czGUSRzItGds72v/RXRSQEU9on6fiPdmflBrdgLdebDnQ2ppFjN/Ee5LTqr0srE5LGg9laq1r0cRvYFiNzceYi8vLSxamk/IRq8z/3SPi1ZpSE7U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721202825; c=relaxed/simple; bh=zK8ruUH07JehWZxI02iwHZoWOCkCvMR3iGwU0ScuYPg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=vD8IZBsIl/1t7LmIQGMAph/sX4IGr2J6ze03Qq0K56dpIBuo0dif+hNNbrucCJnlHcWqYR9bGl2+UqIb8ry9EurwHhC7vOl6ytG1e5j6VPVCDid4uAwCQlv4IqE2xrOW3HOpy/bntLoHb9e9mzKJHNG85dMdQBYAHTWUq/QXP3A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=EMZOkiDj; arc=none smtp.client-ip=45.254.50.219 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="EMZOkiDj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=Mn+4O ScY3XRHK3/oW8fy9rYRq32M1Cn4hjrpDWV3OS4=; b=EMZOkiDjvI4cASb49uHnK E3PYiy/9fs7dix163PMbuAG+nu8ogaUxJoOZQyWgSA3nIADEZqczK01SQzF7NmcQ mQ58D9GHy82U7UMj2JAXlbAv28panIPCY68n51TehLMcWyde2iZbBt8didDlEWYX RRoMca36gnJzkmnqPi4hdU= Received: from localhost.localdomain (unknown [223.166.237.119]) by gzga-smtp-mta-g0-5 (Coremail) with SMTP id _____wD3f3ddeJdmTsbxAA--.36565S4; Wed, 17 Jul 2024 15:53:17 +0800 (CST) From: Ping Gan To: hare@suse.de, sagi@grimberg.me, hch@lst.de, kch@nvidia.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Cc: ping.gan@dell.com, Ping Gan Subject: [PATCH 2/2] nvmet-rdma: add unbound_wq support for nvmet-rdma Date: Wed, 17 Jul 2024 15:52:08 +0800 Message-Id: <20240717075208.87324-3-jacky_gam_2001@163.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20240717075208.87324-1-jacky_gam_2001@163.com> References: <20240717075208.87324-1-jacky_gam_2001@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wD3f3ddeJdmTsbxAA--.36565S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7CryDAw17XryruF45AFyDAwb_yoW8Wr1rp3 95CF17Z393KrW2ya98KF4DXan3u3yfuw4UCas3t34UWFnaqrZ3X3WDtry29rW8GF97Jr4x Ja1DXr4kuF45WwUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zirWrJUUUUU= X-CM-SenderInfo: 5mdfy55bjdzsisqqiqqrwthudrp/1tbiEA8fKWXAl+IiRAAAsf Content-Type: text/plain; charset="utf-8" To define a module parameter use_unbound_wq to enable unbound workqueue to handle RDMA's IO of CQ. Signed-off-by: jackygam2001 Reviewed-by: Hannes Reinecke --- drivers/nvme/target/rdma.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c index 1eff8ca6a5f1..bfd7106316bc 100644 --- a/drivers/nvme/target/rdma.c +++ b/drivers/nvme/target/rdma.c @@ -155,6 +155,10 @@ static int nvmet_rdma_srq_size =3D 1024; module_param_cb(srq_size, &srq_size_ops, &nvmet_rdma_srq_size, 0644); MODULE_PARM_DESC(srq_size, "set Shared Receive Queue (SRQ) size, should >= =3D 256 (default: 1024)"); =20 +static bool use_unbound_wq; +module_param(use_unbound_wq, bool, 0444); +MODULE_PARM_DESC(use_unbound_wq, "use unbound workqueue to handle IO reque= st: Default false"); + static DEFINE_IDA(nvmet_rdma_queue_ida); static LIST_HEAD(nvmet_rdma_queue_list); static DEFINE_MUTEX(nvmet_rdma_queue_mutex); @@ -1259,7 +1263,11 @@ static int nvmet_rdma_create_queue_ib(struct nvmet_r= dma_queue *queue) */ nr_cqe =3D queue->recv_queue_size + 2 * queue->send_queue_size; =20 - queue->cq =3D ib_cq_pool_get(ndev->device, nr_cqe + 1, + if (use_unbound_wq) + queue->cq =3D ib_cq_pool_get(ndev->device, nr_cqe + 1, + queue->comp_vector, IB_POLL_UNBOUND_WORKQUEUE); + else + queue->cq =3D ib_cq_pool_get(ndev->device, nr_cqe + 1, queue->comp_vector, IB_POLL_WORKQUEUE); if (IS_ERR(queue->cq)) { ret =3D PTR_ERR(queue->cq); --=20 2.26.2