From nobody Wed Dec 17 17:28:13 2025 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57113195FD1; Tue, 16 Jul 2024 11:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721129876; cv=none; b=LXywtKTOK5f1w/ejvH4lNgJiZ27TDtYj8K7pLUd6u1ttlMEG+PaLeEiYsniCZE92flp6s25OySoFW3/KDaiUX8EUFZKw5THVxG0OrnfdTyfn+9tPtkK7mL/TsdTjDus+Qfi1E7n6a/bCE4NW0jvZsQ3tePFrfiY27eFA8A5XGHw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721129876; c=relaxed/simple; bh=t7aaLQUyfDA+p5vRSl1NJUfN0pLTnLyMeltQG2AN4vY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UjuOP9iaoxRUjNx3wN7MOe900Rqs934etDis6JjAEACJ/8rvIRUXpeeDBKQM/i2O9Z0xsSvBJiHoy/93w8pDk7guKQPCZVrh5AqN1v7Urooiqz/rPo23ZavTENfzG9sl9ym4lq10ULedQcjO8PQVcALhgSde2whsTagwcRnedrE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=rMa4drYb; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="rMa4drYb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1721129874; x=1752665874; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=t7aaLQUyfDA+p5vRSl1NJUfN0pLTnLyMeltQG2AN4vY=; b=rMa4drYbiD9m5+5RI3F9mOInBY4m4i/k3NLjHIUbohtFLCepxz14Z9Pv KzNUohLWlpialAlItmB8znsRQEykirN2GOFzpmCy013g9iZb48bhtGmfC 1w1avivZZ8c6GdgYREnJ/DWVn81p+net9Wc8n0V0UKZIXFjoNeQhM4i8S ALOcax57ovRHn+jvyYHiH1aPnsfeLkyCSXPLv46K+dH7j7Tlvnsk7tQRd PRp97N3b5/hX1UgaIgWsGIOJKcss2Vpmbp1orKu0Es5KE0gqkzKrgDTPp TazlMcbaGc/mnTBIYxWSVgJk4rQ0Kypt1m8RxC5LZIyYBgypK8RxgjI/E w==; X-CSE-ConnectionGUID: cfaeIL7IRUGLMl9e3xGUlQ== X-CSE-MsgGUID: fQYrUahfRP2If+8ifDi5JQ== X-IronPort-AV: E=Sophos;i="6.09,211,1716274800"; d="scan'208";a="32002840" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Jul 2024 04:37:53 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 16 Jul 2024 04:37:25 -0700 Received: from HYD-DK-UNGSW21.microchip.com (10.10.85.11) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Tue, 16 Jul 2024 04:37:21 -0700 From: Raju Lakkaraju To: CC: , , , , , , , , , , , , Subject: [PATCH net-next V2 2/4] net: lan743x: Create separate Link Speed Duplex state function Date: Tue, 16 Jul 2024 17:03:47 +0530 Message-ID: <20240716113349.25527-3-Raju.Lakkaraju@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240716113349.25527-1-Raju.Lakkaraju@microchip.com> References: <20240716113349.25527-1-Raju.Lakkaraju@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Create separate Link Speed Duplex (LSD) update state function from lan743x_sgmii_config () to use as subroutine. Signed-off-by: Raju Lakkaraju Reviewed-by: Andrew Lunn --- Change List: = =20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D = =20 V1 -> V2: = =20 - No changes = =20 =20 drivers/net/ethernet/microchip/lan743x_main.c | 75 +++++++++++-------- 1 file changed, 45 insertions(+), 30 deletions(-) diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/et= hernet/microchip/lan743x_main.c index ce1e104adc20..b4a4c2840a83 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.c +++ b/drivers/net/ethernet/microchip/lan743x_main.c @@ -992,6 +992,42 @@ static int lan743x_sgmii_write(struct lan743x_adapter = *adapter, return ret; } =20 +static int lan743x_get_lsd(int speed, int duplex, u8 mss) +{ + int lsd; + + switch (speed) { + case SPEED_2500: + if (mss =3D=3D MASTER_SLAVE_STATE_SLAVE) + lsd =3D LINK_2500_SLAVE; + else + lsd =3D LINK_2500_MASTER; + break; + case SPEED_1000: + if (mss =3D=3D MASTER_SLAVE_STATE_SLAVE) + lsd =3D LINK_1000_SLAVE; + else + lsd =3D LINK_1000_MASTER; + break; + case SPEED_100: + if (duplex =3D=3D DUPLEX_FULL) + lsd =3D LINK_100FD; + else + lsd =3D LINK_100HD; + break; + case SPEED_10: + if (duplex =3D=3D DUPLEX_FULL) + lsd =3D LINK_10FD; + else + lsd =3D LINK_10HD; + break; + default: + lsd =3D -EINVAL; + } + + return lsd; +} + static int lan743x_sgmii_mpll_set(struct lan743x_adapter *adapter, u16 baud) { @@ -1179,42 +1215,21 @@ static int lan743x_sgmii_config(struct lan743x_adap= ter *adapter) { struct net_device *netdev =3D adapter->netdev; struct phy_device *phydev =3D netdev->phydev; - enum lan743x_sgmii_lsd lsd =3D POWER_DOWN; bool status; int ret; =20 - switch (phydev->speed) { - case SPEED_2500: - if (phydev->master_slave_state =3D=3D MASTER_SLAVE_STATE_MASTER) - lsd =3D LINK_2500_MASTER; - else - lsd =3D LINK_2500_SLAVE; - break; - case SPEED_1000: - if (phydev->master_slave_state =3D=3D MASTER_SLAVE_STATE_MASTER) - lsd =3D LINK_1000_MASTER; - else - lsd =3D LINK_1000_SLAVE; - break; - case SPEED_100: - if (phydev->duplex) - lsd =3D LINK_100FD; - else - lsd =3D LINK_100HD; - break; - case SPEED_10: - if (phydev->duplex) - lsd =3D LINK_10FD; - else - lsd =3D LINK_10HD; - break; - default: + ret =3D lan743x_get_lsd(phydev->speed, phydev->duplex, + phydev->master_slave_state); + if (ret < 0) { netif_err(adapter, drv, adapter->netdev, - "Invalid speed %d\n", phydev->speed); - return -EINVAL; + "error %d link-speed-duplex(LSD) invalid\n", ret); + return ret; } =20 - adapter->sgmii_lsd =3D lsd; + adapter->sgmii_lsd =3D ret; + netif_dbg(adapter, drv, adapter->netdev, + "Link Speed Duplex (lsd) : 0x%X\n", adapter->sgmii_lsd); + ret =3D lan743x_sgmii_aneg_update(adapter); if (ret < 0) { netif_err(adapter, drv, adapter->netdev, --=20 2.34.1