From nobody Wed Dec 17 13:51:37 2025 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2E4915E9B for ; Tue, 16 Jul 2024 02:58:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721098735; cv=none; b=teN7OFlFNbv++BFi+aKqkxLbk82jKBQQrvCtdtw/37tENg6GEDZw2JjyRiH1lnDRaXmZXrmswi38npAXlzfxkWWG7XlZqc2tj66DuoScVfQkOWelmTYV3TpCkH4QmbIvF21VLC38K06gHo5YqQg3ygmL5f+K2cMQZwk79pF2IR0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721098735; c=relaxed/simple; bh=x93ZBrrNvd/f8ZMmLO3v1L6XGSHURwuLBGCMZo4HrFc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=nShO7Oo637uT/bnDOKWeq/WM9+NPQ25UPtnW+okNMZ2Oz/hVxuJkap/cKmDjBoq94libZzXewHi9Wy6vmxApNAShPfK5gjDqK0sK4R8eBN2PVL8X1+SzQJ+z6nwuUDiaKdtY/4pmEiIdOacSumX/nU6+AfyxCGN/uJlANTSGd30= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=jlyZvg+1; arc=none smtp.client-ip=95.215.58.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="jlyZvg+1" X-Envelope-To: kent.overstreet@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1721098731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=osOBeiU2E0wMhfDJ/xZ4r4HlfwEbTbhRB9j7IQx7WZc=; b=jlyZvg+1EKgEB9S/BDbMCoURP/GAfE0wJkx0F8k3rtUf86MuNrD44D4Y4ZTuPxs8bp1WJM d1BS2gFQVAM2ZjpJisszszZ1/05+t5/OCHF7CchrMHygmHqNpuIGxfLiLYBBvo+ldXfZQX 4wQwy4263SCsc8VpFCwsh4Sn5EOxEVo= X-Envelope-To: youling.tang@linux.dev X-Envelope-To: zhengqi.arch@bytedance.com X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: linux-bcachefs@vger.kernel.org X-Envelope-To: tangyouling@kylinos.cn X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Youling Tang To: Kent Overstreet Cc: Youling Tang , Qi Zheng , linux-kernel@vger.kernel.org, linux-bcachefs@vger.kernel.org, Youling Tang Subject: [PATCH] bcachefs: allocate inode by using alloc_inode_sb() Date: Tue, 16 Jul 2024 10:58:16 +0800 Message-Id: <20240716025816.52156-1-youling.tang@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Youling Tang The inode allocation is supposed to use alloc_inode_sb(), so convert kmem_cache_alloc() to alloc_inode_sb(). It will also fix [1] to avoid the NULL pointer dereference BUG in list_lru_add() when CONFIG_MEMCG is enabled. Links: [1]: https://lore.kernel.org/all/20589721-46c0-4344-b2ef-6ab48bbe2ea5@linux= .dev/ [2]: https://lore.kernel.org/all/7db60e36-9c96-4938-a28d-a9745e287386@linux= .dev/ Fixes: 86d81ec5f5f0 ("bcachefs: Mark bch_inode_info as SLAB_ACCOUNT") Signed-off-by: Youling Tang --- fs/bcachefs/fs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c index f9c9a95d7d4c..34649ed2e3a1 100644 --- a/fs/bcachefs/fs.c +++ b/fs/bcachefs/fs.c @@ -227,7 +227,8 @@ static struct inode *bch2_alloc_inode(struct super_bloc= k *sb) =20 static struct bch_inode_info *__bch2_new_inode(struct bch_fs *c) { - struct bch_inode_info *inode =3D kmem_cache_alloc(bch2_inode_cache, GFP_N= OFS); + struct bch_inode_info *inode =3D alloc_inode_sb(c->vfs_sb, + bch2_inode_cache, GFP_NOFS); if (!inode) return NULL; =20 --=20 2.34.1