From nobody Mon Feb 9 10:28:43 2026 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 204B418E76C; Mon, 15 Jul 2024 13:38:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721050689; cv=none; b=TLuYFPWBy0YXfZglP5Jsvdp4tYcu+Wc/JA6kVJ3Yl4mYbjm1ZuVQgYNz8o3XWnzW3biGldnjA/0MNBmPyML5aXSYF0llW7oDw8EUBXW+orERNtmoVQgCtdnyBnqYZ2BFD9fBsSAL+ijiRP9TT/e7VtxZzNtYsx+HbCpw39B4eVI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721050689; c=relaxed/simple; bh=R71Ts9/VVk5ak3RZO/9IUeDblNdq16YOqaZOiN45D6g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PBQysigiA+AV3eFD4XkQer1hgEwVXOTidIBMcNZiVorYXaqqwIVjGiir1IQm9+FIipdlFQyvRPl5F/slzSpLoGyVE2sf6vhdZK8KsuCgthWgZ1VJ1eOo6odjum+mYgnUy2U5DN+i0BXGSlnnXiQ08qlFtQfgeID00QZHS/qXKrw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C897EDA7; Mon, 15 Jul 2024 06:38:32 -0700 (PDT) Received: from thinkcentre-m93p.cambridge.arm.com (thinkcentre-m93p.cambridge.arm.com [10.1.197.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9DE7F3F73F; Mon, 15 Jul 2024 06:38:06 -0700 (PDT) From: Luke Parkin To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, Luke Parkin Subject: [PATCH v3 2/5] firmware: arm_scmi: Add support for tracking statistics Date: Mon, 15 Jul 2024 14:37:48 +0100 Message-Id: <20240715133751.2877197-3-luke.parkin@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240715133751.2877197-1-luke.parkin@arm.com> References: <20240715133751.2877197-1-luke.parkin@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a new config option for statistic tracking in SCMI subsystem Add an array and enum for tracking statistics Add scmi_log_stats op/no-op function for incrementing statistics Signed-off-by: Luke Parkin --- v2->v3 Switch to an enum & array method of storing statistics v1->v2 Config option now depends on DEBUG_FS Add scmi_log_stats rather than if(IS_ENABLED) Move location of scmi_debug_stats in the scmi_info struct --- drivers/firmware/arm_scmi/Kconfig | 11 +++++++++++ drivers/firmware/arm_scmi/common.h | 9 +++++++++ drivers/firmware/arm_scmi/driver.c | 6 ++++++ 3 files changed, 26 insertions(+) diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/= Kconfig index aa5842be19b2..45e8e7df927e 100644 --- a/drivers/firmware/arm_scmi/Kconfig +++ b/drivers/firmware/arm_scmi/Kconfig @@ -55,6 +55,17 @@ config ARM_SCMI_RAW_MODE_SUPPORT_COEX operate normally, thing which could make an SCMI test suite using the SCMI Raw mode support unreliable. If unsure, say N. =20 +config ARM_SCMI_DEBUG_STATISTICS + bool "Enable SCMI Raw mode statistic tracking" + select ARM_SCMI_NEED_DEBUGFS + depends on DEBUG_FS + help + Enables statistic tracking for the SCMI subsystem. + + Enable this option to create a new debugfs directory which contains + several useful statistics on various SCMI features. This can be useful + for debugging and SCMI monitoring. If unsure, say N. + config ARM_SCMI_HAVE_TRANSPORT bool help diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi= /common.h index b5ac25dbc1ca..157df695aeb1 100644 --- a/drivers/firmware/arm_scmi/common.h +++ b/drivers/firmware/arm_scmi/common.h @@ -301,6 +301,15 @@ extern const struct scmi_desc scmi_optee_desc; =20 void scmi_rx_callback(struct scmi_chan_info *cinfo, u32 msg_hdr, void *pri= v); =20 +#ifdef CONFIG_ARM_SCMI_DEBUG_STATISTICS +static inline void scmi_log_stats(atomic_t *arr, int stat) +{ + atomic_inc(&arr[stat]); +} +#else +static inline void scmi_log_stats(atomic_t *arr, int stat) {} +#endif + enum scmi_bad_msg { MSG_UNEXPECTED =3D -1, MSG_INVALID =3D -2, diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi= /driver.c index 56a93d20bf23..6edec6ec912d 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -125,6 +125,10 @@ struct scmi_debug_info { bool is_atomic; }; =20 +enum debug_stat_counters { + LAST +}; + /** * struct scmi_info - Structure representing a SCMI instance * @@ -161,6 +165,7 @@ struct scmi_debug_info { * bus * @devreq_mtx: A mutex to serialize device creation for this SCMI instance * @dbg: A pointer to debugfs related data (if any) + * @dbg_stats: An array of atomic_c's used for tracking statistics (if ena= bled) * @raw: An opaque reference handle used by SCMI Raw mode. */ struct scmi_info { @@ -187,6 +192,7 @@ struct scmi_info { /* Serialize device creation process for this instance */ struct mutex devreq_mtx; struct scmi_debug_info *dbg; + atomic_t dbg_stats[LAST]; void *raw; }; =20 --=20 2.34.1