From nobody Wed Dec 17 10:45:58 2025 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4CF3188CDA for ; Mon, 15 Jul 2024 12:16:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721045769; cv=none; b=hDb0ko8Pf0QLhlN+AwcbqgC097zzbbTHg/nOQdpdRgeTinMpgOuKYVvw9Agf+ux1WCMhMp2sQDLOkWRH7tL73+BbBpnuXDW1ueiY+zIlyi3KYpPKFhI7FDDG+we3OzC1eCACEfhS1nQ8mfIMjNlQf9UgiEk9SoDOb9Jnqqs+y6s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721045769; c=relaxed/simple; bh=5xxCslBz39cd9KCBn386k+DYETh3rATBhqlskCXMh/4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Qq6HPQMQ0hWW3exScefiy24APlNcueffiZmkV9/IdtbaPAy0lrUEkSwfx1A2QqDfsOgCj/kCwDR+FSZx/h8ZZPrgDW0ZA3bksPf7OVr0SELzaQ0/mCLQ4z8Gp/SA4ke9IMyvMgfO4jRA6Fgnt9BzoPLbTe7UrwDjrSXjSnoSUMc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=udJEA3t/; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="udJEA3t/" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-367ab50a07aso2632075f8f.0 for ; Mon, 15 Jul 2024 05:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721045766; x=1721650566; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CwYPDTPYAwmjKmZ1/Gf11accW/fLFhZgeFXsYW2+ut4=; b=udJEA3t/couQkVT3Z443Rkb88vX0bp7H5bvfLt7NoCtVzWhv4+4GwoFn9+NkEz5JU7 JFtZdz5JtGNb0T6T+4FVYXMmyl1D4EORzAPlH/TxGVupStL/j+to8ngahPhaRI18nVp4 Bs5yeq5yUArHjT5vEErVj0TRW6n2cVOmOQ1DFRqmvuXzDICmxNbUdb9L3Dcy3EJLyJDx LjFGmHQ7e+yb2pxzc4j0exUDvDT7w4g6/prxg8zYKPr9PrP9Ro9n3UKb2wGWVVLIPwjC kaT5QNaSDapoK/TZWgnsWu8B9I7AmHLNbOPJCF95ymDofMx8KLjecoknNxIIWsGGWja+ J2Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721045766; x=1721650566; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CwYPDTPYAwmjKmZ1/Gf11accW/fLFhZgeFXsYW2+ut4=; b=g8mmg9WHm+xsiG1b6z8J/XHDkt6JTH0SMHdzb6XT1UtmsAhgK+VQcOAhv2mb/KxTlw q9R7giGd8IeuI7VpmDYBO8S56vbE9XQPuIgG6jcoNB92OnENJI6PRT5TaYIU0y84vEO4 1CExsIQF8CQWbsX+Z//CpceyQOOG4Yt9NxRk9c4H3B7U+686OnLzXIneCzpX7hv0nHMy 6asmSVB8nXiNemgW+5Tuo1kvsNGXfvdyJKixMdvrcJzU1u2RkmVp/9ETVAbk21P4zi2A T6uhZDkP1/4CT/V7jt5yni/pquw4fFV3ZU9TUnqBelk/7cqZe2k0snV6EfrBLm5+fXZp uJxw== X-Forwarded-Encrypted: i=1; AJvYcCV17T6L3IbDV9QVzwFRbHVX+u7SLs3mhT9qDSKmIR9qbwQShaj2zS6I5Kw0PPEmqsxOZUQMA/y6ZWOBmlxImSXlOqp5oCFFJ62BVR6S X-Gm-Message-State: AOJu0Yz1rPIge9brHEdMBqvGh0nUZGrTn2EOjjipEhd0fHr+iaikuTIx 0mODBQAL6jA9YQnucvz0jmzxbyCe9Mr4lC6JejrU8/8e4Hj4fMy4/mubCoAIdpg= X-Google-Smtp-Source: AGHT+IGqx28NbMNvmzLw5J0w/TQ3ZQHmxkK+h/DWdncxb76LIdC5qwbxWV7jVF8Ibsfqau3YeIjlGw== X-Received: by 2002:a5d:47c3:0:b0:367:8a3b:2098 with SMTP id ffacd0b85a97d-367cea46076mr15982239f8f.3.1721045765987; Mon, 15 Jul 2024 05:16:05 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:886b:1a3a:7569:3d95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680d9771aasm6369201f8f.0.2024.07.15.05.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 05:16:05 -0700 (PDT) From: Stephan Gerhold Date: Mon, 15 Jul 2024 14:15:37 +0200 Subject: [PATCH v2 1/4] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240715-x1e80100-crd-backlight-v2-1-31b7f2f658a3@linaro.org> References: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> In-Reply-To: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight control over the DP AUX channel. While it works almost correctly with the generic "edp-panel" compatible, the backlight needs special handling to work correctly. It is similar to the existing ATNA33XC20 panel, just with a larger resolution and size. Add a new "samsung,atna45af01" compatible to describe this panel in the DT. Use the existing "samsung,atna33xc20" as fallback compatible since existing drivers should work as-is, given that resolution and size are discoverable through the eDP link. Signed-off-by: Stephan Gerhold Acked-by: Conor Dooley Reviewed-by: Douglas Anderson Reviewed-by: Neil Armstrong --- .../devicetree/bindings/display/panel/samsung,atna33xc20.yaml | 8 ++++= +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/panel/samsung,atna33= xc20.yaml b/Documentation/devicetree/bindings/display/panel/samsung,atna33x= c20.yaml index 765ca155c83a..5192c93fbd67 100644 --- a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.ya= ml +++ b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.ya= ml @@ -14,7 +14,13 @@ allOf: =20 properties: compatible: - const: samsung,atna33xc20 + oneOf: + # Samsung 13.3" FHD (1920x1080 pixels) eDP AMOLED panel + - const: samsung,atna33xc20 + # Samsung 14.5" WQXGA+ (2880x1800 pixels) eDP AMOLED panel + - items: + - const: samsung,atna45af01 + - const: samsung,atna33xc20 =20 enable-gpios: true port: true --=20 2.44.1 From nobody Wed Dec 17 10:45:58 2025 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EF7E18A921 for ; Mon, 15 Jul 2024 12:16:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721045770; cv=none; b=pps4BboylkubazUSL+mP+8VoboqMc8qRCMm2qd6itfXjAmSQ/YdoBYtftsg0QTRWwuwK4eF5j03zcQ/z5mdecmPd4c6JLjj+5fvP10Z5noDsB5pDDApUAXqOxqzraOp4YO+D+amLmbbIG933kz0MZfVutn0DvMazwd2YbpYoPlQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721045770; c=relaxed/simple; bh=us5vFbV1oXrFQ1IRmJFjWmuvUJ7Mz2t9/i5d0K/nxWo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kfWvM4H8N7wFQUhg0yki70INi98x+fN7JY5Rt1ycZbiIuJ1IA6NqA3SxTnwV3QSaDLHC1M12MzVCFIrggRpMnk62OkNGM3Ki+gvoHkbLsUfOythva1EOmHTHODhH8DZSq3e9xqsPyBgFys8FxokCcnYvcoEg5U+quoHn0Od4SSA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kClym+ZD; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kClym+ZD" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4266b1f1b21so28062745e9.1 for ; Mon, 15 Jul 2024 05:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721045766; x=1721650566; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=C4zewyPEhlNFFIG7IewHHr+zZpf0Zw7H1PjOS7/qftA=; b=kClym+ZDk2qJRRmPpHLGp01d73dPEUrnBzUe10NhIWj1PTHpD2+JUj6L6o+aKXkdQI iTv9chTm18X1y4P5pc01TDu2dd/c4Uh5279v2RC2KMU0Bi9B73Q2rl9O2uSo5imMX0Uj kLMBjCMlFw6O0+pVs/ImgcYZvvk4enNMwtiX1R9Y/cD6pQCFaX0gR4UpuhHAZthbMV0n D7IiBvn+yjxSnli/aE+tZ8SyaoJ71HnF5/q6SyVaFVkkRZ6oGqZmwELHflfelsm+vM2D e3M74eaf95kDjspy01yQBLOUF7E9+77wT0Zm2fJiHlhbUZBztFoTbDwtGXx5PfBGspyO gtiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721045766; x=1721650566; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C4zewyPEhlNFFIG7IewHHr+zZpf0Zw7H1PjOS7/qftA=; b=KY2CZ5+Rr6nSRk9BFriQnLmeBdKA5jrhZpVSOLqHLpHUCiGZ7FcYJBFIf+tZjGL4bD Mw51DcEL83eatnv1s5JyBQdik/TjsuojlqUQGXUWkGl3JdLCHIhwSBiUSEAFUkEMGXuH 2vROX7shQemKyClurUCUUz9sN8Q1L3wpsX4Ts0HC0NsH4Rx5D27U14bvUH6QlB77BTXG 7vmIIFLbRdkfub/f1lk0tF+r/aXwu6ihaq4wHMQ7ZuVmiDquixdiPWofq1EIvTyxyxLp W7lkE6KZn1+ypOy5QE4xMZfd9thSCsDO055EIMZ+rKaF1qwVoOplvbUpXq7DIGoQHlFp cGbw== X-Forwarded-Encrypted: i=1; AJvYcCX41kYSBQNF/itBIAiJ9BGm46XSGqQz6u8XO0KmjFLuWsPs5RLI8eg7rEMWLtYpBtIcJA7/xnWfklSF82zSc58Y1Y/5U5z9wyp9nrhQ X-Gm-Message-State: AOJu0YwjXM7eTRhr89U7kGHBsz2oKZBHthB5YcADjemWmTppvCatmA/5 Jg9aF3Ht04ndZuKp9nWfKYj01hnXRb53kkeMLrankIqb+LctQcmtYZzRd/fdzfI= X-Google-Smtp-Source: AGHT+IE1hOML28f+XraJzEd8SFOSIj91LonNL45CkfZTFsChgS0t1o51jq4Yctj5be3mCBmPsTXBdQ== X-Received: by 2002:adf:ffcd:0:b0:367:9791:2939 with SMTP id ffacd0b85a97d-367cea6b804mr11785800f8f.21.1721045766633; Mon, 15 Jul 2024 05:16:06 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:886b:1a3a:7569:3d95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680d9771aasm6369201f8f.0.2024.07.15.05.16.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 05:16:06 -0700 (PDT) From: Stephan Gerhold Date: Mon, 15 Jul 2024 14:15:38 +0200 Subject: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240715-x1e80100-crd-backlight-v2-2-31b7f2f658a3@linaro.org> References: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> In-Reply-To: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. The panel should be handled through the samsung-atna33xc20 driver for correct power up timings. Otherwise the backlight does not work correctly. We have existing users of this panel through the generic "edp-panel" compatible (e.g. the Qualcomm X1E80100 CRD), but the screen works only partially in that configuration: It works after boot but once the screen gets disabled it does not turn on again until after reboot. It behaves the same way with the default "conservative" timings, so we might as well drop the configuration from the panel-edp driver. That way, users with old DTBs will get a warning and can move to the new driver. Reviewed-by: Douglas Anderson Signed-off-by: Stephan Gerhold Reviewed-by: Johan Hovold Tested-by: Johan Hovold --- drivers/gpu/drm/panel/panel-edp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/pane= l-edp.c index 3a574a9b46e7..d2d682385e89 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -1960,8 +1960,6 @@ static const struct edp_panel_entry edp_panels[] =3D { EDP_PANEL_ENTRY('L', 'G', 'D', 0x05af, &delay_200_500_e200_d200, "Unknown= "), EDP_PANEL_ENTRY('L', 'G', 'D', 0x05f1, &delay_200_500_e200_d200, "Unknown= "), =20 - EDP_PANEL_ENTRY('S', 'D', 'C', 0x416d, &delay_100_500_e200, "ATNA45AF01"), - EDP_PANEL_ENTRY('S', 'H', 'P', 0x1511, &delay_200_500_e50, "LQ140M1JW48"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x1523, &delay_80_500_e50, "LQ140M1JW46"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x153a, &delay_200_500_e50, "LQ140T1JH01"), --=20 2.44.1 From nobody Wed Dec 17 10:45:58 2025 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC98218A958 for ; Mon, 15 Jul 2024 12:16:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721045770; cv=none; b=YnHMENpDvV0LYdlU6LXRfagrtllXzYaOWcqhFD8NqaDnm9xt182FInQZBDaZGQJk3icKX6T/d1wl1WCyuzw0xNI2IP2hQ3BGyAsg5punR64AVX609nvX8VcLCy8/HKjGq+/Kui1JDJ/rBoLKOLJbnJdzVVG8HPGlc4tURj1FasQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721045770; c=relaxed/simple; bh=uRHj+xASeRStbUPUcco0GvGgUPHvwx8Q22ADeqLFEsw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lDJhQVfxoAed5a/76JOSpXhNNoI+8R0MhCGVfyFd4PVjbWlGt4fMraR7ZgN7+n7gAjKaHX9WT/XAc7p9gnxLQ9tEAjxRzCp3JmnaH5Kuj+31Xf7KOqRWfSiDKfmBstqdQ5jHYYdbpKOFhaFQmAplEXBQrq4Wi1uxN+L11GVZGIw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BCT9xen/; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BCT9xen/" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-36799fb93baso2429648f8f.0 for ; Mon, 15 Jul 2024 05:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721045767; x=1721650567; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nlicpzX8j7ceD/JMCHCgT4Wp1znP1wKt2ZwJqztrd3Q=; b=BCT9xen/HkPZmswnKd8e98txmjSZD63NCzsGErdCO/fLiloTaLeBRV7DHU/8Zt+ZdB tPIH2cWppYioAZ45FHoFN9w2yslKoUysd5uHkjv/to3IE9XWUjQNG0zmPLxWnRihTqXG HN3Y+oNGTdfU7Ns0fZ/CDzd+uP6U7JVgWh9/fP+F1k+IWzFcXQJ18SkFKXbZhm3fm19k OshAbzsZcHWtDi+eITydJ6bQWMi7wvCSWp6aqgN/PUv48rv2WH+AZRRTVBJihqKTbg8f 1xNNoK3gpdewkqNYZ0Uz6UZ5vrGDLfggJ0/nDQUTzZvwK7viSXx7BbzIngWZMP1PuL9h Qs3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721045767; x=1721650567; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nlicpzX8j7ceD/JMCHCgT4Wp1znP1wKt2ZwJqztrd3Q=; b=NmKwdj4RFenll+WGcGVYHrUQYrtL2MAjpwNBHJb4nbmoOrUxei921LBVHjpPSH/Lq+ r66EGTP9FPu47HZnJJ7AaoXJ68p7uxwYcKexmZCh9FlScjFqRWR/IAIQDYShl6RJLZAv 6cKc0KGPNuVLv7F/i5Lo6+9yw7nGs2KmIncfOkUk+mhLPvfvqBw/trsG/t1uOMpI6vXl VJEJNp0n5SpxXzyEr6KhPdlYkhT7A4iGy9sH+t64EibJ8D1uYz9YsFfhYBrJ4a7cvbd0 rPzB2/U8Dy5v+IFxVv2gtBTkIZLIUT3PLcRdvV7kF8jf40Z8nup+B9jeYX1FKtSlZ4S7 xMhg== X-Forwarded-Encrypted: i=1; AJvYcCUxqiMOV/bVD7CDzrXbXwnJ4XOmBByGki6hK343YTslObkPisKx6+VLPxSclryUqTmBoDn2w5wGoMbG6ZIA/Ad/Q21wA3bz6gZ6kqE7 X-Gm-Message-State: AOJu0Yyp+uR9ExSq6yqi2ktzflV3S0jBqlXrPNhJa4KuH5QEQjouGiQb XfIMn2mrTRSWOgPgdBg8pmj8UPqh+M40jnNekZNjYXzzCsLwUttREMUeNFdtLE8= X-Google-Smtp-Source: AGHT+IGgvcNb0nVQlFTcKcu6JOIlWWDkfbIbuPOAB1CSXeabBGkhzvEOawCNDGbvQTG94lGN9DpG+Q== X-Received: by 2002:a05:6000:2c3:b0:367:f281:260e with SMTP id ffacd0b85a97d-367f2812acamr10220652f8f.3.1721045767292; Mon, 15 Jul 2024 05:16:07 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:886b:1a3a:7569:3d95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680d9771aasm6369201f8f.0.2024.07.15.05.16.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 05:16:07 -0700 (PDT) From: Stephan Gerhold Date: Mon, 15 Jul 2024 14:15:39 +0200 Subject: [PATCH v2 3/4] arm64: dts: qcom: x1e80100-crd: Fix backlight Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240715-x1e80100-crd-backlight-v2-3-31b7f2f658a3@linaro.org> References: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> In-Reply-To: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 The backlight does not work correctly with the current display panel configuration: It works after boot, but once the display gets disabled it is not possible to get it back on. It turns out that the ATNA45AF01 panel needs exactly the same non-standard power sequence as implemented by the panel-samsung-atna33xc20 driver for sc7180-trogdor-homestar. Switch the panel in the DT to the new compatible and make two more changes to make it work correctly: 1. Add the missing GPIO for the panel EL_ON3 line (EDP_BL_EN on CRD and enable-gpios in the DT). 2. Drop the regulator-always-on for the panel regulator. The panel does not seem to power off properly if the regulator stays on. Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support") Reviewed-by: Konrad Dybcio Signed-off-by: Stephan Gerhold Reviewed-by: Johan Hovold Tested-by: Johan Hovold --- This can be applied as fix for 6.11 since the driver works as-is with the fallback compatible. If so, the defconfig patch should ideally also go there to ensure people actually have the driver enabled. --- arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dt= s/qcom/x1e80100-crd.dts index 6152bcd0bc1f..4a4eb7211e69 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts @@ -268,7 +268,6 @@ vreg_edp_3p3: regulator-edp-3p3 { pinctrl-0 =3D <&edp_reg_en>; pinctrl-names =3D "default"; =20 - regulator-always-on; regulator-boot-on; }; =20 @@ -724,9 +723,13 @@ &mdss_dp3 { =20 aux-bus { panel { - compatible =3D "edp-panel"; + compatible =3D "samsung,atna45af01", "samsung,atna33xc20"; + enable-gpios =3D <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>; power-supply =3D <&vreg_edp_3p3>; =20 + pinctrl-0 =3D <&edp_bl_en>; + pinctrl-names =3D "default"; + port { edp_panel_in: endpoint { remote-endpoint =3D <&mdss_dp3_out>; @@ -785,6 +788,16 @@ &pcie6a_phy { status =3D "okay"; }; =20 +&pmc8380_3_gpios { + edp_bl_en: edp-bl-en-state { + pins =3D "gpio4"; + function =3D "normal"; + power-source =3D <1>; /* 1.8V */ + input-disable; + output-enable; + }; +}; + &qupv3_0 { status =3D "okay"; }; --=20 2.44.1 From nobody Wed Dec 17 10:45:58 2025 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACFD718C186 for ; Mon, 15 Jul 2024 12:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721045771; cv=none; b=jbPBkiwFtWm01fIggF7WYwQze+qiI7hWGT8n71//C9jQUM+A9p3IUMc6vv4xQBVVd6PHvcyTh3hw4esiqxXGf4aLPKyp5hsUR/Jbf04jcpfr17xGAaaXVQIWDY/joYON4G40yvLaU2WZ3iCR0rZkqwgJ13EuEMGH0YVicfLf+xg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721045771; c=relaxed/simple; bh=ensaB3Sd9xExyqosO4x4Zulfh8zxqrHJ2g7V01Sv1AA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Zsmm2I7fbW21y001GUo8GMpWjbk4GrBWKxDSGsOQPOiYVzH0pmhxixk62jYYm0PxCT50SpiaSKPZkjX/P1vn/FawAUE+4wFvpPS57Cht9aWaD441T7xJRweRUCIU4IcPN6CJkv9mkoI+5EQaOHYF/11VdRJqJT9P43hjEYKvj3s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wfoDu2s4; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wfoDu2s4" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-367b6e5ffbfso2354107f8f.0 for ; Mon, 15 Jul 2024 05:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721045768; x=1721650568; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kTq2r+cTBBf6PJ97371cfxGvOYB5A8cmvVmwB9VmmPg=; b=wfoDu2s4Hi+kMtiB4X5oD6fBKi62FoHAU6/B/6ZSXxoXvgtA2IQstHH0VYFU26VMh5 /T6RdWHd4Il0t3FTX4ItgatvMogsni+hF0+QGaDUWuCUkNgSFSQvBH3msxJEFrK/GlyN MiReNX6uSFsE4erBLEajrdZLW+XhqLfggLwOg1H/2BmZzd9QUexzpEr2BKXIn2VZqIWd pNSgI6lpP5rItElsrttHCzFEiyWFAiJYLcOkEnLBSPm8B5PAl8banRh4NVjB9+o6hUWe us3pUAKRUXoo2BVPySQtwIhV3+ea295DLFp81C82SHvfjBYCFgon9cqdgy+HdIHygkLN ufmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721045768; x=1721650568; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kTq2r+cTBBf6PJ97371cfxGvOYB5A8cmvVmwB9VmmPg=; b=Mz9FlWZKbnzmcIQ/upgLDzXFFo3SVjPMGbbY02Iz3Efg2I0TCUzCox6zq0yiT6yTEv cL9uiWy5ywFSNhUbbrVvbUjL4Y2LzHuxW6syS1ZknRFAB4qST1FqTNMH8gT+F79tduiA iy85eHW8+WhZDdELqf88dp+KYAnv2v/F4RlBOYkEC/Vvnlse3vPKUYHlNutTSfPJo00W wQ0QEIwJVV44dC4q0S+sIp4RCrIyLsZp87siWWyAfKarlAjhR7SHwABRGzw9d3YMtyqw yILXZYCLSoybtJne7PaJU/y1Bh+OdZLlZRzUOOQW5J8W7KBMWWk0OZBLZHlArFCX/tnx Pqag== X-Forwarded-Encrypted: i=1; AJvYcCUS8ZlsC+60rXVO+0O/2zx3dy5xy+oqoWP+9btqYWXHQM/L7i9gMY7GEqNx2FaSK56eot6ac4bdMcMqWmWIMnzj7hMTxCiz6uM3Q4lz X-Gm-Message-State: AOJu0YzvYpIqcjz5VY3AwKEZ5iLNag+Vv6I0AESVizAKWCN1X/Ogb6eL 2OkBtVIf+Gl+nl1rK/l/t8DXfcA+q8wYGxD6KrZkzLdSq9MQ5ctH9HrSdAJolvU= X-Google-Smtp-Source: AGHT+IFs1erFYCijcBGp0SVQyMBvfH9pHBYbLhKOfck+AMcQPdS3cmXHK20l4yRwr/hKh+tKqHhBsQ== X-Received: by 2002:a5d:480c:0:b0:364:6c08:b9b2 with SMTP id ffacd0b85a97d-367cead1d1amr10964785f8f.45.1721045767976; Mon, 15 Jul 2024 05:16:07 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:886b:1a3a:7569:3d95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680d9771aasm6369201f8f.0.2024.07.15.05.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 05:16:07 -0700 (PDT) From: Stephan Gerhold Date: Mon, 15 Jul 2024 14:15:40 +0200 Subject: [PATCH v2 4/4] arm64: defconfig: Add CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240715-x1e80100-crd-backlight-v2-4-31b7f2f658a3@linaro.org> References: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> In-Reply-To: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 This is needed for the display panel to work on the Qualcomm sc7180-trogdor-homestar and x1e80100-crd. Signed-off-by: Stephan Gerhold Reviewed-by: Douglas Anderson Reviewed-by: Johan Hovold --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 7d32fca64996..362df9390263 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -887,6 +887,7 @@ CONFIG_DRM_PANEL_KHADAS_TS050=3Dm CONFIG_DRM_PANEL_MANTIX_MLAF057WE51=3Dm CONFIG_DRM_PANEL_NOVATEK_NT36672E=3Dm CONFIG_DRM_PANEL_RAYDIUM_RM67191=3Dm +CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=3Dm CONFIG_DRM_PANEL_SITRONIX_ST7703=3Dm CONFIG_DRM_PANEL_TRULY_NT35597_WQXGA=3Dm CONFIG_DRM_PANEL_VISIONOX_VTDR6130=3Dm --=20 2.44.1