From nobody Wed Dec 17 10:46:20 2025 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4805317966C for ; Fri, 12 Jul 2024 18:12:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720807947; cv=none; b=Lu39gbsqKVIdDIwyep/w3cgKHIBLs6fPxfmtmjGV+CfqOiLy9MNI7955TnKTDFJHpRPPwdq7cnlcQghAz99L6bQKL3+4h3g0yDaYBN5C0SDbN2IAS/UY/mLTr8ghOKDWLtTs5+cZust6/xyDSJ7t3ovtWi164sMh4/n16CGeOwg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720807947; c=relaxed/simple; bh=z5wXs6v0oTEwyKPVEdDTOwtt2S/GFG3uzWXLUE9bRVQ=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=E79n5eNnMWHcbY+o3KSP9gOY3usUx0OO5S/OhQ0haAKyjfixtxnNWB7lA21t05TvUDxGPgtRWiq4r8lagqiTSYjUTvdstD+qOmAWKw9/vBGJL88GfTrXA1GhzxozruE5NwIbl+SOsV2FwBeHBmHcH3mKBVMGaZOIPFyR6CeFfcA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XPt0Sz3b; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XPt0Sz3b" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e056166e0a6so3815853276.2 for ; Fri, 12 Jul 2024 11:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1720807944; x=1721412744; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=yTWyT8gKTKays8rE64DnYrzhErijM5o6wos0PD63SLQ=; b=XPt0Sz3bc5GB3E1NZRuWYy8zR6ciwmI9Q7Qt3WY4w9jK9SOFVaiW5f+6Zwxtvg9L0O HwxiwKVfN/9tijFPK6sr48/5bjSxGLbQXCN1x2t7gXm0MvWpGkSRPn/j0X7O42awHIxu PPINkLzJYNTIogySjof6Fauw+Bk3t9+60BmVQ1ukI1YcYJ746nSytCxqDeL4CaC8g9H4 nAGXzyU7kZbh0YwzKAarY90DO5W6GtWA00xiL2zynRhswoLe4ZRBwElwOwmVlUpWknCY QrntscG1bZXim1mvtEgwdybUQ9BfwFuxQPCUQYPM47+CGokoUeOb1ygDhtQoPhMvaE4M DSJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720807944; x=1721412744; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yTWyT8gKTKays8rE64DnYrzhErijM5o6wos0PD63SLQ=; b=o8e/fMQixDc5XdQF/EqSl5+pAZFiQRIh4ppHS/MCI7+twB5ld+4tz6wzUEjyakPsXt w/+VIcm5LkqZbWtXGDmg1QR/ba5ESk5pJq07NBJjCbRkGojW+YvG01J3EpAt7JUdZVVx srgtamYY3cAFaNbscCeq46DenxL4cfRPzyYtxJ0ETS/KFyUdnzVHLihAZ9gU8LjayheD r4oZG6+t6nHUHD5mceaqhE6rFcIiYZ/k2W89wovE8lHSf39V0a5Cea7VMOBc3xYWGkj8 7HlG3vEid8elW1dbzx2VHdC3s+CKBSFBPW+w6LDFnr/F25MSpaYcwfPFeMRfUIrEfNzh nywQ== X-Forwarded-Encrypted: i=1; AJvYcCU/OkNnX5JMHxiSRSnRSotAkpN2le7HwsJ1gSheIeGBS3qQ3PQ9656z3xECtK5osr6U2ZD8vKzuvX0hNDV1hixEf98W7Pdpf+2uatrZ X-Gm-Message-State: AOJu0Yw11yTOxHj9GY07hDMtgFzgCkb6uDao0GK+TPsiZEONrLlZvMu0 An2+YZ6P4cqar69U+hOxrwE/N4NyvtT9SlJFtpG78YsBw0+3mSubk8ddd5uY5C+aQbt2x9hn4t/ w+TVSVQ== X-Google-Smtp-Source: AGHT+IFDEg4qCvDKsL+VVqYz1OMCn926w9P2XUU2yFncmeWDbh5Ial6YC4Tg3xMQVgD4UPTtY6N8u5MhM92P X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:2e7d:d47a:a0c6:e3b1]) (user=irogers job=sendgmr) by 2002:a05:6902:100d:b0:dfa:b47e:b99f with SMTP id 3f1490d57ef6-e041b0314afmr26058276.2.1720807944323; Fri, 12 Jul 2024 11:12:24 -0700 (PDT) Date: Fri, 12 Jul 2024 11:10:47 -0700 In-Reply-To: <20240712181108.475336-1-irogers@google.com> Message-Id: <20240712181108.475336-7-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240712181108.475336-1-irogers@google.com> X-Mailer: git-send-email 2.45.2.993.g49e7a77208-goog Subject: [PATCH v5 06/27] perf kmem: Use perf_tool__init From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Athira Rajeev , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reduce the scope of the tool from global/static to just that of the cmd_kmem function where the session is scoped. Use the perf_tool__init to initialize default values. Signed-off-by: Ian Rogers --- tools/perf/builtin-kmem.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c index 859ff018eace..b3cbac40b8c7 100644 --- a/tools/perf/builtin-kmem.c +++ b/tools/perf/builtin-kmem.c @@ -986,15 +986,6 @@ static int process_sample_event(const struct perf_tool= *tool __maybe_unused, return err; } =20 -static struct perf_tool perf_kmem =3D { - .sample =3D process_sample_event, - .comm =3D perf_event__process_comm, - .mmap =3D perf_event__process_mmap, - .mmap2 =3D perf_event__process_mmap2, - .namespaces =3D perf_event__process_namespaces, - .ordered_events =3D true, -}; - static double fragmentation(unsigned long n_req, unsigned long n_alloc) { if (n_alloc =3D=3D 0) @@ -1971,6 +1962,7 @@ int cmd_kmem(int argc, const char **argv) NULL }; struct perf_session *session; + struct perf_tool perf_kmem; static const char errmsg[] =3D "No %s allocation events found. Have you = run 'perf kmem record --%s'?\n"; int ret =3D perf_config(kmem_config, NULL); =20 @@ -1998,6 +1990,13 @@ int cmd_kmem(int argc, const char **argv) =20 data.path =3D input_name; =20 + perf_tool__init(&perf_kmem, /*ordered_events=3D*/true); + perf_kmem.sample =3D process_sample_event; + perf_kmem.comm =3D perf_event__process_comm; + perf_kmem.mmap =3D perf_event__process_mmap; + perf_kmem.mmap2 =3D perf_event__process_mmap2; + perf_kmem.namespaces =3D perf_event__process_namespaces; + kmem_session =3D session =3D perf_session__new(&data, &perf_kmem); if (IS_ERR(session)) return PTR_ERR(session); --=20 2.45.2.993.g49e7a77208-goog