From nobody Wed Dec 17 10:46:14 2025 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7EC517A5A6 for ; Thu, 11 Jul 2024 18:01:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720720864; cv=none; b=lR4c5zzDaESJxqQZ+wV6QYsP3Lm/984Sjux+DrzjGP9lbRPdFJGZI0MeJnlDzlxQM1qyeDTn9/1xUP1yHmaayOQJRaCgbAu1LblGJEpxymPYk+2ZGDMLNMeVvOaP9KaR5xSWKBWjMwKKuiAAjx1KxPIxYL1FrT3P/92As+ijHpk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720720864; c=relaxed/simple; bh=voKswfKfj3xVUdanTG/Vv01I1kScl7Vgd1gUmqiYueA=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=bb6fTIprsLBkH905sYXjD+5S6CZWZoomitMJUxxayNpj/j4AfOqX6wKAi6/DUsf1ndd6uMXzDUwa0t3A8nQfUmSwJ7TJMLP4nBjnVDwfyP72ikjMSHI25NwhgbxDDU6U0K9WZdKiJjBH5HrngltzZk8waX/E8M27sIbiIiYxf5Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=njjrVgWa; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="njjrVgWa" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-6524309be45so22935207b3.0 for ; Thu, 11 Jul 2024 11:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1720720862; x=1721325662; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=Yt616h8hRCivHeAdqJzIY5ztVTyVV8Crah5Wq3Zf1UM=; b=njjrVgWar1PupsOHTA9f4dyQsKwtocH1cP8j0ptvkmjcQ+awOX1prnKnHPayGPzwJy EXxvsilQA7/K+9tjnCXJKvqsxukLGmLqjjEupSaMWQfP7eNC1IzTNiQiRNBWRzPXtQrp qazr0vvZ85UrevU5UjyrPeRool9O8Q32aF0yJ2YCtgEIYJEI6In66W77ospxE0bBHN2n nxVKq9G2EZwwx2k46OLXFsnUAQKFUWysTCcG8QkOf4U86kAmw+dnW9DNjsVACp9MMHge ntBV1zq0ioz8gj90ZTIqqFYlx3SHmR1KWd1mhvbsN0DbvuuHPW4p1QZYAFhTh5jM9ma+ WpAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720720862; x=1721325662; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Yt616h8hRCivHeAdqJzIY5ztVTyVV8Crah5Wq3Zf1UM=; b=SXvvkmDzdYIEUBKLzyhUfEdz6MOlQBaNdXzLeL698nXLLcMF7IgqqroroSECzh3BZn cu1NLCb7gszfjptFfYzm8kTDB1XK6PCn7fLCN1FuwPqbYku9dzuRJAtZTeeZn20uE9ip +oxlaWF88T3EJvwWcagRT4m5G6V0Fique6iOS9mWcRu0gn3OmO5NumqquR6OnmXorfBf PtvxbIfhpzWJDRoasXr3LtyoSNrwFV7zNV5veBRa7a7DQPOU1lpq3TYJTOupRQcwIqyo V1l4pwfN4yXBA+htREsH5FLNpFqY189yJncXLQwf7kt8/ZN0TgWdocMZ27NswZz5+e+v GVIQ== X-Forwarded-Encrypted: i=1; AJvYcCU33koaPN2xnbdZzZjbgj0I1phr+x9XOcQELjt2O8sgYyccFVOwDh42FuNwDai1UMuCBCO4+OhFDePdwXaEBNvgzZx5bhgr5m+oTv+W X-Gm-Message-State: AOJu0YzC+dFf0f7R/LOZX5rSERJMg0H4nG8Vle3d6wY4Y1Iea8OI0l8d e8W4G3JM3afmJPIbrwggftH+8jVo5A3b1mX26/Uidbi/xM3FFWX8TvGs83N2zqYrcdWXVbkacP1 bLpWigQ== X-Google-Smtp-Source: AGHT+IEX9oO7/QxRJKOh3p4hGI/yZCLEqpz98Pi8rexdVxqsNShjq1Lvluub4NnTvVJr1wr4NjxC6/p3kgg0 X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:bd08:a1e0:c497:32db]) (user=irogers job=sendgmr) by 2002:a05:690c:d17:b0:627:dd6a:134 with SMTP id 00721157ae682-658eeb6d6demr1963327b3.3.1720720861856; Thu, 11 Jul 2024 11:01:01 -0700 (PDT) Date: Thu, 11 Jul 2024 11:00:02 -0700 In-Reply-To: <20240711180008.188906-1-irogers@google.com> Message-Id: <20240711180008.188906-23-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240711180008.188906-1-irogers@google.com> X-Mailer: git-send-email 2.45.2.993.g49e7a77208-goog Subject: [PATCH v4 22/28] perf diff: Use perf_tool__init From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Athira Rajeev , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use perf_tool__init so that more uses of struct perf_tool can be const and not relying on perf_tool__fill_defaults. Signed-off-by: Ian Rogers --- tools/perf/builtin-diff.c | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c index 4c0567882a7a..28c5208fcdc9 100644 --- a/tools/perf/builtin-diff.c +++ b/tools/perf/builtin-diff.c @@ -467,21 +467,7 @@ static int diff__process_sample_event(const struct per= f_tool *tool, return ret; } =20 -static struct perf_diff pdiff =3D { - .tool =3D { - .sample =3D diff__process_sample_event, - .mmap =3D perf_event__process_mmap, - .mmap2 =3D perf_event__process_mmap2, - .comm =3D perf_event__process_comm, - .exit =3D perf_event__process_exit, - .fork =3D perf_event__process_fork, - .lost =3D perf_event__process_lost, - .namespaces =3D perf_event__process_namespaces, - .cgroup =3D perf_event__process_cgroup, - .ordered_events =3D true, - .ordering_requires_timestamps =3D true, - }, -}; +static struct perf_diff pdiff; =20 static struct evsel *evsel_match(struct evsel *evsel, struct evlist *evlist) @@ -1959,6 +1945,18 @@ int cmd_diff(int argc, const char **argv) if (ret < 0) return ret; =20 + perf_tool__init(&pdiff.tool, /*ordered_events=3D*/true); + pdiff.tool.sample =3D diff__process_sample_event; + pdiff.tool.mmap =3D perf_event__process_mmap; + pdiff.tool.mmap2 =3D perf_event__process_mmap2; + pdiff.tool.comm =3D perf_event__process_comm; + pdiff.tool.exit =3D perf_event__process_exit; + pdiff.tool.fork =3D perf_event__process_fork; + pdiff.tool.lost =3D perf_event__process_lost; + pdiff.tool.namespaces =3D perf_event__process_namespaces; + pdiff.tool.cgroup =3D perf_event__process_cgroup; + pdiff.tool.ordering_requires_timestamps =3D true; + perf_config(diff__config, NULL); =20 argc =3D parse_options(argc, argv, options, diff_usage, 0); --=20 2.45.2.993.g49e7a77208-goog