From nobody Wed Dec 17 10:40:43 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B050A192483 for ; Wed, 10 Jul 2024 17:27:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720632443; cv=none; b=um/cVqsZcPe6WI6LwR6ARhD186d7lAEYPvxg23w48G76MwGyUiX9EcWOvfKcgf+fa+LoiCiw232h4tW+UyEiM8Tf+LQrXUldLXd78XjQe/YNcMuSZruE9rx+YS1bNrLxpcl1ATcGxPGf07HZTC/YE2BPZcdFnv8JC3q7fLJS4zg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720632443; c=relaxed/simple; bh=N+6nP24X2D6S+4HtySYOmSBVHZCaJaPE+LuP8o4gdBA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=EInxxMJjqKZ5gls/MtpzComVKPhTe0YdEeROaUgq1MGALuBnelWWSENOBsY5/BcYIn1GfPQu4L6ZA3HcYnaSZ8xNGKuoldfaTQCotgK8P2fqwD4+omdzJzK46/4t8jWBKMfVMRYbzBVKMDt1rG94f0k8TUoylCKahNd6I6Cqz54= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TNcOwtGB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TNcOwtGB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A9F6C4AF09; Wed, 10 Jul 2024 17:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720632443; bh=N+6nP24X2D6S+4HtySYOmSBVHZCaJaPE+LuP8o4gdBA=; h=From:To:Cc:Subject:Date:From; b=TNcOwtGBvZKQtWGf63CHbuqIAvWyb9RhCVRd6Hh8494D9I/Jn4l7ZkUBGxh+n72z2 t7mf1QsACZJFjhubmxfTwN/8oNFY/wFPwauPyyHJc+4G7Gr6h1P2LqXYpXW376c4sw Klxlri58iQ9gUiSTEvvGsCY3Wukc+PCDYB5u2HDM/OSnjxf93zvKfA9bneVY6zIJZE hiI7/9hHxuFJZ+TmuTIZK9d58GimT/xGPSUbqW4g7jdyy9uooEWpSLP+/Hln4PXqjq upnUXFvWhMuYhl5Csm7mT4AiQoZhA9V6pV+o+6hEuAUCuLhcldIKqk56Y919M+sU2L H52swwg7eO6JA== Received: from sofa.misterjones.org ([185.219.108.64] helo=valley-girl.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sRb68-00BI6M-SC; Wed, 10 Jul 2024 18:27:21 +0100 From: Marc Zyngier To: linux-kernel@vger.kernel.org Cc: Masahiro Yamada , Nicolas Schier Subject: [PATCH] kbuild: deb-pkg: Fix build error caused by lack of positionnal argument Date: Wed, 10 Jul 2024 18:27:17 +0100 Message-Id: <20240710172717.1346194-1-maz@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, masahiroy@kernel.org, nicolas@fjasle.eu X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Content-Type: text/plain; charset="utf-8" Since 8ef052389f7f ("kbuild: package: add -e and -u options to some shell scripts"), building a debian package on my arm64 box fails: $ make -j20 bindeb-pkg UPD include/config/kernel.release GEN debian ./scripts/package/mkdebian: 138: 1: parameter not set make[2]: *** [scripts/Makefile.package:98: debian] Error 2 make[1]: *** [/home/maz/hot-poop/arm-platforms/Makefile:1538: bindeb-pkg] E= rror 2 make: *** [Makefile:224: __sub-make] Error 2 Applying the same pattern for substitution of undefined variables seems to paper over the issue and brings the script back to life. Fixes: 8ef052389f7f ("kbuild: package: add -e and -u options to some shell = scripts") Signed-off-by: Marc Zyngier Cc: Masahiro Yamada Cc: Nicolas Schier --- scripts/package/mkdebian | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian index 196b14e8ad47..de8b460a46b4 100755 --- a/scripts/package/mkdebian +++ b/scripts/package/mkdebian @@ -135,7 +135,7 @@ else fi maintainer=3D"${name} <${email}>" =20 -if [ "$1" =3D --need-source ]; then +if [ "${1:+set}" =3D --need-source ]; then gen_source fi =20 --=20 2.39.2