From nobody Thu Dec 18 15:27:41 2025 Received: from mail-m49197.qiye.163.com (mail-m49197.qiye.163.com [45.254.49.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C974819408C; Wed, 10 Jul 2024 14:31:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.254.49.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720621863; cv=none; b=MTrIeyLs6WjjiRQuFHmmsAPaWO4ezrSug/0d92++rMUvML7EMkCzEQUCF4B+vc2xqQOQ1cD3h1Naf3Fq7vEOAM+dMZUl3FCvev7z2i/kNv2CNkLHUOBfYmr7OpFvyp5M1oS+P+F/XVEkJBVwP6mSZCjvuZ9whoJKHMgeiKqqoIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720621863; c=relaxed/simple; bh=BHRSRVDN7UY8ojCth3OQGeUyoeHM/w9ju1dYitSn/do=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lNrVyR+GeOXsS5fyNnC2EmJb8LyKGiALVmK5B7cH9RZRMpIVPxCjazcI8UzDiJBd7NNQnkpHfx+OP6mQfDCiQfrbZYKkdhBFhOORwNuRbYSNap2PASJBBlp0ZcRIXSVNGoARtwX7FzEAyqBtagBCXY+7Cv1EIzEDHgwVlVRu/vc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=jmu.edu.cn; spf=pass smtp.mailfrom=jmu.edu.cn; arc=none smtp.client-ip=45.254.49.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=jmu.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=jmu.edu.cn Received: from amadeus-Vostro-3710.lan (unknown [IPV6:240e:3b3:2c00:fb60:82c0:6879:f4d2:caf4]) by smtp.qiye.163.com (Hmail) with ESMTPA id 017297E017F; Wed, 10 Jul 2024 22:30:37 +0800 (CST) From: Chukun Pan To: Heiko Stuebner Cc: Krzysztof Kozlowski , Conor Dooley , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Chukun Pan Subject: [PATCH v3 1/3] arm64: dts: rockchip: use generic Ethernet PHY reset bindings for Lunzn Fastrhino R68S Date: Wed, 10 Jul 2024 22:30:15 +0800 Message-Id: <20240710143017.685905-2-amadeus@jmu.edu.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240710143017.685905-1-amadeus@jmu.edu.cn> References: <20240710143017.685905-1-amadeus@jmu.edu.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWS1ZQUlXWQ8JGhUIEh9ZQVlCTh8aVkwfSh1LSkwfGUIdH1YeHw5VEwETFhoSFy QUDg9ZV1kYEgtZQVlJT0seQUgZSEFJGEtLQR0ZTUtBQ0kYS0FNQ0xCQR1PH0lBGBodT1lXWRYaDx IVHRRZQVlPS0hVSktJQkNDTVVKS0tVS1kG X-HM-Tid: 0a909d0daf8603a2kunm017297e017f X-HM-MType: 10 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MDY6FSo4EzI8EDA4LEtLPQo8 CjYwFApVSlVKTElLTUlKQ0hDTkJCVTMWGhIXVRoWGh8eDgg7ERYOVR4fDlUYFUVZV1kSC1lBWUlP Sx5BSBlIQUkYS0tBHRlNS0FDSRhLQU1DTEJBHU8fSUEYGh1PWVdZCAFZQUhPQko3Bg++ Content-Type: text/plain; charset="utf-8" Replace the deprecated snps,reset-xxx bindings to the generic Ethernet PHY reset GPIO bindings. According to the PHY datasheet, the RTL8211F PHY needs a 10ms assert delay and at least 72ms deassert delay.=20 Considering the possibility of mixed use of PHY chips, increased the reset time. Fixes: b9f8ca655d80 ("arm64: dts: rockchip: Add Lunzn Fastrhino R68S") Signed-off-by: Chukun Pan --- .../boot/dts/rockchip/rk3568-fastrhino-r68s.dts | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r68s.dts b/arch/= arm64/boot/dts/rockchip/rk3568-fastrhino-r68s.dts index ce2a5e1ccefc..02d966d218fd 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r68s.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-fastrhino-r68s.dts @@ -39,10 +39,6 @@ &gmac0_tx_bus2 &gmac0_rx_bus2 &gmac0_rgmii_clk &gmac0_rgmii_bus>; - snps,reset-gpio =3D <&gpio1 RK_PB0 GPIO_ACTIVE_LOW>; - snps,reset-active-low; - /* Reset time is 15ms, 50ms for rtl8211f */ - snps,reset-delays-us =3D <0 15000 50000>; tx_delay =3D <0x3c>; rx_delay =3D <0x2f>; status =3D "okay"; @@ -61,10 +57,6 @@ &gmac1m1_tx_bus2 &gmac1m1_rx_bus2 &gmac1m1_rgmii_clk &gmac1m1_rgmii_bus>; - snps,reset-gpio =3D <&gpio1 RK_PB1 GPIO_ACTIVE_LOW>; - snps,reset-active-low; - /* Reset time is 15ms, 50ms for rtl8211f */ - snps,reset-delays-us =3D <0 15000 50000>; tx_delay =3D <0x4f>; rx_delay =3D <0x26>; status =3D "okay"; @@ -76,6 +68,9 @@ rgmii_phy0: ethernet-phy@1 { reg =3D <0x1>; pinctrl-0 =3D <ð_phy0_reset_pin>; pinctrl-names =3D "default"; + reset-assert-us =3D <20000>; + reset-deassert-us =3D <100000>; + reset-gpios =3D <&gpio1 RK_PB0 GPIO_ACTIVE_LOW>; }; }; =20 @@ -85,6 +80,9 @@ rgmii_phy1: ethernet-phy@1 { reg =3D <0x1>; pinctrl-0 =3D <ð_phy1_reset_pin>; pinctrl-names =3D "default"; + reset-assert-us =3D <20000>; + reset-deassert-us =3D <100000>; + reset-gpios =3D <&gpio1 RK_PB1 GPIO_ACTIVE_LOW>; }; }; =20 --=20 2.25.1