From nobody Wed Dec 17 13:55:37 2025 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FEA5A32 for ; Wed, 10 Jul 2024 00:13:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720570385; cv=none; b=WICUyYQkAHidCs9k7ucpw43DjrfXJMqhUDW9/6r+Kzm0iNLXSobxhnY+urtbkMbJ0uDPZNRExOWZbomwMNHcCA68BuEexp1cz3Wid5RSGdx9QcnH2HDA0Oknz1quRuxYzFXqdp7i/xMG43vpmC/yWr4z+mNu9wSHPKEJYIpudwQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720570385; c=relaxed/simple; bh=Lxs17QnPWqide1kuu3+MFXHOtxROAxydfMblGjRRX3A=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Xs00EOHu9agkjOCTjDEIvUuzGw7ZSOAvtzpyzDIEt1ntOcHmt/9Qqm/XBagJkXN2M46nVOti/7TMHicKNEGNn0XspvDLl6vhrZvaWDyFpTyc8vUZQYHX1t5HaU1DzFPcg3CMUclSon1Swe5gWzmsjaHnCZXaKqNpM1Zr46ddAtY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uci.edu; spf=pass smtp.mailfrom=uci.edu; dkim=pass (2048-bit key) header.d=uci.edu header.i=@uci.edu header.b=VeS5qrJW; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uci.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=uci.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=uci.edu header.i=@uci.edu header.b="VeS5qrJW" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1fb0d88fd25so1809435ad.0 for ; Tue, 09 Jul 2024 17:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uci.edu; s=google; t=1720570383; x=1721175183; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tSpW7AqjpwQU1YZlBwSC0jTPvLt58lOmnA2ZeLiWhSk=; b=VeS5qrJW6hwIqh0g9jlMAJ2L49ZwfDmD5C4fpmz4faMOwe5B/LUwS9EM9k+TbRSd/n WxvfM6TggK3Yw5BetpO8LL22/eMkK+qR+OLguYkC0J9lcjY+rAoCMismMISjmbIEaoN1 6FkYEYmxk9sfr2vbKO3sHxbLbsg0WChhzR5U0P2YmXbActDcQjKT3wgomN4WSfL2Q9a2 AvAjBkJ3aJ4TU2qcZRZCFeLJP2gsvlvNdKurbiZBa/eKVsPDhoa8Mt5nqIXL5K074J2L eTT+y72gLOCNEEn+VJRCcMumYxFU4R8ptpHa8JyCXhk+GGt4VWWgutU8dCIbP5QNKt6X vMcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720570383; x=1721175183; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tSpW7AqjpwQU1YZlBwSC0jTPvLt58lOmnA2ZeLiWhSk=; b=hClOHPKJpa31crn7zQNBStne+LZ5gqJV4xy7FB98UyyNa6qNSjr79xqaz9dN7im/rI F17kgWZm4H+3YX6615AiFESfbH+GVhv+APY5vv5GdSPqhhZbEU0t6GCGjRKrYfIxkwzs ILv8dhWOogiG95osexoAhB9pVw43rLJ11IuF9y2APW+FdgWPviiPH1OjMxtvpTUcl0cN QhUojSEUKVkf5l20H9wq7SOks8wsn1j7p4MXwlWqQOeV45Q01MSGc2SsTxIPyRHDu1Y7 ePhCuHkDJNH7MQn1k0CdWcS678E/bJ+n4jkDGcQ1W9riqsazTE8yX6onykGWvTOG3bXL kX3A== X-Forwarded-Encrypted: i=1; AJvYcCXx0JnZiiMhNuB1xEnnQAXWg/njaWWHfjWbEUmyODGmnpjop1xYv7AGgJc9LJ08r9+HySc8sK0EsHTusf4d5FZIzH0c37xVpte/AZZp X-Gm-Message-State: AOJu0Ywsma8AhmdTLfAIq/kQPtc5UIVVrIyZhiCiSI249Z+HlOYRVRVr cYtOKTDGoocaQ36O8iRgZMFew8wWAYYdutaUu8MQd3hV+yUBycHfPrcd/JiNrRU= X-Google-Smtp-Source: AGHT+IFZ+U0vwKEkq0hOtvZ5jJDsUtmCIT4kTMkBa1V9TXiL/6L8Y3rUPlhGyo845hlJfZURvkiEMA== X-Received: by 2002:a17:902:f7d1:b0:1f8:62a1:b6af with SMTP id d9443c01a7336-1fbb8019531mr41100765ad.21.1720570383350; Tue, 09 Jul 2024 17:13:03 -0700 (PDT) Received: from alpha.mshome.net (ip68-4-168-191.oc.oc.cox.net. [68.4.168.191]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fbb6a34f9esm21740765ad.114.2024.07.09.17.13.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jul 2024 17:13:02 -0700 (PDT) From: Remington Brasga To: Dave Kleikamp , Manas Ghandat , Juntong Deng , Andrew Kanner , Osama Muhammad , Shuah Khan Cc: jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, syzbot+e38d703eeb410b17b473@syzkaller.appspotmail.com, Remington Brasga Subject: [PATCH] jfs: UBSAN: shift-out-of-bounds in dbFindBits Date: Wed, 10 Jul 2024 00:12:44 +0000 Message-Id: <20240710001244.2707-1-rbrasga@uci.edu> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix issue with UBSAN throwing shift-out-of-bounds warning. Reported-by: syzbot+e38d703eeb410b17b473@syzkaller.appspotmail.com Signed-off-by: Remington Brasga --- When nb =3D 32, `mask =3D mask >> nb` or shorthand `mask >>=3D nb` throws shift-out-of-bounds warning. `mask =3D (mask >> nb)` removes that warning.=20 Link to the syzbot bug report: https://lore.kernel.org/all/0000000000006fc5= 63061cbc7f9c@google.com/T/ fs/jfs/jfs_dmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c index cb3cda1390ad..636aae946e84 100644 --- a/fs/jfs/jfs_dmap.c +++ b/fs/jfs/jfs_dmap.c @@ -3020,7 +3020,7 @@ static int dbFindBits(u32 word, int l2nb) =20 /* scan the word for nb free bits at nb alignments. */ - for (bitno =3D 0; mask !=3D 0; bitno +=3D nb, mask >>=3D nb) { + for (bitno =3D 0; mask !=3D 0; bitno +=3D nb, mask =3D (mask >> nb)) { if ((mask & word) =3D=3D mask) break; } --=20 2.34.1