From nobody Wed Dec 17 10:44:45 2025 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 680071953AB for ; Wed, 10 Jul 2024 17:05:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631119; cv=none; b=chazIHR+ZehumJbolBGTlVN8jJHBDyK6FtHmfYW3ZIoyjSDIpgssbIpkhk/XBp7+DucX3xcXeKvCa8M0S3c5m9NJ790VyvWVyiF1jBBw+yoIfKbVDa6OtyClSusIO0zV9AmV6r7GIZ0qTNlaOeND/txIE0Cd0sKmufSFwa7K03I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631119; c=relaxed/simple; bh=wXcS/KnBI5LgsGogTMFCCth33LAkgZkI+3fauQ91JiE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cFIYu4HVFW04A13n7ZfYRldRMb9MOqxjAfLctb2JG0oIB083lSo74g+TlbXEgUbv87yLd6v3bP44WEyLW663pit49bTds71jSx1JRIA2/E9C2zAp1OsPzGXnsoJek9Wk79zZIBmrRS1zNvAJt25eIOr/EvJQBVetF2yE8AtSLFw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=e/bXP+WV; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e/bXP+WV" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-367aa05bf9dso2850200f8f.3 for ; Wed, 10 Jul 2024 10:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720631116; x=1721235916; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ri1KrrJv5lGlLAnLFws19LhHfpuP+FO80ojRQ99yShw=; b=e/bXP+WVdxJ+GppzonXkozIOLiRKmMnJ9RCWcsH8N0GO7ky4VDOy99r0PlGkNOqoSR 7aNcu0a49hIQIXHXtVPsgDbj+dGvgkFxD4aP2F/Fb4rCBpRvqnzmcR4FDSrn8ozIR+cp CdqvMuCHRz9PvpN8BN0Ioj5PzSmlebZjnHx+ZyYW0LxPw8ua85X3GL+Ph/DJ/D8kjn2Z IiQosaFf69Mct8pZkKXm7m+PC2utw5TUeBNTVVwbJYVzjLENfgnX5ZBM2VChfrCYjmup BDUCMiTAesCYcmnQqfwLnX/4alm65oGj1OVSTL/UWUw15Q3WJBeEjGYhArfn1nl9EPax UfDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720631116; x=1721235916; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ri1KrrJv5lGlLAnLFws19LhHfpuP+FO80ojRQ99yShw=; b=Z2jWtlFBZl46Jw44dF4b9B3uhxmU8ON+ytOs6KxwIIPgrfqEh5QqDLswg3wuIV8saJ vVBcEERGsbXoD4/5dOLdMx/6Kv9tV1ont9i7upiTPDYZaFyRZ99svUlwSGBobwTBxTog 46stYask4NtwinSlYUbOAjG/DFfWe6yRZZspw2qfT208VvSwkhvatlH5U/lVbAXTRonR mIezfoSApWrSh5rmiDT+nbgLWBzqgxePqeQ+VWmWprbvFSi5OGV6FCcXWyAmVFuPXQ/7 j8fmE6+x9JgeUGwZe+a0QvlB+4pyCAxeO5J6p8UC5lqUmgrEF/ohXNq03aFDciMHswvi JrHA== X-Forwarded-Encrypted: i=1; AJvYcCV8uE0AoTplQJoFJIsMH1fshl2kYBKz0+dhzL9uAHWLGKYm7NC+UVimp+8ALGdu+QKnm5x7iqJTdLlY1st8Xju0fvMJTlv9mXCFb44y X-Gm-Message-State: AOJu0YxT9ec2mmRoXViXpusV2K2TMWoZy0LA0YQZPoXd4Cd7T7VMYpkL itpPbU3SHusxxP2ukzvh4EUgi8b37Zxhs7Y+vvPxbLeeCE7t53trGhaRFLIVwoA= X-Google-Smtp-Source: AGHT+IG2I2vfs2A9BrUdEREFeLsTLIRYJLTlw8D0se40K1gnpRKxO6FDo/ods9+emAorOvUndvejzA== X-Received: by 2002:adf:978f:0:b0:366:e9f3:c242 with SMTP id ffacd0b85a97d-367cea46887mr3987846f8f.12.1720631115960; Wed, 10 Jul 2024 10:05:15 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:65e6:93ca:5f80:ea9b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7dedfsm5838446f8f.24.2024.07.10.10.05.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:05:15 -0700 (PDT) From: Stephan Gerhold Date: Wed, 10 Jul 2024 19:04:57 +0200 Subject: [PATCH 1/5] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240710-x1e80100-crd-backlight-v1-1-eb242311a23e@linaro.org> References: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> In-Reply-To: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight control over the DP AUX channel. While it works almost correctly with the generic "edp-panel" compatible, the backlight needs special handling to work correctly. It is similar to the existing ATNA33XC20 panel, just with a larger resolution and size. Add a new "samsung,atna45af01" compatible to describe this panel in the DT. Signed-off-by: Stephan Gerhold Acked-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/panel/samsung,atna33xc20.yaml | 6 ++= +++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/panel/samsung,atna33= xc20.yaml b/Documentation/devicetree/bindings/display/panel/samsung,atna33x= c20.yaml index 765ca155c83a..d668e8d0d296 100644 --- a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.ya= ml +++ b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.ya= ml @@ -14,7 +14,11 @@ allOf: =20 properties: compatible: - const: samsung,atna33xc20 + enum: + # Samsung 13.3" FHD (1920x1080 pixels) eDP AMOLED panel + - samsung,atna33xc20 + # Samsung 14.5" WQXGA+ (2880x1800 pixels) eDP AMOLED panel + - samsung,atna45af01 =20 enable-gpios: true port: true --=20 2.44.1 From nobody Wed Dec 17 10:44:45 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C6DA1957E7 for ; Wed, 10 Jul 2024 17:05:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631120; cv=none; b=jvJ49QOfaxTX+0J4k3SM9KD/JKWs2bK1YCiAR9uF8vLJQ7P06GIF+XnTVB9U2nLr6MXYslioGqxSfHud1G+Hv2Sx5qGrkTqS7ZQXqvwh/iJeu31nd1noqVv15Dd5WpYNYNhCVsQL9Mly4DXdQ6mBwsWxSmRgSiJ2Cf7YA0F/XKI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631120; c=relaxed/simple; bh=4u4EzVnigRGaEkzIutm5rdwG3oK439XpXPx5hpNTB2s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pvD7YIaU4LSvh6k9fTR4HgK4jFlHJGwQBA7s+cp5EEtMhLxtmAyP1BHxnOjGS8M4uy+xTh7UbcnzImI0eXk7CiTSSK5iK/mQe/URDeP8D2qBIPZ3siPwGddcMXNcioIiyiSBkL5fYkI/fbE1v+qahPmyIep7rIgWQRCycT3fvkA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DsGkDBh4; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DsGkDBh4" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3678aa359b7so710233f8f.1 for ; Wed, 10 Jul 2024 10:05:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720631117; x=1721235917; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/g1Yb1+vfOCpHonxF+Jqbu5p5cwpmV8OmQtPa+jVmyk=; b=DsGkDBh4bRXaavMvuqB/oQezv1jE2QdIFeLx4Ihe/nBwclajIIjRUwfruDljE9JFXv t2OL9AwPQjVDezw1LJAGFqHpnNow9oaZM/q73aOs90fH5zjcIPkQqpaddmMKUks5EKk9 GQUNo7cnhjvalgFE3DFfx7lCXKTYwr/WwQKX/yKEV8wx/tBHF102lO3tT5IHaRI3hP5o dbZ4goidzy8xqRIzqUQ+FHL6gtb94bagPZjpWwIDEZZe3OehhFvnMqoTLbUB7/nF68cS I2tKCuZyQOIjRhKlwHEU2wXXLyguorxvuSM1ctKqyu5haZr3iBK/VoLk5SZSgVz/lrQi GT9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720631117; x=1721235917; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/g1Yb1+vfOCpHonxF+Jqbu5p5cwpmV8OmQtPa+jVmyk=; b=V1rE4V5O9ccDtmQeEERjhSg24/Oh0rHAembxVUqDUUcJuqi+Jik/Wn++3jIGvbEV3A RAYkHwT/1Gv/AHf8dDp+5ERRtBgTwiemIPNkfMl9o6KOo7wUHDGCpCapfenP0xKHoo3j VtBCHfK6IvnPUfXlkQ1l9xYO6luVEve5nLR8i5I6CqEg+NIq/9MJo57sDEdUxxZBu4dy 4eir2cVy51n1YtX5ajWmpNAU/UELTyEQ2Dp/MzUvwAWX2hWHCTIhF/BVysF8iO8jPqux lX4/Yu5ZUDmjU0I4yUtMMi4oAtdYmtwulk+Co+gG380WSORMiZMLYMVaP1mabDViCi+g bKbw== X-Forwarded-Encrypted: i=1; AJvYcCVucnQW8TqTJ4qwgwp3Deg0IS9u+STJv7KXNOSHRHuQtfz7O9AhrUGcICorpWHF4X0OiKgNUUeVn9kcIqXNOjHEKhNn3Ko6qZLiM56N X-Gm-Message-State: AOJu0YytDIYwZHTDpr5P5ITnhj6fyvXTEtpTLlIOQurP0tsCNsURyhb+ Uii/Jd+KTSq6gH9pdpyQflsqC+wcuaO+Te9/ul9MBGc/c9FHXcgrSvw2PBeDTiA= X-Google-Smtp-Source: AGHT+IHrRXiCsidR4X+LasiuthOFj9ICKMJe5oQgZWQE5LzqBbT6SBTjtUxtWEVsNWAdJXaa53sXHw== X-Received: by 2002:adf:e0d0:0:b0:360:8c88:ab82 with SMTP id ffacd0b85a97d-367f04de8e6mr260014f8f.30.1720631116954; Wed, 10 Jul 2024 10:05:16 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:65e6:93ca:5f80:ea9b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7dedfsm5838446f8f.24.2024.07.10.10.05.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:05:16 -0700 (PDT) From: Stephan Gerhold Date: Wed, 10 Jul 2024 19:04:58 +0200 Subject: [PATCH 2/5] drm/panel: samsung-atna33xc20: Add compatible for ATNA45AF01 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240710-x1e80100-crd-backlight-v1-2-eb242311a23e@linaro.org> References: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> In-Reply-To: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 The Samsung ATNA45AF01 panel needs exactly the same non-standard power sequence as the Samsung ATNA33XC20 panel for backlight to work properly. Add the new "samsung,atna45af01" compatible to the driver to make it handle these panels as well. While ATNA45AF01 would also work with "samsung,atna33xc20" as a fallback compatible, the original submission of the compatible in commit 4bfe6c8f7c23 ("drm/panel-simple: Add Samsung ATNA33XC20") had the timings and resolution hardcoded. These would not work for ATNA45AF01. Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c b/drivers/gpu= /drm/panel/panel-samsung-atna33xc20.c index 9a482a744b8c..fd56fd02df87 100644 --- a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c +++ b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c @@ -333,6 +333,7 @@ static void atana33xc20_remove(struct dp_aux_ep_device = *aux_ep) =20 static const struct of_device_id atana33xc20_dt_match[] =3D { { .compatible =3D "samsung,atna33xc20", }, + { .compatible =3D "samsung,atna45af01", }, { /* sentinal */ } }; MODULE_DEVICE_TABLE(of, atana33xc20_dt_match); --=20 2.44.1 From nobody Wed Dec 17 10:44:45 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A79C195B12 for ; Wed, 10 Jul 2024 17:05:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631120; cv=none; b=D9cGoZukaLOR/nqKctXqh+5jFQyOZxRsr2tCxQLdeQ/ksZ0x3GgKpxA49fLeVHJAZDPrsn99KX5R/Be7IHGhdK8h/CmLNgeg36qf4WEjzaqpTR1q2URfkicZZKzyAJKBGHLXa04Y7+EXozrMgdGbqNOdBe49RDd86CHPsaCS4Ws= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631120; c=relaxed/simple; bh=OjIv6lSyIoOmyQVHsNTFY8WnoyqlDx5HT8DrVGCLkuY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ccDcbQquCHsUGDOatD2OdWNbOvRjFJ34LpJ4OdZ1ZTybmrQAAVm+aqhz1NI+4JaxOGA1aJ6s3yCs/AV8A22Gftdbenkaatalye/dlaWbfPMZHLnl81bRBImNcO2C8PwvmXdtbzmLuWms4eQh5H1SYtSvlMAm56ouLhx84hC2h28= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nkWXSBSj; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nkWXSBSj" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4255fc43f1cso52605e9.0 for ; Wed, 10 Jul 2024 10:05:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720631117; x=1721235917; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=S4NkoAIT77VT3upOcUYDgNo3eUGfA37eNUjC42fZIhc=; b=nkWXSBSjzqJ1ESlxQPj7Yb/ecY3DMOnq6LU7RR7lE5zaSowR+rJZsGleqCmWnR82/m xSvcyDKd0rCCcbwgtSjN/VvUD8DLs9n51/z2hO5pYvLaJXPmXxOfETTRsZJAPyTILpsR J+LLS2TVZH9svZZt9XEbzqJ13nLQpKEjOPfCSi0WFXmJBjvOQ+/JZaQE33rtWbmp+ObN xJQ2e2x5x8uqmrj9/NCmNnrVP/4zoBpT+bgORSBfTJxLq36kyRe9iFP02KjC89LcYI0T Es4PSvBzDNJxu4AmZfxg/Rg23Qi3w6DXkxtE9NfRQVdzjezbRjZ/+Loa9LuolZ+EUEMP OOpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720631117; x=1721235917; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S4NkoAIT77VT3upOcUYDgNo3eUGfA37eNUjC42fZIhc=; b=iVVuF7MZr9VPWeX1G/eR2jYg4EUVVZbSUE/kLNm/LrTY4p4itwAVPKSmRtrUEsyuBM flCwCL24F+bzVMkqf/Hq/6SsDVVfrFb7VRhxhuXhQvK0QaDFQnhQcyKknYm5MOQ2TY8x OAE8f+XuSFpDP6BpePD9ViGrRShb6wuHnpX2Ak1AvcVEXre/xbzTvThnu9GNzbgd1kam RrVMvrYUnt2lpVi5OKMeSB/gQc48tVDG66/vhpRvpqvCHjjtLN0FWxXk++IYVLDD93Vy 4QpiDaXox/It0FKTaqpRbkiwfWXQrIbz5ConJfk7Zc8kyJ3kTWGh/7qiIqk3hrfd9d+T +oYA== X-Forwarded-Encrypted: i=1; AJvYcCUW3YI+v6hKznY9WhoCB94Yvr5yB3Vrrb9TC+R4B02RIWjlBqQAMnhxKqFeHWgJv2Vg6Kr1rRoykGkVqtacFMtVZs9oXOSEQVgnYOT5 X-Gm-Message-State: AOJu0YxCNMyvwVXTlSZtisPCgQEYeqZQ11M8CcMMsu+Gv9ZKowWhUgL1 pPBfawx84f1CoQ4+Qz5lHdNetWiOm5v3zI6CrCi+Eus7MPcNr17/GJ1SiiPLG74= X-Google-Smtp-Source: AGHT+IGkLUFSUmZ5ECS3GHwAe+MqsROrwZrfQE/I+tdJdPvxCPyYlWVxShiAik5dzVjABnYcvtZ7ZQ== X-Received: by 2002:a05:600c:896:b0:426:5216:3254 with SMTP id 5b1f17b1804b1-426708f1eebmr46866985e9.32.1720631117621; Wed, 10 Jul 2024 10:05:17 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:65e6:93ca:5f80:ea9b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7dedfsm5838446f8f.24.2024.07.10.10.05.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:05:17 -0700 (PDT) From: Stephan Gerhold Date: Wed, 10 Jul 2024 19:04:59 +0200 Subject: [PATCH 3/5] Revert "drm/panel-edp: Add SDC ATNA45AF01" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240710-x1e80100-crd-backlight-v1-3-eb242311a23e@linaro.org> References: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> In-Reply-To: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. The panel should be handled through the samsung-atna33xc20 driver for correct power up timings. Otherwise the backlight does not work correctly. We have existing users of this panel through the generic "edp-panel" compatible (e.g. the Qualcomm X1E80100 CRD), but the screen works only partially in that configuration: It works after boot but once the screen gets disabled it does not turn on again until after reboot. It behaves the same way with the default "conservative" timings, so we might as well drop the configuration from the panel-edp driver. That way, users with old DTBs will get a warning and can move to the new driver. Signed-off-by: Stephan Gerhold Reviewed-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-edp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/pane= l-edp.c index 3a574a9b46e7..d2d682385e89 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -1960,8 +1960,6 @@ static const struct edp_panel_entry edp_panels[] =3D { EDP_PANEL_ENTRY('L', 'G', 'D', 0x05af, &delay_200_500_e200_d200, "Unknown= "), EDP_PANEL_ENTRY('L', 'G', 'D', 0x05f1, &delay_200_500_e200_d200, "Unknown= "), =20 - EDP_PANEL_ENTRY('S', 'D', 'C', 0x416d, &delay_100_500_e200, "ATNA45AF01"), - EDP_PANEL_ENTRY('S', 'H', 'P', 0x1511, &delay_200_500_e50, "LQ140M1JW48"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x1523, &delay_80_500_e50, "LQ140M1JW46"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x153a, &delay_200_500_e50, "LQ140T1JH01"), --=20 2.44.1 From nobody Wed Dec 17 10:44:45 2025 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A738195F28 for ; Wed, 10 Jul 2024 17:05:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631123; cv=none; b=mfL24QKNqx4ufmUrFY47AH2s1DTgJd5la+LH+/4OQhRzdzccrjludB7JjJthZvtaQhO9GqB6q8Z0DCTYz38MffpBZ9WxSLVHzuwGjNwLVL6D8W9EUFOgRwsCrjyoKvTjCx2NuHYR0OS265/3LlkAHxK0ksV3khppkDKlUmUcVM4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631123; c=relaxed/simple; bh=UtGbOemBnLSiS/SSxde0/IPn7E11HeciK/KMJx5zgzg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r3wYq7rOmuSLBYoPvyKwRd0sLqWRb+kGfnOf8au7tzL+LRRjvVVjT8ODlvPU7qpMQYLKb/bJpKPlI2s1fPtvFbXmBB1tm2fKa1wl3bxPaH/OvPoNcvcEBP3a8Q0el4pqVVl1uE7HicEaXUzfB7cmgVamjjFj1GDwkbgQIN6FVnM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LsLq3ko0; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LsLq3ko0" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-52e9fe05354so9666219e87.1 for ; Wed, 10 Jul 2024 10:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720631118; x=1721235918; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ejuDXxzDzIH7zcxYcOPWRk3uTUuzsIoqRWToUCtONmU=; b=LsLq3ko0dEzIxVV03b/Sxfq0ohjNb7DdPmSl2uFnq3WU8jJ13/fccWpT/ATmUPgcuK k+Csu+TO8PGmCRyBNyasjp2FDjQ6cdZ0QWIkNL+nE6vkuo8WHimXlRTY/p1FfcfgJw77 56F45oodFpoGj+RMHwrm/oso9eAwGI7HNKdFS04ZzT1Dl6LYrSiPlCI+Tu9v6AdfNo01 MG8DlqovWQHyPCVAoIFBCM4aZsHPWJFf19TJQodeKj9G7fN94BMGYuwI7ekFHJ7b9GXa LmcUNCVAjfqLIVOmox8yTG6IhYL5ef86ZbR/j/j8VUUohaZxhlaRGoG8deaQXsplmYTt Sc2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720631118; x=1721235918; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ejuDXxzDzIH7zcxYcOPWRk3uTUuzsIoqRWToUCtONmU=; b=JL2YeMEeJ9RyHmkaP9Tn96kvD13dkESMC3XeUlY9PiDKYiNO1f/m/RID+g0BKnbgvx FIGibk/R/t080RQ5ZIo4pZDTFbtYl99pSJPfO4c/uYLmMhjaJRO7zfhQBIC1AY53T60t b3ELJFuN6uKWKy881pF6DXWwZXNfq75bMf/CGJ/zC0am0jk+E6tCDBLSPgA4cO9t7sBz t3qTX891jzcGjbfsIwZuCRp3LqA/g19Lih8m5P8OYC24jVuA7RCibHxHd6EUIsdKhipS kDMorUVtn4kHRVUlMia7CW46PFc4O+GA5VMruuY45gODX/TM2AQmPTFfuryBTHM5mqHd 0etg== X-Forwarded-Encrypted: i=1; AJvYcCWwt3lYqsB+CvoNO3UdMPFfxhWsxQozLBX3FNC7UE3ulQHqECn/ZARkrEJ/ckX1nhICbzezjiH8FDudJEaAKDEI3rrT8dEBS0XAOF0Y X-Gm-Message-State: AOJu0YxgOrufICjlJAgf+zsepH8YGZy1NhZqC61n79bdN3w3yNf7pYMV ES9aWD8EU1NyKpqy459DAWodOCnYgxyGRhG53r9srwyND4Z4GP3h0G+Kui4nRb9WC8sU7ZSkL+V v/OPTrw== X-Google-Smtp-Source: AGHT+IEdzDMqSpFrgPIKMoDSkhiU2e+ql+AL5vU9wurvK32RxWDhsTOWJlgEkSrVCpO+E3+Am+YAjQ== X-Received: by 2002:ac2:4281:0:b0:52e:9471:e533 with SMTP id 2adb3069b0e04-52eb99d5fb9mr3803124e87.66.1720631118372; Wed, 10 Jul 2024 10:05:18 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:65e6:93ca:5f80:ea9b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7dedfsm5838446f8f.24.2024.07.10.10.05.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:05:18 -0700 (PDT) From: Stephan Gerhold Date: Wed, 10 Jul 2024 19:05:00 +0200 Subject: [PATCH 4/5] arm64: dts: qcom: x1e80100-crd: Fix backlight Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240710-x1e80100-crd-backlight-v1-4-eb242311a23e@linaro.org> References: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> In-Reply-To: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 The backlight does not work correctly with the current display panel configuration: It works after boot, but once the display gets disabled it is not possible to get it back on. It turns out that the ATNA45AF01 panel needs exactly the same non-standard power sequence as implemented by the panel-samsung-atna33xc20 driver for sc7180-trogdor-homestar. Switch the panel in the DT to the new compatible and make two more changes to make it work correctly: 1. Add the missing GPIO for the panel EL_ON3 line (EDP_BL_EN on CRD and enable-gpios in the DT). 2. Drop the regulator-always-on for the panel regulator. The panel does not seem to power off properly if the regulator stays on. Signed-off-by: Stephan Gerhold Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dt= s/qcom/x1e80100-crd.dts index 6152bcd0bc1f..7d6800dd9b8a 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts @@ -268,7 +268,6 @@ vreg_edp_3p3: regulator-edp-3p3 { pinctrl-0 =3D <&edp_reg_en>; pinctrl-names =3D "default"; =20 - regulator-always-on; regulator-boot-on; }; =20 @@ -724,9 +723,13 @@ &mdss_dp3 { =20 aux-bus { panel { - compatible =3D "edp-panel"; + compatible =3D "samsung,atna45af01"; + enable-gpios =3D <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>; power-supply =3D <&vreg_edp_3p3>; =20 + pinctrl-0 =3D <&edp_bl_en>; + pinctrl-names =3D "default"; + port { edp_panel_in: endpoint { remote-endpoint =3D <&mdss_dp3_out>; @@ -785,6 +788,16 @@ &pcie6a_phy { status =3D "okay"; }; =20 +&pmc8380_3_gpios { + edp_bl_en: edp-bl-en-state { + pins =3D "gpio4"; + function =3D "normal"; + power-source =3D <1>; /* 1.8V */ + input-disable; + output-enable; + }; +}; + &qupv3_0 { status =3D "okay"; }; --=20 2.44.1 From nobody Wed Dec 17 10:44:45 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA931195FEA for ; Wed, 10 Jul 2024 17:05:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631123; cv=none; b=laAcPwF2haD8M6yK+tcDwdlpDykCJXG7RuJgXPEgcIsI8Tlh7rK0kDlLVHogc1y0O/TzQBgYu6VOcf3te4Lj/vjpTrO1wyb0CIWDYaSjaK1qPEnK2YktBwQgseKOuIpVIF2hlGC7rSw6gdSe4zHg/3dC9cnn8IvjLo65LzC1hfU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631123; c=relaxed/simple; bh=qR1uns0P44537MoqBjAHf1EyiKDwg3hxEEorjfsnBX8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fuq2ZppjNBmEsdDgPa+FRWhJcIY5q0L3ySmycGmlLsC48uuMT7AI5Bc7cWdT+A5ahZMRSh38fNeOwSLHKqcLYvhYWBaYxWi1UjsVHU9jy4hFk+rgn197rN/010sZ0GUYObfbVyWHLim78xcExn8GJO0oFQbPtyg3gxQkTafRODo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ghpt6v2u; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ghpt6v2u" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4266ed6c691so17528855e9.3 for ; Wed, 10 Jul 2024 10:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720631119; x=1721235919; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qJL9ctqEQ6EbrQ1caBlXUSKz2PPn/p138eO0sdvXuFQ=; b=ghpt6v2uCKCccrj5MSnJMi4VyrCY7dmJIm3O2xQP3o0wf9kvp+O9Pr4+B66Ko6bwNq wnlSSWc5wxDVmRYk6qQF8BAirQrreim5cjj6Eaq8Vjn/YH9hjjfw/N9DWtto2268qLYs TXaVUa8Pwl8wqS6iUuCFDzX7NYcRfp29mKbQFQM2vRT1cOXZprIAsyOnLlkf6jXJqO9E 8JZqdEznAgQr2XZEX6KzAoy8XrPSDCbNZC3pP/jIDU3ZumzD16t4y5oPtqkbqgdxpUrD Xfr9+Bc1x6wvZBdwMdz2Wfs1MyfALsyjLaAoAwiiQ1gOADaFrBC9IYOmijTZyAmiyvO7 ZfYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720631119; x=1721235919; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qJL9ctqEQ6EbrQ1caBlXUSKz2PPn/p138eO0sdvXuFQ=; b=OyhH6GAMxqarlHf/oTSL+j5X2LnvOFd7LuYedukPSsjfQAeYRbD9BGHBv6tM1RQyUf KU1qchQIBvsA6YjCLaw4BWmZPR339n4xUP+cZ7zm8MdOF4VLnr+nSVRZ0Fj1h8YnhEkb le69C0nGtpNy2XpMahwiDZWm7ZTPrF4JApsesBZ3wmynDDYT3WKhwtFDcWj3sx04HcW1 sXI7tOuo3omaJbT619pWmlDAbu0hxSFtZr+yS3Jpnf6LQXMW+zLBdxyzfUnPK8fUZR4o Za+EJ/hvS3YPuyxd5ujw9mkkDRwMP+gjHqSVVdOl0L5w47jw1xYVVA0kk6bM456/K/iQ rhDw== X-Forwarded-Encrypted: i=1; AJvYcCVUyPduKy+1koDEpL3McWa9Q22gZwSnPnmPnUn7fiwi5K47K+LKNfReDq1Fw2z4D2KgTVE6jJPnKj+glbj9z6NkCAAYVcSKPhG+47mG X-Gm-Message-State: AOJu0YzFGcyqCuTp+7ybhufUuZDNcHGUGep53v4CWArzI6Yaa0Gvx26s ey3P6ldQmdF+6gX2r3diY1y8RDAhVvad56ikFNBPOM6PB33KJ0jdeUfipMrLeKg= X-Google-Smtp-Source: AGHT+IH53Sy5DifFmLWeIWcstw3PzJyB9vgs2HFmeKb0z3bxjT4/dpNjOk8wqX3EUyluYvb65bRiiw== X-Received: by 2002:a5d:4811:0:b0:367:8a3e:c127 with SMTP id ffacd0b85a97d-367cead9253mr4193011f8f.63.1720631119088; Wed, 10 Jul 2024 10:05:19 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:65e6:93ca:5f80:ea9b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7dedfsm5838446f8f.24.2024.07.10.10.05.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:05:18 -0700 (PDT) From: Stephan Gerhold Date: Wed, 10 Jul 2024 19:05:01 +0200 Subject: [PATCH 5/5] arm64: defconfig: Add CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240710-x1e80100-crd-backlight-v1-5-eb242311a23e@linaro.org> References: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> In-Reply-To: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 This is needed for the display panel to work on the Qualcomm sc7180-trogdor-homestar and x1e80100-crd. Signed-off-by: Stephan Gerhold --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 5c9fcf9ad395..9572c337ec29 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -889,6 +889,7 @@ CONFIG_DRM_PANEL_KHADAS_TS050=3Dm CONFIG_DRM_PANEL_MANTIX_MLAF057WE51=3Dm CONFIG_DRM_PANEL_NOVATEK_NT36672E=3Dm CONFIG_DRM_PANEL_RAYDIUM_RM67191=3Dm +CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=3Dm CONFIG_DRM_PANEL_SITRONIX_ST7703=3Dm CONFIG_DRM_PANEL_TRULY_NT35597_WQXGA=3Dm CONFIG_DRM_PANEL_VISIONOX_VTDR6130=3Dm --=20 2.44.1