From nobody Thu Sep 19 23:12:09 2024 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 929B210953 for ; Mon, 8 Jul 2024 19:43:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720467812; cv=none; b=mf+jgz8z1/1BachrFrCxZF5nYE7s/TG878XXFkqTKg+aHC9eiYoe/XYTYUglrQtu9BiwPC3yI1/032ZxJ3MFWtfkoG6hPG64FSGcoiYnnzUgdBScZdTeMckVQOhYCo9P93vhgpl6e87xL3GpqJEwRFgvrDB+L/xe42q4l6y8z44= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720467812; c=relaxed/simple; bh=+rPOdVxxZZGW2sv/TAxO/m4SPgVBlYvpsQEukQOBf7E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=VyAleerrWCOBQFMx5TJ/X3H/M7ERHTdnGKCX7ICoaZrUofESE35plzfJmIZKnUmIcr9mCWVRtPoqmyTM2K5GWAPxDTqNNXJyqQwREQxxnwEmWdUdfxAo4y87doOkifmCtqOXVlJIU1uHSv+0Z8YRi7zc2ddVQAiSg5g4Gux8wWQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Xr5Dcd4Q; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Xr5Dcd4Q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1720467808; bh=+rPOdVxxZZGW2sv/TAxO/m4SPgVBlYvpsQEukQOBf7E=; h=From:Date:Subject:To:Cc:From; b=Xr5Dcd4Q9woGLlxWKghbEDLCUucBe6HkFTW13hjInOqEXYSPQID1w3spxYVHVQZY6 8Vzpz/2FXvdH4XOz5Cv62/GWI4S+qgRoOYeOlI90p9pOpT/YBIebapDxBSNooFUu+c WUuUKdZDV5Psg4nF4iOF2uxnn3DTIv/KRUuL1fLT/+58WsPgoCYreT3XPMDf8naxIz 3VR5g6GYTexpMkm6Ql4LrCpAiBDiUYH+KHMyyl2qNma+kK/J+0lrk6zU5Ytx7hBi3I 324rPqrBT194S79dlij6If5rf6lu9lhkfrhg5EATKbZfX+kYTR0qicsRtjtLus+Arj x2CY9AYZBLTjw== Received: from [192.168.1.242] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id ED87A378042B; Mon, 8 Jul 2024 19:43:26 +0000 (UTC) From: =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= Date: Mon, 08 Jul 2024 15:43:15 -0400 Subject: [PATCH v2] nvmem: mtk-efuse: Only register socinfo device if needed cells are there Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240708-mtk-socinfo-no-data-probe-err-v2-1-7ae252acbcc2@collabora.com> X-B4-Tracking: v=1; b=H4sIAFNBjGYC/43NSw6CQBBF0a2QGlsGGgjEkfswDPorFaGLVBOiI ezdlhU4PG9w3w7JC/kEt2IH8Rsl4pihLgXYUcenR3LZoErVlF3Z47y+MLGlGBgjo9OrxkXYePQ i6Lq27eumdrZXkBuL+EDvs/8YskdKK8vnvNuq3/pveauwwmCUtq7WTWfC3fI0acOir5ZnGI7j+ AIAesF7zgAAAA== To: Srinivas Kandagatla , Matthias Brugger , AngeloGioacchino Del Regno , Chen-Yu Tsai Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= X-Mailer: b4 0.14.0 Not every efuse region has cells storing SoC information. Only register an socinfo device if the required cells are present. This prevents the pointless process of creating an socinfo device, probing it with the socinfo driver only to ultimately error out like so mtk-socinfo mtk-socinfo.0.auto: error -ENOENT: Failed to get socinfo data mtk-socinfo mtk-socinfo.0.auto: probe with driver mtk-socinfo failed with= error -2 This issue is observed on the mt8183-kukui-jacuzzi-juniper-sku16 platform, which has two efuse regions, but only one of them contains the SoC data. Signed-off-by: N=C3=ADcolas F. R. A. Prado --- Changes in v2: - Added missing include for of.h - Link to v1: https://lore.kernel.org/r/20240708-mtk-socinfo-no-data-probe-= err-v1-1-fb2acd3a47bf@collabora.com --- drivers/nvmem/mtk-efuse.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c index 9caf04667341..74def409bc20 100644 --- a/drivers/nvmem/mtk-efuse.c +++ b/drivers/nvmem/mtk-efuse.c @@ -11,6 +11,7 @@ #include #include #include +#include =20 struct mtk_efuse_pdata { bool uses_post_processing; @@ -60,6 +61,8 @@ static void mtk_efuse_fixup_dt_cell_info(struct nvmem_dev= ice *nvmem, cell->read_post_process =3D mtk_efuse_gpu_speedbin_pp; } =20 +static const char socinfo_data_first_name[] =3D "socinfo-data1"; + static int mtk_efuse_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -69,6 +72,7 @@ static int mtk_efuse_probe(struct platform_device *pdev) struct mtk_efuse_priv *priv; const struct mtk_efuse_pdata *pdata; struct platform_device *socinfo; + struct device_node *np; =20 priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) @@ -92,10 +96,16 @@ static int mtk_efuse_probe(struct platform_device *pdev) if (IS_ERR(nvmem)) return PTR_ERR(nvmem); =20 - socinfo =3D platform_device_register_data(&pdev->dev, "mtk-socinfo", - PLATFORM_DEVID_AUTO, NULL, 0); - if (IS_ERR(socinfo)) - dev_info(dev, "MediaTek SoC Information will be unavailable\n"); + np =3D of_get_child_by_name(pdev->dev.of_node, socinfo_data_first_name); + if (np) { + of_node_put(np); + socinfo =3D platform_device_register_data(&pdev->dev, "mtk-socinfo", + PLATFORM_DEVID_AUTO, NULL, 0); + if (IS_ERR(socinfo)) + dev_info(dev, "MediaTek SoC Information will be unavailable\n"); + } else { + dev_info(dev, "Efuse region does not contain SoC information - skipping = socinfo driver setup\n"); + } =20 platform_set_drvdata(pdev, socinfo); return 0; --- base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233 change-id: 20240708-mtk-socinfo-no-data-probe-err-d7558343dc82 Best regards, --=20 N=C3=ADcolas F. R. A. Prado