From nobody Sat Feb 7 18:20:44 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.5]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D1F891BF3A for ; Sun, 7 Jul 2024 11:28:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720351729; cv=none; b=PxdcFR38l0apfLqb155Z575WufD+42XLLhbxfgQGJrtNlbPv1qhvT8Pgx+BC6ZUgGiZmKTgC7ByMyBLEWR9auhPQnCLtLgOwlq6sXHDCqliesWeVDHwx6jNGL19464AmKlgDlJpdyMBxS2L4Jp081XiGyA/EYKNM5KG2lAIqVhM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720351729; c=relaxed/simple; bh=viuQQvnl/HEyojFbTu89HVjIV3n8YtrYoWR0Fl0RIa8=; h=From:To:Cc:Subject:Date:Message-Id; b=jvV3Tt86+7Fvj/5Rdd0ktk/a7Fm6TmIjgcIjdHom2rryZMnPfn4B6MRts5wtrqxBru8z8y6JRIwPJknfzdzbEqBmwedPF9ljZKC6B6EgudjuPVvhfHH3u5RmK4uYWTaMXiFy+EePHwcY8dT+9KHK3nTuXAbyUQVbO8lA775l6mk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=ArYpnNnd; arc=none smtp.client-ip=117.135.210.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="ArYpnNnd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=tmD7p373BjyCkvXoT5 52zWEwEpPq5fuGGKFor+qCn8Y=; b=ArYpnNndommHx49dfJ8zSaLWrj15vs+ve8 HJAqnDmkQutctLfaIv5mY4GvgB4/jICljfpsafYt6dJgxKrwHiPjrjUex5psP6vt HFCeilGOlAHCM3caPzTFzN8jp35HnaiM6EeOBjig21Sz889czo5shiirmdONwAJP EkTyIb7wM= Received: from localhost.localdomain (unknown [114.92.56.131]) by gzga-smtp-mta-g3-3 (Coremail) with SMTP id _____wD3n0C4e4pmtMjXBw--.31032S2; Sun, 07 Jul 2024 19:28:04 +0800 (CST) From: Lizhe To: gregkh@linuxfoundation.org, rafael@kernel.org Cc: linux-kernel@vger.kernel.org, Lizhe Subject: [PATCH v1] driver:core: no need to invert the return value of the call_driver_probe() Date: Sun, 7 Jul 2024 04:27:38 -0700 Message-Id: <20240707112738.3380-1-sensor1010@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: _____wD3n0C4e4pmtMjXBw--.31032S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Gr13tw4DCF4DWF13AF45Awb_yoWfJFg_Ca 17CFyxX34I9an7ua48ZwsxZrZ29FWxWr1kur4Fgwn3JFyUXa409F1DurnxJr45WrZ7uF4D Cry2gryxu3WakjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sRKGQ67UUUUU== X-CM-SenderInfo: 5vhq20jurqiii6rwjhhfrp/1tbiSB8Vq2XAmJL2-wABsO Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" If drv->probe() or drv->bus->probe() returns EPROBE_DEFER, then there is no need to invert the sign. Similarly, if it returns -EPROBE_DEFER, no sign inversion is needed either In the probe function (either bus->probe() or drv->probe()), there is no return value of EPROBE_DEFER. Signed-off-by: Lizhe --- drivers/base/dd.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 83d352394fdf..cbf7fe6aa8e0 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -664,11 +664,6 @@ static int really_probe(struct device *dev, struct dev= ice_driver *drv) if (link_ret =3D=3D -EAGAIN) ret =3D -EPROBE_DEFER; =20 - /* - * Return probe errors as positive values so that the callers - * can distinguish them from other errors. - */ - ret =3D -ret; goto probe_failed; } =20 --=20 2.17.1