From nobody Mon Feb 9 01:48:46 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FD211442F0 for ; Fri, 5 Jul 2024 07:59:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720166346; cv=none; b=J3lOxgxdTe4icGFspoJgfTXjA304yKynnFJZIC0KtDWwpFPtohmufTpAzXNCWbuZAZsH3uUIG77pmfsYsehliaKWtfvQHXIMoZdVVsDLr6kDgXQO8pTboWqECn5Bt6wxecFAatvYbOt/JfgUV68d0kmJb0CQ+VnfcKevyY33gTI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720166346; c=relaxed/simple; bh=k+nb52xgZXJXsYaSnHBpWDVDQGynYhvn3tPYZFKBG5Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JBSm+zmSrkbB9w1OH0aD6DLbTRbqzF5V9ISvVFkYANMVrMShfxNcmminzwDQy0/u0rMhdPYnoD3TWux6hbXtZK5jL3Lwum2bB1F8sYbC4iD+eU2YdMfuUlNWO243o8bTbp5q4jxFE3Ti9E7rr70+X75OF7IAIT4Bba3CvOO5hQk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=H0VY6lVJ; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="H0VY6lVJ" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-426526d31a3so1681165e9.1 for ; Fri, 05 Jul 2024 00:59:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720166343; x=1720771143; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/CUMQGL5WSCg+ncFb1/+wfOD2d0NKg2if04eVfZHfzc=; b=H0VY6lVJ98GSDKVDRvt9YcdClDATALSz6jX5qwjLMQwWrtAeNKiE2A2YvbGFyhnVTp zpsq96C53tEeI63EZnVvhkKeUFHzw7yOahL60anHwcum16Lkz4Nf4La9GZbRWYzj7ZGo VkMbNb2PH3InduQTGNoF1XRoFzgVc1lNs3nLWa1RMt85QX86Svj0dtPLBoj5Jj8ERlJy 4ti6/j/1d1GZn/LiSrZdAnon+6D1wEkr7g/797J3zc3BUg739peqguL9aJl7AqkR5i7G qY/oxOFRnuP+SU4siz9x4r07ApkIU7CqeBrxuQLOIQpnx+JWnJpNcXXEssX8MzRtP4JT CAnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720166343; x=1720771143; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/CUMQGL5WSCg+ncFb1/+wfOD2d0NKg2if04eVfZHfzc=; b=WrnK03FG1oU17h3Y6L1dkuvGuWMs8Z7lz9X8Oe6anlXWD7HK/76EaAUvkw56ILmNdR mKLarCf4y/YFwTwklcAb/EW2H8SAGGFhsoIYHL9IuemswgdYuHKVEgh++7LG01DOEW8a VpvvjAzCqtgG5rR/loZprWxIqXPBgRx7GiCobKlt0oWGID7bXfgBudBa0ts9NUbg8/s5 JMaCeHq42ziQcoM3t+L6qsO9dSJ26IVrrW5Vtbp8K/7mRjvX4stDmJo6O6eP1B8X7eU6 Voc5njo7/NMKdElHL80VXvDVcmgbqc5pPQFTOFrCAN4WUtlte1lDHYNq8YDtqJpWdjgT jzPA== X-Gm-Message-State: AOJu0Yz1apjH5VbdSjJioMXU/rE4gfRVDac07PwcIDOXYaP6/L2wYo/m RcmbvEikWAwgts1aOrYDQiRq2c6Piv5xwD24Cz4KXy9tYLNkUgZm8Rj87dIIK0k= X-Google-Smtp-Source: AGHT+IEWjY8zD9BufrsEhEqK8tWy5nqJA+CiLwZWAGkruz1YZsp4w1bgxeg4b9IrbrEbs4oBKQUmKg== X-Received: by 2002:a7b:cd19:0:b0:41e:db33:9a4e with SMTP id 5b1f17b1804b1-4264a41f86fmr27382825e9.39.1720166343484; Fri, 05 Jul 2024 00:59:03 -0700 (PDT) Received: from srini-hackbase.lan ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42651531f1fsm15315485e9.0.2024.07.05.00.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 00:59:02 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Thorsten Blum , Arnd Bergmann , Srinivas Kandagatla Subject: [PATCH v2 1/6] misc: fastrpc: Use memdup_user() Date: Fri, 5 Jul 2024 08:58:55 +0100 Message-Id: <20240705075900.424100-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240705075900.424100-1-srinivas.kandagatla@linaro.org> References: <20240705075900.424100-1-srinivas.kandagatla@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1361; i=srinivas.kandagatla@linaro.org; h=from:subject; bh=1f72f6Oq6H/lspXXzDtpAY/Ia92lu+L/z56Kxb59lGA=; b=owEBbQGS/pANAwAKAXqh/VnHNFU3AcsmYgBmh6fDSfE5gfxQc3u8tTzwRZuEugV8adc6Rd+qc k5UagYJig2JATMEAAEKAB0WIQQi509axvzi9vce3Y16of1ZxzRVNwUCZoenwwAKCRB6of1ZxzRV N24kB/0RY+uTR9go4oNftnPzQvtN/TgqSitfJO/621L2JbDGrYk9E3Z2DWH+ML23h8wvaH1gZ24 xTB+ZklmTcChFhhLOeGG/zh7vIU/6EblMI1p6y4fTX3/Zs3q2gA4X0F9hfEyNmPLlUOKFGkweOl fQDYh0d3J15ZssZ1QNrTgaXbmGYdm2s9m0sZdLgH4uyZZeJHK6ywDNREB4jN0Sfy3HqS+mDC77L Tgw+aG4ZfM+QNtkq9yej1NgGZTyOFKyYSyn3QxDCYRqecC9O9PUEkAO57Ao85jRmTz2zVusSp8+ cqsmB8ca0I3vRgRPy6a0/WWF7oZ1Z6W+4/cVVGe2neHQY/gR X-Developer-Key: i=srinivas.kandagatla@linaro.org; a=openpgp; fpr=ED6472765AB36EC43B3EF97AD77E3FC0562560D6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Thorsten Blum Switching to memdup_user() overwrites the allocated memory only once, whereas kzalloc() followed by copy_from_user() initializes the allocated memory to zero and then immediately overwrites it. Fixes the following Coccinelle/coccicheck warning reported by memdup_user.cocci: WARNING opportunity for memdup_user Signed-off-by: Thorsten Blum Acked-by: Arnd Bergmann Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 4c67e2c5a82e..694fc083b1bd 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -1259,17 +1259,12 @@ static int fastrpc_init_create_static_process(struc= t fastrpc_user *fl, goto err; } =20 - name =3D kzalloc(init.namelen, GFP_KERNEL); - if (!name) { - err =3D -ENOMEM; + name =3D memdup_user(u64_to_user_ptr(init.name), init.namelen); + if (IS_ERR(name)) { + err =3D PTR_ERR(name); goto err; } =20 - if (copy_from_user(name, (void __user *)(uintptr_t)init.name, init.namele= n)) { - err =3D -EFAULT; - goto err_name; - } - if (!fl->cctx->remote_heap) { err =3D fastrpc_remote_heap_alloc(fl, fl->sctx->dev, init.memlen, &fl->cctx->remote_heap); --=20 2.25.1 From nobody Mon Feb 9 01:48:46 2026 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C63CB145355 for ; Fri, 5 Jul 2024 07:59:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720166348; cv=none; b=cL1Bhb2LPOA4yIUMHNf4NqhfsR2tsd4D7//wSpQyFzgx6pM/YnRsvLOHaoElykQTxzHMmJM6Krzh4N18ehLjfSoXxS5wLH49I7U45PTiHsvE+yUgkvUShjuVwLeCwHLkvPIGSJEtJ1nTvTCI3r2i8jQQWw2m2FGnZYE9OYnW0yw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720166348; c=relaxed/simple; bh=295SPVymILL3zztEI9wBshTd+kDs2G1FpXLFoa0IdoU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=elp9MRwJFel7QdqrSkLkp3TzYK3bdb76DvQukozSunntbQ5QdrV9ZUFhql+V5r7bxHcxwsI6e8AEOQ8vu0HBVTrCc8wdI2W/JSeICqOa0e+9eTi0CszKLgE+yIwQBSWlaWix5H6UmAeOsWMqixmIAeih2bLHEX0wBYBFElTyRWw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lvNSkBtc; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lvNSkBtc" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-52e8b27f493so1592972e87.2 for ; Fri, 05 Jul 2024 00:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720166345; x=1720771145; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=haSCOpPQsh3zt9hsGGiD3rlfBhoqaA0P3zbntxRYf08=; b=lvNSkBtcajm0YJtkZF0PNLRgMLGWHh6twS8xtiJLhuWl34egpWaFuQTh3o08x9dIFs J8EkjSyEzxK4Fvif0dnsaV5+lARQso4UNE/+bLA3kpDWrZBF2QhwvC82kJ7pdTBMUAp6 +jFsaejdUO+zQsJFLMkHyO94Cvcuij7nPnmhYT+yGvWBGWtaSWEiS/q5i1agrI0vXc9y 6DnlnGPwtK4meaZOUUMQnMGSRKXdAGO9wAV4iHVGPb+gFzBBS7qDYVOyRWm0Tu9bPLq/ VHJck0Ux66sHCDEcIp3/fBQryYuG/3MkAc3bL9TxIuM59/iXcWzB08HwQfMtdgP2+XNH gPNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720166345; x=1720771145; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=haSCOpPQsh3zt9hsGGiD3rlfBhoqaA0P3zbntxRYf08=; b=FGOBEOSw3VzT2mTlYDrmIaMLC2DlQaxoY8bdQpu9kD4gZYMh8vOhEuTmhu7LKHmIE9 0uccV3cU4Ob6DV6SVUns7tvCXzgUDxTgADrkVO8a43TEfb+Z8fQr1KYI9igG4WmydlGZ pKKXNTRHmXgc/srmb9PJ+NSb5EegsrfxBh1DmGDMhxrhmKsH6o2HvYZyQD9WgKGV14vk hhmK61mDrmvNjZrcJDALyMbfDXpLgGmVXaXSwEBtzkNpOEwYP3ASCXEH+wMnaQMNh3PK njDeHWyNOs7fcrHfwOrgmaNha7Ck9x9+07/87HEiFIFYnRRV/YxNnj09EVDB16vLff3W 4Pbw== X-Gm-Message-State: AOJu0YxKjnuuuwzMjRFK7ROjnjSOBeDwauYpm380pJXdhjiVe0vI1ZNA n/U6EHmSk5vbZGwZwYn17Wjc+F/sQFXlEx4shNwwT2SuERH7tNgL1/ACQW/LWSUP0nviKnaqYub SuRQ= X-Google-Smtp-Source: AGHT+IG7UGU0JGtWsgYnsPyEwjNgDSZ23V7Wc+m8d7CHtWqWl0vA2ZottB+nj/tder7/tv6MwlwvUQ== X-Received: by 2002:a19:f51a:0:b0:52e:7688:2817 with SMTP id 2adb3069b0e04-52ea0628ccamr2551457e87.17.1720166344872; Fri, 05 Jul 2024 00:59:04 -0700 (PDT) Received: from srini-hackbase.lan ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42651531f1fsm15315485e9.0.2024.07.05.00.59.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 00:59:03 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Ekansh Gupta , Dmitry Baryshkov , Caleb Connolly , Srinivas Kandagatla Subject: [PATCH v2 2/6] misc: fastrpc: Add missing dev_err newlines Date: Fri, 5 Jul 2024 08:58:56 +0100 Message-Id: <20240705075900.424100-3-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240705075900.424100-1-srinivas.kandagatla@linaro.org> References: <20240705075900.424100-1-srinivas.kandagatla@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2912; i=srinivas.kandagatla@linaro.org; h=from:subject; bh=pdIoWa5mSqtc2w+5UDfLbSe20Voxx74ohoojsJLjHVo=; b=owEBbQGS/pANAwAKAXqh/VnHNFU3AcsmYgBmh6fD3my50BjgDkdGvxFhdDjQ7eRRb+Mwcn1WX aaNXIeVEdqJATMEAAEKAB0WIQQi509axvzi9vce3Y16of1ZxzRVNwUCZoenwwAKCRB6of1ZxzRV N3GaCACjDx3xOGAikoB2TJqqZHPWHPAhTe58mA44sWsrMgGVi8rMfp3ck7r08sIJCUPdmaxXE1B wgdjg9hESahR86mIP9Fs8vqhNupCBQZYWxp6SMd8yBQLh/M9FUv541qrMpScGuUxYScyLVo3bbc 1XEdMpkxF3M+Xig28pFkl91WCNIekxRXq7uDptWzpCjQ5bBPsvTe5LSXUwZBDFZvoqHA1USpHQF if3qPsZxF2j4SFOltSyKBvLXFncSpoChrFp+mzE3jSQXigO62WXaZWrB7dfoRdAw0snDSQCRFia uDZC17Ho4QLqGlUK9xUz8e7lOrJ2RNNQWSbb8JcHziNb7dk+ X-Developer-Key: i=srinivas.kandagatla@linaro.org; a=openpgp; fpr=ED6472765AB36EC43B3EF97AD77E3FC0562560D6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ekansh Gupta Few dev_err calls are missing newlines. This can result in unrelated lines getting appended which might make logs difficult to understand. Add trailing newlines to avoid this. Signed-off-by: Ekansh Gupta Reviewed-by: Dmitry Baryshkov Reviewed-by: Caleb Connolly Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 694fc083b1bd..2653a193ff2f 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -325,7 +325,7 @@ static void fastrpc_free_map(struct kref *ref) err =3D qcom_scm_assign_mem(map->phys, map->size, &src_perms, &perm, 1); if (err) { - dev_err(map->fl->sctx->dev, "Failed to assign memory phys 0x%llx size = 0x%llx err %d", + dev_err(map->fl->sctx->dev, "Failed to assign memory phys 0x%llx size = 0x%llx err %d\n", map->phys, map->size, err); return; } @@ -816,7 +816,7 @@ static int fastrpc_map_create(struct fastrpc_user *fl, = int fd, map->attr =3D attr; err =3D qcom_scm_assign_mem(map->phys, (u64)map->size, &src_perms, dst_p= erms, 2); if (err) { - dev_err(sess->dev, "Failed to assign memory with phys 0x%llx size 0x%ll= x err %d", + dev_err(sess->dev, "Failed to assign memory with phys 0x%llx size 0x%ll= x err %d\n", map->phys, map->size, err); goto map_err; } @@ -1222,7 +1222,7 @@ static bool is_session_rejected(struct fastrpc_user *= fl, bool unsigned_pd_reques * that does not support unsigned PD offload */ if (!fl->cctx->unsigned_support || !unsigned_pd_request) { - dev_err(&fl->cctx->rpdev->dev, "Error: Untrusted application trying to = offload to signed PD"); + dev_err(&fl->cctx->rpdev->dev, "Error: Untrusted application trying to = offload to signed PD\n"); return true; } } @@ -1280,7 +1280,7 @@ static int fastrpc_init_create_static_process(struct = fastrpc_user *fl, &src_perms, fl->cctx->vmperms, fl->cctx->vmcount); if (err) { - dev_err(fl->sctx->dev, "Failed to assign memory with phys 0x%llx size = 0x%llx err %d", + dev_err(fl->sctx->dev, "Failed to assign memory with phys 0x%llx size = 0x%llx err %d\n", fl->cctx->remote_heap->phys, fl->cctx->remote_heap->size, err); goto err_map; } @@ -1332,7 +1332,7 @@ static int fastrpc_init_create_static_process(struct = fastrpc_user *fl, (u64)fl->cctx->remote_heap->size, &src_perms, &dst_perms, 1); if (err) - dev_err(fl->sctx->dev, "Failed to assign memory phys 0x%llx size 0x%llx= err %d", + dev_err(fl->sctx->dev, "Failed to assign memory phys 0x%llx size 0x%llx= err %d\n", fl->cctx->remote_heap->phys, fl->cctx->remote_heap->size, err); } err_map: --=20 2.25.1 From nobody Mon Feb 9 01:48:46 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA626145A02 for ; Fri, 5 Jul 2024 07:59:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720166349; cv=none; b=XlApfKGaTmAvCjDkvbiLclGFH9jVpy8wegCIYKjdu23PJXFQYPCnN7NmDics7tgPWgeNsOWe4ShuvtIhxKTvwKsm82qTN2mMjrkX+GQLAxkjZ1miY/9W85h8FiOPGFEjhuyT6tzZEORHNuJo/2CcB2dTbiVAyzxGaC9GRaCgqzI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720166349; c=relaxed/simple; bh=3gDLIAYz181HJf9x7NRIIfS45OFCw170AEfBrtmppso=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dws18tC78NTaRlsxjXIoFGuLVHpB85Wsc084E5PE8x5JvLcm6I5RfgzvJVtuumhEFZiZZgnKSBQlxZQkkOkcetxSUNDsRZEWEFUSlR/kEwn7V/e6HcTdbCpHePXDqiRxuwzPfekcdS+SBBtrQWaf9dw9J+3D7g8f/oNh9vKUiPs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yfAkBtbr; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yfAkBtbr" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-424acf3226fso9846105e9.1 for ; Fri, 05 Jul 2024 00:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720166346; x=1720771146; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xkPsMuaXUEzhAdmrj0v8DKrJWfFPcAx0F2jdkDpzpDU=; b=yfAkBtbrkHVeX9OnV6C5KemHyUfzSIjl/Nlg50NuAlLPO20UOQHVVdXfUNCa2dxMDN iJ90tqLMwJxTwc9ICBFUGNBNatOpwOs4ZFcPTmy0jcUy5a5LwvIa95i6VhvJ6u7b2OaT zFOw83NOckCycPJGT4S++JkjEPk6ibHNTgSed9OSFXW9396CAbiPlhwC47Dg0h6uXLd5 CPoAgeQRIXvJZG8YUkwJltdnbwE/23Vn09+1urJTrPijKHiRmfpe1RB+dujTGF49LCGw 8OVF3jMQ+ckz1wMz0QB8jI3UOVYHpWNfljhNhboN4Y4C/b/0KSAAc44EvB0ZZAbvI4qw s0GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720166346; x=1720771146; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xkPsMuaXUEzhAdmrj0v8DKrJWfFPcAx0F2jdkDpzpDU=; b=mdX8a9B2syVq4Ncyb7O55Gr+jmi+tzknePfBFnrJYf3Vh2KpoIjkpz0qZPdqbK6geb y2eG37FqnWFuMnWtkAeEcUQIx5g797N38myqd/6b9Giy+AIUc8n4hi20me22WB7P1vfQ 98/i2lpZbuxk7XG/TS2mq86TSwQBG3DX2w7rJowbGHlBSO04drcdsJsJe7Sv2WQf25gx BCnJP1YoLlJXyOayOsyczuLR8D6Gsy8MD7ko+tQYD1+GXwi7nqB4b3gXzXCfPPU+sora aHYKXuaC7gCXtSrxJxw48nFzvYZmoH81bugxzThi/vpu1d0UKBR8oYLLLpoQGwWZ45a2 b2lQ== X-Gm-Message-State: AOJu0Yxpao0VIQ3kp0pPvpoe2ONUdZ9BwO2mv5q9iA364+jBLrZRgQHv dEzLTiptzyxv9Zg0HAjDKsTqYX8QIrAZHaSxF0pSh+jlNFeBYO/KzTyelp8UkRY= X-Google-Smtp-Source: AGHT+IHdmMNOpFSelfLc9kICdBxoLWK+HxCmentqwGdoFKjRq9tO6LN6/yXiOdT2rXq2NqIlPLBoGQ== X-Received: by 2002:a05:600c:4692:b0:426:5196:c8dc with SMTP id 5b1f17b1804b1-4265196c973mr6450895e9.39.1720166346234; Fri, 05 Jul 2024 00:59:06 -0700 (PDT) Received: from srini-hackbase.lan ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42651531f1fsm15315485e9.0.2024.07.05.00.59.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 00:59:05 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Jeff Johnson , Bryan O'Donoghue , Srinivas Kandagatla Subject: [PATCH v2 3/6] misc: fastrpc: add missing MODULE_DESCRIPTION() macro Date: Fri, 5 Jul 2024 08:58:57 +0100 Message-Id: <20240705075900.424100-4-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240705075900.424100-1-srinivas.kandagatla@linaro.org> References: <20240705075900.424100-1-srinivas.kandagatla@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=807; i=srinivas.kandagatla@linaro.org; h=from:subject; bh=O15qZdCPqj+aTpIHCNU5gY+gTtmu5dT/gYOiOPVz+lQ=; b=owEBbQGS/pANAwAKAXqh/VnHNFU3AcsmYgBmh6fDan0+3BEHGWpfX/0vThaLh/4ay2/y02f/R /6Qh80jFOSJATMEAAEKAB0WIQQi509axvzi9vce3Y16of1ZxzRVNwUCZoenwwAKCRB6of1ZxzRV N/aiCACMYX9fgiGrigvGoeejAOBh+E4VTTipEQBYDBLUi+VwMU5yF5Y8+NgUpGTMLQ5XQCSVNai qMhepaZqv6Fvz0B5uAe4HwFV0LcleRemvCvNIDUS0fjl6EZeV2ohKhQDP4pKwnXy8WtLJnA5s1Q Hefo+sUBot8mPKSKg/h2V7TdylzCWjZBAgfSzHBVtjyoln7HEEu/+FxdfN3o6exxyWOmddrpvl1 ziOtXeOtEJpeysEVZD7INJvaVFt4cHPjpGNYkVHwT2RxgpRYr361ZRu9em8kJ6OOy8weIWF5pW5 E1GQaimFxi2cdmK1HL4HytpRM9VQbttEWz/7KdcKqdUCHxGh X-Developer-Key: i=srinivas.kandagatla@linaro.org; a=openpgp; fpr=ED6472765AB36EC43B3EF97AD77E3FC0562560D6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jeff Johnson make allmodconfig && make W=3D1 C=3D1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/misc/fastrpc.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson Reviewed-by: Bryan O'Donoghue Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 2653a193ff2f..5fb302b8ae5d 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -2473,5 +2473,6 @@ static void fastrpc_exit(void) } module_exit(fastrpc_exit); =20 +MODULE_DESCRIPTION("Qualcomm FastRPC"); MODULE_LICENSE("GPL v2"); MODULE_IMPORT_NS(DMA_BUF); --=20 2.25.1 From nobody Mon Feb 9 01:48:46 2026 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B2D9145B20 for ; Fri, 5 Jul 2024 07:59:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720166351; cv=none; b=kzmJkrDJpQ3UJNTiLrdZX/GzThGs187JJ1VSqOxsl3ft7ulW6xX3Rzy/OyaxqGkqPinLvFju5FZKjpiKj5wdvaCIkMxYJ4sj4sLdKLemKSZBl38r4nnKyBPW1655RbNYAnbLFi5TLA5IXyJDmkv21xVpJJlsG0WEC8hcsZvx0Ts= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720166351; c=relaxed/simple; bh=rpGrIWoy7L3m8NGIRBoMhINKNndn2QfbZx7fdos1EQQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=U/XdZ1B8KtEb30mEo9nKi1Js5Gr0j/eMGPPRT1HEsJD+/wjh8tTEtp9hCrPRgbdCTBHZFKI0Vh8aV9IWz9u1U7k/+QNW2ZJIha89bg8QZ9li6INiJIe6Fk1qi6VXygSMH/+nV7cVx0fnIFzkVLj1A9IVtfkmPvAHqetrujjnJUs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HnvR032M; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HnvR032M" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-52ea3e499b1so741900e87.3 for ; Fri, 05 Jul 2024 00:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720166348; x=1720771148; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xJMsODzy4vs3aLpIbdr6SfS4EPENNYARdHRHbpGgNyw=; b=HnvR032M2xDqK9NN5J4uy6ILXuewV+iIEbZWq1t3QUyHAaCxU83Q5Hn0lzKMaOTWwH koLby8+Ib68Twy9i+TdQtN9sBv8M1ruMh0ctOA5QCLYqDRxs0b5xz8pVi9wvmOqo5KHX ky8lv7kIEpRbjOUSpMaGpzSkhODJW11RBPPVKx6KLD776rLcs0DqBYm11lBgTfJgN0rB 4f5Fh6mcBsel4FWD1V6JmmGWLpuQu8cIbVNZAnxCljanKwbU9Gc2KUswbl6vRBPFUysG kRTKpyglpvU/WUDZ1cH7VTzYc0t+u8ZQHOJCNDHim/sHtOjuSYdNddBztHb6WxjUIhng kicg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720166348; x=1720771148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xJMsODzy4vs3aLpIbdr6SfS4EPENNYARdHRHbpGgNyw=; b=X8RD66fbh0mM8K1sTuut9W1I1HoNZtgbdW5yOvywCrfOzW+BoynuP7ZhegV7QGmnBS NwVs6UMWn2jdc41GVUzH+3sdC8DqAB3KyO8lYcOg3zDs4BPnB1pQjMDEKEa+hKAQHrho tWBNHmfBdouH/ikTWA8/gt6za3xjri1gFg6OXZuciiFFc3mvE7rRyYodhj5adIOSXqAs xtDmBx6BbBBJKAYA2IXexavt8XnZxDW7LBo869jiFXGOGuz/xc5rw8hDKp1Ly8qN+wfH 2WrBXFMFu20s2MA6Mqrpaai4KlphH4QgkmQHEtzQSlT20bJTDkL+5hp/zeggktynTeg9 +yIQ== X-Gm-Message-State: AOJu0YxwNSQC3JfIihOsD5XZpH/t8N5iBZ9Mqe1UJhzshZJQ/2hUnbf7 TUMD0kYKLZJlP8XLUbhNGMP7YVa1LqSXfQNgoMIOKFTbPNUMv/Js5g1VxkcpYTc= X-Google-Smtp-Source: AGHT+IGhtkecfba9NiIpJp/X26F7qVefbcuG7PPZ0aWZbiS3HuUI5If/0GX0IWBzbXaGmkmUZOwxCA== X-Received: by 2002:a19:6a14:0:b0:52c:d9f8:b033 with SMTP id 2adb3069b0e04-52ea061f85fmr2416825e87.3.1720166347674; Fri, 05 Jul 2024 00:59:07 -0700 (PDT) Received: from srini-hackbase.lan ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42651531f1fsm15315485e9.0.2024.07.05.00.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 00:59:06 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Dylan Van Assche , Caleb Connolly , Dmitry Baryshkov , Ekansh Gupta , Srinivas Kandagatla Subject: [PATCH v2 4/6] misc: fastrpc: support complete DMA pool access to the DSP Date: Fri, 5 Jul 2024 08:58:58 +0100 Message-Id: <20240705075900.424100-5-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240705075900.424100-1-srinivas.kandagatla@linaro.org> References: <20240705075900.424100-1-srinivas.kandagatla@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1956; i=srinivas.kandagatla@linaro.org; h=from:subject; bh=C26JNwUiWg5/qKi+dgD+tXUf7Ay0d6cJGOQDusSWOwU=; b=owEBbQGS/pANAwAKAXqh/VnHNFU3AcsmYgBmh6fDiDRIfX4R6b60wCUc2Uoh26ciwbOe5sU+4 JlDne1aq7CJATMEAAEKAB0WIQQi509axvzi9vce3Y16of1ZxzRVNwUCZoenwwAKCRB6of1ZxzRV N1XXB/0VQtMXTGlnMsmU07RcDDa7naD1G3qZNP1kN02ChS3woJtmToGBK4S4Nre2PfQq9DUm3Ro MWrUZdggqu/PNgZB6HGUIVBemt9r8RlaoiaipKi7K3OmL61PO+aC1hikiEPrpATQWsIw3pcqGgT 4vplbyonr2dpCVU+X8ANAiuGNrNJuW1b77+uWrv1sY8NRSOpwJvu1rEImP1/AX4ZeYlKqEykCg7 WCmrz4QuWO4trs58cTyWiboC6mhH6D2K8XOGpkQHetfrUvQBVPR9DxMZeA8IR2LsHqLEyedd3IV ikeqDFgT4hW4LlKs/ljOBA7vV90fe3MktAmJ83JWQR8b3m/C X-Developer-Key: i=srinivas.kandagatla@linaro.org; a=openpgp; fpr=ED6472765AB36EC43B3EF97AD77E3FC0562560D6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Dylan Van Assche To support FastRPC Context Banks which aren't mapped via the SMMU, make the whole reserved memory region available to the DSP to allow access to coherent buffers. This is performed by assigning the memory to the DSP via a hypervisor call to set the correct permissions for the Virtual Machines on the DSP. This is only necessary when a memory region is provided for SLPI DSPs so guard this with a domain ID check. Signed-off-by: Dylan Van Assche Reviewed-by: Caleb Connolly Reviewed-by: Dmitry Baryshkov Reviewed-by: Ekansh Gupta Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 5fb302b8ae5d..1c045f9a75a4 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -2250,6 +2250,8 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *r= pdev) int i, err, domain_id =3D -1, vmcount; const char *domain; bool secure_dsp; + struct device_node *rmem_node; + struct reserved_mem *rmem; unsigned int vmids[FASTRPC_MAX_VMIDS]; =20 err =3D of_property_read_string(rdev->of_node, "label", &domain); @@ -2292,6 +2294,23 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *= rpdev) } } =20 + rmem_node =3D of_parse_phandle(rdev->of_node, "memory-region", 0); + if (domain_id =3D=3D SDSP_DOMAIN_ID && rmem_node) { + u64 src_perms; + + rmem =3D of_reserved_mem_lookup(rmem_node); + if (!rmem) { + err =3D -EINVAL; + goto fdev_error; + } + + src_perms =3D BIT(QCOM_SCM_VMID_HLOS); + + qcom_scm_assign_mem(rmem->base, rmem->size, &src_perms, + data->vmperms, data->vmcount); + + } + secure_dsp =3D !(of_property_read_bool(rdev->of_node, "qcom,non-secure-do= main")); data->secure =3D secure_dsp; =20 --=20 2.25.1 From nobody Mon Feb 9 01:48:46 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F211145FEA for ; Fri, 5 Jul 2024 07:59:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720166352; cv=none; b=o2LLo1WTwFGVWnKvElCq4vkpJbFIeWi9LwPjFkF/4U+tSOau9uPKZrpbtDfE10AdjlPF81mevoF6MqYWDun9Z+5CahAHzTpQzF5abDPtfom8M2NjZUnlQULN5fOCa3uWqDva/7PH2hfr5ck3sw81dvZkeIEwccW36cx9/qqZdwI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720166352; c=relaxed/simple; bh=TciCqxzc/qy6kg0GBz6jBFReYx11cwU3Iv5FYJNTzCQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bUlOVKyT7OthUuqQV+cC0nyySxHV/xn24zp/5up/QTmeGFY/NTmkLXdnExO70KLWbyoaZ4MfVadqdLHbCUIg80SpneRfSr1pFfrLLeTLnPpyuCg5X/esaPi9EzTfrF6vB24Cd87YjJoUHFL30aNbwDrAA2we39Pbk5ojWuutRog= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oV7zqRtu; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oV7zqRtu" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-42122ac2f38so8329775e9.1 for ; Fri, 05 Jul 2024 00:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720166349; x=1720771149; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ygcyp20J2+LIkFpUGmt6p19eExeLNGh9Ae9+Q6pOPWM=; b=oV7zqRtuGD+gaN6hMUnBWT/5yEi0+sezN2uLch+TiQQGYKW67RXI7YP6f7IPeeR9YV bPN47RXVc8zVXqb86bZ4MxtH3lD4+38J7PLSP6O3rugkPvzzMoGkHDJdPr5ym/C17GF/ hlO17e48JB92FCgJffw6zBeGb2a108npltuOIbN2BFOOOKPz2ksB0uTR8eMmrnw9N2YV cKfzS5yMRdWZzjmJnxlGTB3VKqf4K9ahbgFZv7TsDTu+iXldjEKTfUSkBOFHIuXg6DEJ rUH0v/hDfIhOENpwW3qgeBvhf0pH45pP0L/1WFGfJHHac6o0jz9K3bVpZeSETw6b6yP2 Nigg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720166349; x=1720771149; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ygcyp20J2+LIkFpUGmt6p19eExeLNGh9Ae9+Q6pOPWM=; b=W0nvI6q3Rc9DfhBCp8ln6vemN65KUzh3LlYJ1Vnn9c7jMoRNwwfTX/P0WuVbZaNESe aZ5NUtSN+RDAcRwnbv/LDl7stUpAeQV4FFNbtU4uwh69zG8T3EwWDGGIAu7ChnPyRTz7 T2qKeZVCKaTPy5s6TedUs6UrnsdtYU0mgQH1h1UNznFJy6uspt2f6VKdXdPSaSXD1lHw OhBopx4wHKzbLfPdOrmhJG8qSB35cYS4jWDdjfEqoe0PBwr3Er4dAkdfTcyA6jNPRR3R 6MvJF9rSxiiGEtEN15byITYKjCAXPLJTq/2ty0xWetDmrvBiUxWf1U6mAC6TYlByw8Te 8ywA== X-Gm-Message-State: AOJu0Yz/uA3tm88y17L+aOqHcX5H9LZr/Nhu0BkKlRxprxZtzG8peK1M ZyXABzeofWuTAWEoRiW9ewpoPaJIPaOedTWbvmbAe/A9ZJdcrTvO0Y8NiqfEDv8= X-Google-Smtp-Source: AGHT+IEVSthL/6TxKGR1p9XaW3AvOYF5WWQgzJumdI0bAhoCiQmKRHgfjwgDSW3+jCsg7pJ4K8FfHA== X-Received: by 2002:a05:600c:35c8:b0:424:ade3:c6b7 with SMTP id 5b1f17b1804b1-4264b0c5456mr34232165e9.2.1720166349095; Fri, 05 Jul 2024 00:59:09 -0700 (PDT) Received: from srini-hackbase.lan ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42651531f1fsm15315485e9.0.2024.07.05.00.59.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 00:59:08 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Dylan Van Assche , Caleb Connolly , Ekansh Gupta , Dmitry Baryshkov , Srinivas Kandagatla Subject: [PATCH v2 5/6] misc: fastrpc: use coherent pool for untranslated Compute Banks Date: Fri, 5 Jul 2024 08:58:59 +0100 Message-Id: <20240705075900.424100-6-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240705075900.424100-1-srinivas.kandagatla@linaro.org> References: <20240705075900.424100-1-srinivas.kandagatla@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1383; i=srinivas.kandagatla@linaro.org; h=from:subject; bh=2gIsBIhQ/2HvQF1EyxUO84GUNTMwiRGzOemrHaXwkEk=; b=owEBbQGS/pANAwAKAXqh/VnHNFU3AcsmYgBmh6fDPw48PuUYqZ+kZebcOXFBXVLihgJlDbNQL 6gwJQK0v8GJATMEAAEKAB0WIQQi509axvzi9vce3Y16of1ZxzRVNwUCZoenwwAKCRB6of1ZxzRV N9+yB/42KGYBE3pAUU4bbT0iCuL+CL+C++sRmcNQDHuIUNtlvy/rRhOtDkRdwWOgKDbs/t6TGUK nN1tXN8T7Pz522oUGi+WlBvbBs8MhJTy2EUxlSqyyqL79ygHmca7U5AxdFPfxpCd7vq1UtukUmK O7+v8VW0yeXK6udlP9vzCWp6P1qe0b77q3QAnsNAvFMi2pPMqC9ek3iJ4WwKWeIiHXRJuUNqemV vA4RkYb3Gliiy3HZXIKWwAA9I1Ho1QoeI7s082VWrwhp9PnDSKSVnH2a4vMy6qRyktOyEH67EgI FS25ub2SdaiQaE1XcJvj0llGxfKYAL3F/yJ92SspT6zSYV2B X-Developer-Key: i=srinivas.kandagatla@linaro.org; a=openpgp; fpr=ED6472765AB36EC43B3EF97AD77E3FC0562560D6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Dylan Van Assche Use fastrpc_remote_heap_alloc to allocate from the FastRPC device instead of the Compute Bank when the session ID is 0. This ensures that the allocation is inside the coherent DMA pool which is already accessible to the DSP. This is necessary to support FastRPC devices which do not have dedicated Compute Banks such as the SLPI on the SDM845. The latter uses an allocated CMA region instead of FastRPC Compute Banks. Signed-off-by: Dylan Van Assche Reviewed-by: Caleb Connolly Reviewed-by: Ekansh Gupta Reviewed-by: Dmitry Baryshkov Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 1c045f9a75a4..95931abc3770 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -953,7 +953,10 @@ static int fastrpc_get_args(u32 kernel, struct fastrpc= _invoke_ctx *ctx) =20 ctx->msg_sz =3D pkt_size; =20 - err =3D fastrpc_buf_alloc(ctx->fl, dev, pkt_size, &ctx->buf); + if (ctx->fl->sctx->sid) + err =3D fastrpc_buf_alloc(ctx->fl, dev, pkt_size, &ctx->buf); + else + err =3D fastrpc_remote_heap_alloc(ctx->fl, dev, pkt_size, &ctx->buf); if (err) return err; =20 --=20 2.25.1 From nobody Mon Feb 9 01:48:46 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1559146587 for ; Fri, 5 Jul 2024 07:59:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720166353; cv=none; b=F8rikhWALGNBkXP5zME5rR63a9yvMlQwPAZ6IQngBXT5umVwfEL55PvIGmeLb8XLbqbgkEjkXgJ/lVdK4DMuEKCTU7D0dVLZ0SqCpL3ptPiIA3AhGUKL69x/nZhs62hx0OxW1l0kqZikIRAHQ+3E59be4VqUwJq3Ln7Xs8kndrI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720166353; c=relaxed/simple; bh=SGpVUqdhNuunu6EdU8ICh254/ccEvSKoo44/Lv9FSuU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=orS48RcKfqqcP3zGEwvJ0cLfprwAFQq93uBLKL5E8tkEcM+r/EEVEC5dxy84ov+KaYrAH1PxVhIMigAIsFfcsMpqwoLCshYy0kxVBUlAUlw/tCHfS7z4nI4xMcc/655ZF19+c23oq1aQo850mLWWUmEkU48uaEBqx7Fu24NM1HI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wLBlQpA3; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wLBlQpA3" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-425624255f3so8396425e9.0 for ; Fri, 05 Jul 2024 00:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720166350; x=1720771150; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d5QLOaGfw4fqqwExDjeo+KAi/zuShPBblYH6C90WTtE=; b=wLBlQpA3ZtSGO9uwVnov7+IZZA89S7rBl7v7GunQNkMYzVkCKcVy+OCkYKkEPEAIEF QZcowL02k2ALlaTC6o22+0AMSb+gULKjI3jN9lOsfaWT+crKBYy9aMqVZourKdCEKqGJ 67zVOq6rUyK+vRFsDbOThkENqWpda9VW5w1Qm34pOh3aV55ONd1bVZD5DFajtjCmq9e4 IKNUIhc19+pkIkIRyQmdJO2tJx39jsaiYdXs3RVMC3jn9yInwUMODBfb1VPnFEbrhr2L RJwjD4HLnEVcQcaXf99gN6ndRr9RYO2irQBin2Un7OtLHS2x7GOVh80+sgnKOiW32RtJ 7XLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720166350; x=1720771150; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d5QLOaGfw4fqqwExDjeo+KAi/zuShPBblYH6C90WTtE=; b=ObbUJEKqPU7DWFFOOX3BFmihwQdbJfAMzFGfgj6fdKg+xAkL2uLwFfcEbJI+3j2Bwx 3S/1/NoUrRRpntwhukY793S+vsoOAMCnii1dAFObi3psN221qOIDiFc9UjY9Pc/libVJ 4sRqdRBCCCssS3coAb6Kn+/3X1sWLgtVoOMUUnIrFox2rA+qIiFYNjPf9DJvMxJVCieJ 1Cdc5IhD1+v/d7HhWijUgLPMKpwedBFlIAmXnBkVHOvBUmoasxEEWsO5DBH/dDr8+aNx YdfFBILOp10PEsBahsUIXdBd1ZmiQ1ddEffKb8iJi7YMc7pN+rkWbV36F5LGDAdeYHTN 3tGw== X-Gm-Message-State: AOJu0YzpaZEM4r2c8S1TShygSZAgd2+VdQo5G7UOZ3SQzxAPcCZjn85h d/PCyp1b8BVjaq0ruPDSrjF7KGlkBXtm9IPcNWfM20OObhHHZjufASTPtVQeuxI= X-Google-Smtp-Source: AGHT+IF9gFOr4gU7Pq320fkClZbJsxIC2Erzl2kbomnXaeT/ysdV2OnGI5wtpK7K9mJS/jjnpSr8DQ== X-Received: by 2002:a7b:c8c5:0:b0:425:6424:5f97 with SMTP id 5b1f17b1804b1-4264b126c8emr36205555e9.5.1720166350441; Fri, 05 Jul 2024 00:59:10 -0700 (PDT) Received: from srini-hackbase.lan ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42651531f1fsm15315485e9.0.2024.07.05.00.59.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 00:59:09 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Dmitry Baryshkov , Bjorn Andersson , Srinivas Kandagatla Subject: [PATCH v2 6/6] MAINTAINERS: CC dri-devel list on Qualcomm FastRPC patches Date: Fri, 5 Jul 2024 08:59:00 +0100 Message-Id: <20240705075900.424100-7-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240705075900.424100-1-srinivas.kandagatla@linaro.org> References: <20240705075900.424100-1-srinivas.kandagatla@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1045; i=srinivas.kandagatla@linaro.org; h=from:subject; bh=ueXPhw+SaroMuRF+5GL1pvcqrrkgWe4MYERNdzJ9h1k=; b=owEBbQGS/pANAwAKAXqh/VnHNFU3AcsmYgBmh6fD6xKYlVLsSO08KDbTN/O9me/qGhzqUnMR9 4/564j3JB+JATMEAAEKAB0WIQQi509axvzi9vce3Y16of1ZxzRVNwUCZoenwwAKCRB6of1ZxzRV N61bCAC1Wl7cgtoNqBph4ET6HMbXunvLH7U2vpU9fWniOtCoou4dGCmS/5/OeqQEtZB6YGwHjPx U5O7Wxj8os2B6/If4dkXZgF4EnRXJciFnRG1WsjUfiwO7rL8UgRpVOQ5kIItiVkgIX6DQTH7Pdj YE5IwnShoaGv32A6A+ASPcGoD2C1JLRchGUf8DYzYr/K3ZDjGgWqAjUf+p81bEXrY4hARxNi7YR PegTvas8gj+7geNiLk0gB7j6V4fQ7xpSR71MQnBXmefvonmfT+LC1OcEpdqzQDAS9PjLxPaeAXm 09WKNtT36S7ESPd0aaXeBnw6Js4L9KFUwGU+8teazc/Cfa5L X-Developer-Key: i=srinivas.kandagatla@linaro.org; a=openpgp; fpr=ED6472765AB36EC43B3EF97AD77E3FC0562560D6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Dmitry Baryshkov FastRPC is a way to offload method invocation to the DSPs on Qualcomm platforms. As the driver uses dma-bufs, add dri-devel mailing list to the MAINTAINERS's entry, so that DRM maintainers are notified about the uAPI changes. This follows the usual practice established by the "DMA BUFFER SHARING FRAMEWORK" entry in the file. Suggested-by: Bjorn Andersson Signed-off-by: Dmitry Baryshkov Signed-off-by: Srinivas Kandagatla --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d6c90161c7bf..0b99543d9c6e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18499,6 +18499,7 @@ QUALCOMM FASTRPC DRIVER M: Srinivas Kandagatla M: Amol Maheshwari L: linux-arm-msm@vger.kernel.org +L: dri-devel@lists.freedesktop.org S: Maintained F: Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml F: drivers/misc/fastrpc.c --=20 2.25.1