From nobody Sun Feb 8 07:14:35 2026 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8E0DD17BB13; Wed, 3 Jul 2024 14:38:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720017504; cv=none; b=Kp8pRamph/CXKK2NXEeQE8N0f0IjPPUSSwdeit91GsN4w+Q95heU5YS9g1Kyy9woQqYEKk3RimP8mTUAsSOH4g+6Ht+IpZdz/Ocmyv56ZIl73qduxO4n2UTzdQgYLhJKyVI/LtfDE+AvtVw3XFfYoyukgYMOEh8PyKn4Wsfxmm4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720017504; c=relaxed/simple; bh=9ZdUurG27ClZrOWTl3VHl2nqkq5xVOtJrtbqrj6LutU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RvaJAamyyzvQdyUjCitQ7lnAeBg1Vz4zl9OO7anebuATHGDE/PywBEmP1xA8fCCjcpklLOXAAlTbVIACPMF+68FVqpP9prdMatpiNFIpF3ktSpu30/RQHNoEhfV2SD4c9mFgNnzPGC8obXc9EO82vyJquAUDZX5mKEVwha8+bXs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AFAE2367; Wed, 3 Jul 2024 07:38:45 -0700 (PDT) Received: from thinkcentre-m93p.cambridge.arm.com (thinkcentre-m93p.cambridge.arm.com [10.1.197.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CF5D23F766; Wed, 3 Jul 2024 07:38:19 -0700 (PDT) From: Luke Parkin To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, Luke Parkin Subject: [PATCH v2 1/4] firmware: arm_scmi: Remove superfluous handle_to_scmi_info Date: Wed, 3 Jul 2024 15:37:35 +0100 Message-Id: <20240703143738.2007457-2-luke.parkin@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240703143738.2007457-1-luke.parkin@arm.com> References: <20240703143738.2007457-1-luke.parkin@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove duplicate handle_to_scmi_info Signed-off-by: Luke Parkin Reviewed-by: Cristian Marussi --- drivers/firmware/arm_scmi/driver.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi= /driver.c index 6b6957f4743f..56a93d20bf23 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -1261,9 +1261,6 @@ static int scmi_wait_for_reply(struct device *dev, co= nst struct scmi_desc *desc, xfer->rx.buf, xfer->rx.len); =20 if (IS_ENABLED(CONFIG_ARM_SCMI_RAW_MODE_SUPPORT)) { - struct scmi_info *info =3D - handle_to_scmi_info(cinfo->handle); - scmi_raw_message_report(info->raw, xfer, SCMI_RAW_REPLY_QUEUE, cinfo->id); --=20 2.34.1 From nobody Sun Feb 8 07:14:35 2026 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E2F3717BB13; Wed, 3 Jul 2024 14:38:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720017514; cv=none; b=bnQhAWV2PJtXjUmxIavVrgrfBDWNnSJ48gBayAXpxxjtdWCNyF47P22c/Y+Swn1W0Qx1hoK/3Y7UFCy8iH/PBiusNVY9Xz71lYIilbNKEoRWRQn0GzyIfayanFMw1UC95XoP7kzSq4fT4Slb5GhiDTUWQKgTWkz2W/0NaKNlji0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720017514; c=relaxed/simple; bh=erSLUW9xHIYQlmmCQqx868PG0S+Z7gq7cNErpAEdZ58=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PrYcH6fYjlxxB4v9OPG0Jr7EHRmhNJOgFg0yKIkFc+A0fZ3N73kUq+LqsEbtwG7X9ubXCuOzA1d29GkbUhcArevH+26jgbddvwIRPQGbjgyfkokgD1TxdG6qgEIcHbBcnKurAloFCo/ke3BgGYVWsQMNBdGOVN0awCkot0FiIEU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4F1C7367; Wed, 3 Jul 2024 07:38:57 -0700 (PDT) Received: from thinkcentre-m93p.cambridge.arm.com (thinkcentre-m93p.cambridge.arm.com [10.1.197.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6F2003F766; Wed, 3 Jul 2024 07:38:31 -0700 (PDT) From: Luke Parkin To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, Luke Parkin Subject: [PATCH v2 2/4] firmware: arm_scmi: Add support for tracking statistics Date: Wed, 3 Jul 2024 15:37:36 +0100 Message-Id: <20240703143738.2007457-3-luke.parkin@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240703143738.2007457-1-luke.parkin@arm.com> References: <20240703143738.2007457-1-luke.parkin@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a new config option for statistic tracking in SCMI subsystem Add a struct for tracking statistics Add scmi_log_stats op/no-op function for incrementing statistics Signed-off-by: Luke Parkin v1->v2 Config option now depends on DEBUG_FS Add scmi_log_stats rather than if(IS_ENABLED) Move location of scmi_debug_stats in the scmi_info struct --- drivers/firmware/arm_scmi/Kconfig | 11 +++++++++++ drivers/firmware/arm_scmi/common.h | 9 +++++++++ drivers/firmware/arm_scmi/driver.c | 18 ++++++++++++++++++ 3 files changed, 38 insertions(+) diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/= Kconfig index aa5842be19b2..45e8e7df927e 100644 --- a/drivers/firmware/arm_scmi/Kconfig +++ b/drivers/firmware/arm_scmi/Kconfig @@ -55,6 +55,17 @@ config ARM_SCMI_RAW_MODE_SUPPORT_COEX operate normally, thing which could make an SCMI test suite using the SCMI Raw mode support unreliable. If unsure, say N. =20 +config ARM_SCMI_DEBUG_STATISTICS + bool "Enable SCMI Raw mode statistic tracking" + select ARM_SCMI_NEED_DEBUGFS + depends on DEBUG_FS + help + Enables statistic tracking for the SCMI subsystem. + + Enable this option to create a new debugfs directory which contains + several useful statistics on various SCMI features. This can be useful + for debugging and SCMI monitoring. If unsure, say N. + config ARM_SCMI_HAVE_TRANSPORT bool help diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi= /common.h index b5ac25dbc1ca..1f50c4a209d7 100644 --- a/drivers/firmware/arm_scmi/common.h +++ b/drivers/firmware/arm_scmi/common.h @@ -301,6 +301,15 @@ extern const struct scmi_desc scmi_optee_desc; =20 void scmi_rx_callback(struct scmi_chan_info *cinfo, u32 msg_hdr, void *pri= v); =20 +#ifdef CONFIG_ARM_SCMI_DEBUG_STATISTICS +static inline void scmi_log_stats(atomic_t *atm) +{ + atomic_inc(atm); +} +#else +static inline void scmi_log_stats(atomic_t *atm) {} +#endif + enum scmi_bad_msg { MSG_UNEXPECTED =3D -1, MSG_INVALID =3D -2, diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi= /driver.c index 56a93d20bf23..df3eb17cf439 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -125,6 +125,22 @@ struct scmi_debug_info { bool is_atomic; }; =20 +/** + * struct scmi_debug_stats - Debug statistics + * @sent_ok: Count of successful sends + * @sent_fail: Count of failed sends + * @response_ok: Count of successful responses + * @dlyd_response_ok: Count of successful delayed responses + * @xfers_response_timeout: Count of xfer response timeouts + */ +struct scmi_debug_stats { + atomic_t sent_ok; + atomic_t sent_fail; + atomic_t response_ok; + atomic_t dlyd_response_ok; + atomic_t xfers_response_timeout; +}; + /** * struct scmi_info - Structure representing a SCMI instance * @@ -161,6 +177,7 @@ struct scmi_debug_info { * bus * @devreq_mtx: A mutex to serialize device creation for this SCMI instance * @dbg: A pointer to debugfs related data (if any) + * @stats: Contains several atomic_t's for tracking various statistics * @raw: An opaque reference handle used by SCMI Raw mode. */ struct scmi_info { @@ -187,6 +204,7 @@ struct scmi_info { /* Serialize device creation process for this instance */ struct mutex devreq_mtx; struct scmi_debug_info *dbg; + struct scmi_debug_stats stats; void *raw; }; =20 --=20 2.34.1 From nobody Sun Feb 8 07:14:35 2026 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EA83617C237; Wed, 3 Jul 2024 14:38:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720017517; cv=none; b=P5AG+LlloPhLo2ZFwW8yEZyjEXTcd7agpNdlxDMDos2DTg2oZ59kHyHrXKZ9zktv0gEaXeZVvoq4dlqPawwF63Vah9EGS1Loy+wzijJkisqsJnk9uxZ0fJjpW+MRvAC9afOosV/IadyCsoBYWuNlo05g3GHZwY+ZAkTUOvAxH9g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720017517; c=relaxed/simple; bh=0opBgfznT6wfL/z88iog+TIcqkkfL4b4o6bWKh2z4PA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rybwLm2ZIxwOzeFIsQ6fvSkZNEgFp5e9onzXV7K76zutdEpD/9WZFTRx3sLQPpiiYOWU8+SSFDs6fZ2zHNT3I3N/HCUoES6s7vlgLY1mJPXOYRzllA1pRuQL7Xx8kz7EsO2x9m9uxtvMRfrTEd4/jhV8OrYdM554rURkPXzASyo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 50DCB1007; Wed, 3 Jul 2024 07:38:59 -0700 (PDT) Received: from thinkcentre-m93p.cambridge.arm.com (thinkcentre-m93p.cambridge.arm.com [10.1.197.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 70EC83F766; Wed, 3 Jul 2024 07:38:33 -0700 (PDT) From: Luke Parkin To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, Luke Parkin Subject: [PATCH v2 3/4] firmware: arm_scmi: Track basic SCMI statistics Date: Wed, 3 Jul 2024 15:37:37 +0100 Message-Id: <20240703143738.2007457-4-luke.parkin@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240703143738.2007457-1-luke.parkin@arm.com> References: <20240703143738.2007457-1-luke.parkin@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add tracking of 5 initial statistics Signed-off-by: Luke Parkin V1->V2 Drop unneccesary atomic_set's Use new 'scmi_log_stats' to simplify incrementing of atomics Move scmi_log_stats to locations which mean no extra conditionals are needed --- drivers/firmware/arm_scmi/driver.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi= /driver.c index df3eb17cf439..937546397cf2 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -1146,8 +1146,10 @@ static void scmi_handle_response(struct scmi_chan_in= fo *cinfo, if (xfer->hdr.type =3D=3D MSG_TYPE_DELAYED_RESP) { scmi_clear_channel(info, cinfo); complete(xfer->async_done); + scmi_log_stats(&info->stats.dlyd_response_ok); } else { complete(&xfer->done); + scmi_log_stats(&info->stats.response_ok); } =20 if (IS_ENABLED(CONFIG_ARM_SCMI_RAW_MODE_SUPPORT)) { @@ -1231,6 +1233,7 @@ static int scmi_wait_for_reply(struct device *dev, co= nst struct scmi_desc *desc, struct scmi_xfer *xfer, unsigned int timeout_ms) { int ret =3D 0; + struct scmi_info *info =3D handle_to_scmi_info(cinfo->handle); =20 if (xfer->hdr.poll_completion) { /* @@ -1251,13 +1254,12 @@ static int scmi_wait_for_reply(struct device *dev, = const struct scmi_desc *desc, "timed out in resp(caller: %pS) - polling\n", (void *)_RET_IP_); ret =3D -ETIMEDOUT; + scmi_log_stats(&info->stats.xfers_response_timeout); } } =20 if (!ret) { unsigned long flags; - struct scmi_info *info =3D - handle_to_scmi_info(cinfo->handle); =20 /* * Do not fetch_response if an out-of-order delayed @@ -1291,6 +1293,7 @@ static int scmi_wait_for_reply(struct device *dev, co= nst struct scmi_desc *desc, dev_err(dev, "timed out in resp(caller: %pS)\n", (void *)_RET_IP_); ret =3D -ETIMEDOUT; + scmi_log_stats(&info->stats.xfers_response_timeout); } } =20 @@ -1374,13 +1377,15 @@ static int do_xfer(const struct scmi_protocol_handl= e *ph, !is_transport_polling_capable(info->desc)) { dev_warn_once(dev, "Polling mode is not supported by transport.\n"); + scmi_log_stats(&info->stats.sent_fail); return -EINVAL; } =20 cinfo =3D idr_find(&info->tx_idr, pi->proto->id); - if (unlikely(!cinfo)) + if (unlikely(!cinfo)) { + scmi_log_stats(&info->stats.sent_fail); return -EINVAL; - + } /* True ONLY if also supported by transport. */ if (is_polling_enabled(cinfo, info->desc)) xfer->hdr.poll_completion =3D true; @@ -1412,6 +1417,7 @@ static int do_xfer(const struct scmi_protocol_handle = *ph, ret =3D info->desc->ops->send_message(cinfo, xfer); if (ret < 0) { dev_dbg(dev, "Failed to send message %d\n", ret); + scmi_log_stats(&info->stats.sent_fail); return ret; } =20 @@ -1420,8 +1426,12 @@ static int do_xfer(const struct scmi_protocol_handle= *ph, xfer->hdr.status, xfer->tx.buf, xfer->tx.len); =20 ret =3D scmi_wait_for_message_response(cinfo, xfer); - if (!ret && xfer->hdr.status) + if (!ret && xfer->hdr.status) { ret =3D scmi_to_linux_errno(xfer->hdr.status); + scmi_log_stats(&info->stats.sent_fail); + } else { + scmi_log_stats(&info->stats.sent_ok); + } =20 if (info->desc->ops->mark_txdone) info->desc->ops->mark_txdone(cinfo, ret, xfer); --=20 2.34.1 From nobody Sun Feb 8 07:14:35 2026 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6244F17DA3E; Wed, 3 Jul 2024 14:38:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720017518; cv=none; b=EY7BfnRpHDNxBbCiYm5ov973pqF9NlKKg8jKIpwMgJoODW0TSdkSqAEY2E6ZLB2oiBTg+RWzS//DlEXnfKaPfN+x5Rz6QPLbYjExGBY16An9yYrGjJwmml5v4b6yo/Nq6gA1kgoq7J1e0brlSMQ2LiDmVIiWwDM+laP8F83/Ho8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720017518; c=relaxed/simple; bh=1pyvTHvgPYCtPb4G+O/6/6OTk21US0vpzPZTUyPuZZo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PQ64HsEnbgfxC7pV96DLsGG47yD08OK2OeOIC619vj7eBJiDm/AAPcBMtOpaJlRO+fSu67yWKcDk3yzg+WKqtHifUQG0reW2TyxwF8I+4mK8Wfb9O9DUD9P6OsIcPzsVwX2j2HdHnJh5FpKeOh1mDsk3hRniSREmmrYTq32xZjM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 040BF1688; Wed, 3 Jul 2024 07:39:01 -0700 (PDT) Received: from thinkcentre-m93p.cambridge.arm.com (thinkcentre-m93p.cambridge.arm.com [10.1.197.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 245DB3F766; Wed, 3 Jul 2024 07:38:35 -0700 (PDT) From: Luke Parkin To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, Luke Parkin Subject: [PATCH v2 4/4] firmware: arm_scmi: Create debugfs files for statistics Date: Wed, 3 Jul 2024 15:37:38 +0100 Message-Id: <20240703143738.2007457-5-luke.parkin@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240703143738.2007457-1-luke.parkin@arm.com> References: <20240703143738.2007457-1-luke.parkin@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Create debugfs files for the statistics in the scmi_debug_stats struct Signed-off-by: Luke Parkin v1->v2 Only create stats pointer if stats are enabled Move stats debugfs creation into a seperate helper function --- drivers/firmware/arm_scmi/driver.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi= /driver.c index 937546397cf2..10cd9a319ffb 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -2858,6 +2858,24 @@ static int scmi_device_request_notifier(struct notif= ier_block *nb, return NOTIFY_OK; } =20 +static void scmi_debugfs_stats_setup(struct scmi_info *info, + struct dentry *trans) +{ + struct dentry *stats; + + stats =3D debugfs_create_dir("stats", trans); + debugfs_create_atomic_t("response_ok", 0400, stats, + &info->stats.response_ok); + debugfs_create_atomic_t("dlyd_response_ok", 0400, stats, + &info->stats.dlyd_response_ok); + debugfs_create_atomic_t("sent_ok", 0400, stats, + &info->stats.sent_ok); + debugfs_create_atomic_t("sent_fail", 0400, stats, + &info->stats.sent_fail); + debugfs_create_atomic_t("xfers_response_timeout", 0400, stats, + &info->stats.xfers_response_timeout); +} + static void scmi_debugfs_common_cleanup(void *d) { struct scmi_debug_info *dbg =3D d; @@ -2924,6 +2942,9 @@ static struct scmi_debug_info *scmi_debugfs_common_se= tup(struct scmi_info *info) debugfs_create_u32("rx_max_msg", 0400, trans, (u32 *)&info->rx_minfo.max_msg); =20 + if (IS_ENABLED(CONFIG_ARM_SCMI_DEBUG_STATISTICS)) + scmi_debugfs_stats_setup(info, trans); + dbg->top_dentry =3D top_dentry; =20 if (devm_add_action_or_reset(info->dev, --=20 2.34.1