From nobody Tue Feb 10 02:47:39 2026 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA63416C6B6 for ; Mon, 1 Jul 2024 14:56:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719845809; cv=none; b=rzPlqMPy3r7ZpxHXZA1NcQSkcRpKPbBRGA664r0UEtJAhh7IPMlNHXll50gfm4X7LK4cPjwzPpue9TffSMfrX2VlNIMBZEg+fOdfjbDyNU/dRRc+Z5AMzh/pdr3t9CZpK939W1ExqKWOJgUG8X/Q4SUUNdEuWXYLCmT32ew4Dyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719845809; c=relaxed/simple; bh=79NJk/kks064XT4lzuhqDllc7V+WZUytw1GlsOlds7Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cgCB/TzFr/y/NF8SkyO+qdBp+pqR/JDC8BG9cFq8yc750voEDHbzieJMsjWE97K109HIK5WznOiM+XaDTTXypQeL07ihV/MVpC5LK/qtb61yEbOAoyh5j998JOcQj/1rGJaClmJpCGfOW8EB4zMoisN7pd9iWpUjz1tHOH9Via4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=f2Rm3vpq; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="f2Rm3vpq" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2ebe0a81dc8so41981601fa.2 for ; Mon, 01 Jul 2024 07:56:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719845804; x=1720450604; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JATPX/JRe6q4Z3TotQ5wEOtjsde3mkXmcqQGJxoMG3g=; b=f2Rm3vpqmp0KnqYvBQaJaF4c09gh62YKh5BVvr0I4uxT7lujm7FpxDlAz64bZpqtsg WMtj2eN1NX/IfZee5FuLB8/uIW/z59fhjoevZrBfDaWFo35SG5l5KRHhaSXlRk+Bql5p WynnPVnquATbhrk9j0teVoGFwq8onBAZ0QyXxpqtTjC7stQ/4eDRYpqFJFOrJ39E+y4c lfvpkyeOWYsMCUaRohfyLZf8dcQ0IIFvmgGmdtWHbftoUR5QXUieFYEFBEdqpP/vEALY +HcROcayt10QisQulSbwsdIpI3A4IvNXPwEyJhivFbPjA28h84gtidxm/3zZQyFynrZo Xkdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719845804; x=1720450604; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JATPX/JRe6q4Z3TotQ5wEOtjsde3mkXmcqQGJxoMG3g=; b=NnX7sFzUQf+kc9wbwRPAK8WWRFVgcld7qDtI+zzBirKwzOx2NObZynrjLuvT8AP8wU kWl2AwwYDP1PzdwEMmNiq3q/EBYsSD3CNzk2lPY93s3eMs66oV/4K6qUi0nVExKiOlgh NvhwQfr8toSb/3HYkQb05PnmP+B5sKkOOzBXPcmqw7YObpIBnejtAq8Xv04zGBqVQFXV Ng4wuQe/UkxNkGm//un6a+Ma6ff+/uvd8oS1SwalvAI2q1LhczS5VGHKR+5Bds6mAeFs XTrKD6hDr9e3bQBHVxxApnC11jgDQ3ASje6t5Q73Xe5fwZIm9GjRIlp1u0dq2N83/ZCI i7ew== X-Forwarded-Encrypted: i=1; AJvYcCVB9Fd7Df1AoGniEQUaNQOATKXbGTFYgLCzb0ij9cl94IsFxW/D2olUGF2bHvJdRlxMpLWDOSqi2cTFhfS0dgfNSUhD0rx6NnJvpKEt X-Gm-Message-State: AOJu0Yz6sfoq28WFVbyuQmOYeNW/miVxIK+XqKpzdVKWkmOehN10wcb0 fwPID9+n+VoYngUb63GY8txTzqoeno+bt3/PC2RMjSz6wjZblxVPET4ViZOZzLmgLgMzvcIJqvG Z X-Google-Smtp-Source: AGHT+IE22RIOChFZZa4znuI1O9mOLun25MwFCbFMZiEdl8Iwww43ZJGWH2ZmYlbDClkh5/Wy0lb1+g== X-Received: by 2002:a2e:a889:0:b0:2ec:558d:4e0a with SMTP id 38308e7fff4ca-2ee5e393e16mr52979781fa.19.1719845804485; Mon, 01 Jul 2024 07:56:44 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.137]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256b0c0f99sm160062915e9.41.2024.07.01.07.56.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 07:56:43 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 01 Jul 2024 16:56:34 +0200 Subject: [PATCH 1/7] ARM: dts: marvell: kirkwood: align GPIO keys node name with bindings Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240701-dts-marvell-cleanup-v1-1-4773bd20691a@linaro.org> References: <20240701-dts-marvell-cleanup-v1-0-4773bd20691a@linaro.org> In-Reply-To: <20240701-dts-marvell-cleanup-v1-0-4773bd20691a@linaro.org> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=17045; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=79NJk/kks064XT4lzuhqDllc7V+WZUytw1GlsOlds7Q=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmgsOjPa79i2wAY3BT1qCSZzyYEo45o+HlfiOBX DDT8xAZS8aJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZoLDowAKCRDBN2bmhouD 1z66EACSRfVcHB/qDzhjBWmIncYpKirAvYh9JjoXYCUikttoWxnFj62tNR3/Uz7eEf2dzOZLy1e OxfGmkQhKL05rOl8WVvzIp5d9328lTDV6H3ok82YqDchLYrkjFZnfTT6F5v+9TpJXPXK0iN2QXd sNJsQLSqL6ZUMoqHqLjAvuESYaRDXnCQcuPyzegjLi6wGY+cpt/C2aO+PGxmww4Timf+LTIwVhn 2ayBiXVeh0MT0CPAhM47k3A3u7J/ZnboA6K97qyhUA7knDkE0PO6HTMJ0OsF7maMOF9lfgWHpie 7FSxVynlnt3CJo9OGTbBznGsMcPVcaTD7xADyeABGIChDBEQ0c/N9uG+jZpuU98uf5O55rrWYQK QnElBLVqAsGHGIFdW8g4iRFTI8ITjWOa12uPqRc51Gl1gSlkyKKNaHEQbWXcLaxa8Gfii2QRpxE aB1EBNPyRNhfcRo2G9iwvQZCGzi5eAufY3nbRO01/IbLkGFa2d/4t19kX5NJnNGjpF8ZWy52P4p UTB9Z5PRuPwFYUzPFbCzB9DV9dw44BVLBcFs5GndmygjF9cXivGSEOOIywXJB+HI5EUXuvU52FH waiRVuafwvcyjuuj5euIhHx0dljW9OQDcdIe1BdAyTFVXkG0rB+v0p9LefkvwMioUcc/RDImOXC BwpsZw4SrDqGvLQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Bindings expect the GPIO key node names to follow certain pattern, see dtbs_check warnings: kirkwood-laplug.dtb: gpio_keys: 'power' does not match any of the regexes= : '^(button|event|key|switch|(button|event|key|switch)... Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/marvell/kirkwood-blackarmor-nas220.dts | 4 ++-- arch/arm/boot/dts/marvell/kirkwood-c200-v1.dts | 8 ++++---- arch/arm/boot/dts/marvell/kirkwood-cloudbox.dts | 2 +- arch/arm/boot/dts/marvell/kirkwood-dir665.dts | 4 ++-- arch/arm/boot/dts/marvell/kirkwood-dnskw.dtsi | 6 +++--- arch/arm/boot/dts/marvell/kirkwood-ib62x0.dts | 4 ++-- arch/arm/boot/dts/marvell/kirkwood-iconnect.dts | 4 ++-- arch/arm/boot/dts/marvell/kirkwood-iomega_ix2_200.dts | 6 +++--- arch/arm/boot/dts/marvell/kirkwood-l-50.dts | 2 +- arch/arm/boot/dts/marvell/kirkwood-laplug.dts | 2 +- arch/arm/boot/dts/marvell/kirkwood-linksys-viper.dts | 4 ++-- arch/arm/boot/dts/marvell/kirkwood-lsxl.dtsi | 6 +++--- arch/arm/boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts | 4 ++-- arch/arm/boot/dts/marvell/kirkwood-netxbig.dtsi | 6 +++--- arch/arm/boot/dts/marvell/kirkwood-ns2-common.dtsi | 2 +- arch/arm/boot/dts/marvell/kirkwood-nsa310s.dts | 6 +++--- arch/arm/boot/dts/marvell/kirkwood-nsa3x0-common.dtsi | 6 +++--- arch/arm/boot/dts/marvell/kirkwood-openblocks_a6.dts | 2 +- arch/arm/boot/dts/marvell/kirkwood-pogoplug-series-4.dts | 2 +- arch/arm/boot/dts/marvell/kirkwood-t5325.dts | 2 +- arch/arm/boot/dts/marvell/kirkwood-ts219-6281.dts | 4 ++-- arch/arm/boot/dts/marvell/kirkwood-ts219-6282.dts | 4 ++-- arch/arm/boot/dts/marvell/kirkwood-ts419.dtsi | 4 ++-- 23 files changed, 47 insertions(+), 47 deletions(-) diff --git a/arch/arm/boot/dts/marvell/kirkwood-blackarmor-nas220.dts b/arc= h/arm/boot/dts/marvell/kirkwood-blackarmor-nas220.dts index 07fbfca444d5..f34c3897ff48 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-blackarmor-nas220.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-blackarmor-nas220.dts @@ -35,13 +35,13 @@ gpio_poweroff { gpio_keys { compatible =3D "gpio-keys"; =20 - reset { + button-reset { label =3D "Reset"; linux,code =3D ; gpios =3D <&gpio0 29 GPIO_ACTIVE_HIGH>; }; =20 - button { + button-power { label =3D "Power"; linux,code =3D ; gpios =3D <&gpio0 26 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-c200-v1.dts b/arch/arm/boot= /dts/marvell/kirkwood-c200-v1.dts index f59ff7578dfc..7e3ee64d4bdf 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-c200-v1.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-c200-v1.dts @@ -29,25 +29,25 @@ keys { pinctrl-0 =3D <&pmx_buttons>; pinctrl-names =3D "default"; =20 - power { + button-power { label =3D "Power Button"; linux,code =3D ; gpios =3D <&gpio1 16 GPIO_ACTIVE_HIGH>; }; =20 - reset { + button-reset { label =3D "Reset Button"; linux,code =3D ; gpios =3D <&gpio1 17 GPIO_ACTIVE_LOW>; }; =20 - usb1 { + button-usb1 { label =3D "USB1 Button"; linux,code =3D ; gpios =3D <&gpio0 28 GPIO_ACTIVE_LOW>; }; =20 - usb2 { + button-usb2 { label =3D "USB2 Button"; linux,code =3D ; gpios =3D <&gpio0 29 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-cloudbox.dts b/arch/arm/boo= t/dts/marvell/kirkwood-cloudbox.dts index 448b0cd23b5f..2582b84d8415 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-cloudbox.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-cloudbox.dts @@ -61,7 +61,7 @@ gpio_keys { #address-cells =3D <1>; #size-cells =3D <0>; =20 - power { + key-power { label =3D "Power push button"; linux,code =3D ; gpios =3D <&gpio0 16 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-dir665.dts b/arch/arm/boot/= dts/marvell/kirkwood-dir665.dts index 0c0851cd9bec..e8eff0ba1c99 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-dir665.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-dir665.dts @@ -179,12 +179,12 @@ gpio-keys { #address-cells =3D <1>; #size-cells =3D <0>; =20 - reset { + button-reset { label =3D "reset"; linux,code =3D ; gpios =3D <&gpio0 28 GPIO_ACTIVE_LOW>; }; - wps { + button-wps { label =3D "wps"; linux,code =3D ; gpios =3D <&gpio1 14 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-dnskw.dtsi b/arch/arm/boot/= dts/marvell/kirkwood-dnskw.dtsi index 0738eb679fcd..baea14c68520 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-dnskw.dtsi +++ b/arch/arm/boot/dts/marvell/kirkwood-dnskw.dtsi @@ -14,17 +14,17 @@ gpio_keys { &pmx_button_reset>; pinctrl-names =3D "default"; =20 - power { + button-power { label =3D "Power button"; linux,code =3D ; gpios =3D <&gpio1 2 GPIO_ACTIVE_LOW>; }; - eject { + button-eject { label =3D "USB unmount button"; linux,code =3D ; gpios =3D <&gpio1 15 GPIO_ACTIVE_LOW>; }; - reset { + button-reset { label =3D "Reset button"; linux,code =3D ; gpios =3D <&gpio1 16 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-ib62x0.dts b/arch/arm/boot/= dts/marvell/kirkwood-ib62x0.dts index 962a910a6f5c..d76dbbce16f1 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-ib62x0.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-ib62x0.dts @@ -63,12 +63,12 @@ gpio_keys { pinctrl-0 =3D <&pmx_button_reset &pmx_button_usb_copy>; pinctrl-names =3D "default"; =20 - copy { + button-copy { label =3D "USB Copy"; linux,code =3D ; gpios =3D <&gpio0 29 GPIO_ACTIVE_LOW>; }; - reset { + button-reset { label =3D "Reset"; linux,code =3D ; gpios =3D <&gpio0 28 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-iconnect.dts b/arch/arm/boo= t/dts/marvell/kirkwood-iconnect.dts index aed20185fd7a..ea98ff13700e 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-iconnect.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-iconnect.dts @@ -127,13 +127,13 @@ gpio_keys { pinctrl-0 =3D < &pmx_button_reset &pmx_button_otb >; pinctrl-names =3D "default"; =20 - otb { + button-otb { label =3D "OTB Button"; linux,code =3D ; gpios =3D <&gpio1 3 GPIO_ACTIVE_LOW>; debounce-interval =3D <100>; }; - reset { + button-reset { label =3D "Reset"; linux,code =3D ; gpios =3D <&gpio0 12 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-iomega_ix2_200.dts b/arch/a= rm/boot/dts/marvell/kirkwood-iomega_ix2_200.dts index 2338f495d517..fa7ace071de8 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-iomega_ix2_200.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-iomega_ix2_200.dts @@ -154,17 +154,17 @@ gpio-keys { pinctrl-names =3D "default"; =20 =20 - Power { + button-power { label =3D "Power Button"; linux,code =3D ; gpios =3D <&gpio0 14 GPIO_ACTIVE_LOW>; }; - Reset { + button-reset { label =3D "Reset Button"; linux,code =3D ; gpios =3D <&gpio0 12 GPIO_ACTIVE_LOW>; }; - OTB { + button-otb { label =3D "OTB Button"; linux,code =3D ; gpios =3D <&gpio1 3 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-l-50.dts b/arch/arm/boot/dt= s/marvell/kirkwood-l-50.dts index c841eb8e7fb1..094854743dde 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-l-50.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-l-50.dts @@ -193,7 +193,7 @@ express_card_pwr { keys { compatible =3D "gpio-keys"; =20 - factory_defaults { + button-factory-defaults { label =3D "factory_defaults"; gpios =3D <&gpio0 29 GPIO_ACTIVE_LOW>; linux,code =3D ; diff --git a/arch/arm/boot/dts/marvell/kirkwood-laplug.dts b/arch/arm/boot/= dts/marvell/kirkwood-laplug.dts index 8c2b540eaf4f..8296486a5931 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-laplug.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-laplug.dts @@ -51,7 +51,7 @@ pmx_usb_power_enable: pmx-usb-power-enable { gpio_keys { compatible =3D "gpio-keys"; =20 - power { + button-power { label =3D "Power push button"; linux,code =3D ; gpios =3D <&gpio1 0 GPIO_ACTIVE_HIGH>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-linksys-viper.dts b/arch/ar= m/boot/dts/marvell/kirkwood-linksys-viper.dts index 27fd6e2337d5..3f97240fda74 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-linksys-viper.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-linksys-viper.dts @@ -38,13 +38,13 @@ gpio_keys { pinctrl-0 =3D < &pmx_btn_wps &pmx_btn_reset >; pinctrl-names =3D "default"; =20 - wps { + button-wps { label =3D "WPS Button"; linux,code =3D ; gpios =3D <&gpio1 15 GPIO_ACTIVE_LOW>; }; =20 - reset { + button-reset { label =3D "Reset Button"; linux,code =3D ; gpios =3D <&gpio1 16 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-lsxl.dtsi b/arch/arm/boot/d= ts/marvell/kirkwood-lsxl.dtsi index f80af24b9e90..a86dbc490600 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-lsxl.dtsi +++ b/arch/arm/boot/dts/marvell/kirkwood-lsxl.dtsi @@ -113,18 +113,18 @@ gpio_keys { &pmx_power_auto_switch>; pinctrl-names =3D "default"; =20 - option { + button-option { label =3D "Function Button"; linux,code =3D ; gpios =3D <&gpio1 9 GPIO_ACTIVE_LOW>; }; - reserved { + button-reserved { label =3D "Power-on Switch"; linux,code =3D ; linux,input-type =3D <5>; gpios =3D <&gpio1 10 GPIO_ACTIVE_LOW>; }; - power { + button-power { label =3D "Power-auto Switch"; linux,code =3D ; linux,input-type =3D <5>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts b/arch/= arm/boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts index 5a77286136c7..0d5d85c873b5 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts @@ -96,12 +96,12 @@ gpio_keys { pinctrl-0 =3D <&pmx_keys>; pinctrl-names =3D "default"; =20 - restart { + button-restart { label =3D "SWR Button"; linux,code =3D ; gpios =3D <&gpio1 15 GPIO_ACTIVE_LOW>; }; - wps { + button-wps { label =3D "WPS Button"; linux,code =3D ; gpios =3D <&gpio1 14 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-netxbig.dtsi b/arch/arm/boo= t/dts/marvell/kirkwood-netxbig.dtsi index b5737026e244..d0f85893aeca 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-netxbig.dtsi +++ b/arch/arm/boot/dts/marvell/kirkwood-netxbig.dtsi @@ -60,19 +60,19 @@ gpio-keys { * esc and power represent a three position rocker * switch. Thus the conventional KEY_POWER does not fit */ - exc { + button-exc { label =3D "Back power switch (on|auto)"; linux,code =3D ; linux,input-type =3D <5>; gpios =3D <&gpio0 13 GPIO_ACTIVE_LOW>; }; - power { + button-power { label =3D "Back power switch (auto|off)"; linux,code =3D ; linux,input-type =3D <5>; gpios =3D <&gpio0 15 GPIO_ACTIVE_LOW>; }; - option { + button-option { label =3D "Function button"; linux,code =3D ; gpios =3D <&gpio1 2 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-ns2-common.dtsi b/arch/arm/= boot/dts/marvell/kirkwood-ns2-common.dtsi index 51530ea86622..6cc068a05673 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-ns2-common.dtsi +++ b/arch/arm/boot/dts/marvell/kirkwood-ns2-common.dtsi @@ -58,7 +58,7 @@ gpio_keys { #address-cells =3D <1>; #size-cells =3D <0>; =20 - power { + button-power { label =3D "Power push button"; linux,code =3D ; gpios =3D <&gpio1 0 GPIO_ACTIVE_HIGH>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-nsa310s.dts b/arch/arm/boot= /dts/marvell/kirkwood-nsa310s.dts index 49da633a1bc0..767f34ab434e 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-nsa310s.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-nsa310s.dts @@ -40,19 +40,19 @@ keys { pinctrl-0 =3D <&pmx_buttons>; pinctrl-names =3D "default"; =20 - power { + button-power { label =3D "Power Button"; linux,code =3D ; gpios =3D <&gpio0 26 GPIO_ACTIVE_HIGH>; }; =20 - copy { + button-copy { label =3D "Copy Button"; linux,code =3D ; gpios =3D <&gpio0 25 GPIO_ACTIVE_LOW>; }; =20 - reset { + button-reset { label =3D "Reset Button"; linux,code =3D ; gpios =3D <&gpio0 24 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-nsa3x0-common.dtsi b/arch/a= rm/boot/dts/marvell/kirkwood-nsa3x0-common.dtsi index ea3d36512e9f..bdce8a86ce51 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-nsa3x0-common.dtsi +++ b/arch/arm/boot/dts/marvell/kirkwood-nsa3x0-common.dtsi @@ -68,17 +68,17 @@ gpio_keys { pinctrl-0 =3D <&pmx_btn_reset &pmx_btn_copy &pmx_btn_power>; pinctrl-names =3D "default"; =20 - power { + button-power { label =3D "Power Button"; linux,code =3D ; gpios =3D <&gpio1 14 GPIO_ACTIVE_HIGH>; }; - copy { + button-copy { label =3D "Copy Button"; linux,code =3D ; gpios =3D <&gpio1 5 GPIO_ACTIVE_LOW>; }; - reset { + button-reset { label =3D "Reset Button"; linux,code =3D ; gpios =3D <&gpio1 4 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-openblocks_a6.dts b/arch/ar= m/boot/dts/marvell/kirkwood-openblocks_a6.dts index 8ea430168ea5..ef6d6d7a4008 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-openblocks_a6.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-openblocks_a6.dts @@ -118,7 +118,7 @@ gpio_keys { #address-cells =3D <1>; #size-cells =3D <0>; =20 - power { + button-power { label =3D "Init Button"; linux,code =3D ; gpios =3D <&gpio1 6 GPIO_ACTIVE_HIGH>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-pogoplug-series-4.dts b/arc= h/arm/boot/dts/marvell/kirkwood-pogoplug-series-4.dts index 5aa4669ae254..601760041c99 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-pogoplug-series-4.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-pogoplug-series-4.dts @@ -34,7 +34,7 @@ gpio_keys { pinctrl-0 =3D <&pmx_button_eject>; pinctrl-names =3D "default"; =20 - eject { + button-eject { debounce-interval =3D <50>; wakeup-source; linux,code =3D ; diff --git a/arch/arm/boot/dts/marvell/kirkwood-t5325.dts b/arch/arm/boot/d= ts/marvell/kirkwood-t5325.dts index ad093324e075..6703e412c8e2 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-t5325.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-t5325.dts @@ -161,7 +161,7 @@ gpio_keys { pinctrl-0 =3D <&pmx_button_power>; pinctrl-names =3D "default"; =20 - power { + button-power { label =3D "Power Button"; linux,code =3D ; gpios =3D <&gpio1 13 GPIO_ACTIVE_HIGH>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-ts219-6281.dts b/arch/arm/b= oot/dts/marvell/kirkwood-ts219-6281.dts index 30892c19aceb..859521b5b84e 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-ts219-6281.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-ts219-6281.dts @@ -40,12 +40,12 @@ gpio_keys { pinctrl-0 =3D <&pmx_reset_button &pmx_USB_copy_button>; pinctrl-names =3D "default"; =20 - copy { + button-copy { label =3D "USB Copy"; linux,code =3D ; gpios =3D <&gpio0 15 GPIO_ACTIVE_LOW>; }; - reset { + button-reset { label =3D "Reset"; linux,code =3D ; gpios =3D <&gpio0 16 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-ts219-6282.dts b/arch/arm/b= oot/dts/marvell/kirkwood-ts219-6282.dts index aba1205981f1..3b0a4ed588e8 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-ts219-6282.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-ts219-6282.dts @@ -40,12 +40,12 @@ gpio_keys { pinctrl-0 =3D <&pmx_reset_button &pmx_USB_copy_button>; pinctrl-names =3D "default"; =20 - copy { + button-copy { label =3D "USB Copy"; linux,code =3D ; gpios =3D <&gpio1 11 GPIO_ACTIVE_LOW>; }; - reset { + button-reset { label =3D "Reset"; linux,code =3D ; gpios =3D <&gpio1 5 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/marvell/kirkwood-ts419.dtsi b/arch/arm/boot/= dts/marvell/kirkwood-ts419.dtsi index 717236853e45..126db753c8fe 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-ts419.dtsi +++ b/arch/arm/boot/dts/marvell/kirkwood-ts419.dtsi @@ -41,12 +41,12 @@ gpio_keys { pinctrl-0 =3D <&pmx_reset_button &pmx_USB_copy_button>; pinctrl-names =3D "default"; =20 - copy { + button-copy { label =3D "USB Copy"; linux,code =3D ; gpios =3D <&gpio1 11 GPIO_ACTIVE_LOW>; }; - reset { + button-reset { label =3D "Reset"; linux,code =3D ; gpios =3D <&gpio1 5 GPIO_ACTIVE_LOW>; --=20 2.43.0 From nobody Tue Feb 10 02:47:39 2026 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33C7F16C6B8 for ; Mon, 1 Jul 2024 14:56:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719845810; cv=none; b=rFaU3RBd5gGWH+amhid1rpQ146BkqjE+kCNrdUi18NG1dQAXX+sk9pXQTYTSackJgl6MMyWqNzfWoP07q6ZZFKzh6RHFdkunrCxdz8vU2gNfRgEeOZYX0BbgQ5ReSilk2wXuXIdc8McJNvkqFcf76RWwF4m3feOpsriWW81OlyI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719845810; c=relaxed/simple; bh=NEPSfOxaqM8gOXmgm7ZxD/8mLRI8BGKty4k6NfrPTow=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RgyX0BPYr4JTonGEH0yaQufCuU5CoyOted4uW6PzUQPr9UIZGJlvFWLoFsTYwfe/EKo6osBHozdmRryq6Ccmas0GjT5glf10kMBjwa8o2V9BUwZ27HjToxWU0mr67fF45lappwpyd07/rQapYDmvw31RQKMYAGGXHc4tvpYOVZ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NL3Q02t0; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NL3Q02t0" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2ec5fad1984so43109021fa.0 for ; Mon, 01 Jul 2024 07:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719845806; x=1720450606; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rXFEZx0udsk0lxzY2jdV+4pcISLPkDF6XpicWae74LU=; b=NL3Q02t0zxvKFXiNsCyXsh/nDiHtfI/BuN1vqUmRwa+sALA5FBQbfo9EoCJWVRdSPP 67OkHJZOC9qRzsqOWacjH/pGCKTL6xpObPCaUnwHytyFqKrTqmJ/zh8cuJL05reMTGUB QL4i7YlfP3QBrXkD9rWI1kAiB9RCNEbbwH64zVAdvw6Y9o3jK1gam5Gva0+JOveobrIV qUgVvWfn2UalxG06GgJGKZj5vpOCWGV8R4iRUmOiyBjrfMc2PBE+JjRNy9w4IBFL9Hnc xbSSQ9gkyz91cQhWV6q2UssNXHEL53UdNQ5NAduKHNeIJ87e1A+22hC6SuV8LMvNRArn qvSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719845806; x=1720450606; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rXFEZx0udsk0lxzY2jdV+4pcISLPkDF6XpicWae74LU=; b=eYvf+kI3WzvnK4cmP/lxFniIghC+fNnG4kQtbSmbQpFUOzLUj+LjIKaUUsgL5BoMQj j9KMXFhu4vSuxdpiN7xdNyCTfOkC6WNRmUE8CM0YRgwJtdaqR2Zc+nrt2khq/fpzqiyw 0hXmM/6fFI1WtuMhWGGfpPenWh6OEzGWlI+KomEKOzyOm2UPDuJsLHqj3m4jmqTwo3L8 Mgn+Ac4FqIEcVPNa1oz2EUeLQDhpnRRUnJh+oOxhpQ24WgbX+KFW9kFaYxe5IyrGa6+h k9MeDLOvQSwrXghXs8hsvC9Nbj86BAt/6kZAkmYk5KVrISyy8EyJoQfcgRO68xokIShT 4oEg== X-Forwarded-Encrypted: i=1; AJvYcCXO3xj7C/+LPXwL1QtmdyMLu5fOPgKbptDI8SyROfNf2JxUU65pLaFaOeelVuVp9frKo3VqmWXg21HjeEgtObNX1fFOrWhKLl8xEuru X-Gm-Message-State: AOJu0YzIb4VHtx7zJICGFZxgk5bN0AE9nimtguXcvPV/7t0yG8UcMlMP 8J6cWacENnk8Q4SJyH+AOBpOvO5JmgUCwNcJ3yaot3MU2bqFKY8dZX9oA/JsQmkYf0zH7v7dXt0 I X-Google-Smtp-Source: AGHT+IGUuYy2SeiLbKShnwuk0VB0f/oTMLlaglBaLfapZR2FTp7i7OuuISmeZFTge5g5+GjjgV+adA== X-Received: by 2002:a2e:9a13:0:b0:2ee:64cf:f8f3 with SMTP id 38308e7fff4ca-2ee64cffe44mr44493271fa.33.1719845805812; Mon, 01 Jul 2024 07:56:45 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.137]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256b0c0f99sm160062915e9.41.2024.07.01.07.56.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 07:56:45 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 01 Jul 2024 16:56:35 +0200 Subject: [PATCH 2/7] ARM: dts: marvell: kirkwood: drop incorrect address/size-cells in GPIO keys Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240701-dts-marvell-cleanup-v1-2-4773bd20691a@linaro.org> References: <20240701-dts-marvell-cleanup-v1-0-4773bd20691a@linaro.org> In-Reply-To: <20240701-dts-marvell-cleanup-v1-0-4773bd20691a@linaro.org> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=12028; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=NEPSfOxaqM8gOXmgm7ZxD/8mLRI8BGKty4k6NfrPTow=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmgsOk6ud2OwR0U4BFEE8tFivP5+DYlM03AaQwi dz/E48OzC2JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZoLDpAAKCRDBN2bmhouD 1ywhD/4ycQwgCU7+gy/WuQM/uuU/l3Nildt45XTPANM4XHK4OY5J7RPJTr32U5DwF0OgwgQX1fH P2pdOU/CKzFYlNF1VPWAq+n9rDOjiHeh+hEsAxg/mYuaAdbpjEy31FO9Qg92arKlu2EMvR9+wYh R8/qjql7ORKMiLiLGMZjTM7GksqA/p4iHIKcLK3IJm4E2NCUx5kgu6Fz1dFzHTsnM1RHLESAtHl MqT0HsxVcDaGrcwXOJnJoAOUU/8q69U+oUkt9C5jaMmqTh6OojtCZMyHf3Q0STwzHO8oFm+5X5T YRB9iNYWLnY64+uZR4Apj+TFGg/Gba5B/0y7sSgH8hqUrG6BtgMXUvpa5iHaJkseAQOzA75rupx wN/FnKP2FnKlOFfLDsrWWm+GbIu8FIpuAz60dP1pWLlgz2BO49KXM/k09MEfBYuGaJIE5oK19pq Njy2hfnVrZy0KWXcQPgZcTxOQ2XFn8uLlTzWP+0JrskIF0E+uzuqVzfFBOgmVsS5iO1vE1PzzWd G3ztrAFfsdR0hAx5z2pDf2jH2H2UJEE5tEk3toeC4WIyaB+NJ4dq6U1r6Jg9WHY8ZLc3NUtN1Js xxkTYOlhLoH9uAtQ2wPkjCMFWxz+pntTUbbLrLUwqM4bTlJu9hyWNwqhS1slPm7IaYqSsS+J4aA pOg6eGn9yn0p49g== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Bindings do not allow address/size-cells in GPIO keys and the GPIO keys is not a bus, see dtbs_check warnings: kirkwood-openblocks_a7.dtb: gpio_keys: '#address-cells', '#size-cells' do= not match any of the regexes: '^(button|event|key|switch|(button|event|key= |switch)... Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/marvell/kirkwood-cloudbox.dts | 2 -- arch/arm/boot/dts/marvell/kirkwood-dir665.dts | 2 -- arch/arm/boot/dts/marvell/kirkwood-dnskw.dtsi | 2 -- arch/arm/boot/dts/marvell/kirkwood-ib62x0.dts | 2 -- arch/arm/boot/dts/marvell/kirkwood-iconnect.dts | 2 -- arch/arm/boot/dts/marvell/kirkwood-iomega_ix2_200.dts | 2 -- arch/arm/boot/dts/marvell/kirkwood-linkstation.dtsi | 2 -- arch/arm/boot/dts/marvell/kirkwood-linksys-viper.dts | 2 -- arch/arm/boot/dts/marvell/kirkwood-lsxl.dtsi | 2 -- arch/arm/boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts | 2 -- arch/arm/boot/dts/marvell/kirkwood-netxbig.dtsi | 2 -- arch/arm/boot/dts/marvell/kirkwood-ns2-common.dtsi | 2 -- arch/arm/boot/dts/marvell/kirkwood-nsa310s.dts | 2 -- arch/arm/boot/dts/marvell/kirkwood-nsa3x0-common.dtsi | 2 -- arch/arm/boot/dts/marvell/kirkwood-openblocks_a6.dts | 2 -- arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts | 2 -- arch/arm/boot/dts/marvell/kirkwood-pogoplug-series-4.dts | 2 -- arch/arm/boot/dts/marvell/kirkwood-t5325.dts | 2 -- arch/arm/boot/dts/marvell/kirkwood-ts219-6281.dts | 2 -- arch/arm/boot/dts/marvell/kirkwood-ts219-6282.dts | 2 -- arch/arm/boot/dts/marvell/kirkwood-ts419.dtsi | 2 -- 21 files changed, 42 deletions(-) diff --git a/arch/arm/boot/dts/marvell/kirkwood-cloudbox.dts b/arch/arm/boo= t/dts/marvell/kirkwood-cloudbox.dts index 2582b84d8415..92897f8b637b 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-cloudbox.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-cloudbox.dts @@ -58,8 +58,6 @@ partition@0 { =20 gpio_keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; =20 key-power { label =3D "Power push button"; diff --git a/arch/arm/boot/dts/marvell/kirkwood-dir665.dts b/arch/arm/boot/= dts/marvell/kirkwood-dir665.dts index e8eff0ba1c99..1d1f4cdedab2 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-dir665.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-dir665.dts @@ -176,8 +176,6 @@ blue-24g { =20 gpio-keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; =20 button-reset { label =3D "reset"; diff --git a/arch/arm/boot/dts/marvell/kirkwood-dnskw.dtsi b/arch/arm/boot/= dts/marvell/kirkwood-dnskw.dtsi index baea14c68520..20bcd031f3f5 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-dnskw.dtsi +++ b/arch/arm/boot/dts/marvell/kirkwood-dnskw.dtsi @@ -8,8 +8,6 @@ / { =20 gpio_keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; pinctrl-0 =3D <&pmx_button_power &pmx_button_unmount &pmx_button_reset>; pinctrl-names =3D "default"; diff --git a/arch/arm/boot/dts/marvell/kirkwood-ib62x0.dts b/arch/arm/boot/= dts/marvell/kirkwood-ib62x0.dts index d76dbbce16f1..0f50eb2d5931 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-ib62x0.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-ib62x0.dts @@ -58,8 +58,6 @@ sata@80000 { =20 gpio_keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; pinctrl-0 =3D <&pmx_button_reset &pmx_button_usb_copy>; pinctrl-names =3D "default"; =20 diff --git a/arch/arm/boot/dts/marvell/kirkwood-iconnect.dts b/arch/arm/boo= t/dts/marvell/kirkwood-iconnect.dts index ea98ff13700e..a2782fe3d379 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-iconnect.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-iconnect.dts @@ -122,8 +122,6 @@ otb { =20 gpio_keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; pinctrl-0 =3D < &pmx_button_reset &pmx_button_otb >; pinctrl-names =3D "default"; =20 diff --git a/arch/arm/boot/dts/marvell/kirkwood-iomega_ix2_200.dts b/arch/a= rm/boot/dts/marvell/kirkwood-iomega_ix2_200.dts index fa7ace071de8..91409ae949c4 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-iomega_ix2_200.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-iomega_ix2_200.dts @@ -147,8 +147,6 @@ backup_led { }; gpio-keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; pinctrl-0 =3D <&pmx_button_reset &pmx_button_power &pmx_button_otb>; pinctrl-names =3D "default"; diff --git a/arch/arm/boot/dts/marvell/kirkwood-linkstation.dtsi b/arch/arm= /boot/dts/marvell/kirkwood-linkstation.dtsi index b54c9980f636..8a11d2b9d449 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-linkstation.dtsi +++ b/arch/arm/boot/dts/marvell/kirkwood-linkstation.dtsi @@ -88,8 +88,6 @@ partition@70000 { =20 gpio_keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; pinctrl-0 =3D <&pmx_button_function &pmx_power_switch &pmx_power_auto_switch>; pinctrl-names =3D "default"; diff --git a/arch/arm/boot/dts/marvell/kirkwood-linksys-viper.dts b/arch/ar= m/boot/dts/marvell/kirkwood-linksys-viper.dts index 3f97240fda74..ddefaf628501 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-linksys-viper.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-linksys-viper.dts @@ -33,8 +33,6 @@ chosen { =20 gpio_keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; pinctrl-0 =3D < &pmx_btn_wps &pmx_btn_reset >; pinctrl-names =3D "default"; =20 diff --git a/arch/arm/boot/dts/marvell/kirkwood-lsxl.dtsi b/arch/arm/boot/d= ts/marvell/kirkwood-lsxl.dtsi index a86dbc490600..c0f80146706d 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-lsxl.dtsi +++ b/arch/arm/boot/dts/marvell/kirkwood-lsxl.dtsi @@ -107,8 +107,6 @@ partition@70000 { =20 gpio_keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; pinctrl-0 =3D <&pmx_button_function &pmx_power_switch &pmx_power_auto_switch>; pinctrl-names =3D "default"; diff --git a/arch/arm/boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts b/arch/= arm/boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts index 0d5d85c873b5..fd3813ace0c1 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts @@ -91,8 +91,6 @@ green-usb { =20 gpio_keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; pinctrl-0 =3D <&pmx_keys>; pinctrl-names =3D "default"; =20 diff --git a/arch/arm/boot/dts/marvell/kirkwood-netxbig.dtsi b/arch/arm/boo= t/dts/marvell/kirkwood-netxbig.dtsi index d0f85893aeca..d4edf2727388 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-netxbig.dtsi +++ b/arch/arm/boot/dts/marvell/kirkwood-netxbig.dtsi @@ -53,8 +53,6 @@ sata@80000 { =20 gpio-keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; =20 /* * esc and power represent a three position rocker diff --git a/arch/arm/boot/dts/marvell/kirkwood-ns2-common.dtsi b/arch/arm/= boot/dts/marvell/kirkwood-ns2-common.dtsi index 6cc068a05673..28f09f71b24d 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-ns2-common.dtsi +++ b/arch/arm/boot/dts/marvell/kirkwood-ns2-common.dtsi @@ -55,8 +55,6 @@ eeprom@50 { =20 gpio_keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; =20 button-power { label =3D "Power push button"; diff --git a/arch/arm/boot/dts/marvell/kirkwood-nsa310s.dts b/arch/arm/boot= /dts/marvell/kirkwood-nsa310s.dts index 767f34ab434e..47deb93c90a5 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-nsa310s.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-nsa310s.dts @@ -35,8 +35,6 @@ gpio_poweroff { =20 keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; pinctrl-0 =3D <&pmx_buttons>; pinctrl-names =3D "default"; =20 diff --git a/arch/arm/boot/dts/marvell/kirkwood-nsa3x0-common.dtsi b/arch/a= rm/boot/dts/marvell/kirkwood-nsa3x0-common.dtsi index bdce8a86ce51..e9bd9c551af5 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-nsa3x0-common.dtsi +++ b/arch/arm/boot/dts/marvell/kirkwood-nsa3x0-common.dtsi @@ -63,8 +63,6 @@ gpio_poweroff { =20 gpio_keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; pinctrl-0 =3D <&pmx_btn_reset &pmx_btn_copy &pmx_btn_power>; pinctrl-names =3D "default"; =20 diff --git a/arch/arm/boot/dts/marvell/kirkwood-openblocks_a6.dts b/arch/ar= m/boot/dts/marvell/kirkwood-openblocks_a6.dts index ef6d6d7a4008..20c6290d2037 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-openblocks_a6.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-openblocks_a6.dts @@ -115,8 +115,6 @@ gpio_keys { compatible =3D "gpio-keys"; pinctrl-0 =3D <&pmx_gpio_init>; pinctrl-names =3D "default"; - #address-cells =3D <1>; - #size-cells =3D <0>; =20 button-power { label =3D "Init Button"; diff --git a/arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts b/arch/ar= m/boot/dts/marvell/kirkwood-openblocks_a7.dts index 946f0f453dd1..9c438f10f737 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-openblocks_a7.dts @@ -136,8 +136,6 @@ gpio_keys { compatible =3D "gpio-keys"; pinctrl-0 =3D <&pmx_gpio_init>; pinctrl-names =3D "default"; - #address-cells =3D <1>; - #size-cells =3D <0>; =20 button { label =3D "Init Button"; diff --git a/arch/arm/boot/dts/marvell/kirkwood-pogoplug-series-4.dts b/arc= h/arm/boot/dts/marvell/kirkwood-pogoplug-series-4.dts index 601760041c99..b66fc4d57410 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-pogoplug-series-4.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-pogoplug-series-4.dts @@ -29,8 +29,6 @@ chosen { =20 gpio_keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; pinctrl-0 =3D <&pmx_button_eject>; pinctrl-names =3D "default"; =20 diff --git a/arch/arm/boot/dts/marvell/kirkwood-t5325.dts b/arch/arm/boot/d= ts/marvell/kirkwood-t5325.dts index 6703e412c8e2..a6e77a487d00 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-t5325.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-t5325.dts @@ -156,8 +156,6 @@ usb_power: regulator@1 { =20 gpio_keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; pinctrl-0 =3D <&pmx_button_power>; pinctrl-names =3D "default"; =20 diff --git a/arch/arm/boot/dts/marvell/kirkwood-ts219-6281.dts b/arch/arm/b= oot/dts/marvell/kirkwood-ts219-6281.dts index 859521b5b84e..a2e0ad4b84d8 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-ts219-6281.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-ts219-6281.dts @@ -35,8 +35,6 @@ pmx_board_id: pmx-board-id { =20 gpio_keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; pinctrl-0 =3D <&pmx_reset_button &pmx_USB_copy_button>; pinctrl-names =3D "default"; =20 diff --git a/arch/arm/boot/dts/marvell/kirkwood-ts219-6282.dts b/arch/arm/b= oot/dts/marvell/kirkwood-ts219-6282.dts index 3b0a4ed588e8..35be6bce1dba 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-ts219-6282.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-ts219-6282.dts @@ -35,8 +35,6 @@ pmx_board_id: pmx-board-id { =20 gpio_keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; pinctrl-0 =3D <&pmx_reset_button &pmx_USB_copy_button>; pinctrl-names =3D "default"; =20 diff --git a/arch/arm/boot/dts/marvell/kirkwood-ts419.dtsi b/arch/arm/boot/= dts/marvell/kirkwood-ts419.dtsi index 126db753c8fe..f136059607b7 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-ts419.dtsi +++ b/arch/arm/boot/dts/marvell/kirkwood-ts419.dtsi @@ -36,8 +36,6 @@ pmx_jumper_jp1: pmx-jumper_jp1 { =20 gpio_keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; pinctrl-0 =3D <&pmx_reset_button &pmx_USB_copy_button>; pinctrl-names =3D "default"; =20 --=20 2.43.0 From nobody Tue Feb 10 02:47:39 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB9E416C6AA for ; Mon, 1 Jul 2024 14:56:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719845812; cv=none; b=NmX6r3bcXWqoTs+bIdDxzLIzhAtFYTyx84ApN57IG0txXvpYDxCjSgGahk4IlC21N+MWQXZLhQnDPSaUs4ThEMorpfHdo5Db0eOd7XZ+K5BtYlxEdO7lVgvkIlg7OHbOMppBMpkHe+rDWCGVWRTOXCpNsoPLr2oyZT/AY7iY+x0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719845812; c=relaxed/simple; bh=Q1NUZUtC4GG3C6QOvJgf4AOWOBQMLmgY6uYJKF+rfe4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KeuJf6nrhWVFtvWKYyXW10ZxZiDrHYVHTYcfvhibllDgRUGgVLOEikqKYgE2y9GwKh52szog3K1fAzw5HSv7C93My3gXj/o7ePXXvaw1BnJbsaG4OtPONlgSYx6cEb8wAvVjHvq90ixRndR8LqHf3UxEuCmtNJPabQlC737Y0kw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JGQWCVA5; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JGQWCVA5" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-42561c16ffeso24442865e9.3 for ; Mon, 01 Jul 2024 07:56:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719845808; x=1720450608; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mQ0c+IOKkUe0E3OrCRXiJ8eeG27mFVJAKR5cx71uFwg=; b=JGQWCVA5CJweO5WkvD7xGU9o0Vi76QNq75705Qdy2FeBx1fKEGBm2ymdRKlBpBlfpW IRnkTvNBokNBkNIRyagMAecdDIc+mM4zOLoanJJotGP0shHZSQGoXueZfbWNnW03VyaE kNqUHlJNUz19voUmSj+3N7X1bJNaxXgxhpSf9ap+gJqtv0/8IdUg3Lyf59J2YA46+0rp 9jn3DknqsqM3ThHuogoVwweJ0Fp280vmaShaigwTru4c/feIniqOqukoHtuMzrs31Vuv 5QD+bBvNnB0yhIPB9MHVcYzy3AUygVj3Mnef42T1UPkdA0w2VkbBFTJbJfG3sHoPq+iJ mJYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719845808; x=1720450608; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mQ0c+IOKkUe0E3OrCRXiJ8eeG27mFVJAKR5cx71uFwg=; b=iChBVSC3bcc7Q60iRJJTpGHez1Jky6iLn8rstI7rktRTEPlo/b8vMMx31zmqy4h9yn KlyXL8sj0wKU+sBP/kqWHn0J9Oba7lNdGZzGoZuaeLPTBcfYSxE9ceeBAaoXWt2CdI2N izCfMmNxjyMJkoYofksJkpS5nKpGLykgSbGJVgBDMig0b6PE1HOB8PZ+5EwRGxhq0/je tPnWZnmqPagFJyX/yU0Ko5y3TzUHPJXH0h4Cqw8r7CN9pOY/stimk+lYxOW2R6OVUwUA 0+eWNt0ZU6oOETcrPKLF7XaUM1FatE+F1F0zyzq1bRkztxq1ZAxT4zNxAGOJQM7sEaj9 MeQQ== X-Forwarded-Encrypted: i=1; AJvYcCXt7bNXNLHKL/vI/AM3hnrDQfTGlFt/1P2lQ0mBMOHgFzeH8JVGnVnc3G7mHTWoi/QuS/k/qqzEnkEIS2QFfTuAfc42WbESCbCP8yN/ X-Gm-Message-State: AOJu0YzmQPvWsbO3CY1UpeO8p2FbZ30siSXUm2sZGwxcT+tjwQMzkOCP SNvHOjB6wdK/tLgwnNEmJ1V4L6kVq8TwJFnUIxGSzRwWZ3Z9JsOMbu7w9hg47HPnKugggyVRVjv 2 X-Google-Smtp-Source: AGHT+IEqgPzDRjbCsJB/7GrlivE3MAxrFEqYxvomzupSXQraXO65qTSvx8t6+a3i44nvsYyUkG3sEg== X-Received: by 2002:a7b:ca4a:0:b0:423:b756:cdaf with SMTP id 5b1f17b1804b1-4257a02f3b2mr38614135e9.23.1719845807277; Mon, 01 Jul 2024 07:56:47 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.137]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256b0c0f99sm160062915e9.41.2024.07.01.07.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 07:56:46 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 01 Jul 2024 16:56:36 +0200 Subject: [PATCH 3/7] ARM: dts: marvell: kirkwood: align LED node name with bindings Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240701-dts-marvell-cleanup-v1-3-4773bd20691a@linaro.org> References: <20240701-dts-marvell-cleanup-v1-0-4773bd20691a@linaro.org> In-Reply-To: <20240701-dts-marvell-cleanup-v1-0-4773bd20691a@linaro.org> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=33749; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=Q1NUZUtC4GG3C6QOvJgf4AOWOBQMLmgY6uYJKF+rfe4=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmgsOljOJ5Lnn9VbFjhoyoybYNhM57XfPS6W8lx GzbaCZixbeJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZoLDpQAKCRDBN2bmhouD 14YqD/9Zemi6xlrATyH2lb95bAAooYZdus4yuJ4KdUwI/K/7DVoU3OU6FLXdeE3FFE246BVZpjb u7V1wHP39KOpuq2iIMKpO661GpSQC5hRmvhROMaDBac1j2P7qdQQVdoZHDgIw46mKH6jC9lo5Do AmumZnojuQlsORELMnYql8PYTikkn01qsOO+WAUO69GagBKiUdgLmfhZIEW6Ft0FLFWNn7Hcn+7 kckBRdQ60DYn+MJWc5pgpn0XOszflcH3EMjQL7jT++h4sBKLvUHLkAZ2m+mbD3RFVDaxq78KwNm 2Uh5hi40HMWrbsJmBhuX48bQqN1XeVoDRAmoZ4XPsiANJ8wWMRWF2LIad6gmpXY29BA0qBcMT/G 4l2lazV/j+0o8na1CKS2rTgRylvEY+zgWMuaqPVc+6P/8HX0AtmPO18iGxUR45v/libJcL/LxCH I7h1WI9Nj926/68wutM2KR3OYDabhrHTxu0DqtnHvc4W8hmYkXKojGL6/ULNfey0MlYi3Cr/sC3 mGUrTzhnCPcqJO3Pz6PboIJ3eGqQDafw55iy4kR0KicWo9Wc5KiRiNHg8MaXqcYynkr1w804oCW lffp8CIGgcOtr1PJYNpeaAOwNY0vP7Z7vB+pBlktjOuzZ5TIaIaglJgDrKk2DY8uUECmQQyiHXA /ElLOyzmcoF72OA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Bindings expect the LED node names to follow certain pattern, see dtbs_check warnings: kirkwood-ds409slim.dtb: gpio-leds-alarm-12: 'hdd1-green' does not match a= ny of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- .../dts/marvell/kirkwood-blackarmor-nas220.dts | 2 +- arch/arm/boot/dts/marvell/kirkwood-cloudbox.dts | 4 +- arch/arm/boot/dts/marvell/kirkwood-d2net.dts | 2 +- arch/arm/boot/dts/marvell/kirkwood-dir665.dts | 16 +++--- arch/arm/boot/dts/marvell/kirkwood-dns320.dts | 10 ++-- arch/arm/boot/dts/marvell/kirkwood-dns325.dts | 10 ++-- arch/arm/boot/dts/marvell/kirkwood-dockstar.dts | 4 +- arch/arm/boot/dts/marvell/kirkwood-dreamplug.dts | 6 +-- arch/arm/boot/dts/marvell/kirkwood-goflexnet.dts | 20 ++++---- .../dts/marvell/kirkwood-guruplug-server-plus.dts | 8 +-- arch/arm/boot/dts/marvell/kirkwood-ib62x0.dts | 6 +-- arch/arm/boot/dts/marvell/kirkwood-iconnect.dts | 14 +++--- .../boot/dts/marvell/kirkwood-iomega_ix2_200.dts | 8 +-- arch/arm/boot/dts/marvell/kirkwood-l-50.dts | 18 +++---- arch/arm/boot/dts/marvell/kirkwood-laplug.dts | 4 +- .../boot/dts/marvell/kirkwood-linksys-viper.dts | 4 +- arch/arm/boot/dts/marvell/kirkwood-lsxl.dtsi | 10 ++-- arch/arm/boot/dts/marvell/kirkwood-mplcec4.dts | 12 ++--- .../boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts | 6 +-- arch/arm/boot/dts/marvell/kirkwood-ns2-common.dtsi | 2 +- arch/arm/boot/dts/marvell/kirkwood-ns2lite.dts | 2 +- arch/arm/boot/dts/marvell/kirkwood-nsa310.dts | 20 ++++---- arch/arm/boot/dts/marvell/kirkwood-nsa310a.dts | 18 +++---- arch/arm/boot/dts/marvell/kirkwood-nsa320.dts | 18 +++---- arch/arm/boot/dts/marvell/kirkwood-nsa325.dts | 18 +++---- arch/arm/boot/dts/marvell/kirkwood-pogo_e02.dts | 4 +- .../dts/marvell/kirkwood-pogoplug-series-4.dts | 4 +- .../boot/dts/marvell/kirkwood-sheevaplug-esata.dts | 2 +- arch/arm/boot/dts/marvell/kirkwood-sheevaplug.dts | 4 +- arch/arm/boot/dts/marvell/kirkwood-synology.dtsi | 58 +++++++++++-------= ---- 30 files changed, 157 insertions(+), 157 deletions(-) diff --git a/arch/arm/boot/dts/marvell/kirkwood-blackarmor-nas220.dts b/arc= h/arm/boot/dts/marvell/kirkwood-blackarmor-nas220.dts index f34c3897ff48..36b90c632fd6 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-blackarmor-nas220.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-blackarmor-nas220.dts @@ -51,7 +51,7 @@ button-power { gpio-leds { compatible =3D "gpio-leds"; =20 - blue-power { + led-blue-power { label =3D "nas220:blue:power"; gpios =3D <&gpio0 12 GPIO_ACTIVE_HIGH>; linux,default-trigger =3D "default-on"; diff --git a/arch/arm/boot/dts/marvell/kirkwood-cloudbox.dts b/arch/arm/boo= t/dts/marvell/kirkwood-cloudbox.dts index 92897f8b637b..151edcd140a0 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-cloudbox.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-cloudbox.dts @@ -69,11 +69,11 @@ key-power { gpio-leds { compatible =3D "gpio-leds"; =20 - red-fail { + led-red-fail { label =3D "cloudbox:red:fail"; gpios =3D <&gpio0 14 GPIO_ACTIVE_HIGH>; }; - blue-sata { + led-blue-sata { label =3D "cloudbox:blue:sata"; gpios =3D <&gpio0 15 GPIO_ACTIVE_HIGH>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-d2net.dts b/arch/arm/boot/d= ts/marvell/kirkwood-d2net.dts index bd3b266dd766..fcce8730d3e3 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-d2net.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-d2net.dts @@ -37,7 +37,7 @@ NS_V2_LED_ON 1 1 gpio-leds { compatible =3D "gpio-leds"; =20 - red-fail { + led-red-fail { label =3D "d2net_v2:red:fail"; gpios =3D <&gpio0 12 GPIO_ACTIVE_HIGH>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-dir665.dts b/arch/arm/boot/= dts/marvell/kirkwood-dir665.dts index 1d1f4cdedab2..2f6793f794cd 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-dir665.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-dir665.dts @@ -137,38 +137,38 @@ ehci@50000 { gpio-leds { compatible =3D "gpio-leds"; =20 - blue-usb { + led-blue-usb { label =3D "dir665:blue:usb"; gpios =3D <&gpio0 12 GPIO_ACTIVE_HIGH>; }; - blue-internet { + led-blue-internet { /* Can only be turned on if the Internet * Ethernet port has Link */ label =3D "dir665:blue:internet"; gpios =3D <&gpio1 10 GPIO_ACTIVE_LOW>; }; - amber-internet { + led-amber-internet { label =3D "dir665:amber:internet"; gpios =3D <&gpio1 11 GPIO_ACTIVE_HIGH>; }; - blue-wifi5g { + led-blue-wifi5g { label =3D "dir665:blue:5g"; gpios =3D <&gpio1 12 GPIO_ACTIVE_LOW>; }; - blue-status { + led-blue-status { label =3D "dir665:blue:status"; gpios =3D <&gpio1 13 GPIO_ACTIVE_HIGH>; }; - blue-wps { + led-blue-wps { label =3D "dir665:blue:wps"; gpios =3D <&gpio1 15 GPIO_ACTIVE_HIGH>; }; - amber-status { + led-amber-status { label =3D "dir665:amber:status"; gpios =3D <&gpio1 16 GPIO_ACTIVE_HIGH>; }; - blue-24g { + led-blue-24g { label =3D "dir665:blue:24g"; gpios =3D <&gpio1 17 GPIO_ACTIVE_LOW>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-dns320.dts b/arch/arm/boot/= dts/marvell/kirkwood-dns320.dts index d6b0f418fd01..d8279e0c4c4f 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-dns320.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-dns320.dts @@ -24,24 +24,24 @@ &pmx_led_red_left_hdd &pmx_led_red_right_hdd &pmx_led_white_usb>; pinctrl-names =3D "default"; =20 - blue-power { + led-blue-power { label =3D "dns320:blue:power"; gpios =3D <&gpio0 26 GPIO_ACTIVE_LOW>; default-state =3D "keep"; }; - blue-usb { + led-blue-usb { label =3D "dns320:blue:usb"; gpios =3D <&gpio1 11 GPIO_ACTIVE_LOW>; }; - orange-l_hdd { + led-orange-l_hdd { label =3D "dns320:orange:l_hdd"; gpios =3D <&gpio0 28 GPIO_ACTIVE_LOW>; }; - orange-r_hdd { + led-orange-r_hdd { label =3D "dns320:orange:r_hdd"; gpios =3D <&gpio0 27 GPIO_ACTIVE_LOW>; }; - orange-usb { + led-orange-usb { label =3D "dns320:orange:usb"; gpios =3D <&gpio1 3 GPIO_ACTIVE_LOW>; /* GPIO 35 */ }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-dns325.dts b/arch/arm/boot/= dts/marvell/kirkwood-dns325.dts index 94d9c06cbbf5..7f396195e977 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-dns325.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-dns325.dts @@ -24,24 +24,24 @@ &pmx_led_red_left_hdd &pmx_led_red_right_hdd &pmx_led_white_usb>; pinctrl-names =3D "default"; =20 - white-power { + led-white-power { label =3D "dns325:white:power"; gpios =3D <&gpio0 26 GPIO_ACTIVE_LOW>; default-state =3D "keep"; }; - white-usb { + led-white-usb { label =3D "dns325:white:usb"; gpios =3D <&gpio1 11 GPIO_ACTIVE_LOW>; /* GPIO 43 */ }; - red-l_hdd { + led-red-l_hdd { label =3D "dns325:red:l_hdd"; gpios =3D <&gpio0 28 GPIO_ACTIVE_LOW>; }; - red-r_hdd { + led-red-r_hdd { label =3D "dns325:red:r_hdd"; gpios =3D <&gpio0 27 GPIO_ACTIVE_LOW>; }; - red-usb { + led-red-usb { label =3D "dns325:red:usb"; gpios =3D <&gpio0 29 GPIO_ACTIVE_LOW>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-dockstar.dts b/arch/arm/boo= t/dts/marvell/kirkwood-dockstar.dts index 264938dfa4d9..090f1e2e5bb6 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-dockstar.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-dockstar.dts @@ -42,12 +42,12 @@ gpio-leds { pinctrl-0 =3D <&pmx_led_green &pmx_led_orange>; pinctrl-names =3D "default"; =20 - health { + led-health { label =3D "status:green:health"; gpios =3D <&gpio1 14 GPIO_ACTIVE_LOW>; default-state =3D "keep"; }; - fault { + led-fault { label =3D "status:orange:fault"; gpios =3D <&gpio1 15 GPIO_ACTIVE_LOW>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-dreamplug.dts b/arch/arm/bo= ot/dts/marvell/kirkwood-dreamplug.dts index 328516351e84..590bee3c561c 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-dreamplug.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-dreamplug.dts @@ -85,15 +85,15 @@ gpio-leds { &pmx_led_wifi_ap >; pinctrl-names =3D "default"; =20 - bluetooth { + led-bluetooth { label =3D "dreamplug:blue:bluetooth"; gpios =3D <&gpio1 15 GPIO_ACTIVE_LOW>; }; - wifi { + led-wifi { label =3D "dreamplug:green:wifi"; gpios =3D <&gpio1 16 GPIO_ACTIVE_LOW>; }; - wifi-ap { + led-wifi-ap { label =3D "dreamplug:green:wifi_ap"; gpios =3D <&gpio1 17 GPIO_ACTIVE_LOW>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-goflexnet.dts b/arch/arm/bo= ot/dts/marvell/kirkwood-goflexnet.dts index d4cb3cd3e2a2..d5ac4e3974da 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-goflexnet.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-goflexnet.dts @@ -85,44 +85,44 @@ &pmx_led_right_cap_2 &pmx_led_right_cap_3 >; pinctrl-names =3D "default"; =20 - health { + led-health { label =3D "status:green:health"; gpios =3D <&gpio1 14 GPIO_ACTIVE_LOW>; default-state =3D "keep"; }; - fault { + led-fault { label =3D "status:orange:fault"; gpios =3D <&gpio1 15 GPIO_ACTIVE_LOW>; }; - left0 { + led-left0 { label =3D "status:white:left0"; gpios =3D <&gpio1 10 GPIO_ACTIVE_HIGH>; }; - left1 { + led-left1 { label =3D "status:white:left1"; gpios =3D <&gpio1 11 GPIO_ACTIVE_HIGH>; }; - left2 { + led-left2 { label =3D "status:white:left2"; gpios =3D <&gpio1 12 GPIO_ACTIVE_HIGH>; }; - left3 { + led-left3 { label =3D "status:white:left3"; gpios =3D <&gpio1 13 GPIO_ACTIVE_HIGH>; }; - right0 { + led-right0 { label =3D "status:white:right0"; gpios =3D <&gpio1 6 GPIO_ACTIVE_HIGH>; }; - right1 { + led-right1 { label =3D "status:white:right1"; gpios =3D <&gpio1 7 GPIO_ACTIVE_HIGH>; }; - right2 { + led-right2 { label =3D "status:white:right2"; gpios =3D <&gpio1 8 GPIO_ACTIVE_HIGH>; }; - right3 { + led-right3 { label =3D "status:white:right3"; gpios =3D <&gpio1 9 GPIO_ACTIVE_HIGH>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-guruplug-server-plus.dts b/= arch/arm/boot/dts/marvell/kirkwood-guruplug-server-plus.dts index dfb41393941d..d5aa8b505cc0 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-guruplug-server-plus.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-guruplug-server-plus.dts @@ -59,19 +59,19 @@ gpio-leds { &pmx_led_wmode_r &pmx_led_wmode_g >; pinctrl-names =3D "default"; =20 - health-r { + led-health-r { label =3D "guruplug:red:health"; gpios =3D <&gpio1 14 GPIO_ACTIVE_LOW>; }; - health-g { + led-health-g { label =3D "guruplug:green:health"; gpios =3D <&gpio1 15 GPIO_ACTIVE_LOW>; }; - wmode-r { + led-wmode-r { label =3D "guruplug:red:wmode"; gpios =3D <&gpio1 16 GPIO_ACTIVE_LOW>; }; - wmode-g { + led-wmode-g { label =3D "guruplug:green:wmode"; gpios =3D <&gpio1 17 GPIO_ACTIVE_LOW>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-ib62x0.dts b/arch/arm/boot/= dts/marvell/kirkwood-ib62x0.dts index 0f50eb2d5931..018c6b8f3e8a 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-ib62x0.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-ib62x0.dts @@ -79,16 +79,16 @@ gpio-leds { &pmx_led_usb_transfer>; pinctrl-names =3D "default"; =20 - green-os { + led-green-os { label =3D "ib62x0:green:os"; gpios =3D <&gpio0 25 GPIO_ACTIVE_HIGH>; default-state =3D "keep"; }; - red-os { + led-red-os { label =3D "ib62x0:red:os"; gpios =3D <&gpio0 22 GPIO_ACTIVE_HIGH>; }; - usb-copy { + led-usb-copy { label =3D "ib62x0:red:usb_copy"; gpios =3D <&gpio0 27 GPIO_ACTIVE_HIGH>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-iconnect.dts b/arch/arm/boo= t/dts/marvell/kirkwood-iconnect.dts index a2782fe3d379..91b46e77e0b6 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-iconnect.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-iconnect.dts @@ -89,32 +89,32 @@ led-level { gpios =3D <&gpio1 9 GPIO_ACTIVE_HIGH>; default-state =3D "on"; }; - power-blue { + led-power-blue { label =3D "power:blue"; gpios =3D <&gpio1 10 GPIO_ACTIVE_HIGH>; default-state =3D "keep"; }; - power-red { + led-power-red { label =3D "power:red"; gpios =3D <&gpio1 11 GPIO_ACTIVE_HIGH>; }; - usb1 { + led-usb1 { label =3D "usb1:blue"; gpios =3D <&gpio1 12 GPIO_ACTIVE_HIGH>; }; - usb2 { + led-usb2 { label =3D "usb2:blue"; gpios =3D <&gpio1 13 GPIO_ACTIVE_HIGH>; }; - usb3 { + led-usb3 { label =3D "usb3:blue"; gpios =3D <&gpio1 14 GPIO_ACTIVE_HIGH>; }; - usb4 { + led-usb4 { label =3D "usb4:blue"; gpios =3D <&gpio1 15 GPIO_ACTIVE_HIGH>; }; - otb { + led-otb { label =3D "otb:blue"; gpios =3D <&gpio1 16 GPIO_ACTIVE_HIGH>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-iomega_ix2_200.dts b/arch/a= rm/boot/dts/marvell/kirkwood-iomega_ix2_200.dts index 91409ae949c4..039362152650 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-iomega_ix2_200.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-iomega_ix2_200.dts @@ -127,20 +127,20 @@ gpio-leds { &pmx_led_rebuild &pmx_led_health >; pinctrl-names =3D "default"; =20 - power_led { + led-power-led { label =3D "status:white:power_led"; gpios =3D <&gpio0 16 GPIO_ACTIVE_HIGH>; default-state =3D "keep"; }; - rebuild_led { + led-rebuild-led { label =3D "status:white:rebuild_led"; gpios =3D <&gpio1 4 GPIO_ACTIVE_HIGH>; }; - health_led { + led-health-led { label =3D "status:red:health_led"; gpios =3D <&gpio1 5 GPIO_ACTIVE_HIGH>; }; - backup_led { + led-backup-led { label =3D "status:blue:backup_led"; gpios =3D <&gpio0 15 GPIO_ACTIVE_HIGH>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-l-50.dts b/arch/arm/boot/dt= s/marvell/kirkwood-l-50.dts index 094854743dde..974bc9de4702 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-l-50.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-l-50.dts @@ -97,52 +97,52 @@ rtc@30 { leds { compatible =3D "gpio-leds"; =20 - status_green { + led-status-green { label =3D "l-50:green:status"; gpios =3D <&gpio1 6 GPIO_ACTIVE_LOW>; }; =20 - status_red { + led-status-red { label =3D "l-50:red:status"; gpios =3D <&gpio3 2 GPIO_ACTIVE_LOW>; }; =20 - wifi { + led-wifi { label =3D "l-50:green:wifi"; gpios =3D <&gpio2 7 GPIO_ACTIVE_LOW>; linux,default-trigger =3D "phy0tpt"; }; =20 - internet_green { + led-internet-green { label =3D "l-50:green:internet"; gpios =3D <&gpio2 3 GPIO_ACTIVE_LOW>; }; =20 - internet_red { + led-internet-red { label =3D "l-50:red:internet"; gpios =3D <&gpio2 1 GPIO_ACTIVE_LOW>; }; =20 - usb1_green { + led-usb1-green { label =3D "l-50:green:usb1"; gpios =3D <&gpio2 0 GPIO_ACTIVE_LOW>; linux,default-trigger =3D "usbport"; trigger-sources =3D <&hub_port3>; }; =20 - usb1_red { + led-usb1-red { label =3D "l-50:red:usb1"; gpios =3D <&gpio2 4 GPIO_ACTIVE_LOW>; }; =20 - usb2_green { + led-usb2-green { label =3D "l-50:green:usb2"; gpios =3D <&gpio2 2 GPIO_ACTIVE_LOW>; linux,default-trigger =3D "usbport"; trigger-sources =3D <&hub_port1>; }; =20 - usb2_red { + led-usb2-red { label =3D "l-50:red:usb2"; gpios =3D <&gpio2 5 GPIO_ACTIVE_LOW>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-laplug.dts b/arch/arm/boot/= dts/marvell/kirkwood-laplug.dts index 8296486a5931..90ea6cdee8e0 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-laplug.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-laplug.dts @@ -61,11 +61,11 @@ button-power { gpio-leds { compatible =3D "gpio-leds"; =20 - red-fail { + led-red-fail { label =3D "laplug_v2:red:power"; gpios =3D <&gpio0 12 GPIO_ACTIVE_HIGH>; }; - blue-power { + led-blue-power { label =3D "laplug_v2:blue:power"; gpios =3D <&gpio0 29 GPIO_ACTIVE_HIGH>; linux,default-trigger =3D "default-on"; diff --git a/arch/arm/boot/dts/marvell/kirkwood-linksys-viper.dts b/arch/ar= m/boot/dts/marvell/kirkwood-linksys-viper.dts index ddefaf628501..8a1c38ab6111 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-linksys-viper.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-linksys-viper.dts @@ -54,12 +54,12 @@ gpio-leds { pinctrl-0 =3D < &pmx_led_white_health &pmx_led_white_pulse >; pinctrl-names =3D "default"; =20 - white-health { + led-white-health { label =3D "viper:white:health"; gpios =3D <&gpio0 7 GPIO_ACTIVE_HIGH>; }; =20 - white-pulse { + led-white-pulse { label =3D "viper:white:pulse"; gpios =3D <&gpio0 14 GPIO_ACTIVE_HIGH>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-lsxl.dtsi b/arch/arm/boot/d= ts/marvell/kirkwood-lsxl.dtsi index c0f80146706d..5e0b139dd4fb 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-lsxl.dtsi +++ b/arch/arm/boot/dts/marvell/kirkwood-lsxl.dtsi @@ -137,28 +137,28 @@ &pmx_led_info &pmx_led_power &pmx_led_function_blue>; pinctrl-names =3D "default"; =20 - func_blue { + led-func-blue { label =3D "lsxl:blue:func"; gpios =3D <&gpio1 4 GPIO_ACTIVE_LOW>; }; =20 - alarm { + led-alarm { label =3D "lsxl:red:alarm"; gpios =3D <&gpio1 5 GPIO_ACTIVE_LOW>; }; =20 - info { + led-info { label =3D "lsxl:amber:info"; gpios =3D <&gpio1 6 GPIO_ACTIVE_LOW>; }; =20 - power { + led-power { label =3D "lsxl:blue:power"; gpios =3D <&gpio1 7 GPIO_ACTIVE_LOW>; default-state =3D "keep"; }; =20 - func_red { + led-func-red { label =3D "lsxl:red:func"; gpios =3D <&gpio1 16 GPIO_ACTIVE_LOW>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-mplcec4.dts b/arch/arm/boot= /dts/marvell/kirkwood-mplcec4.dts index e87ea7146546..6533b49a15b2 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-mplcec4.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-mplcec4.dts @@ -114,36 +114,36 @@ &pmx_led_user0g &pmx_led_misc >; pinctrl-names =3D "default"; =20 - health { + led-health { label =3D "status:green:health"; gpios =3D <&gpio0 7 GPIO_ACTIVE_LOW>; }; =20 - user1o { + led-user1o { label =3D "user1:orange"; gpios =3D <&gpio1 8 GPIO_ACTIVE_LOW>; default-state =3D "on"; }; =20 - user1g { + led-user1g { label =3D "user1:green"; gpios =3D <&gpio1 9 GPIO_ACTIVE_LOW>; default-state =3D "on"; }; =20 - user0o { + led-user0o { label =3D "user0:orange"; gpios =3D <&gpio1 12 GPIO_ACTIVE_LOW>; default-state =3D "on"; }; =20 - user0g { + led-user0g { label =3D "user0:green"; gpios =3D <&gpio1 13 GPIO_ACTIVE_LOW>; default-state =3D "on"; }; =20 - misc { + led-misc { label =3D "status:orange:misc"; gpios =3D <&gpio1 14 GPIO_ACTIVE_LOW>; default-state =3D "on"; diff --git a/arch/arm/boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts b/arch/= arm/boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts index fd3813ace0c1..e3b41784c876 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts @@ -73,17 +73,17 @@ gpio-leds { pinctrl-0 =3D <&pmx_leds &pmx_usb_led>; pinctrl-names =3D "default"; =20 - green-status { + led-green-status { label =3D "gtw:green:Status"; gpios =3D <&gpio0 20 GPIO_ACTIVE_HIGH>; }; =20 - red-status { + led-red-status { label =3D "gtw:red:Status"; gpios =3D <&gpio0 21 GPIO_ACTIVE_HIGH>; }; =20 - green-usb { + led-green-usb { label =3D "gtw:green:USB"; gpios =3D <&gpio0 12 GPIO_ACTIVE_HIGH>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-ns2-common.dtsi b/arch/arm/= boot/dts/marvell/kirkwood-ns2-common.dtsi index 28f09f71b24d..d6b615cf6390 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-ns2-common.dtsi +++ b/arch/arm/boot/dts/marvell/kirkwood-ns2-common.dtsi @@ -66,7 +66,7 @@ button-power { gpio-leds { compatible =3D "gpio-leds"; =20 - red-fail { + led-red-fail { label =3D "ns2:red:fail"; gpios =3D <&gpio0 12 GPIO_ACTIVE_HIGH>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-ns2lite.dts b/arch/arm/boot= /dts/marvell/kirkwood-ns2lite.dts index b0cb5907ed63..686bcd6f0f3c 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-ns2lite.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-ns2lite.dts @@ -24,7 +24,7 @@ sata@80000 { gpio-leds { compatible =3D "gpio-leds"; =20 - blue-sata { + led-blue-sata { label =3D "ns2:blue:sata"; gpios =3D <&gpio0 30 GPIO_ACTIVE_LOW>; linux,default-trigger =3D "disk-activity"; diff --git a/arch/arm/boot/dts/marvell/kirkwood-nsa310.dts b/arch/arm/boot/= dts/marvell/kirkwood-nsa310.dts index c1799a07816e..3555ac1c3b15 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-nsa310.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-nsa310.dts @@ -87,43 +87,43 @@ &pmx_led_copy_green &pmx_led_copy_red &pmx_led_hdd_green &pmx_led_hdd_red>; pinctrl-names =3D "default"; =20 - green-sys { + led-green-sys { label =3D "nsa310:green:sys"; gpios =3D <&gpio0 28 GPIO_ACTIVE_HIGH>; }; - red-sys { + led-red-sys { label =3D "nsa310:red:sys"; gpios =3D <&gpio0 29 GPIO_ACTIVE_HIGH>; }; - green-hdd { + led-green-hdd { label =3D "nsa310:green:hdd"; gpios =3D <&gpio1 9 GPIO_ACTIVE_HIGH>; }; - red-hdd { + led-red-hdd { label =3D "nsa310:red:hdd"; gpios =3D <&gpio1 10 GPIO_ACTIVE_HIGH>; }; - green-esata { + led-green-esata { label =3D "nsa310:green:esata"; gpios =3D <&gpio0 12 GPIO_ACTIVE_HIGH>; }; - red-esata { + led-red-esata { label =3D "nsa310:red:esata"; gpios =3D <&gpio0 13 GPIO_ACTIVE_HIGH>; }; - green-usb { + led-green-usb { label =3D "nsa310:green:usb"; gpios =3D <&gpio0 15 GPIO_ACTIVE_HIGH>; }; - red-usb { + led-red-usb { label =3D "nsa310:red:usb"; gpios =3D <&gpio0 16 GPIO_ACTIVE_HIGH>; }; - green-copy { + led-green-copy { label =3D "nsa310:green:copy"; gpios =3D <&gpio1 7 GPIO_ACTIVE_HIGH>; }; - red-copy { + led-red-copy { label =3D "nsa310:red:copy"; gpios =3D <&gpio1 8 GPIO_ACTIVE_HIGH>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-nsa310a.dts b/arch/arm/boot= /dts/marvell/kirkwood-nsa310a.dts index b85e314f045a..ddf84092aade 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-nsa310a.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-nsa310a.dts @@ -75,39 +75,39 @@ lm85: lm85@2e { gpio-leds { compatible =3D "gpio-leds"; =20 - green-sys { + led-green-sys { label =3D "nsa310:green:sys"; gpios =3D <&gpio0 28 GPIO_ACTIVE_HIGH>; }; - red-sys { + led-red-sys { label =3D "nsa310:red:sys"; gpios =3D <&gpio0 29 GPIO_ACTIVE_HIGH>; }; - green-hdd { + led-green-hdd { label =3D "nsa310:green:hdd"; gpios =3D <&gpio1 9 GPIO_ACTIVE_HIGH>; }; - red-hdd { + led-red-hdd { label =3D "nsa310:red:hdd"; gpios =3D <&gpio1 10 GPIO_ACTIVE_HIGH>; }; - green-esata { + led-green-esata { label =3D "nsa310:green:esata"; gpios =3D <&gpio0 12 GPIO_ACTIVE_HIGH>; }; - red-esata { + led-red-esata { label =3D "nsa310:red:esata"; gpios =3D <&gpio0 13 GPIO_ACTIVE_HIGH>; }; - green-usb { + led-green-usb { label =3D "nsa310:green:usb"; gpios =3D <&gpio0 15 GPIO_ACTIVE_HIGH>; }; - green-copy { + led-green-copy { label =3D "nsa310:green:copy"; gpios =3D <&gpio1 7 GPIO_ACTIVE_HIGH>; }; - red-copy { + led-red-copy { label =3D "nsa310:red:copy"; gpios =3D <&gpio1 8 GPIO_ACTIVE_HIGH>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-nsa320.dts b/arch/arm/boot/= dts/marvell/kirkwood-nsa320.dts index 652405e65006..dd5c8ffc8781 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-nsa320.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-nsa320.dts @@ -142,39 +142,39 @@ &pmx_led_copy_green &pmx_led_copy_red &pmx_led_hdd1_green &pmx_led_hdd1_red>; pinctrl-names =3D "default"; =20 - green-sys { + led-green-sys { label =3D "nsa320:green:sys"; gpios =3D <&gpio0 28 GPIO_ACTIVE_HIGH>; }; - orange-sys { + led-orange-sys { label =3D "nsa320:orange:sys"; gpios =3D <&gpio0 29 GPIO_ACTIVE_HIGH>; }; - green-hdd1 { + led-green-hdd1 { label =3D "nsa320:green:hdd1"; gpios =3D <&gpio1 9 GPIO_ACTIVE_HIGH>; }; - red-hdd1 { + led-red-hdd1 { label =3D "nsa320:red:hdd1"; gpios =3D <&gpio1 10 GPIO_ACTIVE_HIGH>; }; - green-hdd2 { + led-green-hdd2 { label =3D "nsa320:green:hdd2"; gpios =3D <&gpio0 12 GPIO_ACTIVE_HIGH>; }; - red-hdd2 { + led-red-hdd2 { label =3D "nsa320:red:hdd2"; gpios =3D <&gpio0 13 GPIO_ACTIVE_HIGH>; }; - green-usb { + led-green-usb { label =3D "nsa320:green:usb"; gpios =3D <&gpio0 15 GPIO_ACTIVE_HIGH>; }; - green-copy { + led-green-copy { label =3D "nsa320:green:copy"; gpios =3D <&gpio1 7 GPIO_ACTIVE_HIGH>; }; - red-copy { + led-red-copy { label =3D "nsa320:red:copy"; gpios =3D <&gpio1 8 GPIO_ACTIVE_HIGH>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-nsa325.dts b/arch/arm/boot/= dts/marvell/kirkwood-nsa325.dts index 371456de34b2..f0786a5f2ce6 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-nsa325.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-nsa325.dts @@ -162,39 +162,39 @@ &pmx_led_copy_green &pmx_led_copy_red &pmx_led_hdd1_green &pmx_led_hdd1_red>; pinctrl-names =3D "default"; =20 - green-sys { + led-green-sys { label =3D "nsa325:green:sys"; gpios =3D <&gpio0 28 GPIO_ACTIVE_HIGH>; }; - orange-sys { + led-orange-sys { label =3D "nsa325:orange:sys"; gpios =3D <&gpio0 29 GPIO_ACTIVE_HIGH>; }; - green-hdd1 { + led-green-hdd1 { label =3D "nsa325:green:hdd1"; gpios =3D <&gpio1 9 GPIO_ACTIVE_HIGH>; }; - red-hdd1 { + led-red-hdd1 { label =3D "nsa325:red:hdd1"; gpios =3D <&gpio1 10 GPIO_ACTIVE_HIGH>; }; - green-hdd2 { + led-green-hdd2 { label =3D "nsa325:green:hdd2"; gpios =3D <&gpio0 12 GPIO_ACTIVE_HIGH>; }; - red-hdd2 { + led-red-hdd2 { label =3D "nsa325:red:hdd2"; gpios =3D <&gpio0 13 GPIO_ACTIVE_HIGH>; }; - green-usb { + led-green-usb { label =3D "nsa325:green:usb"; gpios =3D <&gpio0 15 GPIO_ACTIVE_HIGH>; }; - green-copy { + led-green-copy { label =3D "nsa325:green:copy"; gpios =3D <&gpio1 7 GPIO_ACTIVE_HIGH>; }; - red-copy { + led-red-copy { label =3D "nsa325:red:copy"; gpios =3D <&gpio1 8 GPIO_ACTIVE_HIGH>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-pogo_e02.dts b/arch/arm/boo= t/dts/marvell/kirkwood-pogo_e02.dts index f9e95e55f36d..39a5345332da 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-pogo_e02.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-pogo_e02.dts @@ -33,12 +33,12 @@ chosen { gpio-leds { compatible =3D "gpio-leds"; =20 - health { + led-health { label =3D "pogo_e02:green:health"; gpios =3D <&gpio1 16 GPIO_ACTIVE_LOW>; default-state =3D "keep"; }; - fault { + led-fault { label =3D "pogo_e02:orange:fault"; gpios =3D <&gpio1 17 GPIO_ACTIVE_LOW>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-pogoplug-series-4.dts b/arc= h/arm/boot/dts/marvell/kirkwood-pogoplug-series-4.dts index b66fc4d57410..0e9c4cf79822 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-pogoplug-series-4.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-pogoplug-series-4.dts @@ -46,12 +46,12 @@ gpio-leds { pinctrl-0 =3D <&pmx_led_green &pmx_led_red>; pinctrl-names =3D "default"; =20 - health { + led-health { label =3D "pogoplugv4:green:health"; gpios =3D <&gpio0 22 GPIO_ACTIVE_LOW>; default-state =3D "on"; }; - fault { + led-fault { label =3D "pogoplugv4:red:fault"; gpios =3D <&gpio0 24 GPIO_ACTIVE_LOW>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-sheevaplug-esata.dts b/arch= /arm/boot/dts/marvell/kirkwood-sheevaplug-esata.dts index ae8f493c9a0f..eb185273376e 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-sheevaplug-esata.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-sheevaplug-esata.dts @@ -33,7 +33,7 @@ gpio-leds { pinctrl-0 =3D <&pmx_led_blue>; pinctrl-names =3D "default"; =20 - health { + led-health { label =3D "sheevaplug:blue:health"; gpios =3D <&gpio1 17 GPIO_ACTIVE_LOW>; default-state =3D "keep"; diff --git a/arch/arm/boot/dts/marvell/kirkwood-sheevaplug.dts b/arch/arm/b= oot/dts/marvell/kirkwood-sheevaplug.dts index c73cc904e5c4..ce73fcf2255f 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-sheevaplug.dts +++ b/arch/arm/boot/dts/marvell/kirkwood-sheevaplug.dts @@ -28,13 +28,13 @@ gpio-leds { pinctrl-0 =3D <&pmx_led_blue &pmx_led_red>; pinctrl-names =3D "default"; =20 - health { + led-health { label =3D "sheevaplug:blue:health"; gpios =3D <&gpio1 17 GPIO_ACTIVE_LOW>; default-state =3D "keep"; }; =20 - misc { + led-misc { label =3D "sheevaplug:red:misc"; gpios =3D <&gpio1 14 GPIO_ACTIVE_LOW>; }; diff --git a/arch/arm/boot/dts/marvell/kirkwood-synology.dtsi b/arch/arm/bo= ot/dts/marvell/kirkwood-synology.dtsi index 20964eb48fd7..6b7c5218b1fb 100644 --- a/arch/arm/boot/dts/marvell/kirkwood-synology.dtsi +++ b/arch/arm/boot/dts/marvell/kirkwood-synology.dtsi @@ -410,7 +410,7 @@ gpio-leds-alarm-12 { pinctrl-0 =3D <&pmx_alarmled_12>; pinctrl-names =3D "default"; =20 - hdd1-green { + led-hdd1-green { label =3D "synology:alarm"; gpios =3D <&gpio0 21 GPIO_ACTIVE_LOW>; }; @@ -424,42 +424,42 @@ &pmx_hddled_23 &pmx_hddled_24 &pmx_hddled_25 &pmx_hddled_26 &pmx_hddled_27>; pinctrl-names =3D "default"; =20 - hdd1-green { + led-hdd1-green { label =3D "synology:green:hdd1"; gpios =3D <&gpio0 20 GPIO_ACTIVE_LOW>; }; =20 - hdd1-amber { + led-hdd1-amber { label =3D "synology:amber:hdd1"; gpios =3D <&gpio0 21 GPIO_ACTIVE_LOW>; }; =20 - hdd2-green { + led-hdd2-green { label =3D "synology:green:hdd2"; gpios =3D <&gpio0 22 GPIO_ACTIVE_LOW>; }; =20 - hdd2-amber { + led-hdd2-amber { label =3D "synology:amber:hdd2"; gpios =3D <&gpio0 23 GPIO_ACTIVE_LOW>; }; =20 - hdd3-green { + led-hdd3-green { label =3D "synology:green:hdd3"; gpios =3D <&gpio0 24 GPIO_ACTIVE_LOW>; }; =20 - hdd3-amber { + led-hdd3-amber { label =3D "synology:amber:hdd3"; gpios =3D <&gpio0 25 GPIO_ACTIVE_LOW>; }; =20 - hdd4-green { + led-hdd4-green { label =3D "synology:green:hdd4"; gpios =3D <&gpio0 26 GPIO_ACTIVE_LOW>; }; =20 - hdd4-amber { + led-hdd4-amber { label =3D "synology:amber:hdd4"; gpios =3D <&gpio0 27 GPIO_ACTIVE_LOW>; }; @@ -471,12 +471,12 @@ gpio-leds-hdd-21-1 { pinctrl-0 =3D <&pmx_hddled_21 &pmx_hddled_23>; pinctrl-names =3D "default"; =20 - hdd1-green { + led-hdd1-green { label =3D "synology:green:hdd1"; gpios =3D <&gpio0 21 GPIO_ACTIVE_LOW>; }; =20 - hdd1-amber { + led-hdd1-amber { label =3D "synology:amber:hdd1"; gpios =3D <&gpio0 23 GPIO_ACTIVE_LOW>; }; @@ -488,22 +488,22 @@ gpio-leds-hdd-21-2 { pinctrl-0 =3D <&pmx_hddled_21 &pmx_hddled_23 &pmx_hddled_20 &pmx_hddled_= 22>; pinctrl-names =3D "default"; =20 - hdd1-green { + led-hdd1-green { label =3D "synology:green:hdd1"; gpios =3D <&gpio0 21 GPIO_ACTIVE_LOW>; }; =20 - hdd1-amber { + led-hdd1-amber { label =3D "synology:amber:hdd1"; gpios =3D <&gpio0 23 GPIO_ACTIVE_LOW>; }; =20 - hdd2-green { + led-hdd2-green { label =3D "synology:green:hdd2"; gpios =3D <&gpio0 20 GPIO_ACTIVE_LOW>; }; =20 - hdd2-amber { + led-hdd2-amber { label =3D "synology:amber:hdd2"; gpios =3D <&gpio0 22 GPIO_ACTIVE_LOW>; }; @@ -518,52 +518,52 @@ &pmx_hddled_42 &pmx_hddled_43 &pmx_hddled_44 &pmx_hddled_45>; pinctrl-names =3D "default"; =20 - hdd1-green { + led-hdd1-green { label =3D "synology:green:hdd1"; gpios =3D <&gpio1 4 GPIO_ACTIVE_LOW>; }; =20 - hdd1-amber { + led-hdd1-amber { label =3D "synology:amber:hdd1"; gpios =3D <&gpio1 5 GPIO_ACTIVE_LOW>; }; =20 - hdd2-green { + led-hdd2-green { label =3D "synology:green:hdd2"; gpios =3D <&gpio1 6 GPIO_ACTIVE_LOW>; }; =20 - hdd2-amber { + led-hdd2-amber { label =3D "synology:amber:hdd2"; gpios =3D <&gpio1 7 GPIO_ACTIVE_LOW>; }; =20 - hdd3-green { + led-hdd3-green { label =3D "synology:green:hdd3"; gpios =3D <&gpio1 8 GPIO_ACTIVE_LOW>; }; =20 - hdd3-amber { + led-hdd3-amber { label =3D "synology:amber:hdd3"; gpios =3D <&gpio1 9 GPIO_ACTIVE_LOW>; }; =20 - hdd4-green { + led-hdd4-green { label =3D "synology:green:hdd4"; gpios =3D <&gpio1 10 GPIO_ACTIVE_LOW>; }; =20 - hdd4-amber { + led-hdd4-amber { label =3D "synology:amber:hdd4"; gpios =3D <&gpio1 11 GPIO_ACTIVE_LOW>; }; =20 - hdd5-green { + led-hdd5-green { label =3D "synology:green:hdd5"; gpios =3D <&gpio1 12 GPIO_ACTIVE_LOW>; }; =20 - hdd5-amber { + led-hdd5-amber { label =3D "synology:amber:hdd5"; gpios =3D <&gpio1 13 GPIO_ACTIVE_LOW>; }; @@ -575,22 +575,22 @@ gpio-leds-hdd-38 { pinctrl-0 =3D <&pmx_hddled_38 &pmx_hddled_39 &pmx_hddled_36 &pmx_hddled_= 37>; pinctrl-names =3D "default"; =20 - hdd1-green { + led-hdd1-green { label =3D "synology:green:hdd1"; gpios =3D <&gpio1 6 GPIO_ACTIVE_LOW>; }; =20 - hdd1-amber { + led-hdd1-amber { label =3D "synology:amber:hdd1"; gpios =3D <&gpio1 7 GPIO_ACTIVE_LOW>; }; =20 - hdd2-green { + led-hdd2-green { label =3D "synology:green:hdd2"; gpios =3D <&gpio1 4 GPIO_ACTIVE_LOW>; }; =20 - hdd2-amber { + led-hdd2-amber { label =3D "synology:amber:hdd2"; gpios =3D <&gpio1 5 GPIO_ACTIVE_LOW>; }; --=20 2.43.0 From nobody Tue Feb 10 02:47:39 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03DB116CD0C for ; Mon, 1 Jul 2024 14:56:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719845812; cv=none; b=BJYlhPohCbZ1ZQxy0vOQQbRK1PjX33pquHaxpCt90BG9Pqxpv1sf9ny4zia4JKRjZvT7D4nHFoYFWeDI405D/NtPFXOq5hbvh5FjTqABbWEEw2Oo99xd2aFQoRPFEqf3hHzpZfvoqvksai46kOQ3Qiv1vHjT4cMDVDAqaEfDkVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719845812; c=relaxed/simple; bh=kb1FnQDn0ZT17ALs01+HilXnHppqjDF6c8veki67I7Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LLbj23UcCG6ISaPhO1fh+DLyc+afUGgwl2/Nb3mRW7ZXReSaw1eu8o2KZLlcb28dzHo7znFEUSywhb9qfSIJYnTiDrn43Zxopkjx7GRrCBAk0AhutDv6cWdh5AuHVHi32YDOgfZLPfYIsdlJUPW7rqoXE8j8312wKR4j/X7j9ZM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DsKy32Ey; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DsKy32Ey" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-425809eef0eso8808955e9.3 for ; Mon, 01 Jul 2024 07:56:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719845809; x=1720450609; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RmnlXVSk8Bmi7VgmYcl1HcRpFD6VX2h6iLn8P1zKdUs=; b=DsKy32EyPUv6ohllT8PacQta1TeOJ3SkHJ4wSd/9vzld2Zc343FQ8a+COjcUazFpc7 TXrJ0To8ofg45cqUeegH9w575w5jIf93UMgpoqo+m0ZA9NBSR7Bq/Hd59CQid6kpaSwE TCvADIFFV8gYoRhOu4+/EEXH7Nya3NSicApPFJR4UQ3YkHnydynX74yZNXQE6aieV3Ut gBqRpTCYrsj39gBCS6ypLmG0PYB3FvB6z2JVUynK3rbGJFgcx2e/Smcjj7VIkbeXjAMA 0PAUm2vG7N5mLTgPAPAa53xLP3L7glj+EAfYxilnYGSS0vKgvNXKaxJEwlgdBYKjzRQ8 CSOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719845809; x=1720450609; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RmnlXVSk8Bmi7VgmYcl1HcRpFD6VX2h6iLn8P1zKdUs=; b=dVQteSo9NSQpkBqAQ+fKAC/s+gp/SZxJUSsy3MCXjQyNe/aUwfMOx3nzwvHieKBL+j 9Os2hmMi3YyhYXQGaQq/bd67nLW/VlqEdhM5sXtV+SlGjlk7bxOk3aKb4GW7x5jCor54 ijlPO83MFtUXYpb9rP52JizEBOhq9Yf7FzRsL3+rnRBIWwiooA9Gd/UEXkVTstwOT0aS +eXNFggysEZmyqLvuTIWLLsDMQyfXbFk8MB1aO4LTcHIfmA2x3kDtu1p33TBI2ZM40kr l550CNVXwhGF8eA6chOSSEdkww/8FBvn4wFmYnZCdrkSDJA7Dfjw64PZzT7yoBmcv5tL oQEQ== X-Forwarded-Encrypted: i=1; AJvYcCUsMk6keCF4kfHoVLTsHm/xubhY1lNLpgD3Res79ytxu7ftv3EP+VXjR516pwQUMkduvgjGOFF1pbU04Talk+IWNxs8KD8FJi3BshgC X-Gm-Message-State: AOJu0YxNP1bga40zpo2+DS/K/Vz16aZZueZvfV/HdzjUq4vyuIowJCfh M0TTzT4vGov0dS0m6DDw/I2VydtmYxSEtjA+CBs8LFIwHnZRpTXSN5odlN4g80MZwD+AwFlXD8i 0 X-Google-Smtp-Source: AGHT+IGra1rN0CktmnXJF4vfHe896ROGlb3rDY4QCV/i7d+MRtIToMqbGMp6dcTl/zTwo3hzkxk+Sg== X-Received: by 2002:a05:600c:2255:b0:421:7b9d:5b9b with SMTP id 5b1f17b1804b1-4257a03022fmr47607455e9.15.1719845808875; Mon, 01 Jul 2024 07:56:48 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.137]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256b0c0f99sm160062915e9.41.2024.07.01.07.56.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 07:56:48 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 01 Jul 2024 16:56:37 +0200 Subject: [PATCH 4/7] ARM: dts: marvell: orion: align GPIO keys node name with bindings Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240701-dts-marvell-cleanup-v1-4-4773bd20691a@linaro.org> References: <20240701-dts-marvell-cleanup-v1-0-4773bd20691a@linaro.org> In-Reply-To: <20240701-dts-marvell-cleanup-v1-0-4773bd20691a@linaro.org> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4380; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=kb1FnQDn0ZT17ALs01+HilXnHppqjDF6c8veki67I7Y=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmgsOm1UBLm7b69zUMX/zcTfKcYyhS1/iRpO2En +Uex+ylj8yJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZoLDpgAKCRDBN2bmhouD 144FD/4xlTp2kYFnF/dp6I0lBkqMMr4j5u9JWCbw/26hD3Oqy24gqwEtJJOoSIxn8cGbZV/S5o/ 8vWFvPXXQToXoBGQMCvBfsZ6/eASPEvN3WApo/hg5Vgm2tRmXUAdIL8g+8TzXMpl0HGWhFOhyD2 tlp+j82/ShcJPiTt7I7T2IOnTrulSfBaX3HCGqorljFL9aVP8+k57NRBvZ+x2DH8G+twa4IRPw5 nGwygRHMpPbIKG1V+7JTQ7tXhppg/+zN6+CrxRuFv0E3Z1OOIXzE5VE2fKoQQIJ1qQgEzYaEm2k cKDZx/pA9c2lhYZmhrh3cvCfr+BXqKAm7Ak46Kdi9VEzfPf1zRgT4Y2pxZZ40bBQ7ppabmYdvxi NOBY3hLZCpLSqYWHiGfzP6XeeCwJqxqZ1bWeVtTe4g4D+gWbdLfeBcxMgMH6eRu8YlBjSNzRfwr rkerLlYETsBwmN9wUakwtDsjYfAVu2fG0N7xmGFqoYqV/HOrVsw3py7P5RU7WPlM4uKMbNRukGZ WKv85CR0c7+5IL8f1Ch+I4AfOej9aLnATT0HpdQPmSLleGlPUwxmwuKkwl+swVrljlEktJvuBDH 1dSN8JnfBCz9hHkMwo846IurWcibjKFmQGV0+qiVdc1av8+uLIgGpSY82bGnOq9fM6lXp5RTVC2 5a5rH6Lckm+4FsQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Bindings expect the GPIO key node names to follow certain pattern, see dtbs_check warnings: orion5x-lacie-d2-network.dtb: gpio-keys: 'front_button', 'power_rocker_sw= _off', 'power_rocker_sw_on' do not match any of the regexes: '^(button|even= t|key|switch| ... Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/marvell/orion5x-lacie-d2-network.dts | 7 ++++--- arch/arm/boot/dts/marvell/orion5x-linkstation-lschl.dts | 2 +- arch/arm/boot/dts/marvell/orion5x-lswsgl.dts | 7 ++++--- arch/arm/boot/dts/marvell/orion5x-maxtor-shared-storage-2.dts | 5 +++-- arch/arm/boot/dts/marvell/orion5x-netgear-wnr854t.dts | 2 +- 5 files changed, 13 insertions(+), 10 deletions(-) diff --git a/arch/arm/boot/dts/marvell/orion5x-lacie-d2-network.dts b/arch/= arm/boot/dts/marvell/orion5x-lacie-d2-network.dts index 03471d30bfd9..3d6c5af0e843 100644 --- a/arch/arm/boot/dts/marvell/orion5x-lacie-d2-network.dts +++ b/arch/arm/boot/dts/marvell/orion5x-lacie-d2-network.dts @@ -37,20 +37,21 @@ gpio-keys { pinctrl-names =3D "default"; #address-cells =3D <1>; #size-cells =3D <0>; - front_button { + + button-front { label =3D "Front Push Button"; linux,code =3D ; gpios =3D <&gpio0 18 GPIO_ACTIVE_HIGH>; }; =20 - power_rocker_sw_on { + switch-power-rocker-sw-on { label =3D "Power rocker switch (on|auto)"; linux,input-type =3D <5>; /* EV_SW */ linux,code =3D <1>; /* D2NET_SWITCH_POWER_ON */ gpios =3D <&gpio0 8 GPIO_ACTIVE_HIGH>; }; =20 - power_rocker_sw_off { + switch-power-rocker-sw-off { label =3D "Power rocker switch (auto|off)"; linux,input-type =3D <5>; /* EV_SW */ linux,code =3D <2>; /* D2NET_SWITCH_POWER_OFF */ diff --git a/arch/arm/boot/dts/marvell/orion5x-linkstation-lschl.dts b/arch= /arm/boot/dts/marvell/orion5x-linkstation-lschl.dts index ee751995c8d0..624b737a8be4 100644 --- a/arch/arm/boot/dts/marvell/orion5x-linkstation-lschl.dts +++ b/arch/arm/boot/dts/marvell/orion5x-linkstation-lschl.dts @@ -61,7 +61,7 @@ memory { /* 128 MB */ }; =20 gpio_keys { - func { + func-button { label =3D "Function Button"; linux,code =3D ; gpios =3D <&gpio0 15 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/marvell/orion5x-lswsgl.dts b/arch/arm/boot/d= ts/marvell/orion5x-lswsgl.dts index 2fbc17d6dfa4..e2829fb0c8b2 100644 --- a/arch/arm/boot/dts/marvell/orion5x-lswsgl.dts +++ b/arch/arm/boot/dts/marvell/orion5x-lswsgl.dts @@ -76,20 +76,21 @@ gpio-keys { pinctrl-names =3D "default"; #address-cells =3D <1>; #size-cells =3D <0>; - func { + + key-func { label =3D "Function Button"; linux,code =3D ; gpios =3D <&gpio0 15 GPIO_ACTIVE_LOW>; }; =20 - power { + key-power { label =3D "Power-on Switch"; linux,input-type =3D <5>; /* EV_SW */ linux,code =3D ; /* LSMINI_SW_POWER */ gpios =3D <&gpio0 18 GPIO_ACTIVE_LOW>; }; =20 - autopower { + key-autopower { label =3D "Power-auto Switch"; linux,input-type =3D <5>; /* EV_SW */ linux,code =3D ; /* LSMINI_SW_AUTOPOWER */ diff --git a/arch/arm/boot/dts/marvell/orion5x-maxtor-shared-storage-2.dts = b/arch/arm/boot/dts/marvell/orion5x-maxtor-shared-storage-2.dts index d57859998350..90ce5fa883a4 100644 --- a/arch/arm/boot/dts/marvell/orion5x-maxtor-shared-storage-2.dts +++ b/arch/arm/boot/dts/marvell/orion5x-maxtor-shared-storage-2.dts @@ -37,13 +37,14 @@ gpio-keys { pinctrl-names =3D "default"; #address-cells =3D <1>; #size-cells =3D <0>; - power { + + key-power { label =3D "Power"; linux,code =3D ; gpios =3D <&gpio0 11 GPIO_ACTIVE_LOW>; }; =20 - reset { + key-reset { label =3D "Reset"; linux,code =3D ; gpios =3D <&gpio0 12 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/marvell/orion5x-netgear-wnr854t.dts b/arch/a= rm/boot/dts/marvell/orion5x-netgear-wnr854t.dts index fb203e7d37f5..d63ea15539aa 100644 --- a/arch/arm/boot/dts/marvell/orion5x-netgear-wnr854t.dts +++ b/arch/arm/boot/dts/marvell/orion5x-netgear-wnr854t.dts @@ -35,7 +35,7 @@ gpio-keys { pinctrl-0 =3D <&pmx_reset_button>; pinctrl-names =3D "default"; =20 - reset { + key-reset { label =3D "Reset Button"; linux,code =3D ; gpios =3D <&gpio0 1 GPIO_ACTIVE_LOW>; --=20 2.43.0 From nobody Tue Feb 10 02:47:39 2026 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9324E16CD30 for ; Mon, 1 Jul 2024 14:56:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719845814; cv=none; b=SX3pPNU6Jen0wZh0APoBARXjhzti+UG3YBWvi0Z2g7kwBpPHYImTgJPJtMu41Cifuo00voG4dAkhaXNpSQCeZ0CxSiD2VS20tDozH1nD4bv9NPe6RyBZOzb4YwZdzknqOV2k8mHeaFxhroJ/JH7Patnyha0MrI23UszuReozM2o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719845814; c=relaxed/simple; bh=8rvACG9Tldw0R7sQczKSuOfqyU9GkDAAi2aaVVlRDUg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UtBNLwRUtRjvP27OeE4jWFNPGS0EW1I8On3jlRsaI6L1OcKd+5NdVRXrz6fZaNrfn1ic4jXxaFWAAAiaYOBbYhvVjrbRy+rhSkxwE6p4HrW+73g1iOWQZfOPTRsTg0aZTW0uWDgwEz5spZzLzlah+F4aYv5u9uXpQF4poHnWjII= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fcSlIyyY; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fcSlIyyY" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52e7693c369so4081647e87.3 for ; Mon, 01 Jul 2024 07:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719845810; x=1720450610; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NUpi2VJkABStrX7HzvU2tGfXK2NmMthUnHbMUzSZqBo=; b=fcSlIyyY3/ZbNi/1pyhM9FypXoihaBoNjOwaMtM33wvV2Mmc3SaYZN8tBBNHkgTdcX C5MiZbO/YE9rlh71PuJcXiIH4rUJPjjOX9hT3bk5gSTakVGFr45xnG5qZCiTrknxH4DY t2+WktPb3ijHiH7dtxVU4xcRxQqaPz6R3Ci1YOE+yAusF7gKPLWnhVdyygyHfxTYAPrW Lh9lUEnliSfz230Qokp1UiEZrYZi/xFP/pcSWFyhDLm/KM83jhiVvKC3lDFBCGYEhz5U ymJWWhowhT7PnxsEDdCXwjZH9whM449cI5rfB9am9XHlPHTT/LKSq0EEbKIsdIbp3oUW Hj0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719845810; x=1720450610; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NUpi2VJkABStrX7HzvU2tGfXK2NmMthUnHbMUzSZqBo=; b=g9xZbu64ddSPCgzdvNj8cLAXR7hKJmyUS9WmEWsrqlmI+NvZ4TP5vhG5T5opJR2TQO 5M5jcBDw3fOJkK39t2E2PO1+XG6nfgVd5/NIALxnwOpssd1NxcZKsJpI4haNKdv/bfwg 51+sji3OYvt4REIMRrJrKj5W+NeEh/yVmI8/wKz4an8L7OWy5l4pDUc6XkQZ2c8CDRc1 W7S3CeXwpEblGrM9jSZPWSPDdy5bJ0O2a8etAX0e/vDFo6FOgpj47etTe3jNpXWUtS2m 1QhwyfhtyTX2cgjxGdxTvfICN/jT8HQuTFcny+GbKXWdV5VIV3tVPvtU0TJS56ZioT/r exng== X-Forwarded-Encrypted: i=1; AJvYcCUsUgeg1wQlIvhYMvR6LsJ2M0ePhRY2mfF444poYXahWYey5rV7JwRzpQ4ftw3jMDH9smzRFgKBD6/Ql2cYmSQT7Hc3qoZ+UQ11wupb X-Gm-Message-State: AOJu0Yy8covRp5hmuf2IQW9CJkeOrxpEVQbLRjSarHWlQbqt6LopJ4Yy VlN/sANKEYkza/hYw8YfrJKalAwY+tyjwqvtkKvzd5iqLhSJtXB1I8+IH0b2nUSmJT5ohCMvjdI 9 X-Google-Smtp-Source: AGHT+IFFp745yEV965FCA9ZDSTzXceFaQmPua61KrHO+jS7pR48Zr2ItYavo6QP7EPy0qxYjywPA6Q== X-Received: by 2002:a05:6512:3b88:b0:52c:e180:4eba with SMTP id 2adb3069b0e04-52e8272ab82mr4811218e87.62.1719845810194; Mon, 01 Jul 2024 07:56:50 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.137]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256b0c0f99sm160062915e9.41.2024.07.01.07.56.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 07:56:49 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 01 Jul 2024 16:56:38 +0200 Subject: [PATCH 5/7] ARM: dts: marvell: orion: drop incorrect address/size-cells in GPIO keys Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240701-dts-marvell-cleanup-v1-5-4773bd20691a@linaro.org> References: <20240701-dts-marvell-cleanup-v1-0-4773bd20691a@linaro.org> In-Reply-To: <20240701-dts-marvell-cleanup-v1-0-4773bd20691a@linaro.org> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3473; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=8rvACG9Tldw0R7sQczKSuOfqyU9GkDAAi2aaVVlRDUg=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmgsOnYGPTqX0InmDJtlGWHZ8pHsKB+xFcgOmO+ c/3NIdFdkeJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZoLDpwAKCRDBN2bmhouD 11YkD/0eImE54i7vier1CiQt2gmuahj1JbBKzyoZEacQ5RTErV27ttNXgFxKeillcW5MMDvd+z5 eSor3RtcGQzjfmVb/M8VPHV++mCZSVIk8mXv/L1Kju1MQPR+Sk8Zpzg1Vm62Qj7AZipqRLq/whJ NgzIXIUF4z5L/rse9q2pAu/RwwCwsi2OUUgJLz1Zyibij4nH8nDYoqOkmCdw6hZzD6padk33++W 9ZimJ+h1JdZ3nOVLMqlPscZYdgblIfAD56rMPsznAbP0WFO9bToz5Z/sFtQUNXO8JLBPZ5uRalh aTEiRjYYiVMprk3wXbJa9aoT+dlPoJ7jC9oUTZxkjt0uRjrDmije4z2yKxLgZ98bJ7GdpNKD+L/ 7gfajGJw8UqtonIaSdW6QobEbfPcYjcCjfAzJSmPZPuEs9SqjIqngeHF83qJg2UKibhh1OjN3V6 eqD1wjKXalmsEnn7TXMgZcxbXnAg4rIThvpgHU+nTuW7jzKO/QC4QtSc7OmTzk0hNDW37dyI3p5 q1b6hiJ1PjIOKMu4FwRKYndL7q7z0jg6R8g9IYfED9biLtgwrN5hpBps3CLM5FgbCFx8q8YJcXY z6L4h3aqYLbAxTdziYjw701T8cfaQOwAdNu4PtQSjEOhjdLQ7iMFL5Fy4VqFmrh0r37cOBFsYtB zFqu1u4rZF6kpyQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Bindings do not allow address/size-cells in GPIO keys and the GPIO keys is not a bus, see dtbs_check warnings: orion5x-lacie-ethernet-disk-mini-v2.dtb: gpio-keys: '#address-cells', '#s= ize-cells' do not match any of the regexes: '^(button|event|key|switch|... Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/marvell/mvebu-linkstation-gpio-simple.dtsi | 2 -- arch/arm/boot/dts/marvell/orion5x-lacie-d2-network.dts | 2 -- arch/arm/boot/dts/marvell/orion5x-lacie-ethernet-disk-mini-v2.dts | 5 ++--- arch/arm/boot/dts/marvell/orion5x-lswsgl.dts | 2 -- arch/arm/boot/dts/marvell/orion5x-maxtor-shared-storage-2.dts | 2 -- 5 files changed, 2 insertions(+), 11 deletions(-) diff --git a/arch/arm/boot/dts/marvell/mvebu-linkstation-gpio-simple.dtsi b= /arch/arm/boot/dts/marvell/mvebu-linkstation-gpio-simple.dtsi index c2d87ba6190a..055ac754c5fd 100644 --- a/arch/arm/boot/dts/marvell/mvebu-linkstation-gpio-simple.dtsi +++ b/arch/arm/boot/dts/marvell/mvebu-linkstation-gpio-simple.dtsi @@ -48,8 +48,6 @@ / { gpio_keys { compatible =3D "gpio-keys"; - #address-cells =3D <1>; - #size-cells =3D <0>; pinctrl-0 =3D <&pmx_power_switch>; pinctrl-names =3D "default"; =20 diff --git a/arch/arm/boot/dts/marvell/orion5x-lacie-d2-network.dts b/arch/= arm/boot/dts/marvell/orion5x-lacie-d2-network.dts index 3d6c5af0e843..12a4aac2633e 100644 --- a/arch/arm/boot/dts/marvell/orion5x-lacie-d2-network.dts +++ b/arch/arm/boot/dts/marvell/orion5x-lacie-d2-network.dts @@ -35,8 +35,6 @@ gpio-keys { compatible =3D "gpio-keys"; pinctrl-0 =3D <&pmx_buttons>; pinctrl-names =3D "default"; - #address-cells =3D <1>; - #size-cells =3D <0>; =20 button-front { label =3D "Front Push Button"; diff --git a/arch/arm/boot/dts/marvell/orion5x-lacie-ethernet-disk-mini-v2.= dts b/arch/arm/boot/dts/marvell/orion5x-lacie-ethernet-disk-mini-v2.dts index f17e25ac98dd..a7586370b1d5 100644 --- a/arch/arm/boot/dts/marvell/orion5x-lacie-ethernet-disk-mini-v2.dts +++ b/arch/arm/boot/dts/marvell/orion5x-lacie-ethernet-disk-mini-v2.dts @@ -39,9 +39,8 @@ gpio-keys { compatible =3D "gpio-keys"; pinctrl-0 =3D <&pmx_power_button>; pinctrl-names =3D "default"; - #address-cells =3D <1>; - #size-cells =3D <0>; - button@1 { + + button-1 { label =3D "Power-on Switch"; linux,code =3D ; gpios =3D <&gpio0 18 GPIO_ACTIVE_HIGH>; diff --git a/arch/arm/boot/dts/marvell/orion5x-lswsgl.dts b/arch/arm/boot/d= ts/marvell/orion5x-lswsgl.dts index e2829fb0c8b2..35dffb24b8b5 100644 --- a/arch/arm/boot/dts/marvell/orion5x-lswsgl.dts +++ b/arch/arm/boot/dts/marvell/orion5x-lswsgl.dts @@ -74,8 +74,6 @@ gpio-keys { compatible =3D "gpio-keys"; pinctrl-0 =3D <&pmx_buttons>; pinctrl-names =3D "default"; - #address-cells =3D <1>; - #size-cells =3D <0>; =20 key-func { label =3D "Function Button"; diff --git a/arch/arm/boot/dts/marvell/orion5x-maxtor-shared-storage-2.dts = b/arch/arm/boot/dts/marvell/orion5x-maxtor-shared-storage-2.dts index 90ce5fa883a4..cb1bd24b7ae3 100644 --- a/arch/arm/boot/dts/marvell/orion5x-maxtor-shared-storage-2.dts +++ b/arch/arm/boot/dts/marvell/orion5x-maxtor-shared-storage-2.dts @@ -35,8 +35,6 @@ gpio-keys { compatible =3D "gpio-keys"; pinctrl-0 =3D <&pmx_buttons>; pinctrl-names =3D "default"; - #address-cells =3D <1>; - #size-cells =3D <0>; =20 key-power { label =3D "Power"; --=20 2.43.0 From nobody Tue Feb 10 02:47:39 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50EBC16D4C0 for ; Mon, 1 Jul 2024 14:56:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719845815; cv=none; b=Nfl7q8xK+YURRd7QfLD9NHs6ZMY0/RW9WZPrNNK82XKT6XiTYOkUsMl2/x85BhK2XNdzfJiwlpZ/gOO/0HljcZBCcMuDllepjeU9GuXsXlh6aFsZXgg8Z1XBt4XMb5q66L1GK48x82KEImAR4VXz7ChYMaq07FE5BLQk0XgUgIU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719845815; c=relaxed/simple; bh=SrDosKmap1qHqwbZN81p8+TgKWBukS6DTItRBt59i+A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EoHxCMSsqSeKvFZ99NpUxU02ZCC8GUfSDq0gGxkw0CWCvwMN/fZl83PlKTqBepx9OUktOsyt6k6aFTeglsch4IP4gNBnrpLt+H7+0BENvgW6a+WBvcXDRSCRqxk/KYW9wFvpyAZrsk3bf36kEHRMp+CiGziryl2i6fLT7qbvIJQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NpfmZ74g; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NpfmZ74g" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-424acfff613so28347875e9.0 for ; Mon, 01 Jul 2024 07:56:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719845811; x=1720450611; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RsUHCrNvsKr1kdBukb0DCbmncyLmfrL3JXYTmXFdBlM=; b=NpfmZ74g5fCMFS3fJUxnzwGRMr2fBCDgQLNd1f+xKRGfNs2ZpS+KQFmE8Hqf45DDQR kAiiTTrjQl8uBDZ89WdKGJacxcBJYkLE+JC5oCRt/6mkhujbwCGMb/OOMffO6ozLEnKT y6ho1hT6KOV8wn3puZ6ABySplb1IHJ5egIAbNLOYSoWXJinAdvQCO6j9vGgTaSorxxzl Di7IUvHI+dIHJ4GMV7u+wDo7U0yu7Vc9IfGncIuytKdvxOTXVhlZfNlZuPLKTDKLrHRL wrHG0TKUnCWaiFEZ5EEO8WokopfHQDxi5Z8JZK2gZGSvathtXfJxeJc1yG4skg8guuXU /tSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719845811; x=1720450611; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RsUHCrNvsKr1kdBukb0DCbmncyLmfrL3JXYTmXFdBlM=; b=av/StBDgAU1qDBnr6AsNvfdIUXT4Q5XS82jWrWUVUyEHlJQQSbiA4UCZblxRwzlAhA Sg6gTj5G0he0ijfJj3A2pUuh3r9r1x8IcoWdjJYZevYAhUSeCXlLpy920YnTK7R/r+SP bexmv9XhciVVMbGl9QdaGJLsTsgVzIwiCO7y30ibh0/HZMiNqCXZpE4nuEBy3sCTmx9X dh5+oGAIw6VF0rdkY6+LUFBynk5/ZP64RX2/MFubUq6BRXkMiRxFeLZ/fZnKvVdcEHKP yqLb5+vShVWdwz/eQT06U3NYxHWlP7pc7/kPWz9U/aLdU/xsh8Veq3WLC0JO/inr55J/ fiew== X-Forwarded-Encrypted: i=1; AJvYcCXsahgH3anqLP3IyKEJM8tj6O3IxRIxDs0d69muKcaByYcaRU5YA8QhVBgv/LYf25H1ElW+/lsBnFSXq01LUdwBP8weVdXOiJkyGrvd X-Gm-Message-State: AOJu0Yw6VyQQiqwSCLKjgZqo0vRRKpmI5CZRoGC67XMNVxKtv6GFMYRc 4hdXZoIOWes6MzNyXCTVf3L4qg2b8MSO6vMIIbWQd7UC089psnSSkLKr3WtIH6fld3437NnMNB6 Z X-Google-Smtp-Source: AGHT+IEmqNIzKh8Lu6RZ6/4U5CX2P1NYzyEdM/Eu1XeQVHEX0sMUaOg1okVoBqrKIIsHkxzsu3DaIg== X-Received: by 2002:a05:600c:181b:b0:424:c837:f54b with SMTP id 5b1f17b1804b1-4257a0270f4mr45205645e9.38.1719845811435; Mon, 01 Jul 2024 07:56:51 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.137]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256b0c0f99sm160062915e9.41.2024.07.01.07.56.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 07:56:50 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 01 Jul 2024 16:56:39 +0200 Subject: [PATCH 6/7] ARM: dts: marvell: orion5x-lswsgl: use 'gpios' property for LEDs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240701-dts-marvell-cleanup-v1-6-4773bd20691a@linaro.org> References: <20240701-dts-marvell-cleanup-v1-0-4773bd20691a@linaro.org> In-Reply-To: <20240701-dts-marvell-cleanup-v1-0-4773bd20691a@linaro.org> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1266; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=SrDosKmap1qHqwbZN81p8+TgKWBukS6DTItRBt59i+A=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmgsOo52DMHYvFkxcBePY3Llxu+r5mkmHz3B2jW gUj7B2onLiJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZoLDqAAKCRDBN2bmhouD 12xdD/sHkxSwaK3wAj9bJIFQd3SxEZXMuhG3VHlejfhkDTDqCGJ/tDwTn3Kb6/i7OvydZs5xVD8 Jqz1uAb7w9U1PAKN1tpNLdLH5yJZYa/N7daMCP/T1K9b82GUE1Ok1kzhlamuzu+G9j4GiZQ/1/K SYWvJrnoZk/0WRIZ27P/UAqVoQ7l3K1OHBngBCAx/zbOcaDWhSeXh5wMgBSxP1b/2kSaIIUh5g+ EHnaTSyJ9+XW/iJDr3N1EEx8PlGRz860TXJIobzaBTY+K+EYciNz4+2xXMhGd3YxVH1VUg3WzWv XXsxWl0L1hbJwEEFEoyE+OnTgrMv57MQKcC5Y8Ww5w4mVsS/nQubbhDi9T+gMpxkgtVKa2KXJFv kDb9h6gdIPfzqUvDbU3LhLuDHpOG9JWtVtDEJf+4PfaycfNCjyiw2oRKHcGlSJSKOA+KIJky/8J fPFSySO4nk+KujrpPQn1EV5rNsmrMHm6s7zuhx1ZB6tePzDsfo1xISx92V0ug/ieWTvB1BWSiCO omLydkmrFmTBfNcNNyxuBelJuKobwj6VPj/GxdccsaT+4Cfdm7/Ri1FSiU9t/V4vgbApBdW9Qwh 4v3ECsVbkQOaAF4JKshTTbfMVQzpmFcDcL2AzBr5Dlcdfa9lqqEjEW0vPRQu3rQB24poyEgAp5E 8E3FyOAFyk4dCLQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B The 'gpio' property in GPIO LEDs is deprecated, as reported by dtbs_check: orion5x-lswsgl.dtb: gpio-leds: led-alarm: Unevaluated properties are not = allowed ('gpio' was unexpected) Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/marvell/orion5x-lswsgl.dts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/marvell/orion5x-lswsgl.dts b/arch/arm/boot/d= ts/marvell/orion5x-lswsgl.dts index 35dffb24b8b5..802cd6ff6169 100644 --- a/arch/arm/boot/dts/marvell/orion5x-lswsgl.dts +++ b/arch/arm/boot/dts/marvell/orion5x-lswsgl.dts @@ -104,22 +104,22 @@ gpio-leds { =20 alarm { label =3D "lswsgl:alarm:red"; - gpio =3D <&gpio0 2 GPIO_ACTIVE_LOW>; + gpios =3D <&gpio0 2 GPIO_ACTIVE_LOW>; }; =20 info { label =3D "lswsgl:info:amber"; - gpio =3D <&gpio0 3 GPIO_ACTIVE_LOW>; + gpios =3D <&gpio0 3 GPIO_ACTIVE_LOW>; }; =20 func { label =3D "lswsgl:func:blue:top"; - gpio =3D <&gpio0 9 GPIO_ACTIVE_LOW>; + gpios =3D <&gpio0 9 GPIO_ACTIVE_LOW>; }; =20 power { label =3D "lswsgl:power:blue:bottom"; - gpio =3D <&gpio0 14 GPIO_ACTIVE_LOW>; + gpios =3D <&gpio0 14 GPIO_ACTIVE_LOW>; default-state =3D "on"; }; }; --=20 2.43.0 From nobody Tue Feb 10 02:47:39 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9526016D4D1 for ; Mon, 1 Jul 2024 14:56:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719845816; cv=none; b=BcAL1LyLniLrr9VjtYztwRkcfEIvM968vAdkSiqpXIiEV+NXS/PLSKAOmLh/rrbBx/eV7jsfARjMDG3FDd5s3AFi2U+SYOIvbaC4I6IzkJhU8B7zyYQtZWgqLzIruVlXCVlVmmv4YqIeyNJPIRWlZL9O6pNFv5iNNL2OZETmkR4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719845816; c=relaxed/simple; bh=lulhEHbDI9HXkLTpJhxhZ2CGZpInoFABmokVqba+H/o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eY4IsfJ7mYUYn+4Ya5THsOetvAmjfuY8jlTYvGJgaiwE/4M3PYlrvUnjzcPLGL6YZaM9jyA2XuJ/WjcYawooIWr2srN5+QE+aiYrv+6Yz8pK/qH1buWLvPMJvuq3aG57r9HccUHFmtgCuxKs2EEflsN+3FK7bXY7g453ZQbbXjc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YrdZAIC/; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YrdZAIC/" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4257a390a4eso13657795e9.0 for ; Mon, 01 Jul 2024 07:56:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719845812; x=1720450612; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NQf5Ish3Av0gD9Da5lEuRdMWHvRT8TUq9V7uM/AJGRM=; b=YrdZAIC/39f/WsQE9wNHbV+G5up555StfYHX9H9xxA7dCDWFLbyg+kOOuq74hefn1d cLxAq3wHee0WFMB7G6bN7Kf6DocH1S9f2CYoSEt4tZjNr5G8HfjhqPVKKsmeqs7plPOI 8oN+QXe7Q6iDdM+eXxgdF6kYFTPHSeQGNUDVw8w9XrBT5W5hF5Q8jvsnphhlX3VDrME5 Wo/2FX4LlFfqSwjEUWtfOLJb7pJBwhB8TBWtnia8Mv82yco0+jb2ZUXHvGGcs0tHjuTi ZwtiK5sm9d5kpLKwhQoXZbBylVrYNZa7PdGVurTpsT24tDzMsLypvMrMQ4qCTOtc+o1f oAeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719845812; x=1720450612; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NQf5Ish3Av0gD9Da5lEuRdMWHvRT8TUq9V7uM/AJGRM=; b=icEBTCMz85na1muW0ejp5HLkhe8J62XBdYWQITKVQkmQDwnMIF0c8Sngm2GFBr0dvU ISd/2bhehUQNryAXjndPlml1v0QTi2d+Ny6ZEVpuB8Kh1+KZgJAsJI3Qj+NM0bJ5C8R+ UvWrfzxxUTfSw9rTiGcBuVuAwTcja+cQmPGOrNhbmDW5PRkjYIya5mb5XiQxvlqeZ8JS yTS4/5libQVjup6W5zFNgi4GHTVNKAJ2ut6lxJ2q7+fkrX8POW2lF+DPzHDWcEKDced9 ry8YwHiFMQ99RRPBmdX2x1T9nfz2E7oTICUaKy4vcQL4fyw46G0rD9Ze9zOYZtsn34DO Qznw== X-Forwarded-Encrypted: i=1; AJvYcCVqniMTjBuGNhhX7vgXiHRYvzIKmX432QLDoGbVFwjRslxJ/1cuVYLUlj+lfyX9fdhk0cbxYCrmpGSTcKIMVXhB6trADdiwAmbRZwsC X-Gm-Message-State: AOJu0YzHacjuvI4xz0PI8bhxRgkPFaZLZIF4szs0nzx4WtT6eEFablB9 lAyfy/N82VBgI8X9trWtvLlaGKzaushIulFP0iuMlEiTJuRMh8o34/513U8IOJPWAp+3x2roJdc j X-Google-Smtp-Source: AGHT+IFuoYQlLRqQ9dWAaFITgP1ycNsICaOHlaVoLz1A7a/V/dTh0+2D6q5hqGRXA8gtFdGZaYA6dA== X-Received: by 2002:a05:600c:1c88:b0:424:ab90:ecf0 with SMTP id 5b1f17b1804b1-4257a020ecdmr40982085e9.31.1719845812723; Mon, 01 Jul 2024 07:56:52 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.137]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256b0c0f99sm160062915e9.41.2024.07.01.07.56.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 07:56:52 -0700 (PDT) From: Krzysztof Kozlowski Date: Mon, 01 Jul 2024 16:56:40 +0200 Subject: [PATCH 7/7] ARM: dts: marvell: orion: align LED node name with bindings Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240701-dts-marvell-cleanup-v1-7-4773bd20691a@linaro.org> References: <20240701-dts-marvell-cleanup-v1-0-4773bd20691a@linaro.org> In-Reply-To: <20240701-dts-marvell-cleanup-v1-0-4773bd20691a@linaro.org> To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3014; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=lulhEHbDI9HXkLTpJhxhZ2CGZpInoFABmokVqba+H/o=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmgsOpTixCygCACa26/Ig9SNDnBxhrjatBdht+K 3quMnNm3yKJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZoLDqQAKCRDBN2bmhouD 19McD/9JoJH1/47Ibse8yXq5ZQrHqBFbdg/aRfFIFNiriij2A6v4YY2hWO50iWr4K6f8gRaKhIC nasnu5umdaYkTDXGzQL1kEAVnJ4t3VwyZga9PUsrm9eUfV7cIvTz2lj+OYIoQU1kY1Ei6IgRA3H 4o1zaQ5tdtxmAyNGOf6j3Jw3Ie+9yHdvJ96/GZ+JknCWi6VV5WBea78i/0+YU//r+f8Bvp7kjYN dsOCP8duMYZ0U0NZb1MgSX4lFc0vN8GZsQ3PmY3Pnfp0ALC/8IOdqahgvS0e67YXjBrnKG5ozRg uCfLlNGVJ5r6X67Ftj9lMGJ5wqOqE+tKcgstllUqCaJ2X1Jy3sIC/54jpw0LY7P2XDTpim9V/ZU MHgq2LFfQEdY5FkLkVbyrFvOQhtidDk17t+HZBE9vJkH/V3a9PVEKIF5CqdsjnVdLcvNOzGFXFz WTTUKCScF9zNDqhqVwCMgRgfpWO6iiVM85fLgYW21paImgl99ZOJrzJ0Z8ClWDTkYXPdsqdA5RR LNhM8efXnN94m7Ijoh3G/I08uLEK3uiMHbnN3Bkhw3DrwyQGpEdbRV8ib8wP5fNTxysdZZreUZ8 oL+F9ROB2CEcKBe2PAkAZNH24gM9ZmzyoVtRxT7/P5+RnhTDw5HeoeGA7/Xa99sUTFCw5jtXxe8 XJ+DIrZg1rzUJIA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Bindings expect the LED node names to follow certain pattern, see dtbs_check warnings: orion5x-lswsgl.dtb: gpio-leds: led-alarm: Unevaluated properties are not = allowed ('gpio' was unexpected) Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/marvell/orion5x-lacie-ethernet-disk-mini-v2.dts | 2 +- arch/arm/boot/dts/marvell/orion5x-linkstation-lschl.dts | 2 +- arch/arm/boot/dts/marvell/orion5x-lswsgl.dts | 8 ++++= ---- arch/arm/boot/dts/marvell/orion5x-rd88f5182-nas.dts | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm/boot/dts/marvell/orion5x-lacie-ethernet-disk-mini-v2.= dts b/arch/arm/boot/dts/marvell/orion5x-lacie-ethernet-disk-mini-v2.dts index a7586370b1d5..f81acb9b7223 100644 --- a/arch/arm/boot/dts/marvell/orion5x-lacie-ethernet-disk-mini-v2.dts +++ b/arch/arm/boot/dts/marvell/orion5x-lacie-ethernet-disk-mini-v2.dts @@ -52,7 +52,7 @@ gpio-leds { pinctrl-0 =3D <&pmx_power_led>; pinctrl-names =3D "default"; =20 - led@1 { + led-1 { label =3D "power:blue"; gpios =3D <&gpio0 16 GPIO_ACTIVE_LOW>; }; diff --git a/arch/arm/boot/dts/marvell/orion5x-linkstation-lschl.dts b/arch= /arm/boot/dts/marvell/orion5x-linkstation-lschl.dts index 624b737a8be4..79fee048c900 100644 --- a/arch/arm/boot/dts/marvell/orion5x-linkstation-lschl.dts +++ b/arch/arm/boot/dts/marvell/orion5x-linkstation-lschl.dts @@ -90,7 +90,7 @@ amber-info-led { gpios =3D <&gpio0 3 GPIO_ACTIVE_LOW>; }; =20 - func { + func-led { label =3D "lschl:func:blue:top"; gpios =3D <&gpio0 17 GPIO_ACTIVE_LOW>; }; diff --git a/arch/arm/boot/dts/marvell/orion5x-lswsgl.dts b/arch/arm/boot/d= ts/marvell/orion5x-lswsgl.dts index 802cd6ff6169..e0da406c430f 100644 --- a/arch/arm/boot/dts/marvell/orion5x-lswsgl.dts +++ b/arch/arm/boot/dts/marvell/orion5x-lswsgl.dts @@ -102,22 +102,22 @@ gpio-leds { &pmx_led_power>; pinctrl-names =3D "default"; =20 - alarm { + led-alarm { label =3D "lswsgl:alarm:red"; gpios =3D <&gpio0 2 GPIO_ACTIVE_LOW>; }; =20 - info { + led-info { label =3D "lswsgl:info:amber"; gpios =3D <&gpio0 3 GPIO_ACTIVE_LOW>; }; =20 - func { + led-func { label =3D "lswsgl:func:blue:top"; gpios =3D <&gpio0 9 GPIO_ACTIVE_LOW>; }; =20 - power { + led-power { label =3D "lswsgl:power:blue:bottom"; gpios =3D <&gpio0 14 GPIO_ACTIVE_LOW>; default-state =3D "on"; diff --git a/arch/arm/boot/dts/marvell/orion5x-rd88f5182-nas.dts b/arch/arm= /boot/dts/marvell/orion5x-rd88f5182-nas.dts index fd78aa02a3c5..75ab913b21e5 100644 --- a/arch/arm/boot/dts/marvell/orion5x-rd88f5182-nas.dts +++ b/arch/arm/boot/dts/marvell/orion5x-rd88f5182-nas.dts @@ -32,7 +32,7 @@ gpio-leds { pinctrl-0 =3D <&pmx_debug_led>; pinctrl-names =3D "default"; =20 - led@0 { + led-0 { label =3D "rd88f5182:cpu"; linux,default-trigger =3D "heartbeat"; gpios =3D <&gpio0 0 GPIO_ACTIVE_HIGH>; --=20 2.43.0