From nobody Fri Dec 19 07:35:09 2025 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0FF013DDDA for ; Sat, 29 Jun 2024 04:55:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719636913; cv=none; b=KDfBFh4IBBMCbZZ+YXJMIeHNehJFJBDhnjb4XsF4iqyKIMjzh/554zqER7piJfqevEI3wSgYRdgxmpLN0pLPlQSlyRikN+f9QTo1M8FmurYDVR6QCxjXgTFDouaMllnF37pe1PSB4HBltZVBFwu28TwR9TIVlSMySKb4k5IEa9E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719636913; c=relaxed/simple; bh=LHUR1TtI8mjnffStNAsHkz9pS7nlHhMp1tJRMZ9MeSg=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=jH6E089Fz1dJf93jB88OfX/5as/q3yMLaOy0r9+ykxgM8pjnbYxHyBrty0tzwb558H+RRlA0j3UdBKVMo/nwKzBPx1zW1rR0GuUCWPn9g57D12mqfhD9H7Os9KfQZId/HxkGmis4oLZvpwwofCHh2Jrb63CTcK150EkBz4f4lG8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=fvcNo7j1; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fvcNo7j1" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dfa7a8147c3so2305751276.3 for ; Fri, 28 Jun 2024 21:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719636911; x=1720241711; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=5I8Dk3Jx18DLwgnut7bHcO920rFAKP8Txv5pQFBGNLA=; b=fvcNo7j13pqJty/CVGWl75FCEgaUjN2YrgxfkgIA5e2YUzL1IWEzwRMVkcLb0XmbNZ xGydguIpDITqpARLL5xRLp1kfAUJpFiTmfrktGtxQ3EGlUGnZCIrSL9AcO1FGBSBK6VD 09Otdn0RrF1F0LAP1XQz53JfCEqGiEAZByvU6veSpdst8E0tlZ2u8pP1BR+pq6NzOjLg No3Efkl6VG3rbVzlvilkzZF7Jh0wpQfOiJ8rjUWkQIl35ofvZmabJLnarBWWHIst7Msk JlBPty+vIaZyfgmA7ooJumP3SykEzvIy4ZXlJ/RfWVK5pcuys7kHAN2JSpcR4mhCQOIW 8Yfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719636911; x=1720241711; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5I8Dk3Jx18DLwgnut7bHcO920rFAKP8Txv5pQFBGNLA=; b=gaJmyO7G8Ztj4mXYn141+UGkJeyXzUhc0lq14V/yB86RKMvbr7mnH/WKkt6g81+zip uhTo8MSq+CUjalpS+oXfWXoVYRfkeEXUexeZ80/3I+d1dsWU3Hm89D0SCsaxEIHmALlB DavtQBUKk4ztsLsaBBgUt1it0GNHLOP7okdDMgWCL+h0rTJ/vg5F4rkMDou0F2K72rhd j3aalgfX+HI1ZctVosfqPwm64+th2RpTvcPJyFd2dkOmOYzhJusPboE8/mcmV6q+hLim yW2ZiORDB+o8s9yX5FX4TIcnTlZXI07fhfcp0KGJlz2xh2KCNa2KVEs1yVr2LWPlCHzn deLQ== X-Forwarded-Encrypted: i=1; AJvYcCV9BQMGVeFGM6SYZcz1Qbf54E00LIzLR4H+Zh7Kbu7FyNleFfaFDeQD9E2O/kW/cRHoMTizNYZ3Ou/SvAhNj3V16HuXhau9YNxulW4P X-Gm-Message-State: AOJu0YyD3P/EDR0PIDyQXStScHhIBsu6WD7FBc6m0/T+fHMQwBSn2kWw jmbLnrOg4MBwTNUXZsffog5qi87fPE417/AN65UkuV4F+lMgL8ctkpAef16nZGTbURKAT+ME0vJ 1DFAISg== X-Google-Smtp-Source: AGHT+IHlhj9A+3l7M0c3Zsg//bzFK4sGoQmqySkzynjsb5X2abAc4H7qqAulmEHW+TVVXLld2Zhy5UyS6h0g X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:f9fe:7acd:496e:4edb]) (user=irogers job=sendgmr) by 2002:a05:6902:150d:b0:e03:554e:f396 with SMTP id 3f1490d57ef6-e036eb5c458mr765276.6.1719636910826; Fri, 28 Jun 2024 21:55:10 -0700 (PDT) Date: Fri, 28 Jun 2024 21:53:50 -0700 In-Reply-To: <20240629045350.285243-1-irogers@google.com> Message-Id: <20240629045350.285243-29-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240629045350.285243-1-irogers@google.com> X-Mailer: git-send-email 2.45.2.803.g4e1b14247a-goog Subject: [PATCH v3 28/28] perf session: Constify tool From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Athira Rajeev , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make tool const now that all uses are const and perf_tool__fill_defaults won't be used. The aim is to better capture that sessions don't mutate tools. Signed-off-by: Ian Rogers --- tools/perf/util/session.c | 6 +++--- tools/perf/util/session.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index 6f5692902892..e0eec409e951 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c @@ -1771,7 +1771,7 @@ static int __perf_session__process_decomp_events(stru= ct perf_session *session); static int __perf_session__process_pipe_events(struct perf_session *sessio= n) { struct ordered_events *oe =3D &session->ordered_events; - struct perf_tool *tool =3D session->tool; + const struct perf_tool *tool =3D session->tool; union perf_event *event; uint32_t size, cur_size =3D 0; void *buf =3D NULL; @@ -2183,7 +2183,7 @@ static int __perf_session__process_events(struct perf= _session *session) .in_place_update =3D session->data->in_place_update, }; struct ordered_events *oe =3D &session->ordered_events; - struct perf_tool *tool =3D session->tool; + const struct perf_tool *tool =3D session->tool; struct ui_progress prog; int err; =20 @@ -2233,7 +2233,7 @@ static int __perf_session__process_events(struct perf= _session *session) static int __perf_session__process_dir_events(struct perf_session *session) { struct perf_data *data =3D session->data; - struct perf_tool *tool =3D session->tool; + const struct perf_tool *tool =3D session->tool; int i, ret, readers, nr_readers; struct ui_progress prog; u64 total_size =3D perf_data__size(session->data); diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h index 7f69baeae7fb..7c8dd6956330 100644 --- a/tools/perf/util/session.h +++ b/tools/perf/util/session.h @@ -43,7 +43,7 @@ struct perf_session { u64 one_mmap_offset; struct ordered_events ordered_events; struct perf_data *data; - struct perf_tool *tool; + const struct perf_tool *tool; u64 bytes_transferred; u64 bytes_compressed; struct zstd_data zstd_data; --=20 2.45.2.803.g4e1b14247a-goog