From nobody Fri Dec 19 07:42:17 2025 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0769338FA5 for ; Sat, 29 Jun 2024 04:54:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719636895; cv=none; b=E5zK2uLkjCrGBBipa6xUXWZ3qe/Ka8p8SILwDff2uVTv1ikOmQb9PV+r+olYX74rCFyiuxeG0U2zbGGAz/PPP7C88Mnrkh41H9KwWTAMmsIWd8zf2RvMUV1B6iQOosAaFDSIvkKJgeJ/jukhv5yLMNEya8I9CIDkOkC8pIzUAJA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719636895; c=relaxed/simple; bh=0ztUIio41tQxeZ6pNheoy2WFvNhtkuCm/qyK94mmeeA=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=ckGhV+MynIWZ4XVYjvpwbXUDbHbGmWAnILyB1dL1PyB30AWc05PhnNNpoRpfvB7Oiw5W9Y/gpVfS6ZS+ZWsTObO0fywMSdP2ycHcyeAMLV0Fqq2uknaDsAqSqA4w2o//OqzEOPiJ1KQzdjhRFEz+idXB6BpHyUZ6fFbusmk2KYA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=aGAFvj9x; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="aGAFvj9x" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-64b9800b377so9957767b3.0 for ; Fri, 28 Jun 2024 21:54:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719636893; x=1720241693; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=NfKlTlSCL2wXPfCkyXXt0BLFWNYsoBhoMOQYtSMfZQY=; b=aGAFvj9xgs92gI5LOX1W2jhq7wSBJOFkP4bmEI01aPtCqzAKlWS378QtfNfU6QlkzI 6lXV2zrJHphYzH637m/CDTJigM2dwFRjsG+M5/TqzYeUehTyh00kbjnsgL67YKKyVQ5m IB+cMqzkfVH8vNAItYJkL31MZVQ9oOmG1BqQzXIH7p7h80sk3OnT3F6rBvx9Ekc6Y4bh id/kPJo46bE0ws9APmuNSfjfXyNEvnwwYoSzb0/4DpNOFnx6Ycy7RmhLhLxwz0Wwsd+E /OmWLWDG2y+mb12RDOFycNP/t4yJloa1NQSZJYcV+D5737DSu0gnajK1UahmPi8slbF2 NZSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719636893; x=1720241693; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NfKlTlSCL2wXPfCkyXXt0BLFWNYsoBhoMOQYtSMfZQY=; b=N9k0UX4WrobF641WDQ6Jr42m9/znIFgLEMs6V53KNGHRsQcHWIO7Wx8OnDk8Z8D9dQ qoDcNaBNrfAA4DDP1B57edsoP32XoTtWtjZ+Xb7q0ZE+3grekWBlk9fPi+iQ2ELpWcCH 9As1Ll9dFf8NCnQdlqNLsNz8XmQPcXmYDHtX4M2kfyEiDU9Fcx5ybeakShA/CJjdyyaR T2eqBrq0HtjHH73iUDYtZtfMGjdhfhCnZxbyJBkf6UEdyUOt/NF6nddn8PWYY3IDwC5w hAt11YZeZc5EnDXAru5RXH6SRHslCh7Hx+pezrDMuyRgJgwuMI7YjQwC9sYXRQ+yC0Q0 Q9iA== X-Forwarded-Encrypted: i=1; AJvYcCXB3nqwnAP+7oNooAPkjwMBRqRT1z6Q0Sei+eMomv+6RYcrszPcIeL948Kic1dLw+sMVLMBqNEzB0h7M8aEFu+J9ZV1FLikCOtLo7z5 X-Gm-Message-State: AOJu0Yzy2r0JKFGezwJmfkC28WzMWXUH1fu2lMWn3xMFz12tXeTsy+i9 bePjnHJNCbwujQC87Dg3EYnp1nnX2dLjkwq6qlqadqv70yo2Ea0rdvfi/wNObzMmhBbRCnRPSwX aapUoVQ== X-Google-Smtp-Source: AGHT+IE3hvUi65nhptsIwThb+FEiJVyGB6CGhV5lHcENJmfmi33GBQd2LxbemtNkGqQcGwOe83UOXGl8G96S X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:f9fe:7acd:496e:4edb]) (user=irogers job=sendgmr) by 2002:a25:ae83:0:b0:e03:6445:8ca with SMTP id 3f1490d57ef6-e0364450e73mr75710276.2.1719636892995; Fri, 28 Jun 2024 21:54:52 -0700 (PDT) Date: Fri, 28 Jun 2024 21:53:42 -0700 In-Reply-To: <20240629045350.285243-1-irogers@google.com> Message-Id: <20240629045350.285243-21-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240629045350.285243-1-irogers@google.com> X-Mailer: git-send-email 2.45.2.803.g4e1b14247a-goog Subject: [PATCH v3 20/28] perf mem: Use perf_tool__init From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Athira Rajeev , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use perf_tool__init so that more uses of struct perf_tool can be const and not relying on perf_tool__fill_defaults. Signed-off-by: Ian Rogers --- tools/perf/builtin-mem.c | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c index c2038a32543c..c12ca0ec1237 100644 --- a/tools/perf/builtin-mem.c +++ b/tools/perf/builtin-mem.c @@ -285,7 +285,23 @@ static int report_raw_events(struct perf_mem *mem) .force =3D mem->force, }; int ret; - struct perf_session *session =3D perf_session__new(&data, &mem->tool); + struct perf_session *session; + + perf_tool__init(&mem->tool, /*ordered_events=3D*/true); + mem->tool.sample =3D process_sample_event; + mem->tool.mmap =3D perf_event__process_mmap; + mem->tool.mmap2 =3D perf_event__process_mmap2; + mem->tool.comm =3D perf_event__process_comm; + mem->tool.lost =3D perf_event__process_lost; + mem->tool.fork =3D perf_event__process_fork; + mem->tool.attr =3D perf_event__process_attr; + mem->tool.build_id =3D perf_event__process_build_id; + mem->tool.namespaces =3D perf_event__process_namespaces; + mem->tool.auxtrace_info =3D perf_event__process_auxtrace_info; + mem->tool.auxtrace =3D perf_event__process_auxtrace; + mem->tool.auxtrace_error =3D perf_event__process_auxtrace_error; + + session =3D perf_session__new(&data, &mem->tool); =20 if (IS_ERR(session)) return PTR_ERR(session); @@ -449,21 +465,6 @@ int cmd_mem(int argc, const char **argv) { struct stat st; struct perf_mem mem =3D { - .tool =3D { - .sample =3D process_sample_event, - .mmap =3D perf_event__process_mmap, - .mmap2 =3D perf_event__process_mmap2, - .comm =3D perf_event__process_comm, - .lost =3D perf_event__process_lost, - .fork =3D perf_event__process_fork, - .attr =3D perf_event__process_attr, - .build_id =3D perf_event__process_build_id, - .namespaces =3D perf_event__process_namespaces, - .auxtrace_info =3D perf_event__process_auxtrace_info, - .auxtrace =3D perf_event__process_auxtrace, - .auxtrace_error =3D perf_event__process_auxtrace_error, - .ordered_events =3D true, - }, .input_name =3D "perf.data", /* * default to both load an store sampling --=20 2.45.2.803.g4e1b14247a-goog