From nobody Wed Dec 17 15:43:04 2025 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 873E0156984 for ; Fri, 28 Jun 2024 15:46:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719589572; cv=none; b=tvua4SDQSPEwlsLA+zHzyMy6p61atrGdvRZSYe60Gqz1Ga85hsyTQtTEsY5feps9Fyqc44M/uEe408bVVG0r1EaH5If/8w59gbr46F6qsTSLFurHSjFw6x/y7RNFAE7c9dA9yr/4F0QYz3w+n+poxNMvP9o0DHx+jhnq02wEnfk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719589572; c=relaxed/simple; bh=E2ON8afLO1WrZKvKgL0DbbmyDPjigcjuWNpKuF4J1pM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=nCwK3i4EItyYnRY95q5UfcF82VJDsRQP1UPcU0+zQJR8hy0FOKkX+JCwBOqTIRSXYk3qUP2A8MiXgAA/HkegjUdIhteol/SLuUnKL7vV5Q+NMftF+CMlDFWx9iK06M7UtJzR8PLoheF6dD6jsKEWIjZuhQu1/dAXShjZKMakR/w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=WuCk9LwN; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WuCk9LwN" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-7065df788f7so759984b3a.0 for ; Fri, 28 Jun 2024 08:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719589571; x=1720194371; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=BWwY890+5NLFwmpl4Ncpp5MeSVkTzmaxwxuDQSu9PBk=; b=WuCk9LwNr3A6N6b+VuaUw78Ve6qizDWxJzIQAw0ilQaT6m5jHiat4Br1uEnPAqP667 Oubsu5RucPUtv8V43QYnQrM2WHSGaib96DpoLYt7ZHzrAiQfp1fHW0Yc/YFQogCnqhLi 31FML6zlwT4r9J0nXL1ts1QKI25oqQBZlB7k6aQ21hcl+s8N2gLANDWNN8MqiMIlU7/l 18iKHXeRz8e59GrKtkBIt+yTQv7WtIpBV82+vLAFYyuvdHu4WHpX5l6s2zVsIGNlEvqU 6zGMYmZzo8ZxJAXyd4xTM1nwxcUE5EZd06VIS2f/9mnY9x27se9h8QbQr+OQ2flFTJV4 lTyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719589571; x=1720194371; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BWwY890+5NLFwmpl4Ncpp5MeSVkTzmaxwxuDQSu9PBk=; b=XwN4dtVW/ry76use6s0wwfv3jHzupnR+DGnHjgxfYJl1UYabmeEAXzbHGT9Cik2Cw4 OPy48x4VL0asYCiNz7zioyJFBRgpQKkMf79Cm+7s6gdJkGSx92pgJWZ7okHFYd91ENZ/ MhR90ERkpMHZ2Z7DPPHEm417jbDHdNJuDg/2kA3zroOUNeR93BZU2A8TjMdSeIyjorbo 748Ve+A52hOOp25Ke3wFZXnfzWQx76aVnZP8SaR6ro32gII7AICTutP9rLAgsGvKsvvk X9PJ0j97sJoJVAGkrSfta7XO60Y33HUAEX4v45xjnlc63/eDqL0jlv3k0epk1Bk8lwPT VeHg== X-Forwarded-Encrypted: i=1; AJvYcCWYKTHvuBcmRpUk+QB6jUR/Wrmk60B+mlGcuJPecHOcZjnYElljnJDrWV1Cf0JuBizMQNhB76IruswOy2wesxcdPsoyuRqNkISyZTsE X-Gm-Message-State: AOJu0Yxu+3UZ+BJTp9sb78lu2FGaUXEhIuVrmaT7aP63x410w9TqoVq5 7RJZSxK2yMPjvYCE25wch03FZRMWMCdiR+8FCaujqgcGyQ9mNzNL9HHE6x1TmutAp3Tj+uqyjVk cHqcJosvljO9i8vLhIYXO2y4YUg== X-Google-Smtp-Source: AGHT+IG32gMnXvaf3njbjouiPVyRu1hT0usmDZOv2jZJ7sVHWHnnRif/Y+Bn+1rnVmXX5zr8ZtJ4EL4tM4RTBaskLis= X-Received: from aniketm.c.googlers.com ([fda3:e722:ac3:cc00:4f:4b78:c0a8:3387]) (user=aniketmaurya job=sendgmr) by 2002:a05:6a00:23c7:b0:6ec:f400:95a7 with SMTP id d2e1a72fcca58-708536c380bmr89585b3a.3.1719589570648; Fri, 28 Jun 2024 08:46:10 -0700 (PDT) Date: Fri, 28 Jun 2024 15:46:03 +0000 In-Reply-To: <20240624052851.1030799-1-aniketmaurya@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240624052851.1030799-1-aniketmaurya@google.com> X-Mailer: git-send-email 2.45.2.803.g4e1b14247a-goog Message-ID: <20240628154603.326075-1-aniketmaurya@google.com> Subject: [PATCH v3 2/3] i3c: dw: Use new *_enabled clk API From: Aniket To: Alexandre Belloni , Jeremy Kerr , Joel Stanley , Billy Tsai , Rob Herring , Krzysztof Kozlowski Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Aniket Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move to "enabled" variant of clk_get API. It takes care of enable and disable calls during the probe and remove. Signed-off-by: Aniket --- drivers/i3c/master/dw-i3c-master.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c= -master.c index 9aae5c8dba8d..4e3335641dcd 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -1450,7 +1450,7 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, if (IS_ERR(master->regs)) return PTR_ERR(master->regs); =20 - master->core_clk =3D devm_clk_get(&pdev->dev, NULL); + master->core_clk =3D devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(master->core_clk)) return PTR_ERR(master->core_clk); =20 @@ -1459,10 +1459,6 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, if (IS_ERR(master->core_rst)) return PTR_ERR(master->core_rst); =20 - ret =3D clk_prepare_enable(master->core_clk); - if (ret) - goto err_disable_core_clk; - reset_control_deassert(master->core_rst); =20 spin_lock_init(&master->xferqueue.lock); @@ -1501,9 +1497,6 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, err_assert_rst: reset_control_assert(master->core_rst); =20 -err_disable_core_clk: - clk_disable_unprepare(master->core_clk); - return ret; } EXPORT_SYMBOL_GPL(dw_i3c_common_probe); @@ -1513,8 +1506,6 @@ void dw_i3c_common_remove(struct dw_i3c_master *maste= r) i3c_master_unregister(&master->base); =20 reset_control_assert(master->core_rst); - - clk_disable_unprepare(master->core_clk); } EXPORT_SYMBOL_GPL(dw_i3c_common_remove); =20 --=20 2.45.2.803.g4e1b14247a-goog