From nobody Sun Dec 14 19:19:00 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB67B14F136 for ; Fri, 28 Jun 2024 11:37:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719574632; cv=none; b=W5dzGMYbjH9eAVolwbHlJH5uyweI5uRpQg8jgmdPlDLBKa2djF7VM490YfdNGyw5RpNGexgHdXvdhLQykd7AzpkvgITPReyvjfoP7wyOrA5FeJSEKPxR0xhf9rOM5eMQvRdpMRO8ZiGp5bBZ5/+WE7BWCmyVwMWIIYH0cJighys= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719574632; c=relaxed/simple; bh=uvNcnB9Ff5fU7B8IHkw9VTflTK0qbmhPT0ocf1uno4w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Mq55I8poGLurEWAb6ICAm2uchOaW0WchncRx5pNBazRRqHJWHHtywM9s9rdFVFMZV/o7jtvm2rEB+uOjU2e4G7pc1FkQU/nKo0BzHg5D0MPm3S9lrc/BNUSHt7dGqFoRzN4K5tZdonsXGl1bWb0DptdQGlJLl9afZyG+O0MdatA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uGXZQM/G; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uGXZQM/G" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-363bd55bcc2so296281f8f.2 for ; Fri, 28 Jun 2024 04:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719574629; x=1720179429; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fWlN3/sFgEOPWB0LU/uquV7p1t4WmyyxNaTnRP7KUZk=; b=uGXZQM/GNMpB0QNCXupzlcoEpXeBFV+KjoB/K1BQH1VZf1dy7v0mBDfXHOYFQZ3N5+ MIt5NK0jHlVS5etJm9bKHacOHSj1U7mM0WZ02BrCh11MGjMU/5S2SO+JdLrXDYMQuKeG hTZxpQAxD6cJttAWZv7Z9MHjZQjngJN4VNhJ8me/nTAYG5bb5kScmxLFXpmb35rbQdrn KLXsKjyIYsf/69qGCi/O5ADgydI0sbcNQjwroYlYPtMdcBhe6EDi4D5tJMpUJPq11H0f vKu6a607ivC2hkv7WkcnJxqQO8fCVun7Dvh5ROwWHeMTgrvqRXiFUO8VHkfxk7+4sWsI weMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719574629; x=1720179429; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fWlN3/sFgEOPWB0LU/uquV7p1t4WmyyxNaTnRP7KUZk=; b=mXdgTd02rszf76V4RPVfs4ZtdUk2YK/tZALfegDFEq11DHzOmSqj5LvJ/tfYOCo0eR 2GOPfInBoCNYphxQop+ierYPpHa7psF/Mpuxfa06zjxnb1RRXhMXDeRThzbBKJaODtac N018eT+FI9YNMrhZHC/uWJ06qmirNRbrVJUXXKEvX6nJpr9YKADdTMA1YgVxgi2l6XCF 9g7D0BnPTXdqhZVBealx6N9wN13epkDZovgOnr+UAUjYY+ij7GS/43FR6aowUWwf1GTg DmD95acuQAWf5rnScrj602BgPZDq5hsTfAcX3eR/Nh80CKhAPTsPsnocfZZjfq/r1Hm5 4V3Q== X-Gm-Message-State: AOJu0YyWvQ+zLVjG+Aa5nolLbFNBtAQh0vmLmyFJXeoJmdxBqwTXSWEp NKC/tXnrAVoySVb+lQ/XCsgkav82uRoHbgIQkvSTiy3Qu0scBmvtZTPBQ80hcAA= X-Google-Smtp-Source: AGHT+IGbATUTf1CtcHvGJ7zBXcjjbG4tWLMniVEGLtMqHk8/pkxS70uyMYSeCOTwFKQbfklLYPgaDw== X-Received: by 2002:a5d:5f90:0:b0:35f:fb4:fc7d with SMTP id ffacd0b85a97d-366fb8dd6e1mr11284914f8f.31.1719574629347; Fri, 28 Jun 2024 04:37:09 -0700 (PDT) Received: from srini-hackbase.lan ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3675a0fba5asm2048937f8f.71.2024.06.28.04.37.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jun 2024 04:37:08 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Joy Chakraborty , stable@vger.kernel.org, Dan Carpenter , Srinivas Kandagatla Subject: [PATCH 1/4] nvmem: rmem: Fix return value of rmem_read() Date: Fri, 28 Jun 2024 12:37:01 +0100 Message-Id: <20240628113704.13742-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240628113704.13742-1-srinivas.kandagatla@linaro.org> References: <20240628113704.13742-1-srinivas.kandagatla@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1327; i=srinivas.kandagatla@linaro.org; h=from:subject; bh=MOaOKfQhsx5kjf33gADJlKQaVbEXqSwm5ga7NXsrcWs=; b=owEBbQGS/pANAwAKAXqh/VnHNFU3AcsmYgBmfqBTzBgjUHYeEwlbWQDFMaAtBSjcDX/w00E9j 12gnIvUht6JATMEAAEKAB0WIQQi509axvzi9vce3Y16of1ZxzRVNwUCZn6gUwAKCRB6of1ZxzRV N/gYB/46iK1hmFmIdZgewv89dONRCWZR4eRMehgOKAJlPj57exgk/E4yc9cvrTG6jDCJkIOHuwz hfEOrDUORB9Nmmpnwz4/HIp39cRobD+XhsBB3c0uhNyySz3tsxeQgGNuWsideaHK8ZrqDR5Yqcx +9JrenzXH5okKcaR3WPCi5o7b+aZ34qC9st4r6goEcts6k6d/U5g/RMMdRvHKLPTzDNeqIsXshG 00ryA7qvviVS+aUj/0LmOf0VxbATBzXx6nWFTsbABKaLH3X9W+gns0BXGVxXYyJeBYes2NvlIX5 Y3zQ2sylHnztZ25Ooy1LMunh0DL9BQ7+IrdI16GgrQCcCZQ1 X-Developer-Key: i=srinivas.kandagatla@linaro.org; a=openpgp; fpr=ED6472765AB36EC43B3EF97AD77E3FC0562560D6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Joy Chakraborty reg_read() callback registered with nvmem core expects 0 on success and a negative value on error but rmem_read() returns the number of bytes read which is treated as an error at the nvmem core. This does not break when rmem is accessed using sysfs via bin_attr_nvmem_read()/write() but causes an error when accessed from places like nvmem_access_with_keepouts(), etc. Change to return 0 on success and error in case memory_read_from_buffer() returns an error or -EIO if bytes read do not match what was requested. Fixes: 5a3fa75a4d9c ("nvmem: Add driver to expose reserved memory as nvmem") Cc: stable@vger.kernel.org Signed-off-by: Joy Chakraborty Reviewed-by: Dan Carpenter Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/rmem.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/nvmem/rmem.c b/drivers/nvmem/rmem.c index 752d0bf4445e..7f907c5a445e 100644 --- a/drivers/nvmem/rmem.c +++ b/drivers/nvmem/rmem.c @@ -46,7 +46,10 @@ static int rmem_read(void *context, unsigned int offset, =20 memunmap(addr); =20 - return count; + if (count < 0) + return count; + + return count =3D=3D bytes ? 0 : -EIO; } =20 static int rmem_probe(struct platform_device *pdev) --=20 2.25.1