From nobody Wed Dec 17 23:53:52 2025 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A18117E8E4 for ; Tue, 25 Jun 2024 21:41:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719351687; cv=none; b=QBfIkMjqNJv7bm9LDEyimedF3om3uC9ttWDVkatQ3niXy2hMJxZZMFNfg1YTcQW4xnjsRZKzACjYm5Wa6fJw2SnHrH5d8nK/iL81Rl5JYktFNVDS1yX68VGXdV6c0XyGnW8gUv7HnK+W54nK3hNnmPXNswiekgoy6zHRD/REBtQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719351687; c=relaxed/simple; bh=XCcoFDUSO68+IaAjxY0zcTXTu1PIqW7TvqckZysWY14=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=aoYSdgIlTJWowqAo/zgLb10m69jNhiAa23Fne/pX1aXXzsls9p6lXGAB0fV5e8A+z9VKrYoeKLHxXQAwIybX636YkxvSpKjKkiR49WZb1ZQd8PIAid8/hCbRmlV/0BO6ZtK+J3dEU6t2i2fWWr9uubLZG+Y/QTHQ06K84tFTWNo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=EQeV/X1u; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EQeV/X1u" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dfefc2c8569so12034089276.3 for ; Tue, 25 Jun 2024 14:41:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719351685; x=1719956485; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=nNKhk3i6ZR127Ku5IVQOBYSjQPa/zZMsU20LfXii9LU=; b=EQeV/X1uUyy31ZFHFCFLOMcRduSN8hsEJIOoYAjROttvDhwDlKPqfaBau4qrBrGTy4 vsIVCReGBRN8JuLI8qRxQGorNmuu4+NKVU66ROY8nn/oCZQmm2hccXOd/CamsIGnwkx4 1X3HoQCkUbqKz9/Poc8OVbMkvp3hRNwjGU/0QX5elNeXHic2sBVloFuTXn+Gl3domqAA Qza1tQBwXtnn/4J6TUMCwpspv7Tyr4QABHWL93M9JdCJoHZTrN15VPG7B8btqyfn5Iyv eoHCHJtm533z3c0SrDbu4NoE68VA7JbZ5L57z20lRL+U2UM37pXl9jBSkfqzL5kBJkqE aWBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719351685; x=1719956485; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nNKhk3i6ZR127Ku5IVQOBYSjQPa/zZMsU20LfXii9LU=; b=J/uFd8WLGuIhClIp6x/eGLqawUGMyn6Rwald6MwK9GTRBG9nSAkUthOM40gZACXg2P lgCyOXMn3jtcPsTtZgsQsyHt+OBCKbv0MwXSIHZMCpXF3sTHGtjlFY6uSZyvJM9ZhUNq iRN+5sgRcGOrVPfw50tDwVkJ2RHp3p0WEo2CGdjvr7IxtwmZqOQckdNf4qutBb7pwxzd c+SnxvXmuD1sME7vTCj57WpvUuME5UT3dvhvmlN4r0VcIdTEva2eyVZ0MdCMKXQ2VgDN 0P4CZytvzXokShn7nrLgnv6Bl82LJlgEqIasVGqi9V8va4ayI6pvz9fJXiwByeFKYU9j ue+Q== X-Forwarded-Encrypted: i=1; AJvYcCXCJllIUfpp+QsM5z5GHCmfiuiAS8u969B0hvqSULpg3GjC7pq7IxDjb978/W5O6x9E/tPkmjH95ckXOW73dsrDOzBx2F8nriIpV+RN X-Gm-Message-State: AOJu0YzQGup/9uIcjpkJYecUBTm0ri9ONbB/tMAQeZVZ06LZ9THIG5Tx NfMWW96xMeMS+lfh0QS7YVdZBJODG6gdnPx/afy6UZJvc+EcSXvE8AG5aoh00gmrNJAf0KrEEmn ifqgq/Q== X-Google-Smtp-Source: AGHT+IE+D2HalyQ6pQIV4aC4dnh0NFJgmZWKr3iLPBEr7yE5ihEHg9ErrPWEv3Oai+b0CrXRW2IiX89XKhUd X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:23a1:25b9:2412:56de]) (user=irogers job=sendgmr) by 2002:a25:3625:0:b0:dfd:d6ec:4e3b with SMTP id 3f1490d57ef6-e0303f2b228mr156445276.7.1719351685334; Tue, 25 Jun 2024 14:41:25 -0700 (PDT) Date: Tue, 25 Jun 2024 14:41:11 -0700 In-Reply-To: <20240625214117.953777-1-irogers@google.com> Message-Id: <20240625214117.953777-3-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240625214117.953777-1-irogers@google.com> X-Mailer: git-send-email 2.45.2.741.gdbec12cfda-goog Subject: [PATCH v5 2/8] perf ui: Make ui its own library From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , "=?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?=" , Benno Lossin , Andreas Hindborg , Alice Ryhl , Nick Terrell , Andrei Vagin , Kees Cook , Oliver Upton , Ze Gao , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make the ui code its own library. This is done to avoid compiling code twice, once for the perf tool and once for the perf python module. Signed-off-by: Ian Rogers Reviewed-by: James Clark --- tools/perf/Build | 2 +- tools/perf/Makefile.perf | 10 ++++++++++ tools/perf/ui/Build | 18 +++++++++--------- tools/perf/ui/browsers/Build | 14 +++++++------- tools/perf/ui/tui/Build | 8 ++++---- 5 files changed, 31 insertions(+), 21 deletions(-) diff --git a/tools/perf/Build b/tools/perf/Build index b0cb7ad8e6ac..16ed1357202b 100644 --- a/tools/perf/Build +++ b/tools/perf/Build @@ -55,7 +55,7 @@ CFLAGS_builtin-report.o +=3D -DDOCDIR=3D"BUILD_STR($(s= rcdir_SQ)/Documentation)" =20 perf-y +=3D util/ perf-y +=3D arch/ -perf-y +=3D ui/ +perf-ui-y +=3D ui/ perf-y +=3D scripts/ =20 gtk-y +=3D ui/gtk/ diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index acc41a6717db..c5a027381c55 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -425,10 +425,14 @@ endif =20 export PERL_PATH =20 +LIBPERF_UI_IN :=3D $(OUTPUT)perf-ui-in.o +LIBPERF_UI :=3D $(OUTPUT)libperf-ui.a + PERFLIBS =3D $(LIBAPI) $(LIBPERF) $(LIBSUBCMD) $(LIBSYMBOL) ifdef LIBBPF_STATIC PERFLIBS +=3D $(LIBBPF) endif +PERFLIBS +=3D $(LIBPERF_UI) =20 # We choose to avoid "if .. else if .. else .. endif endif" # because maintaining the nesting to match is a pain. If @@ -729,6 +733,12 @@ $(PERF_IN): prepare FORCE $(PMU_EVENTS_IN): FORCE prepare $(Q)$(MAKE) -f $(srctree)/tools/build/Makefile.build dir=3Dpmu-events obj= =3Dpmu-events =20 +$(LIBPERF_UI_IN): FORCE prepare + $(Q)$(MAKE) $(build)=3Dperf-ui + +$(LIBPERF_UI): $(LIBPERF_UI_IN) + $(QUIET_AR)$(RM) $@ && $(AR) rcs $@ $< + $(OUTPUT)perf: $(PERFLIBS) $(PERF_IN) $(PMU_EVENTS_IN) $(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) \ $(PERF_IN) $(PMU_EVENTS_IN) $(LIBS) -o $@ diff --git a/tools/perf/ui/Build b/tools/perf/ui/Build index 6b6d7143a37b..d2ecd9290600 100644 --- a/tools/perf/ui/Build +++ b/tools/perf/ui/Build @@ -1,12 +1,12 @@ -perf-y +=3D setup.o -perf-y +=3D helpline.o -perf-y +=3D progress.o -perf-y +=3D util.o -perf-y +=3D hist.o -perf-y +=3D stdio/hist.o +perf-ui-y +=3D setup.o +perf-ui-y +=3D helpline.o +perf-ui-y +=3D progress.o +perf-ui-y +=3D util.o +perf-ui-y +=3D hist.o +perf-ui-y +=3D stdio/hist.o =20 CFLAGS_setup.o +=3D -DLIBDIR=3D"BUILD_STR($(LIBDIR))" =20 -perf-$(CONFIG_SLANG) +=3D browser.o -perf-$(CONFIG_SLANG) +=3D browsers/ -perf-$(CONFIG_SLANG) +=3D tui/ +perf-ui-$(CONFIG_SLANG) +=3D browser.o +perf-ui-$(CONFIG_SLANG) +=3D browsers/ +perf-ui-$(CONFIG_SLANG) +=3D tui/ diff --git a/tools/perf/ui/browsers/Build b/tools/perf/ui/browsers/Build index 2608b5da3167..a07489e44765 100644 --- a/tools/perf/ui/browsers/Build +++ b/tools/perf/ui/browsers/Build @@ -1,7 +1,7 @@ -perf-y +=3D annotate.o -perf-y +=3D annotate-data.o -perf-y +=3D hists.o -perf-y +=3D map.o -perf-y +=3D scripts.o -perf-y +=3D header.o -perf-y +=3D res_sample.o +perf-ui-y +=3D annotate.o +perf-ui-y +=3D annotate-data.o +perf-ui-y +=3D hists.o +perf-ui-y +=3D map.o +perf-ui-y +=3D scripts.o +perf-ui-y +=3D header.o +perf-ui-y +=3D res_sample.o diff --git a/tools/perf/ui/tui/Build b/tools/perf/ui/tui/Build index f916df33a1a7..2ac058ad1a61 100644 --- a/tools/perf/ui/tui/Build +++ b/tools/perf/ui/tui/Build @@ -1,4 +1,4 @@ -perf-y +=3D setup.o -perf-y +=3D util.o -perf-y +=3D helpline.o -perf-y +=3D progress.o +perf-ui-y +=3D setup.o +perf-ui-y +=3D util.o +perf-ui-y +=3D helpline.o +perf-ui-y +=3D progress.o --=20 2.45.2.741.gdbec12cfda-goog