From nobody Fri Dec 19 04:52:23 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB62717CA17 for ; Tue, 25 Jun 2024 18:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719339764; cv=none; b=E6kZFjCBpECdLAQ6lZoVNPcBTWcFZecBpIBvtruJB607loV2AQ+o6ALyc2U4jdeD9UbhOQslNrdl6cJFrq6dnvBRvD/xSrXr7hkA/u4OTxc5AeJeW6McF7M9d2rZXCaA3MW6tZOVTEfwElSiBQE4fm5YMTTHDzljlOD5L6znEjg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719339764; c=relaxed/simple; bh=7trYQVtVfDfgh31uDwek2t/HxT/pSeUZ7YfMoL5efRs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=L5u16StBpWC5OmU1bFxYTxK4qxh0adQnw5Ugv7/0KoU+eaGg2PJq5rGMiT8w8UND2IVwlPoqeTrn3WPb0l1MXjvOMcwXpV0eOVRhRuZXBfLCXczXwY4cu/sYsy3T00Ukg5L3wr+M+xJaStyrwlML/joXPk0AXe/sR+shCUQtHQQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YTn+2DF4; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YTn+2DF4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719339763; x=1750875763; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7trYQVtVfDfgh31uDwek2t/HxT/pSeUZ7YfMoL5efRs=; b=YTn+2DF4J6plmSdjY/yPoPerFAFavgYm23Ns9GsJR2dBmkaptH5B622i ORVYb4NXLX+VdGXcMB9nfoPEXmixN7k7/i8Z0Ldy9ZDhzibujj3oXPFaq X28d+Q37w6v7Xk4AKmMkZNtgWHM1IBgZ8/1XELFTfkruRTddISgBpjXMj 83AdwRCdu0GGAAvzQ0x55ftSeD41mngbyKcrIVBoJ9n+dAkUde39/uUqd j67suovQ5ZwsX7ShSMY2HQNI+aQlMKr6BKwXQTnLSHVl6YoKX09a+8HF7 aoCtCSLZW8tYc7I6SWBFoO5UWsAnuUbN11fUxdAAICfkmjvx+sQkvAaDY Q==; X-CSE-ConnectionGUID: 3dU6g9y7RFGdvfjEFvTZ6g== X-CSE-MsgGUID: k5bsSdMcRLKDS1Yy+eyx1Q== X-IronPort-AV: E=McAfee;i="6700,10204,11114"; a="16204040" X-IronPort-AV: E=Sophos;i="6.08,264,1712646000"; d="scan'208";a="16204040" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2024 11:22:22 -0700 X-CSE-ConnectionGUID: 71CNM84ZTRCsiusD3ipyag== X-CSE-MsgGUID: eTNDkOkoT9mhnbrvJInNbQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,264,1712646000"; d="scan'208";a="48913358" Received: from kanliang-dev.jf.intel.com ([10.165.154.102]) by orviesa004.jf.intel.com with ESMTP; 25 Jun 2024 11:22:07 -0700 From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@kernel.org, acme@kernel.org, namhyung@kernel.org, irogers@google.com, adrian.hunter@intel.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org Cc: ak@linux.intel.com, eranian@google.com, Kan Liang Subject: [PATCH V2 10/13] perf: Extend perf_output_read Date: Tue, 25 Jun 2024 11:22:53 -0700 Message-Id: <20240625182256.291914-11-kan.liang@linux.intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20240625182256.291914-1-kan.liang@linux.intel.com> References: <20240625182256.291914-1-kan.liang@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kan Liang The event may have been updated in the PMU-specific implementation, e.g., Intel PEBS counters snapshotting. The common code should not read and overwrite the value. The PERF_SAMPLE_READ in the data->sample_type can be used to detect whether the PMU-specific value is available. If yes, avoid the pmu->read() in the common code. Reviewed-by: Andi Kleen Signed-off-by: Kan Liang --- kernel/events/core.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 8f908f077935..733e507948e6 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -7243,7 +7243,7 @@ static void perf_output_read_one(struct perf_output_h= andle *handle, =20 static void perf_output_read_group(struct perf_output_handle *handle, struct perf_event *event, - u64 enabled, u64 running) + u64 enabled, u64 running, bool read) { struct perf_event *leader =3D event->group_leader, *sub; u64 read_format =3D event->attr.read_format; @@ -7265,7 +7265,7 @@ static void perf_output_read_group(struct perf_output= _handle *handle, if (read_format & PERF_FORMAT_TOTAL_TIME_RUNNING) values[n++] =3D running; =20 - if ((leader !=3D event) && + if ((leader !=3D event) && read && (leader->state =3D=3D PERF_EVENT_STATE_ACTIVE)) leader->pmu->read(leader); =20 @@ -7280,7 +7280,7 @@ static void perf_output_read_group(struct perf_output= _handle *handle, for_each_sibling_event(sub, leader) { n =3D 0; =20 - if ((sub !=3D event) && + if ((sub !=3D event) && read && (sub->state =3D=3D PERF_EVENT_STATE_ACTIVE)) sub->pmu->read(sub); =20 @@ -7307,7 +7307,8 @@ static void perf_output_read_group(struct perf_output= _handle *handle, * on another CPU, from interrupt/NMI context. */ static void perf_output_read(struct perf_output_handle *handle, - struct perf_event *event) + struct perf_event *event, + bool read) { u64 enabled =3D 0, running =3D 0, now; u64 read_format =3D event->attr.read_format; @@ -7325,7 +7326,7 @@ static void perf_output_read(struct perf_output_handl= e *handle, calc_timer_values(event, &now, &enabled, &running); =20 if (event->attr.read_format & PERF_FORMAT_GROUP) - perf_output_read_group(handle, event, enabled, running); + perf_output_read_group(handle, event, enabled, running, read); else perf_output_read_one(handle, event, enabled, running); } @@ -7367,7 +7368,7 @@ void perf_output_sample(struct perf_output_handle *ha= ndle, perf_output_put(handle, data->period); =20 if (sample_type & PERF_SAMPLE_READ) - perf_output_read(handle, event); + perf_output_read(handle, event, !(data->sample_flags & PERF_SAMPLE_READ)= ); =20 if (sample_type & PERF_SAMPLE_CALLCHAIN) { int size =3D 1; @@ -7968,7 +7969,7 @@ perf_event_read_event(struct perf_event *event, return; =20 perf_output_put(&handle, read_event); - perf_output_read(&handle, event); + perf_output_read(&handle, event, true); perf_event__output_id_sample(event, &handle, &sample); =20 perf_output_end(&handle); --=20 2.35.1