From nobody Fri Dec 19 07:01:59 2025 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FC1917D370 for ; Tue, 25 Jun 2024 17:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719336395; cv=none; b=pc4jerBp7a+VIrqHagWAlw6iRR8ZgZUJuEZVTHcOxxmS9Brz1PrdGCsLXWsG04iAKSuD+gjSQB5vci9UoDD+oWeJ9sq1ufkGz1c3HGe9td42ODpuTqkyDrCQ3QBTuKB+7C/IcQTueKppqyl5n3jZox+ZJ0GUJrpdBgPuWpJvVRY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719336395; c=relaxed/simple; bh=xTDdcKAsM0Ri5uMJZogx0bCMWjSncnIkrWNhWgEEO0w=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=M0NaETSA4RYX2nsA0jj/Z5PLI/L15Hcg8R6IJRRstcCGi9keyV1sMIYTKxFeFgVFUgUQoyGgnsRRuvZ9Dp6GtzuI1pwmD0chARO7KF/5Hg1Xt4z9yYUjX84tShoMH8xaZ6r82LocWw3dz3UhqYgGP3Bh6aiSribstOG1FJreghg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=YmhMTzHj; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YmhMTzHj" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-62f43c95de4so132225807b3.3 for ; Tue, 25 Jun 2024 10:26:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719336392; x=1719941192; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=6guPMXmcdW65GtfPCYKyOHBofbB3BqlsDiMCqc1Wqps=; b=YmhMTzHjLw5zVWZw3diCPM1b2dlunOJGcuqopETli6VbX/BjEP4Pafz7AUF318/Kb4 SHAIRXV+x76oa90ZRTQdb4ZCWf9p1zv62RayLEPZAepe2OFxkUrYR74hr/nP0Fnjd2fh H45aE48agPQ6noIz2HijaFxjrTU/cNpIFspDNkCvVk9teAfd9hcw4KFQG7MC5fvoRNNQ WKXaRjnvio0CEEXZ4KJQDEpm+urwsNwKp3xnOk+Ge2XXbqICwIkHlTrT+qmNAkEVarem 0GqdTJ3Gs9rJv9iAuWv2tKVoBBCMNeg/TXEtjQvao8ZJjd9eRDbtPuoSRoxdP3ZSz290 UauQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719336392; x=1719941192; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6guPMXmcdW65GtfPCYKyOHBofbB3BqlsDiMCqc1Wqps=; b=UWI2u3h0XgzYjBln0GmQ75RJLxy5wIR+GvC6UDamg5MVKbv0SUCr7A1LfGrHT6S1ds iNSA6CxCqDRI8VQ7XThkQ4462aUQrlVBl6Ih+GL+o8V+F9+t/3YWoyzGI9bUndZpqqS4 xGgztDEJVuwVpHhLVid0Hlf2dA99UUUgfNbwC4jZLBqvviSwMyUcqrevfYs62XU7yiay lYGkcQG42RwbVDYaIacdVwTcR3csWOccgqg0BKnlFMhgDm5HbitdKpUoJKFYgk21ZGzW GByF5L+xD1EL18wZl32hXg+BWB7/cm3qTB/dGMU/+thJ716op7XBtjBEP2Lk2pl9pX4g YTyA== X-Forwarded-Encrypted: i=1; AJvYcCUAfo3M0b2Vr84kRskB+gfIpbOYt9/H+bKjAm/DMzWaNwgHXNXN6aos8UaTL6WY2JLl9RB2yXjtYKYO23MMQv9H4B70BgLI5O+w6Z0x X-Gm-Message-State: AOJu0YzaYDMGDHPrv8juo5Mq4s7vCDid4ipCu1I3wHzb6tjsTkdXYu3I Pe54dHqIKlBl4nb7+TYuSC9kAjfOuECjcQqNyXaHfg8XlZPj9ARNsomkZeRYO1FwFmmvR7frcBF xXNWxAw== X-Google-Smtp-Source: AGHT+IFV8nFgbzCmqp5624khLyjgblB+C7PSMAG99rhpEHx97+eQXMZPvyVLcBZvUnoqdEaw5LZAWS/mgVDn X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:b4cb:a52b:f9ea:8678]) (user=irogers job=sendgmr) by 2002:a05:690c:fcf:b0:627:7563:95b1 with SMTP id 00721157ae682-6429c6dcf91mr317197b3.5.1719336392078; Tue, 25 Jun 2024 10:26:32 -0700 (PDT) Date: Tue, 25 Jun 2024 10:25:47 -0700 In-Reply-To: <20240625172603.900667-1-irogers@google.com> Message-Id: <20240625172603.900667-11-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240625172603.900667-1-irogers@google.com> X-Mailer: git-send-email 2.45.2.741.gdbec12cfda-goog Subject: [PATCH v1 10/26] perf c2c: Use perf_tool__init From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use perf_tool__init so that more uses of struct perf_tool can be const and not relying on perf_tool__fill_defaults. Signed-off-by: Ian Rogers --- tools/perf/builtin-c2c.c | 31 +++++++++++++------------------ 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c index 88c131d05186..cd2bd573bfc3 100644 --- a/tools/perf/builtin-c2c.c +++ b/tools/perf/builtin-c2c.c @@ -385,24 +385,6 @@ static int process_sample_event(const struct perf_tool= *tool __maybe_unused, goto out; } =20 -static struct perf_c2c c2c =3D { - .tool =3D { - .sample =3D process_sample_event, - .mmap =3D perf_event__process_mmap, - .mmap2 =3D perf_event__process_mmap2, - .comm =3D perf_event__process_comm, - .exit =3D perf_event__process_exit, - .fork =3D perf_event__process_fork, - .lost =3D perf_event__process_lost, - .attr =3D perf_event__process_attr, - .auxtrace_info =3D perf_event__process_auxtrace_info, - .auxtrace =3D perf_event__process_auxtrace, - .auxtrace_error =3D perf_event__process_auxtrace_error, - .ordered_events =3D true, - .ordering_requires_timestamps =3D true, - }, -}; - static const char * const c2c_usage[] =3D { "perf c2c {record|report}", NULL @@ -3070,6 +3052,19 @@ static int perf_c2c__report(int argc, const char **a= rgv) data.path =3D input_name; data.force =3D symbol_conf.force; =20 + perf_tool__init(&c2c.tool, /*ordered_events=3D*/true); + c2c.tool.sample =3D process_sample_event; + c2c.tool.mmap =3D perf_event__process_mmap; + c2c.tool.mmap2 =3D perf_event__process_mmap2; + c2c.tool.comm =3D perf_event__process_comm; + c2c.tool.exit =3D perf_event__process_exit; + c2c.tool.fork =3D perf_event__process_fork; + c2c.tool.lost =3D perf_event__process_lost; + c2c.tool.attr =3D perf_event__process_attr; + c2c.tool.auxtrace_info =3D perf_event__process_auxtrace_info; + c2c.tool.auxtrace =3D perf_event__process_auxtrace; + c2c.tool.auxtrace_error =3D perf_event__process_auxtrace_error; + c2c.tool.ordering_requires_timestamps =3D true; session =3D perf_session__new(&data, &c2c.tool); if (IS_ERR(session)) { err =3D PTR_ERR(session); --=20 2.45.2.741.gdbec12cfda-goog