From nobody Wed Dec 17 19:30:13 2025 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A33D416D9C1 for ; Tue, 25 Jun 2024 14:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719327036; cv=none; b=j0GpPo8qucinmEAENFQWAHXzmYiQX4IWQkEQqzS6xZF90KZjca2+8gJnCBUhEHkQ1lqqWCUYSrP9l4dZwgG16kyDHD9BO/iJv7gHlgPjGSHUNE/s1LEsGjzjT654seTKsNIGpGXxaCjKfUlyYKdN1h/W7/t4Iyc/KNb0i0c8/Y0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719327036; c=relaxed/simple; bh=9PRTUjhEWIG+xp1wbJ1El3maAsca2SWuQSv7OULoMfE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Hvhb/16wr5MwjkhOj/ezKHqnu6q0Pm4A2DSnb6cRkZ3JrRapcI8pkBZx6/u9qEq2DVKV7kHIBYJC+uWVkMySdGNl6xMvKaP8saCtVs/eO4FwknSXHQga/5LPkDgId/99oB4hAB9upWB0jcKpLJoXLfyX5OOjtSX/oy7LZCCehGU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=c3KWucx/; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="c3KWucx/" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a72585032f1so275536766b.3 for ; Tue, 25 Jun 2024 07:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1719327033; x=1719931833; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y8FO99+jOTZQ4oml/X5Fq9PsFL65v7oiJC3yeWK0G1A=; b=c3KWucx/P7sEvrufJmO80YqbnPYBs1MLkSKHl7QOLC62+9PhJu0ep8SYJDn6ogEzSE xH1Z0SW/YlC3dS/sP/opJX5JCRGDOH2YkBOhqcFlLl2k9eHde6LkXMZ2ZFkVKTHRIVrd 6i6Pb8RC9RQMfFMZH4J/06pjhCMfgWnnhoKX0uLKQRwcDiiUayH0Xam+p6aXWi2Uw8rF HWvvL5+z8UIGjsyPb6xu9NESeVCI6BUQuGwJNtmr2jJS0IlJoPPiz+efZsb1w5yyVN6c ATgl99I7rWbDjLjI/32kgxIc1zJSmi0ltYF+JeSpP1+/JhQ04wz4Sn3oSbGchiqGuE2P oe5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719327033; x=1719931833; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y8FO99+jOTZQ4oml/X5Fq9PsFL65v7oiJC3yeWK0G1A=; b=Xb46UHoeatT+G9bBnHD0jcpaKb0qmvvcuJOdHD7cJ/lcjh3vDaDNttdyp1XsRxB2z4 WR3+GhAP30aa66gVAT3T0/1LnJ9b/gHkO/uVuXyF4H62emlVMp7n9TaNRT0bM4UysK21 bQSTEpvQkIRhwxziXv0YPKL9W9mEnhUrfpgIqJjbWQwdpPv3TTL8ubxlflZpLVbJTsyf 2LLCs1JnAPMLjyEW8Samvmr9jYWc9tghdZavTik/mfcexnhQUBp7eB2/vwOY3PsMPobV c1wo0GShMd82lDRQV2aruiMEyn9a9RmKZ0ubI+RvamZGvl4qIh495X26gFgxnRfgzSnF bJ/A== X-Forwarded-Encrypted: i=1; AJvYcCXxVphZsAVQ6do2mQNqix+GEVyUMpLQLyp3JSwbIW/2ly0fv9ezB31Yt4aZgIHCHyR1Usq8VuPZJklZCbuetfGfNkCqnj3qD6ytpHRR X-Gm-Message-State: AOJu0YxZPycwmlidBp7oynJi3bwvxKDHnrcALwHYZXUg2cyxVDbqld6B HdjLo43E1nHOXHvW1GGUAlle7ZO2V0DmS6f764NOOG0lGvvQpx4WPVC+HKWr0m0= X-Google-Smtp-Source: AGHT+IHxhm8K+90t51Ou7UOGxTWXFK96sTe4GE9XHvjFI8vmoRSsxXRqZgmnKIRXFcaKJp4IiVaRvA== X-Received: by 2002:a17:907:a681:b0:a72:80b8:ba64 with SMTP id a640c23a62f3a-a7280b8bdf7mr21897566b.25.1719327033159; Tue, 25 Jun 2024 07:50:33 -0700 (PDT) Received: from toaster.lan ([2a01:e0a:3c5:5fb1:b30c:4c5e:f49e:ab33]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-a724162f037sm355945066b.194.2024.06.25.07.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jun 2024 07:50:32 -0700 (PDT) From: Jerome Brunet To: Neil Armstrong , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: Jerome Brunet , Kevin Hilman , linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , dri-devel@lists.freedesktop.org Subject: [PATCH 1/2] dt-bindings: display: meson-dw-hdmi: add missing power-domain Date: Tue, 25 Jun 2024 16:50:14 +0200 Message-ID: <20240625145017.1003346-2-jbrunet@baylibre.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240625145017.1003346-1-jbrunet@baylibre.com> References: <20240625145017.1003346-1-jbrunet@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Bot: notify Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" All Amlogic instances of the Synopsys HDMI controller need a power domain enabled. This is currently missing because the Amlogic HDMI driver directly pokes the power domain controller registers, which it should not do. Instead The HDMI controller should use the power controller. Fix the bindings accordingly. Signed-off-by: Jerome Brunet Acked-by: Conor Dooley --- .../devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdm= i.yaml b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.ya= ml index 0c85894648d8..84d68b8cfccc 100644 --- a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml +++ b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml @@ -71,6 +71,10 @@ properties: - const: iahb - const: venci =20 + power-domains: + maxItems: 1 + description: phandle to the associated power domain + resets: minItems: 3 =20 @@ -129,6 +133,7 @@ examples: reset-names =3D "hdmitx_apb", "hdmitx", "hdmitx_phy"; clocks =3D <&clk_isfr>, <&clk_iahb>, <&clk_venci>; clock-names =3D "isfr", "iahb", "venci"; + power-domains =3D <&pd_vpu>; #address-cells =3D <1>; #size-cells =3D <0>; =20 --=20 2.43.0 From nobody Wed Dec 17 19:30:13 2025 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08DCC16EC07 for ; Tue, 25 Jun 2024 14:50:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719327037; cv=none; b=U12PI0aizdmHjqasqKFe06uHfowC2F4AOF725QS1Ur1j1rNuQjUP4CrMGCPzfA9fOeJum9xKrqU8+UnxfSDuKycmentAlAW4mhKPlczIPlptT9Jy0bffmTmixACjfb8tJ9i1WE3fisOVL+NBfaxZni1YLOjyyjYZJRoFtGrvcjc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719327037; c=relaxed/simple; bh=oHXJo4PrLGPaAFmiAS/KTJpjakAA/N8r3HA5aYOSdz0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RMF5c+hJ9of6hqCYx5eGirnLR6wyFEqAkYhx3fziCUJN20//EPMtaS+aIhAKFfYL2ihlU4tRoTPdcQdGE5qaRYEqIfRkMrk57HzBznHVVcukVuxCAaiBHCodsFLHxUaRTR1zPn1oLye8x7cK9Q2SjsqsELAIGuPfgZ47OZRKmI4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=AdUkITCW; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="AdUkITCW" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a72510ebc3fso346820366b.2 for ; Tue, 25 Jun 2024 07:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1719327034; x=1719931834; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XNAdTcacMLHiwcp3rwtVy5TsM3diOedzVRX0xlC3b4s=; b=AdUkITCWy9fCHR8rBbQpq3oNfVuOjmgfjIAydsmPPHzO6vzM5lVuTbFR1Cn0jzAVZ2 wpWqHvPXpYZisHubY1+9StPHvBZNVU6GEe0PC3huigo3rgoI96Jd+/5K7ciCZY0qiYif ygLGGllzDQEaTh9qUQYRpUB/T/6JuDfbGb/12Hwotpx1bPneRH8CQJ5XIz0nRoIibnCH Z5yT7O2+PUihqWFdzyUOqyijITpfIwiTDA6v2jZoAurtNyEvuZPnazPWRvPHuEMgNpX1 A/apxQ5bKtioZvJcaNnGFWoxTUhU1zI2DPYSpYDUw0hZjR2QcTgK5iRG6b9Tz7jwu7Wr LAXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719327034; x=1719931834; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XNAdTcacMLHiwcp3rwtVy5TsM3diOedzVRX0xlC3b4s=; b=FySgVFsePcINx/rUpA8FTnWyE9UBItuYesdaYVjKAy1Kh7LlpB0t1MsdJ4Qy+bUMCQ w+EPlkgUP9anDXm9riEZRRsbxZzy1Tg4DiYQ9J732T+U+isjuGPLmMmVU/MRtvP9MMmM xK7ac4RSbwV8rifGDs11JJ/vC+BecQtLYQ1aQKsrMnWBqqJD1Q0qwOQ6INLnD3txdWCm iVGqU+6bvNVWoWLytlrW4DNMTu8aLD8EPrzeHGXGPB0HF7bAzXtaCTAziAu0ltt3p9Bd EvcITGFZ3t42buYOSKsljRxEWv8UmNiZ5LvH5nJea3jnIis4FuvAGulfnSBZt8HUqFk9 VCKA== X-Forwarded-Encrypted: i=1; AJvYcCU8ja74ijZEnWFc6w/mJ/UuiG7SUjGPIgjQMdpO9qUJfzJ9CP745+hgIyxndt4qgGPRHcxS+ot9TCEidLVvSR9t/EfzWMVei4L8JjhC X-Gm-Message-State: AOJu0YxFhL6DDzEJOGQUS1NYEwHoKZnEyCzbZtbFnoULv6Fu6czF2JcT XHohuEsuPWQE1yHgA4j7VBv+eYLTujeQyhAaV7RXWAEP5FDN3NB+cQZ968QCjVk= X-Google-Smtp-Source: AGHT+IEAx+7PNBsfh1PecChpyxyxGCwBCHXZraE/xlVLiq1yJ87mv2cTQeKVv1iemDFLo464qB8MVw== X-Received: by 2002:a17:907:a649:b0:a72:8135:2d4f with SMTP id a640c23a62f3a-a7281352e3cmr12762066b.48.1719327034140; Tue, 25 Jun 2024 07:50:34 -0700 (PDT) Received: from toaster.lan ([2a01:e0a:3c5:5fb1:b30c:4c5e:f49e:ab33]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-a724162f037sm355945066b.194.2024.06.25.07.50.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jun 2024 07:50:33 -0700 (PDT) From: Jerome Brunet To: Neil Armstrong , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: Jerome Brunet , Kevin Hilman , linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , dri-devel@lists.freedesktop.org Subject: [PATCH 2/2] arm64: dts: amlogic: add power domain to hdmitx Date: Tue, 25 Jun 2024 16:50:15 +0200 Message-ID: <20240625145017.1003346-3-jbrunet@baylibre.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240625145017.1003346-1-jbrunet@baylibre.com> References: <20240625145017.1003346-1-jbrunet@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Bot: notify Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" HDMI Tx needs HDMI Tx memory power domain turned on. This power domain is handled under the VPU power domain. The HDMI Tx currently works because it is enabling the PD by directly poking the power controller register. It is should not do that but properly use the power domain controller. Fix this by adding the power domain to HDMI Tx. Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-g12.dtsi | 4 ++++ arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 1 + arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 1 + arch/arm64/boot/dts/amlogic/meson-sm1.dtsi | 4 ++++ 4 files changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-g12.dtsi b/arch/arm64/boot/d= ts/amlogic/meson-g12.dtsi index e732df3f3114..664912d1beaa 100644 --- a/arch/arm64/boot/dts/amlogic/meson-g12.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-g12.dtsi @@ -363,6 +363,10 @@ ðmac { power-domains =3D <&pwrc PWRC_G12A_ETH_ID>; }; =20 +&hdmi_tx { + power-domains =3D <&pwrc PWRC_G12A_VPU_ID>; +}; + &vpu { power-domains =3D <&pwrc PWRC_G12A_VPU_ID>; }; diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/= dts/amlogic/meson-gxbb.dtsi index 12ef6e81c8bd..d8a386c31914 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi @@ -315,6 +315,7 @@ &hdmi_tx { <&clkc CLKID_CLK81>, <&clkc CLKID_GCLK_VENCI_INT0>; clock-names =3D "isfr", "iahb", "venci"; + power-domains =3D <&pwrc PWRC_GXBB_VPU_ID>; }; =20 &sysctrl { diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/d= ts/amlogic/meson-gxl.dtsi index 17bcfa4702e1..82386feb5177 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi @@ -327,6 +327,7 @@ &hdmi_tx { <&clkc CLKID_CLK81>, <&clkc CLKID_GCLK_VENCI_INT0>; clock-names =3D "isfr", "iahb", "venci"; + power-domains =3D <&pwrc PWRC_GXBB_VPU_ID>; }; =20 &sysctrl { diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi b/arch/arm64/boot/d= ts/amlogic/meson-sm1.dtsi index cd0046c0fe72..c76dcb0158a7 100644 --- a/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi @@ -514,6 +514,10 @@ &gpio_intc { "amlogic,meson-gpio-intc"; }; =20 +&hdmi_tx { + power-domains =3D <&pwrc PWRC_SM1_VPU_ID>; +}; + &pcie { power-domains =3D <&pwrc PWRC_SM1_PCIE_ID>; }; --=20 2.43.0