From nobody Sun Feb 8 17:23:16 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA7A61474B8; Tue, 25 Jun 2024 08:11:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719303106; cv=none; b=NFgl1XH3/fI/DAlQSo0oNzZPG43EUFCW8uh8daGznjOXMjcMUl9enDROvx8QEQWgStdiBipUxmU7J/WyHVA8Z45w7iS0/A036jyE44zIhQ7cfepKgXBR3p7LQulyR/lZ4oZUm0j+OJy/NyTN+EOiE8riPw+2p2NC2GdM4v9k6zM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719303106; c=relaxed/simple; bh=dQSS+cisNfaft2A5cQ4bXxLvcIiPOe9EipzRaGlA4QI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=IyNeJct1w9L9nCLnJxljWr5X0LQLVAupaZ/pq1BIXi7Im3EcEfxI6zAkXTg3aUehFBF9NDbLIeGQM3QudlSxz5ZGCpc7RjraDiCcSEKTG7UdphAjx13CAjWNtzWU23dKDvBWuMvTWtd1sZrXl3cqmqumhTbRtOp7H0/FQPZowDo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=bS59Ybso; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bS59Ybso" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719303104; x=1750839104; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dQSS+cisNfaft2A5cQ4bXxLvcIiPOe9EipzRaGlA4QI=; b=bS59YbsopAqkSP3afURYz1huHAjlEihAdTY9x4IRhhxZF9K7raG8qAO5 LmaX/kmMtkJx4iVv5r6ajn1PFsOaGnBJQ9Q5IUjApq2tqeNz5v5CW4w3m krBEz7v4EIyvdQ0LDIF/Qj9rWFXSoP3S/kiQPdMGZJQBHmaekk5Yx0YQ/ CJnZzzgHc3mJWHjP+xE+nh3PNbDDuUKgz8Z039gWh++poGPDnAJkLvuLM Aljmn542RqsUhOFmTl5A5qA6IkOcqyTLSkKFuO/UlojnV9LcRIfPAWb5m lbVF8RL2PuOHq5NkruhrPkMrj8n11Juu9oQSFSUNVvXjXq6IGCR6RjTS7 A==; X-CSE-ConnectionGUID: +qk7eB0UQZCSLIhn0QCGFA== X-CSE-MsgGUID: gKOhmVeKRUmnKUXio5MEKg== X-IronPort-AV: E=McAfee;i="6700,10204,11113"; a="12232501" X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="12232501" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2024 01:11:44 -0700 X-CSE-ConnectionGUID: QqpJtJ98RZuhswRACDjn4g== X-CSE-MsgGUID: YQsl12d6RimXHYcZVrSz8w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="47944896" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by fmviesa003.fm.intel.com with ESMTP; 25 Jun 2024 01:11:42 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , stable@vger.kernel.org, Jason Chen Subject: [PATCH v4 1/5] mei: vsc: Enhance IVSC chipset stability during warm reboot Date: Tue, 25 Jun 2024 16:10:43 +0800 Message-Id: <20240625081047.4178494-2-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240625081047.4178494-1-wentong.wu@intel.com> References: <20240625081047.4178494-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" During system shutdown, incorporate reset logic to ensure the IVSC chipset remains in a valid state. This adjustment guarantees that the IVSC chipset operates in a known state following a warm reboot. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Cc: stable@vger.kernel.org # for 6.8+ Signed-off-by: Wentong Wu Tested-by: Jason Chen Acked-by: Sakari Ailus --- drivers/misc/mei/vsc-tp.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index e6a98dba8a73..5f3195636e53 100644 --- a/drivers/misc/mei/vsc-tp.c +++ b/drivers/misc/mei/vsc-tp.c @@ -568,6 +568,19 @@ static void vsc_tp_remove(struct spi_device *spi) free_irq(spi->irq, tp); } =20 +static void vsc_tp_shutdown(struct spi_device *spi) +{ + struct vsc_tp *tp =3D spi_get_drvdata(spi); + + platform_device_unregister(tp->pdev); + + mutex_destroy(&tp->mutex); + + vsc_tp_reset(tp); + + free_irq(spi->irq, tp); +} + static const struct acpi_device_id vsc_tp_acpi_ids[] =3D { { "INTC1009" }, /* Raptor Lake */ { "INTC1058" }, /* Tiger Lake */ @@ -580,6 +593,7 @@ MODULE_DEVICE_TABLE(acpi, vsc_tp_acpi_ids); static struct spi_driver vsc_tp_driver =3D { .probe =3D vsc_tp_probe, .remove =3D vsc_tp_remove, + .shutdown =3D vsc_tp_shutdown, .driver =3D { .name =3D "vsc-tp", .acpi_match_table =3D vsc_tp_acpi_ids, --=20 2.34.1 From nobody Sun Feb 8 17:23:16 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 743571474CB; Tue, 25 Jun 2024 08:11:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719303109; cv=none; b=lhLitvoULQv7TTVoQvnL2gp5I80Q8OiGV4H5mqr+nOyMwGgIo0BOb+/rOaVrFKA8P4b9V0w9NSCmv1X3Qxl0NmyxCes0/1tZQhWZVgNecTvDYHPOwSDNB6l5J4moePN46l31Bk+9JrRcscHDUK1BAENCYeJc5/Q4iadEpnTeymw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719303109; c=relaxed/simple; bh=JM1sD9QP4RyHSPhRqlUabkVUXwe0DuYqN6xM1zvvobw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Y2eVCGwK4KfjG6sAodf2mSecji7yxOCRNYJT2ztWwM7LLpCNlrK+gC6jaVpxDaeB6+dmow8BMGEHdpek5EzLatMtybFQL3I83n/ngbZLpUlowiazJr9mVpfZY9ZXT4TDoZuE7w2l5mEvq2/3k6jiUf5/l0IQ3fuWVdYdIDYRDPU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Fygv4TRq; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Fygv4TRq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719303107; x=1750839107; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JM1sD9QP4RyHSPhRqlUabkVUXwe0DuYqN6xM1zvvobw=; b=Fygv4TRqqkeNsqamr9dAf10RUZbfvOd01dwOLlkYHNBenVImEDLAtTEv hqwR0v+spDzcvsyIY5UrRR7Om+fGbPuSSczoHK1jXYNJ+Cj2upf7AW5Wo hiAS09JhRH+5zcTxfRA2suY/16PCIKezalFYAlBUbIgKq648bkHZN0gxz idigVhAzLSGeqi253QUUG5Z+czSsOC3OkTOI7mkgLH2CRvCDiSDb07VSp 5nRAfGSxS++vdqduZRHchM7KyvWKE0BHSy0cUg452gpoD8VnEulWQjHbZ 2WIfkl7F+Lx3AWtMqP0Uy26mupmgDN5sdduLLFYl+PZZ67Ilt4MnTMM+j A==; X-CSE-ConnectionGUID: /xqCv4CwRmSlxhmZSUprGA== X-CSE-MsgGUID: e6WTGiEoT+yRpVdaZ6gT/A== X-IronPort-AV: E=McAfee;i="6700,10204,11113"; a="12232503" X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="12232503" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2024 01:11:46 -0700 X-CSE-ConnectionGUID: RorVC/L3SuazX8B16Nn0Lg== X-CSE-MsgGUID: NkKf/9eSTIySmTKvZdCV7w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="47944900" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by fmviesa003.fm.intel.com with ESMTP; 25 Jun 2024 01:11:45 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , stable@vger.kernel.org, Jason Chen Subject: [PATCH v4 2/5] mei: vsc: Prevent timeout error with added delay post-firmware download Date: Tue, 25 Jun 2024 16:10:44 +0800 Message-Id: <20240625081047.4178494-3-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240625081047.4178494-1-wentong.wu@intel.com> References: <20240625081047.4178494-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After completing the firmware download, the firmware requires some time to become functional. This change introduces additional sleep time before the first read operation to prevent a confusing timeout error in vsc_tp_xfer(). Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Cc: stable@vger.kernel.org # for 6.8+ Signed-off-by: Wentong Wu Tested-by: Jason Chen Acked-by: Sakari Ailus --- drivers/misc/mei/platform-vsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mei/platform-vsc.c b/drivers/misc/mei/platform-vs= c.c index 1ec65d87488a..d02f6e881139 100644 --- a/drivers/misc/mei/platform-vsc.c +++ b/drivers/misc/mei/platform-vsc.c @@ -28,8 +28,8 @@ =20 #define MEI_VSC_MAX_MSG_SIZE 512 =20 -#define MEI_VSC_POLL_DELAY_US (50 * USEC_PER_MSEC) -#define MEI_VSC_POLL_TIMEOUT_US (200 * USEC_PER_MSEC) +#define MEI_VSC_POLL_DELAY_US (100 * USEC_PER_MSEC) +#define MEI_VSC_POLL_TIMEOUT_US (400 * USEC_PER_MSEC) =20 #define mei_dev_to_vsc_hw(dev) ((struct mei_vsc_hw *)((dev)->hw)) =20 --=20 2.34.1 From nobody Sun Feb 8 17:23:16 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D0EF148FE1; Tue, 25 Jun 2024 08:11:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719303111; cv=none; b=PN1h0+/i4nrzd1bFRNtbXgZcwo2ubpmZOPz2hSflY2fMw7k7bjAM2ZZPzGTxF3556mIafF+KtgmptBPaBuUqiT9fppyGshUnlZ3QVLEu1DP7H4RugXP3th5zb/0ZyPeVhu7ySQ3kZHUoO0KZdfbEkeqtqt5h7FOQO7FRuxkPvUU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719303111; c=relaxed/simple; bh=NHZgNFEHSi/ZmfdWXySMy89KSP1gWbhSE59sEMp/cJ4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=AgskwlkaFyP+UX7WuJ2ixpBhnz/ugCdPm3igmf1OHvLgjL6sH+2wlgWV7j5ADMLLxBwzktF+/FVkN/fwh9g+jRXlkkbNMoIt1Q6hWpg2hy8gWaDXUdGu2wyqwRORHvCCmXaDJHtiHagwKAx66l2POrlalD/PtdoJ97GGu4TyiEU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=oB1UcvY+; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="oB1UcvY+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719303109; x=1750839109; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NHZgNFEHSi/ZmfdWXySMy89KSP1gWbhSE59sEMp/cJ4=; b=oB1UcvY+11EiuCeeh/53QFwzHSc/zoeZKh51hcseNUt1pUHC44wOZ+Fz cftzC/Vd7WKUoLIUuw5J3JKyWibuBfkWUhS4xXVi98fiY+wPFwsv4vZqx ykbSWHW4NgJyTIcRUFqzSedLGllyOC7Ty4drsnNorAPsgWOkA02Be6uqw BCdlfSD7fvAjBL6I+8YAkyj0PBSdKcqMSLs0JIsYbar9/qOmOasT/P+Y3 zyKlpeZaUD+cAudr3hY+qukaD3FQe5d46O3HXRnaC5cR5i6vfFUv1DS3R SsRB3bGiNwxzoqj5PDQ0RujgzNIELgjxrJhvwvcOnNmnjTZO0kbcqg4/h g==; X-CSE-ConnectionGUID: Hr2+/MTbQVOkDFRanSKPVw== X-CSE-MsgGUID: fdHfGqelRSmJCcG5jHKe8Q== X-IronPort-AV: E=McAfee;i="6700,10204,11113"; a="12232505" X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="12232505" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2024 01:11:49 -0700 X-CSE-ConnectionGUID: w+C+frjHR6i3jWHP7SVo1Q== X-CSE-MsgGUID: Vbik8qEmRpKWqEiedy7XLw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="47944905" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by fmviesa003.fm.intel.com with ESMTP; 25 Jun 2024 01:11:48 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , stable@vger.kernel.org, Jason Chen Subject: [PATCH v4 3/5] mei: vsc: Utilize the appropriate byte order swap function Date: Tue, 25 Jun 2024 16:10:45 +0800 Message-Id: <20240625081047.4178494-4-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240625081047.4178494-1-wentong.wu@intel.com> References: <20240625081047.4178494-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Switch from cpu_to_be32_array() to be32_to_cpu_array() for the received ROM data. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Cc: stable@vger.kernel.org # for 6.8+ Signed-off-by: Wentong Wu Tested-by: Jason Chen Acked-by: Sakari Ailus --- drivers/misc/mei/vsc-tp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index 5f3195636e53..876330474444 100644 --- a/drivers/misc/mei/vsc-tp.c +++ b/drivers/misc/mei/vsc-tp.c @@ -336,7 +336,7 @@ int vsc_tp_rom_xfer(struct vsc_tp *tp, const void *obuf= , void *ibuf, size_t len) return ret; =20 if (ibuf) - cpu_to_be32_array(ibuf, tp->rx_buf, words); + be32_to_cpu_array(ibuf, tp->rx_buf, words); =20 return ret; } --=20 2.34.1 From nobody Sun Feb 8 17:23:16 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2012E1494A0 for ; Tue, 25 Jun 2024 08:11:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719303113; cv=none; b=guhfyZ4W37i5WImK8lrQ7tietHKfEjRrypiqyCWK98BUegjy56fvHUKSc/YAp3ScNGt8EpVsxesj9vKB6YHNHT0PpNwuY7wRjrl6HoUzVBL6hY+/5a5ff8xYbFWDgzBjG2x0KGDBA215xNz2mGwUb8LOUr2PxNf+Hp+N8o32V4A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719303113; c=relaxed/simple; bh=daxe32aE67oVuOh6zKBhL8mvnX6zPKZ6M93+wHKfLcQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Nkm6/x0DNskKf5rPXh2IHQjFFOrlSUdOrX18zQPfpsb4PIGOGFTSjLcs82sF5u52JPVYyrLYqQVHsYT8hOgVHMcP4OmkB3+6P52JJGwTShrCwIuWGJiyJnEfX3i1pK9CugOOpT6lEMW1RWvYFLBC81N3qZBQRmy96+jhiKKX30w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=PAxBKiq9; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PAxBKiq9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719303112; x=1750839112; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=daxe32aE67oVuOh6zKBhL8mvnX6zPKZ6M93+wHKfLcQ=; b=PAxBKiq9/Q24XS3VPf5yQXpuDHY4btnPQi3XWgPq1hjkkkYkyIfdTE4M cB3gRKgkKdpHLu/Y467yus9lU1TPVOx11DRHhqeswBY4zhM1tUTKyAMk+ /y644PxJ5X6JtiYyJ0akGxUgUZh7YPaW087gcVamHI260Ayn5JKEjop6w 2If9sqSHMYucrVF0vOhx/AytyGTsX0Y4/60FBOpVvVIuP7bPwvVt3S1zl e+55FWKx9eqob/ApEylL/aHbAi5lvFY8buXUTl+9daw2gOEEVo//RoSeU ficLN2ZveLg0Kue9GgeZ48PqvfACxvyNuiQitjPQX7L1qlAT2xsdbdmlB w==; X-CSE-ConnectionGUID: ulrsd1I2SjSgPYhjoajghw== X-CSE-MsgGUID: mPCH/r8lTJuA1bihhyWnWA== X-IronPort-AV: E=McAfee;i="6700,10204,11113"; a="12232507" X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="12232507" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2024 01:11:52 -0700 X-CSE-ConnectionGUID: YCPGnEtVQciQVTViGhkBrA== X-CSE-MsgGUID: Q5yqqKxgQvW1EYN2+D/UnQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="47944910" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by fmviesa003.fm.intel.com with ESMTP; 25 Jun 2024 01:11:50 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , Jason Chen Subject: [PATCH v4 4/5] mei: vsc: Enhance SPI transfer of IVSC ROM Date: Tue, 25 Jun 2024 16:10:46 +0800 Message-Id: <20240625081047.4178494-5-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240625081047.4178494-1-wentong.wu@intel.com> References: <20240625081047.4178494-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Before downloading firmware, a command response is required to identify the silicon. However, when downloading IVSC firmware, reading data from the SPI transfers with the IVSC ROM is not necessary. Therefore, the rx buffer of SPI transfer command is determined based on the specific request of the caller. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Signed-off-by: Wentong Wu Tested-by: Jason Chen Acked-by: Sakari Ailus Acked-by: Tomas Winker =20 --- drivers/misc/mei/vsc-tp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index 876330474444..1618cca9a731 100644 --- a/drivers/misc/mei/vsc-tp.c +++ b/drivers/misc/mei/vsc-tp.c @@ -331,7 +331,7 @@ int vsc_tp_rom_xfer(struct vsc_tp *tp, const void *obuf= , void *ibuf, size_t len) return ret; } =20 - ret =3D vsc_tp_dev_xfer(tp, tp->tx_buf, tp->rx_buf, len); + ret =3D vsc_tp_dev_xfer(tp, tp->tx_buf, ibuf ? tp->rx_buf : NULL, len); if (ret) return ret; =20 --=20 2.34.1 From nobody Sun Feb 8 17:23:16 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7723B1494D7 for ; Tue, 25 Jun 2024 08:11:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719303117; cv=none; b=mRkWZNn0ZmBdWSf43AVbd99tQSlwerTMQ68NelJJ4m+IyPwGdUE1H5/IbbI/frEVvh2Vuy1YpAZuR0SMTHD5u4r0qthm6LPalc6QcnrcbdOWPTJjCxy7ItTGQgIAYMQf7HJh5oWu2LRI8hU7uN+fRno1n+k3WKPgxQuwriif2WM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719303117; c=relaxed/simple; bh=X3L9S0Yszj7A4apws7xumH3DwOyFy+hhYSlKzXL6xOY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JZZbuCnZEAHI7i2eSnMpkARzp9kgHgBcWS4pXIbZLztAUta3IA92lkkbahjr2s5XRZIjzvYxHu8rQmNyiLDkavtCM1MAV/Ldw9KHDXQyA0A6nLf+CXJbfMhamYCeddZVbHbAPB6Ct8oC1pSUuWnAA2vtv480EH+76MRO8wb1Dhw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=epieZs/U; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="epieZs/U" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719303115; x=1750839115; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=X3L9S0Yszj7A4apws7xumH3DwOyFy+hhYSlKzXL6xOY=; b=epieZs/Udx9CU11xwgAKvb0BEDSVeKP7cGD7WcH2EDX84WOAIwt4juaD EnXy7voL+rDEHmqClOph77nNpSGbti0NWX2DEPH8WdX/mcEDNlHZpwMwA FVjHnOXNbOiMJWO/AZxJed4lwUBmSHv6MQuWSSd4ufWf3+5yTVsIMKI9n lE98xokBLaS1Urvpq11phU9vohH4oI4glQ7/z6qZ+Q2V2ffUkug0MX6nC gb7/1uL+JgPUXpcYLL25rAV7yRKDOF8g5oedRUN/SPRBqN2zDe00bRllk FN0333cuztlOu+LPH9ePfboQcdIq2hMnidlZ1Lgxxjr7yxlr4jT2PGTfS g==; X-CSE-ConnectionGUID: tiB7NadsQdWFqEnucKX24Q== X-CSE-MsgGUID: rli2tTveTa+/VnySMnHCpA== X-IronPort-AV: E=McAfee;i="6700,10204,11113"; a="12232509" X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="12232509" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2024 01:11:55 -0700 X-CSE-ConnectionGUID: 1DKED9BmR+KR3yPn0Z7bjA== X-CSE-MsgGUID: S0DTKqTNT9egis4O696iBg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="47944916" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by fmviesa003.fm.intel.com with ESMTP; 25 Jun 2024 01:11:54 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , Jason Chen Subject: [PATCH v4 5/5] mei: vsc: Fix spelling error Date: Tue, 25 Jun 2024 16:10:47 +0800 Message-Id: <20240625081047.4178494-6-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240625081047.4178494-1-wentong.wu@intel.com> References: <20240625081047.4178494-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix a spelling error in a comment. Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/misc/mei/vsc-fw-loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/vsc-fw-loader.c b/drivers/misc/mei/vsc-fw-loa= der.c index 596a9d695dfc..084d0205f97d 100644 --- a/drivers/misc/mei/vsc-fw-loader.c +++ b/drivers/misc/mei/vsc-fw-loader.c @@ -204,7 +204,7 @@ struct vsc_img_frag { =20 /** * struct vsc_fw_loader - represent vsc firmware loader - * @dev: device used to request fimware + * @dev: device used to request firmware * @tp: transport layer used with the firmware loader * @csi: CSI image * @ace: ACE image --=20 2.34.1