From nobody Wed Dec 17 16:01:11 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FE4513D8A4; Mon, 24 Jun 2024 13:29:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719235783; cv=none; b=JZT4RoZN3424uZkv/fN+zys5pT6I9CPQZAALvhx7MflpN7WPKqBparVevLtzGilqGBPj3v4bawhJ2yXcKkPzTkQuMKc/sj6qUG+Uzr3UXT/qOfRtBm0jTAOX0Kk1CbnE3mIvTP6fMNcF060+Bzw8h//8vFmwYooSDcfRZCEcEpA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719235783; c=relaxed/simple; bh=dQSS+cisNfaft2A5cQ4bXxLvcIiPOe9EipzRaGlA4QI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=OK1Unn9g9+2SEK+EpOJ4Jph5YpMuuk/LI4DV3J60AcECcNGu0k7fzoN44lWN2bHK+Ir5cmgoDZFRWoU/Lt54xW04HuRioWngmcCE66m4TPdozK72MCiM8dHCf1gsarX+HTZ2tT3pcho7+3S+ePPFpqa/U0k5Z4rjJ+0e/yBhXoY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=bFnUBlxH; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bFnUBlxH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719235782; x=1750771782; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dQSS+cisNfaft2A5cQ4bXxLvcIiPOe9EipzRaGlA4QI=; b=bFnUBlxHgy8aSi+FOxl9DCjldfh7x/oHhlZTpjfKJWurtveLgzw2/1PI d1cViWao8h7+5iGEvr5uEq+vU9nz6w02gybIlzGphCvK+67JRuSP+w/R6 DKGictQa+j3x3MMu9IZkK0ljZ0VdiARAMBBeLgix3KbUnlO1UTlfnv1Jj ZqdB/CeaLaaxJOxum0pE8RyJPuXtesO3GDEsmCBkHyIQADacHSKLMJqFa OFrXRzwruq3Hmh4AMMFXtBBzH/xPX/pyoT9GcRFtlljfKxgeL9fANu8rp uFYjmJ06AwfN/K3z3hthsep2jMjFKMaCA0UZjwFU/v5g+291g6WLPXVSU A==; X-CSE-ConnectionGUID: Tu0QBPLXRH+fIH7fKqNp3w== X-CSE-MsgGUID: vwg2eRgeQ2eCGd9SE5W5Kw== X-IronPort-AV: E=McAfee;i="6700,10204,11112"; a="26830737" X-IronPort-AV: E=Sophos;i="6.08,262,1712646000"; d="scan'208";a="26830737" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2024 06:29:41 -0700 X-CSE-ConnectionGUID: 9RPJwmkCQZy7zLJsmO+BpA== X-CSE-MsgGUID: mygQ8wcYT5+1+DphH/JbIQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,262,1712646000"; d="scan'208";a="47746673" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by fmviesa005.fm.intel.com with ESMTP; 24 Jun 2024 06:29:39 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , stable@vger.kernel.org, Jason Chen Subject: [PATCH v3 1/5] mei: vsc: Enhance IVSC chipset stability during warm reboot Date: Mon, 24 Jun 2024 21:28:45 +0800 Message-Id: <20240624132849.4174494-2-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624132849.4174494-1-wentong.wu@intel.com> References: <20240624132849.4174494-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" During system shutdown, incorporate reset logic to ensure the IVSC chipset remains in a valid state. This adjustment guarantees that the IVSC chipset operates in a known state following a warm reboot. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Cc: stable@vger.kernel.org # for 6.8+ Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/misc/mei/vsc-tp.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index e6a98dba8a73..5f3195636e53 100644 --- a/drivers/misc/mei/vsc-tp.c +++ b/drivers/misc/mei/vsc-tp.c @@ -568,6 +568,19 @@ static void vsc_tp_remove(struct spi_device *spi) free_irq(spi->irq, tp); } =20 +static void vsc_tp_shutdown(struct spi_device *spi) +{ + struct vsc_tp *tp =3D spi_get_drvdata(spi); + + platform_device_unregister(tp->pdev); + + mutex_destroy(&tp->mutex); + + vsc_tp_reset(tp); + + free_irq(spi->irq, tp); +} + static const struct acpi_device_id vsc_tp_acpi_ids[] =3D { { "INTC1009" }, /* Raptor Lake */ { "INTC1058" }, /* Tiger Lake */ @@ -580,6 +593,7 @@ MODULE_DEVICE_TABLE(acpi, vsc_tp_acpi_ids); static struct spi_driver vsc_tp_driver =3D { .probe =3D vsc_tp_probe, .remove =3D vsc_tp_remove, + .shutdown =3D vsc_tp_shutdown, .driver =3D { .name =3D "vsc-tp", .acpi_match_table =3D vsc_tp_acpi_ids, --=20 2.34.1 From nobody Wed Dec 17 16:01:11 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FEB513FD62; Mon, 24 Jun 2024 13:29:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719235787; cv=none; b=RMyMo6rqy0mAojeWEt5h/GoG28+kUweoVQFOt5X3ZDzh1u1FN7kZGN0y33708TN9qYUPz7FDUrrN464hVeQwvf7n4WF0yakqUdbE/1L+WHktpLXZkNUNjWrQ09ianPjP+zV7pwjSfWUdwZICrpzF6pJu5NrrGpbFy26gFQX6b6k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719235787; c=relaxed/simple; bh=xIsG2R3uWOMJIdmsjuS0JUaO8Tx4hQq+TFIWKfoNBiw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bg0Bq66lAvUCVp5NVvc45qdFYJ6PGN5r9QVmY1ROcGDibmlUQtJa5LQTlL4P8TOzAQzC7hVtPEtlNOLFrV94DpfuApq1Y/BusryCI9j58VF55w0ku0rniegu5ThE91MbGZROVbibwi3dE2mKNIYIl3kYcvjIMkx1A9GWQxAw7YA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=bRKgS57z; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bRKgS57z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719235786; x=1750771786; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xIsG2R3uWOMJIdmsjuS0JUaO8Tx4hQq+TFIWKfoNBiw=; b=bRKgS57z2lEKbX5WXoRZdE7yXhILHIP9tJKWoetvI/dk8aEF2sgcTykl 5PBSHm0twTrPINjhXSBuWMTcQKzKvi+dYkywCjyhSxwdHYDR+seDsdU11 LIzxZbWGjopUaZFnDAi8EL+wuX+nyWT8R0qSa72Wsh0xeUZHJj7woO4eP VVeJYnvORs2Ff4/EbKUIZwH7UaE8LkDHeR9FfeL+d4EEXrdTFCo0nfn2C IsYHRDFGFlJZ7sSRp//GDPPb9LPFxnB7VgB99CnNIQPH7jgmEfl3lFOV/ SutgIMMPXmNE+epKQQrzhOQDetXxrBOjqK7z3iF4Ix4xn/9L31xVEpi+6 Q==; X-CSE-ConnectionGUID: rY8cOEF4QU2WSidjsh3UAg== X-CSE-MsgGUID: QQU0rmo7T4mtzlks/C/t1g== X-IronPort-AV: E=McAfee;i="6700,10204,11112"; a="26830742" X-IronPort-AV: E=Sophos;i="6.08,262,1712646000"; d="scan'208";a="26830742" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2024 06:29:45 -0700 X-CSE-ConnectionGUID: eRi+SNWrTxe1e+BHUoIFIg== X-CSE-MsgGUID: gfnA5DfbSiiFy1QBfd2LcQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,262,1712646000"; d="scan'208";a="47746699" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by fmviesa005.fm.intel.com with ESMTP; 24 Jun 2024 06:29:42 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , stable@vger.kernel.org, Jason Chen Subject: [PATCH v3 2/5] mei: vsc: Enhance SPI transfer of IVSC rom Date: Mon, 24 Jun 2024 21:28:46 +0800 Message-Id: <20240624132849.4174494-3-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624132849.4174494-1-wentong.wu@intel.com> References: <20240624132849.4174494-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Constructing the SPI transfer command as per the specific request. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Cc: stable@vger.kernel.org # for 6.8+ Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/misc/mei/vsc-tp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index 5f3195636e53..26387e2f1dd7 100644 --- a/drivers/misc/mei/vsc-tp.c +++ b/drivers/misc/mei/vsc-tp.c @@ -331,7 +331,7 @@ int vsc_tp_rom_xfer(struct vsc_tp *tp, const void *obuf= , void *ibuf, size_t len) return ret; } =20 - ret =3D vsc_tp_dev_xfer(tp, tp->tx_buf, tp->rx_buf, len); + ret =3D vsc_tp_dev_xfer(tp, tp->tx_buf, ibuf ? tp->rx_buf : NULL, len); if (ret) return ret; =20 --=20 2.34.1 From nobody Wed Dec 17 16:01:11 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9599014038A; Mon, 24 Jun 2024 13:29:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719235790; cv=none; b=Rib89wMZyZ/FOTkFFTKiLfshdHOvH9IiOOoqQpsnUjQzLAIGENu5zoEigvQ46aGpW/le4LPc2X6UExasEbkXRxC7hR03cFU3dSrZTvQiB+C6wSEKwr457SRY9j19hWuFWczXFZoL6s/RRY67lzTbPuQ4VMJWIJu9i9owhcL/oLM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719235790; c=relaxed/simple; bh=UZbBhq5qQXvf1/MvNlBj2IT7czxIpQmTilPKU1BJNX8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=AsrclPhKgOY8JF3KNc6nvQLQlUbdFqQ4hJjM5716iYxKOObzCdZB8pExaKBhk3JvQYsWSHCA5/D6SFy24lHq6rGsCwlgIYMIFPWrjuyyMKmhdZZtne0q1CU2liRQgDB089nh8eAAL7P9N0Ul24JXlUBw5NW62bjuweAbvZPTZCw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=i1CNnFJA; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="i1CNnFJA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719235789; x=1750771789; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UZbBhq5qQXvf1/MvNlBj2IT7czxIpQmTilPKU1BJNX8=; b=i1CNnFJAo2AX6uXOoHvvFO6JVT8BcVOFqWr3BZJBUDpM3LgX3eS+WucD VfbbxuK096Dlb92dtkk+wvDmfHl571fZMcVmAev4knFOu4SxFez1XOjt3 UIEpqNJvWYj1PproWk21W31mI1wHKN4It0hIdCBntjBBPbqTEImyxX7je YjobRU+7MnN0HHIAON8EiMsZDQKXEMUf4ms4ohgpdBOQ2m69Prj/i3y48 L5oAzZ1ltQsaL39XoHe8ckVUGvDXkXB47oxx/+sSQCzDtiCDNUTw1sDP6 oEuTOOUxUSv3icZC6yHbjxvO/QP7BNkI02csQyxr/ITPHqyZWNWUoIH2w Q==; X-CSE-ConnectionGUID: 1oP1fLSNSYWEpzfFvRlRbg== X-CSE-MsgGUID: fzlC/WqmQfa2YlVCRDWArg== X-IronPort-AV: E=McAfee;i="6700,10204,11112"; a="26830747" X-IronPort-AV: E=Sophos;i="6.08,262,1712646000"; d="scan'208";a="26830747" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2024 06:29:49 -0700 X-CSE-ConnectionGUID: 7JY7TR8nTD+D3QR4kmM8pg== X-CSE-MsgGUID: rQy/JB2/Tk2sBVEgCQfaAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,262,1712646000"; d="scan'208";a="47746718" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by fmviesa005.fm.intel.com with ESMTP; 24 Jun 2024 06:29:47 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , stable@vger.kernel.org, Jason Chen Subject: [PATCH v3 3/5] mei: vsc: Utilize the appropriate byte order swap function Date: Mon, 24 Jun 2024 21:28:47 +0800 Message-Id: <20240624132849.4174494-4-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624132849.4174494-1-wentong.wu@intel.com> References: <20240624132849.4174494-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Switch from cpu_to_be32_array() to be32_to_cpu_array() for the received rom data. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Cc: stable@vger.kernel.org # for 6.8+ Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/misc/mei/vsc-tp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index 26387e2f1dd7..1618cca9a731 100644 --- a/drivers/misc/mei/vsc-tp.c +++ b/drivers/misc/mei/vsc-tp.c @@ -336,7 +336,7 @@ int vsc_tp_rom_xfer(struct vsc_tp *tp, const void *obuf= , void *ibuf, size_t len) return ret; =20 if (ibuf) - cpu_to_be32_array(ibuf, tp->rx_buf, words); + be32_to_cpu_array(ibuf, tp->rx_buf, words); =20 return ret; } --=20 2.34.1 From nobody Wed Dec 17 16:01:11 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 820C81448D9; Mon, 24 Jun 2024 13:29:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719235795; cv=none; b=OwZ3/8VRxZ/oefJhvU3O/qMA5qZjzsFiP+G8q7nevZr+CXIfDTkHmHTkzGRY7dmFTcOx60r9Y66efAfMB2i9XkOohKGuZAxrHthXB0M7uA3HOrP0jNHzzuX+x2NWJ5WMvTFLX9wAMfaxRN/PxBgmG1iAT+GjipHWGTsnSJhqmAE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719235795; c=relaxed/simple; bh=JM1sD9QP4RyHSPhRqlUabkVUXwe0DuYqN6xM1zvvobw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=h7fhmh+Bg+c+lofj+zrJTwc55z+oDTKlKIzJ+pxHP/BOah+2Yj0+aXjOUxBKzxgb+uhYZ2o/DbBVBbYzJMBVKbVZwBH3avwsJ2mO/06lv5IizW4D33aUH7lyVvuafI4ZXq0Rv+Asn4prADmnNvwvsKYGD69+1KTBrfJuwyeJ68Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=eDoJCowY; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="eDoJCowY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719235794; x=1750771794; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JM1sD9QP4RyHSPhRqlUabkVUXwe0DuYqN6xM1zvvobw=; b=eDoJCowYyDhPVtxYhrwt6h0zt/u3fseu6y1oldX0P3mCCFmnsnSHeIz+ iHDiHUXU1WuBp9Hsf3qHIrmcDA1tNXNfPF2RGTr/c2Ys53ulyQyXZPl4d Fz3YRicHKNvn0WLo7tINKQUnA3bg0OG9zm9dybQ+lrbP9vclFdGlSKom3 0mdGkxLsNYNjM1mJgvL597VsbnjKOxZTgps52z+mNIGwGy6S8h8kfuOu3 0wKtbQRVJfJ3c2av+0jbvk2x86oBPp0gf1EqAxbjf69PIKqm8XuVkBRy2 9vQ8bTvq9T974/4fkp5dszEJpR52rIpydISb/DXEYFYoPjY6a85nPAeWs A==; X-CSE-ConnectionGUID: JaBHE5U1RcaED/hWOVPynw== X-CSE-MsgGUID: wEQl7WLCRteK4wIEEuZWWQ== X-IronPort-AV: E=McAfee;i="6700,10204,11112"; a="26830755" X-IronPort-AV: E=Sophos;i="6.08,262,1712646000"; d="scan'208";a="26830755" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2024 06:29:54 -0700 X-CSE-ConnectionGUID: K+q5CI5dTZaceQrjTvCvmA== X-CSE-MsgGUID: xXN1cEZkQIG+SfpCEqsjiQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,262,1712646000"; d="scan'208";a="47746743" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by fmviesa005.fm.intel.com with ESMTP; 24 Jun 2024 06:29:51 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , stable@vger.kernel.org, Jason Chen Subject: [PATCH v3 4/5] mei: vsc: Prevent timeout error with added delay post-firmware download Date: Mon, 24 Jun 2024 21:28:48 +0800 Message-Id: <20240624132849.4174494-5-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624132849.4174494-1-wentong.wu@intel.com> References: <20240624132849.4174494-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After completing the firmware download, the firmware requires some time to become functional. This change introduces additional sleep time before the first read operation to prevent a confusing timeout error in vsc_tp_xfer(). Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Cc: stable@vger.kernel.org # for 6.8+ Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/misc/mei/platform-vsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mei/platform-vsc.c b/drivers/misc/mei/platform-vs= c.c index 1ec65d87488a..d02f6e881139 100644 --- a/drivers/misc/mei/platform-vsc.c +++ b/drivers/misc/mei/platform-vsc.c @@ -28,8 +28,8 @@ =20 #define MEI_VSC_MAX_MSG_SIZE 512 =20 -#define MEI_VSC_POLL_DELAY_US (50 * USEC_PER_MSEC) -#define MEI_VSC_POLL_TIMEOUT_US (200 * USEC_PER_MSEC) +#define MEI_VSC_POLL_DELAY_US (100 * USEC_PER_MSEC) +#define MEI_VSC_POLL_TIMEOUT_US (400 * USEC_PER_MSEC) =20 #define mei_dev_to_vsc_hw(dev) ((struct mei_vsc_hw *)((dev)->hw)) =20 --=20 2.34.1 From nobody Wed Dec 17 16:01:11 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 244421448E6 for ; Mon, 24 Jun 2024 13:29:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719235798; cv=none; b=aPL4pU55YJWUbZw0L/drqe9Kdro2gXyeiM8hzqG3LMiNl4uW/D3/pK3Tk9XJOa9FxDrHaSwsc5m+qisjtPtwEQrwssOECJuA098XVP63he7+bVuBp/JWPeL5cDGZNe5k1QYUxhWI049AlQ+ohffbzjMG0WCIwhjJ0HHTj7Sx3+8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719235798; c=relaxed/simple; bh=3PGXukhXUhbCCLDkatC+1Lrz46ffQiiXYfae+u3zvRI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CZY1AyHY0L/B5gtcKxV+2zsuW9DGWL+t+144Zgti8kLoLAoT2gFu72GrTpDueoB7EcUr1HvMEemjb+wdPsn9+ETJZuqOmdpBRLQTnP8K20PbdWociMBy7QQWmQEJv+Yg7miQLyCztHXlelscpb/9KBt+mSZvUnq4oY7CJGg1kEU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Bqnin3LW; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Bqnin3LW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719235797; x=1750771797; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3PGXukhXUhbCCLDkatC+1Lrz46ffQiiXYfae+u3zvRI=; b=Bqnin3LWWqpcCuTEPnuBroiOg/QSTpc8MFbfpQMWjuiR3pd/l8WNWDD6 lPEKt1X6jOuEqVmCdLK0HziJzT0dyKn+1QCxdoD+upPbQACLrsxTNcGaY WduIvC5GtRka2D25QWDkGYOBf0dKan475kVrliVcZDS4dnUUUKTXmul+P +kf3FCHvZWfzBIHPLBuR3VA8Ftzt6SqKauxwAhnEOHfTcpj4VLzCTi2sw wTPd3AwCiA1DL3AO4Abr/6TqUTQvmotuEu9PxQuDXG4Ya0azJnCfZ2ggY Jul4iUvD0noGPxyZyGptSIUVD1Axtu1Vhm/H6HMtWIfLGqp0Fby6GqaAY A==; X-CSE-ConnectionGUID: waJx9Gf3S+CU2rkNQkzZGQ== X-CSE-MsgGUID: vqrLLYoSSceALRIVVtWsHA== X-IronPort-AV: E=McAfee;i="6700,10204,11112"; a="26830765" X-IronPort-AV: E=Sophos;i="6.08,262,1712646000"; d="scan'208";a="26830765" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2024 06:29:57 -0700 X-CSE-ConnectionGUID: oKe1HYZvT+S8MwYyY4xhEw== X-CSE-MsgGUID: MIiWP/QmQAavtxj3/rYqUA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,262,1712646000"; d="scan'208";a="47746775" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by fmviesa005.fm.intel.com with ESMTP; 24 Jun 2024 06:29:55 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , Jason Chen Subject: [PATCH v3 5/5] mei: vsc: Fix spelling error Date: Mon, 24 Jun 2024 21:28:49 +0800 Message-Id: <20240624132849.4174494-6-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624132849.4174494-1-wentong.wu@intel.com> References: <20240624132849.4174494-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix a spelling error in a comment. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/misc/mei/vsc-fw-loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/vsc-fw-loader.c b/drivers/misc/mei/vsc-fw-loa= der.c index 596a9d695dfc..084d0205f97d 100644 --- a/drivers/misc/mei/vsc-fw-loader.c +++ b/drivers/misc/mei/vsc-fw-loader.c @@ -204,7 +204,7 @@ struct vsc_img_frag { =20 /** * struct vsc_fw_loader - represent vsc firmware loader - * @dev: device used to request fimware + * @dev: device used to request firmware * @tp: transport layer used with the firmware loader * @csi: CSI image * @ace: ACE image --=20 2.34.1