From nobody Wed Dec 17 13:55:40 2025 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAB141CD39 for ; Fri, 28 Jun 2024 15:45:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719589536; cv=none; b=aAzrhwB8pm+SWJmoYv8oy6Yl4ar4OSEvic8cg6HjWag9BxxYZBPdpSMexUVo1Qo9VAftJ42w93mYXwaMVZN78Gcl5ty7e8AOkUNE6eJjP0+5/N9ExSaZE2GEedy1haVKmqfCKzziCmag2dY/Ck58CYYKd9a11xIf/JAMKs54pGs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719589536; c=relaxed/simple; bh=HsKpHTxO2qZZAKegni6aUmxcivarzWwp0eI+cMurg4U=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=dC1PxJAQjeewpvMyXFx6i+zQqVB/ZbcEUN5eOA7tHHWwG5jlHwmSdR7mhAHFbGHVfCiaTZ6eUHnyopIPjq/ZFm5n5NcSldf6RjABTwxwQcnCM1s2eKpcdI43AVOUPhjJqf5Kupx6oVjSmvh4sAGlcD1VPt/uPE+Id4tzHza1aOQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=JmVFwc0l; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="JmVFwc0l" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-64399573fd3so14196447b3.0 for ; Fri, 28 Jun 2024 08:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719589534; x=1720194334; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=yTiNPLIdhtP6pyhi64HYkOcFsA7q03RXOkGSgCbbU/c=; b=JmVFwc0l07xWdsqV80lL0lNYMJHJxOlpNEZKBpP4Sq4nY4FIn3RwzuNlo3LSYVYUdU bSMK/S+8jARnCjxHyOPw8GIKFZJlIpZntgFxspYUH266c5vs0C7UVauFl1xHl9UYZQQc 0b6hwdvilgS3d4WFtGsxUY4Hduhxi/utPZLSum5uo2Ev1YOXl1SAkhC4sRwoPgolo6UA WROgRecmWZ/eRaq7HbNDpuQMZSs+A1qXjyvacUVsfCelVwgPvcfLgkZrTJQJ9kQ00yUm mtvIwVE0GGpMLEDyPpHDK1cmz67lErYaVQAH6tEOfhErGRAgCoRNNlwSKZMWPOnYMFRT tOKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719589534; x=1720194334; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yTiNPLIdhtP6pyhi64HYkOcFsA7q03RXOkGSgCbbU/c=; b=LyetPmBEnowyQMebtbUtRc20gFDXjuX9U0016WMgNmeaL1g1z5i1hJBj2gdH+vWBsx QE5tJUTR3EJn6aiW7yfXAH9Knkz3x+emtKJSw2fJWZKB8wLOcwqpif7IUwH2GI5PUOWt 8vT6pIxfZ3Y4+PJVk37EOxp7UgGCFDKCy90XytTBNeu8gSC+Lp8eiIMORFSO5/EwUaeV 2wD4csoQXVl4XGstjulhETJPiammUkkVW2vYoHeKUyh0WvR/COYWxetU0742gFU6yShh x/vdS56tiSFB0KpVqy9xSS7lAx6azayo7S1G7WNdgxRFzIYK/+j5vweITOiZ7+0CApz5 hRdg== X-Forwarded-Encrypted: i=1; AJvYcCUo+qoxcBchNZUJRKc2ZODnBZuHdsAGzDJHB1qeuLjWqgJOgvXYJ4AcyrNqD1ylnDNShGYXtslqHlXIngDyOzI00U3R8SH+8Si4sX/V X-Gm-Message-State: AOJu0Ywc91yIoLZHbE1+y+VZkAa9gpWRTe8AtjvQgzF8mYmlOZR1ORkM Gwqc7zaGIgarhjbJ7X6O3BuTlE3dlao4WoBQb9/hOAgINGhBiwLyEgX3m4SbX/FcaVyeab/t4tE WOy3nWdlVek2c3fnwfOb898QR0A== X-Google-Smtp-Source: AGHT+IHW+w0N4Pm/D4C73M71WR7MUwhZIC3G5b/P9aMWl8aREiz5+MCB11v8g9AB/i/7uh4YYcl8gXlJzUZwxH8Dwyk= X-Received: from aniketm.c.googlers.com ([fda3:e722:ac3:cc00:4f:4b78:c0a8:3387]) (user=aniketmaurya job=sendgmr) by 2002:a05:6902:1109:b0:df7:8f43:f8a3 with SMTP id 3f1490d57ef6-e0303e603bfmr1005307276.0.1719589533819; Fri, 28 Jun 2024 08:45:33 -0700 (PDT) Date: Fri, 28 Jun 2024 15:45:26 +0000 In-Reply-To: <20240624052851.1030799-1-aniketmaurya@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240624052851.1030799-1-aniketmaurya@google.com> X-Mailer: git-send-email 2.45.2.803.g4e1b14247a-goog Message-ID: <20240628154526.324068-1-aniketmaurya@google.com> Subject: [PATCH v3 1/3] dt-bindings: i3c: dw: Add apb clock binding From: Aniket To: Alexandre Belloni , Jeremy Kerr , Joel Stanley , Billy Tsai , Rob Herring , Krzysztof Kozlowski Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Aniket Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add dt binding for optional apb clock. Core clock is mandatory. Signed-off-by: Aniket --- .../devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml = b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml index c0e805e531be..4fc13e3c0f75 100644 --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml @@ -20,7 +20,16 @@ properties: maxItems: 1 =20 clocks: - maxItems: 1 + minItems: 1 + items: + - description: Core clock + - description: APB clock + + clock-names: + minItems: 1 + items: + - const: core + - const: apb =20 interrupts: maxItems: 1 --=20 2.45.2.803.g4e1b14247a-goog From nobody Wed Dec 17 13:55:40 2025 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D78E18C38 for ; Mon, 24 Jun 2024 05:29:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719206954; cv=none; b=dPmszk66Toqv/JV0M9u8UoavTxOWEiwe6L8+/pvVINfIaaQrTPSzWWI2aBy1sin9ikmtPvAiY+RoCBx8Hp5vLL1Gxf9BtZIAnkeo5zhm5bGW2YssuWedFIFfGjCUcofdRCUpFMP7MOk5VHsqwhhgmccPZyri468B1JuVy4ZU3Bo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719206954; c=relaxed/simple; bh=CfPZiFmfp0Qs9eggBxskJJLc/pbaINcjbBZ7ulzGj0w=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=pb41t0X/Zc0djXePLs5dG6TkDcoj8Pv6YVcVZxbzwRYNcl8u7gIJ1QgDHXafM8HjA6QxtorIXh47kYSqTMtxqXFtORpeTPFEe2pxzXdIFtoAJifOLh9DI+mOZFzskg9nyf7pomdZ6+HiSKFgKONmJgraFM4rBw7SWp8AppdIH5I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=wKghoiXp; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="wKghoiXp" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dfdff0a9f26so7306156276.1 for ; Sun, 23 Jun 2024 22:29:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719206952; x=1719811752; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=xRFts49NKsibYysZG1mN4zOHSnI8JrcU21XVbqexR8c=; b=wKghoiXpi08EVp1V0jFehKzn5khACAp0ZlqZEoyhaLFuUKRSDcEo6BuJ0nUf4QwBUk atWdDw0ZVoFkaqu60HBarPcaN1AJ+AJmFRZp6K9pQ3ihzQLAnscjuMf5IlXulYZkiPTf SvMp1BgZWJ6AGCvnUovk5igM6s+HI413qF+FxTWAzrzxEZ8ZJvAGTCpZ+KG59X++QxEz EJZAU1soRSglgNFNh+fn0lK9ttEH7nzI+jf7WjLxdjQ7szU9U22XeTzF3PrmKwjNNIc1 JAQgdF05g9U/Hf0oKv6/gsQWb0Qqz8N7H19SLgSETQ9Q2NpvrSFQ+CTAi83/0WPwml3I xwKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719206952; x=1719811752; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xRFts49NKsibYysZG1mN4zOHSnI8JrcU21XVbqexR8c=; b=GQGflZaLDjFyM4xPDQK7X6jJZdGBm5Gyb/Bl5mAd4g5TANlJmMAO+WywNtNteIR/vf 9g5DHCdW9rcsMWSwB5lPKkxXs9/KPvfL0Ayu2YAnf7kkjpXB9U1+Sx6omwfHYLeg3Yrv FQDgXbwvJVkWrTqzjIypYBb+sUSB3c0KI9pL6uZ702z3wq7R04+QuPo7+iNxukhekOL8 hkoweUFg6uyJDA+zRWSrxJ5wmsR5cik0gun7cjDcwpfxh9PJSB9i/ahFaXFPHUK7YP+3 L3gyq30AhFir7P0D5cl3/Nl9piJHTsgXYukIA8YHHRfeobUQnA+j9oc5n8Fa6JFQz2rW agqw== X-Forwarded-Encrypted: i=1; AJvYcCXLdt1trHoZLoJJnkT4XcH4Xf1C2ZHeL7DFuv+/pM+xnez7UQC/CNNY8jctmDXm+KLhSiCV6EwHJ0O1PYiJPdqI/GfgmErmCz3aaU9/ X-Gm-Message-State: AOJu0YzR/p5asv07IcR7DklcFAbGYJec4r/rGh8ZUTCZABWGAYGvIdXE G6xgWCSxotzB7zVoJuSlMNrTeangTfpi5eYS9a+Mt2PIcgguys93nFgHj6HlsNm/ZDU3Ticxa3n yXdEIrZhGbhgb+fpr79qvmbIlxw== X-Google-Smtp-Source: AGHT+IEPFtuLDU7qM5B+Hh1VvGYKz7iFDuXzYucZ4EYIl/bThe8hJCvlk8EEUhg4hesztK7Po0cAT9oQQFYv0eq6Ez0= X-Received: from aniketm.c.googlers.com ([fda3:e722:ac3:cc00:4f:4b78:c0a8:3387]) (user=aniketmaurya job=sendgmr) by 2002:a05:6902:1006:b0:dfa:59bc:8858 with SMTP id 3f1490d57ef6-e0300f01d20mr12307276.1.1719206952193; Sun, 23 Jun 2024 22:29:12 -0700 (PDT) Date: Mon, 24 Jun 2024 05:28:49 +0000 In-Reply-To: <20240624052851.1030799-1-aniketmaurya@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240611171600.1105124-1-aniketmaurya@google.com> <20240624052851.1030799-1-aniketmaurya@google.com> X-Mailer: git-send-email 2.45.2.741.gdbec12cfda-goog Message-ID: <20240624052851.1030799-2-aniketmaurya@google.com> Subject: [PATCH v2 1/3] dt-bindings: i3c: dw: Add apb clock binding From: Aniket To: Alexandre Belloni , Jeremy Kerr , Joel Stanley , Billy Tsai , Rob Herring , Krzysztof Kozlowski Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Aniket Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add dt binding for optional apb clock. Core clock is mandatory. Signed-off-by: Aniket Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml = b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml index c0e805e531be..4fc13e3c0f75 100644 --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml @@ -20,7 +20,16 @@ properties: maxItems: 1 =20 clocks: - maxItems: 1 + minItems: 1 + items: + - description: Core clock + - description: APB clock + + clock-names: + minItems: 1 + items: + - const: core + - const: apb =20 interrupts: maxItems: 1 --=20 2.45.2.741.gdbec12cfda-goog From nobody Wed Dec 17 13:55:40 2025 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 873E0156984 for ; Fri, 28 Jun 2024 15:46:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719589572; cv=none; b=tvua4SDQSPEwlsLA+zHzyMy6p61atrGdvRZSYe60Gqz1Ga85hsyTQtTEsY5feps9Fyqc44M/uEe408bVVG0r1EaH5If/8w59gbr46F6qsTSLFurHSjFw6x/y7RNFAE7c9dA9yr/4F0QYz3w+n+poxNMvP9o0DHx+jhnq02wEnfk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719589572; c=relaxed/simple; bh=E2ON8afLO1WrZKvKgL0DbbmyDPjigcjuWNpKuF4J1pM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=nCwK3i4EItyYnRY95q5UfcF82VJDsRQP1UPcU0+zQJR8hy0FOKkX+JCwBOqTIRSXYk3qUP2A8MiXgAA/HkegjUdIhteol/SLuUnKL7vV5Q+NMftF+CMlDFWx9iK06M7UtJzR8PLoheF6dD6jsKEWIjZuhQu1/dAXShjZKMakR/w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=WuCk9LwN; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WuCk9LwN" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-7065df788f7so759984b3a.0 for ; Fri, 28 Jun 2024 08:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719589571; x=1720194371; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=BWwY890+5NLFwmpl4Ncpp5MeSVkTzmaxwxuDQSu9PBk=; b=WuCk9LwNr3A6N6b+VuaUw78Ve6qizDWxJzIQAw0ilQaT6m5jHiat4Br1uEnPAqP667 Oubsu5RucPUtv8V43QYnQrM2WHSGaib96DpoLYt7ZHzrAiQfp1fHW0Yc/YFQogCnqhLi 31FML6zlwT4r9J0nXL1ts1QKI25oqQBZlB7k6aQ21hcl+s8N2gLANDWNN8MqiMIlU7/l 18iKHXeRz8e59GrKtkBIt+yTQv7WtIpBV82+vLAFYyuvdHu4WHpX5l6s2zVsIGNlEvqU 6zGMYmZzo8ZxJAXyd4xTM1nwxcUE5EZd06VIS2f/9mnY9x27se9h8QbQr+OQ2flFTJV4 lTyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719589571; x=1720194371; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BWwY890+5NLFwmpl4Ncpp5MeSVkTzmaxwxuDQSu9PBk=; b=XwN4dtVW/ry76use6s0wwfv3jHzupnR+DGnHjgxfYJl1UYabmeEAXzbHGT9Cik2Cw4 OPy48x4VL0asYCiNz7zioyJFBRgpQKkMf79Cm+7s6gdJkGSx92pgJWZ7okHFYd91ENZ/ MhR90ERkpMHZ2Z7DPPHEm417jbDHdNJuDg/2kA3zroOUNeR93BZU2A8TjMdSeIyjorbo 748Ve+A52hOOp25Ke3wFZXnfzWQx76aVnZP8SaR6ro32gII7AICTutP9rLAgsGvKsvvk X9PJ0j97sJoJVAGkrSfta7XO60Y33HUAEX4v45xjnlc63/eDqL0jlv3k0epk1Bk8lwPT VeHg== X-Forwarded-Encrypted: i=1; AJvYcCWYKTHvuBcmRpUk+QB6jUR/Wrmk60B+mlGcuJPecHOcZjnYElljnJDrWV1Cf0JuBizMQNhB76IruswOy2wesxcdPsoyuRqNkISyZTsE X-Gm-Message-State: AOJu0Yxu+3UZ+BJTp9sb78lu2FGaUXEhIuVrmaT7aP63x410w9TqoVq5 7RJZSxK2yMPjvYCE25wch03FZRMWMCdiR+8FCaujqgcGyQ9mNzNL9HHE6x1TmutAp3Tj+uqyjVk cHqcJosvljO9i8vLhIYXO2y4YUg== X-Google-Smtp-Source: AGHT+IG32gMnXvaf3njbjouiPVyRu1hT0usmDZOv2jZJ7sVHWHnnRif/Y+Bn+1rnVmXX5zr8ZtJ4EL4tM4RTBaskLis= X-Received: from aniketm.c.googlers.com ([fda3:e722:ac3:cc00:4f:4b78:c0a8:3387]) (user=aniketmaurya job=sendgmr) by 2002:a05:6a00:23c7:b0:6ec:f400:95a7 with SMTP id d2e1a72fcca58-708536c380bmr89585b3a.3.1719589570648; Fri, 28 Jun 2024 08:46:10 -0700 (PDT) Date: Fri, 28 Jun 2024 15:46:03 +0000 In-Reply-To: <20240624052851.1030799-1-aniketmaurya@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240624052851.1030799-1-aniketmaurya@google.com> X-Mailer: git-send-email 2.45.2.803.g4e1b14247a-goog Message-ID: <20240628154603.326075-1-aniketmaurya@google.com> Subject: [PATCH v3 2/3] i3c: dw: Use new *_enabled clk API From: Aniket To: Alexandre Belloni , Jeremy Kerr , Joel Stanley , Billy Tsai , Rob Herring , Krzysztof Kozlowski Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Aniket Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move to "enabled" variant of clk_get API. It takes care of enable and disable calls during the probe and remove. Signed-off-by: Aniket --- drivers/i3c/master/dw-i3c-master.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c= -master.c index 9aae5c8dba8d..4e3335641dcd 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -1450,7 +1450,7 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, if (IS_ERR(master->regs)) return PTR_ERR(master->regs); =20 - master->core_clk =3D devm_clk_get(&pdev->dev, NULL); + master->core_clk =3D devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(master->core_clk)) return PTR_ERR(master->core_clk); =20 @@ -1459,10 +1459,6 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, if (IS_ERR(master->core_rst)) return PTR_ERR(master->core_rst); =20 - ret =3D clk_prepare_enable(master->core_clk); - if (ret) - goto err_disable_core_clk; - reset_control_deassert(master->core_rst); =20 spin_lock_init(&master->xferqueue.lock); @@ -1501,9 +1497,6 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, err_assert_rst: reset_control_assert(master->core_rst); =20 -err_disable_core_clk: - clk_disable_unprepare(master->core_clk); - return ret; } EXPORT_SYMBOL_GPL(dw_i3c_common_probe); @@ -1513,8 +1506,6 @@ void dw_i3c_common_remove(struct dw_i3c_master *maste= r) i3c_master_unregister(&master->base); =20 reset_control_assert(master->core_rst); - - clk_disable_unprepare(master->core_clk); } EXPORT_SYMBOL_GPL(dw_i3c_common_remove); =20 --=20 2.45.2.803.g4e1b14247a-goog From nobody Wed Dec 17 13:55:40 2025 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2469F1BC3C for ; Mon, 24 Jun 2024 05:29:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719206959; cv=none; b=eMTaUTQ44k8b41UgtZQoF1rWjkhEVhApndmUR0dcAbn4Ga1j3pXRLoXYM86+3FWhkAU9r9p6aarI5aQrOmu9l3eDK7KqF/6YrxMsl8FoBA0ze9lgmg5XDRIF9nnguHCSewVbwv89JbTPI7Dw1alCP2IsUVWS1nKcp+ypC3BV+Ws= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719206959; c=relaxed/simple; bh=8InZIp7y2zwsO4oF6fUGa/AKQ9soRf44nwDuYbc/fZQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=DhV0c9UnTy9dCjxyV+cumv9b5/psArKTcJ1BZGp6WrcNZ+fVr0KtCuIw/SbqXc5wBe0t5eA+Bn+yKmlgCAD25zwGSUGNNkeavz8uIYBEKI/yBFAgFnpcCqciQeR1s9dHi8gIuMSmk2KfDE64iFyA+qAXYMa8Jc8hKPZME6GEtqA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=PQ3P2j6F; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PQ3P2j6F" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e02b5792baaso8158029276.2 for ; Sun, 23 Jun 2024 22:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719206957; x=1719811757; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=z1lDGMLBKOZjPQERPgHQ2A9MuACw0+8pMDHkdqTSITw=; b=PQ3P2j6FIp0z8UcrJEeANyB+43hqZROi1TVjPCGiCDykbWkrECMQZa/XNyQQVGZ44j LFd25UKETZLW8rUilZDBhizUUOMer+WB06a+OAeEG+qWamwbTuQSEdY4gKCKpxE+zvCX DBeWtWYGrsjNjx3hPTw9G7W8zzqFPG6s/GYkD+dx48qJVj9HF2lXXtvhhgLR5mlhbQHF TVosdzXF8TVlUUObLVO7EAWlDJfeT60n6GsGLRFzb2o6B+PtEsWVHTIonQnOOTaKVxWM 1Hb5la7muxAemVE9Ac9vy4QcGTqftkV8JhTgTqD71Y0v3tLXRa/bjadhM+MAW2UZth8q iUCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719206957; x=1719811757; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z1lDGMLBKOZjPQERPgHQ2A9MuACw0+8pMDHkdqTSITw=; b=BFxukh+ctEXFfOk7IAAj+/RsxtHll5BIwu2RhnteS/gcTq4Bhlbt/SPMbIVGqznpN4 E1tdk3fHLA4NNFHDNQDR9/3vAZWntboX+P1R1tfljqEzlDzWFW4Byoj+UeveZ0ABKptB GYZzWJbAcux5NrrsZiIgcC3IK8M4jzab3BehRp59/syz0OTpUXsQ/XyZT3mr5CmfAU8T EJDh1lx+WZVZ/BDYADMpHvWsUaK3JNU8RfTLsoypvdt7umP1ApgrDquy3PEL9gu7zkRk o2bEnMTfrPqkseebrB1MUwR/wot6bLMVTGckGeny+kfQmjI8/IEA/qn3Xo9FPOoOGIIo 7V3Q== X-Forwarded-Encrypted: i=1; AJvYcCXPoT760Qfe+W+YVas1nvljp8M04raDpPSAh20v8E+GO5l1hl1DUQe8cSX/RV7skgSpfnNwf3WT5JfJAuHRvtkUOpTE4ohNATYk/ngD X-Gm-Message-State: AOJu0YxH1ttaUBcKCHmHOt0Lz0jCm2We537XNhaglY5Ky37uDG5dkq6A EwNeA/vEbgt0aR+jcLZiQ4g5/3uH1LEgUzBQ62h5prkOX+aIVEvx2lWrzCVIKj44zydb10Ahu5g jLsKGiGG/C0+7G3btNmUw/gMYuw== X-Google-Smtp-Source: AGHT+IFg4S5f43LgnXGlfi54t9Ut10DZcSLiBehSOlBVrIz63/P6FEWtc9+rMh5c0FMT9ZFPAyecpjuZbGRYntXsAoc= X-Received: from aniketm.c.googlers.com ([fda3:e722:ac3:cc00:4f:4b78:c0a8:3387]) (user=aniketmaurya job=sendgmr) by 2002:a25:c747:0:b0:e02:6dcf:e9b2 with SMTP id 3f1490d57ef6-e0303d64058mr25487276.0.1719206957343; Sun, 23 Jun 2024 22:29:17 -0700 (PDT) Date: Mon, 24 Jun 2024 05:28:50 +0000 In-Reply-To: <20240624052851.1030799-1-aniketmaurya@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240611171600.1105124-1-aniketmaurya@google.com> <20240624052851.1030799-1-aniketmaurya@google.com> X-Mailer: git-send-email 2.45.2.741.gdbec12cfda-goog Message-ID: <20240624052851.1030799-3-aniketmaurya@google.com> Subject: [PATCH v2 2/3] i3c: dw: Add optional apb clock From: Aniket To: Alexandre Belloni , Jeremy Kerr , Joel Stanley , Billy Tsai , Rob Herring , Krzysztof Kozlowski Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Aniket Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Besides the core clock, IP also has an apb interface clock. Add an optional hook for the same and appropriately enable/disable. Signed-off-by: Aniket --- drivers/i3c/master/dw-i3c-master.c | 12 ++++++++++++ drivers/i3c/master/dw-i3c-master.h | 1 + 2 files changed, 13 insertions(+) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c= -master.c index 77a2a1c3fd1d..41cdfd6741e3 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -1470,12 +1470,20 @@ int dw_i3c_common_probe(struct dw_i3c_master *maste= r, if (IS_ERR(master->core_clk)) return PTR_ERR(master->core_clk); =20 + master->pclk =3D devm_clk_get_optional(&pdev->dev, "pclk"); + if (IS_ERR(master->pclk)) + return PTR_ERR(master->pclk); + master->core_rst =3D devm_reset_control_get_optional_exclusive(&pdev->dev, "core_rst"); if (IS_ERR(master->core_rst)) return PTR_ERR(master->core_rst); =20 ret =3D clk_prepare_enable(master->core_clk); + if (ret) + return ret; + + ret =3D clk_prepare_enable(master->pclk); if (ret) goto err_disable_core_clk; =20 @@ -1520,6 +1528,8 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, err_assert_rst: reset_control_assert(master->core_rst); =20 + clk_disable_unprepare(master->pclk); + err_disable_core_clk: clk_disable_unprepare(master->core_clk); =20 @@ -1533,6 +1543,8 @@ void dw_i3c_common_remove(struct dw_i3c_master *maste= r) =20 reset_control_assert(master->core_rst); =20 + clk_disable_unprepare(master->pclk); + clk_disable_unprepare(master->core_clk); } EXPORT_SYMBOL_GPL(dw_i3c_common_remove); diff --git a/drivers/i3c/master/dw-i3c-master.h b/drivers/i3c/master/dw-i3c= -master.h index 8cb617b8147e..50c38e790c0e 100644 --- a/drivers/i3c/master/dw-i3c-master.h +++ b/drivers/i3c/master/dw-i3c-master.h @@ -36,6 +36,7 @@ struct dw_i3c_master { void __iomem *regs; struct reset_control *core_rst; struct clk *core_clk; + struct clk *pclk; char version[5]; char type[5]; bool ibi_capable; --=20 2.45.2.741.gdbec12cfda-goog From nobody Wed Dec 17 13:55:40 2025 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C338A1DFFB for ; Fri, 28 Jun 2024 15:46:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719589587; cv=none; b=SynD33pHgbGn6369r7bSiPEYcDZwx6ckKS0iumHNaLQOJYJO5Zfnph4yuEWp+HU0ItwSyldLazD2P7CqtdHAYNUatJUACFRS4Co00inON04/AR1XTEMdrNnpLWTC2hYPDrAa3a++kUlqpzXHoE6NRnP3Tp83wZiS9ZTXG1bAVXE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719589587; c=relaxed/simple; bh=pDyR6wbamVTNJYnWEAl1qjW26pSZoAd5OKTK9phK6wg=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=UCJYgd7arEWAEfk7YFC5hae+RDof65cwTC548BUOCq1i1A5wxp8inkeAUFn5vATrXW1qU031BFuot7YvxF5+UHPbZ+bnUyxvxDdSiMJgN2ZWFUQtsEmqS6x1TnpIkD8IkzJtOIhZ1Bw4JPSvbUitx27LdFb37KGPHCHi2wAl3aA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=VrvGGOSJ; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VrvGGOSJ" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e032d4cf26aso1453058276.3 for ; Fri, 28 Jun 2024 08:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719589585; x=1720194385; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=uik8gGS0BJXXt/zzhXfY9dwtNNpwmc4SjckR9/xyOjE=; b=VrvGGOSJW4D42H0vzojuWDTXK6LGKoXTb9gVXB6azibIjBqAnnVTUKpBGNQydBMV7Y Y6V8XSloqgcCc3M/mx7eafAdgrZVgu2XRr2HPLIohMig+z+wZhEhMrkrmA8WVrHQXOxi vY9WWPzigH9qVOm/hVzLo2SpaGw4OFBwNaxkIC+eq+O9/XhXruI/zGGSnUikdKFaTPLg O0AK/2QrykopzKGLAR5nNb/+sMiTtBHRiDv2h3Ag4qIQTo91V/+UL9UbULxcsmkps2pS HSpDwBDBYmdQMijRBrS6Z4EB3AB8RSUPeuaKBkqtNbYvBqc/SsbnTRlBq5YRqmG61mfD sJ9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719589585; x=1720194385; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uik8gGS0BJXXt/zzhXfY9dwtNNpwmc4SjckR9/xyOjE=; b=OvcryO+CsDihRw1FQ9GXKitYpyTqreTo+LDOoYoK58GaD8adCXJXiB+Hi/E9a3jVmV qe2lif1lLd6+fSozPbVMsL7nGcyBHk3UpDkgdH9XASNQnYxL5dqn2QDWgzNZ4CVsP3f5 Go6qAPLi2uKlUCH1LCqFYlO+XNMa+xcoC2Hgd0RcCP1/JDL2LpwEmvjwN9hqV+TDyOHF OC76xcf2GCN9uhWFlCuNEcR96sdcb1MTOtGkGw/6oTBuzJtVyq6Rxli3p67EVCp6S9sj ZNz8ydu85erMGezyZHQSrV07X1xkR/Ic4wlTeKJNcRyrRwjmAkb1U82ZBs9Fzg6n4G1c flPw== X-Forwarded-Encrypted: i=1; AJvYcCWLx3VeygzmL74IiA0TRhA9aKkmGelbV/ExXadGrwZn3pEnTfgV4PXp+HgD3Mj/NdCUpcz1SUnD7QJllG6xQO6AR1Mjo9FoVuxMTrSN X-Gm-Message-State: AOJu0YyhiODB0qEPu6ON5rBclV0pbIWkC1cCT19I6KjfznYR9xwX1HuG lTxWkkJU3RLsILjXvHRAyBGCzYxxTuqzrZZ/kc1Mu7wvIHmaA6fsQssyXOxCD04F9vToCXe3xUd VPmztgLB8xkFDIU4mq3NCWht1GA== X-Google-Smtp-Source: AGHT+IGfB7ik9VdtwsAzQwB6NZPw5Sc6rxP7YfqsyxrxwdZNm7diILFTFbMiLS0YpTc/XkKLrMFZg6xM7Cn3odq5SM0= X-Received: from aniketm.c.googlers.com ([fda3:e722:ac3:cc00:4f:4b78:c0a8:3387]) (user=aniketmaurya job=sendgmr) by 2002:a05:6902:1006:b0:e03:4bf0:b21e with SMTP id 3f1490d57ef6-e034bf0b50dmr375748276.1.1719589584856; Fri, 28 Jun 2024 08:46:24 -0700 (PDT) Date: Fri, 28 Jun 2024 15:46:18 +0000 In-Reply-To: <20240624052851.1030799-1-aniketmaurya@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240624052851.1030799-1-aniketmaurya@google.com> X-Mailer: git-send-email 2.45.2.803.g4e1b14247a-goog Message-ID: <20240628154618.327151-1-aniketmaurya@google.com> Subject: [PATCH v3 3/3] i3c: dw: Add optional apb clock From: Aniket To: Alexandre Belloni , Jeremy Kerr , Joel Stanley , Billy Tsai , Rob Herring , Krzysztof Kozlowski Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Aniket Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Besides the core clock, IP also has an apb interface clock. Add an optional hook for the same. Signed-off-by: Aniket --- drivers/i3c/master/dw-i3c-master.c | 4 ++++ drivers/i3c/master/dw-i3c-master.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c= -master.c index 4e3335641dcd..0ca41782f3a6 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -1454,6 +1454,10 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, if (IS_ERR(master->core_clk)) return PTR_ERR(master->core_clk); =20 + master->pclk =3D devm_clk_get_optional_enabled(&pdev->dev, "pclk"); + if (IS_ERR(master->pclk)) + return PTR_ERR(master->pclk); + master->core_rst =3D devm_reset_control_get_optional_exclusive(&pdev->dev, "core_rst"); if (IS_ERR(master->core_rst)) diff --git a/drivers/i3c/master/dw-i3c-master.h b/drivers/i3c/master/dw-i3c= -master.h index 7e76ca381d9f..fb7121c6c687 100644 --- a/drivers/i3c/master/dw-i3c-master.h +++ b/drivers/i3c/master/dw-i3c-master.h @@ -36,6 +36,7 @@ struct dw_i3c_master { void __iomem *regs; struct reset_control *core_rst; struct clk *core_clk; + struct clk *pclk; char version[5]; char type[5]; u32 sir_rej_mask; --=20 2.45.2.803.g4e1b14247a-goog From nobody Wed Dec 17 13:55:40 2025 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7433F1BC3C for ; Mon, 24 Jun 2024 05:29:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719206964; cv=none; b=sxI/gQnknj48gjf0qWQXeAAq0qp3hFLa8YwTDV2Hy5C3Av+ub0uDtPkxXm04F5e6d4H6S+mxLcZa5S81ZQT0Hn9g3QW9ptiLIhQHHcsGtPF5ssCsKvCVTtV5nNQ8STnlXtds3yUsYa3dm+lGzzYsHDiTj7IG2eALEVKL3rFgHRY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719206964; c=relaxed/simple; bh=50twyfEJ8ALTho3pL+ku6E2q/cus4h8CQVXWkBsgJ4o=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ejo/FTGh20+0U/kC6moMrwmlFkFMfGdda12sxmltxpKbNMZ75e8Z0Ia+KarTw9tn4zfu8HNND5tKZ/xBdU0VpcxMaK0pYdChNozeX80j1icos3PljA7BBMmpSbEXWwrPXRZlsT6n335MBAe8g+nvAh2QAPCkt++E+k2hU1bVjM0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Y5iseQFR; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aniketmaurya.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Y5iseQFR" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-63a988bdec8so74691907b3.2 for ; Sun, 23 Jun 2024 22:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719206962; x=1719811762; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=P1I8I99l7a+8VVN3a7Xt/piq3f28W3MFZ3VnliaJyPU=; b=Y5iseQFRU1iKk+YleCi7794DESJI6bmBUHk0J+kVJ2aoxLqJJb0U/sxiQhzriiZsM4 FXgnWCKy/cwa7O70CGqcDjMAGuO4fXLKYSUL8+zREOivnsn7FPQfjgWMeq7Jx8nCOOOv GtjxFzrCrPWmIEU4bqRm7jSdVTXPTOlo21/1B5WVJWFREvr9lq3xgZvtj64aBXvXUhYE EuV7HqhsCXVzoCStfQVJDLxv2abbOUKqxSm4AR6JbWJ2szgOBuiL2B+3Ey8ArPByDsQw 6IaOLegT93Oxw+Jx8hI+sGHLXQJBPkSXpCbWbITvUqMlBSMq3WZdv8K1DgWB6a3QEE/W Hsdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719206962; x=1719811762; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P1I8I99l7a+8VVN3a7Xt/piq3f28W3MFZ3VnliaJyPU=; b=BbxjbMF2ZTxxconvEEUJ+3kPabpFjRHOyYPQEYdr8KuzesZOS8YIyZmy/EoBh9wyVR +zSB7H96mO9xrUcJfKftRpQuYgaWN/BhEYPO+y68G5PTktY8ngxW24wXHlDJpscVbd8k PcePbV77WQBfCA9DSTVJTrTMlmEArcZyXHeNZkZ5NLH5TW9T7ks9AKMogx5HZFS+sRlq f3i4YuodpQw9OmRkPwtjSmt674PLpTyvvCrkzJ57eBYqdB2cpVFMP2xIH75T9YedVJGp Puil7NVlfWgFeMab6pv/Q0Efi5LfjMd8lSpKXsL7kOnebslENR4c57kaoETlsckZfbZP pQXQ== X-Forwarded-Encrypted: i=1; AJvYcCXwRxuhEhnON0ASLLoUycKuDfzA4tkvprixnJMnTSegPt9GclGv7G4VrpR4zHjAhzx/VRRyLhiUcT3djGq40l+P4sR7yKqgPfupbS4C X-Gm-Message-State: AOJu0YxAg+4q3fqWg0dr6ufFtHHyG0iI57lox2jJiMSkXZRY7IIRI3Bz UgNrPsAPOPw8ENQ02N+vzf2ikK5/p6egD29u7rPmBqIqFn3OS4mJP1U2x3XRRwMkAfevDMXxLe7 ahqlj3+WY4WKGUHkKH607mvRLpg== X-Google-Smtp-Source: AGHT+IFYTSVOMsLqJVDUxHQ8GFvdZHqCOqKjAi9xCBAxDVenSvN+E7dc9z9/aa2vq33ZomTzPFE3OUf1TIIi5BohR5k= X-Received: from aniketm.c.googlers.com ([fda3:e722:ac3:cc00:4f:4b78:c0a8:3387]) (user=aniketmaurya job=sendgmr) by 2002:a05:6902:1146:b0:e02:c619:732 with SMTP id 3f1490d57ef6-e0301098e9emr11043276.8.1719206962420; Sun, 23 Jun 2024 22:29:22 -0700 (PDT) Date: Mon, 24 Jun 2024 05:28:51 +0000 In-Reply-To: <20240624052851.1030799-1-aniketmaurya@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240611171600.1105124-1-aniketmaurya@google.com> <20240624052851.1030799-1-aniketmaurya@google.com> X-Mailer: git-send-email 2.45.2.741.gdbec12cfda-goog Message-ID: <20240624052851.1030799-4-aniketmaurya@google.com> Subject: [PATCH v2 3/3] i3c: dw: Use new *_enabled clk APIs From: Aniket To: Alexandre Belloni , Jeremy Kerr , Joel Stanley , Billy Tsai , Rob Herring , Krzysztof Kozlowski Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Aniket Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move to "enabled" variant of clk_get APIs. It takes care of enable and disable calls during the probe and remove. Signed-off-by: Aniket --- drivers/i3c/master/dw-i3c-master.c | 21 ++------------------- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c= -master.c index 41cdfd6741e3..37092b8e964f 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -1466,11 +1466,11 @@ int dw_i3c_common_probe(struct dw_i3c_master *maste= r, if (IS_ERR(master->regs)) return PTR_ERR(master->regs); =20 - master->core_clk =3D devm_clk_get(&pdev->dev, NULL); + master->core_clk =3D devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(master->core_clk)) return PTR_ERR(master->core_clk); =20 - master->pclk =3D devm_clk_get_optional(&pdev->dev, "pclk"); + master->pclk =3D devm_clk_get_optional_enabled(&pdev->dev, "pclk"); if (IS_ERR(master->pclk)) return PTR_ERR(master->pclk); =20 @@ -1479,14 +1479,6 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, if (IS_ERR(master->core_rst)) return PTR_ERR(master->core_rst); =20 - ret =3D clk_prepare_enable(master->core_clk); - if (ret) - return ret; - - ret =3D clk_prepare_enable(master->pclk); - if (ret) - goto err_disable_core_clk; - reset_control_deassert(master->core_rst); =20 spin_lock_init(&master->xferqueue.lock); @@ -1528,11 +1520,6 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, err_assert_rst: reset_control_assert(master->core_rst); =20 - clk_disable_unprepare(master->pclk); - -err_disable_core_clk: - clk_disable_unprepare(master->core_clk); - return ret; } EXPORT_SYMBOL_GPL(dw_i3c_common_probe); @@ -1542,10 +1529,6 @@ void dw_i3c_common_remove(struct dw_i3c_master *mast= er) i3c_master_unregister(&master->base); =20 reset_control_assert(master->core_rst); - - clk_disable_unprepare(master->pclk); - - clk_disable_unprepare(master->core_clk); } EXPORT_SYMBOL_GPL(dw_i3c_common_remove); =20 --=20 2.45.2.741.gdbec12cfda-goog