From nobody Sun Feb 8 03:46:29 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C70D32564; Mon, 24 Jun 2024 01:43:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719193397; cv=none; b=Oyjs4pmruZ1f2o0SixeauNASZAQgbAJqA+HA1d3auutZ+tZtpy7du+o8wsPCzP0dZ1/ChgzuLvk1pf+XWNrxP6ZhfJH86bcmoIGBkA1xjbwpzKb++UtUCiuG7p+riTXLkhGXS2/5jLx+xoARfOMXLjMnJmly+cdJNKZXJwbM2p4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719193397; c=relaxed/simple; bh=dQSS+cisNfaft2A5cQ4bXxLvcIiPOe9EipzRaGlA4QI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UzLcILbHylzI+yJARSYM3tjMc3v2gkNBDY/+UKKpWCiokLNzYNp50wLVNnRyzszlXl6IwiLQeL0nUNMjvoyPhe6DuPlOUdmotfAiTwFfQgyXi7xw1uJ/i8qlbQw0gNRUHQ1WDWjmYougNPM6IeaRPtG5obtN/hJZDI28KWAYVPo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=lSh/xBMG; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="lSh/xBMG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719193396; x=1750729396; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dQSS+cisNfaft2A5cQ4bXxLvcIiPOe9EipzRaGlA4QI=; b=lSh/xBMGM6pBzH1iys/UOrgg8kVKhoagccTbp5q/EQpM+tht8fnZWKGp 02orl9pOPC+lFIjtU5m9LylhrMmPqVEEqyMshCag+RGvrNIFbNmW3P+aG k1f3/Vz7SR9hnFo2KpcdJst+YgMcn60y+NZJ+gT/0AqJTSk204inK07mr ILG+QvzdEr8S7nT+LxBjKbH6LLgrEHRUIK3kE+CSHNQj7VYh+NAwcHlH1 H/LBfN06guxfqFKg7x1uP8aDYJyqggXy8BFIBiS5BOj6//L2o+2SgdIAT /g4StshFxi1tik6FmbRiYQdVdjpVifEmfKYwgHPu8/RFLPQdI8hsMLnwu w==; X-CSE-ConnectionGUID: DNG8NNPPSXyMomvLVng0VQ== X-CSE-MsgGUID: JwJVOIdAQGmrG5vqC2UKUQ== X-IronPort-AV: E=McAfee;i="6700,10204,11112"; a="12202748" X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="12202748" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2024 18:43:16 -0700 X-CSE-ConnectionGUID: b+DP2NKySZWqjRby6sfcFQ== X-CSE-MsgGUID: ZCT72PlLQ0OMgcIHe9+V0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="43821151" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by orviesa007.jf.intel.com with ESMTP; 23 Jun 2024 18:43:14 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , stable@vger.kernel.org, Jason Chen Subject: [PATCH v2 1/5] mei: vsc: Enhance IVSC chipset stability during warm reboot Date: Mon, 24 Jun 2024 09:42:19 +0800 Message-Id: <20240624014223.4171341-2-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624014223.4171341-1-wentong.wu@intel.com> References: <20240624014223.4171341-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" During system shutdown, incorporate reset logic to ensure the IVSC chipset remains in a valid state. This adjustment guarantees that the IVSC chipset operates in a known state following a warm reboot. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Cc: stable@vger.kernel.org # for 6.8+ Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/misc/mei/vsc-tp.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index e6a98dba8a73..5f3195636e53 100644 --- a/drivers/misc/mei/vsc-tp.c +++ b/drivers/misc/mei/vsc-tp.c @@ -568,6 +568,19 @@ static void vsc_tp_remove(struct spi_device *spi) free_irq(spi->irq, tp); } =20 +static void vsc_tp_shutdown(struct spi_device *spi) +{ + struct vsc_tp *tp =3D spi_get_drvdata(spi); + + platform_device_unregister(tp->pdev); + + mutex_destroy(&tp->mutex); + + vsc_tp_reset(tp); + + free_irq(spi->irq, tp); +} + static const struct acpi_device_id vsc_tp_acpi_ids[] =3D { { "INTC1009" }, /* Raptor Lake */ { "INTC1058" }, /* Tiger Lake */ @@ -580,6 +593,7 @@ MODULE_DEVICE_TABLE(acpi, vsc_tp_acpi_ids); static struct spi_driver vsc_tp_driver =3D { .probe =3D vsc_tp_probe, .remove =3D vsc_tp_remove, + .shutdown =3D vsc_tp_shutdown, .driver =3D { .name =3D "vsc-tp", .acpi_match_table =3D vsc_tp_acpi_ids, --=20 2.34.1 From nobody Sun Feb 8 03:46:29 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB8D779F6; Mon, 24 Jun 2024 01:43:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719193400; cv=none; b=oTn/g2HiHQB6RiFhQuUHb5Cy8ZsrROAlJonG2HlmlX1GJGtzkfUMKTYvzdr0gcpLTCfcFcNpWztuE2jEd3PKKOsbbub/m1QnzY3AiCAY59LE4H/uMlTTLXxUe7X0u6NXr80DE5HOnIaYJuUb6JE1kcUWmtYEXNv8PDBbag15Py8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719193400; c=relaxed/simple; bh=dlSC/zVmzLNuhEKcph1rM7e1p5iGGVD5RK80YRfDr3E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bTRw8j+PxoSDTsEq05D96R/u/8kgPnFBIrP3ffrqb7QVdleb9vId1PGx1VFAwQ5dib23GxFMA5+UPySpiBy8iFYBBqJOVdKyLOz2mP7PptTzrOUaFNLcjXY9IlNbA+ZfFoZhrjanb4CN5uvRBiDxSE6ZD6cKzn+9/D+v2dWqIxE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=S0LO/7rP; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="S0LO/7rP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719193399; x=1750729399; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dlSC/zVmzLNuhEKcph1rM7e1p5iGGVD5RK80YRfDr3E=; b=S0LO/7rP6KyEWVyD8/egXoSPWQktHEwBq/GIv76lKPhYteRys2FI7eXK pCmybBVxNLocJO9xtrst0xj3CwlGcnb4bWay7Oex3io8/fpKTPNaYN8+r /qWE2goX0GgP5lsguR12+0ruwGTC/UtHpxetqOXeN5U8e5PVQnj8HOG+d KW3bxatEY3U9j7BuG+3Xm3vc9O2VME3MBMmIJCRe0RTZWQmdlYVnFRT5U YZ47jNzAbyVQOEmGxwc/9CUYb1tN+5BiBtTSae7vE6swh+vx5XpsSIzgd BjPzVnL+4zYPNqeBGzFXlwqPCmQ0RJSApQH3ew80cL1bFfVsVNnbHeKEg w==; X-CSE-ConnectionGUID: wU4ZmImBSK69R+K/JLBmiw== X-CSE-MsgGUID: +fHO8bG6StGBFDhUiiDgCQ== X-IronPort-AV: E=McAfee;i="6700,10204,11112"; a="12202754" X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="12202754" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2024 18:43:18 -0700 X-CSE-ConnectionGUID: WRb/btplTfeXyShIZm08YQ== X-CSE-MsgGUID: vwnc/n6OTfCuija306mzLQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="43821188" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by orviesa007.jf.intel.com with ESMTP; 23 Jun 2024 18:43:17 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , stable@vger.kernel.org, Jason Chen Subject: [PATCH v2 2/5] mei: vsc: Enhance SPI transfer of IVSC rom Date: Mon, 24 Jun 2024 09:42:20 +0800 Message-Id: <20240624014223.4171341-3-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624014223.4171341-1-wentong.wu@intel.com> References: <20240624014223.4171341-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Constructing the SPI transfer command as per the specific request. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Cc: stable@vger.kernel.org # for 6.8+ Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/misc/mei/vsc-tp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index 5f3195636e53..fed156919fda 100644 --- a/drivers/misc/mei/vsc-tp.c +++ b/drivers/misc/mei/vsc-tp.c @@ -331,7 +331,7 @@ int vsc_tp_rom_xfer(struct vsc_tp *tp, const void *obuf= , void *ibuf, size_t len) return ret; } =20 - ret =3D vsc_tp_dev_xfer(tp, tp->tx_buf, tp->rx_buf, len); + ret =3D vsc_tp_dev_xfer(tp, tp->tx_buf, ibuf ? tp->rx_buf : ibuf, len); if (ret) return ret; =20 --=20 2.34.1 From nobody Sun Feb 8 03:46:29 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84AAEF507; Mon, 24 Jun 2024 01:43:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719193407; cv=none; b=V5fQxFnTbNnSCQtmTzLEv4lK+uBFjvplxGZ9bmxiM1kgT++GtSRpQpWyvIFlqS1/qCBaUonOIBnPtiYxhq/1byyv68kHhjMphYSCG/x9KpwXvoFxoCPWa6CIFpfIA/hBOCB1wjrUWGRwl42MrCuGopudQosSITq61mUDIKI18ZM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719193407; c=relaxed/simple; bh=HZevPcwTlaflkC7j4MO+L4+OhCr0yxD+BbEzZ4my0MI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LicPuD0rYEoZR5kX2ofYdcKv9zg7zgyyfEznqZKK9MBcYSYmsVhtL7znM2/xuSwBiTTa1JmX4V//Yfy0Kc5xJyBTdLt0Yxpgh+9zwX8ns40sTaz37D6UjcRMyO57xhUnY0m4DjdI+G2w5Rsyu2k15yvdl8h8MHgGPVytr3VEYK8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Sov6rUfS; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Sov6rUfS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719193406; x=1750729406; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HZevPcwTlaflkC7j4MO+L4+OhCr0yxD+BbEzZ4my0MI=; b=Sov6rUfS65FR4wEH5lc9TLD0kCTSOZkoDB0UP3YUMX0MjryMCx+U+m3K pGYtXTWYZdmo1olAIhkBMrXyv5kOR5qLDlhjA2EmySuuVz3l+n+OpQVQb 7xyeDvZ+BP1/3naOeJI2kSA2rigRtOY9Jx3uTOHJvSDDCp3pvc3oHHvEz dwf5cyuoOig1/F0AgdiWbYQ9bzeeqMvWhPLBtpVEr/QlKS8CgWQEKgSHh bRfy53PeZgJkoFpC0mNZVdGhhJhpyCzESuZb3KVcpAuKUoS1UbHZMrZTi fN36mfk2zJQ+l/+e95MFukieth8yLSh5kIMjO1M9n8FsUrAYkbyG8XMEl Q==; X-CSE-ConnectionGUID: gzrT65HKSb+L58k1C5zufg== X-CSE-MsgGUID: 2OQ1fRNVRbOVOIIJVnADvQ== X-IronPort-AV: E=McAfee;i="6700,10204,11112"; a="12202760" X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="12202760" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2024 18:43:25 -0700 X-CSE-ConnectionGUID: M0n8ThwGSlmzMBO8Xqi+ug== X-CSE-MsgGUID: 8fL3OKZBTpedl/nN1I/AJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="43821235" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by orviesa007.jf.intel.com with ESMTP; 23 Jun 2024 18:43:23 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , stable@vger.kernel.org, Jason Chen Subject: [PATCH v2 3/5] mei: vsc: Utilize the appropriate byte order swap function Date: Mon, 24 Jun 2024 09:42:21 +0800 Message-Id: <20240624014223.4171341-4-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624014223.4171341-1-wentong.wu@intel.com> References: <20240624014223.4171341-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Switch from cpu_to_be32_array() to be32_to_cpu_array() for the received rom data. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Cc: stable@vger.kernel.org # for 6.8+ Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/misc/mei/vsc-tp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index fed156919fda..12236599649e 100644 --- a/drivers/misc/mei/vsc-tp.c +++ b/drivers/misc/mei/vsc-tp.c @@ -336,7 +336,7 @@ int vsc_tp_rom_xfer(struct vsc_tp *tp, const void *obuf= , void *ibuf, size_t len) return ret; =20 if (ibuf) - cpu_to_be32_array(ibuf, tp->rx_buf, words); + be32_to_cpu_array(ibuf, tp->rx_buf, words); =20 return ret; } --=20 2.34.1 From nobody Sun Feb 8 03:46:29 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F410F749A; Mon, 24 Jun 2024 01:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719193426; cv=none; b=ZbNzQPW8uQyaikozl3tjZp1iPaNLFqX1n8VsRLIFf3kkR2dnZnT+6fsuM0Y7RPhEM9qgiY3in/R6B2f2aQEX4JeON1iAySAGey/s6YKG4CgeOeEV86JG6mkjfISPzaamDZOTrl4fwiuvfVlSEzqz8KjKuZe5hsaiTu4g+uV808Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719193426; c=relaxed/simple; bh=JM1sD9QP4RyHSPhRqlUabkVUXwe0DuYqN6xM1zvvobw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=n5kKIeWkMw7jRo4k1Nt/zkA89Zio+Wtce9IAyrD9WCpiytP5xw5MXYEVVqFiAIbt8DHHoHp0IbThKP+V9wBpq5Hihbj+lhJQpo3QuZrQvMWiKUYEgrG7BiJUekbPZ5Y4P8vlbk4PPrJ3qaTALZW5DzeJi8isLHDUV1bf4I/i6N4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=m0+JEOVL; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="m0+JEOVL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719193425; x=1750729425; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JM1sD9QP4RyHSPhRqlUabkVUXwe0DuYqN6xM1zvvobw=; b=m0+JEOVLAbA61Y8JaSbEx+6Jacm/W05pvyQapaXtP15GbfFjhVdpyHR9 kaL/XClnDEqLNB9CNpeKcE4rJwE781k+bisi25K9Y75Ui7AaWBIB+66x9 sxR37ND4QmJHsTTt0Fq67AiBiqupZfXDQZKM6Wa0+9w+RzxRH951Onsb9 YUlu4Drvy7Qd5pXVPPxcbDuLU8+UIjpRAe3zLdK7mCpnuG8643weSTDnY 7Ly8om2EfUH88kLj6fGf1VcIUupi5iwN73RR/Ek8JWlDDbSJaoqqc+qo9 RYAT9hLtnwyaACXM4ypyKFrIFZQoEHD0Xv5MWO55fJE7kK0G6Cqp5bsp6 g==; X-CSE-ConnectionGUID: OO/uiz14QuaV8c5fLg1WYg== X-CSE-MsgGUID: qRBf8u+7SQiOl/Dkhh/rxw== X-IronPort-AV: E=McAfee;i="6700,10204,11112"; a="12202780" X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="12202780" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2024 18:43:44 -0700 X-CSE-ConnectionGUID: jQm4zB0LR0qSf5sKmLzWmg== X-CSE-MsgGUID: JEQc1Ez3S/aHVMdeoFjo6g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="43821399" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by orviesa007.jf.intel.com with ESMTP; 23 Jun 2024 18:43:42 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , stable@vger.kernel.org, Jason Chen Subject: [PATCH v2 4/5] mei: vsc: Prevent timeout error with added delay post-firmware download Date: Mon, 24 Jun 2024 09:42:22 +0800 Message-Id: <20240624014223.4171341-5-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624014223.4171341-1-wentong.wu@intel.com> References: <20240624014223.4171341-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After completing the firmware download, the firmware requires some time to become functional. This change introduces additional sleep time before the first read operation to prevent a confusing timeout error in vsc_tp_xfer(). Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Cc: stable@vger.kernel.org # for 6.8+ Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/misc/mei/platform-vsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mei/platform-vsc.c b/drivers/misc/mei/platform-vs= c.c index 1ec65d87488a..d02f6e881139 100644 --- a/drivers/misc/mei/platform-vsc.c +++ b/drivers/misc/mei/platform-vsc.c @@ -28,8 +28,8 @@ =20 #define MEI_VSC_MAX_MSG_SIZE 512 =20 -#define MEI_VSC_POLL_DELAY_US (50 * USEC_PER_MSEC) -#define MEI_VSC_POLL_TIMEOUT_US (200 * USEC_PER_MSEC) +#define MEI_VSC_POLL_DELAY_US (100 * USEC_PER_MSEC) +#define MEI_VSC_POLL_TIMEOUT_US (400 * USEC_PER_MSEC) =20 #define mei_dev_to_vsc_hw(dev) ((struct mei_vsc_hw *)((dev)->hw)) =20 --=20 2.34.1 From nobody Sun Feb 8 03:46:29 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CA04C8D1 for ; Mon, 24 Jun 2024 01:43:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719193430; cv=none; b=utypvDvpS+X6Lbide2jhDo63TkNbS7U9Md/I76/bAYHf0oBH88mlZjEa2ydnr52lj09G/VM1fcJkmiYOSbOg7PvISgPtNWn/tan7lxE95EJi6HniMspz2WgtEB8RUSBK20yxJdr0G4tZTPLs2cmdrMsahSBt5yFkKiK3qifG3Sc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719193430; c=relaxed/simple; bh=3PGXukhXUhbCCLDkatC+1Lrz46ffQiiXYfae+u3zvRI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FxSITIuZiELoHEFef8AmmwuVWX11V0+CkWdEva2jTocZzCNqrMtF8C8+JDu722njNKJO8Oo+xRBTM0zCwZ87KT4jKJhsuW45Rj7i+Td0n1x6FXoyYnGNEk4bsgegp2tlkNgPPxfBKIywwHLSogTiUXHI/ggvVW7cnlsmbZH2rx4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=TdU+6lT+; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="TdU+6lT+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719193429; x=1750729429; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3PGXukhXUhbCCLDkatC+1Lrz46ffQiiXYfae+u3zvRI=; b=TdU+6lT+dudMX/iLJe6y4nR3pW+q9Eq0VSR4TCIwTKHqB5gAWSOMqYC1 P6K588rpX/X6aw/XeKiyCI2gOhZnwYQ/fgd2qGZMeSDt1pqZz5pOBjdBC mlVME6k3H8dpqPfNWyDPCR3aa3cdEmuAVb3D9emsTz3clQ71fesTQhmN9 qb2c1zNAqT0qrlpfj9kOzIrfEvBG8DADUPtaHEi+wZ0cjq6lVJO7w2p6l INDHDz0cg+8B8kwNXEaQDuW1iK2YbAy5+yp1JhWrO3TSxBmjm4QtHVWaS szZVAW1CwM+TfEPVc9lDZdUsxTEaueozy0oKPdinLGYdp5+nvQDyulDZv Q==; X-CSE-ConnectionGUID: +Vum4D0nSP6UCILSFcbvWA== X-CSE-MsgGUID: YcCVKpjJR8GGInqno2bMlw== X-IronPort-AV: E=McAfee;i="6700,10204,11112"; a="12202794" X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="12202794" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2024 18:43:49 -0700 X-CSE-ConnectionGUID: hUcK0I8mRYmcF5kD+s68TA== X-CSE-MsgGUID: 1jIlMDLTRM2355BMVgTyAg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="43821442" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by orviesa007.jf.intel.com with ESMTP; 23 Jun 2024 18:43:48 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , Jason Chen Subject: [PATCH v2 5/5] mei: vsc: Fix spelling error Date: Mon, 24 Jun 2024 09:42:23 +0800 Message-Id: <20240624014223.4171341-6-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240624014223.4171341-1-wentong.wu@intel.com> References: <20240624014223.4171341-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix a spelling error in a comment. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/misc/mei/vsc-fw-loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/vsc-fw-loader.c b/drivers/misc/mei/vsc-fw-loa= der.c index 596a9d695dfc..084d0205f97d 100644 --- a/drivers/misc/mei/vsc-fw-loader.c +++ b/drivers/misc/mei/vsc-fw-loader.c @@ -204,7 +204,7 @@ struct vsc_img_frag { =20 /** * struct vsc_fw_loader - represent vsc firmware loader - * @dev: device used to request fimware + * @dev: device used to request firmware * @tp: transport layer used with the firmware loader * @csi: CSI image * @ace: ACE image --=20 2.34.1