From nobody Thu Dec 18 06:05:21 2025 Received: from fhigh6-smtp.messagingengine.com (fhigh6-smtp.messagingengine.com [103.168.172.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99EC018754B for ; Sun, 23 Jun 2024 22:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.157 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719180557; cv=none; b=TTE0QUg80UOp/w06SePgLzvcvKiNrGDJvtsaY2v9Qf1cGTc9jL8AZ3K3b6lcTPpw7mU8ijFkQtQim76kyF8Og2sJiuIWdKXWifvYXQZHhZzLLDoYI4HiRveGTRFD032LuXl8VtrpAtK285Ch8lmvetZRNKLM/2mMQQOHx2RRdHc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719180557; c=relaxed/simple; bh=v252W92RzXy8ORK5dMJxqUSL0uBdYHFGHrhFVPRouig=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=glYTAJHnIpdXAyyZ9KtB4xZqH+tJkiRQZv9BWViq2Ol2UgdutvicuCUG4n4Q5RhKvXmT4T1H7JQVU/wJwAnm3/p7La9PU8wJmoKI1Qsee430n+zNVNrcUlj/cltvkgUtBYkE+0uXwxOO8dfMBactDovFUumGtEChOkA28GApQ2Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=NPryTV9r; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=o8A1V56X; arc=none smtp.client-ip=103.168.172.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="NPryTV9r"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="o8A1V56X" Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfhigh.nyi.internal (Postfix) with ESMTP id A0963114011D; Sun, 23 Jun 2024 18:09:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 23 Jun 2024 18:09:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1719180554; x= 1719266954; bh=5fRKzoSigHUcRzL6hQHux4tv35XsJTJ3RfGKgiIvETE=; b=N PryTV9rG7lIrRx0eVKEz58uKC/DwC6x40hqXqI06BwttE2x8IZ2CBmjcPgMYWmjk LgfBlpeeyuQFCK+0MxVlQbo1ufQBL+dn5CiHMrE4VkaPkHWSgE7l21obGr6OlshJ OUrxqTRNJxMeWTjAEawgl7HpgIGycKTdpdroKFTAaV58ECYVZLT1/I2VU5J/szut iXk+/oB7D/l20O/SBSfWfqDWz+Doq91iLsbMdWCDnT/Qc219jn7KXFC4StPcNvIw VowC6EiIQbkgEXpvEUanI1dgEdyZxm916Lp5ZuwiWvmEG2qEyVWDURfLx2YoViSK x/1OEf8voKnD3M77l3Z0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1719180554; x= 1719266954; bh=5fRKzoSigHUcRzL6hQHux4tv35XsJTJ3RfGKgiIvETE=; b=o 8A1V56XedFurg9Vf+oYtF1DYxuCyDovNA3rRxp2LIQGpl3E3TfCJufr8WVAB+E+I lHwKuyZzPAll8Pl91wRAKavTl4L3KFMPdrFiCw13x5tS1ulxKqwY/I3KoRI3160q Hs/Jiq2kbjpsanaj6ygnWJGfJ736YBbtNY9JMxkJPvC3IQ07r0nkVFOPK15BoNwW DEg/xN12W05BDK17mPqhUBV+mY5b9MWE48R5XAiVS93vnvX9Ln41lmzPbVAFTigL D6Jzl0gRDzoTh/5hExfyGjoTAlKuzN0yNdwLtWPdAhfpptzmZOyJP+rBn8aHbE45 2Zy/baX37yXiDdbMeu7rg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeegtddgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefvrghkrghshhhiucfurghkrghmohhtohcuoehoqdhtrghk rghshhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrghtthgvrhhnpedvjefgje euvdfguddukeelveetgfdtvefhtdfffeeigfevueetffeivdffkedvtdenucevlhhushht vghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehoqdhtrghkrghshhhise hsrghkrghmohgttghhihdrjhhp X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 23 Jun 2024 18:09:13 -0400 (EDT) From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Subject: [PATCH 6/7] firewire: core: add tracepoints events for queueing packets of isochronous context Date: Mon, 24 Jun 2024 07:08:57 +0900 Message-ID: <20240623220859.851685-7-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240623220859.851685-1-o-takashi@sakamocchi.jp> References: <20240623220859.851685-1-o-takashi@sakamocchi.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It is helpful to trace the queueing packets of isochronous context when the core function is requested them by both in-kernel unit drivers and userspace applications. This commit adds some tracepoints events for the aim. Signed-off-by: Takashi Sakamoto --- drivers/firewire/core-iso.c | 4 ++ include/trace/events/firewire.h | 79 +++++++++++++++++++++++++++++++++ 2 files changed, 83 insertions(+) diff --git a/drivers/firewire/core-iso.c b/drivers/firewire/core-iso.c index 93ca0dec1805..b3eda38a36f3 100644 --- a/drivers/firewire/core-iso.c +++ b/drivers/firewire/core-iso.c @@ -191,6 +191,10 @@ int fw_iso_context_queue(struct fw_iso_context *ctx, struct fw_iso_buffer *buffer, unsigned long payload) { + trace_isoc_outbound_queue(ctx, payload, packet); + trace_isoc_inbound_single_queue(ctx, payload, packet); + trace_isoc_inbound_multiple_queue(ctx, payload, packet); + return ctx->card->driver->queue_iso(ctx, packet, buffer, payload); } EXPORT_SYMBOL(fw_iso_context_queue); diff --git a/include/trace/events/firewire.h b/include/trace/events/firewir= e.h index ad1546120aa3..0381b3ca4d0e 100644 --- a/include/trace/events/firewire.h +++ b/include/trace/events/firewire.h @@ -742,6 +742,85 @@ DEFINE_EVENT_CONDITION(isoc_flush_completions_template= , isoc_inbound_multiple_fl TP_CONDITION(ctx->type =3D=3D FW_ISO_CONTEXT_RECEIVE_MULTICHANNEL) ); =20 +#define TP_STRUCT__entry_iso_packet(ctx, buffer_offset, packet) \ + TP_STRUCT__entry( \ + __field(u64, context) \ + __field(u8, card_index) \ + __field(u32, buffer_offset) \ + __field(bool, interrupt) \ + __field(bool, skip) \ + __field(u8, sy) \ + __field(u8, tag) \ + __dynamic_array(u32, header, packet->header_length / QUADLET_SIZE) \ + ) + +#define TP_fast_assign_iso_packet(ctx, buffer_offset, packet) \ + TP_fast_assign( \ + __entry->context =3D (uintptr_t)ctx; \ + __entry->card_index =3D ctx->card->index; \ + __entry->buffer_offset =3D buffer_offset; \ + __entry->interrupt =3D packet->interrupt; \ + __entry->skip =3D packet->skip; \ + __entry->sy =3D packet->sy; \ + __entry->tag =3D packet->tag; \ + memcpy(__get_dynamic_array(header), packet->header, \ + __get_dynamic_array_len(header)); \ + ) + +TRACE_EVENT_CONDITION(isoc_outbound_queue, + TP_PROTO(const struct fw_iso_context *ctx, unsigned long buffer_offset, c= onst struct fw_iso_packet *packet), + TP_ARGS(ctx, buffer_offset, packet), + TP_CONDITION(ctx->type =3D=3D FW_ISO_CONTEXT_TRANSMIT), + TP_STRUCT__entry_iso_packet(ctx, buffer_offset, packet), + TP_fast_assign_iso_packet(ctx, buffer_offset, packet), + TP_printk( + "context=3D0x%llx card_index=3D%u buffer_offset=3D0x%x interrupt=3D%s sk= ip=3D%s sy=3D%d tag=3D%u header=3D%s", + __entry->context, + __entry->card_index, + __entry->buffer_offset, + __entry->interrupt ? "true" : "false", + __entry->skip ? "true" : "false", + __entry->sy, + __entry->tag, + __print_array(__get_dynamic_array(header), + __get_dynamic_array_len(header) / QUADLET_SIZE, QUADLET_SIZE) + ) +); + +TRACE_EVENT_CONDITION(isoc_inbound_single_queue, + TP_PROTO(const struct fw_iso_context *ctx, unsigned long buffer_offset, c= onst struct fw_iso_packet *packet), + TP_ARGS(ctx, buffer_offset, packet), + TP_CONDITION(ctx->type =3D=3D FW_ISO_CONTEXT_RECEIVE), + TP_STRUCT__entry_iso_packet(ctx, buffer_offset, packet), + TP_fast_assign_iso_packet(ctx, buffer_offset, packet), + TP_printk( + "context=3D0x%llx card_index=3D%u buffer_offset=3D0x%x interrupt=3D%s sk= ip=3D%s", + __entry->context, + __entry->card_index, + __entry->buffer_offset, + __entry->interrupt ? "true" : "false", + __entry->skip ? "true" : "false" + ) +); + +TRACE_EVENT_CONDITION(isoc_inbound_multiple_queue, + TP_PROTO(const struct fw_iso_context *ctx, unsigned long buffer_offset, c= onst struct fw_iso_packet *packet), + TP_ARGS(ctx, buffer_offset, packet), + TP_CONDITION(ctx->type =3D=3D FW_ISO_CONTEXT_RECEIVE_MULTICHANNEL), + TP_STRUCT__entry_iso_packet(ctx, buffer_offset, packet), + TP_fast_assign_iso_packet(ctx, buffer_offset, packet), + TP_printk( + "context=3D0x%llx card_index=3D%u buffer_offset=3D0x%x interrupt=3D%s", + __entry->context, + __entry->card_index, + __entry->buffer_offset, + __entry->interrupt ? "true" : "false" + ) +); + +#undef TP_STRUCT__entry_iso_packet +#undef TP_fast_assign_iso_packet + #undef QUADLET_SIZE =20 #endif // _FIREWIRE_TRACE_EVENT_H --=20 2.43.0