From nobody Tue Dec 16 19:42:23 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2235DD51C; Sun, 23 Jun 2024 09:32:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719135145; cv=none; b=Hv2wlgdtta1u4cx6LJKyfAm/iK+9KuLl9Ys34wJs3Pi9HTklSDvj5ic25XTcNTTa3vf3N71+216rRlvaMzm7Wg2TXWMVyO3gDMdtGI+PORQYxYJomvFHVkTt8PJO7+yr5ZsPzZ1K8u6u5DvMIry34MUhUvflhDCqtM5Q03zdUic= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719135145; c=relaxed/simple; bh=o+ppC9cqSZaFmTTXQs9RvqE76Ildur/5zLcTVfC39hE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=X8Tt6/RXbQfHtDp4+huK2NhcNsx6AN8spF8XOx3D+O6XjrFMiwzW1fWKknjnF+kizA4+dyyc7uzysaczw1uZGa8TvnDpOv0dZ1iQ50SveekYRBgZdDExjppaWaWVXLIwSFPeZ4oQC4GTGiAeB1FI6Vh4MORplCL89Jqu0iq/XYo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Zjj8sv7u; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Zjj8sv7u" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719135143; x=1750671143; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=o+ppC9cqSZaFmTTXQs9RvqE76Ildur/5zLcTVfC39hE=; b=Zjj8sv7uyLnhIjxtcYYh9IUiFQ2R/oreF6vD8IfYMp/L3zxLsgilwZwG VXAV/raj1NHKjUvzoO2w5UQqP6TyFPAQW/98CnkTtf/fNKrT9hYHZpHeV oXnG1EBJUSGnM1WCn4x9ZVkeS1flMQLNkXwIbJO7lLo8WcyCJbzQvVc4c d9SpbyEM7NP8AFu+ENDLb/dG7Q315zkAYKrxatz/KyKqUQhAb9ol5feha vL/Ll9Qrf7wsQZwvOO2L+UKpmW+zb6PQps9dVP/aKeXQjNNN8nqMiEhWC I5oS30ciJPwWv4dnzi9ngNNXYbGl131k1FB9M5H/oQP9JBfjAqGGFMdeG w==; X-CSE-ConnectionGUID: T6dKxOzmQnGlxLU0TuCQOQ== X-CSE-MsgGUID: NG2ukBj/SBagNhIO6k83VQ== X-IronPort-AV: E=McAfee;i="6700,10204,11111"; a="16089078" X-IronPort-AV: E=Sophos;i="6.08,259,1712646000"; d="scan'208";a="16089078" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2024 02:32:23 -0700 X-CSE-ConnectionGUID: 0zZQzj9EQYqUsncoeReyXA== X-CSE-MsgGUID: 3C4DSRbIRtWyvz8FuqJd1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,259,1712646000"; d="scan'208";a="73761700" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by orviesa002.jf.intel.com with ESMTP; 23 Jun 2024 02:32:21 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , stable@vger.kernel.org, Jason Chen Subject: [PATCH 1/6] mei: vsc: Enhance IVSC chipset reset toggling Date: Sun, 23 Jun 2024 17:30:51 +0800 Message-Id: <20240623093056.4169438-2-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240623093056.4169438-1-wentong.wu@intel.com> References: <20240623093056.4169438-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Implementing the hardware recommendation to toggle the chipset reset. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Cc: stable@vger.kernel.org # for 6.8+ Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/misc/mei/vsc-tp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index e6a98dba8a73..dcab5174bf00 100644 --- a/drivers/misc/mei/vsc-tp.c +++ b/drivers/misc/mei/vsc-tp.c @@ -350,6 +350,8 @@ void vsc_tp_reset(struct vsc_tp *tp) disable_irq(tp->spi->irq); =20 /* toggle reset pin */ + gpiod_set_value_cansleep(tp->resetfw, 1); + msleep(VSC_TP_RESET_PIN_TOGGLE_INTERVAL_MS); gpiod_set_value_cansleep(tp->resetfw, 0); msleep(VSC_TP_RESET_PIN_TOGGLE_INTERVAL_MS); gpiod_set_value_cansleep(tp->resetfw, 1); --=20 2.34.1 From nobody Tue Dec 16 19:42:23 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50CD05FB9C; Sun, 23 Jun 2024 09:32:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719135151; cv=none; b=qHot9+MoZraDnJ8HMFSA0aWPjSdJqb1y8x++AhIvUx57pCqDsXB9ObVHnToiCIteHWw5da1j8uLKuCv3Em86r6dCMyZFEa9wIlrOimNuQ+souaNL1wqDwyU/Zn8HW9vEgxy3FsuXfpYwM95wRhDMYEzJM2SM7cJJMHwB49KAtjs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719135151; c=relaxed/simple; bh=XmOQcTrxfUfHjL/0izCrhg/Yqc+CNqGhOUcXysJjsvA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DOQG3t/nefJQ7debzE8n1JJAV2eghJJzXingtSKmpqxBFDBxxjfbOZijqEjz5ZG18lbo5EzVKa5+WdxF5kC6mvZ9+E0GfIcns4rE4MAGCc9q3seaqFSKF0k+QH7YaWCOrulGqO7p/QqQQWt21/zYQLxwKjM9kOwpy9IMZC6YIVQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=L5qiUZVf; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="L5qiUZVf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719135149; x=1750671149; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=XmOQcTrxfUfHjL/0izCrhg/Yqc+CNqGhOUcXysJjsvA=; b=L5qiUZVfs/28nSMPdFJYtcohhoV8gbXW32vo+DnnSCJFTw45d6sIoXrQ 3QP7ILno3T3PSYs7/zima6WEgPZGre6D+1nsRlBYe6W/7vrqBcwK1ATjk 6HbgK8LBkZNi/Xy5ZCX+m/o2j8jXM6ObqUCiIOK9RQiy9YK0R/xu7d9f7 oqAR860+Ik/X96ezOb4nc0Hz+UMEE4yHqhRFRhr4xZ+ZqRm3+sj9DuaMt coij4CM/TE4LzhRQ1gE4N3DcbAOd6U/Ae3Y5JTFUfy+tS5dVRBcHd5Vwc Xh4v9ZaVrML8rKsTd3CfIa1htVH73nPYa9BQAcQEwLZ1sFW4QPhj81ocM A==; X-CSE-ConnectionGUID: toXZe1SNQYym5rN010STbA== X-CSE-MsgGUID: QDrb+Un0SM+/pCiSP1Mw7A== X-IronPort-AV: E=McAfee;i="6700,10204,11111"; a="16089086" X-IronPort-AV: E=Sophos;i="6.08,259,1712646000"; d="scan'208";a="16089086" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2024 02:32:29 -0700 X-CSE-ConnectionGUID: l0olGh5WTniS46YTWBw8fA== X-CSE-MsgGUID: Md9Tz+HIQmm5mXVYkSMaxg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,259,1712646000"; d="scan'208";a="73761709" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by orviesa002.jf.intel.com with ESMTP; 23 Jun 2024 02:32:27 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , stable@vger.kernel.org, Jason Chen Subject: [PATCH 2/6] mei: vsc: Enhance IVSC chipset stability during warm reboot Date: Sun, 23 Jun 2024 17:30:52 +0800 Message-Id: <20240623093056.4169438-3-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240623093056.4169438-1-wentong.wu@intel.com> References: <20240623093056.4169438-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" During system shutdown, incorporate reset logic to ensure the IVSC chipset remains in a valid state. This adjustment guarantees that the IVSC chipset operates in a known state following a warm reboot. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Cc: stable@vger.kernel.org # for 6.8+ Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/misc/mei/vsc-tp.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index dcab5174bf00..4595b1a25536 100644 --- a/drivers/misc/mei/vsc-tp.c +++ b/drivers/misc/mei/vsc-tp.c @@ -570,6 +570,19 @@ static void vsc_tp_remove(struct spi_device *spi) free_irq(spi->irq, tp); } =20 +static void vsc_tp_shutdown(struct spi_device *spi) +{ + struct vsc_tp *tp =3D spi_get_drvdata(spi); + + platform_device_unregister(tp->pdev); + + mutex_destroy(&tp->mutex); + + vsc_tp_reset(tp); + + free_irq(spi->irq, tp); +} + static const struct acpi_device_id vsc_tp_acpi_ids[] =3D { { "INTC1009" }, /* Raptor Lake */ { "INTC1058" }, /* Tiger Lake */ @@ -582,6 +595,7 @@ MODULE_DEVICE_TABLE(acpi, vsc_tp_acpi_ids); static struct spi_driver vsc_tp_driver =3D { .probe =3D vsc_tp_probe, .remove =3D vsc_tp_remove, + .shutdown =3D vsc_tp_shutdown, .driver =3D { .name =3D "vsc-tp", .acpi_match_table =3D vsc_tp_acpi_ids, --=20 2.34.1 From nobody Tue Dec 16 19:42:23 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06DCA12E1CE; Sun, 23 Jun 2024 09:32:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719135154; cv=none; b=ANYsc7vobt3w7OkRLPE0KKQSUVg2dQtD3Q6LtsiMZaAoz6e/b/tSIIkAftNkBMN5zo9E8KOkG6uS2RfIbVbx1jm/g2jp8Man7OLcD0gHbGndNrGiPHwyLfh556XtQ1yEYe+FHU8GZv86uRSAb1W8d1oszh+YvGZuTgVmCwjoFMY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719135154; c=relaxed/simple; bh=EXkNc/Ttx7OMvyjILPC3VaKaH6IL0o8GMCiR0jJ5wKw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=EWv7F+FnB19Ye7LgCiIbhK9UcFRfix4zTPbDl4b379sYLpuMWnXauFHf2YaKd9YU8ig1wq55E7q7o0QKKIj+yKrlkHcEmwkPEAR4xB70Ks8ES6afbxaPHAZBth4aRyqGuPkX9Ca7SdN7pCDpIg7v9JJUTZBfipzz9m1jc7kg6bw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hzmtJVlB; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hzmtJVlB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719135153; x=1750671153; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EXkNc/Ttx7OMvyjILPC3VaKaH6IL0o8GMCiR0jJ5wKw=; b=hzmtJVlBQkbxb901MnBTIJ4kAQ1hMSV9UC1BqygLEvMh31s9pklj8BQZ BJKSea7q5TwgHOVwQvS8sTC1qXv30FMNuw8T7qCAKd/DjxZEMtFYfGg04 qm+wSSnIYkWqR0K1evYR9l8ImZMZziVgxE5OMRJx9QvI5grJX5OMM+YkD 0xCx6i7qnOw2FHTL37PY1IbOI8GBjzQihqTr1e+ggf1VwjeMWq48Tv0Yx a6QYdwwX2fv4zcwDcRmK266b/Jsah0luKWqmLKiSeQR75IZ3dQjdKucI3 0XqulPBZMz9bLDFBzx0BIMxsBtS7JO6siEezL9aB/BSHPMzZ464m+scFR g==; X-CSE-ConnectionGUID: hz0pFQH2Q+WGoVWW/q8cWQ== X-CSE-MsgGUID: f/IjNLoERzS28H/aNHarUA== X-IronPort-AV: E=McAfee;i="6700,10204,11111"; a="16089090" X-IronPort-AV: E=Sophos;i="6.08,259,1712646000"; d="scan'208";a="16089090" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2024 02:32:33 -0700 X-CSE-ConnectionGUID: gYicLethRRmGgw/YZJKPVw== X-CSE-MsgGUID: M/6xiyp+S0+ZaFYH3Venug== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,259,1712646000"; d="scan'208";a="73761728" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by orviesa002.jf.intel.com with ESMTP; 23 Jun 2024 02:32:31 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , stable@vger.kernel.org, Jason Chen Subject: [PATCH 3/6] mei: vsc: Enhance SPI transfer of IVSC rom Date: Sun, 23 Jun 2024 17:30:53 +0800 Message-Id: <20240623093056.4169438-4-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240623093056.4169438-1-wentong.wu@intel.com> References: <20240623093056.4169438-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Constructing the SPI transfer command as per the specific request. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Cc: stable@vger.kernel.org # for 6.8+ Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/misc/mei/vsc-tp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index 4595b1a25536..7a89e4e5d553 100644 --- a/drivers/misc/mei/vsc-tp.c +++ b/drivers/misc/mei/vsc-tp.c @@ -331,7 +331,7 @@ int vsc_tp_rom_xfer(struct vsc_tp *tp, const void *obuf= , void *ibuf, size_t len) return ret; } =20 - ret =3D vsc_tp_dev_xfer(tp, tp->tx_buf, tp->rx_buf, len); + ret =3D vsc_tp_dev_xfer(tp, tp->tx_buf, ibuf ? tp->rx_buf : ibuf, len); if (ret) return ret; =20 --=20 2.34.1 From nobody Tue Dec 16 19:42:23 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E58282C76; Sun, 23 Jun 2024 09:32:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719135163; cv=none; b=YnzjA3Chp2UG4S4bwzlpklUCetCYKr3bNaXMuMhZUFCoHWt+ORg2zG/LELkqYU9PP48Hz03mP8yMhTD6J5W0GXWGs/FapYyFKeHRaNPGuLM4NgXrbga4SbgKpw92+t4BH0hBqeD9qstk5josTPTWSb2CssfXRUQJWmHYZtsCRTc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719135163; c=relaxed/simple; bh=cEeXCxkP09Nlfke0tgRhA43h1ZuuPItJ3/CFcKSQk+k=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=niWBzPJJjtDDztIuFIVMv+LvxKXndTM7MzXoFnOLllHJm9HzJ43YPyt3cfPenLzjP5XsHXM2VG7Rr61/jmtwX5I4GbH0y1/JEaMDEJS30WRiQps3NseB8wn5jXN8BxCKe622apvM9fZB6nZxnguInTm7SGgFRCqMtUKGhY4i7RA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fSWWOgLq; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fSWWOgLq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719135162; x=1750671162; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cEeXCxkP09Nlfke0tgRhA43h1ZuuPItJ3/CFcKSQk+k=; b=fSWWOgLqlYb752eXZzrVqoKnPWQhkYnj4g+ON2jCpffeg3KIoy4XvCHV cRCS6DdGebvtcfZICKsXi2ki/n3nvbzuttFsP/2glmVyXbT3pAkgqhmcM 8RBPos3xhjYmy63O8OFbPCJYgz8lv8dEWtZEWJ0bcPP5TpXk/ZvlZkhXP tg8a+bHky4FOeiPM6gEe5/vh9Wr5HcftEJkk+5k3lV4Y21BJ0LFmoFIPp z8IpjIOAcc+oiS0SWkmEHhXO0KMWrdlNUn0Kaa0pdC7m7hQMSMhTV6WH5 g3RDthpZAKjgO79QnvTDs0JlmwHZ3p5Tf0vBVTt3nmDkdRLit+umU2biw Q==; X-CSE-ConnectionGUID: zzt0KeJTSzy1C6+y4NEvVA== X-CSE-MsgGUID: XzN+xNHqQiOog/RIkdnkzA== X-IronPort-AV: E=McAfee;i="6700,10204,11111"; a="16089095" X-IronPort-AV: E=Sophos;i="6.08,259,1712646000"; d="scan'208";a="16089095" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2024 02:32:41 -0700 X-CSE-ConnectionGUID: /ERllLhMR8+qRP/BuBTf2w== X-CSE-MsgGUID: 2LMqLRu/TQKZ5B4O00P6PQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,259,1712646000"; d="scan'208";a="73761747" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by orviesa002.jf.intel.com with ESMTP; 23 Jun 2024 02:32:40 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , stable@vger.kernel.org, Jason Chen Subject: [PATCH 4/6] mei: vsc: Utilize the appropriate byte order swap function Date: Sun, 23 Jun 2024 17:30:54 +0800 Message-Id: <20240623093056.4169438-5-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240623093056.4169438-1-wentong.wu@intel.com> References: <20240623093056.4169438-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Switch from cpu_to_be32_array() to be32_to_cpu_array() for the received rom data. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Cc: stable@vger.kernel.org # for 6.8+ Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/misc/mei/vsc-tp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index 7a89e4e5d553..381d7ba4f98a 100644 --- a/drivers/misc/mei/vsc-tp.c +++ b/drivers/misc/mei/vsc-tp.c @@ -336,7 +336,7 @@ int vsc_tp_rom_xfer(struct vsc_tp *tp, const void *obuf= , void *ibuf, size_t len) return ret; =20 if (ibuf) - cpu_to_be32_array(ibuf, tp->rx_buf, words); + be32_to_cpu_array(ibuf, tp->rx_buf, words); =20 return ret; } --=20 2.34.1 From nobody Tue Dec 16 19:42:23 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9952912E1CE; Sun, 23 Jun 2024 09:32:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719135166; cv=none; b=OnH2OeCnavjgs7/9/1s/0oXTXHleSC2nWE673EUo/duoGgQeHA5METBfug9B+CQRbxqGMeFxbwlDirKJsxI9OvW7DGfs0eZ8PIfJpgBwx4ATSgyUtDobfWaWNtv/kfqs8C2s6xHx5f6YYOZVOukghHFkw/JPi99HUI7yrTxw8m8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719135166; c=relaxed/simple; bh=JM1sD9QP4RyHSPhRqlUabkVUXwe0DuYqN6xM1zvvobw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=k4HrI6yKZI1KDml9jkqIhQEzVhB/YEAnmFSCV0Aoy1w/GYeM9wR6gPAVfd3C0gN7Cb0p2V0YOesCt+mC0HOJiU+NoFbx3eqnt7aaLnIj6bdF3LR1Pn8+vCaCvz/BM8eeZ9FdyU36CRMxCBrqxiC+3KfuipkNufFfXkU0wC+nYSw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=h9xdMbrj; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="h9xdMbrj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719135164; x=1750671164; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JM1sD9QP4RyHSPhRqlUabkVUXwe0DuYqN6xM1zvvobw=; b=h9xdMbrjV2k3RJx/2j8wlokYqibL1JMJfGLt0z0U7kDxUHMvGTQ0VKxI a9iesIwT6GEzldDo/dQonx6rdg/zFj98IN/og6IQSp8PLPIMQ7hI8zNJ7 sUY08yctto1X/R83IsjDBtK6NhJpStXYB6tsneSLMWC+XqbfLJtU+pan0 Bddkj7SzOeDcVMN8aYS11JXkfUDm6Yy/9lHKgeN88ECKzfOoCSBBoXEbg r4q8HwnzkQqIaLFgVqk9JNiRLgf5p4zNZLN29HkCeJOy/poGMmDDH1iUK UYKzZSByqz+sNquXhh7ET3lloamIsc/NXPZrbutPXGNDEwPN/1JRtOA0V w==; X-CSE-ConnectionGUID: FqoXEs9gS2utdn/Ndwmktg== X-CSE-MsgGUID: tFaomdIiRnytyI+oQ4UuSg== X-IronPort-AV: E=McAfee;i="6700,10204,11111"; a="16089098" X-IronPort-AV: E=Sophos;i="6.08,259,1712646000"; d="scan'208";a="16089098" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2024 02:32:44 -0700 X-CSE-ConnectionGUID: wCZye3qESUy0kwHa2b+nxQ== X-CSE-MsgGUID: SUUb/IcfTy6jTTz8eKuVFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,259,1712646000"; d="scan'208";a="73761754" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by orviesa002.jf.intel.com with ESMTP; 23 Jun 2024 02:32:43 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , stable@vger.kernel.org, Jason Chen Subject: [PATCH 5/6] mei: vsc: Prevent timeout error with added delay post-firmware download Date: Sun, 23 Jun 2024 17:30:55 +0800 Message-Id: <20240623093056.4169438-6-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240623093056.4169438-1-wentong.wu@intel.com> References: <20240623093056.4169438-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After completing the firmware download, the firmware requires some time to become functional. This change introduces additional sleep time before the first read operation to prevent a confusing timeout error in vsc_tp_xfer(). Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Cc: stable@vger.kernel.org # for 6.8+ Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/misc/mei/platform-vsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mei/platform-vsc.c b/drivers/misc/mei/platform-vs= c.c index 1ec65d87488a..d02f6e881139 100644 --- a/drivers/misc/mei/platform-vsc.c +++ b/drivers/misc/mei/platform-vsc.c @@ -28,8 +28,8 @@ =20 #define MEI_VSC_MAX_MSG_SIZE 512 =20 -#define MEI_VSC_POLL_DELAY_US (50 * USEC_PER_MSEC) -#define MEI_VSC_POLL_TIMEOUT_US (200 * USEC_PER_MSEC) +#define MEI_VSC_POLL_DELAY_US (100 * USEC_PER_MSEC) +#define MEI_VSC_POLL_TIMEOUT_US (400 * USEC_PER_MSEC) =20 #define mei_dev_to_vsc_hw(dev) ((struct mei_vsc_hw *)((dev)->hw)) =20 --=20 2.34.1 From nobody Tue Dec 16 19:42:23 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A03D612FB0B; Sun, 23 Jun 2024 09:32:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719135169; cv=none; b=BI+I32e6uPQrRMjuHsRyEPAdwTTJaan/CG5dlHhydZWM2why/sfqeqfb0L/i60DqhGHItIx4dKnxHJ87qlopL0l5VSc0PO+6sLL4yqDUdr4PyXKR3iO0t13utyN5nv+prPX/hjGnUPwSI/JLYhK06O8v3cGi/oxSFnW47vQuJqM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719135169; c=relaxed/simple; bh=qTMPWsu7YkfJAzlZHprziJZbdGJsTuC7Lk0WAHlkJxc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kpWpWdqYXXBwfLc71AHdz7BJfN1uxRlcs/sS1M5qSsCCxlEQIgtAtuIN74r7RuFwHczl7yOENkp682i8yHpBm37OmWVlMsgY5sP8xvcNNdcEdsOOEH2AxsA5xooD2H9kMHoTmwWfhirWlOmY6+rO0MGERPeqzR7bR5yqlyjiKQA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hY8P5ew4; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hY8P5ew4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719135167; x=1750671167; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qTMPWsu7YkfJAzlZHprziJZbdGJsTuC7Lk0WAHlkJxc=; b=hY8P5ew4ricWVO0nOlGmq7U0/jPtCRiMu6LmwNcJuWntiYxeOiZOmzME ySdLdnC0RIEbrDpRzSiAHJHpqbLL9ijCOg8e8uLONwxT9X/GHYhSavNiW K9Qcx6hJh2KdeVGDqhOMc5Ym1Ap7PCNhiZN6MsOAtpvefC74pq0zrERPC RZcYRCa8YAA3xpZCHZqYrcxqWi51WcUA9zJAS5qQyMNPl8sIukPjLgppm X3d0q+jTZJyvQgMkrOLSF5ymEi3fyq7J76qU96Z6glbHNimhaElfHt4cw BHK+tnJpdPcDAjSYpsftPs1aRLd/DjHRjLY13VXl8RItPnbdEmjnWN5t0 A==; X-CSE-ConnectionGUID: 9cQ7nr0iRMOARSd9cZoimQ== X-CSE-MsgGUID: 95p+SxW6RfmIYSACAitdPw== X-IronPort-AV: E=McAfee;i="6700,10204,11111"; a="16089102" X-IronPort-AV: E=Sophos;i="6.08,259,1712646000"; d="scan'208";a="16089102" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2024 02:32:47 -0700 X-CSE-ConnectionGUID: 4iRWJGYiQKuYIlgF3Orcag== X-CSE-MsgGUID: 7Nl+VDi5Sy63vc3skNEwow== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,259,1712646000"; d="scan'208";a="73761761" Received: from wentongw-optiplex-7000.sh.intel.com ([10.239.154.127]) by orviesa002.jf.intel.com with ESMTP; 23 Jun 2024 02:32:46 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, tomas.winkler@intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wentong Wu , stable@vger.kernel.org, Jason Chen Subject: [PATCH 6/6] mei: vsc: Fix spelling error Date: Sun, 23 Jun 2024 17:30:56 +0800 Message-Id: <20240623093056.4169438-7-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240623093056.4169438-1-wentong.wu@intel.com> References: <20240623093056.4169438-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix a spelling error in a comment. Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") Cc: stable@vger.kernel.org # for 6.8+ Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/misc/mei/vsc-fw-loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/vsc-fw-loader.c b/drivers/misc/mei/vsc-fw-loa= der.c index 596a9d695dfc..084d0205f97d 100644 --- a/drivers/misc/mei/vsc-fw-loader.c +++ b/drivers/misc/mei/vsc-fw-loader.c @@ -204,7 +204,7 @@ struct vsc_img_frag { =20 /** * struct vsc_fw_loader - represent vsc firmware loader - * @dev: device used to request fimware + * @dev: device used to request firmware * @tp: transport layer used with the firmware loader * @csi: CSI image * @ace: ACE image --=20 2.34.1