From nobody Mon Feb 9 13:32:37 2026 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77279DF60 for ; Sun, 23 Jun 2024 05:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719121223; cv=none; b=Vv3Vny2+mSiCv+vS2vOL1xl1HjOxYYvMpUY1uuxeVnH8jSkQiLXgvQem8EBHY3cPWpsr4ehKc1tGEpJf2FkZm0kEBYdkqcTjos2T/DHFD8NNuu0jixJ3FcGLEEcRje+CxqyESkUCW4L/K7rzlpeqMXHXyXSZ+LmT9OUDQk3sM80= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719121223; c=relaxed/simple; bh=3yTmp3Sv/j769E4v8X1gSQqZKrDdcZgB/xdp5LC/6x4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KD15f2REDcGQH3vCJSTcfb8z8LVaqCKzm5chP5WPcFYJ0DY40S5R8YjUKOejfFmgTiiwUD33W0B/LzOzdPvsb6cac9bp22w6krgQcxTrYyKA+HPSwlLeb9lzJ5LbUx1g+3CyLA+uz6iLVxAoj/UenB2Od4vdh4AeKcTInKnmauo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rExk3ToI; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rExk3ToI" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52cd8897c73so1971099e87.2 for ; Sat, 22 Jun 2024 22:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719121219; x=1719726019; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aNgtctpFaOvFe0yQEbHzPg2VSnmgptJ1G0644gEqPQQ=; b=rExk3ToIuRbcQsZxNV7NIW7Ivf9ilc+3YVHzwjr1RnsZpv30UyGAsPgoXyj4f/dW41 0jvKgPJAYj2YnIWQLeVZ51GT58kjXW0PLJ8NTXDIWuV7CTG/ml8F9PFoAKbSsBQbLZEj f67jEHojqXzLtr0F/sPjGED8Hn8K0NOA3T1T6KNH7dYnoVC3zZEgIwPUcGM23F9DJxi2 2CjbBwB3eK/KI7D0X4kwZ49COYWmpdHvoeyoPiiPo65fQvvNKCTdgtC8vWSJbsqSeCxR WRN6azRNJ7KJtLdqbK1PPNm5ljMhVjwr2dACX3Z6aYlSQ/kSoqzPrJt7BiVn5hhRGzCB 1Byg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719121219; x=1719726019; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aNgtctpFaOvFe0yQEbHzPg2VSnmgptJ1G0644gEqPQQ=; b=r8g7hscC09HcSS+uYH5QOkLSrp3PAko1L9crjcSLfGsGIHV4xSnfKakws7SD7nM0vR ceV0/NRkFqVqzcDjT4lObgxYSrz0nA8WLxazDWQHXjN4WEg+K8J+334BZgGSiTnrLBl3 jrAuOMpfUevXY6L1srzhjOUgKiILEHH/29hXTJto5WmxocvlUXXHN3LU//3iFJH5M290 G9uX7E2kZFiu/EQN7MdcY5/ZwTPOGWK9OeiI6lpVJ01lLjnSz1cfYKgKM95n3AKlOpqI 2qaLyhNkxM4jvVyu7EiYIgpByaT0VtOFDyWCs1T+ELePQJeluO+qCU/sClVNw1Bk1snp umHQ== X-Forwarded-Encrypted: i=1; AJvYcCUHMHtpY0jg17TaLRn/TO1g9GNwBe3I/8LuQYQGYFaOTtgo+Z9UhJiswRac8wgYskW2xcLMda4qeFxWov94SXghaGK4/dsDz0IxMgAa X-Gm-Message-State: AOJu0Yx8vWvxjJNGc1NrtQ+FKvcWxa8HnFiBmqnTe1gORd9Bnebd70oM AsO8YVSVJsUmYGC6BAG21J3qnWTGaOi7sJ5119EnMdFHtdJrxMKd+1srDR7FutM= X-Google-Smtp-Source: AGHT+IFuCPUyL+zRFxa1v0tcKCSI3+LoANHXMylFFQW3d9q4jeiaePhHRqSnp/6uBUz1C9TF9/I1Rg== X-Received: by 2002:a05:6512:31d2:b0:52c:e3bd:c708 with SMTP id 2adb3069b0e04-52ce3bdc757mr436609e87.10.1719121219460; Sat, 22 Jun 2024 22:40:19 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52cd63bcd32sm659696e87.65.2024.06.22.22.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jun 2024 22:40:19 -0700 (PDT) From: Dmitry Baryshkov Date: Sun, 23 Jun 2024 08:40:12 +0300 Subject: [PATCH v2 1/2] drm/bridge-connector: reset the HDMI connector state Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240623-drm-bridge-connector-fix-hdmi-reset-v2-1-8590d44912ce@linaro.org> References: <20240623-drm-bridge-connector-fix-hdmi-reset-v2-0-8590d44912ce@linaro.org> In-Reply-To: <20240623-drm-bridge-connector-fix-hdmi-reset-v2-0-8590d44912ce@linaro.org> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Dave Stevenson Cc: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=6433; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=3yTmp3Sv/j769E4v8X1gSQqZKrDdcZgB/xdp5LC/6x4=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmd7VBENNTf284nWcQLh19OCMqf5IH1l5DhmmVZ yDrtAtWhEiJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZne1QQAKCRCLPIo+Aiko 1U8hB/9SdkyyQg2swP/hpd6sqcRQmN44V1uzQeeeLir0Z86HYX6cpVuiZZKhFO2c2rLP45ryy/i A5Xl2EAGhcZ3l1uEjXG7Jflm09qnZQwT0zDkgtgjIAaVd+8IeqKyPhtKCY52+Qta66/wCZitg5y Gtz+GGfdKbUtakJIgpe77KynIp8mIS0/lL28/oNnnCidrAF9/PWCxnYcv4TPkDXJftSF6c9pder hzJPbmXZfku9q60/SPFe4SZ9AIucQuYC7UiFXcvvCEDszVItrKJfcgUpvH0xcHuEdhHxu28LQRd op8kCK69QUiDJfHyliwKoF9Q9TY/SexvsU6snm1xFS5RBrg2 X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A On HDMI connectors which use drm_bridge_connector and DRM_BRIDGE_OP_HDMI IGT chokes on the max_bpc property in several kms_properties tests due to the the drm_bridge_connector failing to reset HDMI-related properties. Call __drm_atomic_helper_connector_hdmi_reset() if there is a the drm_bridge_connector has bridge_hdmi. Note, the __drm_atomic_helper_connector_hdmi_reset() is moved to drm_atomic_state_helper.c because drm_bridge_connector.c can not depend on DRM_DISPLAY_HDMI_STATE_HELPER. At the same time it is impossible to call this function from HDMI bridges, there is is no function that corresponds to the drm_connector_funcs::reset(). Fixes: 6b4468b0c6ba ("drm/bridge-connector: implement glue code for HDMI co= nnector") Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 21 --------------------- drivers/gpu/drm/drm_atomic_state_helper.c | 21 +++++++++++++++++++++ drivers/gpu/drm/drm_bridge_connector.c | 13 ++++++++++++- include/drm/display/drm_hdmi_state_helper.h | 3 --- include/drm/drm_atomic_state_helper.h | 2 ++ 5 files changed, 35 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/display/drm_hdmi_state_helper.c b/drivers/gpu/= drm/display/drm_hdmi_state_helper.c index 2dab3ad8ce64..67f39857b0b4 100644 --- a/drivers/gpu/drm/display/drm_hdmi_state_helper.c +++ b/drivers/gpu/drm/display/drm_hdmi_state_helper.c @@ -8,27 +8,6 @@ #include #include =20 -/** - * __drm_atomic_helper_connector_hdmi_reset() - Initializes all HDMI @drm_= connector_state resources - * @connector: DRM connector - * @new_conn_state: connector state to reset - * - * Initializes all HDMI resources from a @drm_connector_state without - * actually allocating it. This is useful for HDMI drivers, in - * combination with __drm_atomic_helper_connector_reset() or - * drm_atomic_helper_connector_reset(). - */ -void __drm_atomic_helper_connector_hdmi_reset(struct drm_connector *connec= tor, - struct drm_connector_state *new_conn_state) -{ - unsigned int max_bpc =3D connector->max_bpc; - - new_conn_state->max_bpc =3D max_bpc; - new_conn_state->max_requested_bpc =3D max_bpc; - new_conn_state->hdmi.broadcast_rgb =3D DRM_HDMI_BROADCAST_RGB_AUTO; -} -EXPORT_SYMBOL(__drm_atomic_helper_connector_hdmi_reset); - static const struct drm_display_mode * connector_state_get_mode(const struct drm_connector_state *conn_state) { diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/dr= m_atomic_state_helper.c index 519228eb1095..1518ada81b45 100644 --- a/drivers/gpu/drm/drm_atomic_state_helper.c +++ b/drivers/gpu/drm/drm_atomic_state_helper.c @@ -478,6 +478,27 @@ void drm_atomic_helper_connector_reset(struct drm_conn= ector *connector) } EXPORT_SYMBOL(drm_atomic_helper_connector_reset); =20 +/** + * __drm_atomic_helper_connector_hdmi_reset() - Initializes all HDMI @drm_= connector_state resources + * @connector: DRM connector + * @new_conn_state: connector state to reset + * + * Initializes all HDMI resources from a @drm_connector_state without + * actually allocating it. This is useful for HDMI drivers, in + * combination with __drm_atomic_helper_connector_reset() or + * drm_atomic_helper_connector_reset(). + */ +void __drm_atomic_helper_connector_hdmi_reset(struct drm_connector *connec= tor, + struct drm_connector_state *new_conn_state) +{ + unsigned int max_bpc =3D connector->max_bpc; + + new_conn_state->max_bpc =3D max_bpc; + new_conn_state->max_requested_bpc =3D max_bpc; + new_conn_state->hdmi.broadcast_rgb =3D DRM_HDMI_BROADCAST_RGB_AUTO; +} +EXPORT_SYMBOL(__drm_atomic_helper_connector_hdmi_reset); + /** * drm_atomic_helper_connector_tv_margins_reset - Resets TV connector prop= erties * @connector: DRM connector diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_b= ridge_connector.c index 0869b663f17e..7ebb35438459 100644 --- a/drivers/gpu/drm/drm_bridge_connector.c +++ b/drivers/gpu/drm/drm_bridge_connector.c @@ -216,8 +216,19 @@ static void drm_bridge_connector_debugfs_init(struct d= rm_connector *connector, } } =20 +static void drm_bridge_connector_reset(struct drm_connector *connector) +{ + struct drm_bridge_connector *bridge_connector =3D + to_drm_bridge_connector(connector); + + drm_atomic_helper_connector_reset(connector); + if (bridge_connector->bridge_hdmi) + __drm_atomic_helper_connector_hdmi_reset(connector, + connector->state); +} + static const struct drm_connector_funcs drm_bridge_connector_funcs =3D { - .reset =3D drm_atomic_helper_connector_reset, + .reset =3D drm_bridge_connector_reset, .detect =3D drm_bridge_connector_detect, .fill_modes =3D drm_helper_probe_single_connector_modes, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, diff --git a/include/drm/display/drm_hdmi_state_helper.h b/include/drm/disp= lay/drm_hdmi_state_helper.h index 285f366cf716..454319b40f17 100644 --- a/include/drm/display/drm_hdmi_state_helper.h +++ b/include/drm/display/drm_hdmi_state_helper.h @@ -8,9 +8,6 @@ struct drm_connector; struct drm_connector_state; struct hdmi_audio_infoframe; =20 -void __drm_atomic_helper_connector_hdmi_reset(struct drm_connector *connec= tor, - struct drm_connector_state *new_conn_state); - int drm_atomic_helper_connector_hdmi_check(struct drm_connector *connector, struct drm_atomic_state *state); =20 diff --git a/include/drm/drm_atomic_state_helper.h b/include/drm/drm_atomic= _state_helper.h index b9740edb2658..adf300e6b4eb 100644 --- a/include/drm/drm_atomic_state_helper.h +++ b/include/drm/drm_atomic_state_helper.h @@ -71,6 +71,8 @@ void __drm_atomic_helper_connector_state_reset(struct drm= _connector_state *conn_ void __drm_atomic_helper_connector_reset(struct drm_connector *connector, struct drm_connector_state *conn_state); void drm_atomic_helper_connector_reset(struct drm_connector *connector); +void __drm_atomic_helper_connector_hdmi_reset(struct drm_connector *connec= tor, + struct drm_connector_state *new_conn_state); void drm_atomic_helper_connector_tv_reset(struct drm_connector *connector); int drm_atomic_helper_connector_tv_check(struct drm_connector *connector, struct drm_atomic_state *state); --=20 2.39.2 From nobody Mon Feb 9 13:32:37 2026 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8B4B16419 for ; Sun, 23 Jun 2024 05:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719121223; cv=none; b=eeQB0uSxajYfRW6gZ5CDdRxXBHI6dhcGKr9UcmyFo+GLGLPIWHAm5xsIAh/E0Mx8e3hIZbCguHdPwso9TdSJqTX5YGBG1KlPJ9SKWNWT9yt6MjR1YU9Walj2D7sJwn2Zlu1zf/DDjMteQuI/rFb5GeaADoqJXmMy5GukREkg3eI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719121223; c=relaxed/simple; bh=Ogj1qgSBFy5LiaMGrph8HSRVcootU6FeEO747BTFj9E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YjrgKO6BDwULS9+iDsN0N/ZzxFeKijayWTcNRbEJDud2PdZ+LVz6fmCFHo3rhQRNOR/9uoz/CPhfdZa4X9nIyO0uBfTfvobS1HQPi3KeSUPCk0goqJxCTUYB5b9SaFkBs0x0wWlHkXEJZXkHGSY7VF72mvvW0VKsJ9JAqYlgkr0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Ch+vl/ba; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ch+vl/ba" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-52ce0140416so641657e87.0 for ; Sat, 22 Jun 2024 22:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719121220; x=1719726020; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hbJUOmvW24quAtGM4HEWCKTnos6XbtfhPM+nK5+e2Tw=; b=Ch+vl/baHE7qh8a1FrDSVMd7BPF6WvPa2cVJGz7Ei6loeoGLd76Z9nrkFrUxDOisuB K+pUEIp1WZiDYqXSUHeq5uRGut297Es9ylz9YEaeJ60SOLbCcv9uxs8ftaJq0rOPG6Kl D4pQJtMiyzqTnB6sV+VhNOD7Zxqu6efyc8SUXtsxvjnE3MK0NtmebjATBKwAYQHqAGUP Cas5Z9tyL7ohHZzehWqjQZ4xY3Oc+/TSuP47FHHTS/H8IzGQ8YL6EZR8K0Qz3h6TQgjv vUzNRHkBOUuBv+nhTCARq47FMvryhUDHIBe/aFGzOsL1qUhrEvwR1ltEcioG2J/dvlg1 kBDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719121220; x=1719726020; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hbJUOmvW24quAtGM4HEWCKTnos6XbtfhPM+nK5+e2Tw=; b=uYGu8F2VMs9kIKYHZ0+KAOKSgfbu/uDiJDdZDVLJzTVU/VsHbsYR1b4ybmAuPZw4iK oEuGtiIQ1IVhZXPdONjpT6U2VW2YNEUeXd3/p6itSvKi2FCKaKiCOA4D1kz1zP0fbW9T Go+fsFkaycxuZysQJJ0zE+7D+xNIDMfYdD0Hk9D6D1q/8POMY0YxENltEMA2IgDNBjvq mwdRsxGNeHMr7jO/KY1GE3wMDRpuvYvTYp88+U+r9psPFef60pL1JIyzewUobG2j1MyN jO+PAxMw4eheYzeuMZNcYjHTFKIsB0K9wGOdDmXWiP+cUEG5IBMI/0GNB3SoZ9fs30yv aWxw== X-Forwarded-Encrypted: i=1; AJvYcCWINMGJkSEpdnud/NQSWRIV1GIee7c9GJpghKFGZph6Yt9dsfTyG+0G1+HkbLCYtirJ9l5/ckes/4imZU7mA5V2c/Sg6H/qTuoMWWuv X-Gm-Message-State: AOJu0YySLMtNGP6OOsWB24FnCE9X17ZFFY7U2M25KVMwv2pNN6G96RMk dN9/nuWmEfZINxSDkPIF1UAAweop+TeGjg+nOPNhxyHey5Wg4iOBFJckzkyEsHI= X-Google-Smtp-Source: AGHT+IFhjib/1suTVLnNKOG4CvpqSohWo8V1ebgg4ZYt51DXitjlM8EQ+GXNkC1wy0zWx1GrQbZ0kA== X-Received: by 2002:a05:6512:348c:b0:52c:86d7:fa62 with SMTP id 2adb3069b0e04-52ce061b1femr1263685e87.23.1719121220118; Sat, 22 Jun 2024 22:40:20 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52cd63bcd32sm659696e87.65.2024.06.22.22.40.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jun 2024 22:40:19 -0700 (PDT) From: Dmitry Baryshkov Date: Sun, 23 Jun 2024 08:40:13 +0300 Subject: [PATCH v2 2/2] drm/connector: automatically set immutable flag for max_bpc property Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240623-drm-bridge-connector-fix-hdmi-reset-v2-2-8590d44912ce@linaro.org> References: <20240623-drm-bridge-connector-fix-hdmi-reset-v2-0-8590d44912ce@linaro.org> In-Reply-To: <20240623-drm-bridge-connector-fix-hdmi-reset-v2-0-8590d44912ce@linaro.org> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Dave Stevenson Cc: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1164; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=Ogj1qgSBFy5LiaMGrph8HSRVcootU6FeEO747BTFj9E=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmd7VC9k3OnQtTnxxxl8WBd8EP07ZwSvEfxe83x 9mlVUBtvXWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZne1QgAKCRCLPIo+Aiko 1ZulB/9VGOjTN5uHSczSZCl5LY1tDsEZ8ElrPoAzIIMyxJpYuHzDj1DEP2L3SeTXmv3wCOuwzTc 6bNUkw9AdXzeLJ/IGR/Xk+V/XA9lDA5rBPuJkdSCdWaHur06DeHT8KOxFv7G0NLTl6T5MU7yptb wQGBL+gk8cC92DjyVWJdKinJm5xjogNa/2cR8nHAa2PjDuQVFDRfgLs9rWbq4srehFPnwVIxIUa oxspq1UPaQ+j1MCtZHSzIdBfaVt8ZCP+d7c8ygH59JccJ/3jw1oACd1hGJMXkpneuj7uqb5DblK 9wKM9mnJISq4t243XjfYVTg4SbCN4fWKN4q+6IxUytONLpQj X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A With the introduction of the HDMI Connector framework the driver might end up creating the max_bpc property with min =3D max =3D 8. IGT insists that such properties carry the 'immutable' flag. Automatically set the flag if the driver asks for the max_bpc property with min =3D=3D max. Fixes: aadb3e16b8f3 ("drm/connector: hdmi: Add output BPC to the connector = state") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_connector.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connecto= r.c index ab6ab7ff7ea8..33847fd63628 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -2610,7 +2610,12 @@ int drm_connector_attach_max_bpc_property(struct drm= _connector *connector, =20 prop =3D connector->max_bpc_property; if (!prop) { - prop =3D drm_property_create_range(dev, 0, "max bpc", min, max); + u32 flags =3D 0; + + if (min =3D=3D max) + flags |=3D DRM_MODE_PROP_IMMUTABLE; + + prop =3D drm_property_create_range(dev, flags, "max bpc", min, max); if (!prop) return -ENOMEM; =20 --=20 2.39.2