From nobody Wed Dec 17 12:17:03 2025 Received: from cstnet.cn (smtp84.cstnet.cn [159.226.251.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E2B92B2CC for ; Sat, 22 Jun 2024 07:25:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719041157; cv=none; b=txE+5GauEvukA4lDQGPfENNfY1kJPoC/zstqfyjXAgCRXiL7EAIsk7KbrGL0gZTLNsbNmlUHg72ugFJaFOTGRIKUBo/aJrEeiBLuOOsj9Kl8GObEvXh4fN+Xz857vWUSN4BzcxPA1bDd33JCw3CYXb9077SanYLHqlbEFP2RZ3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719041157; c=relaxed/simple; bh=POw0L6WU3HDCeFD5/vqIYSJyCIJr/xX0Tg4Od6INzCA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=f3oEZZ4vE5BglHZPmOym32uPoMVR7z0HyOaj5dGCZENgtHtRsH+wzV4PoFP9U5q7c3Kp4apFQir03o0S+T87bCAiAusV0OILjd4g88M2KMa4dGo3AewyKy0IMraU/LgZszynEw1Ckk60VQZWc+UomAUV5l8FRxaVh2CsfE80mFk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from icess-ProLiant-DL380-Gen10.. (unknown [183.174.60.14]) by APP-05 (Coremail) with SMTP id zQCowACHLRBbfHZmVukYEg--.47408S2; Sat, 22 Jun 2024 15:25:30 +0800 (CST) From: Ma Ke To: patrik.r.jakobsson@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ma Ke Subject: [PATCH] drm/gma500: fix a possible null pointer dereference Date: Sat, 22 Jun 2024 15:25:14 +0800 Message-Id: <20240622072514.1867582-1-make24@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowACHLRBbfHZmVukYEg--.47408S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtF1rZr4fAF47WFykZF48Xrb_yoWfurX_GF 18ZrnrCrZ8u3Z3ur4Ivw45Cr90yF10va1kWr13Ka4fAwnrAr15X342gFy5ZFyxZ3W8W3yD Ja4j9FyrAFs7CjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb4kFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6r1j6r18M7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Jr0_ Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr 0_Cr1UM2vYz4IE04k24VAvwVAKI4IrM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVAC Y4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJV W8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI2 0VAGYxC7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrV AFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCI c40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267 AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_ Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjfUOlksUU UUU X-CM-SenderInfo: ppdnvj2u6l2u1dvotugofq/ Content-Type: text/plain; charset="utf-8" In cdv_intel_lvds_get_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Signed-off-by: Ma Ke --- drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/gma500/cdv_intel_lvds.c b/drivers/gpu/drm/gma5= 00/cdv_intel_lvds.c index f08a6803dc18..69b8c0fd6063 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_lvds.c +++ b/drivers/gpu/drm/gma500/cdv_intel_lvds.c @@ -311,6 +311,8 @@ static int cdv_intel_lvds_get_modes(struct drm_connecto= r *connector) if (mode_dev->panel_fixed_mode !=3D NULL) { struct drm_display_mode *mode =3D drm_mode_duplicate(dev, mode_dev->panel_fixed_mode); + if (!mode) + return -ENOMEM; drm_mode_probed_add(connector, mode); return 1; } --=20 2.25.1