From nobody Tue Dec 16 10:52:20 2025 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4125F1607AF for ; Fri, 21 Jun 2024 21:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719004704; cv=none; b=mkaSO7GHajvljQR6C68m72MEBHW9a11y090b/i4Jq0WXx7c2FOxDSTxVWWOPxMGNNaDfUuoZGG/oDm9ra6K07ziQ0zgrLLSs270ja7SLn0Et6P5L/PgIEMhZ9r9Z2JwWbXsQ1kFrmqeXs+sk5cQcQkyJduUq5vBa7SJsL+9A274= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719004704; c=relaxed/simple; bh=B+G9QtsD7C2Jc3sDzbUlvXmN736PbhSU6BpyDPCIla8=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=E+BohqGCeschvsMSr96g7/9rz+WD7gnKmtsn+YZEWqCMLjaLo175DFSYjACuztLiMetQy1z7bXGiZJOW8V3xsTL4UpyFAAUB2OeZ5B00X+P22EglVwzOPlH2MmxC5cVoDRTww6OM0VZ3MEkMcYWuAnBeSgpjlG4eaRhdQkRHwhk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--yabinc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=N/WNm3vc; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--yabinc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="N/WNm3vc" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-63c88ec6b76so42352637b3.2 for ; Fri, 21 Jun 2024 14:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719004702; x=1719609502; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=lEa6AhAPPJv6m60+8usBRJvGW03PUOWIeiJHHFIJ3k4=; b=N/WNm3vc9n+ujg5+G3tuA6wnC+rytZnaoKChCEU/abyVu+pn0dpxyQ93GWS8AIlYkL IdU/D2L6j77bwcalfAGbYvc+xDCTakNN1bgI2dQvbzU2Yf8djU6I/6tBmWSFC90K5Ic+ 2OVolDin1HWx/FwdWKvnr3FgUDul0rKxv6kOGV3fHk2Hk8xam2dMw8cFdZ6QJV2nm+ej irTCTNsSoTrp2rxUhujFCpMKcwYy1LjWsgpKpmotHM6A/cO4pzYK639ygXZ6UsjUusHE +CByxlUWiVcnS3wVWowobRRVnHfzAaOkrJOaC06D9tmur94uPa7AsYzfEOaCHbvHTFOQ klhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719004702; x=1719609502; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=lEa6AhAPPJv6m60+8usBRJvGW03PUOWIeiJHHFIJ3k4=; b=is0rjxCBbe8UWFUUrPoHi1L4pXXmCK0JkjOVw+TKyTp0qss8oyMxAQIEZmvFPb8hb3 4vIq5GckuQpajAAkrw4kxxYAbHmMs/RAkwUiHQ5DVzv6SBygQkemAaHZLaKORH5Dzw58 eU9pabQPCUs1cllDDJJsW0LpJtkCmDn8X0IQBqzt169J4uazVr6dOZweow0CoA6UNKdm EZjPeE7a/yjkdr4Nm9T5cPAD31MBAR1ksHvkm7BbS04cJq5lAK2pWsL49hJukd870Pdv +b58HgvMVmsWNR1NQAj6GxGXfL4XSKP/wR23PpvPzK4H9fHMai8e3rLWDXQh8zOac5ZA GBCQ== X-Forwarded-Encrypted: i=1; AJvYcCUN4RCzWCDO7uAwZJrAVEfm3IHqqg96R2ABSY3awnHQb2CNyeSBTHltpkq6Qyn2JAInYaGKsbigHyDUJG6qrErO5/GRAaCb4BNYHGP1 X-Gm-Message-State: AOJu0YzC6Nk7HhLcuIxwpmGmGKsmJGnbA7Lz7XtboJS3HMCzTnetuOpZ h61fGDbBk4smMWnC4dmU4IJnYfookHxr0QsKGzaSA5a8c5UQgsFp9Cy3Pns5QeK3BCd67FfcwsS B X-Google-Smtp-Source: AGHT+IEP/2Rh6WitHSvCa6ePiTeFcXPS1z9OBz0PJKzZRVE8qWAYk4K12RXfyoLq827IauC3/poGWrv3R4c= X-Received: from yabinc-desktop.mtv.corp.google.com ([2620:15c:211:202:9257:c357:1f0c:2e57]) (user=yabinc job=sendgmr) by 2002:a05:690c:6106:b0:627:a962:4252 with SMTP id 00721157ae682-63a8faf1313mr15919837b3.7.1719004702263; Fri, 21 Jun 2024 14:18:22 -0700 (PDT) Date: Fri, 21 Jun 2024 14:18:19 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.45.2.741.gdbec12cfda-goog Message-ID: <20240621211819.1690234-1-yabinc@google.com> Subject: [PATCH v2] Fix initializing a static union variable From: Yabin Cui To: Steffen Klassert , Herbert Xu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Yabin Cui Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" saddr_wildcard is a static union variable initialized with {}. Empty brace initialization of union types is unspecified prior to C23, and even in C23, it doesn't guarantee zero initialization of all fields (see sections 4.5 and 6.2 in https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2900.htm). Clang currently only initializes the first field to zero, leaving other fields undefined. This can lead to unexpected behavior and optimizations that produce random values (with some optimization flags). See https://godbolt.org/z/hxnT1PTWo. The issue has been reported to Clang upstream ( https://github.com/llvm/llvm-project/issues/78034#issuecomment-2183233517). This commit mitigates the problem by avoiding empty brace initialization in saddr_wildcard. Fixes: 08ec9af1c062 ("xfrm: Fix xfrm_state_find() wrt. wildcard source addr= ess.") Signed-off-by: Yabin Cui Reviewed-by: Nick Desaulniers --- Changes in v2: - Update commit message to add/update links. --- net/xfrm/xfrm_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index 649bb739df0d..9bc69d703e5c 100644 --- a/net/xfrm/xfrm_state.c +++ b/net/xfrm/xfrm_state.c @@ -1139,7 +1139,7 @@ xfrm_state_find(const xfrm_address_t *daddr, const xf= rm_address_t *saddr, struct xfrm_policy *pol, int *err, unsigned short family, u32 if_id) { - static xfrm_address_t saddr_wildcard =3D { }; + static const xfrm_address_t saddr_wildcard; struct net *net =3D xp_net(pol); unsigned int h, h_wildcard; struct xfrm_state *x, *x0, *to_put; --=20 2.45.2.741.gdbec12cfda-goog