From nobody Wed Dec 17 02:53:31 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61DD2DDC4 for ; Fri, 21 Jun 2024 14:45:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718981123; cv=none; b=k8ziEoTrSMuNRP0iUHZG6ROmU4nYsPDntyKZkLAeqgDRbq/hJ2dFGB3roIIp/Mlb5Uid3KFly7R3R/dxTxyr/vRoT7U8xSTh8GvhtZF5JmUrNmWajIR/DY0MwQdEnp5oKr9B8vMUaqAOFLHlLc0GD0Mkx2xV4v8GBDyXxLRkXjQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718981123; c=relaxed/simple; bh=xvWIFuIsnsvJimvcVf8Xqx3SmW+EsVMSHqVOamqwzAU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JuOM5C6iYZ/8dBc0Ya1fCUJclrewmNuf7MnAoe2D0BitYr7KEu+3vqNbnKJIx6mOQuzgkfE0H+t1Xk++8am6IkHTa57GPB3xPofKTYmlOqZcncS3OjRZcWQwwhVGbU3sVIeDUiZiTfhLw9y1erccN9O0CtiVcllz3zmxgtRZ4RA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sKfVn-0004LC-Ea; Fri, 21 Jun 2024 16:45:11 +0200 From: Philipp Zabel Date: Fri, 21 Jun 2024 16:45:04 +0200 Subject: [PATCH RFC 3/3] reset: uniphier-glue: Use devm_reset_control_bulk_get_shared_deasserted() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240621-reset-get-deasserted-v1-3-94ee76fb7b7d@pengutronix.de> References: <20240621-reset-get-deasserted-v1-0-94ee76fb7b7d@pengutronix.de> In-Reply-To: <20240621-reset-get-deasserted-v1-0-94ee76fb7b7d@pengutronix.de> To: Kunihiko Hayashi , Masami Hiramatsu , Lad Prabhakar , Geert Uytterhoeven , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Philipp Zabel X-Mailer: b4 0.14-dev X-SA-Exim-Connect-IP: 2a0a:edc0:0:1101:1d::54 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Replace the pattern devm_reset_control_bulk_get_shared() / reset_control_bulk_deassert() / devm_add_action_or_reset() with devm_reset_control_bulk_get_shared_deasserted() for some reduction in boilerplate. Signed-off-by: Philipp Zabel --- drivers/reset/reset-uniphier-glue.c | 24 +++++------------------- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/drivers/reset/reset-uniphier-glue.c b/drivers/reset/reset-unip= hier-glue.c index 5f9f2f7994c0..a2a262bf6bfc 100644 --- a/drivers/reset/reset-uniphier-glue.c +++ b/drivers/reset/reset-uniphier-glue.c @@ -35,13 +35,6 @@ static void uniphier_clk_disable(void *_priv) clk_bulk_disable_unprepare(priv->data->nclks, priv->clk); } =20 -static void uniphier_rst_assert(void *_priv) -{ - struct uniphier_glue_reset_priv *priv =3D _priv; - - reset_control_bulk_assert(priv->data->nrsts, priv->rst); -} - static int uniphier_glue_reset_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -68,13 +61,6 @@ static int uniphier_glue_reset_probe(struct platform_dev= ice *pdev) if (ret) return ret; =20 - for (i =3D 0; i < priv->data->nrsts; i++) - priv->rst[i].id =3D priv->data->reset_names[i]; - ret =3D devm_reset_control_bulk_get_shared(dev, priv->data->nrsts, - priv->rst); - if (ret) - return ret; - ret =3D clk_bulk_prepare_enable(priv->data->nclks, priv->clk); if (ret) return ret; @@ -83,11 +69,11 @@ static int uniphier_glue_reset_probe(struct platform_de= vice *pdev) if (ret) return ret; =20 - ret =3D reset_control_bulk_deassert(priv->data->nrsts, priv->rst); - if (ret) - return ret; - - ret =3D devm_add_action_or_reset(dev, uniphier_rst_assert, priv); + for (i =3D 0; i < priv->data->nrsts; i++) + priv->rst[i].id =3D priv->data->reset_names[i]; + ret =3D devm_reset_control_bulk_get_shared_deasserted(dev, + priv->data->nrsts, + priv->rst); if (ret) return ret; =20 --=20 2.39.2