From nobody Wed Dec 17 07:26:56 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B56641AB8E5 for ; Thu, 20 Jun 2024 11:24:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718882694; cv=none; b=M0CgSD0Iyii0TW9Sa3ZD1yde+ANDeiSOpTKi7Q8S7Ac9D4Mrsvcl3ZQI6ASbVAg4DLE07rqNuW8EJlI6FcCqkt7+CU2aCL84nl/xYtX2rK7K84hl2Bjpk1GfRaipDfffbl+f8spTNS/8K5mvYa0fMwrAqSdMZw+xWD7IlILPEiY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718882694; c=relaxed/simple; bh=tW3+FRmdT+LhW6+/gh7jWAg5hDYyMsWs2xc2h3wzP84=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rQN9f0I9LRO3oEigD4fd3GEc7g3mocVPmpViwFd6DhMSb1zNSZkXW7s4sLWfG67nqsH+MQZiC0oriZHnnMQnXEuBNLJGLdmb71fl4iJ5Hmt1dOthtEjbqwScPmpaQuCmcfl9kWzwkVL9A7zysPGcgtcQy80Pf0Dh/ZdiVcgyTTc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SCCfvIGI; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SCCfvIGI" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-42189d3c7efso9578295e9.2 for ; Thu, 20 Jun 2024 04:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718882691; x=1719487491; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=987jsaZOwPOhpdxKZBmiiodJXPiBJ4LwBLho6zc60+8=; b=SCCfvIGI2xhYTyAGXPhXUywuAwrZgW3fKqO+fj7AwlSeDPalDg7AfQvPdxm/8eLHg0 Tf0fDDJ0Pu//tOH7Z4w0lH1sbbERiy3i5tpn4Iy0C1IHKcep5ldA843nxeTGysDsC3+5 9KorXIyXQV8bumGMWioNdzN22vH3AXmMBNP+hFwvQmglJGIK22Rvr9KDo0zs4SikQbao eBnmcsK84yMZHoFU7A2mIiJckAGTLWhBHq5/dxvEczAEWZ5DFpMyVAwhzU053W2x4ego buB9y457Huxiq1wUdVVSkhwkhp+cxDOWrNE17dPi8tK4Dg/30wFus/Vej/AMwf2u4Ecn v42g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718882691; x=1719487491; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=987jsaZOwPOhpdxKZBmiiodJXPiBJ4LwBLho6zc60+8=; b=a60feldI2HjF845BUqLTKW7nkdTx2SAjpW3Kp+hU5KnVyO6rPoEHMGajfpV0JBUHef r769VJXjG2NMFEzUJW/r8DkARCA1DSW4Xq7kicsiUUnuW39i1Z+sR3UZh1+T9TYpcJyI vDWRmOC7Hgl0SujmAt1R3dltpRYwDe3s0p87TVA7J9MZ2ETYk8C/8odw1M9ce+GTZO+R AoPwJcNbjgv8HBUOWVrWWxTMs4a27ROQQvFe7WNnIcA55k9hhiZHD0UjhfJ9xYB4Cf8P 3hzhrkz0ZDvHtEGzUz/zNNDxIlCxHtcmBj/5PkqH0sMlOFM64Yqv3eRLG2EcuqIdac+d LImA== X-Forwarded-Encrypted: i=1; AJvYcCWG5KoAEi4KSoEUVzcQSUCNFB5bSfl90o8ICIRZvQf4SQVPxlxHgND7SFDOGpViWcdrXBKWiERdO8BMjVMQVJcDgR0f02Hejmrt3oxA X-Gm-Message-State: AOJu0YxdjJMXdmA83LLQj58pTH2i4PCUi7gQ+sf4H9N/TsiMDmghk2df sp37iv6n8fhHCLFelFfqgujUoXW44E89mnjTwnVbrGq0pahFhuCYfcq8Gn5Bhqc= X-Google-Smtp-Source: AGHT+IEWYOFclmv+Dob4SK4leA35bYz4CV1ZSG93H0XX8NLBeMikAyl8HGO+4UJqtWZ0FffKI/BoJg== X-Received: by 2002:a05:600c:4b27:b0:423:b5f9:203f with SMTP id 5b1f17b1804b1-42475079466mr46049795e9.5.1718882690982; Thu, 20 Jun 2024 04:24:50 -0700 (PDT) Received: from gpeter-l.lan ([2a0d:3344:2e8:8510::3aa]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3647bf3092csm2025371f8f.97.2024.06.20.04.24.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 04:24:50 -0700 (PDT) From: Peter Griffin To: lee@kernel.org, arnd@arndb.de, krzk@kernel.org, alim.akhtar@samsung.com Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, semen.protsenko@linaro.org, kernel-team@android.com, Peter Griffin Subject: [PATCH v2 1/2] mfd: syscon: add of_syscon_register_regmap() API Date: Thu, 20 Jun 2024 12:24:45 +0100 Message-ID: <20240620112446.1286223-2-peter.griffin@linaro.org> X-Mailer: git-send-email 2.45.2.627.g7a2c4fd464-goog In-Reply-To: <20240620112446.1286223-1-peter.griffin@linaro.org> References: <20240620112446.1286223-1-peter.griffin@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The of_syscon_register_regmap() API allows an externally created regmap to be registered with syscon. This regmap can then be returned to client drivers using the syscon_regmap_lookup_by_phandle() APIs. The API is used by platforms where mmio access to the syscon registers is not possible, and a underlying soc driver like exynos-pmu provides a SoC specific regmap that can issue a SMC or hypervisor call to write the register. This approach keeps the SoC complexities out of syscon, but allows common drivers such as syscon-poweroff, syscon-reboot and friends that are used by many SoCs already to be re-used. Signed-off-by: Peter Griffin Reviewed-by: Arnd Bergmann Reviewed-by: Sam Protsenko --- Changes in v2: - Keep syscon lock held between checking and adding entry (Krzysztof) - Link to v1 https://lore.kernel.org/linux-arm-kernel/20240614140421.317267= 4-2-peter.griffin@linaro.org/ --- drivers/mfd/syscon.c | 54 ++++++++++++++++++++++++++++++++++++++ include/linux/mfd/syscon.h | 8 ++++++ 2 files changed, 62 insertions(+) diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c index 7d0e91164cba..75379e089b6b 100644 --- a/drivers/mfd/syscon.c +++ b/drivers/mfd/syscon.c @@ -192,6 +192,60 @@ static struct regmap *device_node_get_regmap(struct de= vice_node *np, return syscon->regmap; } =20 +/** + * of_syscon_register_regmap() - Register regmap for specified device node + * @np: Device tree node + * @regmap: Pointer to regmap object + * + * Register an externally created regmap object with syscon for the specif= ied + * device tree node. This regmap can then be returned to client drivers us= ing + * the syscon_regmap_lookup_by_phandle() API. + * + * Return: 0 on success, negative error code on failure. + */ +int of_syscon_register_regmap(struct device_node *np, struct regmap *regma= p) +{ + struct syscon *entry, *syscon =3D NULL; + int ret; + + if (!np || !regmap) + return -EINVAL; + + /* check if syscon entry already exists */ + spin_lock(&syscon_list_slock); + + list_for_each_entry(entry, &syscon_list, list) + if (entry->np =3D=3D np) { + syscon =3D entry; + break; + } + + if (syscon) { + ret =3D -EEXIST; + goto err_unlock; + } + + syscon =3D kzalloc(sizeof(*syscon), GFP_KERNEL); + if (!syscon) { + ret =3D -ENOMEM; + goto err_unlock; + } + + syscon->regmap =3D regmap; + syscon->np =3D np; + + /* register the regmap in syscon list */ + list_add_tail(&syscon->list, &syscon_list); + spin_unlock(&syscon_list_slock); + + return 0; + +err_unlock: + spin_unlock(&syscon_list_slock); + return ret; +} +EXPORT_SYMBOL_GPL(of_syscon_register_regmap); + struct regmap *device_node_to_regmap(struct device_node *np) { return device_node_get_regmap(np, false); diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h index c315903f6dab..aad9c6b50463 100644 --- a/include/linux/mfd/syscon.h +++ b/include/linux/mfd/syscon.h @@ -28,6 +28,8 @@ struct regmap *syscon_regmap_lookup_by_phandle_args(struc= t device_node *np, unsigned int *out_args); struct regmap *syscon_regmap_lookup_by_phandle_optional(struct device_node= *np, const char *property); +int of_syscon_register_regmap(struct device_node *np, + struct regmap *regmap); #else static inline struct regmap *device_node_to_regmap(struct device_node *np) { @@ -67,6 +69,12 @@ static inline struct regmap *syscon_regmap_lookup_by_pha= ndle_optional( return NULL; } =20 +static inline int of_syscon_register_regmap(struct device_node *np, + struct regmap *regmap) +{ + return -EOPNOTSUPP; +} + #endif =20 #endif /* __LINUX_MFD_SYSCON_H__ */ --=20 2.45.2.627.g7a2c4fd464-goog From nobody Wed Dec 17 07:26:56 2025 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDD6E1AB34D for ; Thu, 20 Jun 2024 11:24:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718882695; cv=none; b=MMZFEwsANYoHE6jf13SMS31sNHxW0glD2l7JfNvHtHURmdRtVyRh3bhOs8V3ZCaxlc4Cj90Cl0x3ybd01FYe8j/8HKFFQJ2WLVp01QNkuAbW2WuJ1E/C2HAP8GnoTV4xDGF70mpu2kdpGk2tw2MNXlt/LmMqPginlrZEo87uCG8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718882695; c=relaxed/simple; bh=Xq7Y5OxTOhqlbSsF4ClvHT17sw2kze9goC5POMsbHvM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aGPcA2HfOcEtdSIkW8VzeVzTq+JOAFjnh6IXFI+2zhwOBxygN6H9p4rtjdmedZKc/rje541lH8ygMjzT+V1iGq06rpSDWJbU0L5dzqlAsnUz9dj7RR/r6l5//Lp+jDIwfZgP0C7tPrG7DTDqJp8OsIBh+c9W+KIOrrgzHuFg92w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=E5vT/r8o; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E5vT/r8o" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4218180a122so6040855e9.1 for ; Thu, 20 Jun 2024 04:24:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718882692; x=1719487492; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GTdnj0h4hO88f5E9a81SRTfb2IoRwa/RVBQI7iSQd1U=; b=E5vT/r8oLipiL+q35t4z3mjIDird5oNvwqko1UUwxd6NDfZgMUYNyGcCuMy5Yb9/lY TX7hAISu8Xpql0uilLrAJvJA5Acodttck+aDlniBjaSasLEjh71V38Gr4HDfVAFKpfie dVaUvheFCZvBlx47MWnziF+UZd9CtuK+bE8p9oP2neJez4q72IfIphD7dB+CS8TMxgwB pkTOhXHWgDxXE7ZC+Ify6EQo6FygGXyzlLy2hCv2nNllyGqhIYtDexhFH5LKvuEs3rOg uJk4AVkVSUeqdW8RJUoIslHHCF71cgGdQlii9lGn50oWU1yfwDjxumLTXIMGF11UkddP vHDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718882692; x=1719487492; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GTdnj0h4hO88f5E9a81SRTfb2IoRwa/RVBQI7iSQd1U=; b=EuZgjDPpjwFdo+0knuQRLd4ASjau8i3CDz4XVx/llUlt6brSBZG+WtjcqdJ0E5drU0 hBNMMaYTNMzVpBk0NvcgYZ/OjQkDXJWYlFJKefbLMZeJ3aN3LpcMSMjYVuwB+gaDTfUo YnVP7o9kbR8wWVUrJusk2cbBH2GUrl2KUqp52V7r3G5G86zHynLWPcvGE+uOo/gcSkrx VzJNLd0SkB6bfNLcyybr1/u6xlzueoefEi5R7XL1txN6Qd9qZ4p5t2PZY23SCbQ+QraD 3DGUy2M49FUKZiRkb8s9m9nH/qSsrhA9mCvOX2n1mQhCEjHKtZB79jjwUJ3u1aLyfIDF DhUw== X-Forwarded-Encrypted: i=1; AJvYcCXzZBoL58ihUfpdYQFyVMrgUs4bewKmVPuLuetOP1wmDcIg70E+KcWVzeZJHgpCde51jWny7iFCBAXDcaINR3BiS7CPoXn2zICT+tH4 X-Gm-Message-State: AOJu0YziQfrCZh2d+b64mrIoyg0FnzmBAPUAfM840G+agXE29FOavmLE 47EZj2Ru+ibLZUu33fvPM4eyRI0kqvcD+bMxpqEst4jAJaBMdJw49OXz3j5panQ= X-Google-Smtp-Source: AGHT+IG0bmj/clv7a657zIPzp9MmvrFRbSd49FscT10OF1XmC+kRwLR3I33eOqChc4j25jNWe1YVvw== X-Received: by 2002:a5d:4687:0:b0:360:7c63:53cf with SMTP id ffacd0b85a97d-363177a1dcamr3799891f8f.19.1718882692152; Thu, 20 Jun 2024 04:24:52 -0700 (PDT) Received: from gpeter-l.lan ([2a0d:3344:2e8:8510::3aa]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3647bf3092csm2025371f8f.97.2024.06.20.04.24.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 04:24:51 -0700 (PDT) From: Peter Griffin To: lee@kernel.org, arnd@arndb.de, krzk@kernel.org, alim.akhtar@samsung.com Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, semen.protsenko@linaro.org, kernel-team@android.com, Peter Griffin Subject: [PATCH v2 2/2] soc: samsung: exynos-pmu: update to use of_syscon_register_regmap() Date: Thu, 20 Jun 2024 12:24:46 +0100 Message-ID: <20240620112446.1286223-3-peter.griffin@linaro.org> X-Mailer: git-send-email 2.45.2.627.g7a2c4fd464-goog In-Reply-To: <20240620112446.1286223-1-peter.griffin@linaro.org> References: <20240620112446.1286223-1-peter.griffin@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For SoCs like gs101 that need a special regmap, register this with of_syscon_register_regmap api, so it can be returned by syscon_regmap_lookup_by_phandle() and friends. For SoCs that don't require a custom regmap, revert back to syscon creating the mmio regmap rather than duplicating the logic here. exynos_get_pmu_regmap_by_phandle() api is also updated to retrieve the regmap via syscon. The exynos_get_pmu_regmap_by_phandle() api is kept around until fw_devlink support for syscon property is added for the pinctrl-samsung driver that also runs at postcore_initcall level. All other exynos client drivers can revert back to syscon_regmap_lookup_by_phandle(). Signed-off-by: Peter Griffin Reviewed-by: Arnd Bergmann Reviewed-by: Sam Protsenko --- Changes since v1: - pass pmu_np (not np) to syscon_node_to_regmap() (reported by William) Link to v1: https://lore.kernel.org/linux-arm-kernel/20240614140421.3172674= -3-peter.griffin@linaro.org/ --- drivers/soc/samsung/exynos-pmu.c | 38 ++++++++++++-------------------- 1 file changed, 14 insertions(+), 24 deletions(-) diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-= pmu.c index fd8b6ac06656..624324f4001c 100644 --- a/drivers/soc/samsung/exynos-pmu.c +++ b/drivers/soc/samsung/exynos-pmu.c @@ -204,16 +204,6 @@ static const struct regmap_config regmap_smccfg =3D { .reg_update_bits =3D tensor_sec_update_bits, }; =20 -static const struct regmap_config regmap_mmiocfg =3D { - .name =3D "pmu_regs", - .reg_bits =3D 32, - .reg_stride =3D 4, - .val_bits =3D 32, - .fast_io =3D true, - .use_single_read =3D true, - .use_single_write =3D true, -}; - static const struct exynos_pmu_data gs101_pmu_data =3D { .pmu_secure =3D true }; @@ -290,7 +280,6 @@ EXPORT_SYMBOL_GPL(exynos_get_pmu_regmap); struct regmap *exynos_get_pmu_regmap_by_phandle(struct device_node *np, const char *propname) { - struct exynos_pmu_context *ctx; struct device_node *pmu_np; struct device *dev; =20 @@ -316,9 +305,7 @@ struct regmap *exynos_get_pmu_regmap_by_phandle(struct = device_node *np, if (!dev) return ERR_PTR(-EPROBE_DEFER); =20 - ctx =3D dev_get_drvdata(dev); - - return ctx->pmureg; + return syscon_node_to_regmap(pmu_np); } EXPORT_SYMBOL_GPL(exynos_get_pmu_regmap_by_phandle); =20 @@ -355,19 +342,22 @@ static int exynos_pmu_probe(struct platform_device *p= dev) regmap =3D devm_regmap_init(dev, NULL, (void *)(uintptr_t)res->start, &pmu_regmcfg); + + if (IS_ERR(regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(regmap), + "regmap init failed\n"); + + ret =3D of_syscon_register_regmap(dev->of_node, regmap); + if (ret) + return ret; } else { - /* All other SoCs use a MMIO regmap */ - pmu_regmcfg =3D regmap_mmiocfg; - pmu_regmcfg.max_register =3D resource_size(res) - - pmu_regmcfg.reg_stride; - regmap =3D devm_regmap_init_mmio(dev, pmu_base_addr, - &pmu_regmcfg); + /* let syscon create mmio regmap */ + regmap =3D syscon_node_to_regmap(dev->of_node); + if (IS_ERR(regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(regmap), + "syscon_node_to_regmap failed\n"); } =20 - if (IS_ERR(regmap)) - return dev_err_probe(&pdev->dev, PTR_ERR(regmap), - "regmap init failed\n"); - pmu_context->pmureg =3D regmap; pmu_context->dev =3D dev; =20 --=20 2.45.2.627.g7a2c4fd464-goog