From nobody Wed Dec 17 00:18:29 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EE51365; Thu, 20 Jun 2024 00:11:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718842266; cv=none; b=NwP6kDAcpFW7yytOPSL/2PYiANI+ho0/q7XU6DcV2w1RWILOUWiKgpl3FJliort9SPCb7dgY52xsdOdS2GxWuMDRQg8UoCFDibTpaPZ0juojgY4btdEgDbi+Ehj333kinl+bwSnk+YMONOoJILJ2/JuZsuTgSpHiJsiU9X8k6V4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718842266; c=relaxed/simple; bh=u4PrA9HJiG+Ew0eD/qifHzsRxivvCZdkuwxWVHAcCbI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CvhNbFKmJjKbapRd8ATyu9NnsGryIHtkWrRJczUITnck0CKx4L4e9v+AZWr5SZ3EvkpJlB8HESH68zyD6olPQHDkATcnIxOartQSW/5nwKANUFvAgtfNgc3484NZFq8OBr/IrOh04EaAqsEWSXv/fK5ZDMmMJJT4eJskoJVPkWI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=MRhVHfcS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="MRhVHfcS" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45JALiRK023156; Thu, 20 Jun 2024 00:10:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +CsNH6WhWqlQOHkcV8o/A/l5euMhtvt2OZiz460XFT8=; b=MRhVHfcSTS3fQ1DF WL/au5Wu+aMZzqdDbxOa94Ux731IEKFOOQsNlATvXJLBZ/KpCB+RPik/0lRpzIIq b1sxUkPKSZkPxMvCu1YDQHzwOK1xwyl6bQB9hAoVJluWrdg1oYnlIIQHb9iASESr naEDv2tsJsRmgxEvY5y9aYa1gh0I16jXCAsFHnd3A1qT1P3eXr4n+T2nU7tjZTa0 z3/Z9tWtYUiQ6Qxt6urxD44XzN6YoDJCMVa7ax3eLFKeSvyBRBkXgmaJKfwAJ3SP QCIQUOGTCXZbLsJCJ439+F2HJas/g6daB/ALkQKD0MwRFS6SD/CKeN4L3m2m94pU VWBYPA== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3yuj9x3283-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Jun 2024 00:10:47 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA03.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 45K0Ak5K019691 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Jun 2024 00:10:46 GMT Received: from hu-obabatun-lv.qualcomm.com (10.49.16.6) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 19 Jun 2024 17:10:43 -0700 From: Oreoluwa Babatunde To: CC: , , , , , , , , , , , , , , Subject: [PATCH v2] of: reserved_mem: Restructure code to call reserved mem init functions earlier Date: Wed, 19 Jun 2024 17:10:27 -0700 Message-ID: <20240620001027.2326275-1-quic_obabatun@quicinc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <202406181626.126X1Nbz-lkp@intel.com> References: <202406181626.126X1Nbz-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: nalasex01b.na.qualcomm.com (10.47.209.197) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: vAiifgyVNjlZhb9Q62jOPFCYsXQXTOph X-Proofpoint-GUID: vAiifgyVNjlZhb9Q62jOPFCYsXQXTOph X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-19_02,2024-06-19_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=999 impostorscore=0 priorityscore=1501 suspectscore=0 mlxscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 bulkscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406200000 Content-Type: text/plain; charset="utf-8" After all the reserved memory regions have been added to the reserved_mem array, a region specific initialization function is called on each of reserved memory regions in a loop to initialize them. With recent changes made to allow the reserved_mem array be dynamically allocated, the cma reserved memory regions are not initialized until after the page tables are setup. This causes the warning seen in the dump stack below: WARNING: CPU: 0 PID: 1 at mm/memory.c:2789 __apply_to_page_range+0x360/0x3= 80 CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.10.0-rc1-00007-ga46cccb0ee2d #1 Hardware name: Generic DT based system Call trace: unwind_backtrace from show_stack+0x18/0x1c show_stack from dump_stack_lvl+0x54/0x68 dump_stack_lvl from __warn+0x74/0x114 __warn from warn_slowpath_fmt+0x13c/0x1c0 warn_slowpath_fmt from __apply_to_page_range+0x360/0x380 __apply_to_page_range from apply_to_page_range+0x24/0x2c apply_to_page_range from __alloc_from_contiguous+0xc4/0x158 __alloc_from_contiguous from cma_allocator_alloc+0x3c/0x44 cma_allocator_alloc from arch_dma_alloc+0x128/0x2b4 arch_dma_alloc from dma_alloc_attrs+0x90/0x150 dma_alloc_attrs from drm_gem_dma_create+0xa4/0x13c drm_gem_dma_create from drm_gem_dma_create_with_handle+0x24/0xac drm_gem_dma_create_with_handle from drm_gem_dma_dumb_create+0x44/0x50 drm_gem_dma_dumb_create from drm_client_framebuffer_create+0x9c/0x164 drm_client_framebuffer_create from drm_fbdev_dma_helper_fb_probe+0x84/0x23c drm_fbdev_dma_helper_fb_probe from __drm_fb_helper_initial_config_and_unlo= ck+0x2e4/0x4f8 __drm_fb_helper_initial_config_and_unlock from drm_fbdev_dma_client_hotplu= g+0x74/0xb8 drm_fbdev_dma_client_hotplug from drm_client_register+0x5c/0x98 drm_client_register from aspeed_gfx_probe+0x278/0x3c0 aspeed_gfx_probe from platform_probe+0x60/0xb8 platform_probe from really_probe+0xd4/0x3b4 really_probe from __driver_probe_device+0x90/0x1dc __driver_probe_device from driver_probe_device+0x38/0xd0 driver_probe_device from __driver_attach+0x118/0x1dc __driver_attach from bus_for_each_dev+0x84/0xd4 bus_for_each_dev from bus_add_driver+0xec/0x1f0 bus_add_driver from driver_register+0x84/0x11c driver_register from do_one_initcall+0x84/0x1c8 do_one_initcall from kernel_init_freeable+0x1a4/0x230 kernel_init_freeable from kernel_init+0x1c/0x138 kernel_init from ret_from_fork+0x14/0x28 Exception stack(0x9f015fb0 to 0x9f015ff8) 5fa0: 00000000 00000000 00000000 00000= 000 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000= 000 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 ---[ end trace 0000000000000000 ]--- aspeed_gfx 1e6e6000.display: [drm] fb0: aspeed-gfx-drmd frame buffer device Hence, restructure the code to initialize the regions as soon as each of them are added to the reserved_mem array. Fixes: a46cccb0ee2d ("of: reserved_mem: Restruture how the reserved memory = regions are processed") Signed-off-by: Oreoluwa Babatunde Tested-by: Nathan Chancellor --- v2: - Fix kernel-doc for of_init_reserved_mem_node() in response to the below warning from v1: https://lore.kernel.org/all/202406181626.126X1Nbz-lkp@intel.com/ v1: https://lore.kernel.org/all/20240617193357.3929092-1-quic_obabatun@quicin= c.com/ drivers/of/fdt.c | 2 +- drivers/of/of_private.h | 2 +- drivers/of/of_reserved_mem.c | 83 +++++++++++++++++++++--------------- 3 files changed, 50 insertions(+), 37 deletions(-) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index 9cde2abd2fc0..ea2dff0478c7 100644 --- a/drivers/of/fdt.c +++ b/drivers/of/fdt.c @@ -1239,7 +1239,7 @@ void __init unflatten_device_tree(void) unittest_unflatten_overlay_base(); =20 /* initialize the reserved memory regions */ - of_init_reserved_mem(); + of_scan_reserved_mem_reg_nodes(); } =20 /** diff --git a/drivers/of/of_private.h b/drivers/of/of_private.h index 01b33c4b1e9f..7412aed903df 100644 --- a/drivers/of/of_private.h +++ b/drivers/of/of_private.h @@ -181,7 +181,7 @@ static inline struct device_node *__of_get_dma_parent(c= onst struct device_node * #endif =20 int fdt_scan_reserved_mem(void); -void of_init_reserved_mem(void); +void of_scan_reserved_mem_reg_nodes(void); =20 bool of_fdt_device_is_available(const void *blob, unsigned long node); =20 diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c index eb54490a0a11..b31001728866 100644 --- a/drivers/of/of_reserved_mem.c +++ b/drivers/of/of_reserved_mem.c @@ -97,6 +97,8 @@ static void __init alloc_reserved_mem_array(void) reserved_mem =3D new_array; } =20 +static void __init of_init_reserved_mem_node(struct reserved_mem *rmem); + /* * of_reserved_mem_save_node() - save fdt node for second pass initializat= ion */ @@ -115,6 +117,12 @@ static void __init of_reserved_mem_save_node(struct de= vice_node *node, const cha rmem->base =3D base; rmem->size =3D size; =20 + /* + * Run the region specific initialization function for the rmem + * node. + */ + of_init_reserved_mem_node(rmem); + reserved_mem_count++; return; } @@ -201,6 +209,8 @@ static int __init __fdt_reserved_mem_check_root(unsigne= d long node) return 0; } =20 +static void __init __rmem_check_for_overlap(void); + /** * of_scan_reserved_mem_reg_nodes() - Store info for the "reg" defined * reserved memory regions. @@ -211,7 +221,7 @@ static int __init __fdt_reserved_mem_check_root(unsigne= d long node) * size are all stored in the reserved_mem array by calling the * of_reserved_mem_save_node() function. */ -static void __init of_scan_reserved_mem_reg_nodes(void) +void __init of_scan_reserved_mem_reg_nodes(void) { struct device_node *node, *child; phys_addr_t base, size; @@ -222,6 +232,13 @@ static void __init of_scan_reserved_mem_reg_nodes(void) return; } =20 + /* + * Before moving forward, allocate the exact size needed for the + * reserved_mem array and copy all previously saved contents + * into the new array if successful. + */ + alloc_reserved_mem_array(); + for_each_child_of_node(node, child) { int ret =3D 0; const char *uname; @@ -246,6 +263,8 @@ static void __init of_scan_reserved_mem_reg_nodes(void) if (size) of_reserved_mem_save_node(child, uname, base, size); } + /* check for overlapping reserved regions */ + __rmem_check_for_overlap(); } =20 static int __init __reserved_mem_alloc_size(unsigned long node, const char= *uname); @@ -526,44 +545,38 @@ static void __init __rmem_check_for_overlap(void) } =20 /** - * of_init_reserved_mem() - allocate and init all saved reserved memory re= gions + * of_init_reserved_mem_node() - Initialize a saved reserved memory region. + * @rmem: reserved_mem object of the memory region to be initialized. + * + * This function is used to call the region specific initialization + * function on the rmem object passed as an argument. The rmem object + * will contain the base address, size, node name, and device_node of + * the reserved memory region to be initialized. */ -void __init of_init_reserved_mem(void) +static void __init of_init_reserved_mem_node(struct reserved_mem *rmem) { - int i; - - alloc_reserved_mem_array(); - - of_scan_reserved_mem_reg_nodes(); + int err; + bool nomap; + struct device_node *node =3D rmem->dev_node; =20 - /* check for overlapping reserved regions */ - __rmem_check_for_overlap(); + nomap =3D of_property_present(node, "no-map"); =20 - for (i =3D 0; i < reserved_mem_count; i++) { - struct reserved_mem *rmem =3D &reserved_mem[i]; - struct device_node *node =3D rmem->dev_node; - int err =3D 0; - bool nomap; - - nomap =3D of_property_present(node, "no-map"); - - err =3D __reserved_mem_init_node(rmem); - if (err !=3D 0 && err !=3D -ENOENT) { - pr_info("node %s compatible matching fail\n", rmem->name); - if (nomap) - memblock_clear_nomap(rmem->base, rmem->size); - else - memblock_phys_free(rmem->base, rmem->size); - } else { - phys_addr_t end =3D rmem->base + rmem->size - 1; - bool reusable =3D of_property_present(node, "reusable"); - - pr_info("%pa..%pa (%lu KiB) %s %s %s\n", - &rmem->base, &end, (unsigned long)(rmem->size / SZ_1K), - nomap ? "nomap" : "map", - reusable ? "reusable" : "non-reusable", - rmem->name ? rmem->name : "unknown"); - } + err =3D __reserved_mem_init_node(rmem); + if (err !=3D 0 && err !=3D -ENOENT) { + pr_info("node %s compatible matching fail\n", rmem->name); + if (nomap) + memblock_clear_nomap(rmem->base, rmem->size); + else + memblock_phys_free(rmem->base, rmem->size); + } else { + phys_addr_t end =3D rmem->base + rmem->size - 1; + bool reusable =3D of_property_present(node, "reusable"); + + pr_info("%pa..%pa (%lu KiB) %s %s %s\n", + &rmem->base, &end, (unsigned long)(rmem->size / SZ_1K), + nomap ? "nomap" : "map", + reusable ? "reusable" : "non-reusable", + rmem->name ? rmem->name : "unknown"); } } =20 --=20 2.34.1